2022-05-12

<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<core-meetingbot> Meeting started Thu May 12 19:01:15 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] jonatack opened pull request #25120: test: fix DWARF string_view linker error in blockfilter_tests (master...fix-DWARF-string_view-linker-error) https://github.com/bitcoin/bitcoin/pull/25120
<bitcoin-git> [bitcoin] jonatack opened pull request #25119: net, refactor: move StartExtraBlockRelayPeers() from header to implementation (master...move-StartExtraBlockRelayPeers-from-header-to-implementation) https://github.com/bitcoin/bitcoin/pull/25119
<bitcoin-git> [bitcoin] furszy opened pull request #25118: wallet: unify “allow/block other inputs“ concept (master...2022_coinControl_unify_allowOtherInputs) https://github.com/bitcoin/bitcoin/pull/25118
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
<bitcoin-git> [bitcoin] theStack opened pull request #25115: scripted-diff: replace non-standard fixed width integer types (`u_int`... - `uint`...) (master...202205-refactor-replace_non_std_fixed_width_integer_types) https://github.com/bitcoin/bitcoin/pull/25115
<bitcoin-git> [bitcoin] fanquake closed pull request #21158: lib: Add Taproot support to libconsensus (master...libconsensus_taproot) https://github.com/bitcoin/bitcoin/pull/21158
<bitcoin-git> [bitcoin] fanquake closed pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
<bitcoin-git> [bitcoin] fanquake closed pull request #19880: fix CTxMemPool::TrimToSize to put only confirmed coins in pvNoSpendsRemaining (master...simplify-trimtosize) https://github.com/bitcoin/bitcoin/pull/19880
<bitcoin-git> [bitcoin] fanquake closed pull request #19358: torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service. (master...pr351-bitcoin) https://github.com/bitcoin/bitcoin/pull/19358
<bitcoin-git> [bitcoin] fanquake closed pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689
<bitcoin-git> [bitcoin] fanquake closed pull request #24293: (Refactor) QA: wallet_basic: Split wtx expected_fields over multiple lines to minimise merge conflicts (master...qa_wtx_expected_fields_lines) https://github.com/bitcoin/bitcoin/pull/24293
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #22871: Discourage CSV as NOP when locktime disable is set & discourage unknown nSequence (master...discourage-csv) https://github.com/bitcoin/bitcoin/pull/22871
<laanwj> see https://github.com/bitcoin/bitcoin/blob/master/src/qt/utilitydialog.cpp#L124 ; working around this means having to remove that functionality (and always print the help message to stdout), or a really ugly workaround complicating the already delicate initialization sequence even more
<laanwj> seems like a bug (though, there are various compromises with regard to bitcoin-qt initialization, that might make it necessary to initialize qt before showing the options/help, dunno)
<bitcoin-git> [bitcoin] theStack opened pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
<earnestly> Is it possible to generate the manuals without X11 (for bitcoin-qt)? It appears when using --version, I get 'qt.qpa.xcb: could not connect to display' and an IOT instruction abort
<bitcoin-git> [bitcoin] laanwj closed pull request #18427: Bugfix? Restore linking to libmingwthrd (master...2020mingwthrd) https://github.com/bitcoin/bitcoin/pull/18427
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25113: Bump univalue subtree (master...2205-uni-bump-🕌) https://github.com/bitcoin/bitcoin/pull/25113
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25102: Remove unused GetTimeSeconds (master...2205-no-GetTimeSeconds-😅) https://github.com/bitcoin/bitcoin/pull/25102
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3bab43329e7...dd9f61a184d4
<bitcoin-git> bitcoin/master fab9e8a MacroFake: Remove unused GetTimeSeconds
<bitcoin-git> bitcoin/master dd9f61a MacroFake: Merge bitcoin/bitcoin#25102: Remove unused GetTimeSeconds
<bitcoin-git> [bitcoin] fanquake merged pull request #25099: guix: bump time-machine to 998eda3067c7d21e0d9bb3310d2f5a14b8f1c681 (master...guix_time_machine_bump) https://github.com/bitcoin/bitcoin/pull/25099
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2a8e919ee07...e3bab43329e7
<bitcoin-git> bitcoin/master 298389e fanquake: guix: bump time-machine to 998eda3067c7d21e0d9bb3310d2f5a14b8f1c681
<bitcoin-git> bitcoin/master e3bab43 fanquake: Merge bitcoin/bitcoin#25099: guix: bump time-machine to 998eda3067c7d21e0d...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25112: util: Move error message formatting of NonFatalCheckError to cpp (master...2205-err-impl-🗡) https://github.com/bitcoin/bitcoin/pull/25112
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24925: refactor: make GetRand a template, remove GetRandInt (master...refactor-random-2) https://github.com/bitcoin/bitcoin/pull/24925
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51527ec1ec42...a2a8e919ee07
<bitcoin-git> bitcoin/master ab1ea29 pasta: refactor: make GetRand a template, remove GetRandInt
<bitcoin-git> bitcoin/master a2a8e91 MacroFake: Merge bitcoin/bitcoin#24925: refactor: make GetRand a template, remove Get...
<bitcoin-git> [bitcoin] luke-jr opened pull request #25111: Re-enable external signer support for Windows (master...hww_windows) https://github.com/bitcoin/bitcoin/pull/25111

2022-05-11

<sipa> bitcoin core is really intended to be able to connect to the network; if there are things it can do without, those should be moved (or at least made accessible) to utility binaries
<sipa> Yeah, that's fair. There really should be a utility binary that can do offline signing with all the features bitcoin core itself has.
<sipa> Earnestly: I don't think so. But why are you running bitcoin core in the first place then?
<bitcoin-git> [bitcoin] fanquake opened pull request #25110: tidy: use modernize-use-raw-string-literal (master...modernize_use_raw_string_literal) https://github.com/bitcoin/bitcoin/pull/25110
<bitcoin-git> [bitcoin] laanwj merged pull request #25051: Bugfix: configure: Define defaults for enable_arm_{crc,shani} (master...fix_configure_def_enable_arm_asms) https://github.com/bitcoin/bitcoin/pull/25051
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9db941d77374...51527ec1ec42
<bitcoin-git> bitcoin/master 51527ec laanwj: Merge bitcoin/bitcoin#25051: Bugfix: configure: Define defaults for enable...
<bitcoin-git> bitcoin/master 7fd0860 Luke Dashjr: Bugfix: configure: Define defaults for enable_arm_{crc,shani}
<bitcoin-git> [bitcoin] ajtowns opened pull request #25109: Strengthen AssertLockNotHeld assertions (master...202205-neg-anno-assertnotheld-only) https://github.com/bitcoin/bitcoin/pull/25109
<bitcoin-git> [bitcoin] fanquake opened pull request #25108: tidy: add modernize-use-default-member-init (master...modernize_use_default_Member_init) https://github.com/bitcoin/bitcoin/pull/25108
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25100: Switch scheduler to steady_clock (master...2205-sched_stead-🚵) https://github.com/bitcoin/bitcoin/pull/25100
<bitcoin-git> bitcoin/master fa90516 MacroFake: Switch scheduler to steady_clock
<bitcoin-git> bitcoin/master 9db941d MacroFake: Merge bitcoin/bitcoin#25100: Switch scheduler to steady_clock
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cca900e3820d...9db941d77374
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25104: wallet: Change log interval to use `steady_clock` (master...scan_wallet_clovk) https://github.com/bitcoin/bitcoin/pull/25104
<bitcoin-git> bitcoin/master cca900e MacroFake: Merge bitcoin/bitcoin#25104: wallet: Change log interval to use `steady_cl...
<bitcoin-git> bitcoin/master bdc6881 w0xlt: wallet: Change log interval to use `steady_clock`
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/27d7b11e8ce2...cca900e3820d
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25106: rpc: dumptxoutset: check `fopen` return code (master...202205-rpc-check_fopen_retval_in_dumptxoutset) https://github.com/bitcoin/bitcoin/pull/25106
<bitcoin-git> bitcoin/master 9feb887 Sebastian Falbesoner: rpc: check `fopen` return code in dumptxoutset
<bitcoin-git> bitcoin/master 27d7b11 MacroFake: Merge bitcoin/bitcoin#25106: rpc: dumptxoutset: check `fopen` return code
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8ded26ef3d7...27d7b11e8ce2
<bitcoin-git> [bitcoin] laanwj opened pull request #25107: bench: Add `--one-iteration` flag, use it in `make check` (master...2022-05-bench-one-iteration) https://github.com/bitcoin/bitcoin/pull/25107
<bitcoin-git> [bitcoin] theStack opened pull request #25106: rpc: dumptxoutset: check `fopen` return code (master...202205-rpc-check_fopen_retval_in_dumptxoutset) https://github.com/bitcoin/bitcoin/pull/25106
<bitcoin-git> [bitcoin] fanquake merged pull request #25090: doc: Explain Bitcoin Core instead of Bitcoin in README.md (master...2205-doc-intro-🥒) https://github.com/bitcoin/bitcoin/pull/25090
<bitcoin-git> bitcoin/master b8ded26 fanquake: Merge bitcoin/bitcoin#25090: doc: Explain Bitcoin Core instead of Bitcoin ...
<bitcoin-git> bitcoin/master faeb5b5 MacroFake: doc: Explain Bitcoin Core in README.md
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ed4eeafbb6e2...b8ded26ef3d7

2022-05-10

<bitcoin-git> [bitcoin] w0xlt opened pull request #25104: wallet: Change log interval to use `steady_clock` (master...scan_wallet_clovk) https://github.com/bitcoin/bitcoin/pull/25104
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #25033: add explicit condition fo master fingerprint to be lowercase hex (master...explicit_master_fp_str_encoding_in_docs) https://github.com/bitcoin/bitcoin/pull/25033
<gribble> https://github.com/bitcoin/bitcoin/issues/24924 | bench: Make WalletLoading benchmark run faster by achow101 · Pull Request #24924 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25102: Remove unused GetTimeSeconds (master...2205-no-GetTimeSeconds-😅) https://github.com/bitcoin/bitcoin/pull/25102
<bitcoin-git> [bitcoin] laanwj merged pull request #24793: test: Change color of skipped functional tests (master...change_skipped_test_color) https://github.com/bitcoin/bitcoin/pull/24793
<bitcoin-git> bitcoin/master 3258bad Jacob P. Fickes: changes color of skipped functional tests
<bitcoin-git> bitcoin/master ed4eeaf laanwj: Merge bitcoin/bitcoin#24793: test: Change color of skipped functional tests
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fb7c12c26f57...ed4eeafbb6e2
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25101: Add mockable clock type (master...2205-mock-clock-😃) https://github.com/bitcoin/bitcoin/pull/25101
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25100: Switch scheduler to steady_clock (master...2205-sched_stead-🚵) https://github.com/bitcoin/bitcoin/pull/25100
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24921: Add time helpers for std::chrono::steady_clock and FastRandomContext::rand_uniform_delay (master...2204-steady-clock-🎎) https://github.com/bitcoin/bitcoin/pull/24921
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/967654d0792f...fb7c12c26f57
<bitcoin-git> bitcoin/master fa4fb8d MarcoFalke: random: Add FastRandomContext::rand_uniform_delay
<bitcoin-git> bitcoin/master faa5c62 MarcoFalke: Add time helpers for std::chrono::steady_clock
<bitcoin-git> bitcoin/master fb7c12c MacroFake: Merge bitcoin/bitcoin#24921: Add time helpers for std::chrono::steady_cloc...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25079: index: Change sync variables to use `std::chrono::steady_clock` (master...base_index_chrono) https://github.com/bitcoin/bitcoin/pull/25079
<bitcoin-git> bitcoin/master 967654d MacroFake: Merge bitcoin/bitcoin#25079: index: Change sync variables to use `std::chr...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9219b233fdc...967654d0792f
<bitcoin-git> bitcoin/master 92b35ab w0xlt: index, refactor: Change sync variables to use `std::chrono::steady_clock`

2022-05-09

<bitcoin-git> [bitcoin] fanquake opened pull request #25099: guix: bump time-machine to 998eda3067c7d21e0d9bb3310d2f5a14b8f1c681 (master...guix_time_machine_bump) https://github.com/bitcoin/bitcoin/pull/25099
<bitcoin-git> bitcoin/master f70ee34 Hennadii Stepanov: qt, refactor: Declare `WalletModel` member functions with `const`
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3dd95cb5c291...b9219b233fdc
<bitcoin-git> bitcoin/master b9219b2 Hennadii Stepanov: Merge bitcoin-core/gui#590: refactor: Declare `WalletModel` member functio...
<bitcoin-git> [gui] hebasto merged pull request #590: refactor: Declare `WalletModel` member functions with `const` (master...220423-wm-const) https://github.com/bitcoin-core/gui/pull/590
<bitcoin-git> bitcoin/master 3dd95cb Hennadii Stepanov: Merge bitcoin-core/gui#591: test: Add tests for `tableView` in `AddressBoo...
<bitcoin-git> bitcoin/master 1506913 Hennadii Stepanov: qt, test: Add tests for `tableView` in `AddressBookPage` dialog
<bitcoin-git> bitcoin/master edae3ab Hennadii Stepanov: qt: No need to force Qt::QueuedConnection for NotifyAddressBookChanged
<bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a8098f2cef53...3dd95cb5c291
<bitcoin-git> [gui] hebasto merged pull request #591: test: Add tests for `tableView` in `AddressBookPage` dialog (master...220423-test-ab) https://github.com/bitcoin-core/gui/pull/591
<bitcoin-git> [bitcoin] david-bakin opened pull request #25097: Unit tests for taproot/tapscript coverage in `interpreter.cpp` (master...23279-taproot-unit-tests) https://github.com/bitcoin/bitcoin/pull/25097
<bitcoin-git> [bitcoin] dergoegge opened pull request #25096: [net] Minor improvements to addr caching (master...2022-05-improve-addr-cache) https://github.com/bitcoin/bitcoin/pull/25096
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25095: rpc: Fix implicit-integer-sign-change in gettxout (master...2205-rpc-int-ubsan-😛) https://github.com/bitcoin/bitcoin/pull/25095
<bitcoin-git> [bitcoin] hunglun closed pull request #25069: test: Add a new unit test for chain.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/25069
<bitcoin-git> [gui] furszy opened pull request #598: Avoid recalculating the wallet balance - use model cache (master...2022_GUI_use_model_cached_balance) https://github.com/bitcoin-core/gui/pull/598
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25093: rpc: Fix incorrect sendmany doc and check all docs (master...2205-doc-rpc-opt-🚈) https://github.com/bitcoin/bitcoin/pull/25093
<bitcoin-git> [bitcoin] jonatack opened pull request #25092: doc: various developer notes updates (master...developer-notes-updates-may-2022) https://github.com/bitcoin/bitcoin/pull/25092
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25091: test: Remove extended lint (cppcheck) (master...2022-05-remove-extended-lints) https://github.com/bitcoin/bitcoin/pull/25091
<bitcoin-git> bitcoin/master efae252 laanwj: test: Remove extended lint (cppcheck)
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dab18f03f725...a8098f2cef53
<bitcoin-git> bitcoin/master a8098f2 MacroFake: Merge bitcoin/bitcoin#25091: test: Remove extended lint (cppcheck)
<bitcoin-git> [bitcoin] laanwj opened pull request #25091: test: Remove extended lint (cppcheck) (master...2022-05-remove-extended-lints) https://github.com/bitcoin/bitcoin/pull/25091
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25090: doc: Explain Bitcoin Core in README.md (master...2205-doc-intro-🥒) https://github.com/bitcoin/bitcoin/pull/25090
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24946: Unroll the ChaCha20 inner loop for performance (master...202204_unrollchacha) https://github.com/bitcoin/bitcoin/pull/24946
<bitcoin-git> bitcoin/master dab18f0 MacroFake: Merge bitcoin/bitcoin#24946: Unroll the ChaCha20 inner loop for performance
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8abe79aedd0b...dab18f03f725
<bitcoin-git> bitcoin/master 81c09ee Pieter Wuille: Unroll the ChaCha20 inner loop for performance
<gribble> https://github.com/bitcoin/bitcoin/issues/24150 | refactor: move index class members from protected to private by jonatack · Pull Request #24150 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25078: doc: Shorten explanation of "maintainers" (master...2205-doc-lead-🛴) https://github.com/bitcoin/bitcoin/pull/25078
<bitcoin-git> bitcoin/master fa32ced MacroFake: doc: Shorten explanation of "maintainers"
<bitcoin-git> bitcoin/master 8abe79a fanquake: Merge bitcoin/bitcoin#25078: doc: Shorten explanation of "maintainers"
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59ac8bacd573...8abe79aedd0b
<bitcoin-git> [bitcoin] luke-jr opened pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088

2022-05-08

<bitcoin-git> [bitcoin] theStack opened pull request #25087: test: use MiniWallet for feature_dbcrash.py (master...202205-test-use_MiniWallet_for_feature_dbcrash) https://github.com/bitcoin/bitcoin/pull/25087
<bitcoin-git> [bitcoin] hebasto closed pull request #25086: bitcoin (master...22.x-knots) https://github.com/bitcoin/bitcoin/pull/25086
<bitcoin-git> [bitcoin] DIGITALMININGOP opened pull request #25086: bitcoin (master...22.x-knots) https://github.com/bitcoin/bitcoin/pull/25086
<bitcoin-git> [bitcoin] uJhin closed pull request #25084: Optimization Icon Images (master...master) https://github.com/bitcoin/bitcoin/pull/25084
<bitcoin-git> [bitcoin] uJhin opened pull request #25084: Optimization Icon Images (master...master) https://github.com/bitcoin/bitcoin/pull/25084

2022-05-07

<bitcoin-git> [bitcoin] ishaanam opened pull request #25083: Set effective_value when initializing a COutput (master...draft-CalculateEffectiveValue2) https://github.com/bitcoin/bitcoin/pull/25083
<bitcoin-git> [bitcoin] martinus opened pull request #25081: tracing: lock contention analysis (master...2022-05-lock-tracking-2) https://github.com/bitcoin/bitcoin/pull/25081

2022-05-06

<bitcoin-git> [bitcoin] w0xlt opened pull request #25079: index: Change sync interval variables to std::chrono::seconds (master...base_index_chrono) https://github.com/bitcoin/bitcoin/pull/25079
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25078: doc: Shorten explanation of "maintainers" (master...2205-doc-lead-🛴) https://github.com/bitcoin/bitcoin/pull/25078
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25077: Fix chain tip data race and corrupt rest response (master...2205-tip-race-🤠) https://github.com/bitcoin/bitcoin/pull/25077
<bitcoin-git> [bitcoin] fanquake opened pull request #25076: guix: native GCC 10 toolchain for Linux builds (master...native_gcc_10_linux) https://github.com/bitcoin/bitcoin/pull/25076
<bitcoin-git> [bitcoin] mzumsande opened pull request #25074: index: During sync, commit best block after indexing (master...202205_index_sync_order) https://github.com/bitcoin/bitcoin/pull/25074
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25073: test: Cleanup miner_tests (master...2205-test-miner-😊) https://github.com/bitcoin/bitcoin/pull/25073
<bitcoin-git> [bitcoin] fanquake closed pull request #22919: fees: skip pointless fee parameter calculation during IBD (master...lazy_update) https://github.com/bitcoin/bitcoin/pull/22919
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24804: Sanity assert GetAncestor() != nullptr where appropriate (master...assert_get_ancestor_rebase) https://github.com/bitcoin/bitcoin/pull/24804
<bitcoin-git> bitcoin/master 308dd2e Adam Jonas: Sanity assert GetAncestor() != nullptr where appropriate
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77a9997d97f9...59ac8bacd573
<bitcoin-git> bitcoin/master 59ac8ba MacroFake: Merge bitcoin/bitcoin#24804: Sanity assert GetAncestor() != nullptr where ...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25063: test: previous releases: add v23.0 (master...2022/05/add_previous_release) https://github.com/bitcoin/bitcoin/pull/25063
<bitcoin-git> bitcoin/master dba1231 Sjors Provoost: test: previous releases: add v23.0
<bitcoin-git> bitcoin/master 77a9997 MacroFake: Merge bitcoin/bitcoin#25063: test: previous releases: add v23.0
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b557a24be931...77a9997d97f9
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #22440: Eliminate Signature Checker/Creator Ambiguity w/ LIFETIMEBOUND References (master...lifetimeboundcheckers) https://github.com/bitcoin/bitcoin/pull/22440
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #19426: refactor: Change * to & in MutableTransactionSignatureCreator (master...2007-refactorSign) https://github.com/bitcoin/bitcoin/pull/19426
<bitcoin-git> bitcoin/master fac6cfc MarcoFalke: refactor: Change * to & in MutableTransactionSignatureCreator
<bitcoin-git> bitcoin/master b557a24 MacroFake: Merge bitcoin/bitcoin#19426: refactor: Change * to & in MutableTransaction...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b2e7811c6288...b557a24be931
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24538: miner: bug fix? update for ancestor inclusion using modified fees, not base (master...2022-03-miner-prioritised) https://github.com/bitcoin/bitcoin/pull/24538
<bitcoin-git> bitcoin/master 0f9a444 glozow: MOVEONLY: group miner tests into MinerTestingSetup functions
<bitcoin-git> bitcoin/master e4303c3 glozow: [unit test] prioritisation in mining
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/74d9f4bd950f...b2e7811c6288
<bitcoin-git> bitcoin/master 7a8d606 glozow: [miner] bug fix: update for parent inclusion using modified fee
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25068: Wrap boost::replace_all (master...2205-util-string-📉) https://github.com/bitcoin/bitcoin/pull/25068
<bitcoin-git> bitcoin/master 74d9f4b MacroFake: Merge bitcoin/bitcoin#25068: Wrap boost::replace_all
<bitcoin-git> bitcoin/master fa2deae MacroFake: Wrap boost::replace_all
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/460450836304...74d9f4bd950f
<bitcoin-git> [bitcoin] Crypt-iQ closed pull request #25071: test: remove unused BasicTestingSetup from sock_tests (master...socktests_setup) https://github.com/bitcoin/bitcoin/pull/25071
<bitcoin-git> [bitcoin] Crypt-iQ opened pull request #25071: test: remove unused BasicTestingSetup from sock_tests (master...socktests_setup) https://github.com/bitcoin/bitcoin/pull/25071

2022-05-05

<jonatack> The "Safer Usage Of C++" document mentioned by MarcoFalke in https://github.com/bitcoin/bitcoin/issues/20493#issuecomment-1113589139, and in particular the "Annotate Lifetimes" section, seems quite good.
<bitcoin-git> [bitcoin] Crypt-iQ closed pull request #24901: mempool: reduce lookups, insertions to cache in UpdateForDescendants (master...mempool_desc_patch) https://github.com/bitcoin/bitcoin/pull/24901
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<gribble> https://github.com/bitcoin/bitcoin/issues/22278 | Add LIFETIMEBOUND to CScript where needed by MarcoFalke · Pull Request #22278 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/20493 | lifetimebound compile attribute · Issue #20493 · bitcoin/bitcoin · GitHub
<jonatack> I don't think it's too bad, see https://github.com/bitcoin/bitcoin/pull/25060/files for an example
<gribble> https://github.com/bitcoin/bitcoin/issues/20493 | lifetimebound compile attribute · Issue #20493 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24836 | add RPC (-regtest only) for testing package policy by glozow · Pull Request #24836 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25038 | BIP125-based Package RBF by glozow · Pull Request #25038 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24836 | add RPC (-regtest only) for testing package policy by glozow · Pull Request #24836 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23662 | rpc: improve `getreceivedby{address,label}` performance by theStack · Pull Request #23662 · bitcoin/bitcoin · GitHub
<laanwj> there's 12 blockers and 1 labaled chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<core-meetingbot> Meeting started Thu May 5 19:01:17 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<gribble> https://github.com/bitcoin/bitcoin/issues/24058 | BIP-322 basic support by kallewoof · Pull Request #24058 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25070: contrib: fix dirname on `verify-commits` (master...2022-05-ci-fix) https://github.com/bitcoin/bitcoin/pull/25070
<bitcoin-git> bitcoin/master 4604508 fanquake: Merge bitcoin/bitcoin#25070: contrib: fix dirname on `verify-commits`
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4478d312f90...460450836304
<bitcoin-git> bitcoin/master ded915e brunoerg: contrib: fix dirname on `verify-commits`
<bitcoin-git> [bitcoin] brunoerg opened pull request #25070: contrib: fix dirname on `verify-commits` (master...2022-05-ci-fix) https://github.com/bitcoin/bitcoin/pull/25070
<gribble> https://github.com/bitcoin/bitcoin/issues/24993 | test, contrib, refactor: use `with` when opening a file by brunoerg · Pull Request #24993 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #25006: guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported (master...specify_minimum_kernel) https://github.com/bitcoin/bitcoin/pull/25006
<bitcoin-git> bitcoin/master eb02713 fanquake: doc: add minimum required kernel version to dependencies.md
<bitcoin-git> bitcoin/master e4478d3 fanquake: Merge bitcoin/bitcoin#25006: guix: consolidate kernel headers to 5.15, spe...
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c367736f85ac...e4478d312f90
<bitcoin-git> bitcoin/master dcad5f7 fanquake: guix: consolidate kernel headers to 5.15
<bitcoin-git> [bitcoin] hunglun opened pull request #25069: test: Add a new unit test for chain.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/25069
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
<bitcoin-git> bitcoin/master bd6ceb4 whiteh0rse: test: port 'lint-shell.sh' to python
<bitcoin-git> bitcoin/master c367736 MacroFake: Merge bitcoin/bitcoin#24840: test: port 'lint-shell.sh' to python
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cc1860b12a5...c367736f85ac
<sipa> They were already blocked on the bitcoin org; I also blocked them from the bitcoin-core org.
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25068: Wrap boost::replace_all (master...2205-util-string-📉) https://github.com/bitcoin/bitcoin/pull/25068
<bitcoin-git> [bitcoin] fanquake merged pull request #24566: build: Drop redundant checks for ranlib and strip tools (master...220314-conf) https://github.com/bitcoin/bitcoin/pull/24566
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ad5d5088d69...7cc1860b12a5
<bitcoin-git> bitcoin/master a0e2a31 Hennadii Stepanov: build: Drop redundant checks for ranlib and strip tools
<bitcoin-git> bitcoin/master 7cc1860 fanquake: Merge bitcoin/bitcoin#24566: build: Drop redundant checks for ranlib and s...
<bitcoin-git> [bitcoin] jonatack opened pull request #25067: validation, refactor: make MainSignalsInstance() a class, move to h (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
<bitcoin-git> [bitcoin] fanquake merged pull request #24866: build: No longer need to hack the `PATH` variable in `config.site` (master...220415-tools) https://github.com/bitcoin/bitcoin/pull/24866
<bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/0d080a183bfc...1ad5d5088d69
<bitcoin-git> bitcoin/master a4fd440 Hennadii Stepanov: build: Pass missed `strip` tool via `config.site`
<bitcoin-git> bitcoin/master f87594d Hennadii Stepanov: build: No need to provide defaults for darwin-specific tools
<bitcoin-git> bitcoin/master 80cd993 Hennadii Stepanov: scripted-diff: Rename INSTALLNAMETOOL -> INSTALL_NAME_TOOL
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d4475ea7ae70...0d080a183bfc
<bitcoin-git> bitcoin/master e71c51b Shashwat: refactor: rename command -> message type in comments in the src/net* files
<bitcoin-git> bitcoin/master 2b09593 Shashwat: scripted-diff: Rename message command to message type
<bitcoin-git> bitcoin/master 0d080a1 MacroFake: Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* ...

2022-05-04

<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Extract only what we use of `init/common.cpp` by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dongcarl opened pull request #25065: [kernel 2c/n] Extract only what we use of `init/common.cpp` (master...2022-03-libbitcoinkernel-initcommon) https://github.com/bitcoin/bitcoin/pull/25065
<bitcoin-git> [bitcoin] fanquake closed pull request #24969: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/24969
<bitcoin-git> [bitcoin] laanwj merged pull request #22235: script: add script to generate example bitcoin.conf (master...josibake-auto-generate-example-bitcoin-conf-file) https://github.com/bitcoin/bitcoin/pull/22235
<bitcoin-git> bitcoin/master 6aac946 Josiah Baker: doc: update bitcoin-conf.md
<bitcoin-git> bitcoin/master 1c7e820 josibake: script: add script to generate example bitcoin.conf
<bitcoin-git> bitcoin/master b483084 josibake: doc: replace bitcoin.conf with placeholder file
<bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/5e1aacab576b...d4475ea7ae70
<bitcoin-git> [bitcoin] laanwj merged pull request #24933: util: Replace non-threadsafe strerror (master...2022-04-strerror-threadsafe) https://github.com/bitcoin/bitcoin/pull/24933
<bitcoin-git> bitcoin/master 718da30 laanwj: util: Refactor SysErrorString logic
<bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fe6a299fc002...5e1aacab576b
<bitcoin-git> bitcoin/master 46971c6 laanwj: util: Replace non-threadsafe strerror
<bitcoin-git> bitcoin/master e7f2f77 laanwj: util: Use strerror_s for SysErrorString on Windows
<bitcoin-git> [bitcoin] laanwj merged pull request #24852: util: optimize HexStr (master...2022-03-HexStr-optimizations) https://github.com/bitcoin/bitcoin/pull/24852
<bitcoin-git> bitcoin/master 67c8411 Martin Leitner-Ankerl: test: Adds a test for HexStr that checks all 256 bytes
<bitcoin-git> bitcoin/master 4e2b99f Martin Leitner-Ankerl: bench: Adds a benchmark for HexStr
<bitcoin-git> bitcoin/master 5e61532 Martin Leitner-Ankerl: util: optimizes HexStr
<bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/33aaf434af27...fe6a299fc002
<bitcoin-git> [bitcoin] fanquake merged pull request #24976: netgroup: Follow-up for #22910 (master...2022-04-nStartByte-followup) https://github.com/bitcoin/bitcoin/pull/24976
<bitcoin-git> bitcoin/master 33aaf43 fanquake: Merge bitcoin/bitcoin#24976: netgroup: Follow-up for #22910
<bitcoin-git> bitcoin/master e5d1831 dergoegge: [netgroup] Use nStartByte as offset for the last byte of the group
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0047d9b89b9f...33aaf434af27
<bitcoin-git> [bitcoin] laanwj merged pull request #24993: test, contrib, refactor: use `with` when opening a file (master...2022-04-contrib-close-file) https://github.com/bitcoin/bitcoin/pull/24993
<bitcoin-git> bitcoin/master 027aab6 brunoerg: test, contrib, refactor: use `with` when opening a file
<bitcoin-git> bitcoin/master 0047d9b laanwj: Merge bitcoin/bitcoin#24993: test, contrib, refactor: use `with` when open...
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bde5836f9996...0047d9b89b9f
<bitcoin-git> [bitcoin] fanquake merged pull request #25057: refactor: replace remaining boost::split with SplitString (master...2022-04-boost-split-exorcism) https://github.com/bitcoin/bitcoin/pull/25057
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9183c66cc6ae...bde5836f9996
<bitcoin-git> bitcoin/master d1a9850 Martin Leitner-Ankerl: http: replace boost::split with SplitString
<bitcoin-git> bitcoin/master b7ab9db Martin Leitner-Ankerl: Extend Split to work with multiple separators
<bitcoin-git> bitcoin/master 0d7efcd Martin Leitner-Ankerl: core_read: Replace boost::split with SplitString
<gribble> https://github.com/bitcoin/bitcoin/issues/25064 | [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` by dongcarl · Pull Request #25064 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] dongcarl opened pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064
<bitcoin-git> [bitcoin] fanquake merged pull request #25046: build: Fix `libmultiprocess` cross-compiling to Linux hosts (master...220501-mp-cross) https://github.com/bitcoin/bitcoin/pull/25046
<bitcoin-git> bitcoin/master 9183c66 fanquake: Merge bitcoin/bitcoin#25046: build: Fix `libmultiprocess` cross-compiling ...
<bitcoin-git> bitcoin/master c0f5cc1 Hennadii Stepanov: build: Fix `libmultiprocess` cross-compiling to Linux hosts
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d17bbc3c484e...9183c66cc6ae
<bitcoin-git> [bitcoin] dongcarl closed pull request #24456: blockman: Properly guard blockfile members (master...2022-02-kirby-p4) https://github.com/bitcoin/bitcoin/pull/24456
<bitcoin-git> [bitcoin] Sjors opened pull request #25063: test: previous releases: add v23.0 (master...2022/05/add_previous_release) https://github.com/bitcoin/bitcoin/pull/25063
<gribble> https://github.com/bitcoin/bitcoin/issues/24921 | Add time helpers for std::chrono::steady_clock and FastRandomContext::rand_uniform_delay by MarcoFalke · Pull Request #24921 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19426: refactor: Change * to & in MutableTransactionSignatureCreator (master...2007-refactorSign) https://github.com/bitcoin/bitcoin/pull/19426
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25060: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time (master...add-LIFETIMEBOUND-to-GetFirstStoredBlock-start_time) https://github.com/bitcoin/bitcoin/pull/25060
<bitcoin-git> bitcoin/master d17bbc3 MacroFake: Merge bitcoin/bitcoin#25060: blockstorage: add LIFETIMEBOUND to GetFirstSt...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c290249fff81...d17bbc3c484e
<bitcoin-git> bitcoin/master 4cb9d21 Jon Atack: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time
<bitcoin-git> [bitcoin] fanquake closed pull request #23035: p2p, rpc, test: expose tried and refcount in getnodeaddresses, update/improve tests (master...getnodeaddresses-tried-and-reference_count) https://github.com/bitcoin/bitcoin/pull/23035
<bitcoin-git> [bitcoin] fanquake merged pull request #25058: rpc: Move output script RPCs to separate file, rename misc.cpp (master...2205-rpc-out-script-📂) https://github.com/bitcoin/bitcoin/pull/25058
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/14cb53dfe95e...c290249fff81
<bitcoin-git> bitcoin/master fa758f9 MacroFake: scripted-diff: Rename rpc/misc.cpp to rpc/node.cpp
<bitcoin-git> bitcoin/master fa87eb8 MacroFake: rpc: Move output script RPCs to separate file
<bitcoin-git> bitcoin/master c290249 fanquake: Merge bitcoin/bitcoin#25058: rpc: Move output script RPCs to separate file...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient (master...2204-sched-🔭) https://github.com/bitcoin/bitcoin/pull/25040
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b42d62f426f...14cb53dfe95e
<bitcoin-git> bitcoin/master fa4652c MacroFake: Pass lifetimebound reference to SingleThreadedSchedulerClient
<bitcoin-git> bitcoin/master 14cb53d MacroFake: Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to Sin...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25045: test: add coverage for invalid requests for `blockfilterheaders` (REST) (master...2022-04-invalid-blockfilterheaders) https://github.com/bitcoin/bitcoin/pull/25045
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/880cec91fab1...9b42d62f426f
<bitcoin-git> bitcoin/master d1bfe5e brunoerg: test: add coverage for invalid requests for `blockfilterheaders`
<bitcoin-git> bitcoin/master 9b42d62 MacroFake: Merge bitcoin/bitcoin#25045: test: add coverage for invalid requests for `...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25047: tidy: add readability-redundant-declaration (master...tidy_redundant_externs) https://github.com/bitcoin/bitcoin/pull/25047
<bitcoin-git> bitcoin/master 880cec9 MacroFake: Merge bitcoin/bitcoin#25047: tidy: add readability-redundant-declaration
<bitcoin-git> bitcoin/master c2b2958 fanquake: tidy: add readability-redundant-declaration
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12455acca2c3...880cec91fab1

2022-05-03

<merlin_moci47> - How many members of Bitcoin Core have to agree for Bob to get invited?
<merlin_moci47> Actually I was thinking about a hypothetical social engineering scenario. Suppose Bob likes ethereum and Bob is in love with Alice. However, Alice wants to marry a member of Bitcoin Core because she wants her Kids to become real cypherpunks. How can Bob get Alice while minimising his effort?
<bitcoin-git> [bitcoin] jonatack opened pull request #25060: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time (master...add-LIFETIMEBOUND-to-GetFirstStoredBlock-start_time) https://github.com/bitcoin/bitcoin/pull/25060
<jonatack> merlin_moci: if you have the knack and work at it consistently over time, it may be possible, or at least, not impossible? enjoying the process, the concepts, the code, the challenge, and having a deep desire to help bitcoin, and people, and your fellow contributors...might be some viable motivations for doing it over the long term...just an
<merlin_moci> Can you make good-quality code reviews and become a member of bitcoin-core without being a developer?
<jonatack> merlin_moci: it's possible to learn! participate in https://bitcoincore.reviews, apply for the chaincode labs seminars, and see (for instance) https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core for more info
<merlin_moci> Who decides to add new people to the bitcoin-core organisation on Github?
<merlin_moci> Who decides to add new people to the bitcoin-core organisation on Github?
<bytes1440000> How are people added to this github org? https://github.com/orgs/bitcoin-core/people
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24470: Disallow more unsafe string-path conversions allowed by path append operators (master...pr/patha) https://github.com/bitcoin/bitcoin/pull/24470
<bitcoin-git> bitcoin/master 12455ac MacroFake: Merge bitcoin/bitcoin#24470: Disallow more unsafe string->path conversions...
<bitcoin-git> bitcoin/master f64aa9c Ryan Ofsky: Disallow more unsafe string->path conversions allowed by path append opera...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64d2715533b5...12455acca2c3
<bitcoin-git> [bitcoin] fanquake merged pull request #25053: Guard `#include config/bitcoin-config.h` (master...220502-config) https://github.com/bitcoin/bitcoin/pull/25053
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d24318a40cad...64d2715533b5
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24941: test: MiniWallet: support skipping mempool checks (feature_fee_estimation.py performance fix) (master...202204-test-MiniWallet-support_creating_txs_without_mempool_checks) https://github.com/bitcoin/bitcoin/pull/24941
<bitcoin-git> bitcoin/master d24318a MacroFake: Merge bitcoin/bitcoin#24941: test: MiniWallet: support skipping mempool ch...
<bitcoin-git> bitcoin/master 01552e8 Sebastian Falbesoner: test: MiniWallet: always rehash after signing (P2PK mode)
<bitcoin-git> bitcoin/master a498acc Sebastian Falbesoner: test: MiniWallet: skip mempool check if `mempool_valid=False`
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2c56404088f7...d24318a40cad
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25058: rpc: Move output script RPCs to separate file, rename misc.cpp (master...2205-rpc-out-script-📂) https://github.com/bitcoin/bitcoin/pull/25058
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25029: rpc: Move fee estimation RPCs to separate file (master...2204-rpc-fees-😊) https://github.com/bitcoin/bitcoin/pull/25029
<bitcoin-git> bitcoin/master fa753ab MacroFake: rpc: Move fee estimation RPCs to separate file
<bitcoin-git> bitcoin/master 2c56404 MacroFake: Merge bitcoin/bitcoin#25029: rpc: Move fee estimation RPCs to separate fil...
<bitcoin-git> Can be reviewed with --col...
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/037c5e511fe2...2c56404088f7
<bitcoin-git> [bitcoin] martinus opened pull request #25057: refactor: replace remaining boost::split with StringSplit (master...2022-04-boost-split-exorcism) https://github.com/bitcoin/bitcoin/pull/25057

2022-05-02

<Murch> A few weeks ago I was trying to follow a Bitcoin PR Review Club but got only one in a dozen messages on Matrix
<bitcoin-git> [bitcoin] laanwj merged pull request #25042: lint: Fix lint-circular-dependencies.py file list (master...2204-lint-circ-🚄) https://github.com/bitcoin/bitcoin/pull/25042
<bitcoin-git> [bitcoin] hebasto opened pull request #25053: Guard `#include config/bitcoin-config.h` (master...220502-config) https://github.com/bitcoin/bitcoin/pull/25053
<bitcoin-git> bitcoin/master fad0abf MacroFake: lint: Fix lint-circular-dependencies.py file list