2020-11-19

< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/71d068db4058...7aa94569ce1a
< bitcoin-git> bitcoin/master ea93bbe practicalswift: init: Fix incorrect warning "Reducing -maxconnections from N to N-1, becau...
< MarcoFalke> Anyone mind to ACK https://github.com/bitcoin-core/univalue/pull/24 ?
< Kiminuo> hebasto, https://github.com/kiminuo/bitcoin/tree/feature/2020-11-19-replace-boost-filesystem-with-cpp17-filesystem could you possibly try that on Ubuntu 18.04, if you have one?
< Kiminuo> https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md - mentions that the lowest supported GCC version is 7.
< Kiminuo> https://stackoverflow.com/a/53531186 - It seems, you can compile Bitcoin codebase on Ubuntu 18.04 with std::filesystem only with GCC 8.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18531: rpc: remove deprecated CRPCCommand constructor (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git> bitcoin/master 71d068d MarcoFalke: Merge #18531: rpc: remove deprecated CRPCCommand constructor
< bitcoin-git> bitcoin/master fa19bb2 MarcoFalke: remove dead rpc code
< bitcoin-git> bitcoin/master faaf9c5 MarcoFalke: remove CRPCCommand constructor that takes rpcfn_type function pointer
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9ab9665c74dd...71d068db4058
< bitcoin-git> [bitcoin] laanwj merged pull request #15710: wallet: Catch ios_base::failure specifically (master...walletdb-readthrow) https://github.com/bitcoin/bitcoin/pull/15710
< bitcoin-git> bitcoin/master 9ab9665 Wladimir J. van der Laan: Merge #15710: wallet: Catch ios_base::failure specifically
< bitcoin-git> bitcoin/master 7486e27 Bushstar: Tests: Unit test related to WalletDB ReadKeyValue
< bitcoin-git> bitcoin/master 32def8d Peter Bushnell: Catch ios_base::failure specifically
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9180c50b689...9ab9665c74dd
< Kiminuo> MarcoFalke, Hi Marco, could you say whether it's worth working on std::fs at this time? You have, I think, mentioned that `std::fs` is not supported by some OSs. So I just want to know whether it makes sense to work on this or let it wait a few months or a few years for next upgrade (https://github.com/bitcoin/bitcoin/pull/19245#issuecomment-730291399)
< bitcoin-git> [bitcoin] laanwj merged pull request #20145: contrib: add getcoins.py script to get coins from (signet) faucet (master...202010-signet-getcoins) https://github.com/bitcoin/bitcoin/pull/20145
< bitcoin-git> bitcoin/master d9180c5 Wladimir J. van der Laan: Merge #20145: contrib: add getcoins.py script to get coins from (signet) f...
< bitcoin-git> bitcoin/master e9c8e6e Karl-Johan Alm: doc: add contrib/signet readme
< bitcoin-git> bitcoin/master 355d0c4 Karl-Johan Alm: contrib: add getcoins.py script to get coins from (signet) faucet
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1cc5e693c186...d9180c50b689
< bitcoin-git> [bitcoin] laanwj merged pull request #20358: src/randomenv.cpp: fix build on uclibc (master...master) https://github.com/bitcoin/bitcoin/pull/20358
< bitcoin-git> bitcoin/master 1cc5e69 Wladimir J. van der Laan: Merge #20358: src/randomenv.cpp: fix build on uclibc
< bitcoin-git> bitcoin/master 330cb33 Fabrice Fontaine: src/randomenv.cpp: fix build on uclibc
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fbb2bee82d83...1cc5e693c186
< bitcoin-git> [bitcoin] vasild reopened pull request #20000: test: fix creation of "std::string"s with \0s (master...fix_base32_tests) https://github.com/bitcoin/bitcoin/pull/20000
< bitcoin-git> [bitcoin] vasild closed pull request #20000: test: fix creation of "std::string"s with \0s (master...fix_base32_tests) https://github.com/bitcoin/bitcoin/pull/20000
< bitcoin-git> [bitcoin] laanwj merged pull request #20067: refactor: remove use of boost::algorithm::replace_first (master...20201003-get-rid-of-boost-replace_first) https://github.com/bitcoin/bitcoin/pull/20067
< bitcoin-git> bitcoin/master fbb2bee Wladimir J. van der Laan: Merge #20067: refactor: remove use of boost::algorithm::replace_first
< bitcoin-git> bitcoin/master 6f4e393 Sebastian Falbesoner: refactor: remove use of boost::algorithm::replace_first
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e12ad7f38346...fbb2bee82d83
< bitcoin-git> [bitcoin] laanwj merged pull request #19968: doc: clarify CRollingBloomFilter size estimate (master...bloom-doc) https://github.com/bitcoin/bitcoin/pull/19968
< bitcoin-git> bitcoin/master d9141a0 Anthony Towns: doc: clarify CRollingBloomFilter size estimate
< bitcoin-git> bitcoin/master e12ad7f Wladimir J. van der Laan: Merge #19968: doc: clarify CRollingBloomFilter size estimate
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/47b6ad837c07...e12ad7f38346
< bitcoin-git> [bitcoin] laanwj merged pull request #20333: build: remove native_biplist dependency (master...no_more_biplist) https://github.com/bitcoin/bitcoin/pull/20333
< bitcoin-git> bitcoin/master 47b6ad8 Wladimir J. van der Laan: Merge #20333: build: remove native_biplist dependency
< bitcoin-git> bitcoin/master 7087440 fanquake: depends: native_ds_store 1.3.0
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/888c22e0dd35...47b6ad837c07
< bitcoin-git> [bitcoin] laanwj merged pull request #20359: depends: Various config.site.in improvements and linting (master...2020-11-config-site-cleanup) https://github.com/bitcoin/bitcoin/pull/20359
< bitcoin-git> bitcoin/master 46756a6 Carl Dong: depends: Fix PYTHONPATH setting in config.site.in
< bitcoin-git> bitcoin/master 618cbd2 Carl Dong: lint: Also lint files with shellcheck directive
< bitcoin-git> bitcoin/master 6c7e8f0 Carl Dong: depends: Allow relative CONFIG_SITE path env var
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cddcd22ab326...888c22e0dd35
< bitcoin-git> [bitcoin] laanwj merged pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
< bitcoin-git> bitcoin/master cddcd22 Wladimir J. van der Laan: Merge #20288: script, doc: contrib/seeds updates
< bitcoin-git> bitcoin/master 961f148 Jon Atack: doc: update contrib/seeds/README dnspython installation info
< bitcoin-git> bitcoin/master dd7b5f4 Jon Atack: script: fix deprecation warning in makeseeds.py
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ea7926527ce3...cddcd22ab326
< wumpus> the make-tag script can now check all you favorite extra msvc build version strings too https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/66/files
< bitcoin-git> bitcoin/0.21 80496f9 Wladimir J. van der Laan: build: Set msvc builds's CLIENT_VERSION_IS_RELEASE
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/6cde7bb9b26c...80496f9e8116
< bitcoin-git> [bitcoin] fanquake opened pull request #20422: build: mac deployment unification (master...macdeploy_unify) https://github.com/bitcoin/bitcoin/pull/20422
< bitcoin-git> [bitcoin] fanquake opened pull request #20421: build: miniupnpc 2.2.0 (master...miniupnpc_220) https://github.com/bitcoin/bitcoin/pull/20421
< bitcoin-git> [bitcoin] fanquake merged pull request #20413: build: Require C++17 compiler (master...2011-buildCxx17) https://github.com/bitcoin/bitcoin/pull/20413
< bitcoin-git> bitcoin/master ea79265 fanquake: Merge #20413: build: Require C++17 compiler
< bitcoin-git> bitcoin/master fac7198 MarcoFalke: Use std::make_unique
< bitcoin-git> bitcoin/master faaee81 MarcoFalke: build: Require C++17 compiler
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/50e019a97a5b...ea7926527ce3

2020-11-18

< bitcoin-git> [bitcoin] achow101 closed pull request #20420: wallet: Don't upgrade to HD split if it is already supported (master...upgradewallet-fix-split) https://github.com/bitcoin/bitcoin/pull/20420
< gribble> https://github.com/bitcoin/bitcoin/issues/20420 | wallet: Dont upgrade to HD split if it is already supported by achow101 · Pull Request #20420 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] achow101 opened pull request #20420: wallet: Don't upgrade to HD split if it is already supported (master...upgradewallet-fix-split) https://github.com/bitcoin/bitcoin/pull/20420
< bitcoin-git> [bitcoin] fanquake opened pull request #20419: build: set minimum supported macOS to 10.14 (master...macos_minimum_10_14) https://github.com/bitcoin/bitcoin/pull/20419
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20414: doc: Remove generated manual pages from master branch (master...2020_11_manpages) https://github.com/bitcoin/bitcoin/pull/20414
< bitcoin-git> bitcoin/master 50e019a MarcoFalke: Merge #20414: doc: Remove generated manual pages from master branch
< bitcoin-git> bitcoin/master daf1ebf Wladimir J. van der Laan: doc: Remove generated manual pages from master branch
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d020e8839fa5...50e019a97a5b
< bitcoin-git> [bitcoin] fanquake closed pull request #11082: Add new bitcoin_rw.conf file that is used for settings modified by this software itself (master...rwconf) https://github.com/bitcoin/bitcoin/pull/11082
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20418: doc: clean out release notes post branch-off (master...clean_out_rel_notes) https://github.com/bitcoin/bitcoin/pull/20418
< bitcoin-git> bitcoin/master d020e88 MarcoFalke: Merge #20418: doc: clean out release notes post branch-off
< bitcoin-git> bitcoin/master 8a715a6 fanquake: build: Bump gitian descriptors to 0.22
< bitcoin-git> bitcoin/master dc5a35a fanquake: doc: clean out release notes post branch-off
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5bcae7967f73...d020e8839fa5
< bitcoin-git> [bitcoin] fanquake merged pull request #20408: CConnman: move initialization to declaration (master...202011-connman-fuzz) https://github.com/bitcoin/bitcoin/pull/20408
< bitcoin-git> bitcoin/master 5bcae79 fanquake: Merge #20408: CConnman: move initialization to declaration
< bitcoin-git> bitcoin/master 9d09132 Anthony Towns: CConnman: initialise at declaration rather than in Start()
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a64ff1c4d32c...5bcae7967f73
< bitcoin-git> [bitcoin] fanquake opened pull request #20418: doc: clean out release notes post branch-off (master...clean_out_rel_notes) https://github.com/bitcoin/bitcoin/pull/20418
< bitcoin-git> [bitcoin] fanquake closed pull request #20417: Test (master...test) https://github.com/bitcoin/bitcoin/pull/20417
< bitcoin-git> [bitcoin] seclab-skku opened pull request #20417: Test (master...test) https://github.com/bitcoin/bitcoin/pull/20417
< bitcoin-git> [bitcoin] fanquake closed pull request #20320: Depends: Update FreeType package (CVE-2020-15999) (master...master) https://github.com/bitcoin/bitcoin/pull/20320
< bitcoin-git> [bitcoin] jnewbery closed pull request #20416: net: Remove SetMaxOutboundTimeframe() (master...2020-11-remove-set-outbound-timeframe) https://github.com/bitcoin/bitcoin/pull/20416
< bitcoin-git> [bitcoin] jnewbery opened pull request #20416: net: Remove SetMaxOutboundTimeframe() (master...2020-11-remove-set-outbound-timeframe) https://github.com/bitcoin/bitcoin/pull/20416
< bitcoin-git> [bitcoin] laanwj closed pull request #20415: Create Double.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20415
< bitcoin-git> [bitcoin] elonmu opened pull request #20415: Create Double.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20415
< bitcoin-git> [gui] MarcoFalke closed pull request #42: qt: remove unused 'Decrypt' wallet (master...qt-remove-decrypt-case) https://github.com/bitcoin-core/gui/pull/42
< hebasto> MarcoFalke: https://github.com/bitcoin-core/gui/pull/42 could be closed now
< bitcoin-git> [bitcoin] jonatack reopened pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19905: Remove dead CheckForkWarningConditionsOnNewFork (master...2009-noFork) https://github.com/bitcoin/bitcoin/pull/19905
< bitcoin-git> bitcoin/master a64ff1c MarcoFalke: Merge #19905: Remove dead CheckForkWarningConditionsOnNewFork
< bitcoin-git> bitcoin/master fa7eed5 MarcoFalke: doc: Clarify that vpindexToConnect is in reverse order
< bitcoin-git> bitcoin/master fa62304 MarcoFalke: Remove dead CheckForkWarningConditionsOnNewFork
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/54532f46c4e2...a64ff1c4d32c
< bitcoin-git> [bitcoin] jonatack reopened pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
< bitcoin-git> [bitcoin] laanwj opened pull request #20414: doc: Remove generated manual pages from master branch (master...2020_11_manpages) https://github.com/bitcoin/bitcoin/pull/20414
< bitcoin-git> [gui] MarcoFalke merged pull request #109: wallet: Remove unused AskPassphraseDialog::Decrypt (master...201023-decrypt) https://github.com/bitcoin-core/gui/pull/109
< bitcoin-git> bitcoin/master 4146a31 Hennadii Stepanov: qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted
< bitcoin-git> bitcoin/master f886a20 Hennadii Stepanov: qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet
< bitcoin-git> bitcoin/master 6e95011 Hennadii Stepanov: qt, wallet: Remove unused AskPassphraseDialog::Decrypt
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4ae04090bb1d...54532f46c4e2
< bitcoin-git> bitcoin/master 4ae0409 MarcoFalke: Merge bitcoin-core/gui#118: Remove BDB version from the Information tab
< bitcoin-git> [gui] MarcoFalke merged pull request #118: Remove BDB version from the Information tab (master...201027-bdb) https://github.com/bitcoin-core/gui/pull/118
< bitcoin-git> bitcoin/master e4fc45a Hennadii Stepanov: gui: Remove BDB version from the Information tab
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4b24c3962fd9...4ae04090bb1d
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20413: build: Require C++17 compiler (master...2011-buildCxx17) https://github.com/bitcoin/bitcoin/pull/20413
< bitcoin-git> bitcoin/0.21 6cde7bb Wladimir J. van der Laan: doc: Generate manual pages for 0.21.0rc1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/463b316822c7...6cde7bb9b26c
< gribble> https://github.com/bitcoin/bitcoin/issues/19183 | [WIP DONOTMERGE] Replace boost with C++17 by MarcoFalke · Pull Request #19183 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.21 463b316 Wladimir J. van der Laan: build: Bump version for 0.21.0rc1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/commit/463b316822c7
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19504: Bump minimum python version to 3.6 (master...202007-python3.6) https://github.com/bitcoin/bitcoin/pull/19504
< bitcoin-git> bitcoin/master 4b24c39 MarcoFalke: Merge #19504: Bump minimum python version to 3.6
< bitcoin-git> bitcoin/master 97c738f Anthony Towns: [tests] Recommend f-strings for formatting, update feature_block to use th...
< bitcoin-git> bitcoin/master 8ae9d31 Anthony Towns: Bump minimum python version to 3.6
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/132e1d897f13...4b24c3962fd9
< bitcoin-git> bitcoin/master 132e1d8 Wladimir J. van der Laan: build: Bump master version to 0.21.99
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/831675c8dccf...132e1d897f13
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20166: [0.20] Backports (0.20...more_020_backports) https://github.com/bitcoin/bitcoin/pull/20166
< bitcoin-git> bitcoin/0.20 731502a MarcoFalke: rpc: Properly deserialize txs with witness before signing
< bitcoin-git> bitcoin/0.20 ee0082b Pieter Wuille: Avoid the use of abs64 in timedata
< bitcoin-git> bitcoin/0.20 05bd0c2 Nadav Ivgi: docs: Correct description for getblockstats's txs field
< bitcoin-git> [bitcoin] MarcoFalke pushed 11 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/a339289c2ef9...a2fa11f9de78
< gribble> https://github.com/bitcoin/bitcoin/issues/20292 | test: Fix intermittent feature_taproot issue by MarcoFalke · Pull Request #20292 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] troygiorshev opened pull request #20411: Fix Version Message Deserialization Discrepancy (master...2020-11-test-framework-version-msg-fix) https://github.com/bitcoin/bitcoin/pull/20411

2020-11-17

< miketwenty1> sipa, right now in bitcoin-core repo we have the gitian sigs for non guix process .. but would we have a sigs folder for guix build process or am i thinking about this incorrectly?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20410: wallet: Do not treat default constructed types as None-type (master...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20410
< bitcoin-git> [bitcoin] jnewbery closed pull request #20317: Backport wtxid orphan fetch to v0.20 (0.20...2020-07-v20-wtxid-orphan) https://github.com/bitcoin/bitcoin/pull/20317
< jnewbery> pinheadmz: it's 15:00 UTC on alternate Tuesdays: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
< sdaftuar> philosophically though there is no such thing as "bitcoin's tx relay rules". i think that's luke's fundamental point (which I agree with)
< gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20399 | Revert "Merge #19606: Backport wtxid relay to v0.20" by MarcoFalke · Pull Request #20399 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19509 | Per-Peer Message Capture by troygiorshev · Pull Request #19509 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20158 | tree-wide: De-globalize ChainstateManager by dongcarl · Pull Request #20158 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19398 | Move remaining application layer data to net processing · Issue #19398 · bitcoin/bitcoin · GitHub
< ariard> Im waiting for https://github.com/bitcoin/bitcoin/pull/19160 landing before to go forward with altnet
< jnewbery> We have one proposed topic for today's meeting: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#17-nov-2020.
< gribble> https://github.com/bitcoin/bitcoin/issues/17 | listaccounts method · Issue #17 · bitcoin/bitcoin · GitHub
< jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< core-meetingbot> Meeting started Tue Nov 17 15:00:13 2020 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] ajtowns opened pull request #20408: CConnman: move initialization into Init() (master...202011-connman-fuzz) https://github.com/bitcoin/bitcoin/pull/20408
< bitcoin-git> [bitcoin] fanquake merged pull request #20401: qt: Pre-splitoff translations update (master...2020_11_translations_update) https://github.com/bitcoin/bitcoin/pull/20401
< gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 831675c fanquake: Merge #20401: qt: Pre-splitoff translations update
< bitcoin-git> bitcoin/master bb6441b Wladimir J. van der Laan: qt: Pre-splitoff translations update
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80e32e120ee4...831675c8dccf
< gribble> https://github.com/bitcoin/bitcoin/issues/20401 | qt: Pre-splitoff translations update by laanwj · Pull Request #20401 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305
< bitcoin-git> bitcoin/master e21212f Jon Atack: wallet: remove unneeded WALLET_BTC_KB_TO_SAT_B constant
< bitcoin-git> bitcoin/master 6112cf2 Jon Atack: wallet: add CFeeRate ctor doxygen documentation
< bitcoin-git> bitcoin/master 3f72791 Jon Atack: wallet: fix bug in RPC send options
< bitcoin-git> [bitcoin] MarcoFalke pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/e7986c51bc7a...80e32e120ee4
< bitcoin-git> bitcoin/master c99d6f6 Sjors Provoost: gui: create wallet: name placeholder
< bitcoin-git> bitcoin/master ac64cec Sjors Provoost: gui: create wallet: add advanced section
< bitcoin-git> bitcoin/master 5bff825 Sjors Provoost: [gui] create wallet: smarter checkbox toggling
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c463f70fb05e...e7986c51bc7a
< bitcoin-git> [gui] MarcoFalke merged pull request #96: Slight improve create wallet dialog (master...2020/09/create_wallet) https://github.com/bitcoin-core/gui/pull/96
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20139: Wallet: do not return warnings from UpgradeWallet() (master...upgradewallet_rpc_cleanup) https://github.com/bitcoin/bitcoin/pull/20139
< bitcoin-git> bitcoin/master c463f70 MarcoFalke: Merge #20139: Wallet: do not return warnings from UpgradeWallet()
< bitcoin-git> bitcoin/master 9636962 Sishir Giri: [upgradewallet] removed unused warning param
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3457054c61d5...c463f70fb05e
< bitcoin-git> [bitcoin] fanquake merged pull request #20346: script: modify security-check.py to use "==" instead of "is" for literal comparison (master...literal-comparison-update) https://github.com/bitcoin/bitcoin/pull/20346
< bitcoin-git> bitcoin/master 3457054 fanquake: Merge #20346: script: modify security-check.py to use "==" instead of "is"...
< bitcoin-git> bitcoin/master b6121ed Tyler Chambers: swapped "is" for "==" in literal comparison
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7c0d412a74ba...3457054c61d5
< bitcoin-git> [bitcoin] fanquake merged pull request #20405: p2p: avoid calculating onion address checksum when version is not 3 (master...tinyrefactoring) https://github.com/bitcoin/bitcoin/pull/20405
< bitcoin-git> bitcoin/master 7c0d412 fanquake: Merge #20405: p2p: avoid calculating onion address checksum when version i...
< bitcoin-git> bitcoin/master d355a30 lontivero: Break circuit earlier
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c48e788246fc...7c0d412a74ba
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #20407: rpc: Support -rpcauthfile argument (master...2020-11-rpcauthfile) https://github.com/bitcoin/bitcoin/pull/20407

2020-11-16

< bitcoin-git> [bitcoin] practicalswift opened pull request #20406: util: Avoid invalid integer negation in FormatMoney and ValueFromAmount (master...avoid-invalid-integer-negation-in-FormatMoney) https://github.com/bitcoin/bitcoin/pull/20406
< bitcoin-git> [bitcoin] lontivero opened pull request #20405: Avoid calculating onion address checksum when version is not 3 (master...tinyrefactoring) https://github.com/bitcoin/bitcoin/pull/20405
< bitcoin-git> [bitcoin] hebasto opened pull request #20404: Remove names from translatable strings (master...201116-tr) https://github.com/bitcoin/bitcoin/pull/20404
< bitcoin-git> [bitcoin] jonatack opened pull request #20403: wallet: upgradewallet fixes, improvements, test coverage (master...upgradewallet-improvements) https://github.com/bitcoin/bitcoin/pull/20403
< gribble> https://github.com/bitcoin/bitcoin/issues/18573 | [RFC] bitcoin-asmap utility by sipa · Pull Request #18573 · bitcoin/bitcoin · GitHub
< provoostenator> sipa: is there a step between downloading the files with asmap-rs and the your bitcoin-asmap encode incantation in #18573?
< bitcoin-git> [bitcoin] laanwj opened pull request #20401: qt: Pre-splitoff translations update (master...2020_11_translations_update) https://github.com/bitcoin/bitcoin/pull/20401
< bitcoin-git> [bitcoin] laanwj merged pull request #18836: wallet: upgradewallet fixes and additional tests (master...upgradewallet-tests) https://github.com/bitcoin/bitcoin/pull/18836
< bitcoin-git> bitcoin/master bd7398c Andrew Chow: wallet: have ScriptPubKeyMan::Upgrade check against the new version
< bitcoin-git> bitcoin/master 5f72054 Andrew Chow: wallet: Add GetClosestWalletFeature function
< bitcoin-git> bitcoin/master 842ae38 Andrew Chow: wallet: Add utility method for CanSupportFeature
< bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/1e17114917f2...c48e788246fc
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20238: doc: Missing comments for signet parameters (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20238
< bitcoin-git> bitcoin/master 1e17114 MarcoFalke: Merge #20238: doc: Missing comments for signet parameters
< bitcoin-git> bitcoin/master 9c08f33 kanon: doc: Missing comments for signet parameters
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/37a463481176...1e17114917f2
< bitcoin-git> [bitcoin] mateusz-klatt closed pull request #20361: Descriptor Wallets BIP39 recovery (master...master) https://github.com/bitcoin/bitcoin/pull/20361
< bitcoin-git> [bitcoin] hebasto closed pull request #20366: scripted-diff: Fix includes when secp256k1 is locally installed on macOS (master...201111-incl) https://github.com/bitcoin/bitcoin/pull/20366
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20390: CI/Cirrus: Skip merge_base step for non-PRs (master...cirrus_nonpr_fix) https://github.com/bitcoin/bitcoin/pull/20390
< bitcoin-git> bitcoin/master 37a4634 MarcoFalke: Merge #20390: CI/Cirrus: Skip merge_base step for non-PRs
< bitcoin-git> bitcoin/master 20e491d Luke Dashjr: CI/Cirrus: Skip merge_base step for non-PRs
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2fa085a5d752...37a463481176
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20033: refactor: minor whitespace fixups, s/const/constexpr/ and remove template (followup to #19845) (master...nits_followup_to_19845) https://github.com/bitcoin/bitcoin/pull/20033
< bitcoin-git> bitcoin/master 2fa085a MarcoFalke: Merge #20033: refactor: minor whitespace fixups, s/const/constexpr/ and re...
< bitcoin-git> bitcoin/master 89836a8 Vasil Dimov: style: minor improvements as a followup to #19845
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0ede354367c4...2fa085a5d752
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20399: Revert "Merge #19606: Backport wtxid relay to v0.20" (0.20...2011-prepare020release) https://github.com/bitcoin/bitcoin/pull/20399

2020-11-15

< gribble> https://github.com/bitcoin/bitcoin/issues/19980 | refactor: Some wallet cleanups by promag · Pull Request #19980 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20386: Silence false positive GCC warning in wallet/rpcwallet.cpp (master...rpcwallet-silence-warning) https://github.com/bitcoin/bitcoin/pull/20386
< bitcoin-git> bitcoin/master 049feab Kristaps Kaupe: Add missing optional.h include
< bitcoin-git> bitcoin/master 0ede354 MarcoFalke: Merge #20386: Silence false positive GCC warning in wallet/rpcwallet.cpp
< bitcoin-git> bitcoin/master 29c66ac Kristaps Kaupe: Silence false positive GCC warning
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fb7726e56d0f...0ede354367c4
< luke-jr> Bullit: discuss in #bitcoin
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20395: ci: Use the previous build worker image in AppVeyor (master...201115-appveyor) https://github.com/bitcoin/bitcoin/pull/20395
< bitcoin-git> bitcoin/master fb7726e MarcoFalke: Merge #20395: ci: Use the previous build worker image in AppVeyor
< bitcoin-git> bitcoin/master 406097c Hennadii Stepanov: ci: Use the previous build worker image in AppVeyor
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/543693b92b95...fb7726e56d0f
< Bullit> Bitcoin QT is almost 6 weeks busy with its re-indexing on a microsoft windows 10 pro with graphix card designed for litecoin mining But indexing seems to be slowed halted or delayed, as it is currently at 2 years 40 weeks behind, i remember have seen 2 years 27 weeks behind
< bitcoin-git> [bitcoin] hebasto opened pull request #20395: ci: Use the previous build worker image in AppVeyor (master...201115-appveyor) https://github.com/bitcoin/bitcoin/pull/20395
< bitcoin-git> [bitcoin] prayank23 opened pull request #20393: error if invalid chars in wallet name (master...wallet-name) https://github.com/bitcoin/bitcoin/pull/20393
< bitcoin-git> [bitcoin] sipsorcery opened pull request #20392: Switch appveyor build from Release to Debug (master...msvc-appveyor-debug-build) https://github.com/bitcoin/bitcoin/pull/20392
< jonatack> hebasto: seeing the same qt failure in appveyor, something about different compiler versions of Qt5Test.lib and Qt5Core.lib... https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36313638

2020-11-14

< bitcoin-git> [bitcoin] jonatack opened pull request #20391: wallet: introduce setfeerate (an improved settxfee, in sat/vB) (master...setfeerate) https://github.com/bitcoin/bitcoin/pull/20391
< bitcoin-git> [bitcoin] simewu closed pull request #20388: Bitcoin master (master...bitcoin-master) https://github.com/bitcoin/bitcoin/pull/20388
< bitcoin-git> [bitcoin] simewu opened pull request #20388: Bitcoin master (master...bitcoin-master) https://github.com/bitcoin/bitcoin/pull/20388
< luke-jr> sipa: bitcoin-cli createwallet my_wallet false false '' false true
< bitcoin-git> [bitcoin] kristapsk opened pull request #20386: Silence false positive GCC warning in wallet/rpcwallet.cpp (master...rpcwallet-silence-warning) https://github.com/bitcoin/bitcoin/pull/20386

2020-11-13

< bitcoin-git> [bitcoin] mjdietzx opened pull request #20385: test: run mempool_spend_coinbase.py even with wallet disabled (master...mempool-tests-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20385
< gribble> https://github.com/bitcoin/bitcoin/issues/19137 | wallettool: Add dump and createfromdump commands by achow101 · Pull Request #19137 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20383: Avoid signed integer overflow and invalid integer negation when loading malformed mempool.dat files (master...signed-integer-malformed-mempool-dat-and-rpc) https://github.com/bitcoin/bitcoin/pull/20383
< luke-jr> achow101: is this a fix we should be adding in 0.21? https://github.com/bitcoin/bitcoin/pull/20267/files#r523007716
< bitcoin-git> [bitcoin] practicalswift closed pull request #20089: validation: Increase robustness when loading malformed mempool.dat files (LoadMempool) (master...load-mempool-robustness) https://github.com/bitcoin/bitcoin/pull/20089
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20378: wallet: fix potential division by 0 in WalletLogPrintf (master...2020/11/fix_devnull_wallet) https://github.com/bitcoin/bitcoin/pull/20378
< bitcoin-git> bitcoin/master 543693b Jonas Schnelli: Merge #20378: wallet: fix potential division by 0 in WalletLogPrintf
< bitcoin-git> bitcoin/master 440f8d3 Jonas Schnelli: fix potential devision by 0
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/28cb61646b29...543693b92b95
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19065: tests: Add fuzzing harness for CAddrMan (master...fuzzers-2020-05-23) https://github.com/bitcoin/bitcoin/pull/19065
< bitcoin-git> bitcoin/master 28cb616 MarcoFalke: Merge #19065: tests: Add fuzzing harness for CAddrMan
< bitcoin-git> bitcoin/master d04a17a practicalswift: fuzz: Use ConsumeRandomLengthBitVector(...) in src/test/fuzz/connman and s...
< bitcoin-git> bitcoin/master e6bb9fd practicalswift: tests: Add fuzzing harness for CAddrMan
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99fcc2b4778f...28cb61646b29
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20379: tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp) (master...remove-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20379
< bitcoin-git> bitcoin/master 99fcc2b MarcoFalke: Merge #20379: tests: Remove no longer needed UBSan suppression (float divi...
< bitcoin-git> bitcoin/master 0ccb3ad practicalswift: tests: Remove no longer needed UBSan suppression (float-divide-by-zero in ...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0bd4929cd00e...99fcc2b4778f
< bitcoin-git> [bitcoin] fanquake closed pull request #19068: build: Use a zip instead of dmg for macOS releases (master...macdeploy_zip_instead_of_dmg) https://github.com/bitcoin/bitcoin/pull/19068
< bitcoin-git> [bitcoin] fanquake closed pull request #20336: build: automatically determine macOS base translations (master...auto_find_translations) https://github.com/bitcoin/bitcoin/pull/20336

2020-11-12

< gribble> Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< sipa> we do need a bitcoin core specific fuzzing farm that can run fuzzers with months of CPU time though
< gribble> https://github.com/bitcoin/bitcoin/issues/19387 | span: update constructors to match c++20 draft spec and add lifetimebound attribute by theuni · Pull Request #19387 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20380: doc: Add instructions on how to fuzz the P2P layer using Honggfuzz NetDriver (master...honggfuzz-p2p-fuzzing) https://github.com/bitcoin/bitcoin/pull/20380
< wumpus> bitcoin core is too big
< gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub
< wumpus> make it clear which areas of the code are the really risky ones that could break bitcoin as a thing
< Kiminuo> https://github.com/bitcoin/bitcoin/pull/19245 - Do I understand correctly that this is dead for foreseeable future?
< ja> provoostenator: i linked the commit https://github.com/bitcoin/bitcoin/commit/1d3ec2a1fda7446323786a52da1fd109c01aa6fb because i wanted to discuss this compromise on boolean blindness in general, not specific to the btcd issue
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/19305 | doc: add C++17 release note for 0.21.0 by fanquake · Pull Request #19305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19716 | build: Qt 5.15.x by fanquake · Pull Request #19716 · bitcoin/bitcoin · GitHub
< ja> michaelfolkson: if you bitcoin node is deadlocked on a shared_mutex, are you online?
< ja> luke-jr: if you use bitcoin to back a lightning node, a deadlock could be pretty bad, no?
< jnewbery> Prompted by https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696, where Cory ran into a bug in glibc when using std::shared_mutex.
< jnewbery> As a reminder, our plan for C++17 is here: https://github.com/bitcoin/bitcoin/issues/16684
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20379: tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp) (master...remove-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20379
< provoostenator> I'd like to get this in the release if possible: https://github.com/bitcoin-core/gui/pull/96
< wumpus> at least there's only three PRs left on the milestone: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu Nov 12 19:01:12 2020 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< ja> i see so many booleans, and i am suspicious. for example https://github.com/bitcoin/bitcoin/commit/1d3ec2a1fda7446323786a52da1fd109c01aa6fb
< jnewbery> #proposedmeetingtopic limiting C++17 feature usage (see https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696)
< bitcoin-git> [bitcoin] laanwj merged pull request #20284: addrman: ensure old versions don't parse peers.dat (master...peers_dat_format) https://github.com/bitcoin/bitcoin/pull/20284
< bitcoin-git> bitcoin/master 38ada89 Vasil Dimov: addrman: ensure old versions don't parse peers.dat
< bitcoin-git> bitcoin/master 0bd4929 Wladimir J. van der Laan: Merge #20284: addrman: ensure old versions don't parse peers.dat
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bd131669729...0bd4929cd00e
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20378: fix potential devision by 0 (master...2020/11/fix_devnull_wallet) https://github.com/bitcoin/bitcoin/pull/20378
< bitcoin-git> [bitcoin] practicalswift opened pull request #20377: fuzz: Fill various small fuzzing gaps (master...fuzzers-2020-11-12) https://github.com/bitcoin/bitcoin/pull/20377
< pinheadmz> shesek ive gotten a lot of great help from #bitcoin-core-pr-reviews
< pinheadmz> #bitcoin is basically /r/bitcoin
< jonasschnelli> shesek: yeah.. maybe also #bitcoin can help
< shesek> honestly I kinda knew it, its just that #bitcoin-dev appears pretty much dead, all my scrollback there is join/part/quit messages
< jonasschnelli> this channel is for bitcoin core development
< jonasschnelli> but I recommend to join #bitcoin-dev