< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615
< queip>
the "score" field in getnetworkinfo, what does it actually mean? we are confused about it trying to provide support to user in #bitcoin . Could RPC help xxx command include short explanation for the outputed JSON fields for most commands?
< bitcoin-git>
[bitcoin] laanwj merged pull request #20549: Support make src/bitcoin-node and src/bitcoin-gui (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549
< bitcoin-git>
bitcoin/master 8e1f9d6 Wladimir J. van der Laan: Merge #20549: Support make src/bitcoin-node and src/bitcoin-gui
< bitcoin-git>
bitcoin/master 206f74e João Barbosa: Support make src/bitcoin-node and src/bitcoin-gui
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
< bitcoin-git>
[bitcoin] laanwj merged pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
< bitcoin-git>
bitcoin/master e20b488 Wladimir J. van der Laan: Merge #20567: test: Add option to git-subtree-check to do full check, add ...
< bitcoin-git>
bitcoin/master 34c80d9 Wladimir J. van der Laan: test: Add option to git-subtree-check to do full check, add help
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611
< az0re>
(I am new to the Bitcoin codebase and would appreciate some tips on the most relevant data structures)
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
< bitcoin-git>
bitcoin/master c8fdbb4 MarcoFalke: Merge #20609: configure: output notice that test binary is disabled by fuz...
< bitcoin-git>
bitcoin/master 904d875 Andrew Poelstra: configure: output notice that test binary is disabled by fuzzing
< bitcoin-git>
[bitcoin] fanquake merged pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
< bitcoin-git>
bitcoin/master 0547106 fanquake: Merge #20608: contrib: add symbol check test for PE binaries
< bitcoin-git>
bitcoin/master ae9b489 fanquake: contrib: add symbol check test for PE
< bitcoin-git>
[bitcoin] apoelstra opened pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
< bitcoin-git>
[gui] luke-jr opened pull request #148: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...bugfix_gui_bumpyes) https://github.com/bitcoin-core/gui/pull/148
< bitcoin-git>
[bitcoin] fanquake opened pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
< bitcoin-git>
[bitcoin] fanquake merged pull request #19910: net processing: Move peer_map to PeerManager (master...2020-08-peer-plv2) https://github.com/bitcoin/bitcoin/pull/19910
< bitcoin-git>
bitcoin/master a20ab22 John Newbery: [net processing] Make GetPeerRef const
< bitcoin-git>
bitcoin/master a529fd3 John Newbery: [net processing] Move GetNodeStateStats into PeerManager
< bitcoin-git>
bitcoin/master ed7e469 John Newbery: [net_processing] Move peer_map to PeerManager
< queip>
some users looking at bitcoin-qt have a feeling that node "is stuck". Perhaps GUI is not re-assuring enough progress is happening. This leads to second problem: "bored" users then look into debug.log and some of normal messages look "worrying" like the ones with invalid blocks, rejected peers (result of forkcoin peers). Apparently some users think node is not working and seek help then
< gribble>
https://github.com/bitcoin/bitcoin/issues/19658 | [rpc] Allow RPC to fetch all addrman records and add records to addrman by jnewbery · Pull Request #19658 · bitcoin/bitcoin · GitHub
< vasild>
right now bitcoin core is the only implementation that exists, I guess. I would be a problem if another implementation arrives that expects sendaddrv2 at a certain time and is upset otherwise
< vasild>
sipa: wumpus: wrt sending sendaddrv2 and the difference between the code and the BIP, I opened https://github.com/bitcoin/bips/pull/1043 to change the BIP.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
< bitcoin-git>
[bitcoin] laanwj merged pull request #20568: doc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
< bitcoin-git>
bitcoin/master 5c4911e Wladimir J. van der Laan: Merge #20568: doc: Use FeeModes doc helper in estimatesmartfee
< bitcoin-git>
bitcoin/master fa8abdc MarcoFalke: rpc: Use FeeModes doc helper in estimatesmartfee
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
< bitcoin-git>
bitcoin/master 00f4dcd MarcoFalke: Merge #20138: net: Assume that SetCommonVersion is called at most once per...
< bitcoin-git>
bitcoin/master fa0f415 MarcoFalke: net: Assume that SetCommonVersion is called at most once per peer
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20588: Remove unused and confusing CTransaction constructor (master...2012-txConstructor) https://github.com/bitcoin/bitcoin/pull/20588
< bitcoin-git>
[bitcoin] laanwj reopened pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
< bitcoin-git>
[bitcoin] laanwj closed pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
< bitcoin-git>
[bitcoin] laanwj merged pull request #20468: build: warn when generating man pages for binaries built from a dirty branch (master...fix-20412) https://github.com/bitcoin/bitcoin/pull/20468
< bitcoin-git>
bitcoin/master f3e1768 Wladimir J. van der Laan: Merge #20468: build: warn when generating man pages for binaries built fro...
< bitcoin-git>
bitcoin/master 6690adb Tyler Chambers: Warn when binaries are built from a dirty branch.
< bitcoin-git>
[bitcoin] hebasto closed pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20584: Don't declare de facto const member functions as non-const. Don't declare de facto const reference variables as non-const. (master...const-member-fn-and-const-ref-var) https://github.com/bitcoin/bitcoin/pull/20584
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20583: rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs (master...2012-walletSync) https://github.com/bitcoin/bitcoin/pull/20583
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581
< bitcoin-git>
bitcoin/master 9385549 MarcoFalke: Merge #20581: Don't make "in" parameters look like "out"/"in-out" paramete...
< bitcoin-git>
bitcoin/master 12dcdaa practicalswift: Don't make "in" parameters look like "out"/"in-out" parameters: pass by re...
< bitcoin-git>
[bitcoin] wodry opened pull request #20582: [doc] Fix documenation of options onlynet and listenonion (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20582
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581
2020-12-05
< bitcoin-git>
[bitcoin] promag closed pull request #20580: wallet: Some cleanups around LegacyScriptPubKeyMan (master...2020-12-wallet-legacy) https://github.com/bitcoin/bitcoin/pull/20580
< pinheadmz>
re: coordination though - BIPs are good places to pick service bits, etc at the community level - thats not really "bitcoin core deciding:
< sipa>
bitcoin core shouldn't be decided what messages are allowed on the network
< sipa>
it seems everyone working on bitcoin core feels this is weird and makes things harder for alternative implementations
< pinheadmz>
at the meeting this week there was talk about btcd and libbitcoin disconnecting on unkown p2p message types. i think bcoin does this as well, but that behavior could be changed. does Bitcoin Core have another way to mitigate spam attacks with unknown messages? or is it not a concern because they are simply not processed?
< bitcoin-git>
[bitcoin] promag opened pull request #20580: wallet: Some cleanups around LegacyScriptPubKeyMan (master...2020-12-wallet-legacy) https://github.com/bitcoin/bitcoin/pull/20580
< bitcoin-git>
[bitcoin] theStack opened pull request #20577: doc: libconsensus: add missing error code description, fix NBitcoin link (master...201212-doc-libbitcoinconsensus-fixes) https://github.com/bitcoin/bitcoin/pull/20577
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20575: Do not run functions with necessary side-effects in assert() (master...side-effect-free-assert) https://github.com/bitcoin/bitcoin/pull/20575
< bitcoin-git>
[bitcoin] hebasto reopened pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
< luke-jr>
Provostro: this channel is for Bitcoin Core development, not for speaking with specific people about other topics
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20562: tests: Test that a fully signed tx given to signrawtx is unchanged (master...test-signraw-fullysigned) https://github.com/bitcoin/bitcoin/pull/20562
< bitcoin-git>
bitcoin/master 751ffaa MarcoFalke: Merge #20562: tests: Test that a fully signed tx given to signrawtx is unc...
< bitcoin-git>
bitcoin/master 773c42b Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
< harding>
problems, please reply to the thread." http://bitcoinops.org/en/newsletters/2020/03/04/#improving-feature-negotiation-between-full-nodes-at-startup Later (August), about the new wtxidrelay message, we wrote, "This behavior is already implemented in an unreleased development version of Bitcoin Core. If the maintainers of other implementations, or anyone else, opposes this change, please respond to the mailing list thread."
< wumpus>
well, it also helps coordinate between bitcoin core developers on a more conceptual level than implementation details, but that discussion happened on the BIP repo PRs, not on the mailing list
< wumpus>
but I agree, the whole BIP process is there to standardize the bitcoin protocols, to coordinate between implementations, that's the point