< December 2024 >
Su Mo Tu We Th Fr Sa 1234567891011 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30 31
2021-10-02
<gribble>
https://github.com/bitcoin/bitcoin/issues/12119 | [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH by Sjors · Pull Request #12119 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] fanquake opened pull request #23149: build: make --enable-werror just -Werror (master...make_enable_werror_full_werror) https://github.com/bitcoin/bitcoin/pull/23149
<Guest64>
Guys, hello. Tell me who's in the subject. I send a certain amount of money from Bitcoin Core to a Bitcoin address, the commission is generally acceptable. But the balance of the wallet itself is reduced by an amount that is 42 times more than the amount of funds sent. I canceled the operation. What can be wrong?
<laanwj>
it's fairly easy with make to make a mistake with regard to ordering dependencies which causes issues (either errors or non-determinism) with high parallelism, if you find such a issue with bitcoin core please report it
<sipa>
i build bitcoin core with -j48
<laanwj>
i don't know about useless? bitcoin core's build should have plenty of potential parallelism, i once saw a screenshot of someone building on a 64-core machine, all cores 100%, though probably this won't be the case in the latter parts of the process during linking etc which have to merge a lot of build artifacts
<bitcoin-git>
[bitcoin] jonatack opened pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
<bitcoin-git>
[gui] hebasto merged pull request #342: wallet: Move wallets loading out from the main GUI thread (master...210521-wallet) https://github.com/bitcoin-core/gui/pull/342
<bitcoin-git>
bitcoin/master f9b633e Hennadii Stepanov: qt, wallet: Move activity progress dialog from data member to local
<bitcoin-git>
bitcoin/master 4a024fc Hennadii Stepanov: qt, wallet, refactor: Move connection to QObject::deleteLater to ctor
<bitcoin-git>
bitcoin/master f6991cb Hennadii Stepanov: qt, wallet: Add LoadWalletsActivity class
<TallTim>
I'd like to report using addnode to sync bitcoin core client with my personal full node has sped up my sync time. Thanks again to sipa for the advice.
<bitcoin-git>
bitcoin/master 4446ef0 fanquake: build: remove support for weak linking getauxval()
<bitcoin-git>
bitcoin/master e56100c fanquake: build: remove arm includes from getauxval() check
<bitcoin-git>
bitcoin/master 7f81f54 W. J. van der Laan: Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove ...
<fedecuci>
Hi guys, I am curious, how many people have a very strong understanding of the Bitcoin protocol and source code? I am talking about people that are comfortable with at least 80% of the codebase and would know almost immediately where to go to fix a bug in case it arises. Any estimate?
<bitcoin-git>
bitcoin/master 90be29c Sebastian Falbesoner: wallet: enable SQLite extended result codes
<bitcoin-git>
bitcoin/master 80b4e8f W. J. van der Laan: Merge bitcoin/bitcoin#23112: wallet: enable SQLite extended result codes
<bitcoin-git>
[gui] laanwj merged pull request #336: Do not exit and re-enter main event loop during shutdown (master...210516-loop) https://github.com/bitcoin-core/gui/pull/336
<bitcoin-git>
bitcoin/master 7830cd0 Hennadii Stepanov: qt, refactor: Keep OptionsDialog in the main event loop
<bitcoin-git>
bitcoin/master 59f7ba4 Hennadii Stepanov: qt, refactor: Keep CoinControlDialog in the main event loop
<vasild>
in case anybody is curious how many incoming connections his node is getting (and lazy to type wretched bash commands), assuming debug=net is switched off on the node: bitcoin-cli logging '["net"]' && sleep 3600 && bitcoin-cli logging '[]' '["net"]'
<bitcoin-git>
bitcoin/master f529290 Hennadii Stepanov: Merge bitcoin-core/gui#439: Do not show unused widgets at startup
<bitcoin-git>
bitcoin/master 489060d Hennadii Stepanov: qt: Do not show unused widgets at startup
<vasild>
laanwj: right, a "node" victim.com:80 that never speaks bitcoin p2p would propagate less and fall out of addrmans. So a rate from a well propagated real bitcoin node with public ipv4 address and port 80 would give an upper bound. If that is not high enough to be considered as a dos attack, then a lower number will also not be.
<gribble>
https://github.com/bitcoin/bitcoin/issues/23136 | test: update fee rate assertion helper in the functional test framework by jonatack · Pull Request #23136 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23142: Return false on corrupt tx rather than asserting (master...202109_no_assert_corruption) https://github.com/bitcoin/bitcoin/pull/23142
<michaelfolkson>
jawed: Happened on #bitcoin-dev channel. I'll send a summary and a conversation log to the mailing list
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23141: Fix intermitent failure in wallet_basic.py (master...202109_fix_test_rounding) https://github.com/bitcoin/bitcoin/pull/23141
2021-09-29
<gribble>
https://github.com/bitcoin/bitcoin/issues/22949 | fee: Round up fee calculation to avoid a lower than expected feerate by achow101 · Pull Request #22949 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[gui] hebasto opened pull request #440: Do not require restart if overridden option is modified (master...210929-restart) https://github.com/bitcoin-core/gui/pull/440
<bitcoin-git>
[bitcoin] sipa opened pull request #23140: Make CAddrman::Select_ select buckets, not positions, first (master...202109_addrmanbias) https://github.com/bitcoin/bitcoin/pull/23140
<bitcoin-git>
[bitcoin] jonatack opened pull request #23139: rpc: fix "trusted" field in TransactionDescriptionString(), add coverage (master...fix-rpc-trusted-field-help) https://github.com/bitcoin/bitcoin/pull/23139
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23115: bloom: use Span instead of std::vector for `insert` and `contains` (master...18985_rebased) https://github.com/bitcoin/bitcoin/pull/23115
<bitcoin-git>
bitcoin/master 10c6929 Samuel Dobson: Include vout when copying transaction ID from coin selection
<bitcoin-git>
bitcoin/master 8d83f9c Hennadii Stepanov: Merge bitcoin-core/gui#436: Include vout when copying transaction ID from ...
<bitcoin-git>
[gui] hebasto merged pull request #436: Include vout when copying transaction ID from coin selection (master...202109_coinselection_copy_vout) https://github.com/bitcoin-core/gui/pull/436
<bitcoin-git>
[bitcoin] jonatack opened pull request #23136: test: update fee rate assertion helper in the functional test framework (master...update-assert_fee_amount) https://github.com/bitcoin/bitcoin/pull/23136
<bitcoin-git>
bitcoin/master 2ba4ddf William Casarin: bloom: use Span instead of std::vector for `insert` and `contains`
<vasild>
I just enabled debug=net again to get recent data (thanks, jonatack for bitcoin-cli logging '["net"]', I wasn't aware of it (shame!))
<bitcoin-git>
[bitcoin] brunoerg opened pull request #23135: test: Use asset_equal utils where possible in feature_nulldummy (master...2021-09-assert_equal) https://github.com/bitcoin/bitcoin/pull/23135
<sipa>
vasild: interesting... mostly non-bitcoin core nodes i assume?
<jonatack>
or if the node is already running, then: bitcoin-cli logging '["net"]'
<laanwj>
https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-core-dev was originally intended as a mailing list for bitcoin core development but there was no post on it for years, no one actually wants to use a mailing list for development, at some point it was changed to a notification-only list
<sipa>
the bitcoin-dev mailing list is for bitcoin development in general; not for development of the bitcoin-core software implementation
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23124: Fix feature_segwit.py failure due to witness (master...202109_fix_feature_segwit) https://github.com/bitcoin/bitcoin/pull/23124
<bitcoin-git>
bitcoin/master b207971 Samuel Dobson: Fix feature_segwit failure due to witness
<bitcoin-git>
bitcoin/master d648bbb MarcoFalke: Merge bitcoin/bitcoin#23124: Fix feature_segwit.py failure due to witness
<sipa>
vasild: i just read that yesterday; i think at least historically, there is a different argument too... it's not so much the concern of an actually harmful Dos, but some the worry that some webserver say would suddenly get a bunch of incoming connections from bitcoin nodes, and risk that causing negative press or so
<bitcoin-git>
[bitcoin] naumenkogs closed pull request #18421: Periodically update DNS caches for better privacy of non-reachable nodes (master...2020_03_dns_cache_update) https://github.com/bitcoin/bitcoin/pull/18421
<bitcoin-git>
[gui] hebasto merged pull request #430: Improvements to the open up transaction in third-party link action (master...3party-tx-links-cleanup) https://github.com/bitcoin-core/gui/pull/430
<Guest5751>
would be IPFS, which is starting to catch on. For the binaries themselves there’s already the option of downloading through torrents." Do you know if anyone is already hosting Bitcoin's source code on IPFS?
<bitcoin-git>
[bitcoin] dougEfresh opened pull request #23128: doc: Remove TODO 'exclude peers with download permission' (master...remove-todo-max-dl-permission) https://github.com/bitcoin/bitcoin/pull/23128
<bitcoin-git>
[bitcoin] dougEfresh closed pull request #23109: net: Bypass increasing nMaxOutbound for peers with download permission (master...max_update_exclude_dl_perm) https://github.com/bitcoin/bitcoin/pull/23109
<bitcoin-git>
[bitcoin] vincenzopalazzo opened pull request #23127: tests: Use test utils each time that it is possible (master...tests/use_testutils) https://github.com/bitcoin/bitcoin/pull/23127
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23079: test: use MiniWallet for p2p_filter.py (master...202109-test-use_MiniWallet_for_p2p_filter) https://github.com/bitcoin/bitcoin/pull/23079
<bitcoin-git>
bitcoin/master fa46768 MarcoFalke: test: Remove unused and confusing main parameter from script_util
<bitcoin-git>
bitcoin/master 7d4ea7c MarcoFalke: Merge bitcoin/bitcoin#23120: test: Remove unused and confusing main parame...
<bitcoin-git>
bitcoin/master fa54efd MarcoFalke: test: pep-8 touched test
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23124: Fix feature_segwit.py failure due to witness (master...202109_fix_feature_segwit) https://github.com/bitcoin/bitcoin/pull/23124
<bitcoin-git>
[bitcoin] fanquake merged pull request #23122: doc: Remove un-actionable TODO from chainparams.cpp (master...2109-docTodo) https://github.com/bitcoin/bitcoin/pull/23122
2021-09-28
<bitcoin-git>
[bitcoin] mjdietzx closed pull request #23091: fuzz: fix checks on number of required sigs and keys in multisig scripts (master...fuzz_extract_destinations_bug_fix) https://github.com/bitcoin/bitcoin/pull/23091
<bitcoin-git>
[bitcoin] meshcollider merged pull request #20591: wallet, bugfix: fix ComputeTimeSmart function during rescanning process. (master...fix-computetimesmart) https://github.com/bitcoin/bitcoin/pull/20591
<bitcoin-git>
bitcoin/master d6eb39a BitcoinTsunami: test: add functional test to check transaction time determination during b...
<bitcoin-git>
bitcoin/master 240ea29 BitcoinTsunami: doc: update doxygen documention of ComputeTimeSmart() and AddToWalletIfInv...
<bitcoin-git>
bitcoin/master 07b44f1 BitcoinTsunami: wallet: fix ComputeTimeSmart algorithm to use blocktime during old block r...
<bitcoin-git>
[bitcoin] meshcollider merged pull request #22722: rpc: update estimatesmartfee to return max of CBlockPolicyEstimator::estimateSmartFee, mempoolMinFee and minRelayTxFee (master...estimatesmartfee) https://github.com/bitcoin/bitcoin/pull/22722
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23122: doc: Remove un-actionable TODO from chainparams.cpp (master...2109-docTodo) https://github.com/bitcoin/bitcoin/pull/23122
<bitcoin-git>
[bitcoin] glozow opened pull request #23121: [policy] check ancestor feerate in RBF, remove BIP125 Rule2 (master...ancestorscore-remove-bip1252) https://github.com/bitcoin/bitcoin/pull/23121
<prayank>
504 2021-09-28T16:09:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection) 505 2021-09-28T16:09:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23097: Run specified functional tests with all matching flags (master...202109_tests_matchall) https://github.com/bitcoin/bitcoin/pull/23097
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23120: test: Remove unused and confusing main parameter from script_util (master...2109-testCleanupScript) https://github.com/bitcoin/bitcoin/pull/23120
<bitcoin-git>
bitcoin/master efa227f W. J. van der Laan: Merge bitcoin/bitcoin#23097: Run specified functional tests with all match...
<bitcoin-git>
bitcoin/master b8909b0 Samuel Dobson: Run functional tests with all possible flags
<prayank>
I am trying to understand https://github.com/bitcoin/bitcoin/projects/11. After reading lot of comments in few PRs and issues I realised it's beyond my understanding and some PRs are already merged. Is this going to be an option like assumeutxo=1 will help in bootstrapping else it will work same by default? Or we have changed default behaviour for this project in Core?
<bitcoin-git>
[bitcoin] fanquake merged pull request #23117: test: Use assert_equal over assert for easier debugging (master...2109-testAssertEq) https://github.com/bitcoin/bitcoin/pull/23117
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23117: test: Use assert_equal over assert for easier debugging (master...2109-testAssertEq) https://github.com/bitcoin/bitcoin/pull/23117
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23106: Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI (master...202109_walletprocesspsbt_unlocked) https://github.com/bitcoin/bitcoin/pull/23106
<bitcoin-git>
bitcoin/master 0e89521 Samuel Dobson: Ensure wallet is unlocked before signing in walletprocesspsbt
<bitcoin-git>
bitcoin/master 0f3acec Samuel Dobson: Add test that walletprocesspsbt requires unlocked wallet when signing
<bitcoin-git>
bitcoin/master 7e3ee4c Samuel Dobson: GUI: Ask user to unlock wallet before signing psbt
<gribble>
https://github.com/bitcoin/bitcoin/issues/23106 | Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI by meshcollider · Pull Request #23106 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] fanquake opened pull request #23115: bloom: use Span instead of std::vector for `insert` and `contains` (#18985) (master...18985_rebased) https://github.com/bitcoin/bitcoin/pull/23115
<bitcoin-git>
[bitcoin] meshcollider merged pull request #22938: test: Add remaining scenarios of 0 waste, in wallet waste_test (master...waste-test-add) https://github.com/bitcoin/bitcoin/pull/22938
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23113: Add warnings to createmultisig and addmultisig if using uncompressed keys (master...202109_createmultisig_warnings) https://github.com/bitcoin/bitcoin/pull/23113
<bitcoin-git>
[bitcoin] meshcollider merged pull request #17526: Add Single Random Draw as an additional coin selection algorithm (master...srd-fallback-2) https://github.com/bitcoin/bitcoin/pull/17526
<bitcoin-git>
bitcoin/master dc10ca3 Sjors Provoost: net: switch to signet DNS seed
<bitcoin-git>
bitcoin/master 68bbfcc W. J. van der Laan: Merge bitcoin/bitcoin#23021: net: switch to signet DNS seed
<bitcoin-git>
[bitcoin] laanwj merged pull request #22579: doc: Add references for the generator/constant used in Bech32(m) (master...202107_bech32_doc) https://github.com/bitcoin/bitcoin/pull/22579
<bitcoin-git>
bitcoin/master 16a5997 W. J. van der Laan: Merge bitcoin/bitcoin#22579: doc: Add references for the generator/constan...
<bitcoin-git>
bitcoin/master b8cd2a4 Pieter Wuille: Add references for the generator/constant used in Bech32(m)
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23106: Ensure wallet is unlocked before signing in walletprocesspsbt (master...202109_walletprocesspsbt_unlocked) https://github.com/bitcoin/bitcoin/pull/23106
<bitcoin-git>
[bitcoin] laanwj merged pull request #22892: doc: Clarify that change_cost cannot be negative in GetSelectionWaste (master...doc-change-cost-not-negative) https://github.com/bitcoin/bitcoin/pull/22892
<bitcoin-git>
bitcoin/master d2eccac benthecarman: doc: Clarify that change_cost cannot be negative in GetSelectionWaste
<bitcoin-git>
bitcoin/master 07e743e W. J. van der Laan: Merge bitcoin/bitcoin#22892: doc: Clarify that change_cost cannot be negat...
<bitcoin-git>
[gui] meshcollider opened pull request #436: Include vout when copying transaction ID from coin selection (master...202109_coinselection_copy_vout) https://github.com/bitcoin-core/gui/pull/436
<bitcoin-git>
[bitcoin] laanwj merged pull request #23102: test: Add missing re.escape() to feature_addrman test (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/23102