2021-09-27

<glozow> Question: why is the fee estimator managed by `CTxMemPool` instead of subscribed to `CValidationInterface`? https://github.com/bitcoin/bitcoin/pull/10199/files#r115530273 suggests that we might want that?
<bitcoin-git> [bitcoin] laanwj merged pull request #23021: net: switch to signet DNS seed (master...2021/09/signet_dns_seed) https://github.com/bitcoin/bitcoin/pull/23021
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/16a5997336b4...68bbfcc25058
<bitcoin-git> bitcoin/master dc10ca3 Sjors Provoost: net: switch to signet DNS seed
<bitcoin-git> bitcoin/master 68bbfcc W. J. van der Laan: Merge bitcoin/bitcoin#23021: net: switch to signet DNS seed
<bitcoin-git> [bitcoin] laanwj merged pull request #22579: doc: Add references for the generator/constant used in Bech32(m) (master...202107_bech32_doc) https://github.com/bitcoin/bitcoin/pull/22579
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/07e743edd013...16a5997336b4
<bitcoin-git> bitcoin/master 16a5997 W. J. van der Laan: Merge bitcoin/bitcoin#22579: doc: Add references for the generator/constan...
<bitcoin-git> bitcoin/master b8cd2a4 Pieter Wuille: Add references for the generator/constant used in Bech32(m)
<bitcoin-git> [bitcoin] meshcollider opened pull request #23106: Ensure wallet is unlocked before signing in walletprocesspsbt (master...202109_walletprocesspsbt_unlocked) https://github.com/bitcoin/bitcoin/pull/23106
<bitcoin-git> [bitcoin] laanwj merged pull request #22892: doc: Clarify that change_cost cannot be negative in GetSelectionWaste (master...doc-change-cost-not-negative) https://github.com/bitcoin/bitcoin/pull/22892
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eabc2c482aad...07e743edd013
<bitcoin-git> bitcoin/master d2eccac benthecarman: doc: Clarify that change_cost cannot be negative in GetSelectionWaste
<bitcoin-git> bitcoin/master 07e743e W. J. van der Laan: Merge bitcoin/bitcoin#22892: doc: Clarify that change_cost cannot be negat...
<bitcoin-git> [gui] meshcollider opened pull request #436: Include vout when copying transaction ID from coin selection (master...202109_coinselection_copy_vout) https://github.com/bitcoin-core/gui/pull/436
<bitcoin-git> [bitcoin] laanwj merged pull request #23102: test: Add missing re.escape() to feature_addrman test (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/23102
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8b523f2e5571...eabc2c482aad
<bitcoin-git> bitcoin/master fa01f22 MarcoFalke: test: Add missing re.escape() to feature_addrman test
<bitcoin-git> bitcoin/master eabc2c4 W. J. van der Laan: Merge bitcoin/bitcoin#23102: test: Add missing re.escape() to feature_addr...
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23104: log: Avoid breaking single log lines over multiple lines in the log file (master...2109-logCont) https://github.com/bitcoin/bitcoin/pull/23104
<gribble> https://github.com/bitcoin/bitcoin/issues/17526 | Add Single Random Draw as an additional coin selection algorithm by achow101 · Pull Request #17526 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #23094: doc: Remove outdated comments (master...210925-comment) https://github.com/bitcoin/bitcoin/pull/23094
<bitcoin-git> bitcoin/master 8b523f2 W. J. van der Laan: Merge bitcoin/bitcoin#23094: doc: Remove outdated comments
<bitcoin-git> bitcoin/master ee7891a Hennadii Stepanov: doc: Remove outdated comments
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/632be5514c31...8b523f2e5571
<bitcoin-git> [bitcoin] hebasto opened pull request #23103: ci: Enable feature_asmap.py test on native Windows (master...210927-asmap) https://github.com/bitcoin/bitcoin/pull/23103
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23061: Fix (inverse) meaning of -persistmempool (master...2109-fixArgParse) https://github.com/bitcoin/bitcoin/pull/23061
<bitcoin-git> bitcoin/master 632be55 merge-script: Merge bitcoin/bitcoin#23061: Fix (inverse) meaning of -persistmempool
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/58c25bdcea9b...632be5514c31
<bitcoin-git> bitcoin/master faff17b MarcoFalke: Fix (inverse) meaning of -persistmempool
<bitcoin-git> bitcoin/master faa9c19 MarcoFalke: doc: Add 23061 release notes
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23102: test: Add missing re.escape() to feature_addrman test (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/23102
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23092: test: Remove Windows workaround in authproxy (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/23092
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ba3f0b2c4817...58c25bdcea9b
<bitcoin-git> bitcoin/master fad0227 MarcoFalke: test: Remove Windows workaround in authproxy
<bitcoin-git> bitcoin/master 58c25bd merge-script: Merge bitcoin/bitcoin#23092: test: Remove Windows workaround in authproxy
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23084: test: avoid non-determinism in asmap-addrman test (master...asmap-addrman-test-assert-on-result-instead-of-log) https://github.com/bitcoin/bitcoin/pull/23084
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/09cb5ec6c8b4...ba3f0b2c4817
<bitcoin-git> bitcoin/master 5825b34 Jon Atack: test: avoid non-determinism in asmap-addrman test
<bitcoin-git> bitcoin/master ba3f0b2 merge-script: Merge bitcoin/bitcoin#23084: test: avoid non-determinism in asmap-addrman ...
<bitcoin-git> [gui] jarolrod opened pull request #435: Move third-party tx URL setting from Display to Wallet options tab (master...move-3partytx-setting) https://github.com/bitcoin-core/gui/pull/435
<TallTim> Sorry if not topical - but google searches only referred me to client pages with no detail. Is there a way to direct the Bitcoin Core client to pull its blocks from a full node I control on the same network? Just seems it would be faster.

2021-09-26

<bitcoin-git> [bitcoin] katesalazar opened pull request #23100: Abort tests early upon filling the test logs drive (master...20210926) https://github.com/bitcoin/bitcoin/pull/23100
<bitcoin-git> [gui] promag opened pull request #434: Keep InitExecutor in main gui thread (master...2021-09-qt-initexecutor) https://github.com/bitcoin-core/gui/pull/434
<gribble> https://github.com/bitcoin/bitcoin/issues/23099 | Handle disk-full more gracefully in functional tests · Issue #23099 · bitcoin/bitcoin · GitHub
<shiza> I'm taking that as "Bitcoin doesn't support running all of the functional tests suite on temporary directories so small".
<bitcoin-git> [bitcoin] laanwj merged pull request #23065: Allow UTXO locks to be written to wallet DB (master...202109_lockunspent_persistence) https://github.com/bitcoin/bitcoin/pull/23065
<bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/16ccb3a1cd91...09cb5ec6c8b4
<bitcoin-git> bitcoin/master c527893 Samuel Dobson: Allow locked UTXOs to be store in the wallet database
<bitcoin-git> bitcoin/master f13fc16 Samuel Dobson: Allow lockunspent to store the lock in the wallet DB
<bitcoin-git> bitcoin/master 719ae92 Samuel Dobson: Update lockunspent tests for lock persistence
<bitcoin-git> [bitcoin] Shubhankar-Gambhir reopened pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
<bitcoin-git> [bitcoin] Shubhankar-Gambhir closed pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
<gribble> https://github.com/bitcoin/bitcoin/issues/23065 | Allow UTXO locks to be written to wallet DB by meshcollider · Pull Request #23065 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23097 | Run specified functional tests with all matching flags by meshcollider · Pull Request #23097 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] meshcollider opened pull request #23097: Run specified functional tests with all matching flags (master...202109_tests_matchall) https://github.com/bitcoin/bitcoin/pull/23097

2021-09-25

<bitcoin-git> [bitcoin] AaronDewes opened pull request #23096: util: Treat empty settings.json file as valid (master...allow-empty-settings-json) https://github.com/bitcoin/bitcoin/pull/23096
<gribble> https://github.com/bitcoin/bitcoin/issues/11146 | addwitnessaddress fails with v0.15.0rc2 · Issue #11146 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] hebasto opened pull request #23095: refactor: Use C++17 std::clamp (master...210925-clamp) https://github.com/bitcoin/bitcoin/pull/23095
<bitcoin-git> [bitcoin] hebasto opened pull request #23094: doc: Remove outdated comments (master...210925-comment) https://github.com/bitcoin/bitcoin/pull/23094
<bitcoin-git> [bitcoin] meshcollider opened pull request #23093: Add ability to flush keypool and always flush when upgrading non-HD to HD (master...202109_keypoolrefill) https://github.com/bitcoin/bitcoin/pull/23093
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23086: test: Add -testactivationheight tests to rpc_blockchain (master...2109-testActH) https://github.com/bitcoin/bitcoin/pull/23086
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/747f91c0a385...16ccb3a1cd91
<bitcoin-git> bitcoin/master 16ccb3a merge-script: Merge bitcoin/bitcoin#23086: test: Add -testactivationheight tests to rpc_...
<bitcoin-git> bitcoin/master fa4ca8d MarcoFalke: test: Add -testactivationheight tests to rpc_blockchain
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23092: test: Remove Windows workaround in authproxy (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/23092
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23089: ci: Increase the dynamic port range to the maximum on native Windows (master...210924-portrange) https://github.com/bitcoin/bitcoin/pull/23089
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/442e32e1179a...747f91c0a385
<bitcoin-git> bitcoin/master 747f91c merge-script: Merge bitcoin/bitcoin#23089: ci: Increase the dynamic port range to the ma...
<bitcoin-git> bitcoin/master 8e08a4b Hennadii Stepanov: ci: Increase the dynamic port range to the maximum on native Windows
<bitcoin-git> bitcoin/master 097ac74 Hennadii Stepanov: ci: Add more functional tests to the native Windows task
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22817: test: Avoid race after connect_nodes (master...2108-testRaceConnect) https://github.com/bitcoin/bitcoin/pull/22817
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03cb2b480bd5...442e32e1179a
<bitcoin-git> bitcoin/master fa04f26 MarcoFalke: test: Avoid race after connect_nodes
<bitcoin-git> bitcoin/master 442e32e merge-script: Merge bitcoin/bitcoin#22817: test: Avoid race after connect_nodes
<bitcoin-git> [bitcoin] mjdietzx opened pull request #23091: fuzz: fix assertion on the number of required sigs in a bare multisig script (master...fuzz_extract_destinations_bug_fix) https://github.com/bitcoin/bitcoin/pull/23091

2021-09-24

<bitcoin-git> [bitcoin] katesalazar opened pull request #23090: Deprecate `main` and `test` `-chain` params (master...20210924) https://github.com/bitcoin/bitcoin/pull/23090
<gribble> https://github.com/bitcoin/bitcoin/issues/19092 | cli: display multiwallet total balance in -getinfo by jonatack · Pull Request #19092 · bitcoin/bitcoin · GitHub
<prayank> A user can lock 1 UTXO associated with some transaction to avoid using it. After few days user relaunches Bitcoin Core, forgets about lock being removed, sends some bitcoin to Binance in which this UTXO is used. Binance asks for source of funds etc.
<gribble> https://github.com/bitcoin/bitcoin/issues/22009 | wallet: Decide which coin selection solution to use based on waste metric by achow101 · Pull Request #22009 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22009 | wallet: Decide which coin selection solution to use based on waste metric by achow101 · Pull Request #22009 · bitcoin/bitcoin · GitHub
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<gribble> https://github.com/bitcoin/bitcoin/issues/17526 | Add Single Random Draw as an additional coin selection algorithm by achow101 · Pull Request #17526 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/23065 | Allow UTXO locks to be written to wallet DB by meshcollider · Pull Request #23065 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/22424 | Sub wallet for dirty coins · Issue #22424 · bitcoin/bitcoin · GitHub
<achow101> I'm pretty sure it was implemented that way because of this comment: https://github.com/bitcoin/bitcoin/pull/12560#issuecomment-377567454
<gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub
<meshcollider> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag
<core-meetingbot> Meeting started Fri Sep 24 19:00:29 2021 UTC. The chair is meshcollider. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<bitcoin-git> [bitcoin] hebasto opened pull request #23089: ci: Increase the dynamic port range to the maximum on native Windows (master...210924-portrange) https://github.com/bitcoin/bitcoin/pull/23089
<bitcoin-git> [bitcoin] hebasto reopened pull request #17786: refactor: Nuke policy/fees->mempool circular dependencies (master...20191221-mempool-circ-dep) https://github.com/bitcoin/bitcoin/pull/17786
<prayank> 3. Martin(one of the maintainers) in this presentation: https://git.gnunet.org/gnunet-videos-2020.git/plain/FOSDEM20/dip_gnunet.webm had explained things nicely. I like lot of things he mentioned in video. 4. Still not ready for Bitcoin Core mainnet.
<bitcoin-git> [bitcoin] laanwj merged pull request #23025: bench: update nanobench add `-min_time` (master...2021-09-update-nanobench) https://github.com/bitcoin/bitcoin/pull/23025
<bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/01b5cfb9511a...03cb2b480bd5
<bitcoin-git> bitcoin/master 468b232 Martin Ankerl: bench: remove unnecessary & incorrect multiplication in MuHashDiv
<bitcoin-git> bitcoin/master eed99cf Martin Ankerl: bench: update nanobench from 4.3.4 to 4.3.6
<bitcoin-git> bitcoin/master 153e686 Martin Ankerl: bench: change AddrManGood to AddrManAddThenGood
<bitcoin-git> [bitcoin] laanwj merged pull request #23047: test: Use MiniWallet in mempool_persist (master...2109-testMempool) https://github.com/bitcoin/bitcoin/pull/23047
<bitcoin-git> bitcoin/master fa32cb2 MarcoFalke: test: Use MiniWallet in mempool_persist
<bitcoin-git> bitcoin/master faca688 MarcoFalke: test: Add MiniWallet get_descriptor function
<bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8e9801bfc4ac...01b5cfb9511a
<bitcoin-git> bitcoin/master fafb7b7 MarcoFalke: test: pep8
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23086: test: Add -testactivationheight tests to rpc_blockchain (master...2109-testActH) https://github.com/bitcoin/bitcoin/pull/23086
<gribble> https://github.com/bitcoin/bitcoin/issues/23074 | Package-aware fee estimation by darosior · Pull Request #23074 · bitcoin/bitcoin · GitHub
<darosior> Ok, opened an issue: wanted to open a quick PR but it seems non trivial https://github.com/bitcoin/bitcoin/issues/23085
<gribble> https://github.com/bitcoin/bitcoin/issues/23074 | Package-aware fee estimation by darosior · Pull Request #23074 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22818: test: Activate all regtest softforks at height 1, unless overridden (master...2108-regtestSoft) https://github.com/bitcoin/bitcoin/pull/22818
<bitcoin-git> bitcoin/master fa086ef MarcoFalke: test: Remove unused ~TestChain100Setup
<bitcoin-git> bitcoin/master fadb2ef MarcoFalke: test: Add extra_args argument to TestChain100Setup constructor
<bitcoin-git> bitcoin/master faa4698 MarcoFalke: test: Remove version argument from build_next_block in p2p_segwit test
<bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b7e360081506...8e9801bfc4ac
<bitcoin-git> [bitcoin] Sjors closed pull request #23000: net: update signet seeds (master...2021/09/signet-seed) https://github.com/bitcoin/bitcoin/pull/23000
<gribble> https://github.com/bitcoin/bitcoin/issues/23021 | net: switch to signet DNS seed by Sjors · Pull Request #23021 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] jonatack opened pull request #23084: test: assert on result instead of log in asmap-addrman test (master...asmap-addrman-test-assert-on-result-instead-of-log) https://github.com/bitcoin/bitcoin/pull/23084
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #23083: rpc: Fail to return undocumented or misdocumented JSON (master...2108-docRpc) https://github.com/bitcoin/bitcoin/pull/23083
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23083: rpc: Fail to return undocumented or misdocumented JSON (master...2108-docRpc) https://github.com/bitcoin/bitcoin/pull/23083
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23083: rpc: Fail to return undocumented or misdocumented JSON (master...2108-docRpc) https://github.com/bitcoin/bitcoin/pull/23083
<bitcoin-git> [bitcoin] fanquake opened pull request #23082: build: improve gexauxval() detection, remove getauxval() weak linking (master...remove_weak_auxval) https://github.com/bitcoin/bitcoin/pull/23082
<bitcoin-git> [gui] jarolrod opened pull request #430: Improvements to the open up transaction in third-party link action (master...3party-tx-links-cleanup) https://github.com/bitcoin-core/gui/pull/430
<bitcoin-git> [bitcoin] fanquake closed pull request #23081: Updated for better readability (master...patch-2) https://github.com/bitcoin/bitcoin/pull/23081
<bitcoin-git> [bitcoin] stevebanik opened pull request #23081: Updated for better readability (master...patch-2) https://github.com/bitcoin/bitcoin/pull/23081
<bitcoin-git> [bitcoin] brunoerg opened pull request #23080: test: check abandoned tx in listsinceblock (master...2021-09-improv-test-listsinceblock) https://github.com/bitcoin/bitcoin/pull/23080
<bitcoin-git> [bitcoin] theStack opened pull request #23079: test: use MiniWallet for p2p_filter.py (master...202109-test-use_MiniWallet_for_p2p_filter) https://github.com/bitcoin/bitcoin/pull/23079

2021-09-23

<bitcoin-git> [bitcoin] laanwj merged pull request #21526: validation: UpdateTip/CheckBlockIndex assumeutxo support (master...2021-03-multi-chainstates) https://github.com/bitcoin/bitcoin/pull/21526
<bitcoin-git> [bitcoin] laanwj pushed 13 commits to master: https://github.com/bitcoin/bitcoin/compare/d8b4b3077fd2...b7e360081506
<bitcoin-git> bitcoin/master ac4051d James O'Beirne: refactor: remove unused assumeutxo methods
<bitcoin-git> bitcoin/master 665072a James O'Beirne: doc: add comment for g_best_block
<bitcoin-git> bitcoin/master 9f6bb53 James O'Beirne: validation: add chainman ref to CChainState
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<luke-jr> laanwj: from some pre-Bitcoin C compiler, ultilately
<BlueMatt> pools have complained that getblocktemplate is horrendously ineffecient for years, it needs to go, plus there's some other nice wins, see eg the second two bullets at https://github.com/bitcoin/bitcoin/pull/23049#issuecomment-926009122
<luke-jr> miners and pools using only anti-bootstrappable binaries would be a security concern for Bitcoin too
<sipa> if this is Rust code that is being developed now with the sole purpose of using it in Bitcoin Core, I too would prefer it being written in C++
<laanwj> #topic rust library in bitcoin core (fi3)
<core-meetingbot> topic: rust library in bitcoin core (fi3)
<gribble> https://github.com/bitcoin/bitcoin/issues/22950 | [p2p] Pimpl AddrMan to abstract implementation details by amitiuttarwar · Pull Request #22950 · bitcoin/bitcoin · GitHub
<michaelfolkson> Bitcoin Core PR review club on #22950 next week
<gribble> https://github.com/bitcoin/bitcoin/issues/21526 | validation: UpdateTip/CheckBlockIndex assumeutxo support by jamesob · Pull Request #21526 · bitcoin/bitcoin · GitHub
<laanwj> according to https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 2 chasing concept ACK
<laanwj> one proposed topic this week: rust library in bitcoin core (fi3)
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
<core-meetingbot> Meeting started Thu Sep 23 19:00:14 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<michaelfolkson> fi3: There may have been advancements since this was discussed last but some context from previous discussions on Rust is here: https://github.com/bitcoin/bitcoin/issues/17090
<michaelfolkson> #proposedmeetingtopic (by fi3) rust library in bitcoin core (23049)
<sipa> #proposedwalletmeetingtopic (by fi3) rust library in bitcoin core (23049)
<fi3> in core. In a comment on this PR https://github.com/bitcoin/bitcoin/pull/23049 luke-jr point out
<gribble> https://github.com/bitcoin/bitcoin/issues/23075 | refactoring: Fee estimation functional test cleanups by darosior · Pull Request #23075 · bitcoin/bitcoin · GitHub
<jonatack> yes, on mainnet the most frequent contentions I see are the cs_vNodes ones, and many/most on them were replaced by only a handful of connman.cs_vNodes contention *per hour* instead...grep "connman.cs_vNodes" ~/.bitcoin/debug.log
<gribble> https://github.com/bitcoin/bitcoin/issues/21943 | Dedup and RAII-fy the creation of a copy of CConnman::vNodes by vasild · Pull Request #21943 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] vasild opened pull request #23077: Full CJDNS support (master...cjdns) https://github.com/bitcoin/bitcoin/pull/23077
<bitcoin-git> [bitcoin] laanwj merged pull request #23057: log: Consolidate timedata logging (master...202109_log_timedata) https://github.com/bitcoin/bitcoin/pull/23057
<bitcoin-git> bitcoin/master 64e1ddd Martin Zumsande: log: call LogPrint only once with time data samples
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95b16e70a8b7...d8b4b3077fd2
<bitcoin-git> bitcoin/master d8b4b30 W. J. van der Laan: Merge bitcoin/bitcoin#23057: log: Consolidate timedata logging
<bitcoin-git> [bitcoin] jonatack opened pull request #23076: Pass CFeeRate and CTxMemPool in-params by reference to const (master...feerate-and-txmempool-fixups) https://github.com/bitcoin/bitcoin/pull/23076
<bitcoin-git> [bitcoin] darosior opened pull request #23075: refactoring: Fee estimation functional test cleanups (master...fee_est_test_cleanup) https://github.com/bitcoin/bitcoin/pull/23075
<bitcoin-git> [bitcoin] darosior opened pull request #23074: Package-aware fee estimation (master...fee_est_cpfp) https://github.com/bitcoin/bitcoin/pull/23074
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23072: log: Remove unnecessary timing of Callbacks bench (master...23071_remove_callback_bench) https://github.com/bitcoin/bitcoin/pull/23072
<bitcoin-git> bitcoin/master ab27800 Douglas Chimento: log: Remove unnecessary timing logs for Callbacks bench
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cdce149050c9...95b16e70a8b7
<bitcoin-git> bitcoin/master 95b16e7 merge-script: Merge bitcoin/bitcoin#23072: log: Remove unnecessary timing of Callbacks b...
<gribble> https://github.com/bitcoin/bitcoin/issues/23057 | log: Consolidate timedata logging by mzumsande · Pull Request #23057 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] laanwj merged pull request #23045: build: Restrict check for CRC32C intrinsic to aarch64 (master...2021-09-arm64-crc32) https://github.com/bitcoin/bitcoin/pull/23045
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86c3b8438881...cdce149050c9
<bitcoin-git> bitcoin/master f2747d1 W. J. van der Laan: build: Restrict check for CRC32C intrinsic to aarch64
<bitcoin-git> bitcoin/master cdce149 W. J. van der Laan: Merge bitcoin/bitcoin#23045: build: Restrict check for CRC32C intrinsic to...
<bitcoin-git> [bitcoin] fanquake pushed tag v0.21.2: https://github.com/bitcoin/bitcoin/compare/v0.21.2
<bitcoin-git> [bitcoin] fanquake merged pull request #22858: [0.21] Final changes for 0.21.2 (0.21...potential_0_21_rc3_backports) https://github.com/bitcoin/bitcoin/pull/22858
<bitcoin-git> bitcoin/0.21 6c102a6 fanquake: release: bump RC to 0 (-final)
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/97d3500601c1...af591f2068d0
<bitcoin-git> bitcoin/0.21 f78570e Pieter Wuille: doc: mention bech32m/BIP350 in doc/descriptors.md
<bitcoin-git> bitcoin/0.21 af591f2 fanquake: Merge bitcoin/bitcoin#22858: [0.21] Final changes for 0.21.2
<bitcoin-git> [bitcoin] fanquake merged pull request #23036: test: use test_framework.p2p `P2P_SERVICES` constant in functional tests (master...use-test_framework-P2P_SERVICES-in-functional-tests) https://github.com/bitcoin/bitcoin/pull/23036
<bitcoin-git> bitcoin/master 86c3b84 fanquake: Merge bitcoin/bitcoin#23036: test: use test_framework.p2p `P2P_SERVICES` c...
<bitcoin-git> bitcoin/master b69a106 Jon Atack: test: use test_framework.p2p P2P_SERVICES in functional tests
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8bda5e0988e1...86c3b8438881
<bitcoin-git> [bitcoin] dougEfresh opened pull request #23072: refactor: Remove unnecessary timing of Callbacks bench (master...23071_remove_callback_bench) https://github.com/bitcoin/bitcoin/pull/23072
<bitcoin-git> [bitcoin] fanquake merged pull request #22855: RBF move 3/3: move followups + improve RBF documentation (master...2021-09-rbf-docs) https://github.com/bitcoin/bitcoin/pull/22855
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b8cca9cac764...8bda5e0988e1
<bitcoin-git> bitcoin/master 3cf46f6 glozow: [doc] improve RBF documentation
<bitcoin-git> bitcoin/master c78eb86 glozow: [policy/refactor] pass in relay fee instead of using global
<bitcoin-git> bitcoin/master c6abeb7 glozow: make MAX_BIP125_RBF_SEQUENCE constexpr
<gribble> https://github.com/bitcoin/bitcoin/issues/23060 | release: increase minimum compiler and lib(std)c++ requirements by fanquake · Pull Request #23060 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake merged pull request #23059: test: Revert "Add missing suppression signed-integer-overflow:addrman.cpp" (master...2109-testSanSupU) https://github.com/bitcoin/bitcoin/pull/23059
<bitcoin-git> bitcoin/master fa5e8c1 MarcoFalke: Revert "test: Add missing suppression signed-integer-overflow:addrman.cpp"...
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3120bceeafcb...b8cca9cac764
<bitcoin-git> bitcoin/master b8cca9c fanquake: Merge bitcoin/bitcoin#23059: test: Revert "Add missing suppression signed-...
<bitcoin-git> [bitcoin] fanquake merged pull request #23054: Use C++11 member initializer in CTxMemPoolEntry (master...2109-cpp11MemberInitMempool) https://github.com/bitcoin/bitcoin/pull/23054
<bitcoin-git> bitcoin/master fa08d4c MarcoFalke: Use C++11 member initializer in CTxMemPoolEntry
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/faecb2ee0a0a...3120bceeafcb
<bitcoin-git> bitcoin/master 3120bce fanquake: Merge bitcoin/bitcoin#23054: Use C++11 member initializer in CTxMemPoolEnt...
<bitcoin-git> [bitcoin] fanquake merged pull request #22798: doc: Fix RPC result documentation (master...2108-docRpc) https://github.com/bitcoin/bitcoin/pull/22798
<bitcoin-git> bitcoin/master fa10fbc MarcoFalke: doc: Fix RPC result documentation
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/971cad475f38...faecb2ee0a0a
<bitcoin-git> bitcoin/master faecb2e fanquake: Merge bitcoin/bitcoin#22798: doc: Fix RPC result documentation
<gribble> https://github.com/bitcoin/bitcoin/issues/22720 | v0.21.2 Testing · Issue #22720 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21330 | Deal with missing data in signature hashes more consistently by sipa · Pull Request #21330 · bitcoin/bitcoin · GitHub
<jarolrod> ^ yes, and that is the first website to come up when someone googles bitcoin
<gribble> ugh.. double your bitcoin scam on bitcoin.org

2021-09-22

<fanquake> As for 0.20.2rc3, jonasschnelli: are you able to push some sigs up https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.20 ?
<gribble> https://github.com/bitcoin/bitcoin/issues/22858 | [0.21] Potential rc3 backports by fanquake · Pull Request #22858 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] sipa closed pull request #23070: Bitcoinrupee (master...Bitcoinrupee) https://github.com/bitcoin/bitcoin/pull/23070
<bitcoin-git> [bitcoin] ryanofsky reopened pull request #22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (master...pr/u8path) https://github.com/bitcoin/bitcoin/pull/22937
<bitcoin-git> [bitcoin] ryanofsky closed pull request #22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (master...pr/u8path) https://github.com/bitcoin/bitcoin/pull/22937
<bitcoin-git> [bitcoin] amjadshaheed opened pull request #23070: Bitcoinrupee (master...Bitcoinrupee) https://github.com/bitcoin/bitcoin/pull/23070
<bitcoin-git> [bitcoin] katesalazar opened pull request #23068: Add aliases to the `-chain` param (master...20210922) https://github.com/bitcoin/bitcoin/pull/23068
<bitcoin-git> [bitcoin] laanwj closed pull request #23067: Adding link to original bitcoin whitepaper (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23067
<bitcoin-git> [bitcoin] stevebanik opened pull request #23067: Adding link to original bitcoin whitepaper (master...patch-1) https://github.com/bitcoin/bitcoin/pull/23067
<jeremyrubin> I think what we'd want is to remove the http support from Bitcoin core and then build a separate binary with a simple http proxy to it
<sipa> you can also use bitcoin core RPC in a local trusted network
<sipa> *anything* could have been chosen for bitcoin core's RPC interface, but the one that was chosen was json-rpc over http with user/pass authentication
<sipa> michaelfolkson: c-lightning just calls bitcoin-cli
<michaelfolkson> laanwj: What is/was the answer to this question? https://github.com/bitcoin/bitcoin/pull/9919#issuecomment-841577083
<dviola> sipa: someone already reported it: https://github.com/bitcoin-core/gui/issues/429
<bitcoin-git> [bitcoin] fanquake closed pull request #22966: doc: Improve documentation around the ACK statement (master...ack-documentation) https://github.com/bitcoin/bitcoin/pull/22966
<bitcoin-git> [bitcoin] meshcollider opened pull request #23065: Allow UTXO locks to be written to wallet DB (master...202109_lockunspent_persistence) https://github.com/bitcoin/bitcoin/pull/23065
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23064: fuzz: Fix memory leak in system fuzz target (master...2109-fuzzMemLeakSys) https://github.com/bitcoin/bitcoin/pull/23064
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23044: refactor: Remove unused validation includes (master...2109-valInc) https://github.com/bitcoin/bitcoin/pull/23044
<bitcoin-git> bitcoin/master fa45a13 MarcoFalke: refactor: Remove unused validation includes
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51c7d88e6790...971cad475f38
<bitcoin-git> bitcoin/master 971cad4 merge-script: Merge bitcoin/bitcoin#23044: refactor: Remove unused validation includes
<MarcoFalke> paulo: See also https://github.com/MarcoFalke/bitcoin-core/issues/18 for an entry point to getting started (if you need one)
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23061: Fix (inverse) meaning of -persistmempool (master...2109-fixArgParse) https://github.com/bitcoin/bitcoin/pull/23061
<prayank> paulo: There are lot of things to work on. You can start with https://github.com/bitcoin/bitcoin/issues/22368 (It's less than 20 lines of code if correctly done but nobody wants to work on it for some reason)
<prayank> paulo: if you have things in wishlist that improve privacy in bitcoin core but you don't feel like creating an issue in the repository, feel free to write them down in a gist and share the link here. Will be helpful.
<bitcoin-git> [bitcoin] fanquake opened pull request #23060: release: increase minimum compiler and lib(std)c++ requirements (master...23_0_min_compiler_libcpp_requires) https://github.com/bitcoin/bitcoin/pull/23060
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23059: Revert "test: Add missing suppression signed-integer-overflow:addrman.cpp" (master...2109-testSanSupU) https://github.com/bitcoin/bitcoin/pull/23059
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22790: test: add aarch64-apple-darwin platform entry to get_previous_releases (master...add-aarch64-apple-darwin-get-prev-releases) https://github.com/bitcoin/bitcoin/pull/22790
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a8a272ac329d...51c7d88e6790
<bitcoin-git> bitcoin/master f6e4db2 Zero-1729: test: add aarch64-apple-darwin platform entry to get_previous_releases
<bitcoin-git> bitcoin/master 51c7d88 merge-script: Merge bitcoin/bitcoin#22790: test: add aarch64-apple-darwin platform entry...
<prayank> instagibbs: 1. Not sure tbh how will things change if different mempool policies are used however it looks less likely in near future looking at the trend. Most users will run Bitcoin Core and they will use defaults. 2. Things are simple. There are blocks which get mined every few minutes. Blocks have limit based on vsize or weight. So everyone is bidding and competing to get their transactions confirmed. There is nothing to estimate or predict but
<dviola> when I receive a tx in bitcoin core 22.0.0 the clock icon (before the date field) in the Transactions tab says I have 1 of 6 confirmations

2021-09-21

<bitcoin-git> [bitcoin] kallewoof reopened pull request #22776: rpc/wallet: add optional transaction(s) to getbalances (master...202108-getbalances-tx) https://github.com/bitcoin/bitcoin/pull/22776
<bitcoin-git> [bitcoin] mzumsande opened pull request #23057: log: Consolidate timedata logging (master...202109_log_timedata) https://github.com/bitcoin/bitcoin/pull/23057
<prayank> jeremyrubin: Is sapio a different programming language? Is it possible or will ever be possible to write bitcoin smart contracts using normal programing languages like C#? Somone had asked a related question here: https://www.reddit.com/r/csharp/comments/phqwg2/is_smart_contract_development_with_c_possible/hbl48g1
<prayank> If I want to buy bitcoin right now, I will look at the orderbook and create limit buy order at 42200. I won't check last 1000 trades because they don't matter if goal is to buy bitcoin asap.
<prayank> darosior: I think we need to fix fee estimation logic used in `estimatesmartfee` first. Had suggested few things here: https://github.com/bitcoin/bitcoin/pull/22722#issuecomment-901907447
<laanwj> but sure, agree it makes sense to prefix, all the bitcoin-core channels were prefixed with bitcoin-core when moving to libera
<jeremy> not sure who owns the #bitcoin namespace tho
<jeremy> yes, aware of that. I think it's that they prefer whoever owns the #bitcoin namespace should encourage/assist allocating bip reviews as ##bitcoin-bip-review-<name> or something going forward.
<jeremy> laanwj, not sure if you "own" the IRC, but as a general rule the #libera folk asked me to relay that they strongly prefer we not use channels like ##ctv-bip-review or ##taproot-bip-review in the future and instead namespace them in #bitcoin
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22734: addrman: Avoid crash on corrupt data, Force Check after deserialize (master...2108-addrmanNoCrash) https://github.com/bitcoin/bitcoin/pull/22734
<bitcoin-git> bitcoin/master fae5c63 MarcoFalke: move-only: Move CAddrMan::Check to cpp file
<bitcoin-git> bitcoin/master fa29897 MarcoFalke: Refactor: Turn the internal addrman check helper into a forced check
<bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ae674a0198b0...a8a272ac329d
<bitcoin-git> bitcoin/master fa7a883 MarcoFalke: addrman: Replace assert with throw on corrupt data
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22998: test: use MiniWallet for make_utxo helper in feature_rbf.py (master...202109-test-use_miniwallet_for_make_utxo) https://github.com/bitcoin/bitcoin/pull/22998
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8f022a59b8bd...ae674a0198b0
<bitcoin-git> bitcoin/master d1e2481 Sebastian Falbesoner: test: scale amounts in test_doublespend_chain down by factor 10
<bitcoin-git> bitcoin/master 0f27524 Sebastian Falbesoner: test: scale amounts in test_doublespend_tree down by factor 10
<bitcoin-git> bitcoin/master f680d27 Sebastian Falbesoner: test: use MiniWallet for make_utxo helper in feature_rbf.py
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #22798: doc: Fix RPC result documentation (master...2108-docRpc) https://github.com/bitcoin/bitcoin/pull/22798
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #22798: doc: Fix RPC result documentation (master...2108-docRpc) https://github.com/bitcoin/bitcoin/pull/22798
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23054: Use C++11 member initializer in CTxMemPoolEntry (master...2109-cpp11MemberInitMempool) https://github.com/bitcoin/bitcoin/pull/23054
<bitcoin-git> [bitcoin] kallewoof closed pull request #22776: rpc/wallet: add optional transaction(s) to getbalances (master...202108-getbalances-tx) https://github.com/bitcoin/bitcoin/pull/22776
<bitcoin-git> [bitcoin] jnewbery opened pull request #23053: [fuzz] Use public methods in addrman fuzz tests (master...2021-09-addrman-fuzzer-public-methods2) https://github.com/bitcoin/bitcoin/pull/23053
<bitcoin-git> [bitcoin] Shubhankar-Gambhir opened pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
<bitcoin-git> [bitcoin] fanquake merged pull request #22993: build: set OSX_MIN_VERSION to 10.15 (master...macos_minimum_10_15) https://github.com/bitcoin/bitcoin/pull/22993
<bitcoin-git> bitcoin/master 8f022a5 fanquake: Merge bitcoin/bitcoin#22993: build: set OSX_MIN_VERSION to 10.15
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/223ad2fd0d35...8f022a59b8bd
<bitcoin-git> bitcoin/master a43b8e9 fanquake: build: set OSX_MIN_VERSION to 10.15
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22831: test: add addpeeraddress "tried", test addrman checks on restart with asmap (master...addrman-asmap-init-order-test) https://github.com/bitcoin/bitcoin/pull/22831
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0c1a39390f67...223ad2fd0d35
<bitcoin-git> bitcoin/master ef242f5 Jon Atack: Allow passing "tried" to rpc addpeeraddress to call CAddrMan::Good()
<bitcoin-git> bitcoin/master 869f136 Jon Atack: Add test for rpc addpeeraddress with "tried" argument
<bitcoin-git> bitcoin/master cdaab90 Jon Atack: Add test for addrman consistency check on restart with asmap
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23041: test: Add addrman deserialization error tests (master...2109-testAddrmanDeser) https://github.com/bitcoin/bitcoin/pull/23041
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/89447a63b9cc...0c1a39390f67
<bitcoin-git> bitcoin/master faa81f9 MarcoFalke: test: Add addrman deserialization error tests
<bitcoin-git> bitcoin/master 0c1a393 merge-script: Merge bitcoin/bitcoin#23041: test: Add addrman deserialization error tests...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23017: test: Replace MiniWallet scan_blocks with rescan_utxos (master...2109-testMiniWalletCleanup) https://github.com/bitcoin/bitcoin/pull/23017
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23050: log: change an incorrect fee to fee rate, and vice-versa (master...fee-vs-feerate) https://github.com/bitcoin/bitcoin/pull/23050
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1260b7e483f1...eb180d807a0e
<bitcoin-git> bitcoin/master c17f554 Jon Atack: Fix BlockAssembler::AddToBlock, CTxMemPool::PrioritiseTransaction logging
<bitcoin-git> bitcoin/master eb180d8 merge-script: Merge bitcoin/bitcoin#23050: log: change an incorrect fee to fee rate, and...
<bitcoin-git> [bitcoin] fanquake merged pull request #23001: doc: Enable TLS in links in documentation (master...docs-tls) https://github.com/bitcoin/bitcoin/pull/23001
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4ae0008d81e...1260b7e483f1
<bitcoin-git> bitcoin/master 9bdda50 Jeremy Rand: Enable TLS in links in documentation
<bitcoin-git> bitcoin/master 1260b7e fanquake: Merge bitcoin/bitcoin#23001: doc: Enable TLS in links in documentation
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23014: ci: Bump distro version, disable feature_bind_extra for two configurations (master...2109-ciUpdates) https://github.com/bitcoin/bitcoin/pull/23014
<bitcoin-git> [bitcoin] fanquake merged pull request #23043: ci: Set --nocleanup for Windows functional tests (master...2109-ciWinCleanup) https://github.com/bitcoin/bitcoin/pull/23043
<bitcoin-git> bitcoin/master 133446f fanquake: Merge bitcoin/bitcoin#23043: ci: Set --nocleanup for Windows functional te...
<bitcoin-git> bitcoin/master fac67b3 MarcoFalke: ci: Set --nocleanup for Windows functional tests
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f7bd3111cdc...133446f3dcb8

2021-09-20

<achow101> sipa: I had left the same comment during review: https://github.com/bitcoin/bitcoin/pull/12677#discussion_r707609663
<bitcoin-git> [bitcoin] gruve-p closed pull request #22961: Update zmq to 4.3.4 (master...zmq-update) https://github.com/bitcoin/bitcoin/pull/22961
<gribble> https://github.com/bitcoin/bitcoin/issues/22689 | rpc: deprecate top-level fee fields in getmempool RPCs by josibake · Pull Request #22689 · bitcoin/bitcoin · GitHub
<Kiminuo> jonatack: https://github.com/bitcoin/bitcoin/pull/12677#pullrequestreview-759043318 - I don't really want to try to beat somebody in addressing these but I should have some time over the coming days to address that so I'll do it, ok? Saying that just because I don't want to compete with somebody
<Kiminuo> I should really check it here https://github.com/bitcoin/bitcoin/pull/21422 then :)
<bitcoin-git> [bitcoin] jonatack opened pull request #23050: log: change an incorrect fee to fee rate, and vice-versa (master...fee-vs-feerate) https://github.com/bitcoin/bitcoin/pull/23050