< queip>
fanquake: FYI this is same guy that in past days is running around various IRC channels, threatens to kill Bitcoin developers. He rambles about Zeronet (which he ~falsely claims to be top developer of), about politics, bitcoin wiki, uses VPN, switches nicks, runs some scam foundation for "human rights"
< bosch-0>
Next Bitcoin Core design call is scheduled for next Wednesday at 9:00AM UTC - https://github.com/BitcoinDesign/Meta/issues/40 - For discussion around this join ##bitcoin-core-gui
2020-10-28
< bitcoin-git>
[bitcoin] achow101 opened pull request #20260: wallet: Create named SQLite wallet files instead of wallet directories (master...single-file-sqlite) https://github.com/bitcoin/bitcoin/pull/20260
< bitcoin-git>
[gui] hebasto opened pull request #123: rpc: Do not accept command while executing another one (master...201028-prompt) https://github.com/bitcoin-core/gui/pull/123
< gribble>
https://github.com/bitcoin/bitcoin/issues/19960 | build: The vcpkg tool has introduced a proper way to use manifests by sipsorcery · Pull Request #19960 · bitcoin/bitcoin · GitHub
< wumpus>
jnewbery: previous PRs like it might be a guide there (#18506, #16999), e.g. people could try to repeat the last step in https://github.com/bitcoin/bitcoin/tree/master/contrib/seeds#seeds and see if it ends up with the same .h file, you could also repeat the entire process but as the list of peers from the seeder will be different every time that will give a (slightly, hopefully)
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #16856: Do not allow descendants of BLOCK_FAILED_VALID blocks to be BLOCK_FAILED_VALID (master...2019-09-invalidate-block-child-invalid) https://github.com/bitcoin/bitcoin/pull/16856
2020-10-27
< sipa>
bip322 proves the ability to spend coins sent to a particular bitcoin address; a lightning equivalent sounds like it would need a lightning-specific solution
< bitcoin-git>
[bitcoin] fanquake closed pull request #20224: doc: CI system link added, clarity increased (squashed into a single commit) (master...master) https://github.com/bitcoin/bitcoin/pull/20224
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20247: fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 serialization. (master...fuzzers-netaddr-post-addrv2) https://github.com/bitcoin/bitcoin/pull/20247
< bitcoin-git>
bitcoin/master fa463f1 MarcoFalke: Merge #20247: fuzz: Check for addrv1 compatibility before using addrv1 ser...
< bitcoin-git>
bitcoin/master 903f3d0 practicalswift: fuzz: Check for addrv1 compatibility before using addrv1 serializer
< bitcoin-git>
[bitcoin] luke-jr opened pull request #20251: Move major version to first version integer as specified by SemVer (master...semver2) https://github.com/bitcoin/bitcoin/pull/20251
< bitcoin-git>
[bitcoin] luke-jr opened pull request #20250: Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely (master...rpcwallet_explicit_fixups) https://github.com/bitcoin/bitcoin/pull/20250
< roconnor>
Strangely BitcoinABC's CNetAddr:IsRoutable() gets miscompiled, but not Bitcoin's. I have no explaination.
< bitcoin-git>
[bitcoin] dgpv opened pull request #20248: Fix test: length of R check in test/key_tests.cpp:key_signature_tests (master...fix-test-key-signature-low-r) https://github.com/bitcoin/bitcoin/pull/20248
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20247: fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 address serialization. (master...fuzzers-netaddr-post-addrv2) https://github.com/bitcoin/bitcoin/pull/20247
< luke-jr>
AdulrunaRedviva: #Bitcoin for user questions, but rephrase it
< wumpus>
AdulrunaRedviva: it's unclear to me what you mean, I suppose you are using multiwallet but what are yo trying to do? to select a wallet for RPC getbalance in bitcoin-cli you can pass -rpcwallet=<walletname>
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20245: test: Run script_assets_test even if built --with-libs=no (master...2010-testAssetTestlibconsensus) https://github.com/bitcoin/bitcoin/pull/20245
< luke-jr>
"Welcome to Bitcoin Core 2022.11. You are using an ancient wallet version, that will not be supported in the next release. Do you want to upgrade now? This will invalidate old backups!"
< sipa>
Murch: the bitcoin core RPC also lets you pass any amount as a string, in case your client library can't produce JSON numbers without going through a floating-point type
< luke-jr>
emzy: but msat isn't an existing unit (in Bitcoin/Core at least)
< sipa>
bitcoin core has no problem with this, it parses the decimals exactly from json, without conversion to a floating point type at any point
< bitcoin-git>
[bitcoin] hebasto opened pull request #20230: wallet: Fix bug when just created encrypted wallet cannot get address (master...201023-signal) https://github.com/bitcoin/bitcoin/pull/20230
< jonasschnelli>
##bitcoin-core-gui
< jonasschnelli>
join #bitcoin-core-gui
< jonasschnelli>
For the one not following the GUI repository: https://github.com/bitcoin-core/gui/pull/108 (interactive mempool statistics). Ideas, reviews and testing welcome
< queip>
kinlo: if yes then great opportunity to ditch github. Or at least prepare to do so in future. if we distribute PRs, Issues, and maybe searching all servers for git remote modules, then we can ignore any such problems. anyway if bitcoin GH is officially mirrored to other gits, wouldn't hurt to promote that knowledge in places
< queip>
I am curious now, they commited some bitcoin.svg just to change git glame to them or something, got rejected, and now are DMCA-mad that their pressious bitcoin.svg sits there in PR? or smth? (besides that svg file is 404 anyway already)
< queip>
MarcoFalke: probably that troll, now asks in #bitcoin with some fake DMCA I guess
< jonasschnelli>
The SV people recently started foundation activity in Switzerland.... I think its them. The webpage also links to bitcoin.com.
< gribble>
https://github.com/bitcoin/bitcoin/issues/20229 | Adding a new Bitcoin logo, and release it under the public domain license. by bitcoin-foundation-admin · Pull Request #20229 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #20229: Adding a new Bitcoin logo, and release it under the public domain license. (master...master) https://github.com/bitcoin/bitcoin/pull/20229
< bitcoin-git>
[bitcoin] bitcoin-foundation-admin opened pull request #20229: Adding a new Bitcoin logo, and release it under the public domain license. (master...master) https://github.com/bitcoin/bitcoin/pull/20229
< jonasschnelli>
I'm again banned in #bitcoin-dev and #bitcoin and #bitcoin-wizards ... if anyone know how to unban: thanks.
< bitcoin-git>
bitcoin/master 49984b4 Jonas Schnelli: Merge bitcoin-core/gui#71: Fix visual quality of text in QR image
< bitcoin-git>
bitcoin/master 6954156 Hennadii Stepanov: qt: Fix visual quality of text in QR image
< luke-jr>
fjahr: Core and Bitcoin are different things
< fjahr>
Major versions means breaking API changes. If we say breaking API changes are breaking consensus changes in Bitcoin wouldn't it make sense to keep 0.x until we have to do a hardfork? I know that's not how people think of the versioning but I think that would make sense.
< sipa>
Bitcoin Core releases are versioned as follows: 0.MAJOR.MINOR, and release candidates are suffixed with rc1, rc2 etc.
< bitcoin-git>
bitcoin/master 9453fbf Jonas Schnelli: Merge #20: Wrap tooltips in the intro window
< bitcoin-git>
bitcoin/master 6ed4bca Hennadii Stepanov: qt: Wrap tooltips in the intro window
< bitcoin-git>
[bitcoin] sushant-varanasi opened pull request #20224: doc: CI system link added, clarity increased (squashed into a single commit) (master...master) https://github.com/bitcoin/bitcoin/pull/20224
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20198: Show name, format and if uses descriptors in bitcoin-wallet tool (master...2020/10/wallet_tool_sqlite) https://github.com/bitcoin/bitcoin/pull/20198
< bitcoin-git>
bitcoin/master b46f37b MarcoFalke: Merge #20198: Show name, format and if uses descriptors in bitcoin-wallet ...
< bitcoin-git>
bitcoin/master fa4074b Jonas Schnelli: Show name, format and if uses descriptors in bitcoin-wallet tool
< bitcoin-git>
[bitcoin] vasild opened pull request #20212: net: fix output of peer address in version message (master...fix_version_message_print) https://github.com/bitcoin/bitcoin/pull/20212
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20211: Use -Wswitch for TxoutType where possible (master...2010-WswitchTxoutType) https://github.com/bitcoin/bitcoin/pull/20211
< fanquake>
jonasschnelli: correct. Mine is "git@github.com:bitcoin-core/gui.git"
< bitcoin-git>
[bitcoin] jonatack opened pull request #20210: net: ensure CNode::m_inbound_onion is inbound, add getter, unit tests (master...CNode-IsInboundOnion) https://github.com/bitcoin/bitcoin/pull/20210
< gribble>
https://github.com/bitcoin/bitcoin/issues/20153 | wallet: do not import a descriptor with hardened derivations into a watch-only wallet by S3RK · Pull Request #20153 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] sipa opened pull request #20207: Follow-up extra comments on taproot code and tests (master...202010_taproot-comments) https://github.com/bitcoin/bitcoin/pull/20207
< bitcoin-git>
[bitcoin] hebasto opened pull request #20206: wallet, refactor: Include headers instead of function declarations (master...201020-headers) https://github.com/bitcoin/bitcoin/pull/20206
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #20198: Show name, format and if uses descriptors in bitcoin-wallet tool (master...2020/10/wallet_tool_sqlite) https://github.com/bitcoin/bitcoin/pull/20198
< gribble>
https://github.com/bitcoin/bitcoin/issues/20187 | Addrman: test-before-evict bugfix and improvements for block-relay-only peers by sdaftuar · Pull Request #20187 · bitcoin/bitcoin · GitHub
< jonasschnelli>
ryanofsky: the reason why I look at that issue is that probably some users have specified --wallet(s) in bitcoin.conf (or CLI parameter) and will eventually run into the load/unload issue
< ryanofsky>
but in general the idea is for the gui to simply reload the same wallets you loaded last time, so you can stop using bitcoin.conf
< ryanofsky>
there maybe be similar cases worth fixing. like if a bitcoin.conf specifies a wallet to load, and you unload it and reload it in the gui, that should not trigger any duplicate wallet error
< jonasschnelli>
I guess the issue if someone creates a wallet with --wallet=mywallet in bitcoin.conf or via cli parameter, unloaded it and loads it again in the GUI (or with load_on_startup), restarts bitcoin with the same parameter will lead to a halt due to a duplicate -wallet parameter?
< bitcoin-git>
[bitcoin] vasild opened pull request #20196: net: fix GetListenPort() to derive the proper port (master...fix_GetListenPort) https://github.com/bitcoin/bitcoin/pull/20196
< bitcoin-git>
[bitcoin] fanquake opened pull request #20195: build: fix mutex detection when building bdb on macOS (master...bdb_xcode12_implicit_function_decleration) https://github.com/bitcoin/bitcoin/pull/20195
< bitcoin-git>
[bitcoin] S3RK opened pull request #20191: wallet, refactor: make DescriptorScriptPubKeyMan agnostic of internal flag (master...remove_m_internal) https://github.com/bitcoin/bitcoin/pull/20191