2020-10-01

< dongcarl> luke-jr: We can talk more about guix on #bitcoin-builds, would very much like to know the problems you ran into
< gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
< wumpus> we could do that starting from next week, after sorting things out, I think we need to postpone things like "sqlite wallet storage" to 0.22 https://github.com/bitcoin/bitcoin/milestone/45
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< wumpus> yep, FWIW today was the translations freeze, feature freeze is in 14 days: https://github.com/bitcoin/bitcoin/issues/18947
< gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 12 blockers, 1 bugfix, 2 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< achow101> if there's a cutoff, it's not consistent. https://travis-ci.org/github/bitcoin/bitcoin/jobs/731742236 ran for 1 hr 17 min and passed
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20056: net: Use Span in ReceiveMsgBytes (master...2010-netSpan) https://github.com/bitcoin/bitcoin/pull/20056
< bitcoin-git> [bitcoin] laanwj merged pull request #18309: zmq: Add support to listen on multiple interfaces (master...zmq-listen-multiple-interfaces) https://github.com/bitcoin/bitcoin/pull/18309
< bitcoin-git> bitcoin/master a0b2e5c nthumann: doc: Add release notes to support multiple interfaces
< bitcoin-git> bitcoin/master b1c3f18 nthumann: doc: Adjust ZMQ usage to support multiple interfaces
< bitcoin-git> bitcoin/master 347c94f Nicolas Thumann: zmq: Add support to listen on multiple interfaces
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/9fc2f011ba17...a0185d90a7f2
< bitcoin-git> [bitcoin] laanwj opened pull request #20055: rpc: Set HTTP Content-Type in bitcoin-cli (master...2020_10_cli_contenttype) https://github.com/bitcoin/bitcoin/pull/20055
< gribble> https://github.com/bitcoin/bitcoin/issues/18309 | zmq: Add support to listen on multiple interfaces by n-thumann · Pull Request #18309 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20054: Remove confusing and useless "unexpected version" warning (master...2010-valRemVerWarn) https://github.com/bitcoin/bitcoin/pull/20054
< wumpus> bitcoin-qt is 31MB, for reference, that includes a large part of whopping qt statically
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20048: chainparams: do not log signet startup messages for other chains (master...signet-startup-logging-bugfix) https://github.com/bitcoin/bitcoin/pull/20048
< bitcoin-git> bitcoin/master 9fc2f01 MarcoFalke: Merge #20048: chainparams: do not log signet startup messages for other ch...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/40aab35e9828...9fc2f011ba17
< bitcoin-git> bitcoin/master 6fccad7 Jon Atack: signet: do not log signet startup messages for other chains
< vasild> MarcoFalke: why those builds on 18750? https://github.com/bitcoin/bitcoin/pull/18750#event-3822788532
< vasild> jonatack: https://github.com/bitcoin/bitcoin/pull/19954#pullrequestreview-499530501 "Should we test for both msg_addr and msg_addrv2?"
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19253: Tests: tidy up address.py and segwit_addr.py (master...2020-06-addr-unit-tests) https://github.com/bitcoin/bitcoin/pull/19253
< bitcoin-git> bitcoin/master 7f639df John Newbery: [tests] Remove unused optional verify_checksum parameter
< bitcoin-git> bitcoin/master 011e784 John Newbery: [tests] Rename segwit encode and decode functions
< bitcoin-git> bitcoin/master e455713 John Newbery: [tests] Move bech32 unit tests to test framework
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/3487e421a7fe...40aab35e9828
< bitcoin-git> [bitcoin] fanquake closed pull request #19785: build: lrelease requires xml if not cross-building (master...200823-xml) https://github.com/bitcoin/bitcoin/pull/19785
< bitcoin-git> [bitcoin] kallewoof closed pull request #20045: upstream: add and use defaulted getters to UniValue (master...202009-defaulted-get) https://github.com/bitcoin/bitcoin/pull/20045
< gribble> https://github.com/bitcoin/bitcoin/issues/20017 | rpc: Add RPCContext by promag · Pull Request #20017 · bitcoin/bitcoin · GitHub
< tryphe> could be, but i have some machines where that behavior happens to other applications, not just bitcoin (i don't run bitcoin on windows though so can't say)

2020-09-30

< sipa> anyone on windows who can try to reproduce this? https://bitcoin.stackexchange.com/q/99273/208
< bitcoin-git> [bitcoin] dongcarl opened pull request #20050: validation bundle 1: Prune (in)direct g_chainman usage related to `::LookupBlockIndex` (master...2020-09-libbitcoinruntime-v4) https://github.com/bitcoin/bitcoin/pull/20050
< bitcoin-git> [bitcoin] hebasto reopened pull request #17428: p2p: Try to preserve outbound block-relay-only connections during restart (master...20191109-anchors) https://github.com/bitcoin/bitcoin/pull/17428
< bitcoin-git> [bitcoin] hebasto closed pull request #17428: p2p: Try to preserve outbound block-relay-only connections during restart (master...20191109-anchors) https://github.com/bitcoin/bitcoin/pull/17428
< bitcoin-git> [bitcoin] jonatack opened pull request #20048: chainparams: do not log signet startup messages for other chains (master...signet-startup-logging-bugfix) https://github.com/bitcoin/bitcoin/pull/20048
< gribble> https://github.com/bitcoin/bitcoin/issues/20014 | doc: Mention signet in -help output by hebasto · Pull Request #20014 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theStack opened pull request #20047: test: use wait_for_{block,header} helpers in p2p_fingerprint.py (master...20200930-test-use-wait-for-block-header-in-fingerprint-py) https://github.com/bitcoin/bitcoin/pull/20047
< bitcoin-git> [bitcoin] laanwj merged pull request #20004: test: Add signet witness commitment section parse tests (master...2009-testSignetParse) https://github.com/bitcoin/bitcoin/pull/20004
< bitcoin-git> bitcoin/master 3487e42 Wladimir J. van der Laan: Merge #20004: test: Add signet witness commitment section parse tests
< bitcoin-git> bitcoin/master fa29b5a MarcoFalke: test: Add signet witness commitment section parse tests
< bitcoin-git> bitcoin/master fa23308 MarcoFalke: Remove gArgs global from CreateChainParams to aid testing
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/72affcb16cad...3487e421a7fe
< bitcoin-git> [bitcoin] ryanofsky opened pull request #20046: depends: Set CMAKE_INSTALL_RPATH for native packages (master...pr/ipc-rpath) https://github.com/bitcoin/bitcoin/pull/20046
< bitcoin-git> [bitcoin] laanwj merged pull request #19802: doc: elaborate on release notes wrt netmasks (master...elaborate_netmasks_relnotes) https://github.com/bitcoin/bitcoin/pull/19802
< bitcoin-git> bitcoin/master 72affcb Wladimir J. van der Laan: Merge #19802: doc: elaborate on release notes wrt netmasks
< bitcoin-git> bitcoin/master 8de51d1 Vasil Dimov: doc: elaborate on release notes wrt netmasks
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7b7cb70f4cd9...72affcb16cad
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19498: Tidy up ProcessOrphanTx (master...2020-07-orphan-tidy) https://github.com/bitcoin/bitcoin/pull/19498
< bitcoin-git> bitcoin/master 4763b51 John Newbery: ProcessOrphanTx: remove useless setMisbehaving set
< bitcoin-git> bitcoin/master 6e8dd99 John Newbery: [net processing] Add doxygen comments for orphan data and function
< bitcoin-git> bitcoin/master 55c79a9 John Newbery: ProcessOrphanTx: remove useless done variable
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/301959fa7482...7b7cb70f4cd9
< jnewbery> wumpus: here's another one from a different PR: https://travis-ci.org/github/bitcoin/bitcoin/jobs/731454576. Perhaps you're right that that's what it looks like when Travis times out at that stage of the job
< bitcoin-git> [bitcoin] fanquake merged pull request #20043: doc: Add 19501 release notes (master...2009-doc19501) https://github.com/bitcoin/bitcoin/pull/20043
< bitcoin-git> bitcoin/master 301959f fanquake: Merge #20043: doc: Add 19501 release notes
< bitcoin-git> bitcoin/master faf60de MarcoFalke: doc: Remove double-whitespace from help string, other whitespace fixups
< bitcoin-git> bitcoin/master fa710a6 MarcoFalke: doc: Add 19501 release notes
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4f5ae52738f7...301959fa7482
< bitcoin-git> [bitcoin] laanwj merged pull request #20006: Fix misleading error message: Clean stack rule (master...clean_stk) https://github.com/bitcoin/bitcoin/pull/20006
< bitcoin-git> bitcoin/master 4f5ae52 Wladimir J. van der Laan: Merge #20006: Fix misleading error message: Clean stack rule
< bitcoin-git> bitcoin/master af57766 sanket1729: Fix misleading error message: Clean stack rule
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c435c78e36c...4f5ae52738f7
< bitcoin-git> [bitcoin] laanwj merged pull request #20036: signet: Add assumed values for default signet (master...2009-signetAssumed) https://github.com/bitcoin/bitcoin/pull/20036
< bitcoin-git> bitcoin/master 5c435c7 Wladimir J. van der Laan: Merge #20036: signet: Add assumed values for default signet
< bitcoin-git> bitcoin/master fac9661 MarcoFalke: signet: Add assumed values for default signet
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1769828684f1...5c435c78e36c
< bitcoin-git> [bitcoin] laanwj closed pull request #19485: torcontrol: Create also a V3 ed25519-V3 onion address. (master...add-ed25519) https://github.com/bitcoin/bitcoin/pull/19485
< bitcoin-git> [bitcoin] kallewoof opened pull request #20045: upstream: add and use defaulted getters to UniValue (master...202009-defaulted-get) https://github.com/bitcoin/bitcoin/pull/20045
< bitcoin-git> [bitcoin] sipa opened pull request #20044: Make all of net_processing (and some of net) use std::chrono types (master...202009_chrono_types) https://github.com/bitcoin/bitcoin/pull/20044
< bitcoin-git> [bitcoin] decryp2kanon closed pull request #20041: test: consistently use BTC/kB and sat/B in wallet_basic test (master...test_btc_kb_200930) https://github.com/bitcoin/bitcoin/pull/20041
< bitcoin-git> [bitcoin] kallewoof closed pull request #20013: rpc: normalize parameter names (master...202009-rpc-normalize) https://github.com/bitcoin/bitcoin/pull/20013
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20043: doc: Add 19501 release notes (master...2009-doc19501) https://github.com/bitcoin/bitcoin/pull/20043
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19501: send* RPCs in the wallet returns the "fee reason" (master...send_rpc_feereason) https://github.com/bitcoin/bitcoin/pull/19501
< bitcoin-git> bitcoin/master 1769828 MarcoFalke: Merge #19501: send* RPCs in the wallet returns the "fee reason"
< bitcoin-git> bitcoin/master 69cf5d4 Sishir Giri: [test] Make sure send rpc returns fee reason
< bitcoin-git> bitcoin/master d5863c0 Sishir Giri: [send] Make send RPCs return fee reason
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/36f5a58c0210...1769828684f1
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19960: build: The vcpkg tool has introduced a proper way to use manifests (master...vcpkg_manifest) https://github.com/bitcoin/bitcoin/pull/19960
< bitcoin-git> bitcoin/master 36f5a58 MarcoFalke: Merge #19960: build: The vcpkg tool has introduced a proper way to use man...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7ad94428ab6...36f5a58c0210
< bitcoin-git> bitcoin/master 712f95d Aaron Clauson: Update msvc build to use new vcpkg manifest
< sipa> my bitcoin-fuzz dir is 319M
< bitcoin-git> [bitcoin] fanquake merged pull request #19958: doc: Better document features of feelers (master...2020-09-rename-feeler-to-probe) https://github.com/bitcoin/bitcoin/pull/19958
< bitcoin-git> bitcoin/master c7ad944 fanquake: Merge #19958: doc: Better document features of feelers
< bitcoin-git> bitcoin/master 2ea62ca Gleb Naumenko: Improve docs about feeler connections
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de4b7f25acef...c7ad94428ab6
< bitcoin-git> [bitcoin] decryp2kanon opened pull request #20041: test: unit case sensitive in a functional test (master...test_btc_kb_200930) https://github.com/bitcoin/bitcoin/pull/20041

2020-09-29

< sipa> dburkett: i never contributed to open source before bitcoin
< dburkett> Gotcha. Thanks for the honesty. Bitcoin development has often scared myself and many others away in the past due to the lack of readability and organization of the code.
< luke-jr> dburkett: something like https://github.com/bitcoin/bitcoin/pull/771 ?
< dburkett> Here's a quick example: https://github.com/bitcoin/bitcoin/blob/d82b2c6e65ff1ade508e2e8abeb07d0ff37e09c4/src/validation.cpp#L1128-L1238 doesn't seem to be related to validation at all, and looks like an obvious candidate to move to some sort of BlockStore class or codefile.
< bitcoin-git> [bitcoin] achow101 opened pull request #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on insert (master...inner-groupoutputs) https://github.com/bitcoin/bitcoin/pull/20040
< bitcoin-git> [bitcoin] prayank23 opened pull request #20039: test: Convert amounts from float to decimal (master...floatdecimal) https://github.com/bitcoin/bitcoin/pull/20039
< gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< luke-jr> possibly into Bitcoin-Qt too, though I can't see any way one would exploit this
< bitcoin-git> [bitcoin] laanwj merged pull request #20015: doc: Added default signet config for linearize script (master...master) https://github.com/bitcoin/bitcoin/pull/20015
< bitcoin-git> bitcoin/master 8a4dcda gr0kchain: doc: Added default signet config for linearize script
< bitcoin-git> bitcoin/master de4b7f2 Wladimir J. van der Laan: Merge #20015: doc: Added default signet config for linearize script
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e6f56f6ea0f...de4b7f25acef
< bitcoin-git> [bitcoin] laanwj merged pull request #19984: log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)" (master...logging-should-not-be-static-department) https://github.com/bitcoin/bitcoin/pull/19984
< bitcoin-git> bitcoin/master 9e6f56f Wladimir J. van der Laan: Merge #19984: log: Remove static log message "Initializing chainstate Chai...
< bitcoin-git> bitcoin/master f22d6a1 practicalswift: log: Remove static log message "Initializing chainstate Chainstate [ibd] @...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8aa617896139...9e6f56f6ea0f
< bitcoin-git> [bitcoin] laanwj merged pull request #20003: net: Exit with error message if -proxy is specified without arguments (instead of continuing without proxy server) (master...error-on-empty-proxy) https://github.com/bitcoin/bitcoin/pull/20003
< bitcoin-git> bitcoin/master 8aa6178 Wladimir J. van der Laan: Merge #20003: net: Exit with error message if -proxy is specified without ...
< bitcoin-git> bitcoin/master 9b4fa0a practicalswift: net: Print error message if -proxy is specified without arguments (instead...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d82b2c6e65ff...8aa617896139
< Bullit> What happened last thing it said at 33% block load ¨i´ll warn you again¨ then Bitcoin Core QT Shutdown during start up full chain is running again on laptop, please don´t make me a node see my energydrink company
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20036: signet: Add assumed values for default signet (master...2009-signetAssumed) https://github.com/bitcoin/bitcoin/pull/20036
< bitcoin-git> bitcoin/master d82b2c6 fanquake: Merge #19898: log: print unexpected version warning in validation log cate...
< bitcoin-git> [bitcoin] fanquake merged pull request #19898: log: print unexpected version warning in validation log category (master...log-fix-unexpected-version) https://github.com/bitcoin/bitcoin/pull/19898
< bitcoin-git> bitcoin/master 62dba96 nthumann: log: print unexpected version warning in validation log category
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec9b4492eba5...d82b2c6e65ff
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20035: signet: Fix uninitialized read in validation (master...2009-signetUninitRead) https://github.com/bitcoin/bitcoin/pull/20035
< vasild> hebasto: I am looking at https://github.com/bitcoin/bitcoin/pull/19991#discussion_r495073463 -- that wouldn't allow to configure the two things independently.
< bitcoin-git> [bitcoin] ryanofsky opened pull request #20034: test: Get rid of default wallet hacks (master...pr/defw) https://github.com/bitcoin/bitcoin/pull/20034
< bitcoin-git> [bitcoin] jnewbery closed pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197
< bitcoin-git> [bitcoin] jnewbery closed pull request #15206: Immediately disconnect on invalid net message checksum (master...2019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
< bitcoin-git> [bitcoin] vasild opened pull request #20033: style: minor improvements as a followup to #19845 (master...nits_followup_to_19845) https://github.com/bitcoin/bitcoin/pull/20033
< bitcoin-git> [bitcoin] darosior closed pull request #16890: rpc: Don't allow to 'estimatesmartfee' in blocksonly mode (master...estimatesmartfee_blockonly) https://github.com/bitcoin/bitcoin/pull/16890
< bitcoin-git> [bitcoin] jnewbery closed pull request #17566: Switch to weight units for all feerates computation (master...feerate_in_weight) https://github.com/bitcoin/bitcoin/pull/17566
< bitcoin-git> [bitcoin] vasild closed pull request #19031: Implement ADDRv2 support (part of BIP155) (master...addrv2) https://github.com/bitcoin/bitcoin/pull/19031
< bitcoin-git> [bitcoin] fanquake merged pull request #19630: Cleanup fee estimation code (master...20/07/refactor_feeest_code) https://github.com/bitcoin/bitcoin/pull/19630
< bitcoin-git> bitcoin/master 569d92a Antoine Poinsot: policy/fees: small readability improvements
< bitcoin-git> bitcoin/master dba8196 Antoine Poinsot: policy/fees: correct decay explanation comments
< bitcoin-git> bitcoin/master 5b8cb35 Antoine Poinsot: policy/fee: remove requireGreater parameter in EstimateMedianVal()
< bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6af9b31bfc6d...ec9b4492eba5
< bitcoin-git> [bitcoin] fanquake merged pull request #19107: p2p: Move all header verification into the network layer, extend logging (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
< bitcoin-git> bitcoin/master 1ca20c1 Troy Giorshev: Add doxygen comment for ReceiveMsgBytes
< bitcoin-git> bitcoin/master 890b1d7 Troy Giorshev: Move checksum check from net_processing to net
< bitcoin-git> bitcoin/master 2716647 Troy Giorshev: Give V1TransportDeserializer an m_node_id member
< bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e36aa351a31c...6af9b31bfc6d
< bitcoin-git> [bitcoin] fanquake merged pull request #19969: Send RPC bug fix and touch-ups (master...2020/09/send_touchups) https://github.com/bitcoin/bitcoin/pull/19969
< bitcoin-git> bitcoin/master d813d26 Sjors Provoost: [rpc] send: various touch-ups
< bitcoin-git> bitcoin/master 0fc1c68 Sjors Provoost: [rpc] send: fix parsing replaceable option
< bitcoin-git> bitcoin/master efc9b85 Sjors Provoost: Mark send RPC experimental
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7ea649946daa...e36aa351a31c
< bitcoin-git> [bitcoin] fanquake closed pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
< bitcoin-git> bitcoin/master 7ea6499 fanquake: Merge #20028: test: Check that invalid peer traffic is accounted for
< bitcoin-git> [bitcoin] fanquake merged pull request #20028: test: Check that invalid peer traffic is accounted for (master...2009-testInvalidTraffic) https://github.com/bitcoin/bitcoin/pull/20028
< bitcoin-git> bitcoin/master fae243f MarcoFalke: test: Remove confusing cast to same type (int to int)
< bitcoin-git> bitcoin/master faa94cb MarcoFalke: test: Check that invalid peer traffic is accounted for
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5db44c740ebd...7ea649946daa
< bitcoin-git> [bitcoin] fanquake merged pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
< bitcoin-git> bitcoin/master 5db44c7 fanquake: Merge #20014: doc: Mention signet in -help output
< bitcoin-git> bitcoin/master b3972bc Hennadii Stepanov: doc: Mention signet in -help output
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/655937ebcbf6...5db44c740ebd

2020-09-28

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030
< bitcoin-git> [bitcoin] sipa merged pull request #19845: net: CNetAddr: add support to (un)serialize as ADDRv2 (master...ser_addrv2_cnetaddr) https://github.com/bitcoin/bitcoin/pull/19845
< bitcoin-git> bitcoin/master e0d7357 Vasil Dimov: net: CNetAddr: add support to (un)serialize as ADDRv2
< bitcoin-git> bitcoin/master d2bb681 Vasil Dimov: util: move HasPrefix() so it can be reused
< bitcoin-git> bitcoin/master fe42411 Vasil Dimov: test: move HasReason so it can be reused
< bitcoin-git> [bitcoin] sipa pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/255270200074...655937ebcbf6
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15367: feature: Added ability for users to add a startup command (master...startup_commands) https://github.com/bitcoin/bitcoin/pull/15367
< bitcoin-git> bitcoin/master 2552702 MarcoFalke: Merge #15367: feature: Added ability for users to add a startup command
< bitcoin-git> bitcoin/master 090530c Ben Carman: feature: Added ability for users to add a startup command
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c95784e3d31d...255270200074
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030
< emzy> cdecker / provoostenator: would you like to look into or test my dnsseed dnssec setup? https://github.com/Emzy/bitcoin-seeder/blob/master/README-dnssec.md
< gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19411 | Unable to build BDB 4.8 on macOS Big Sur beta or Xcode 12.0 · Issue #19411 · bitcoin/bitcoin · GitHub
< Bullit> Bitcoin core V0.20 keeps crashing 2020-09-28T12:21:12Z Verifying last 6 blocks at level 3 ; whats Bitcoin Core Network Trafic + Banking Stockbroker traffic
< harding> Can someone with either Travis access or GitHub admin access for the bitcoin-core organization take a look at https://github.com/bitcoin-core/bitcoincore.org/pull/722 please? I'd like to merge it but its travis job is stuck and the master branch is protected against merges that haven't passed CI.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20028: test: Check that invalid peer traffic is accounted for (master...2009-testInvalidTraffic) https://github.com/bitcoin/bitcoin/pull/20028
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20016: uint256: 1 is a constant (master...202009-uint256_1) https://github.com/bitcoin/bitcoin/pull/20016
< bitcoin-git> bitcoin/master 4cc7171 Anthony Towns: wallet: no need for duplicate storage for ABANDON_HASH constant
< bitcoin-git> bitcoin/master 82cf464 Anthony Towns: scripted-diff: Replace UINT256_ONE() with uint256::ONE
< bitcoin-git> bitcoin/master 183f308 Anthony Towns: uint256: Update constructors to c++11, make ONE static
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e7e6f0bf18b9...c95784e3d31d
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20026: test: typo in a functional test doc (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20026
< bitcoin-git> bitcoin/master e7e6f0b MarcoFalke: Merge #20026: test: typo in a functional test doc
< bitcoin-git> bitcoin/master a5a6965 kanon: [Trivial] python help message
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/055abfbc5a4d...e7e6f0bf18b9
< bitcoin-git> [bitcoin] jonatack closed pull request #19883: net, rpc: expose connection type in getpeerinfo (master...getpeerinfo-conn-type) https://github.com/bitcoin/bitcoin/pull/19883
< kallewoof> https://github.com/bitcoin/bitcoin/pull/19969 is mostly nit-fixes, and has 2 utACKs and 1 tested ACK (by me); looks ready for merging.

2020-09-27

< bitcoin-git> [bitcoin] sipa opened pull request #20027: Use mockable time everywhere in net_processing (master...202009_mockable_netproc) https://github.com/bitcoin/bitcoin/pull/20027
< bitcoin-git> [bitcoin] decryp2kanon opened pull request #20026: [Trivial] python help message (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20026
< jb55> rebuilding bitcoin/gcc and all transitive deps with the emit_diagnostic patch... hit a pubsub test in zmq and something in icu so far: https://jb55.com/s/31761d3ea0e88b4e.txt
< roconnor> luke-jr: https://gist.github.com/real-or-random/1548239059158370416dfdc6a866329a#gistcomment-3468827 is a patch to instrument GCC 9 (and I think GCC 10). It seems to imply that bitcoin and libsecp256k1 is unaffected by this bug.

2020-09-26

< bitcoin-git> [bitcoin] gzhao408 opened pull request #20025: validation/util: add GetTransactionFee (master...2020-09-getfee) https://github.com/bitcoin/bitcoin/pull/20025
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20023: test: remove unused constants in functional tests (master...20200926-test-remove-unused-constants) https://github.com/bitcoin/bitcoin/pull/20023
< bitcoin-git> bitcoin/master 055abfb MarcoFalke: Merge #20023: test: remove unused constants in functional tests
< bitcoin-git> bitcoin/master 92e28fa Sebastian Falbesoner: test: remove unused constants in functional tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4f45ea1f7393...055abfbc5a4d
< bitcoin-git> bitcoin/master df091b9 Amiti Uttarwar: [refactor] Rename test file to allow any getpeerinfo deprecations.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19725: [RPC] Add connection type to getpeerinfo, improve logs (master...2020-08-getpeerinfo-conn-type) https://github.com/bitcoin/bitcoin/pull/19725
< bitcoin-git> bitcoin/master 395acfa Amiti Uttarwar: [rpc] Add connection type to getpeerinfo RPC, update tests
< bitcoin-git> bitcoin/master 49c10a9 Amiti Uttarwar: [log] Add connection type to log statement
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8aa3a4a49874...4f45ea1f7393
< bitcoin-git> [bitcoin] practicalswift opened pull request #20024: init: Fix incorrect warning "Reducing -maxconnections from N to N-1, because of system limitations" (master...fix-incorrect-warning) https://github.com/bitcoin/bitcoin/pull/20024
< gloriazhao> Would someone be able to restart Travis for me please? https://travis-ci.org/github/bitcoin/bitcoin/jobs/730095344
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20022: test: use explicit p2p objects where available (master...p2p-conn-rename) https://github.com/bitcoin/bitcoin/pull/20022
< bitcoin-git> bitcoin/master 8aa3a4a MarcoFalke: Merge #20022: test: use explicit p2p objects where available
< bitcoin-git> bitcoin/master 0fcaf73 Oliver Gugger: test: use explicit p2p objects where available
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/78f912c9010f...8aa3a4a49874
< bitcoin-git> [bitcoin] theStack opened pull request #20023: test: remove unused constants in functional tests (master...20200926-test-remove-unused-constants) https://github.com/bitcoin/bitcoin/pull/20023
< bitcoin-git> [bitcoin] guggero opened pull request #20022: test: use explicit p2p objects where available (master...p2p-conn-rename) https://github.com/bitcoin/bitcoin/pull/20022

2020-09-25

< bitcoin-git> [bitcoin] dongcarl opened pull request #20019: depends: Properly pass $PATH to configure and pin (master...2020-09-resolve-PATH-prepending-madness) https://github.com/bitcoin/bitcoin/pull/20019
< bitcoin-git> [bitcoin] dhruv opened pull request #20018: p2p: ProcessAddrFetch(-seednode) is unnecessary if -connect is specified (master...seednode-not-needed-with-connect) https://github.com/bitcoin/bitcoin/pull/20018
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #20017: rpc: Add RPCContext (master...2020-09-rpcontext) https://github.com/bitcoin/bitcoin/pull/20017
< bitcoin-git> [bitcoin] ajtowns opened pull request #20016: uint256: 1 is a constant (master...202009-uint256_1) https://github.com/bitcoin/bitcoin/pull/20016
< bitcoin-git> [bitcoin] gr0kchain opened pull request #20015: doc: Added default signet config for linearize script (master...master) https://github.com/bitcoin/bitcoin/pull/20015
< bitcoin-git> [bitcoin] hebasto opened pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property (master...test-p2p-property) https://github.com/bitcoin/bitcoin/pull/19804
< bitcoin-git> bitcoin/master 549d30f gzhao408: scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx
< bitcoin-git> bitcoin/master 7a0de46 gzhao408: [doc] sample code for test framework p2p objects
< bitcoin-git> bitcoin/master 784f757 gzhao408: [refactor] clarify tests by referencing p2p objects directly
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1b313cacc99a...78f912c9010f
< hebasto> jonasschnelli: fanquake: begging review for https://github.com/bitcoin-core/gui/pull/46
< bitcoin-git> [bitcoin] kallewoof closed pull request #19957: rpc: alias helper (master...202009-rpc-alias) https://github.com/bitcoin/bitcoin/pull/19957
< bitcoin-git> [bitcoin] kallewoof opened pull request #20013: rpc: normalize parameter names (master...202009-rpc-normalize) https://github.com/bitcoin/bitcoin/pull/20013
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20012: rpc: Remove duplicate name and argNames from CRPCCommand (master...2009-rpcCheckMapping) https://github.com/bitcoin/bitcoin/pull/20012
< fanquake> MarcoFalke: FYI the bot seems to have run out of disk: https://github.com/bitcoin/bitcoin/pull/19868#issuecomment-698680164

2020-09-24

< elichai2> lol `base_uint` in arith_uint256.h seems to have dodged the bullet by pure luck https://github.com/bitcoin/bitcoin/blob/master/src/arith_uint256.h#L217-L222
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 13 blockers, 1 bugfix, 2 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< bitcoin-git> [bitcoin] jnewbery closed pull request #19759: [doc] Struct members should have m_ prefix (master...2020-08-struct-members) https://github.com/bitcoin/bitcoin/pull/19759
< bitcoin-git> [bitcoin] laanwj merged pull request #20008: [Backport] #19839 and #19842 to v0.20 (0.20...2020-09-appveyor-backport) https://github.com/bitcoin/bitcoin/pull/20008
< bitcoin-git> bitcoin/0.20 80aa83a Wladimir J. van der Laan: Merge #20008: [Backport] #19839 and #19842 to v0.20
< bitcoin-git> bitcoin/0.20 498b7cb Aaron Clauson: Update the vcpkg checkout commit ID in appveyor config.
< bitcoin-git> bitcoin/0.20 ad99777 Aaron Clauson: Set appveyor vm version to previous Visual Studio 2019 release.
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/30926997fa15...80aa83aa4064
< bitcoin-git> [bitcoin] naumenkogs reopened pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< bitcoin-git> [bitcoin] jnewbery opened pull request #20008: [Backport] #19839 and #19842 to v0.20 (0.20...2020-09-appveyor-backport) https://github.com/bitcoin/bitcoin/pull/20008
< bitcoin-git> [bitcoin] naumenkogs reopened pull request #19958: p2p: Better document features of feelers (master...2020-09-rename-feeler-to-probe) https://github.com/bitcoin/bitcoin/pull/19958
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19958: p2p: Better document features of feelers (master...2020-09-rename-feeler-to-probe) https://github.com/bitcoin/bitcoin/pull/19958
< roconnor> https://github.com/bitcoin/bitcoin/blob/0.20/src/netaddress.cpp#L237 also. ... assuming that IsIPv4 somehow isn't always returning true.
< bitcoin-git> [bitcoin] ajtowns closed pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970

2020-09-23

< bitcoin-git> [bitcoin] sanket1729 opened pull request #20006: Fix misleading error message: Clean stack rule (master...clean_stk) https://github.com/bitcoin/bitcoin/pull/20006
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19927: validation: Reduce direct g_chainman usage (master...2020-09-reduce-g_chainman-usage) https://github.com/bitcoin/bitcoin/pull/19927
< bitcoin-git> bitcoin/master f8d4975 Carl Dong: validation: Move PruneOneBlockFile to BlockManager
< bitcoin-git> bitcoin/master 74f73c7 Carl Dong: validation: Pass in chainman to UnloadBlockIndex
< bitcoin-git> bitcoin/master 4668ded Carl Dong: validation: Move ~CMainCleanup logic to ~BlockManager
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/43305e9810e4...1b313cacc99a
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19868: build: Fix target name (master...200904-make) https://github.com/bitcoin/bitcoin/pull/19868
< bitcoin-git> bitcoin/master 43305e9 MarcoFalke: Merge #19868: build: Fix target name
< bitcoin-git> bitcoin/master 7a89f2e Hennadii Stepanov: build: Fix target name
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5e14fafb316e...43305e9810e4
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19994: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet) (master...2009-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19994
< bitcoin-git> bitcoin/master 5e14faf MarcoFalke: Merge #19994: Assert that RPCArg names are equal to CRPCCommand ones (net,...
< bitcoin-git> bitcoin/master fa14f57 MarcoFalke: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8235dca6210d...5e14fafb316e
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19979: Replace LockAssertion with AssertLockHeld, remove LockAssertion (master...200919-tsa) https://github.com/bitcoin/bitcoin/pull/19979
< bitcoin-git> bitcoin/master 0bd1184 Hennadii Stepanov: Remove unused LockAssertion struct
< bitcoin-git> bitcoin/master ab2a442 Hennadii Stepanov: Replace LockAssertion with a proper thread safety annotations
< bitcoin-git> bitcoin/master 73f71e1 Hennadii Stepanov: refactor: Use explicit function type instead of template
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e217f5a6f08...8235dca6210d
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20004: test: Add signet witness commitment section parse tests (master...2009-testSignetParse) https://github.com/bitcoin/bitcoin/pull/20004
< gribble> https://github.com/bitcoin/bitcoin/issues/19043 | torcontrol: add -tortarget config by MDrollette · Pull Request #19043 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20003: net: Print error message if -proxy is specified without arguments (instead of continuing without proxy server) (master...error-on-empty-proxy) https://github.com/bitcoin/bitcoin/pull/20003
< bitcoin-git> [bitcoin] practicalswift closed pull request #20001: net: Use proxy server 127.0.0.1 if -proxy is specified without arguments (instead of continuing without proxy server) (master...use-localhost-instead-of-silently-skipping-proxy) https://github.com/bitcoin/bitcoin/pull/20001
< bitcoin-git> [bitcoin] laanwj merged pull request #19572: ZMQ: Create "sequence" notifier, enabling client-side mempool tracking (master...zmq_sequence_all) https://github.com/bitcoin/bitcoin/pull/19572
< bitcoin-git> bitcoin/master 68c3c7e Gregory Sanders: Add functional tests for zmq sequence topic and mempool sequence logic
< bitcoin-git> bitcoin/master e76fc2b Gregory Sanders: Add 'sequence' zmq publisher to track all block (dis)connects, mempool del...
< bitcoin-git> bitcoin/master 1b615e6 Gregory Sanders: zmq test: Actually make reorg occur
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/821989382557...9e217f5a6f08
< bitcoin-git> [bitcoin] jonatack opened pull request #20002: net, rpc, cli: expose CNetAddr::GetNetClass in getpeerinfo, use in -netinfo (master...getpeerinfo-GetNetClass) https://github.com/bitcoin/bitcoin/pull/20002
< bitcoin-git> [bitcoin] practicalswift opened pull request #20001: net: Use default proxy server (127.0.0.1:9050) if -proxy is specified without arguments (instead of continuing without proxy server) (master...use-localhost-instead-of-silently-skipping-proxy) https://github.com/bitcoin/bitcoin/pull/20001
< gribble> https://github.com/bitcoin/bitcoin/issues/19606 | Backport wtxid relay to v0.20 by jnewbery · Pull Request #19606 · bitcoin/bitcoin · GitHub
< vasild> luke-jr: https://github.com/bitcoin/bips/pull/907 can be merged? It has 4 ACKs, including from the BIP author (wumpus).
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19993: refactor: Signet fixups (master...2009-signetFixups) https://github.com/bitcoin/bitcoin/pull/19993
< bitcoin-git> bitcoin/master fae0548 MarcoFalke: fuzz: Remove needless guard
< bitcoin-git> bitcoin/master 77771a0 MarcoFalke: refactor: Remove SignetTxs::m_valid and use optional instead
< bitcoin-git> bitcoin/master fa2ad5d MarcoFalke: test: Run signet test even when wallet was not compiled
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b1291b2e8fc3...821989382557
< bitcoin-git> [bitcoin] vasild opened pull request #20000: test: fix DecodeBase32 tests (master...fix_base32_tests) https://github.com/bitcoin/bitcoin/pull/20000