<michaelfolkson>
Kaizen_Kintsugi_: Perhaps #bitcoin-core-pr-reviews is better channel for these types of general questions. But with Schnorr we can do key aggregation schemes (e.g. MuSig2) but not signature aggregation across say inputs
<dongcarl>
provoostenator: E.g. ./src/bitcoin-chainstate ./test-datadir (This is a draft PR please don’t use it on your actual datadir).
<dongcarl>
provoostenator: bitcoin-chainstate does do something! It will print out information about a datadir and wait for new blocks (encoded in hex) to process on stdin. I found it pretty cool to start it and start feeding it block 1, 2, 3, and see it work :-)
<gribble>
https://github.com/bitcoin/bitcoin/issues/24230 | indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky · Pull Request #24230 · bitcoin/bitcoin · GitHub
<dongcarl>
Right, I think in practice libbitcoinkernel will probably be a subset of bitcoin-node (is that the right binary?), as in bitcoin-node can link against libbitcoinkernel (not proposing that we do this yet)
<prayank>
michaelfolkson: It was sarcasm for some privacy wallets writing non sense that affect privacy of Bitcoin in general but nobody wants to talk about it. I understand your point and no disagreement.
<bitcoin-git>
[bitcoin] Sjors opened pull request #24313: Improve display address handling for external signer (master...2022/02/displayaddress) https://github.com/bitcoin/bitcoin/pull/24313
<bitcoin-git>
[bitcoin] fanquake opened pull request #24309: test: test that OP_1-OP_16 (but not lower/higher) start witness programs (master...cherrypick_test_13062) https://github.com/bitcoin/bitcoin/pull/24309
<bitcoin-git>
[bitcoin] laanwj merged pull request #24238: random: use arc4random on OpenBSD (master...202202-random-use_arc4random_on_OpenBSD) https://github.com/bitcoin/bitcoin/pull/24238
<bitcoin-git>
[bitcoin] kristapsk opened pull request #24307: RPC: Return external_signer in getwalletinfo (master...getwalletinfo-external_signer) https://github.com/bitcoin/bitcoin/pull/24307
2022-02-09
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #24306: util: Make ArgsManager::GetPathArg more widely usable (master...pr/patharg) https://github.com/bitcoin/bitcoin/pull/24306
<dongcarl>
laanwj: In my mind, bitcoin-chainstate is more of a demo executable, one which makes sure that we're linking in everything we need and surfaces our dependency tree. I think it'll be nice to have a few of these demo executables as guiding "north stars" so we can see how ergonomic (or rather, un-ergonomic) libbitcoinkernel is right now, and how it
<bitcoin-git>
[bitcoin] fanquake opened pull request #24296: ci: use Ubuntu Hirsute for Windows cross-compilation CI (master...win_ci_gcc_10_3) https://github.com/bitcoin/bitcoin/pull/24296
<darosior>
I guess if you have a bitcoin-chainstate binary you can already have your own P2P implementation and feed blocks to the binary as the consensus engine
<laanwj>
dongcarl: btw congrats on bitcoin-chainstate it's a big step towards bitcoin-kernel i think?
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24295: Remove std::move from fs wrapper to work around bug (master...2202-bug) https://github.com/bitcoin/bitcoin/pull/24295
<bitcoin-git>
bitcoin/master 2385b50 Luke Dashjr: Bugfix: GUI: Only apply invalid style to QValidatedLineEdit, not its toolt...
<bitcoin-git>
bitcoin/master b1a544b Luke Dashjr: Bugfix: GUI: Re-check validity after QValidatedLineEdit::setCheckValidator
<bitcoin-git>
bitcoin/master aeb18b6 Luke Dashjr: Bugfix: GUI: Check validity when QValidatedLineEdit::setText is called
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24294: RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid (master...getblockfrompeer_param_names) https://github.com/bitcoin/bitcoin/pull/24294
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24293: (Refactor) QA: wallet_basic: Split wtx expected_fields over multiple lines to minimise merge conflicts (master...qa_wtx_expected_fields_lines) https://github.com/bitcoin/bitcoin/pull/24293
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24292: Revert "ci: Run fuzzer task for the master branch only" (master...2202-ciFuzz) https://github.com/bitcoin/bitcoin/pull/24292
<dongcarl>
Basically bitcoin-chainstate is a binary that, upon invocation with a datadir path as the first argument, will load the datadir, print out information about it, then wait for blocks (encoded in hex) on stdin to call ProcessNewBlock on. THE PROBLEM is that when I start with an empty datadir, and feed it block 1 and block 2, then exit, the next time
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24291: build: Remove libboost-test-dev depencency when --enable-fuzz (master...2202-fuzzNoBoost) https://github.com/bitcoin/bitcoin/pull/24291
<bitcoin-git>
[bitcoin] hebasto opened pull request #24283: build: Add print-all-% target for multi-line variables and debug info (master...220207-print) https://github.com/bitcoin/bitcoin/pull/24283
<bitcoin-git>
[bitcoin] bitcoinhodler opened pull request #24282: docs: Move explanation of hardened key syntax closer to KEY section (master...doc-fix-hardened-descriptors) https://github.com/bitcoin/bitcoin/pull/24282
<bitcoin-git>
[bitcoin] bitcoinhodler opened pull request #24281: docs: Update to match new default wallet type (master...doc-fix-default-wallet) https://github.com/bitcoin/bitcoin/pull/24281
<sipa>
This channel is about development of the Bitcoin Core software, not general discussion.
<bitcoin-git>
[bitcoin] hebasto opened pull request #24279: build: Make $(package)_*_env available to to all $(package)_*_cmds (master...220206-export) https://github.com/bitcoin/bitcoin/pull/24279
<bitcoin-git>
[bitcoin] hebasto opened pull request #24277: build: Fix `make deploy` for Windows when building out of source tree (master...220206-deploy) https://github.com/bitcoin/bitcoin/pull/24277
<bitcoin-git>
[bitcoin] hebasto opened pull request #24276: build, refactor: Improve package version usage (master...220206-underscore) https://github.com/bitcoin/bitcoin/pull/24276
<gribble>
https://github.com/bitcoin/bitcoin/issues/22546 | build, qt: Fix `make deploy` on M1-based macOS with system frameworks by hebasto · Pull Request #22546 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] nymkappa closed pull request #24267: util: if `DataDir` is a symbolic link, manually follow it (master...bugfix/follow-symlinks) https://github.com/bitcoin/bitcoin/pull/24267
<bitcoin-git>
[bitcoin] anshu-khare-design closed pull request #24247: p2p: Split network logging into two categories (master...issue_20576) https://github.com/bitcoin/bitcoin/pull/24247
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24269: test: add functional test for `-discover` (master...2022-02-discover-test) https://github.com/bitcoin/bitcoin/pull/24269
<laanwj>
coin control is one of the most popular features of the bitcoin core wallet, that other wallets don't tend to have, it's not going away
<Murch>
Okay, so why does that need to be discussed. Do you think someone wants to remove coin control from Bitcoin Core's wallet?
<prayank>
2. In Bitcoin Core we still have coin control and recently fixed locking coins.
<prayank>
4. Private funds of Private coins do not exis in Bitcoin. Everything is public but they may not be aware who did this tx.
<bitcoin-git>
[bitcoin] nymkappa opened pull request #24267: If DataDir is a symbolic link, manually follow it (master...bugfix/follow-symlinks) https://github.com/bitcoin/bitcoin/pull/24267
<prayank>
Coin Control is important and should always remain part of bitcoin wallets that care about privacy. If UX needs to be improved there can be a checkbox in settings to disable it. Or if wallet has no coin control but cluster control, removing it will not reduce errors it will change nature of errors and create new issues.
<prayank>
Sorry if this looks offtopic because of link but concept is ontopic. After working on several privacy related PRs in Core and then WW2 I realized core is not that bad with no marketing and coinjoin. Privacy is expressing yourself selectively. Everything is public on Bitcoin but if user wants to share links of transactions with less people that is privacy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #24265: Drop StripRedundantLastElementsOfPath() function and re-enable Windows tests (master...220204-norm) https://github.com/bitcoin/bitcoin/pull/24265
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23545: scripted-diff: Use clang-tidy syntax for C++ named arguments (master...2109-docNamedArgs) https://github.com/bitcoin/bitcoin/pull/23545
<bitcoin-git>
[gui] hebasto merged pull request #524: Replace int with std::chrono in for the timer->setInterval() argument (master...220112-chrono) https://github.com/bitcoin-core/gui/pull/524
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24258: test: check localaddresses in getnetworkinfo for nodes with proxy (master...2022-02-check-localaddresses) https://github.com/bitcoin/bitcoin/pull/24258
<achow101>
apparently bull bitcoin (an exchange) uses sffo to make their users pay the fee if they want to opt out of batched transactions. limiting to manual would break that use case
<Guest>
I am new to git.. I am trying to push a commit regarding this (https://github.com/bitcoin/bitcoin/issues/20576) .. I am getting this message when I am trying to push the code remote: Permission to bitcoin/bitcoin.git denied to anshu-khare-design ..
<Guest>
Hii I have successfully built Bitcoin core on Windows with the help of Visual Studio.. I want to take this (https://github.com/bitcoin/bitcoin/issues/20576) issue as the starting point of contribution.. Could you please tell some code pointers related to this issue?
<bitcoin-git>
[bitcoin] jarolrod opened pull request #24241: doc: cleanup doc on need of Developer Account to obtain macOS SDK (master...macdeploy-readme-cleanups) https://github.com/bitcoin/bitcoin/pull/24241
<bitcoin-git>
[bitcoin] laanwj merged pull request #23948: build: add support for FreeBSD to depends (master...depends_support_freebsd) https://github.com/bitcoin/bitcoin/pull/23948