< sipa>
i believe that policy wouldn't affect any bitcoin core versions in the past or those with the proposed change
< vasild>
you mean for the first "never send to anybody" -- I don't object the research, assume no such one exists now, but is it safe to assume that no such one would exist in the future? As for the second type - "Or send those messages occasionally" -- bitcoin core is such.
< vasild>
concern can be split in 2 sub-concerns: 1. these changes (extensions) to the protocol are done without a new BIP or modifying existent ones and 2. even if with BIP, on the technical level, I think assuming that if a node sends one of getaddr,addr,addrv2,sendaddrv2 then they participate in address relay is wrong, some examples: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-862312851
< vasild>
amiti: "In regards to the path forward for #21528 & #22245, it seems like the concerns are all focusing specifically on SENDADDRV2 and the wording of that specific bip" -- no, that's not the case. My biggest concern is changing the meaning of getaddr, addr, addrv2 (and sendaddrv2 if 22245 is considered). I explained that in https://github.com/bitcoin/bitcoin/pull/22245#issuecomment-862539375. My
< vasild>
amiti: "why are these approach concerns only being raised now?" I wasn't aware of your work before yesterday. I think late concerns are normal annoyance in software development, not specific to Bitcoin Core or decentralized projects (I worked 10 years in Oracle, I know!). In the same way you seem to be unaware of previous attempts to fix the black holdes problem and explicit signaling for address
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22120: test: p2p_invalid_block: Check that a block rejected due to too-new tim… (master...qa_timetoonew_retry) https://github.com/bitcoin/bitcoin/pull/22120
< bitcoin-git>
bitcoin/master dd24567 MarcoFalke: Merge bitcoin/bitcoin#22120: test: p2p_invalid_block: Check that a block r...
< bitcoin-git>
bitcoin/master 754e802 Luke Dashjr: test: check rejected future block later accepted
< bitcoin-git>
[bitcoin] jamesob opened pull request #22263: refactor: wrap CCoinsViewCursor in unique_ptr (master...2021-06-cursor-unique-ptr) https://github.com/bitcoin/bitcoin/pull/22263
2021-06-16
< bitcoin-git>
[bitcoin] hebasto reopened pull request #19882: depends: Export variables from make to environment explicitly (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
< michaelfolkson>
hiii: #bitcoin
< michaelfolkson>
hiii: "Bitcoin Core development discussion and commit log"
< hiii>
Hi, is this the main bitcoin dev channel?
< amiti>
so, if 21528 only used ADDR, ADDRV2, GETADDR to indicate "interest in addr relay", then bitcoin core nodes wouldn't initiate any of those to outbound block-relay-only connections. but nodes who have started up in blocks-only mode would initiate a GETADDR to their outbound peers.
< amiti>
understanding was the biggest concern was about compatibility for other clients, so I wrote to the mailing list and researched / opened issues in every other bitcoin client I could find. I’ve additionally brought up these changes at a P2P meeting in early April and then again this week. I understand that time zones are hard and that not everyone can attend the meetings, but I’d hope the logs would be read and concerns to
< amiti>
To review the context of this work: I opened #21528 almost 3 months ago, and soon after brought it up at the weekly bitcoin-core-dev meeting to seek approach feedback. A lot of the concerns that are now being voiced (should there be a separate flag, could we do redundant relay for blackholes rather than selective, what are the implications for other clients) have already been discussed in relation to these changes. My
< WS_black22>
i got my old wallet.dat i need to imported to the new bitcoin core, how can i do this? i dont see the replasment of wallet.dat,
< bitcoin-git>
[bitcoin] jnewbery opened pull request #22261: [p2p/mempool] Two small fixes to node broadcast logic (master...2021-06-broadcast-fixes) https://github.com/bitcoin/bitcoin/pull/22261
< bitcoin-git>
[bitcoin] Sjors opened pull request #22260: Make bech32m the default, except where needed. Update GUI checkbox. (master...2021/06/bech32_gui) https://github.com/bitcoin/bitcoin/pull/22260
< jnewbery>
laanwj: I'd suggest re-reading the irc meeting logs from when this was discussed, both in the main Bitcoin Core meeting, and in the p2p meeting. You commented in the first meeting in March, so you were aware that this was a proposal.
< vasild>
hmm, actually laanwj is right that 21528 is not related to just bitcoin core - it changes the semantics of getaddr, addr, addrv2 and sendaddrv2. I guess that warrants a BIP.
< jnewbery>
laanwj: this has been discussed in many venues already. It's been raised on the mailing list, discussed in bitcoin core irc and p2p irc meetings, amiti has even done a survey of every other common node implementation to make sure it doesn't break them: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-809906430
< jnewbery>
a pre-bip155 bitcoin core node will send a getaddr, which implies that it wants to receive addresses
< vasild>
anyway, if sendaddrv2 signalled preference to receive unrequested address messages, then bitcoin core-pre-bip155 do not want to receive unrequested address messages?
< vasild>
But I think the bigger argument here is 22245+21528 and changing the semantic of sendaddrv2 in order to tweak address relay and attempt to fix the black holes problem. But would even that fix it? Some scenarios where it will not: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-862312851
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22258: build: Disable deprecated-copy warning only when external warnings are enabled (master...2106-buildEnableWarnDeprecatedCopy) https://github.com/bitcoin/bitcoin/pull/22258
< bitcoin-git>
[bitcoin] luke-jr opened pull request #22255: [0.21] wallet: Do not iterate a directory if having an error while accessing it (0.21...listwalletdir_iterate_inf-0.19) https://github.com/bitcoin/bitcoin/pull/22255
< bitcoin-git>
[bitcoin] glozow opened pull request #22253: [validation/mempool] distinguish between same tx and same nonwitness tx already in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
< bitcoin-git>
[bitcoin] glozow opened pull request #22252: policy: Trim Packages when transaction with same txid exists in mempool (master...2021-06-mempool-matches) https://github.com/bitcoin/bitcoin/pull/22252
< bitcoin-git>
[bitcoin] S3RK opened pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
< bitcoin-git>
[gui] hebasto opened pull request #365: Draw "eye" sign at the beginning of watch-only addresses (master...210614-tx) https://github.com/bitcoin-core/gui/pull/365
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #22247: Switch Appveyor CI to VS2019 stable image (master...appveyor-image-stable) https://github.com/bitcoin/bitcoin/pull/22247
< Alina-malina>
there was a mindmap for bitcoin core source code
< jamesob>
Alina-malina: that's a question for #bitcoin
< Alina-malina>
guys do you remember the name of that program/protocol, that was right before bitcoin appeared in 2009? like it was something-brokers or something?
< bitcoin-git>
[bitcoin] amitiuttarwar opened pull request #22245: [p2p] Stop sending SENDADDRV2 message to block-relay-only peers (master...2021-06-sendaddrv2) https://github.com/bitcoin/bitcoin/pull/22245
< bitcoin-git>
[bitcoin] laanwj opened pull request #22244: devtools: Correctly extract symbol versions in symbol-check (master...2021-06-pixie) https://github.com/bitcoin/bitcoin/pull/22244
< bitcoin-git>
[gui] hebasto closed pull request #307: Make row color alternating in the Peers tab optional (master...210501-stripes) https://github.com/bitcoin-core/gui/pull/307
< elichai2>
pubhashtx, I took 20 because in the end I'm gathering some stats on transactions(for research purposes) and it's not too useful to me to get transactions in a big delay after the node gets them (I should've probably hacked my data gathering into bitcoin core), so I'd rather miss transactions than get them in delay
< bitcoin-git>
[bitcoin] josibake opened pull request #22235: script: add script to generate example bitcoin.conf (master...josibake-auto-generate-example-bitcoin-conf-file) https://github.com/bitcoin/bitcoin/pull/22235
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #21941: fuzz: Call const member functions in addrman fuzz test only once (master...2105-fuzzAddrConst) https://github.com/bitcoin/bitcoin/pull/21941
< bitcoin-git>
bitcoin/master d75a1df MarcoFalke: Merge bitcoin/bitcoin#21941: fuzz: Call const member functions in addrman ...
< bitcoin-git>
bitcoin/master faf7623 MarcoFalke: fuzz: Call const member functions in addrman fuzz test only once
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22232: refactor: Pass interpreter flags as uint32_t instead of signed int (master...2106-refactorFlags) https://github.com/bitcoin/bitcoin/pull/22232
< elichai2>
I'm sometimes getting big jumps in (zmq) sequence numbers, for example, I was listening to `hashtx` with a buffer of 20 on the bitcoin core side, and suddenly I got a message with sequence number 4139 while the one before it had 3038
< elichai2>
which channel is best for asking about details on the zmq interface? #bitcoin? (I remembered there was a #bitcoin-dev, but I can't join it) or is here also fine?
< elichai2>
oh I apparently forgot that zmq addresses need to have a protocol prefix (eg "tcp://IP:PORT"), and bitcoin core didn't complain about it
< elichai2>
Are the binaries from bitcoin.org compiled with zmq support?
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22102: Remove `Warning:` from warning message printed for unknown new rules (master...warning-msg) https://github.com/bitcoin/bitcoin/pull/22102
< bitcoin-git>
[bitcoin] hebasto opened pull request #22231: refactor: Separate AppInitStartClients from AppInitMain (master...210612-start) https://github.com/bitcoin/bitcoin/pull/22231
< bitcoin-git>
[gui] luke-jr opened pull request #363: Peers window: Show direction in a new column, with clearer icon (master...qt_peers_directionarrow) https://github.com/bitcoin-core/gui/pull/363
<@gribble>
https://github.com/bitcoin/bitcoin/issues/263 | 0.3.22rc2 Says 0.0005 in the warning dialog but takes 0.01 as a fee for small transactions. · Issue #263 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj merged pull request #22156: Allow tr() import only when Taproot is active (master...disallow-tr-privkey-import) https://github.com/bitcoin/bitcoin/pull/22156
< bitcoin-git>
bitcoin/master b0e5fbf W. J. van der Laan: Merge bitcoin/bitcoin#22156: Allow tr() import only when Taproot is active...
< bitcoin-git>
bitcoin/master fbf485c Andrew Chow: Allow tr() import only when Taproot is active
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #22224: Update msvc and appveyor builds to use Qt5.12.11 binaries (master...msvc_qt5.12.11) https://github.com/bitcoin/bitcoin/pull/22224
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22118: test: check anchors.dat when node starts for the first time (master...2021-05-improv-anchors-test) https://github.com/bitcoin/bitcoin/pull/22118
< bitcoin-git>
bitcoin/master 6985038 MarcoFalke: Merge bitcoin/bitcoin#22118: test: check anchors.dat when node starts for ...
< bitcoin-git>
bitcoin/master ef99d03 bruno: test: check anchors.dat when node starts for the first time
< bitcoin-git>
[bitcoin] fanquake merged pull request #22203: test: Use ConnmanTestMsg from test lib in denialofservice_tests (master...2106-testConnman) https://github.com/bitcoin/bitcoin/pull/22203
< bitcoin-git>
bitcoin/master 551933f fanquake: Merge bitcoin/bitcoin#22203: test: Use ConnmanTestMsg from test lib in den...
< bitcoin-git>
bitcoin/master fa72fce MarcoFalke: test: Use ConnmanTestMsg from test lib in denialofservice_tests
<@gribble>
https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
< jonatack>
Am about to push an update to the inbound eviction protection one. I was hoping to get back to the BTC/kvB-to-sat/vB transition in time for the release but that's unfeasible so just concentrating on finishing up https://github.com/bitcoin/bitcoin/pull/21261
< bitcoin-git>
[bitcoin] amadeuszpawlik opened pull request #22212: Guard `fHavePruned` to avoid potential data race (master...fix_guard_fhavepruned) https://github.com/bitcoin/bitcoin/pull/22212
< bitcoin-git>
[bitcoin] vasild opened pull request #22211: net: relay I2P addresses even if not reachable (by us) (master...i2p_IsRelayable) https://github.com/bitcoin/bitcoin/pull/22211
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (master...2106-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/22210