2021-04-26

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21777: test: Fix feature_notifications.py intermittent issue (master...2104-testFix) https://github.com/bitcoin/bitcoin/pull/21777

2021-04-25

< bitcoin-git> [gui] RandyMcMillan opened pull request #298: qt: peertableview alternating row colors (master...alt-row-colors) https://github.com/bitcoin-core/gui/pull/298
< bitcoin-git> [gui] hebasto opened pull request #297: Avoid unnecessary translations (master...210425-btc) https://github.com/bitcoin-core/gui/pull/297
< bitcoin-git> [gui] hebasto opened pull request #296: Do not use QObject::tr plural syntax for numbers with a unit symbol (master...210425-plurals) https://github.com/bitcoin-core/gui/pull/296
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21775: p2p: Limit m_block_inv_mutex (master...2104-netLockBlockInv) https://github.com/bitcoin/bitcoin/pull/21775
< luke-jr> if someone wants to help me get caught up on BIPs PRs, this one looks annoying to figure out if technically sound: https://github.com/bitcoin/bips/pull/1107/files
< bitcoin-git> bitcoin/master 5f438d6 João Barbosa: refactor, qt: Simplify SendCoinsDialog::updateCoinControlState
< bitcoin-git> bitcoin/master c4571a0 Hennadii Stepanov: Merge bitcoin-core/gui#284: refactor: Simplify SendCoinsDialog::updateCoin...
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f80092d78f7...c4571a0c39e0
< bitcoin-git> [gui] hebasto merged pull request #284: refactor: Simplify SendCoinsDialog::updateCoinControlState (master...2021-04-sendcoinsdialog) https://github.com/bitcoin-core/gui/pull/284
< hebasto> ryanofsky: your opinion in https://github.com/bitcoin-core/gui/issues/295 discussion will be much appreciated
< bitcoin-git> [gui] brunoerg closed pull request #294: Update GUI repository (master...master) https://github.com/bitcoin-core/gui/pull/294
< bitcoin-git> [gui] brunoerg opened pull request #294: Update GUI repository (master...master) https://github.com/bitcoin-core/gui/pull/294
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21773: fuzz: Ensure prevout is consensus-valid (master...2104-fuzzScript) https://github.com/bitcoin/bitcoin/pull/21773
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21563: net: Restrict period when cs_vNodes mutex is locked (master...210331-send) https://github.com/bitcoin/bitcoin/pull/21563
< bitcoin-git> bitcoin/master 8c8237a Hennadii Stepanov: net, refactor: Fix style in CConnman::StopNodes
< bitcoin-git> bitcoin/master 229ac18 Hennadii Stepanov: net: Combine two loops into one, and update comments
< bitcoin-git> bitcoin/master a3d090d Hennadii Stepanov: net: Restrict period when cs_vNodes mutex is locked
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/66fd3b28e85c...8f80092d78f7
< sipa> if you're going to ask more of these questions, it may be better to ask on https://bitcoin.stackexchange.com; it's more generic than just bitcoin core, and has lots of people answering
< CrazyPython> How many of the Bitcoin developers have churned? Anyone still around from the Satoshi days?
< CrazyPython> Is Bitcoin Core's block verification code highly optimized?
< luke-jr> CrazyPython: https://en.bitcoin.it/wiki/Consensus_versions might be useful
< sipa> there are lots of improvements being worked on by various people, some related to consensus rules, but far more things in p2p improvements (mostly in bitcoin core), generic software improvements in various software, other software stack built on top, ...
< CrazyPython> Are there any upcoming plans for optimizing Bitcoin? (Other than Taproot, Schnorr)
< sipa> in any case, this channel is about bitcoin core really
< CrazyPython> Has Bitcoin Core ever done an intended hard fork?
< CrazyPython> sipa: <hard fork count>.<soft fork count>.<patch count> could be a numbering system for bitcoin
< CrazyPython> If Bitcoin were on semver, then 0.x would mean Bitcoin is prone to backwards-incompatible changes
< sipa> bitcoin itself doesn't have a version number
< sipa> the next release of Bitcoin Core will be 22.0
< CrazyPython> When will bitcoin reach 1.0?

2021-04-24

< bitcoin-git> [gui] RandyMcMillan opened pull request #293: peers-tab: enable wordWrap for Services (master...enable-wordwrap-services) https://github.com/bitcoin-core/gui/pull/293

2021-04-23

< bitcoin-git> [gui] RandyMcMillan opened pull request #291: Network Graph layout - debug window improvement. (master...net-graph-layout) https://github.com/bitcoin-core/gui/pull/291
< darosior> meshcollider: if you mind giving a quick look to https://github.com/bitcoin/bitcoin/pull/20867 , fanquake asked you for review some time ago, and many other wallet people ACKed (or previous versions of it without nits-fixing)
< bitcoin-git> [bitcoin] dongcarl opened pull request #21767: [Bundle 6/n] Prune g_chainman usage in auxiliary modules (master...2020-10-libbitcoinruntime-v8) https://github.com/bitcoin/bitcoin/pull/21767
< hebasto> just wanted to announce a "Wallet" label in the gui repo -- https://github.com/bitcoin-core/gui/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3AWallet
< bitcoin-git> [bitcoin] JeremyRubin reopened pull request #21702: Implement BIP-119 Validation (CheckTemplateVerify) (master...checktemplateverify-rebase-4-15-21) https://github.com/bitcoin/bitcoin/pull/21702
< bitcoin-git> [bitcoin] JeremyRubin closed pull request #21702: Implement BIP-119 Validation (CheckTemplateVerify) (master...checktemplateverify-rebase-4-15-21) https://github.com/bitcoin/bitcoin/pull/21702
< gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
< jeremyrubin> that change was introduced my glozow https://github.com/bitcoin/bitcoin/blame/cfec4a1dad2181a5471b04f8a7b77ab64293fb13/src/test/transaction_tests.cpp#L191 looks like relatively recently
< jeremyrubin> unrelated to the actual PR itself, got a strange failure case on https://github.com/bitcoin/bitcoin/pull/21702
< bitcoin-git> [gui] jonatack opened pull request #290: Peers window `Peer id` improvements (master...peer-id-improvements) https://github.com/bitcoin-core/gui/pull/290
< jonatack> pox, that looks about right but maybe your install is elsewhere. perhaps these steps can help (or not ;) https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests
< bitcoin-git> [gui] jonatack opened pull request #289: Add "Direction" column to peers tab (master...add-direction-column-to-peers-tab) https://github.com/bitcoin-core/gui/pull/289
< bitcoin-git> [bitcoin] wu-emma opened pull request #21764: build: produce Windows GUI build with Cirrus CI (master...cirrus-winbuild) https://github.com/bitcoin/bitcoin/pull/21764
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21763: test: Run AppInitSanityChecks before all tests (master...2104-testCommonInit) https://github.com/bitcoin/bitcoin/pull/21763
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21732: MOVEONLY: Move common init code to init/common (master...pr/initc) https://github.com/bitcoin/bitcoin/pull/21732
< bitcoin-git> bitcoin/master 90469c1 Russell Yanofsky: Move common logging AddArg code to init/common
< bitcoin-git> bitcoin/master 387c4cf Russell Yanofsky: Move common sanity check code to init/common
< bitcoin-git> bitcoin/master a67b548 Russell Yanofsky: Move common global init code to init/common
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/4b5659c6b115...66fd3b28e85c
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21762: test: Speed up mempool_spend_coinbase.py (master...2104-testSpeed) https://github.com/bitcoin/bitcoin/pull/21762
< bitcoin-git> [bitcoin] laanwj merged pull request #21470: BIP 350: Implement Bech32m and use it for v1+ segwit addresses (0.20 backport) (0.20...202103_bech32m_0.20) https://github.com/bitcoin/bitcoin/pull/21470
< bitcoin-git> bitcoin/0.20 1a4e88e Pieter Wuille: Use Bech32m encoding for v1+ segwit addresses
< bitcoin-git> bitcoin/0.20 cf18ac9 Pieter Wuille: Add Bech32m test vectors
< bitcoin-git> bitcoin/0.20 5f9537b Pieter Wuille: Implement Bech32m encoding/decoding
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/f1c3c53e5f94...56311988bff1

2021-04-22

< luke-jr> achow101: is https://github.com/bitcoin/bips/pull/1100 a NACK?
< bitcoin-git> [bitcoin] Brightside56 opened pull request #21760: Add -flushwalletinterval command line arg (master...flushwalletinterval) https://github.com/bitcoin/bitcoin/pull/21760
< bitcoin-git> [bitcoin] glozow opened pull request #21759: wallet: document coin selection code (master...2021-04-wallet-docs) https://github.com/bitcoin/bitcoin/pull/21759
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/5577e0a4867c...d97d0d31a6f4
< bitcoin-git> bitcoin/0.21 d97d0d3 W. J. van der Laan: doc: Merge release notes fragment, merge taproot description from wiki
< gribble> https://github.com/bitcoin/bitcoin/issues/21470 | BIP 350: Implement Bech32m and use it for v1+ segwit addresses (0.20 backport) by sipa · Pull Request #21470 · bitcoin/bitcoin · GitHub
< wumpus> i see there's also a release notes fragment that needs to be merged in : https://github.com/bitcoin/bitcoin/blob/0.21/doc/release-notes-20861.md
< wumpus> speaking of releases i'm going to merge https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.21.1-Release-Notes-draft into the 0.21.1 release notes
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< meshcollider> Any admin of the Bitcoin org
< jnewbery> it does seem somewhat of a centralization problem. The BIPs repo is a venue for sharing proposed changes to Bitcoin, and one person decides who can update it, and also decides whether or not they should ever be replaced/supplemented?
< ariard> jeremyrubin: on the other point, I don't think bip2 recommend bitcoin-core-dev as a venue, maybe better suitted to #bitcoin or #bitcoin-wizards
< gribble> https://github.com/bitcoin/bitcoin/issues/21261 | p2p: update inbound eviction protection for multiple networks, add I2P peers by jonatack · Pull Request #21261 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 has 10 blockers, no bugfixes and nothing chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu Apr 22 19:00:00 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< MarcoFalke> It is mostly up to you, but for the Bitcoin Core repo we try to avoid commiting large blobs
< bitcoin-git> [bitcoin] practicalswift opened pull request #21756: Avoid calling `getnameinfo` when formatting IPv6 addresses in `CNetAddr::ToStringIP` (master...simplify-ipv6-address-formatting) https://github.com/bitcoin/bitcoin/pull/21756
< bitcoin-git> [bitcoin] prayank23 opened pull request #21755: Add more info about prefix in error message for invalid address (master...error-address) https://github.com/bitcoin/bitcoin/pull/21755
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21754: test: Run feature_cltv with MiniWallet (master...2104-testCltvNoWallet) https://github.com/bitcoin/bitcoin/pull/21754
< gribble> https://github.com/bitcoin/bitcoin/issues/21009 | Remove RewindBlockIndex logic by dhruv · Pull Request #21009 · bitcoin/bitcoin · GitHub
< provoostenator> Alright, I marked the external signer GUI PR as ready for review... https://github.com/bitcoin-core/gui/pull/4
< bitcoin-git> [bitcoin] jonatack opened pull request #21753: doc: add -addrinfo to tor docs (master...tor-doc-addrinfo) https://github.com/bitcoin/bitcoin/pull/21753
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19801: test: check for all possible OP_CLTV fail reasons in feature_cltv.py (BIP 65) (master...20200825-test-check-all-failure-reasons-for-CLTV) https://github.com/bitcoin/bitcoin/pull/19801
< bitcoin-git> bitcoin/master dbc1981 Sebastian Falbesoner: test: check that _all_ invalid-CLTV txs are allowed in a block pre-BIP65
< bitcoin-git> bitcoin/master 8d0ce50 Sebastian Falbesoner: test: prepare cltv_invalidate to test all failure reasons in feature_cltv....
< bitcoin-git> bitcoin/master ce994e1 Sebastian Falbesoner: test: add tx modfication helper function in feature_cltv.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/aaf66413e123...4b5659c6b115
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21564: net: Avoid calling getnameinfo when formatting IPv4 addresses in CNetAddr::ToStringIP (master...simplify-ipv4-address-formatting) https://github.com/bitcoin/bitcoin/pull/21564
< bitcoin-git> bitcoin/master aaf6641 MarcoFalke: Merge bitcoin/bitcoin#21564: net: Avoid calling getnameinfo when formattin...
< bitcoin-git> bitcoin/master 58580a8 practicalswift: net: Avoid calling getnameinfo when formatting IPv4 addresses in CNetAddr:...
< bitcoin-git> bitcoin/master 5858057 practicalswift: net: Add IPv4ToString (we already have IPv6ToString)
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e7776e20ed0d...aaf66413e123
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21752: scripted-diff: Clarify that feerates are per virtual size (master...2104-docFee) https://github.com/bitcoin/bitcoin/pull/21752
< fanquake> Why not just open it with the description, and avoid potential questions. i.e :https://github.com/bitcoin/bitcoin/pull/21749#discussion_r618227797
< bitcoin-git> [bitcoin] fanquake closed pull request #21751: Update nodes_main.txt (master...patch-3) https://github.com/bitcoin/bitcoin/pull/21751
< bitcoin-git> [bitcoin] d8n77ru57 opened pull request #21751: Update nodes_main.txt (master...patch-3) https://github.com/bitcoin/bitcoin/pull/21751
< bitcoin-git> [bitcoin] vasild opened pull request #21750: net: remove unnecessary check of CNode::cs_vSend (master...remove_unnecessary_check_of_CNode_cs_vSend) https://github.com/bitcoin/bitcoin/pull/21750
< bitcoin-git> [bitcoin] hebasto opened pull request #21749: test: Bump shellcheck version (master...210422-shell) https://github.com/bitcoin/bitcoin/pull/21749
< gribble> https://github.com/bitcoin/bitcoin/issues/21009 | Remove RewindBlockIndex logic by dhruv · Pull Request #21009 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #21748: 1.1 (master...1.1) https://github.com/bitcoin/bitcoin/pull/21748
< bitcoin-git> [bitcoin] widecoin-project opened pull request #21748: 1.1 (master...1.1) https://github.com/bitcoin/bitcoin/pull/21748
< BlueMatt> you asked why bitcoin core doesn't use something other than assert(), I answered why. There is, to my knowledge, nothing in bitcoin core that will abort() in a debug build and not in a release build, which appears to be what you want.
< BlueMatt> yanmaani: bitcoin core generally has historically treated assert() as "if this isn't true, we probably have buggy hardware, or otherwise may lose funds, continuing is unsafe". so running without assertions is definitely *not* a goal
< yanmaani> How come Bitcoin doesn't use a custom assert macro? That way, if NDEBUG is set, assert could be ((void)__VA_ARGS__) instead, allowing for compilation without assertions to be made.
< bitcoin-git> [bitcoin] jamesob opened pull request #21746: refactor: init: mark fReset const (master...2021-04-freset-const) https://github.com/bitcoin/bitcoin/pull/21746

2021-04-21

< bitcoin-git> bitcoin/master e7776e2 Hennadii Stepanov: Merge bitcoin-core/gui#286: qt: Bump transifex slug for 22.x
< bitcoin-git> bitcoin/master 4173059 W. J. van der Laan: qt: Bump transifex slug for 22.x
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e16f8720dca2...e7776e20ed0d
< bitcoin-git> [gui] hebasto merged pull request #286: qt: Bump transifex slug for 22.x (master...2021-04-transifex-slug-022x) https://github.com/bitcoin-core/gui/pull/286
< bitcoin-git> [bitcoin] whb07 opened pull request #21745: includes refactor pubkey.cpp/pubkey.h (master...refactor_imports_pubkey) https://github.com/bitcoin/bitcoin/pull/21745
< hebasto> wumpus: luke-jr: https://github.com/bitcoin-core/gui/issues/287 presents the results of experimental usage of XLIFF translation file; your opinion will be much appreciated
< gribble> https://github.com/bitcoin/bitcoin/issues/21694 | build: Use XLIFF file to provide more context to Transifex translators by hebasto · Pull Request #21694 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] laanwj opened pull request #286: qt: Bump transifex slug for 22.x (master...2021-04-transifex-slug-022x) https://github.com/bitcoin-core/gui/pull/286
< bitcoin-git> bitcoin/master e16f872 fanquake: Merge #21655: build, qt: No longer need to set QT_RCC_TEST=1 for determini...
< bitcoin-git> [bitcoin] fanquake merged pull request #21655: build, qt: No longer need to set QT_RCC_TEST=1 for determinism (master...210411-qhash) https://github.com/bitcoin/bitcoin/pull/21655
< bitcoin-git> bitcoin/master c799a19 Hennadii Stepanov: build, qt: No longer need to set QT_RCC_TEST=1 for determinism
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e507acb1184f...e16f8720dca2
< bitcoin-git> [bitcoin] fanquake merged pull request #20353: configure: Support -fdebug-prefix-map and -fmacro-prefix-map (master...202011-ccache-debug-prefix) https://github.com/bitcoin/bitcoin/pull/20353
< bitcoin-git> bitcoin/master e507acb fanquake: Merge #20353: configure: Support -fdebug-prefix-map and -fmacro-prefix-map...
< bitcoin-git> bitcoin/master 7abac98 Anthony Towns: configure: Support -f{debug,macro}-prefix-map
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2bce9329e8b9...e507acb1184f
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21719: refactor: Add and use EnsureConnman in rpc code (master...2104-netConnman) https://github.com/bitcoin/bitcoin/pull/21719
< bitcoin-git> bitcoin/master 2bce932 MarcoFalke: Merge bitcoin/bitcoin#21719: refactor: Add and use EnsureConnman in rpc co...
< bitcoin-git> bitcoin/master fafb68a MarcoFalke: refactor: Add and use EnsureConnman in rpc code
< bitcoin-git> bitcoin/master faabeb8 MarcoFalke: refactor: Mark member functions const
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f385ad765174...2bce9329e8b9
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21687: p2p: 1 IP per-connection policy (master...ameer_prevent_duplicate_connections_from_same_ip) https://github.com/bitcoin/bitcoin/pull/21687
< bitcoin-git> [bitcoin] windsok opened pull request #21740: test: add new python linter test for checking filenames and file permissions (master...file-permissions-linter) https://github.com/bitcoin/bitcoin/pull/21740

2021-04-20

< bitcoin-git> [gui] RandyMcMillan closed pull request #231: splash: new layout and new icon (master...new-icon) https://github.com/bitcoin-core/gui/pull/231
< bitcoin-git> [gui] RandyMcMillan closed pull request #208: docs: update README notes for /interfaces (master...interfaces-notes) https://github.com/bitcoin-core/gui/pull/208
< bitcoin-git> [gui] RandyMcMillan closed pull request #147: splash: New layout (master...splash) https://github.com/bitcoin-core/gui/pull/147
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< sipa> it won't get relayed by bitcoin core, because it's below the marginal feerate (the cost of relaying over the network is considered larger than what it's paying extra
< sipa> the only thing we neef reusable or usable from within Bitcoin Core is decoding/querying support, and we have that
< ariard> gleb: nah you can link *.c/*.cpp in rust, we can talk about it in rust-bitcoin if you wanna
< ariard> so it's about finishing asmap-rs as a functional bitcoin-asmap ?
< gleb> Bitcoin Core maintainers, every core release probably should get a new asmap file
< ariard> Who is maintainer here ? bitcoin core or asmap tooling one?
< jnewbery> I think amiti is doing a good job at analyzing the possible risk here: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-809906430
< gribble> https://github.com/bitcoin/bitcoin/issues/17194 | p2p: Avoid forwarding ADDR messages to SPV nodes by naumenkogs · Pull Request #17194 · bitcoin/bitcoin · GitHub
< ariard> imo that's okay to move "ready for review", if no one yells on the ml and main bitcoin libraries are behaving like core
< amiti> oh, another link is to a previous bitcoin-dev meeting where we discussed: http://www.erisian.com.au/bitcoin-core-dev/log-2021-03-25.html#l-954
< amiti> I’ve also looked at the implementations of every other client I’ve heard of =P and been recording that here: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-809906430
< amiti> I wrote to the mailing list: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-April/018784.html, and have not gotten any responses there
< amiti> The PR serves as a proof of concept for how this can be implemented in Bitcoin Core, but is currently in a draft because I have been trying to build confidence that this wouldn’t harm other software on the network.
< gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
< jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< gribble> https://github.com/bitcoin/bitcoin/issues/20 | JSON-RPC callback · Issue #20 · bitcoin/bitcoin · GitHub
< jnewbery> We also have three proposed topics for today's meeting: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#20-apr-2021
< jnewbery> As a reminder, everyone is free to share their p2p priorities here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
< core-meetingbot> Meeting started Tue Apr 20 21:01:33 2021 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> bitcoin/master 7931175 Hennadii Stepanov: qt: Do not assign Alt+<KEY> shortcuts to context menu actions
< bitcoin-git> bitcoin/master 963e120 Hennadii Stepanov: qt: Drop menu separator that separates nothing
< bitcoin-git> bitcoin/master 1398a65 Hennadii Stepanov: qt, refactor: Make AddressBookPage::deleteAction a local variable
< bitcoin-git> [bitcoin] hebasto pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bca00942ed27...f385ad765174
< bitcoin-git> [gui] hebasto merged pull request #263: Revamp context menus (master...210330-context) https://github.com/bitcoin-core/gui/pull/263
< jnewbery> Hi folks. Reminder that we have a p2p irc meeting in about 3.5 hours. Feel free to share your priorities here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities and add suggested topics here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21731: Update msvc build to use Qt5.12.10 binaries. (master...msvc_qt5.12.10) https://github.com/bitcoin/bitcoin/pull/21731
< bitcoin-git> bitcoin/master f02ca7a Aaron Clauson: Update msvc build to use Qt5.12.10 binaries.
< bitcoin-git> bitcoin/master bca0094 MarcoFalke: Merge bitcoin/bitcoin#21731: Update msvc build to use Qt5.12.10 binaries.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90e0faaa442b...bca00942ed27
< bitcoin-git> [bitcoin] dongcarl closed pull request #18963: [WIP] rebase: Call ProcessNewBlock() asynchronously (master...2020-05-async-pnb) https://github.com/bitcoin/bitcoin/pull/18963
< gribble> https://github.com/bitcoin/bitcoin/issues/21463 | doc: Address feedback from Transifex translator community by hebasto · Pull Request #21463 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #21694: build: Use XLIFF file to provide more context to Transifex translators (master...210415-xliff) https://github.com/bitcoin/bitcoin/pull/21694
< bitcoin-git> bitcoin/master f959b75 Hennadii Stepanov: build: Add Qt lconvert tool to depends
< bitcoin-git> bitcoin/master 99686b6 Hennadii Stepanov: qt [experimental]: Add a translation comment and a disambiguation string
< bitcoin-git> bitcoin/master 2045e4c Hennadii Stepanov: build: Use XLIFF file to provide more context to Transifex translators
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/018045347110...90e0faaa442b
< wumpus> e.g. the auto-update URL for 0.21.x right now in the transifex interface is : https://raw.githubusercontent.com/bitcoin/bitcoin/master/src/qt/locale/bitcoin_en.ts
< gribble> https://github.com/bitcoin/bitcoin/issues/21694 | build: Use XLIFF file to provide more context to Transifex translators by hebasto · Pull Request #21694 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master bb85cbc Jon Atack: doc: add cli -addrinfo release note
< bitcoin-git> [bitcoin] laanwj merged pull request #21595: cli: create -addrinfo (master...addressinfo) https://github.com/bitcoin/bitcoin/pull/21595
< bitcoin-git> bitcoin/master db4d2c2 Jon Atack: cli: create AddrinfoRequestHandler class
< bitcoin-git> bitcoin/master 5056a37 Jon Atack: cli: add -addrinfo command
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/30a86bb814e3...018045347110
< ShapeShifter499> so I have a question about the client. I'm on linux and I'm wondering does it matter what Berkeley Database Bitcoin is compiled against if I want to recover old wallets?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21733: build: Re-add command to install vcpkg (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21733
< bitcoin-git> bitcoin/master 30a86bb MarcoFalke: Merge bitcoin/bitcoin#21733: build: Re-add command to install vcpkg
< bitcoin-git> bitcoin/master de17d24 dplusplus1024: Re-add command to install vcpkg
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/572b36d4ff99...30a86bb814e3
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21738: test: Use clang-12 for ASAN, Add missing suppression (master...2104-asan) https://github.com/bitcoin/bitcoin/pull/21738
< bitcoin-git> [bitcoin] hebasto closed pull request #19213: util: Get rid of RecursiveMutex in Get{Blocks,Data}Dir (master...200608-path-mx) https://github.com/bitcoin/bitcoin/pull/19213
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21736: doc: Fix doxygen comment silent merge conflict in descriptor.cpp (master...2021-04-parameter-documentation) https://github.com/bitcoin/bitcoin/pull/21736
< bitcoin-git> bitcoin/master e5faec6 W. J. van der Laan: doc: Fix doxygen comment silent merge conflict in descriptor.cpp
< bitcoin-git> bitcoin/master 572b36d MarcoFalke: Merge bitcoin/bitcoin#21736: doc: Fix doxygen comment silent merge conflic...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/906ecb87c8c7...572b36d4ff99
< wumpus> december tends to be a really quiet month in bitcoin dev
< bitcoin-git> [bitcoin] laanwj opened pull request #21736: doc: Fix doxygen comment silent merge conflict in descriptor.cpp (master...2021-04-parameter-documentation) https://github.com/bitcoin/bitcoin/pull/21736
< bitcoin-git> [bitcoin] laanwj merged pull request #21238: A few descriptor improvements to prepare for Taproot support (master...202102_descriptor_prepare_taproot) https://github.com/bitcoin/bitcoin/pull/21238
< bitcoin-git> bitcoin/master 4441c6f Pieter Wuille: Make DescriptorImpl support multiple subscripts
< bitcoin-git> bitcoin/master a917478 Pieter Wuille: refactor: move population of out.scripts from ExpandHelper to MakeScripts
< bitcoin-git> bitcoin/master 84f3939 Pieter Wuille: Remove support for subdescriptors expanding to multiple scripts
< bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/de77cbc9d855...906ecb87c8c7
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21691: test: Check that no versionbits are re-used (master...2104-testVersionbits) https://github.com/bitcoin/bitcoin/pull/21691
< bitcoin-git> bitcoin/master fa8eaee MarcoFalke: test: Run versionbits_sanity for all chains
< bitcoin-git> bitcoin/master faec1e9 MarcoFalke: test: Address outstanding versionbits_test feedback
< bitcoin-git> bitcoin/master fad4167 MarcoFalke: test: Check that no versionbits are re-used
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a839303edc8a...de77cbc9d855
< gribble> https://github.com/bitcoin/bitcoin/issues/20353 | configure: Support -fdebug-prefix-map and -fmacro-prefix-map by ajtowns · Pull Request #20353 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ajtowns closed pull request #21378: Convert taproot to flag day activation (master...202103-taproot-flag-day) https://github.com/bitcoin/bitcoin/pull/21378
< bitcoin-git> [bitcoin] fanquake merged pull request #21244: Move GetDataDir to ArgsManager (master...feature/2021-02-get-data-dir-args) https://github.com/bitcoin/bitcoin/pull/21244
< bitcoin-git> bitcoin/master 1cb52ba Kiminuo: Modify "util_datadir" unit test to not use gArgs.
< bitcoin-git> bitcoin/master 1add318 Kiminuo: Move GetDataDir(fNetSpecific) implementation to ArgsManager.
< bitcoin-git> bitcoin/master 70cdf67 Kiminuo: Move StripRedundantLastElementsOfPath before ArgsManager class.
< bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/67a359313f79...a839303edc8a
< bitcoin-git> bitcoin/master 67a3593 fanquake: Merge #21728: remove executable flag for src/net_processing.cpp
< bitcoin-git> [bitcoin] fanquake merged pull request #21728: remove executable flag for src/net_processing.cpp (master...2021-remove-exec-flag-from-net_processing) https://github.com/bitcoin/bitcoin/pull/21728
< bitcoin-git> bitcoin/master f2f2541 Sebastian Falbesoner: remove executable flag for src/net_processing.cpp
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/13d27b452d4b...67a359313f79

2021-04-19

< gribble> https://github.com/bitcoin/bitcoin/issues/20017 | rpc: Add RPCContext by promag · Pull Request #20017 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dplusplus1024 opened pull request #21733: build: Re-add command to install vcpkg (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21733
< bitcoin-git> [bitcoin] ryanofsky opened pull request #21732: MOVEONLY: Move common init code to init/common (master...pr/initc) https://github.com/bitcoin/bitcoin/pull/21732
< provoostenator> aj: you should rebase https://github.com/ajtowns/bitcoin/commits/anyprevout and make it a draft PR :-)
< gribble> https://github.com/bitcoin/bitcoin/issues/21238 | A few descriptor improvements to prepare for Taproot support by sipa · Pull Request #21238 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20851 | Release schedule for 22.0 · Issue #20851 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipsorcery opened pull request #21731: Update msvc build to use Qt5.12.10 binaries. (master...msvc_qt5.12.10) https://github.com/bitcoin/bitcoin/pull/21731
< gribble> https://github.com/bitcoin/bitcoin/issues/21694 | build: Use XLIFF file to provide more context to Transifex translators by hebasto · Pull Request #21694 · bitcoin/bitcoin · GitHub
< Arvidt> I changed the hostname in my script from bitcoin.org to bitcoincore.org now it is working again. And the download speed is very fast now that's fine
< bitcoin-git> bitcoin/master 13d27b4 Hennadii Stepanov: Merge bitcoin-core/gui#276: Elide long strings in their middle in the Peer...
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfec4a1dad21...13d27b452d4b
< bitcoin-git> bitcoin/master 4e06133 Hennadii Stepanov: qt: Elide long strings in their middle in the Peers tab
< bitcoin-git> [gui] hebasto merged pull request #276: Elide long strings in their middle in the Peers tab (master...210410-elide) https://github.com/bitcoin-core/gui/pull/276
< Arvidt> Thanks, you are right, with Firefox I was on https://bitcoincore.org/bin/ there is the 0.21.1 but also with Firefox _not_ on https://bitcoin.org/bin/
< harding> Arvidt: I don't see a 0.21.1 folder on bitcoin.org/bin/ ; are you sure you're seeing it? In any case, the preferred location to get the binaries is from https://bitcoincore.org/bin/
< Arvidt> <a href="bitcoin-core-0.9.5/">bitcoin-core-0.9.5/</a> 27-Mar-2017 19:45 -
< Arvidt> <a href="bitcoin-core-0.21.0/">bitcoin-core-0.21.0/</a> 14-Jan-2021 18:05 -
< Arvidt> <a href="bitcoin-core-0.20.1/">bitcoin-core-0.20.1/</a> 01-Aug-2020 12:40 -
< Arvidt> <a href="bitcoin-core-0.20.0/">bitcoin-core-0.20.0/</a> 03-Jun-2020 10:15 -
< Arvidt> I have a Bitcoin binary download script that determines the latest version by parsing the output of 'wget -q -O - https://bitcoin.org/bin/' but there is no subfolder bitcoin-core-0.21.1/ in the output, while when I open https://bitcoin.org/bin/ with Firefox, the 0.21.1 subfolder is shown? Before I never had problems with my script. Also tried wget with --no-cache, but that did not help.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21280: test: bug fix in transaction_tests (master...2021-02-test-bug) https://github.com/bitcoin/bitcoin/pull/21280
< bitcoin-git> bitcoin/master 5aee73d glozow: [test] minor improvements / followups
< bitcoin-git> bitcoin/master 8a365df glozow: [test] fix bug in ExcludeIndividualFlags
< bitcoin-git> bitcoin/master 8cac292 glozow: [test] remove invalid test from tx_valid.json
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/83c715415a88...cfec4a1dad21
< gribble> https://github.com/bitcoin/bitcoin/issues/21729 | Write linter to check file permissions · Issue #21729 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21728 | remove executable flag for src/net_processing.cpp by theStack · Pull Request #21728 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theStack opened pull request #21728: remove executable flag for src/net_processing.cpp (master...2021-remove-exec-flag-from-net_processing) https://github.com/bitcoin/bitcoin/pull/21728
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20857: test: update documentation in feature_csv_activation.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20857
< bitcoin-git> bitcoin/master 83c7154 MarcoFalke: Merge #20857: test: update documentation in feature_csv_activation.py
< bitcoin-git> bitcoin/master 9053b88 Pierre K: update docstring in feature_csv_activation.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d4300a10ddd6...83c715415a88
< gribble> https://github.com/bitcoin/bitcoin/issues/21713 | Refactor ProcessNewBlock to reduce code duplication by rebroad · Pull Request #21713 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21679: rpc: Keep default argument value in correct type (master...2021-04-rpc-defaults) https://github.com/bitcoin/bitcoin/pull/21679
< bitcoin-git> bitcoin/master d4300a1 MarcoFalke: Merge #21679: rpc: Keep default argument value in correct type
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/17b51cd5cb9c...d4300a10ddd6
< bitcoin-git> bitcoin/master f81ef43 João Barbosa: rpc: Keep default argument value in correct type
< bitcoin-git> bitcoin/master bee56c7 João Barbosa: rpc: Check default value type againts argument type
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21713: Refactor ProcessNewBlock to reduce code duplication (master...RefactorProcessNewBlock) https://github.com/bitcoin/bitcoin/pull/21713
< bitcoin-git> bitcoin/master 17b51cd MarcoFalke: Merge #21713: Refactor ProcessNewBlock to reduce code duplication
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ed133fe005d8...17b51cd5cb9c
< bitcoin-git> bitcoin/master 9a06535 R E Broadley: Refactor ProcessNewBlock to reduce code duplication
< bitcoin-git> [bitcoin] laanwj merged pull request #21615: script: Add trusted key for hebasto (master...210406-key) https://github.com/bitcoin/bitcoin/pull/21615
< bitcoin-git> bitcoin/master ed133fe W. J. van der Laan: Merge #21615: script: Add trusted key for hebasto
< bitcoin-git> bitcoin/master 55d8583 Hennadii Stepanov: script: Add trusted key for hebasto
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a47ae618a00c...ed133fe005d8
< bitcoin-git> [bitcoin] fanquake merged pull request #21718: rpc: Improve error message for getblock invalid datatype. (master...master) https://github.com/bitcoin/bitcoin/pull/21718
< bitcoin-git> bitcoin/master a47ae61 fanquake: Merge #21718: rpc: Improve error message for getblock invalid datatype.
< bitcoin-git> bitcoin/master a411494 klementtan: rpc: Improve getblock error message for invalid data type.
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0dd7b234895b...a47ae618a00c
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21727: refactor: Move more stuff to blockstorage (master...2104-blockstorage) https://github.com/bitcoin/bitcoin/pull/21727
< wumpus> might be useful for getting immediate feedback on whose build mismatches and how exactly: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/91
< bitcoin-git> bitcoin/0.21 5577e0a W. J. van der Laan: doc: Add PR and author list to release notes for 0.21.1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/329eafa7f453...5577e0a4867c

2021-04-18

< bitcoin-git> [bitcoin] fjahr opened pull request #21726: Add prune blockers to BlockManager (master...prune_improve) https://github.com/bitcoin/bitcoin/pull/21726
< bitcoin-git> [gui] promag opened pull request #284: refactor, qt: Simplify SendCoinsDialog::updateCoinControlState (master...2021-04-sendcoinsdialog) https://github.com/bitcoin-core/gui/pull/284
< bitcoin-git> [bitcoin] JeremyRubin closed pull request #21721: [WIP][POC][DONOTMERGE] Flag Day ST Compatible Logic w/ Optional Mandatory Signalling (0.21...uasf) https://github.com/bitcoin/bitcoin/pull/21721
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #21721: [WIP][POC][DONOTMERGE] Flag Day ST Compatible Logic w/ Optional Mandatory Signalling (0.21...uasf) https://github.com/bitcoin/bitcoin/pull/21721

2021-04-17

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21719: refactor: Add and use EnsureConnman in rpc code (master...2104-netConnman) https://github.com/bitcoin/bitcoin/pull/21719
< bitcoin-git> bitcoin/master d485e81 Carl Dong: rpc/blockchain: Use existing NodeContext
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21391: [Bundle 5/n] Prune g_chainman usage in RPC modules (master...2020-10-libbitcoinruntime-v7) https://github.com/bitcoin/bitcoin/pull/21391
< bitcoin-git> bitcoin/master d0abf0b Carl Dong: rpc/*,rest: Add review-only assertion to EnsureChainman
< bitcoin-git> bitcoin/master cced0f4 Carl Dong: miner: Pass in previous CBlockIndex to RegenerateCommitments
< bitcoin-git> [bitcoin] MarcoFalke pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/4a1751a929cc...0dd7b234895b
< bitcoin-git> bitcoin/master 4a1751a MarcoFalke: Merge bitcoin-core/gui#277: Do not use QClipboard::Selection on Windows an...
< bitcoin-git> bitcoin/master 7f3a598 Hennadii Stepanov: qt: Do not use QClipboard::Selection on Windows and macOS.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5e8bcf985df...4a1751a929cc
< bitcoin-git> [gui] MarcoFalke merged pull request #277: Do not use QClipboard::Selection on Windows and macOS. (master...210410-clip) https://github.com/bitcoin-core/gui/pull/277
< bitcoin-git> [bitcoin] klementtan reopened pull request #21718: rpc: Improve error message for getblock invalid datatype. (master...master) https://github.com/bitcoin/bitcoin/pull/21718
< bitcoin-git> [bitcoin] klementtan closed pull request #21718: rpc: Improve error message for getblock invalid datatype. (master...master) https://github.com/bitcoin/bitcoin/pull/21718
< bitcoin-git> [bitcoin] klementtan opened pull request #21718: rpc: Improve error message for getblock invalid datatype. (master...master) https://github.com/bitcoin/bitcoin/pull/21718
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21689: test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in `cnetaddr_basic` (master...remove-intermittently-failing-and-largely-meaningless-ipv6-test) https://github.com/bitcoin/bitcoin/pull/21689
< bitcoin-git> bitcoin/master f5e8bcf MarcoFalke: Merge #21689: test: Remove intermittently failing and not very meaningful ...
< bitcoin-git> bitcoin/master 63631be practicalswift: test: Remove intermittently failing and not very meaningful `BOOST_CHECK` ...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e69370b1506...f5e8bcf985df
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21712: qa: Test default include_mempool value of gettxout (master...2021-04-gettxout) https://github.com/bitcoin/bitcoin/pull/21712
< bitcoin-git> bitcoin/master 8e69370 MarcoFalke: Merge #21712: qa: Test default include_mempool value of gettxout
< bitcoin-git> bitcoin/master 44dab42 João Barbosa: qa: Test default include_mempool value of gettxout
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/585cbe225753...8e69370b1506
< bitcoin-git> [bitcoin] promag opened pull request #21714: refactor: Drop CCoinControl::SetNull (master...2021-04-coincontrol) https://github.com/bitcoin/bitcoin/pull/21714