<bitcoin-git>
[bitcoin] w0xlt opened pull request #26174: rpc, wallet: add ability to retrieve all address book entries (master...list_address_book) https://github.com/bitcoin/bitcoin/pull/26174
<amovfx>
I would get some input from some people that have more experience with bitcoin than me, they may provide guidance that will save you a fair amount of time.
<adam2k>
👋 I'm looking to help out cleaning up or picking up on some older stale issues. Any opinions on this issue https://github.com/bitcoin/bitcoin/issues/4176 or any others that are more pressing?
<bitcoin-git>
[bitcoin] Sjors opened pull request #26162: Remove taproot chain param and list exception blocks in getdeploymentinfo (master...2022/09/taproot) https://github.com/bitcoin/bitcoin/pull/26162
<jonatack>
amovfx: another suggestion would be to git clone the bitcoin optech and the bitcoin core pr reviews repositories locally and then search them for the terms you are interested in
<gribble>
https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
<warren>
Somewhat related, when Fedora packaged bitcoin core they insisted on running "make check" during every package build. I tried to argue even Bitcoin Core's own binary distribution process doesn't do that because it's way too slow?
<sipa>
and bitcoin-tx tests
<gribble>
https://github.com/bitcoin/bitcoin/issues/23417 | wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101 · Pull Request #23417 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] benthecarman closed pull request #26157: rpc: Fix ordering of arguments in listtransactions help message (master...fix-list-txs-help) https://github.com/bitcoin/bitcoin/pull/26157
<bitcoin-git>
[bitcoin] benthecarman opened pull request #26157: rpc: Fix ordering of arguments in listtransactions help message (master...fix-list-txs-help) https://github.com/bitcoin/bitcoin/pull/26157
<amovfx>
I don't suppose I could grab some guidance on what to focus on to be a core dev. I'm noob, right now I'm doing the blockchain commons learn bitcoin by the commandline, reviewing prs, and doing the pr review club
<bitcoin-git>
[bitcoin] theStack opened pull request #26156: test: check that `listdescriptors` descriptor strings are sorted (master...202209-test-rpc-check_sorted_listdescriptors_strings) https://github.com/bitcoin/bitcoin/pull/26156
<_aj_>
amovfx: cool; it's an anti-spam thing on some bitcoin channels
<bitcoin-git>
[bitcoin] yancyribbens opened pull request #26154: refactor: move coin_control variable to test setup section (master...move-coin-control-setup) https://github.com/bitcoin/bitcoin/pull/26154
2022-09-21
<bitcoin-git>
[bitcoin] sipa opened pull request #26153: Reduce wasted pseudorandom bytes in ChaCha20 + various improvements (master...202209_chacha20) https://github.com/bitcoin/bitcoin/pull/26153
<bitcoin-git>
[bitcoin] Xekyo opened pull request #26152: Bump unconfirmed ancestor transactions to target feerate (master...2022-09-ancestor-aware-funding) https://github.com/bitcoin/bitcoin/pull/26152
<bitcoin-git>
[bitcoin] dergoegge opened pull request #26151: refactor: Guard TxRequestTracker by its own lock instead of cs_main (master...2022-09-txrequest-cs_main-split) https://github.com/bitcoin/bitcoin/pull/26151
<bitcoin-git>
[bitcoin] fanquake merged pull request #26145: [24.x] init: abort if i2p/cjdns are chosen via -onlynet but are unreachable (24.x...202208_onlynet_init) https://github.com/bitcoin/bitcoin/pull/26145
<kouloumos>
That makes sense, thanks. So opening an issue there sounds a better approach than even dealing with https://github.com/bitcoin-core/gui/issues/126. I'll just need to add a bit of guidance on that flow cause, as a new user, it took me a bit of time to find my way through transifex.
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26147: [24.x] rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR (24.x...2022_rpc_remove_type_check) https://github.com/bitcoin/bitcoin/pull/26147
<bitcoin-git>
[bitcoin] fanquake merged pull request #25737: rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR (master...2022_rpc_remove_type_check) https://github.com/bitcoin/bitcoin/pull/25737
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26145: [24.x] init: abort if i2p/cjdns are chosen via -onlynet but are unreachable (24.x...202208_onlynet_init) https://github.com/bitcoin/bitcoin/pull/26145
<bitcoin-git>
bitcoin/master 97f865b fanquake: Merge bitcoin/bitcoin#25989: init: abort if i2p/cjdns are chosen via -only...
<bitcoin-git>
[bitcoin] fanquake merged pull request #25989: init: abort if i2p/cjdns are chosen via -onlynet but are unreachable (master...202208_onlynet_init) https://github.com/bitcoin/bitcoin/pull/25989
<bitcoin-git>
bitcoin/master a8a9ed6 Martin Zumsande: init: Abort if i2p/cjdns are chosen via -onlynet but unreachable
<bitcoin-git>
bitcoin/master 68209a7 Martin Zumsande: rpc: make addpeeraddress work with cjdns addresses
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26144: [24.x] wallet: Fix nNextResend data race in ResubmitWalletTransactions (24.x...2209-wallet-race-💆) https://github.com/bitcoin/bitcoin/pull/26144
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26143: test: wait for the expected basic block filter index in `interface_rest` (master...2022-10-fix-rest-test) https://github.com/bitcoin/bitcoin/pull/26143
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26143: test: wait for the expected basic block filter index in `interface_rest` (master...2022-10-fix-rest-test) https://github.com/bitcoin/bitcoin/pull/26143
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26127: test: check that bumping tx with already spent coin fails (master...202209-test-bumpfee-check_that_bumping_tx_with_spent_input_fails) https://github.com/bitcoin/bitcoin/pull/26127
<bitcoin-git>
bitcoin/master 2c03465 Aurèle Oulès: test: Test watchonly imports with passphrase-locked wallet
<bitcoin-git>
[bitcoin] hebasto opened pull request #26142: Use `PACKAGE_NAME` in messages rather than hardcoding "Bitcoin Core" (master...220920-package) https://github.com/bitcoin/bitcoin/pull/26142
<bitcoin-git>
[bitcoin] dergoegge opened pull request #26140: refactor: Move CNodeState members guarded by g_msgproc_mutex to Peer (master...2022-09-move-cnodestate-msgproc-members) https://github.com/bitcoin/bitcoin/pull/26140
<bitcoin-git>
[bitcoin] luke-jr opened pull request #26139: doc: Drop historical release-notes directory (master...drop_historical_relnotes) https://github.com/bitcoin/bitcoin/pull/26139
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26138: test: Avoid race in disconnect_nodes helper (master...2209-test-race-🍄) https://github.com/bitcoin/bitcoin/pull/26138
<bitcoin-git>
bitcoin/master bf12abe Anthony Towns: net: drop cs_sendProcessing
<bitcoin-git>
bitcoin/master a66a7cc Anthony Towns: net_processing: add thread safety annotations for Peer members accessed on...
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26123: [24.x] doc: Move -permitbaremultisig to the relay help category (24.x...2209-doc-help-🌹) https://github.com/bitcoin/bitcoin/pull/26123
<bitcoin-git>
bitcoin/master 9843a8c MacroFake: Merge bitcoin/bitcoin#26119: doc: Move -permitbaremultisig to the relay he...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26119: doc: Move -permitbaremultisig to the relay help category (master...2209-doc-help-🌹) https://github.com/bitcoin/bitcoin/pull/26119
<bitcoin-git>
[bitcoin] fanquake merged pull request #26005: Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) (master...fix_wallet_copyfail_nullresult) https://github.com/bitcoin/bitcoin/pull/26005
<bitcoin-git>
bitcoin/master 335ff98 Luke Dashjr: Bugfix: Wallet: Wrap RestoreWallet content in a try block to ensure except...
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26119: doc: Move -permitbaremultisig to the relay help category (master...2209-doc-help-🌹) https://github.com/bitcoin/bitcoin/pull/26119
<bitcoin-git>
[bitcoin] yancyribbens opened pull request #26111: refactor: Simplify bnb coin_selection test params (master...simplify-bnb-test-params) https://github.com/bitcoin/bitcoin/pull/26111
<sipa>
It looks to me that being a member of the "frequent contributors" group on the bitcoin-core org is sufficient.
<fanquake>
although I'm not sure if write access is needed to make edits? Maybe just being a member of bitcoin-core orgnanisation (which it doesn't look like you were a part of either)
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25971: refactor: Use std::string for thread and index names (master...baseindex-getname-string) https://github.com/bitcoin/bitcoin/pull/25971
<bitcoin-git>
bitcoin/master 26cf9ea stickies-v: scripted-diff: rename pszThread to thread_name
<bitcoin-git>
bitcoin/master 04fee75 Pieter Wuille: Use ReadLE64 in uint256::GetUint64() instead of duplicating logic
<bitcoin-git>
bitcoin/master 2530a24 fanquake: Merge bitcoin/bitcoin#26105: Use ReadLE64 in uint256::GetUint64 instead of...
<bitcoin-git>
[bitcoin] fanquake merged pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
<bitcoin-git>
bitcoin/master 8b2891a Vasil Dimov: i2p: use the same destination type for transient and persistent addresses
<bitcoin-git>
bitcoin/master 19526d9 fanquake: Merge bitcoin/bitcoin#26065: i2p: use the same destination type for transi...
<robertspigler>
bitcoin/contrib/seeds/nodes_main.txt, I still don't have any automatic outbound or inbound I2P peers. Is this an issue with preferential peering?
<bitcoin-git>
[bitcoin] sipa opened pull request #26105: Use ReadLE64 in uint256::GetUint64 instead of duplicating logic (master...202209_uint256_readle64) https://github.com/bitcoin/bitcoin/pull/26105
<bitcoin-git>
[bitcoin] Xekyo closed pull request #26104: coin selection: Check whether feerate is higher than long_term_feerate only once (master...2022-09-high-feerate-optimization) https://github.com/bitcoin/bitcoin/pull/26104
<bitcoin-git>
[bitcoin] Xekyo opened pull request #26104: Check whether feerate is higher than long_term_feerate only once (master...2022-09-high-feerate-optimization) https://github.com/bitcoin/bitcoin/pull/26104
<kouloumos>
Great! thank you everyone, I'll look into including 25717 and give progress updates in https://github.com/bitcoin/bitcoin/issues/26092 . Please reach out with ideas and feedback. Thanks!
<bitcoin-git>
[bitcoin] stickies-v opened pull request #26103: refactor: mempool: use CTxMemPool::Limits (master...mempool-simplify-fn-signatures) https://github.com/bitcoin/bitcoin/pull/26103
<kouloumos>
From the release notes ( https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft ), I've already included testing guidance for 4 changes that I think most worthwhile to test and I have 1 pending. I'd appreciate feedback on if you think anything else should be included, and if maybe something can be omitted.
<gribble>
https://github.com/bitcoin/bitcoin/issues/26005 | Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) by luke-jr · Pull Request #26005 · bitcoin/bitcoin · GitHub