2021-01-28

< gribble> https://github.com/bitcoin/bitcoin/issues/20749 | [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex by dongcarl · Pull Request #20749 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] jonasschnelli merged pull request #85: Remove unused "What's This" button in dialogs on Windows OS (master...200907-whatsit) https://github.com/bitcoin-core/gui/pull/85
< bitcoin-git> bitcoin/master ac7ccd6 Hennadii Stepanov: scripted-diff: Remove unused "What's This" button in dialogs on Windows
< bitcoin-git> bitcoin/master 68692d3 Jonas Schnelli: Merge bitcoin-core/gui#85: Remove unused "What's This" button in dialogs o...
< bitcoin-git> bitcoin/master b695148 Hennadii Stepanov: qt: Add flags to prevent a "What's This" button on Windows OS
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/759518354377...68692d33c6c5
< bitcoin-git> bitcoin/master 7595183 Jonas Schnelli: Merge bitcoin-core/gui#72: util: Log static plugins meta data and used sty...
< bitcoin-git> bitcoin/master 957895c Hennadii Stepanov: util: Log static plugins meta data and style
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02b01651c562...759518354377
< bitcoin-git> [gui] jonasschnelli merged pull request #72: util: Log static plugins meta data and used style (master...200812-log) https://github.com/bitcoin-core/gui/pull/72
< bitcoin-git> bitcoin/master 02b0165 Jonas Schnelli: Merge bitcoin-core/gui#177: Use "fusion" style on macOS Big Sur with old Q...
< bitcoin-git> bitcoin/master 4e1154d Hennadii Stepanov: qt: Use "fusion" style on macOS Big Sur with old Qt
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9deba2de764f...02b01651c562
< bitcoin-git> [gui] jonasschnelli merged pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177
< jonasschnelli> ^ --- ithubmerge.pushmirrors=git@github.com:bitcoin-core/gui.git
< bitcoin-git> [bitcoin] fctorial opened pull request #21020: Add check for gnu sed inplace replace (master...gnu_sed) https://github.com/bitcoin/bitcoin/pull/21020
< sipa> sob3rkid: this channel is for development bitcoin core, a specific implementation of the bitcoin protocol
< gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
< dongcarl> In the meeting on the 14th, people asked jamesob and me to take a look at potential AssumeUTXO and chainman-deglobalization conflicts and if a certain merge order is preferable. Here is the result: https://github.com/bitcoin/bitcoin/pull/19806#issuecomment-768673523
< bitcoin-git> [bitcoin] meshcollider merged pull request #20226: wallet, rpc: add listdescriptors command (master...listdescriptors) https://github.com/bitcoin/bitcoin/pull/20226
< bitcoin-git> bitcoin/master 9deba2d Samuel Dobson: Merge #20226: wallet, rpc: add listdescriptors command
< bitcoin-git> bitcoin/master 647b81b Ivan Metlushko: wallet, rpc: add listdescriptors command
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d1ddead09a58...9deba2de764f

2021-01-27

< shesek> I filed an issue for conflicted wallet transactions: https://github.com/bitcoin/bitcoin/issues/21018
< gribble> https://github.com/bitcoin/bitcoin/issues/20892 | tests: Run both descriptor and legacy tests within a single test invocation by achow101 · Pull Request #20892 · bitcoin/bitcoin · GitHub
< S3RK> luke-jr wrt https://github.com/bitcoin/bitcoin/pull/20226#issuecomment-768392164 I've pushed updated test with my comment so it won't fail anymore. Sorry it wasn't clear from my original comment
< bitcoin-git> bitcoin/master f3153dc Jon Atack: gui: improve markup handling of connection type tooltip
< bitcoin-git> bitcoin/master 79a2576 Jon Atack: doc: update ConnectionType Doxygen documentation
< bitcoin-git> bitcoin/master 4f09615 Jon Atack: gui: return inbound {full, block} relay type in peer details
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/15a9df070615...d1ddead09a58
< bitcoin-git> [gui] laanwj merged pull request #180: Peer details: connection type follow-ups (master...peer-details-connection-type-followups) https://github.com/bitcoin-core/gui/pull/180
< bitcoin-git> [bitcoin] laanwj closed pull request #20957: doc: Update tor.md for notes on how to preserve v2 urls (with a not recommended note) (master...tor-controlport-docs) https://github.com/bitcoin/bitcoin/pull/20957
< bitcoin-git> [bitcoin] laanwj merged pull request #20964: rpc: Add specific error code for "wallet already loaded" (master...2021-01-wallet-already-loaded-rpc) https://github.com/bitcoin/bitcoin/pull/20964
< bitcoin-git> bitcoin/master 15a9df0 Wladimir J. van der Laan: Merge #20964: rpc: Add specific error code for "wallet already loaded"
< bitcoin-git> bitcoin/master a6739cc Wladimir J. van der Laan: rpc: Add specific error code for "wallet already loaded"
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/11d3b5833671...15a9df070615
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20757: doc: tor.md and -onlynet help updates (master...tor-md-doc-updates) https://github.com/bitcoin/bitcoin/pull/20757
< bitcoin-git> bitcoin/master 9af99b6 Jon Atack: doc: update/improve automatic tor section of tor.md
< bitcoin-git> bitcoin/master dfc4ce1 saibato: doc: update -proxy, -onion and -onlynet info in tor.md
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e130ff38c91a...11d3b5833671
< bitcoin-git> bitcoin/master 784a278 Jon Atack: doc: update -onlynet help in src/init.cpp
< vasild> MarcoFalke: wrt https://github.com/jnewbery/bitcoin/pull/18#issuecomment-768216999: -use_value_profile=1 does not make much difference, if any
< bitcoin-git> [bitcoin] fanquake opened pull request #21016: refactor: remove boost::thread_group usage (master...remove_boost_threadgroup) https://github.com/bitcoin/bitcoin/pull/21016
< bitcoin-git> [gui] Bosch-0 opened pull request #199: Added updated bitcoin PNG / SVG icon (master...bitcoin_icon) https://github.com/bitcoin-core/gui/pull/199
< fanquake> It seems quite annoying if GitHub will close issues in the bitcoin-core/gui repo, when I, or potentially anyone else, push to their own repos (fanquake/bitcoin)
< fanquake> I fetched upstream, merged it into my bitcoin fork, then pushed that back to GitHub (fanquake/bitcoin).
< gribble> https://github.com/bitcoin/bitcoin/issues/101 | Shy clients by gavinandresen · Pull Request #101 · bitcoin/bitcoin · GitHub

2021-01-26

< bitcoin-git> [bitcoin] dhruv opened pull request #21015: Make all of net_processing (and some of net) use std::chrono types (master...pr-20044) https://github.com/bitcoin/bitcoin/pull/21015
< sipa> norisgOG: this is getting off topic; there are several answers about this on https://bitcoin.stackexchange.com, and people are probably willing to help on #bitcoin
< norisgOG> I followed the build process in doc/unix-build but its missing the configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for wallet functionality
< bitcoin-git> [bitcoin] stackman27 opened pull request #21014: test: Run mempool_accept.py even with wallet disabled (master...diswallet_mempoolaccept) https://github.com/bitcoin/bitcoin/pull/21014
< vasild> jnewbery: review https://github.com/jnewbery/bitcoin/pull/18 carefully, it looks a bit suspicious to me.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20044: Make all of net_processing (and some of net) use std::chrono types (master...202009_chrono_types) https://github.com/bitcoin/bitcoin/pull/20044
< vasild> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities -- all entries are from Jan 27, but today is Jan 26.
< gribble> https://github.com/bitcoin/bitcoin/issues/20557 | addrman: Fix new table bucketing during unserialization by jnewbery · Pull Request #20557 · bitcoin/bitcoin · GitHub
< wumpus> jonatack: seems like a nice tool, the only thing i dislike is that it's written in go, i'd managed to avoid having to install a go toolchain on my bitcoin dev VM until now :-)
< jnewbery> ok, let's call the meeting there. Homework for next meeting on Feb 9 is to fill in your priorities in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities so we have something to talk about
< gribble> https://github.com/bitcoin/bitcoin/issues/20044 | Make all of net_processing (and some of net) use std::chrono types by sipa · Pull Request #20044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
< jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
< jnewbery> wumpus: I have pr -> https://github.com/bitcoin/bitcoin/pull/%s and bc -> https://github.com/bitcoin/bitcoin/search?q=%s . The second one is particularly useful for jumping from a commit hash in git to the commit/PR in github
< gribble> https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
< jnewbery> Hi folks. We have a p2p meeting in about 25 minutes. Two proposed topics at https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#26-jan-2021
< aj> wumpus: i setup https://github.com/bitcoin/bitcoin/pull/%s as a bookmark in firefox with the keyword "btc" so i can type "btc 12345" in the url bar to get to PR 12345
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
< gribble> https://github.com/bitcoin/bitcoin/issues/21008 | test: fix zmq test flakiness, improve speed by theStack · Pull Request #21008 · bitcoin/bitcoin · GitHub
< wumpus> viraltaco_: again, #bitcoin please
< bitcoin-git> bitcoin/master e130ff3 MarcoFalke: Merge bitcoin-core/gui#183: Add include for std::bind.
< bitcoin-git> bitcoin/master 2a39ccf sinetek: Add include for std::bind.
< bitcoin-git> [gui] MarcoFalke merged pull request #183: Add include for std::bind. (master...functional) https://github.com/bitcoin-core/gui/pull/183
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5f65f135977e...e130ff38c91a
< bitcoin-git> bitcoin/master 5f65f13 Jonas Schnelli: Merge bitcoin-core/gui#189: qt: drop workaround for QTBUG-42503 which was ...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d38e2d9a19c9...5f65f135977e
< bitcoin-git> bitcoin/master a2a3f4c Pavol Rusnak: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0
< bitcoin-git> [gui] jonasschnelli merged pull request #189: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0 (master...qtbug-42503) https://github.com/bitcoin-core/gui/pull/189
< bitcoin-git> [gui] jonasschnelli merged pull request #186: Add information to "Confirm fee bump" window (master...bump-fee) https://github.com/bitcoin-core/gui/pull/186
< bitcoin-git> bitcoin/master d38e2d9 Jonas Schnelli: Merge bitcoin-core/gui#186: Add information to "Confirm fee bump" window
< bitcoin-git> bitcoin/master 232d1f9 Prayank: Add information to "Confirm fee bump" window
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32d44d2b1ca3...d38e2d9a19c9
< wumpus> this channel is for development, it is not a general bitcoin related social channel
< wumpus> #bitcoin please
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsanitize=integer (master...fsanitize-integer) https://github.com/bitcoin/bitcoin/pull/21000
< bitcoin-git> bitcoin/master 32d44d2 MarcoFalke: Merge #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not wa...
< bitcoin-git> bitcoin/master f0f8b1a practicalswift: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsan...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ce75fc36edc8...32d44d2b1ca3
< bitcoin-git> bitcoin/master 58232e3 practicalswift: fuzz: Avoid -fsanitize=integer warnings in fuzzing harnesses
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20971: test: Work around libFuzzer deadlock (master...2101-fuzzDeadlock) https://github.com/bitcoin/bitcoin/pull/20971
< bitcoin-git> bitcoin/master ce75fc3 MarcoFalke: Merge #20971: test: Work around libFuzzer deadlock
< bitcoin-git> bitcoin/master fa39c8a MarcoFalke: test: Work around libFuzzer deadlock
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cbe439629e2b...ce75fc36edc8
< bitcoin-git> bitcoin/master cbe4396 MarcoFalke: Merge bitcoin-core/gui#167: raise helpMessageDialog
< bitcoin-git> bitcoin/master 7711446 randymcmillan: raise helpMessageDialog
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/280d0bd0bd19...cbe439629e2b
< bitcoin-git> [gui] MarcoFalke merged pull request #167: raise helpMessageDialog (master...help-message-raise) https://github.com/bitcoin-core/gui/pull/167
< sipa> i'm happy to answer on bitcoin se
< sipa> viraltaco_: that"s off topic her; try #bitcoin, or https://bitcoin.stackexchange.com
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21010: refactor: remove straggling boost::mutex usage (master...why_new_boost_depend) https://github.com/bitcoin/bitcoin/pull/21010
< bitcoin-git> bitcoin/master 280d0bd MarcoFalke: Merge #21010: refactor: remove straggling boost::mutex usage
< bitcoin-git> bitcoin/master f827e15 fanquake: refactor: remove straggling boost::mutex usage
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/16ae3368f2a2...280d0bd0bd19
< bitcoin-git> [bitcoin] fanquake opened pull request #21010: refactor: remove straggling boost::mutex usage (master...why_new_boost_depend) https://github.com/bitcoin/bitcoin/pull/21010
< gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19337 | sync: detect double lock from the same thread by vasild · Pull Request #19337 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21007 | bitcoind: Add -daemonwait option to wait for initialization by laanwj · Pull Request #21007 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dhruv opened pull request #21009: Remove RewindBlockIndex logic (master...rewindblockindex-2021) https://github.com/bitcoin/bitcoin/pull/21009
< bitcoin-git> [bitcoin] theStack opened pull request #21008: test: fix zmq test flakiness, improve speed (master...2021-test-zmq-fix_flakiness) https://github.com/bitcoin/bitcoin/pull/21008
< bitcoin-git> [bitcoin] meshcollider merged pull request #17350: doc: Add developer documentation to isminetype (master...doc_isminetype) https://github.com/bitcoin/bitcoin/pull/17350
< bitcoin-git> bitcoin/master 16ae336 Samuel Dobson: Merge #17350: doc: Add developer documentation to isminetype
< bitcoin-git> bitcoin/master 40f0564 HAOYUatHZ: doc: Add developer documentation to isminetype
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4b15ffe9913e...16ae3368f2a2
< bitcoin-git> [bitcoin] meshcollider merged pull request #20832: rpc: Better error messages for invalid addresses (master...master) https://github.com/bitcoin/bitcoin/pull/20832
< bitcoin-git> bitcoin/master 4b15ffe Samuel Dobson: Merge #20832: rpc: Better error messages for invalid addresses
< bitcoin-git> bitcoin/master 8f0b64f Bezdrighin: Better error messages for invalid addresses
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52d84a45e2fa...4b15ffe9913e

2021-01-25

< bitcoin-git> [bitcoin] achow101 closed pull request #16463: [BIP 174] Implement serialization support for GLOBAL_XPUB field. (master...bip174-xpub) https://github.com/bitcoin/bitcoin/pull/16463
< bitcoin-git> [bitcoin] laanwj opened pull request #21007: bitcoind: Add -daemonwait option to wait for initialization (master...2021-01-daemonwait) https://github.com/bitcoin/bitcoin/pull/21007
< bitcoin-git> [bitcoin] laanwj merged pull request #20987: doc: add instructions for generating RPC docs (master...rpc-docs-gen-rp) https://github.com/bitcoin/bitcoin/pull/20987
< bitcoin-git> bitcoin/master e147af7 benk10: doc: add instructions for generating RPC docs
< bitcoin-git> bitcoin/master 52d84a4 Wladimir J. van der Laan: Merge #20987: doc: add instructions for generating RPC docs
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b386d3736074...52d84a45e2fa
< bitcoin-git> [bitcoin] laanwj merged pull request #18710: Add local thread pool to CCheckQueue (master...200419-thread-pool) https://github.com/bitcoin/bitcoin/pull/18710
< bitcoin-git> bitcoin/master 0ef9386 Hennadii Stepanov: refactor: Use member initializers in CCheckQueue
< bitcoin-git> bitcoin/master 0151177 Hennadii Stepanov: Add local thread pool to CCheckQueue
< bitcoin-git> bitcoin/master dba3069 Hennadii Stepanov: test: Use CCheckQueue local thread pool
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d0852f39a7a3...b386d3736074
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #21003: test: Move MakeNoLogFileContext to libtest_util, and use it in bench (master...2101-benchNoLog) https://github.com/bitcoin/bitcoin/pull/21003
< bitcoin-git> [bitcoin] martinus opened pull request #21006: rpc: reduce LOCK(cs_min) scope in rest_block: ~5 times as many requests per second (master...2021-01-reduce-cs_main-lock-in-rest_block) https://github.com/bitcoin/bitcoin/pull/21006
< bitcoin-git> [bitcoin] setpill opened pull request #21004: Fix docker args conditional (master...improve-gitian-build-py) https://github.com/bitcoin/bitcoin/pull/21004
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21003: test: Move MakeNoLogFileContext to libtest_util, and use it in bench (master...2101-benchNoLog) https://github.com/bitcoin/bitcoin/pull/21003
< setpill> Apologies if this is not the right place to ask, but has any research been done into gitian building of bitcoin core in docker rather than a VM?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21003: test: Move MakeNoLogFileContext to common libtest_util, and use it in bench (master...2101-benchNoLog) https://github.com/bitcoin/bitcoin/pull/21003
< bitcoin-git> [bitcoin] 4D617278 opened pull request #21002: script: improve scripted-diff check (master...commit-script-check) https://github.com/bitcoin/bitcoin/pull/21002
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20998: test: Fix BlockToJsonVerbose benchmark (master...2021-01-fix-BlockToJsonVerbose-single-benchmark-run) https://github.com/bitcoin/bitcoin/pull/20998
< bitcoin-git> bitcoin/master d0852f3 MarcoFalke: Merge #20998: test: Fix BlockToJsonVerbose benchmark
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f707fcde9a70...d0852f39a7a3
< bitcoin-git> bitcoin/master 7487bc9 Martin Ankerl: Fix BlockToJsonVerbose benchmark
< bitcoin-git> [bitcoin] martinus closed pull request #20999: rpc: faster JSON generation (master...2021-01-optimize-json-generation) https://github.com/bitcoin/bitcoin/pull/20999

2021-01-24

< bitcoin-git> [bitcoin] laanwj merged pull request #20958: gitian-keys: Add signer aliases, some historical keys (master...2021-01-gitian-sigs) https://github.com/bitcoin/bitcoin/pull/20958
< bitcoin-git> bitcoin/master f707fcd Wladimir J. van der Laan: Merge #20958: gitian-keys: Add signer aliases, some historical keys
< bitcoin-git> bitcoin/master 2b4cfb4 Wladimir J. van der Laan: gitian-keys: Add signer aliases, some historical keys
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e31af1065e8a...f707fcde9a70
< bitcoin-git> [bitcoin] practicalswift opened pull request #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsanitize=integer (master...fsanitize-integer) https://github.com/bitcoin/bitcoin/pull/21000
< bitcoin-git> [bitcoin] martinus opened pull request #20999: rpc: faster JSON generation (master...2021-01-optimize-json-generation) https://github.com/bitcoin/bitcoin/pull/20999
< bitcoin-git> [bitcoin] laanwj merged pull request #20989: gitian-keys: add CoinForensics key (master...master) https://github.com/bitcoin/bitcoin/pull/20989
< bitcoin-git> bitcoin/master 94271d2 coinforensics: gitian-keys: add CoinForensics key
< bitcoin-git> bitcoin/master e31af10 Wladimir J. van der Laan: Merge #20989: gitian-keys: add CoinForensics key
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32b191fb66e6...e31af1065e8a
< gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
< aj> MarcoFalke: #bitcoin-signet ; faucet was fixed overnight, blocks should be 10m on average but are poisson'ed so will have long delays now and then (capped at 1h though)
< bitcoin-git> [bitcoin] martinus opened pull request #20998: Fix BlockToJsonVerbose benchmark (master...2021-01-fix-BlockToJsonVerbose-single-benchmark-run) https://github.com/bitcoin/bitcoin/pull/20998
< bitcoin-git> [bitcoin] fanquake closed pull request #20994: doc: remove trailing whitespace from the release notes (master...trailing-whitespace) https://github.com/bitcoin/bitcoin/pull/20994

2021-01-23

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION (master...2101-fuzzVersion0) https://github.com/bitcoin/bitcoin/pull/20995
< bitcoin-git> [bitcoin] prusnak opened pull request #20994: doc: remove trailing whitespace from the release notes (master...trailing-whitespace) https://github.com/bitcoin/bitcoin/pull/20994
< bitcoin-git> [bitcoin] theStack opened pull request #20993: test: store subversion (user agent) as string in msg_version (master...2021-01-test-store_user_agent_as_string) https://github.com/bitcoin/bitcoin/pull/20993
< nanotube> wumpus: heya, just wanted to send you a general expression of support. i think you acted prudently wrt the recent csw saga. you do great work for bitcoin. hope the bs you get from internet randos doesn't get to you. :)
< bitcoin-git> [gui] RandyMcMillan closed pull request #140: about:version:help clean up add Bitcoin branding (master...about) https://github.com/bitcoin-core/gui/pull/140
< bitcoin-git> [gui] RandyMcMillan closed pull request #133: Qt Creator specific .gitignore files (master...gitignore) https://github.com/bitcoin-core/gui/pull/133
< bitcoin-git> [gui] RandyMcMillan closed pull request #146: qt: Reduce overlay animation to 250ms (master...modal) https://github.com/bitcoin-core/gui/pull/146
< bitcoin-git> [gui] RandyMcMillan closed pull request #90: Enlarge Network Traffic Graph (master...debugwindow-ui) https://github.com/bitcoin-core/gui/pull/90
< bitcoin-git> [gui] RandyMcMillan closed pull request #135: peers-tab: cleaner presentation - more functionality (master...peers-tab) https://github.com/bitcoin-core/gui/pull/135

2021-01-22

< bitcoin-git> [bitcoin] dongcarl closed pull request #17944: netaddress: Simplify reachability logic (master...2020-01-simplify-reachability) https://github.com/bitcoin/bitcoin/pull/17944
< jonatack> maybe ban khokho1 if they continue adding comments with btc addresses like the 3 in https://github.com/bitcoin/bitcoin/commit/1e72b68ab330c72644981508c8a1b3fa670d086f#commitcomment-46251271
< bitcoin-git> [bitcoin] coinforensics opened pull request #20989: gitian-keys: add CoinForensics key (master...master) https://github.com/bitcoin/bitcoin/pull/20989
< bitcoin-git> [gui] MarcoFalke reopened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke closed pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke closed pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke reopened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke closed pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< gribble> https://github.com/bitcoin/bitcoin/issues/20788 | net: add RAII socket and use it instead of bare SOCKET by vasild · Pull Request #20788 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20685 | Add I2P support using I2P SAM by vasild · Pull Request #20685 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19203 | net: Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket. Add thin SOCKET wrapper. by practicalswift · Pull Request #19203 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20788 | net: add RAII socket and use it instead of bare SOCKET by vasild · Pull Request #20788 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19203 | net: Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket. Add thin SOCKET wrapper. by practicalswift · Pull Request #19203 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20788 | net: add RAII socket and use it instead of bare SOCKET by vasild · Pull Request #20788 · bitcoin/bitcoin · GitHub
< vasild> In "High-priority for review" PRs (https://github.com/bitcoin/bitcoin/projects/8) #19203 is listed, but #20788 is not. I think that #20788 would help both #19203 and #20685 - the same (or very similar) Sock class is defined in all 3 PRs. So maybe add #20788 to hi-prio for review?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20927: [refactor] [net] Clean up InactivityCheck() (master...2021-01-timeout-cleanup) https://github.com/bitcoin/bitcoin/pull/20927
< bitcoin-git> bitcoin/master 32b191f MarcoFalke: Merge #20927: [refactor] [net] Clean up InactivityCheck()
< bitcoin-git> bitcoin/master bf100f8 John Newbery: [net] Cleanup InactivityChecks() and add commenting about time
< bitcoin-git> bitcoin/master 06fa85c John Newbery: [net] InactivityCheck() takes a CNode reference
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b7e12b350d32...32b191fb66e6
< bitcoin-git> [bitcoin] ben-kaufman opened pull request #20987: doc: add instructions for generating RPC docs (master...rpc-docs-gen-rp) https://github.com/bitcoin/bitcoin/pull/20987
< bitcoin-git> [gui] MarcoFalke reopened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke closed pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [bitcoin] fanquake merged pull request #20985: doc: add xorriso to macOS depends packages (master...xorriso_depends_doc) https://github.com/bitcoin/bitcoin/pull/20985
< bitcoin-git> bitcoin/master 5b41d84 fanquake: doc: add xorriso to macOS depends packages
< bitcoin-git> bitcoin/master b7e12b3 fanquake: Merge #20985: doc: add xorriso to macOS depends packages
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bd586607d63...b7e12b350d32
< bitcoin-git> [bitcoin] jnewbery opened pull request #20986: [RFC] docs: update developer notes to discourage very long lines (master...2021-01-no-long-lines) https://github.com/bitcoin/bitcoin/pull/20986
< bitcoin-git> [gui] MarcoFalke reopened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke closed pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke reopened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [gui] MarcoFalke closed pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< bitcoin-git> [bitcoin] fanquake opened pull request #20985: doc: add xorriso to macOS depends packages (master...xorriso_depends_doc) https://github.com/bitcoin/bitcoin/pull/20985
< bitcoin-git> [gui] MarcoFalke opened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196
< gribble> https://github.com/bitcoin/bitcoin/issues/20970 | Fix a bug that personal signet can not be created. by fujicoin · Pull Request #20970 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #20523: zmq: deduplicate 'sequence' publisher message creation/sending (master...20201128-zmq-refactor-dedup_sequence_msg_sending) https://github.com/bitcoin/bitcoin/pull/20523
< bitcoin-git> bitcoin/master 9624442 Sebastian Falbesoner: zmq: deduplicate 'sequence' publisher message creation/sending
< bitcoin-git> bitcoin/master 4bd5866 fanquake: Merge #20523: zmq: deduplicate 'sequence' publisher message creation/sendi...
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/019aa248d931...4bd586607d63
< bitcoin-git> [bitcoin] fanquake merged pull request #17920: guix: Build support for macOS (master...2020-01-guix-macos) https://github.com/bitcoin/bitcoin/pull/17920
< bitcoin-git> bitcoin/master f3835dc Carl Dong: build: Make xorrisofs reproducible with -volume_date
< bitcoin-git> bitcoin/master 37fe73a Carl Dong: build: Add var printing target to src/Makefile.am
< bitcoin-git> bitcoin/master c9eb4cf Carl Dong: guix: Add support for darwin builds
< bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/d6c3c43ef8d9...019aa248d931
< bitcoin-git> [bitcoin] fanquake merged pull request #20983: Fix MSVC build after gui#176 (master...210121-appveyor) https://github.com/bitcoin/bitcoin/pull/20983
< bitcoin-git> bitcoin/master d6c3c43 fanquake: Merge #20983: Fix MSVC build after gui#176
< bitcoin-git> bitcoin/master c5354e4 Hennadii Stepanov: Fix MSVC build after gui#176
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f653c3b22f0...d6c3c43ef8d9

2021-01-21

< Emcy> wumpus hey you dont know me because im just a random bitcoiner, but i know youre getting a lot of heat because of events that happened today and how you reacted. I want to say that i personally appreciate the work you do and have done for bitcoin very much, and i know many others do too, even if most of the time no one says it. So im saying it now.
< bitcoin-git> [bitcoin] hebasto opened pull request #20983: Fix MSVC build after gui#176 (master...210121-appveyor) https://github.com/bitcoin/bitcoin/pull/20983
< bitcoin-git> [gui] MarcoFalke reopened pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177
< bitcoin-git> [gui] MarcoFalke closed pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< sipa> this isn't just a bitcoin core thing
< nickler> perhaps also good to add link to bitcoin wiki page and aj's post
< gribble> https://github.com/bitcoin/bitcoin/issues/19573 | Replace unused BIP 9 logic with draft BIP 8 by luke-jr · Pull Request #19573 · bitcoin/bitcoin · GitHub
< wumpus> yes, that's fine, I don't think it has to be one or the other, though I would prefer not to add and maintain a complete tracing infrastructure inside bitcoin core when there are existing solutions, but if it has a clear scope, sure
< bitcoin-git> [bitcoin] dongcarl opened pull request #20980: guix: Test security-check sanity before performing them (master...2020-12-guix-mingw-extra-flags) https://github.com/bitcoin/bitcoin/pull/20980
< gribble> https://github.com/bitcoin/bitcoin/issues/20960 | doc: Add tracing.md, documenting eBPF tracing by laanwj · Pull Request #20960 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19866 | eBPF Linux tracepoints by jb55 · Pull Request #19866 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20960 | doc: Add tracing.md, documenting eBPF tracing by laanwj · Pull Request #20960 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19866 | eBPF Linux tracepoints by jb55 · Pull Request #19866 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 1 bugfix, 2 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu Jan 21 19:00:38 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< luke-jr> TallTim: I would like to discuss it with you, but in #Bitcoin
< luke-jr> TallTim: again, #Bitcoin. It is off-topic here (this is about development of Bitcoin Core, not about developers of Bitcoin Core)
< luke-jr> TallTim: #Bitcoin (also the first part is a lie, and CSW had nothing to do with it)
< jnewbery> I think the best place for documentation of our high-level conceptual approach to these things is probably https://github.com/bitcoin-core/bitcoin-devwiki/wiki
< sipa> if there really is a discrepancy between bip125 and what bitcoin core implements, it could be mentioned in doc/bips.md
< TallTim> On topic, it involves Bitcoin Core website operations and the devs that are spineless.
< TallTim> "The Bitcoin Core website was modified to remove references to the whitepaper, their local copy of the whitepaper PDF was deleted, and with less than 2 hours of public review this change was merged."
< bitcoin-git> [gui] MarcoFalke merged pull request #176: Fix TxViewDelegate layout (master...210103-delegate) https://github.com/bitcoin-core/gui/pull/176
< bitcoin-git> bitcoin/master af58f5b Hennadii Stepanov: qt: Stop the effect of hidden widgets on the size of QStackedWidget
< bitcoin-git> bitcoin/master f0d0479 Hennadii Stepanov: qt: Fix TxViewDelegate layout
< bitcoin-git> bitcoin/master d439921 Hennadii Stepanov: qt: Add TransactionOverviewWidget class
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/53bbbe5a204c...7f653c3b22f0
< bitcoin-git> [gui] MarcoFalke merged pull request #171: Use layout manager for Create Wallet dialog (master...210101-wallet) https://github.com/bitcoin-core/gui/pull/171
< bitcoin-git> bitcoin/master 53bbbe5 MarcoFalke: Merge bitcoin-core/gui#171: Use layout manager for Create Wallet dialog
< bitcoin-git> bitcoin/master d4feb68 Hennadii Stepanov: qt: Use layout manager for Create Wallet dialog
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45952dab9d2f...53bbbe5a204c
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls (master...feature/fs-AbsPathJoin) https://github.com/bitcoin/bitcoin/pull/20932
< bitcoin-git> bitcoin/master 45952da MarcoFalke: Merge #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls
< bitcoin-git> bitcoin/master da9caa1 Kiminuo: Replace fs::absolute calls with AbsPathJoin calls
< bitcoin-git> bitcoin/master 66576c4 Kiminuo: test: Clear forced -walletdir setting after wallet init_tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/11cbd4bb54af...45952dab9d2f
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17556: test: Change feature_config_args.py not to rely on strange regtest=0 behavior (master...pr/wdpy) https://github.com/bitcoin/bitcoin/pull/17556
< bitcoin-git> bitcoin/master 11cbd4b MarcoFalke: Merge #17556: test: Change feature_config_args.py not to rely on strange r...
< bitcoin-git> bitcoin/master ff44cae Russell Yanofsky: test: Change feature_config_args.py not to rely on strange regtest=0 behav...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f45e8550953...11cbd4bb54af
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20972: locks: Annotate CTxMemPool::check to require cs_main (master...2021-01-CTxMemPool-spendheight-lock-inversion) https://github.com/bitcoin/bitcoin/pull/20972
< bitcoin-git> bitcoin/master 1f45e85 MarcoFalke: Merge #20972: locks: Annotate CTxMemPool::check to require cs_main
< bitcoin-git> bitcoin/master b396467 Carl Dong: locks: Annotate CTxMemPool::check to require cs_main
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85fee49c39cc...1f45e8550953
< elichai2> achow101: I posted the survey on multiple Israeli bitcoin forums/groups, I hope they'll answer it (I feel like the Israeli community uses the gui a lot more than the international one)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20946: fuzz: Consolidate fuzzing TestingSetup initialization (master...2021-01-make-fuzzing-ctx) https://github.com/bitcoin/bitcoin/pull/20946
< bitcoin-git> bitcoin/master 85fee49 MarcoFalke: Merge #20946: fuzz: Consolidate fuzzing TestingSetup initialization
< bitcoin-git> bitcoin/master abb6fa7 Carl Dong: fuzz: Initialize a full TestingSetup where appropriate
< bitcoin-git> bitcoin/master 713314a Carl Dong: fuzz: Consolidate fuzzing TestingSetup initialization
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3734adba390c...85fee49c39cc
< bitcoin-git> [gui] hebasto opened pull request #194: Save/restore RPCConsole geometry only for window (master...210121-window) https://github.com/bitcoin-core/gui/pull/194
< bitcoin-git> [bitcoin] ben-kaufman opened pull request #20976: doc: fix broken link to whitepaper in README (master...fix-wp-link) https://github.com/bitcoin/bitcoin/pull/20976
< bitcoin-git> [bitcoin] fanquake reopened pull request #20523: zmq: deduplicate 'sequence' publisher message creation/sending (master...20201128-zmq-refactor-dedup_sequence_msg_sending) https://github.com/bitcoin/bitcoin/pull/20523
< bitcoin-git> [bitcoin] fanquake merged pull request #20953: test: dedup zmq test setup code (node restart, topics subscription) (master...2021-zmq_dedup_test_setup_code) https://github.com/bitcoin/bitcoin/pull/20953
< bitcoin-git> bitcoin/master 3734adb fanquake: Merge #20953: test: dedup zmq test setup code (node restart, topics subscr...
< bitcoin-git> bitcoin/master 4efb6c2 Sebastian Falbesoner: zmq test: deduplicate test setup code (node restart, topics subscription)
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80486e7e2d8c...3734adba390c
< bitcoin-git> [bitcoin] ryanofsky opened pull request #20974: test: add test for corrupt wallet bdb logs (master...pr/badbdb) https://github.com/bitcoin/bitcoin/pull/20974

2021-01-20

< bitcoin-git> [gui] RandyMcMillan closed pull request #192: fix for #191 (master...191) https://github.com/bitcoin-core/gui/pull/192
< luke-jr> viraltaco_: #bitcoin
< bitcoin-git> [bitcoin] dongcarl opened pull request #20972: locks: Annotate CTxMemPool::check to require cs_main (master...2021-01-CTxMemPool-spendheight-lock-inversion) https://github.com/bitcoin/bitcoin/pull/20972
< gribble> https://github.com/bitcoin/bitcoin/issues/186 | Remove unnecessary line which creates a dependency on wxs png library. by TheBlueMatt · Pull Request #186 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] RandyMcMillan opened pull request #192: fix for #191 (master...191) https://github.com/bitcoin-core/gui/pull/192
< Talkless> just wantend to "share", now if someone posts github issue agaist Bitcoin, you will know what's up.
< luke-jr> still not really a Bitcoin dev issue IMO
< gribble> https://github.com/bitcoin/bitcoin/issues/20951 | doc: APS explanation clarified in 0.21.0 release notes by dscotese · Pull Request #20951 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20971: test: Work around libFuzzer deadlock (master...2101-fuzzDeadlock) https://github.com/bitcoin/bitcoin/pull/20971
< vasild> jonatack: you can run bitcoin-cli getpeerinfo |jq 'map(select(.network == "i2p")) |map({inbound: .inbound, addr: .addr, addrbind: .addrbind, addrlocal: .addrlocal, network: .network, subver: .subver})'
< gribble> https://github.com/bitcoin/bitcoin/issues/20764 | cli -netinfo peer connections dashboard updates 🎄 ✨ by jonatack · Pull Request #20764 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub