<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #24821: refactor: remove preset coins in linear time with remove-erase idiom (master...remove-preselect-remove-erase) https://github.com/bitcoin/bitcoin/pull/24821
<sipa>
Hi, I'm trying to gather some statistics on typical average message sizes in the P2P protocol for Bitcoin Core nodes. I have a commit on https://github.com/sipa/bitcoin/commit/6a692f0835e7f1b054b2b82893aa78f77344e89b that adds such statistics to the getnettotals RPC. I'd very much appreciate it if people could run it for a few days and report back.
<bitcoin-git>
[bitcoin] rag-hav opened pull request #24821: refactor: remove preset coins in linear time with remove-erase idiom (master...remove-preselect-remove-erase) https://github.com/bitcoin/bitcoin/pull/24821
<bitcoin-git>
[bitcoin] akankshakashyap opened pull request #24820: test: 3 new tests for SelectCoins function (master...coin_selection_tc) https://github.com/bitcoin/bitcoin/pull/24820
<bitcoin-git>
[gui] hebasto opened pull request #581: refactor: Revamp `ClientModel` code to handle core signals (master...220410-invoke) https://github.com/bitcoin-core/gui/pull/581
<bitcoin-git>
[bitcoin] theStack opened pull request #24817: test: use MiniWallet for feature_fee_estimation.py (master...202204-test-use_MiniWallet_for_feature_fee_estimation) https://github.com/bitcoin/bitcoin/pull/24817
<bitcoin-git>
[gui] hebasto opened pull request #580: Getting ready to Qt 6 (3/n). Do not use `QKeyEvent` copy constructor (master...220409-event) https://github.com/bitcoin-core/gui/pull/580
2022-04-08
<bitcoin-git>
[gui] hebasto opened pull request #579: Getting ready to Qt 6 (2/n). Remove `QApplication::globalStrut()` (master...220409-strut) https://github.com/bitcoin-core/gui/pull/579
<bitcoin-git>
[bitcoin] aureleoules opened pull request #24812: util/check: Add CheckNonFatal identity function and use it in src/rpc (master...check_non_fatal_identity) https://github.com/bitcoin/bitcoin/pull/24812
<bitcoin-git>
[bitcoin] Empact opened pull request #24811: refactor: Prepare for moving ArgsManager out of util/system (master...2022-03-util-args-manager-prep) https://github.com/bitcoin/bitcoin/pull/24811
<bitcoin-git>
bitcoin/23.x e3e4be9 Luke Dashjr: RPC: Switch getblockfrompeer back to standard param name blockhash
<bitcoin-git>
[bitcoin] jonatack opened pull request #24808: doc: update RPC argument and field naming guideline in developer notes (master...update-developer-notes-rpc-argument-and-field-naming-guideline) https://github.com/bitcoin/bitcoin/pull/24808
<bitcoin-git>
[bitcoin] fanquake merged pull request #24806: RPC: Switch getblockfrompeer back to standard param name blockhash (master...use_bloch_hash) https://github.com/bitcoin/bitcoin/pull/24806
<bitcoin-git>
[bitcoin] fanquake opened pull request #24806: RPC: Switch getblockfrompeer back to standard param name blockhash (master...use_bloch_hash) https://github.com/bitcoin/bitcoin/pull/24806
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #24294: RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid (master...getblockfrompeer_param_names) https://github.com/bitcoin/bitcoin/pull/24294
<gribble>
https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/24770 | Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive by jonatack · Pull Request #24770 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #24697: refactor: Use type-safe time for address relay (master...2203-refactor-addr-relay-time-🌦) https://github.com/bitcoin/bitcoin/pull/24697
<laanwj>
as for VPSes and containers that don't allow setting the time, and have it drift, that's a really lousy VPS and it's probably a bad idea to run a bitcoin node on it, expecting user-space software to work around kernel level problems is pretty unreasonable
<laanwj>
_aj_: which is the place where this should be solved, by people who study it and are specialized in it, fixing internet time sync is out of scope for bitcoin
<sipa>
_aj_: That'd only tell us how many light clients are out of sync, which may be very different from how often bitcoin core nodes are.
<laanwj>
i mean if bitcoin's time adjustment was a serious contender for protecting against ntp attacks things would be different, but it is effectively unmaintained, never reasoned about code, with known unfixed issues for years
<sipa>
ntp being unauthenticated is a problem, probably a bigger one than the issues enabled by bitcoin's time adjustment... but nothing we can do about
<laanwj>
pretty sure there are many things more time sensitive than bitcoin, e.g. 2fa tokens
<fanquake>
they've probably got other non-bitcoin issues in that case too
<bitcoin-git>
[bitcoin] Eunoia1729 opened pull request #24802: lint: convert format strings linter test to python (master...lint-format-strings-py) https://github.com/bitcoin/bitcoin/pull/24802
<bitcoin-git>
[bitcoin] KevinMusgrave opened pull request #24800: lint: convert lint-python-mutable-default-parameters.sh to Python (master...port-lint-script-to-python) https://github.com/bitcoin/bitcoin/pull/24800
<bitcoin-git>
[bitcoin] jacobpfickes opened pull request #24793: test: changes color of skipped functional tests (master...change_skipped_test_color) https://github.com/bitcoin/bitcoin/pull/24793
<bitcoin-git>
[bitcoin] fanquake closed pull request #24341: build: remove some no-longer-needed var unexporting from configure (master...remove_redundant_un_export) https://github.com/bitcoin/bitcoin/pull/24341
<bitcoin-git>
[bitcoin] fanquake opened pull request #24792: Update libsecp256k1 subtree to current master (master...update_libsecp256k1) https://github.com/bitcoin/bitcoin/pull/24792
<bitcoin-git>
[bitcoin] fanquake opened pull request #24784: refactor: Remove deduplication of data in rollingbloom bench (master...rebased_fixedd_24088) https://github.com/bitcoin/bitcoin/pull/24784
<bitcoin-git>
[bitcoin] laanwj merged pull request #24552: guix: make it possible to override gpg binary (master...guix-attest-override-gpg) https://github.com/bitcoin/bitcoin/pull/24552
<bitcoin-git>
bitcoin/master af74e06 Pavol Rusnak: guix: make it possible to override gpg binary
<bitcoin-git>
bitcoin/master b307279 laanwj: Merge bitcoin/bitcoin#24552: guix: make it possible to override gpg binary...
<bitcoin-git>
[bitcoin] hebasto opened pull request #24781: build, qt: Drop unneeded direct dependency on freetype (master...220406-freetype) https://github.com/bitcoin/bitcoin/pull/24781
<bitcoin-git>
[bitcoin] fjahr opened pull request #24778: lint: Convert Python dead code linter test to Python (master...202204-dead-py) https://github.com/bitcoin/bitcoin/pull/24778
<bitcoin-git>
bitcoin/master 15220ec MarcoFalke: Merge bitcoin/bitcoin#24775: build: Do not modify `common.init.vcxproj` di...
<bitcoin-git>
bitcoin/master ba0bf79 Hennadii Stepanov: build: Do not modify `common.init.vcxproj` directly
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24776: docs: update `/rest/chaininfo` doc according to `getblockchaininfo` (master...2022-04-rest-doc-improv) https://github.com/bitcoin/bitcoin/pull/24776
<bitcoin-git>
[bitcoin] hebasto opened pull request #24775: build: Do not modify `common.init.vcxproj` directly (master...220405-toolset) https://github.com/bitcoin/bitcoin/pull/24775
<bitcoin-git>
[bitcoin] Crypt-iQ opened pull request #24763: configure.ac: disable FORTIFY_SOURCE for asan/msan/tsan (master...disable_fortify_san) https://github.com/bitcoin/bitcoin/pull/24763
<laanwj>
re: https://github.com/bitcoin-core/gui/issues/573 did anyone check recently on MacOS and Qt whether the whole custom notification code is still needed? would be cool if we could get rid of all the platform specific notificator code
<bitcoin-git>
[gui] laanwj opened pull request #574: qt: Equalize notifySystray and notifyDBus interface (master...2022-04-notification-icon) https://github.com/bitcoin-core/gui/pull/574