2020-05-29

< bitcoin-git> [bitcoin] fanquake merged pull request #16939: p2p: Delay querying DNS seeds (master...201909-avoid-dns-if-addrman-populated) https://github.com/bitcoin/bitcoin/pull/16939
< bitcoin-git> bitcoin/master 73407ff fanquake: Merge #16939: p2p: Delay querying DNS seeds
< bitcoin-git> bitcoin/master fa5894f Anthony Towns: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known
< bitcoin-git> bitcoin/master 96954d1 Anthony Towns: DNS seeds: don't query DNS while network is inactive
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d7f5e01e3093...73407ff65cef
< gribble> https://github.com/bitcoin/bitcoin/issues/19103 | QRCode address in image is not readable · Issue #19103 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13389 | Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen · Pull Request #13389 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17127 | util: Correct permissions for datadir and wallets subdir by hebasto · Pull Request #17127 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18424: qt: Use parent-child relation to manage lifetime of OptionsModel object (master...20200324-options-model) https://github.com/bitcoin/bitcoin/pull/18424
< bitcoin-git> bitcoin/master d7f5e01 Jonas Schnelli: Merge #18424: qt: Use parent-child relation to manage lifetime of OptionsM...
< bitcoin-git> bitcoin/master 8e08d00 Hennadii Stepanov: qt: Use parent-child relation to manage lifetime of OptionsModel object
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de369c7ea577...d7f5e01e3093
< bitcoin-git> [bitcoin] promag opened pull request #19104: gui, test: Fix Cannot queue arguments of type size_t (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18165: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function (master...svcflags2str) https://github.com/bitcoin/bitcoin/pull/18165
< bitcoin-git> bitcoin/master de369c7 Jonas Schnelli: Merge #18165: Consolidate service flag bit-to-name conversion to a shared ...
< bitcoin-git> bitcoin/master c31bc5b Luke Dashjr: Consolidate service flag bit-to-name conversion to a shared serviceFlagToS...
< bitcoin-git> bitcoin/master cea91a1 Luke Dashjr: Bugfix: GUI: Use unsigned long long type to avoid implicit conversion of M...
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b603cff63a...de369c7ea577
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #17993: gui: Balance/TxStatus polling update based on last block hash. (master...2020_avoid_unnecessary_lock_in_balance_polling) https://github.com/bitcoin/bitcoin/pull/17993
< bitcoin-git> bitcoin/master f4b603c Jonas Schnelli: Merge #17993: gui: Balance/TxStatus polling update based on last block has...
< bitcoin-git> bitcoin/master a06e845 furszy: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTi...
< bitcoin-git> bitcoin/master 2f86720 furszy: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/beb3844c45c5...f4b603cff63a
< gribble> https://github.com/bitcoin/bitcoin/issues/17355 | gui: grey out used address in address book by za-kk · Pull Request #17355 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #17968: qt: Ensure that ModalOverlay is resized properly (master...20200120-fix-modaloverlay) https://github.com/bitcoin/bitcoin/pull/17968
< bitcoin-git> bitcoin/master beb3844 Jonas Schnelli: Merge #17968: qt: Ensure that ModalOverlay is resized properly
< bitcoin-git> bitcoin/master 4fc1df4 Hennadii Stepanov: qt: Track QEvent::Resize during animation
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d5c18204b73...beb3844c45c5
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #17956: gui: Disable unavailable context menu items in transactions tab (master...tx-menu-disable) https://github.com/bitcoin/bitcoin/pull/17956
< bitcoin-git> bitcoin/master 0d5c182 Jonas Schnelli: Merge #17956: gui: Disable unavailable context menu items in transactions ...
< bitcoin-git> bitcoin/master 2b18fd2 Kristaps Kaupe: Disable unavailable context menu items in transactions tab
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9024a42fcec...0d5c18204b73
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #17918: qt: Hide non PKHash-Addresses in signing address book (master...2020-01-hide-non-pkhash-addresses) https://github.com/bitcoin/bitcoin/pull/17918
< bitcoin-git> bitcoin/master c4ea501 Emil Engler: qt: Hide non PKHash-Addresses in signing address book
< bitcoin-git> bitcoin/master a9024a4 Jonas Schnelli: Merge #17918: qt: Hide non PKHash-Addresses in signing address book
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2c15ea54eb1...a9024a42fcec
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908
< bitcoin-git> bitcoin/master c2c15ea Jonas Schnelli: Merge #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal
< bitcoin-git> bitcoin/master 1122817 Hennadii Stepanov: qt: Remove QFont warnings with QPA=minimal
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/343169998193...c2c15ea54eb1
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
< bitcoin-git> bitcoin/master 73529f0 Hennadii Stepanov: qt: Rename slot to updateDisplayUnit()
< bitcoin-git> bitcoin/master 3431699 Jonas Schnelli: Merge #17597: qt: Fix height of QR-less ReceiveRequestDialog
< bitcoin-git> bitcoin/master 68288ef Hennadii Stepanov: qt: Overhaul ReceiveRequestDialog
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5f75c5e7df14...343169998193
< gribble> https://github.com/bitcoin/bitcoin/issues/17227 | Qt: Add Android packaging support by icota · Pull Request #17227 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #16876: gui: Drop calls to QCoreApplication::processEvents (master...2019-09-drop-processevents) https://github.com/bitcoin/bitcoin/pull/16876
< gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] rajarshimaitra reopened pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
< bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
< gribble> https://github.com/bitcoin/bitcoin/issues/15202 | gui: Add Close All Wallets action by promag · Pull Request #15202 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #12833: [qt] move QSettings to bitcoin_rw.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #16432: qt: Add privacy to the Overview page (master...20190721-privacy) https://github.com/bitcoin/bitcoin/pull/16432
< bitcoin-git> bitcoin/master 5f75c5e Jonas Schnelli: Merge #16432: qt: Add privacy to the Overview page
< bitcoin-git> bitcoin/master 73d8ef7 Hennadii Stepanov: qt: Add BitcoinUnits::formatWithPrivacy() function
< bitcoin-git> bitcoin/master 8d75115 Hennadii Stepanov: qt: Add privacy feature to Overview page
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/adc143fc2b9a...5f75c5e7df14
< gribble> https://github.com/bitcoin/bitcoin/issues/19097 | qt: Add missing QPainterPath include by achow101 · Pull Request #19097 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #19097: qt: Add missing QPainterPath include (master...qpainterpath-include) https://github.com/bitcoin/bitcoin/pull/19097
< bitcoin-git> bitcoin/master adc143f fanquake: Merge #19097: qt: Add missing QPainterPath include
< bitcoin-git> bitcoin/master 79b0a69 Andrew Chow: Add missing QPainterPath include
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fc1fb4dd7c05...adc143fc2b9a
< bitcoin-git> bitcoin/master fc1fb4d fanquake: Merge #19094: build: Only allow ASCII identifiers
< bitcoin-git> [bitcoin] fanquake merged pull request #19094: build: Only allow ASCII identifiers (master...2020_05_no_extended_identifiers) https://github.com/bitcoin/bitcoin/pull/19094
< bitcoin-git> bitcoin/master 399d84d Wladimir J. van der Laan: build: Only allow ASCII identifiers
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea3e9e0b84c5...fc1fb4dd7c05

2020-05-28

< gribble> https://github.com/bitcoin/bitcoin/issues/18921 | build: add stack-clash and control-flow protection options to hardening flags by fanquake · Pull Request #18921 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] achow101 opened pull request #19102: wallet: Introduce and use DummyDatabase instead of dummy BerkeleyDatabase (master...true-dummydb) https://github.com/bitcoin/bitcoin/pull/19102
< bitcoin-git> [bitcoin] ryanofsky opened pull request #19101: refactor: remove ::vpwallets and related global variables (master...pr/novp) https://github.com/bitcoin/bitcoin/pull/19101
< bitcoin-git> [bitcoin] ryanofsky opened pull request #19099: refactor: Move wallet methods out of chain.h and node.h (master...pr/wclient) https://github.com/bitcoin/bitcoin/pull/19099
< wumpus> in any case the only reason this is controversial at all is because bitcoin's P2P is semi-stateless so losing a packet is not necessarily fatal, in a stateful protocol the only sensible thing is to disconnect
< bitcoin-git> [bitcoin] ryanofsky opened pull request #19098: test: Remove duplicate NodeContext hacks (master...pr/qtx) https://github.com/bitcoin/bitcoin/pull/19098
< wumpus> especially as bitcoin's P2P protocol is more or less stateless and can handle lost messages
< wumpus> in the case of something like SSH that's annoying because yo ureally want to remain connected to that one host, for bitcoin P2P though ,they'll just connect to a different node
< gribble> https://github.com/bitcoin/bitcoin/issues/18971 | wallet: Refactor the classes in wallet/db.{cpp/h} by achow101 · Pull Request #18971 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15197 | Refactor and slightly stricter p2p message processing by jonasschnelli · Pull Request #15197 · bitcoin/bitcoin · GitHub
< jnewbery> wumpus: I think https://github.com/troygiorshev/bitcoin/tree/p2p-refactor-header is possibly a cleaner implementation
< gribble> https://github.com/bitcoin/bitcoin/issues/15206 | Immediately disconnect on invalid net message checksum by jonasschnelli · Pull Request #15206 · bitcoin/bitcoin · GitHub
< jnewbery> jonasschnelli: do you mind taking a look at https://github.com/bitcoin/bitcoin/pull/15206#issuecomment-634707439? I like the approach there that moves the header checking to net.cpp and doesn't change behaviour
< * sipa> idly wonders if bitcoin 0.4.0 would compile against wxwidget 3.0 (as the 2.9 that was used at the time was never released...)
< gribble> https://github.com/bitcoin/bitcoin/issues/18027 | "PSBT Operations" dialog by gwillen · Pull Request #18027 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17145 | GUI event loop should be block free · Issue #17145 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16432 | qt: Add privacy to the Overview page by hebasto · Pull Request #16432 · bitcoin/bitcoin · GitHub
< jamesob> what is the anticipated burden of rerouting people filing issues/PRs in bitcoin/bitcoin to bitcoin/bitcoin-gui when appropriate?
< harding> I think it's important for Bitcoin Core to continue to ship releases with a default GUI, which this allows, and making it easier for people to follow just GUI issues sounds very nice to me, so +1
< jamesob> wumpus: do you really think it actually turns away people, just that GUI is under bitcoin/bitcoin?
< gribble> https://github.com/bitcoin/bitcoin/issues/19071 | [WIP RFC DONOTMERGE] meta: Separate repository for the gui by MarcoFalke · Pull Request #19071 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18637 | coins: allow cache resize after init by jamesob · Pull Request #18637 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18971 | wallet: Refactor the classes in wallet/db.{cpp/h} by achow101 · Pull Request #18971 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18468 | Span improvements by sipa · Pull Request #18468 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18000 | [WIP] Index for UTXO Set Statistics by fjahr · Pull Request #18000 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Calculate UTXO set hash using Muhash by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18971 | wallet: Refactor the classes in wallet/db.{cpp/h} by achow101 · Pull Request #18971 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18968 | doc: noban precludes maxuploadtarget disconnects by MarcoFalke · Pull Request #18968 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18000 | [WIP] Index for UTXO Set Statistics by fjahr · Pull Request #18000 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 currently 5 blockers, 1 bugfix, 4 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] achow101 opened pull request #19097: qt: Add missing QPainterPath include (master...qpainterpath-include) https://github.com/bitcoin/bitcoin/pull/19097
< bitcoin-git> [bitcoin] ryanofsky opened pull request #19096: Remove g_rpc_chain global (master...pr/wc) https://github.com/bitcoin/bitcoin/pull/19096
< bitcoin-git> [bitcoin] jnewbery opened pull request #19095: [tools] Update clang-format config for multi-line function declarations and calls (master...2020-05-clang-tidy) https://github.com/bitcoin/bitcoin/pull/19095
< bitcoin-git> [bitcoin] laanwj opened pull request #19094: build: Only allow ASCII identifiers (master...2020_05_no_extended_identifiers) https://github.com/bitcoin/bitcoin/pull/19094
< bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
< bitcoin-git> [bitcoin] jonatack opened pull request #19092: cli: display multiwallet total balance in -getinfo (master...cli-getinfo-multiwallet-total-balance) https://github.com/bitcoin/bitcoin/pull/19092
< bitcoin-git> [bitcoin] laanwj merged pull request #18700: Fix locking on WSL using flock instead of fcntl (master...202004_file_lock_windows) https://github.com/bitcoin/bitcoin/pull/18700
< bitcoin-git> bitcoin/master e8fa0a3 Samuel Dobson: Fix WSL file locking by using flock instead of fcntl
< bitcoin-git> bitcoin/master ea3e9e0 Wladimir J. van der Laan: Merge #18700: Fix locking on WSL using flock instead of fcntl
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/082a417abcce...ea3e9e0b84c5
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18635: Replace -Wthread-safety-analysis with broader -Wthread-safety (master...200414-threads) https://github.com/bitcoin/bitcoin/pull/18635
< bitcoin-git> bitcoin/master 971a468 Hennadii Stepanov: Use template function instead of void* parameter
< bitcoin-git> bitcoin/master dfb75ae Hennadii Stepanov: refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
< bitcoin-git> bitcoin/master 79be487 Hennadii Stepanov: Add thread safety annotated wrapper for std::mutex
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/55b4c65bd1d8...082a417abcce
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19090: refactor: Misc scheduler cleanups (master...2005-schedulerCleanup) https://github.com/bitcoin/bitcoin/pull/19090
< bitcoin-git> [bitcoin] jonatack opened pull request #19089: cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups (master...cli-getinfo-multiwallet-follow-ups) https://github.com/bitcoin/bitcoin/pull/19089
< gribble> https://github.com/bitcoin/bitcoin/issues/19064 | refactor: Cleanup thread ctor calls by hebasto · Pull Request #19064 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #19088: validation: use std::chrono throughout some validation functions (master...validation_chrono) https://github.com/bitcoin/bitcoin/pull/19088
< bitcoin-git> [bitcoin] fanquake closed pull request #19086: fixed typo - polish translation (master...master) https://github.com/bitcoin/bitcoin/pull/19086
< bitcoin-git> [bitcoin] lareq opened pull request #19086: fixed typo - polish translation (master...master) https://github.com/bitcoin/bitcoin/pull/19086
< gribble> https://github.com/bitcoin/bitcoin/issues/18191 | Change UpdateForDescendants to use Epochs by JeremyRubin · Pull Request #18191 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #19085: Refactor: clean up PeriodicFlush() (master...2020-05-refactor-periodic-flush) https://github.com/bitcoin/bitcoin/pull/19085
< bitcoin-git> [bitcoin] ajtowns opened pull request #19084: net: add comments on dns seed behaviour (master...202005-dns-seed-doc) https://github.com/bitcoin/bitcoin/pull/19084

2020-05-27

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16127: More thread safety annotation coverage (master...201905-locking) https://github.com/bitcoin/bitcoin/pull/16127
< bitcoin-git> bitcoin/master 8b5af3d Anthony Towns: net: fMsgProcWake use LOCK instead of lock_guard
< bitcoin-git> bitcoin/master de7c5f4 Anthony Towns: wallet/wallet.h: Remove mutexScanning which was only protecting a single a...
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9ccaee1d5e2e...55b4c65bd1d8
< bitcoin-git> bitcoin/master c3cf2f5 Anthony Towns: rpc/blockchain.cpp: Remove g_utxosetscan mutex that is only protecting a s...
< bitcoin-git> [bitcoin] gzhao408 opened pull request #19083: test: msg_mempool, fRelay, and other bloomfilter tests (master...test-bloomfilter) https://github.com/bitcoin/bitcoin/pull/19083
< bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19063: rpc: testmempoolaccept returns transaction fee (master...fee-in-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/19063
< bitcoin-git> [bitcoin] gillichu opened pull request #19082: Moved the CScriptNum asserts into the unit test in script.py (master...issue24) https://github.com/bitcoin/bitcoin/pull/19082
< harding> I added some previously-undocumented changes to the 0.20 release notes draft. Review is appreciated; I'm happy to make any edits: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft/_compare/cd86fd949c5dc3bf8c85f7f4935cac0c1ae0fb55...d87bc6f05e506ae1ff358ccff4e7f4cbbe2c1fb3
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19004: refactor: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
< bitcoin-git> bitcoin/master 9ccaee1 MarcoFalke: Merge #19004: refactor: Replace const char* to std::string
< bitcoin-git> bitcoin/master c57f03c Calvin Kim: refactor: Replace const char* to std::string
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cffbf1eb9a47...9ccaee1d5e2e
< gribble> https://github.com/bitcoin/bitcoin/issues/18275 | wallet: error if an explicit fee rate was given but the needed fee rate differed by kallewoof · Pull Request #18275 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 4c82579 Elichai Turkel: Remove outdated comment about DER encoding
< bitcoin-git> bitcoin/master cffbf1e fanquake: Merge #19073: Remove outdated comment about DER encoding
< bitcoin-git> [bitcoin] fanquake merged pull request #19073: Remove outdated comment about DER encoding (master...2020-05-remove-der-comment) https://github.com/bitcoin/bitcoin/pull/19073
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48e114e0a86f...cffbf1eb9a47
< bitcoin-git> [bitcoin] fanquake merged pull request #19061: doc: Add link to Visual Studio build readme (master...master) https://github.com/bitcoin/bitcoin/pull/19061
< bitcoin-git> bitcoin/master 48e114e fanquake: Merge #19061: doc: Add link to Visual Studio build readme
< bitcoin-git> bitcoin/master 1c91ffe pad: doc : add link to readme.md in the first section
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/520e435b5e56...48e114e0a86f
< gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16549 | UI external signer support (e.g. hardware wallet) by Sjors · Pull Request #16549 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17219 | wallet: allow transaction without change if keypool is empty by Sjors · Pull Request #17219 · bitcoin/bitcoin · GitHub
< fanquake> The linter is having an absolute meltdown over sqlite3.c heh: https://travis-ci.org/github/bitcoin/bitcoin/jobs/691575513
< bitcoin-git> bitcoin/master d321046 Andrew Chow: wallet: remove -salvagewallet
< bitcoin-git> [bitcoin] meshcollider merged pull request #18918: wallet: Move salvagewallet into wallettool (master...wallettool-salvagewallet) https://github.com/bitcoin/bitcoin/pull/18918
< bitcoin-git> bitcoin/master cdd955e Andrew Chow: Add basic test for bitcoin-wallet salvage
< bitcoin-git> bitcoin/master c877709 Andrew Chow: wallettool: Add a salvage command
< bitcoin-git> [bitcoin] meshcollider pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/4af01b37d402...520e435b5e56
< bitcoin-git> [bitcoin] achow101 opened pull request #19077: wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets (master...sqlite-wallet) https://github.com/bitcoin/bitcoin/pull/19077

2020-05-26

< bitcoin-git> [bitcoin] za-kk closed pull request #18313: gui: fix font inconsistency on send coins form (master...march-gui-font) https://github.com/bitcoin/bitcoin/pull/18313
< bitcoin-git> [bitcoin] practicalswift opened pull request #19074: tests: Use BasicTestingSetup to initialise fuzzing environment (master...fuzzers-2020-05-26) https://github.com/bitcoin/bitcoin/pull/19074
< bitcoin-git> [bitcoin] dongcarl closed pull request #18644: net: Reduce `TransportDeserializer` interface to 2 methods (master...2020-04-transport-readmessages) https://github.com/bitcoin/bitcoin/pull/18644
< bitcoin-git> [bitcoin] elichai opened pull request #19073: Remove outdated comment about DER encoding (master...2020-05-remove-der-comment) https://github.com/bitcoin/bitcoin/pull/19073
< bitcoin-git> [bitcoin] laanwj merged pull request #19060: test: Remove global wait_until from p2p_getdata (master...2005-testWaitUntilGetdata) https://github.com/bitcoin/bitcoin/pull/19060
< bitcoin-git> bitcoin/master fa80b47 MarcoFalke: test: Remove global wait_until from p2p_getdata
< bitcoin-git> bitcoin/master 999922b MarcoFalke: test: Default mininode.wait_until timeout to 60s
< bitcoin-git> bitcoin/master fab4737 MarcoFalke: test: pep-8 p2p_getdata.py
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dcacea096e02...4af01b37d402
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19072: doc: Expand section on Getting Started (master...2005-docContribClarif) https://github.com/bitcoin/bitcoin/pull/19072
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19071: [WIP RFC DONOTMERGE] meta: Separate repository for the gui (master...2005-splitRepoGui) https://github.com/bitcoin/bitcoin/pull/19071
< bitcoin-git> [bitcoin] jnewbery opened pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
< bitcoin-git> [bitcoin] theStack opened pull request #19069: refactor: replace pointers by references within tx_verify.{h,cpp} (master...20200526-refactor-replace-pointers-by-refs-in-tx_verify) https://github.com/bitcoin/bitcoin/pull/19069
< bitcoin-git> [bitcoin] laanwj merged pull request #19032: Serialization improvements: final step (master...202005_noncastserial_final) https://github.com/bitcoin/bitcoin/pull/19032
< bitcoin-git> bitcoin/master ef17c03 Pieter Wuille: Convert wallet to new serialization
< bitcoin-git> bitcoin/master 92beff1 Pieter Wuille: Convert LimitedString to formatter
< bitcoin-git> bitcoin/master 65c589e Pieter Wuille: Convert Qt to new serialization
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fe1357a03af1...dcacea096e02
< andrewtoth> I did some rudimentary benchmarking on the connecting blocks with a cleared cache and it does seem to have a performance impact https://github.com/bitcoin/bitcoin/pull/18941#issuecomment-633684774
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18881: Prevent UB in DeleteLock() function (master...200505-cofu) https://github.com/bitcoin/bitcoin/pull/18881
< bitcoin-git> bitcoin/master 8d8921a Hennadii Stepanov: refactor: Add LockStackItem type alias
< bitcoin-git> bitcoin/master f511f61 Hennadii Stepanov: refactor: Add LockPair type alias
< bitcoin-git> bitcoin/master 458992b Hennadii Stepanov: Prevent UB in DeleteLock() function
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/13397dc78fd6...fe1357a03af1
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible (master...2005-rpcInterrupt) https://github.com/bitcoin/bitcoin/pull/19056
< bitcoin-git> bitcoin/master 13397dc MarcoFalke: Merge #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible
< bitcoin-git> bitcoin/master fa75692 MarcoFalke: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible
< bitcoin-git> bitcoin/master fa7fc5a MarcoFalke: rpc: factor out RpcInterruptionPoint from dumptxoutset
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d3b0ef80f653...13397dc78fd6
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18867: tests: Add fuzzing harness for CCoinsViewCache (master...fuzzers-coins_view) https://github.com/bitcoin/bitcoin/pull/18867
< bitcoin-git> bitcoin/master d3b0ef8 MarcoFalke: Merge #18867: tests: Add fuzzing harness for CCoinsViewCache
< bitcoin-git> bitcoin/master f9b22e3 practicalswift: tests: Add fuzzing harness for CCoinsViewCache
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d32cce3e75b...d3b0ef80f653
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
< bitcoin-git> bitcoin/master 5308c97 Jim Posen: [test] Add test for cfheaders
< bitcoin-git> bitcoin/master f6b58c1 Jim Posen: [net processing] Message handling for getcfheaders.
< bitcoin-git> bitcoin/master 3bdc7c2 John Newbery: [doc] Add comment for m_headers_cache
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/14f844777746...7d32cce3e75b
< bitcoin-git> [bitcoin] fanquake opened pull request #19068: build: Use a zip instead of dmg for macOS releases (master...macdeploy_zip_instead_of_dmg) https://github.com/bitcoin/bitcoin/pull/19068
< bitcoin-git> [bitcoin] fanquake merged pull request #19059: gui: update Qt base translations for macOS release (master...macdeploy_translations) https://github.com/bitcoin/bitcoin/pull/19059
< bitcoin-git> bitcoin/master 14f8447 fanquake: Merge #19059: gui: update Qt base translations for macOS release
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f70290642c...14f844777746
< bitcoin-git> bitcoin/master 69bfcac fanquake: gui: update Qt base translations for macOS release

2020-05-25

< bitcoin-git> [bitcoin] practicalswift opened pull request #19067: tests: Add fuzzing harness for CNode (master...fuzzers-2020-05-25) https://github.com/bitcoin/bitcoin/pull/19067
< gribble> https://github.com/bitcoin/bitcoin/issues/19066 | corruption due to lack of memory is not handled · Issue #19066 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #18151: build: replace libdmg and genisoimage with xorriso (master...xorriso_replaces_libdmg_genisoimage) https://github.com/bitcoin/bitcoin/pull/18151
< elichai2> shesek: feel free to test this https://github.com/bitcoin/bitcoin/pull/18964 (promag )
< fjahr> Is this the same issue? https://github.com/bitcoin/bitcoin/issues/18954
< gribble> https://github.com/bitcoin/bitcoin/issues/17219 | wallet: allow transaction without change if keypool is empty by Sjors · Pull Request #17219 · bitcoin/bitcoin · GitHub

2020-05-24

< bitcoin-git> [bitcoin] practicalswift opened pull request #19065: tests: Add fuzzing harness for CAddrMan. Fill some fuzzing coverage gaps. (master...fuzzers-2020-05-23) https://github.com/bitcoin/bitcoin/pull/19065
< bitcoin-git> [bitcoin] hebasto opened pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
< bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19063: rpc: testmempoolaccept returns transaction fee (master...fee-in-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/19063
< gribble> https://github.com/bitcoin/bitcoin/issues/16432 | qt: Add privacy to the Overview page by hebasto · Pull Request #16432 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] maitrebitcoin opened pull request #19061: doc: new section on to how to build with visual studio (master...master) https://github.com/bitcoin/bitcoin/pull/19061

2020-05-23

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19060: test: Remove global wait_until from p2p_getdata (master...2005-testWaitUntilGetdata) https://github.com/bitcoin/bitcoin/pull/19060
< bitcoin-git> [bitcoin] meshcollider merged pull request #18594: cli: display multiwallet balances in -getinfo (master...cli-getinfo-multiwallet-balances) https://github.com/bitcoin/bitcoin/pull/18594
< bitcoin-git> bitcoin/master 9f01849 Jon Atack: cli: create GetWalletBalances() to fetch multiwallet balances
< bitcoin-git> bitcoin/master 7430775 Jon Atack: cli: lift -rpcwallet logic up to CommandLineRPC()
< bitcoin-git> bitcoin/master 29f2cbd Jon Atack: cli: extract connection exception handler, -rpcwait logic
< bitcoin-git> [bitcoin] meshcollider pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/793e0ff22cba...24f70290642c
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18698: Make g_chainman internal to validation (master...2004-chainman) https://github.com/bitcoin/bitcoin/pull/18698
< bitcoin-git> bitcoin/master fa84b1c MarcoFalke: validation: Make LoadBlockIndex() a member of ChainstateManager
< bitcoin-git> bitcoin/master fa05fdf MarcoFalke: net: Pass chainman into PeerLogicValidation
< bitcoin-git> bitcoin/master fa7b626 MarcoFalke: node: Add chainman alias for g_chainman
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/492cdc56e087...793e0ff22cba
< bitcoin-git> [bitcoin] fanquake opened pull request #19059: gui: update Qt base translations for macOS release (master...macdeploy_translations) https://github.com/bitcoin/bitcoin/pull/19059
< bitcoin-git> bitcoin/master 492cdc5 fanquake: Merge #19058: doc: Drop protobuf stuff
< bitcoin-git> [bitcoin] fanquake merged pull request #19058: doc: Drop protobuf stuff (master...200523-proto) https://github.com/bitcoin/bitcoin/pull/19058
< bitcoin-git> bitcoin/master ea9fcfd Hennadii Stepanov: doc: Drop protobuf stuff
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa3288cda125...492cdc56e087
< fanquake> Pinged a few people re adding release notes for 0.20.0 to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft. If you end up adding some let me know / comment on the PR and I'll cleanup the last few "needs release notes" labels
< bitcoin-git> [bitcoin] hebasto opened pull request #19058: doc: Drop protobuf stuff (master...200523-proto) https://github.com/bitcoin/bitcoin/pull/19058

2020-05-22

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (master...remove-afl-limit) https://github.com/bitcoin/bitcoin/pull/19052
< bitcoin-git> bitcoin/master fa3288c MarcoFalke: Merge #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now:...
< bitcoin-git> bitcoin/master 6a239e7 practicalswift: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b5c423c48e09...fa3288cda125
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible (master...2005-rpcInterrupt) https://github.com/bitcoin/bitcoin/pull/19056
< bitcoin-git> [bitcoin] fjahr opened pull request #19055: Calculate UTXO set hash using Muhash (master...csi-1-muhash) https://github.com/bitcoin/bitcoin/pull/19055
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18594 | cli: display multiwallet balances in -getinfo by jonatack · Pull Request #18594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18918 | wallet: Move salvagewallet into wallettool by achow101 · Pull Request #18918 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18787 | wallet: descriptor wallet release notes and cleanups by achow101 · Pull Request #18787 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] achow101 opened pull request #19054: wallet: Skip hdKeypath of 'm' when determining inactive hd seeds (master...inactive-seed-skip-m) https://github.com/bitcoin/bitcoin/pull/19054
< bitcoin-git> [bitcoin] theStack opened pull request #19053: refactor: replace CNode pointers by references within net_processing.{h,cpp} (master...20200522-refactor-use-cnode-references-within-net_processing) https://github.com/bitcoin/bitcoin/pull/19053
< bitcoin-git> [bitcoin] practicalswift opened pull request #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (master...remove-afl-limit) https://github.com/bitcoin/bitcoin/pull/19052
< bitcoin-git> [bitcoin] fjahr opened pull request #19050: doc: Add warning for rest interface limitation (master...rest_fd) https://github.com/bitcoin/bitcoin/pull/19050
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option (master...2005-testPrevReleases) https://github.com/bitcoin/bitcoin/pull/19014
< bitcoin-git> bitcoin/master b5c423c MarcoFalke: Merge #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_frame...
< bitcoin-git> bitcoin/master fad798b MarcoFalke: test: Default --previous-releases to false if dir is empty
< bitcoin-git> bitcoin/master faf1c3c MarcoFalke: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df303ceb6505...b5c423c48e09
< bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19048: test: changing signature of wait_until(). (master...fixing-waituntil) https://github.com/bitcoin/bitcoin/pull/19048
< bitcoin-git> [bitcoin] achow101 opened pull request #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants (master...rm-load-memonly) https://github.com/bitcoin/bitcoin/pull/19046
< bitcoin-git> [bitcoin] meshcollider merged pull request #18787: wallet: descriptor wallet release notes and cleanups (master...desc-wallet-followup) https://github.com/bitcoin/bitcoin/pull/18787
< bitcoin-git> bitcoin/master 89b1ce1 Andrew Chow: Remove unimplemented SetCrypted from DescriptorScriptPubKeyMan
< bitcoin-git> bitcoin/master b9073c8 Andrew Chow: rpc: createwallet warning that descriptor wallets are experimental
< bitcoin-git> bitcoin/master 610030d Andrew Chow: docs: Add release notes for descriptor wallets
< bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ccd85b57af60...df303ceb6505
< bitcoin-git> [bitcoin] meshcollider merged pull request #17681: wallet: Keep inactive seeds after sethdseed and derive keys from them as needed (master...keep-inactive-seeds) https://github.com/bitcoin/bitcoin/pull/17681
< bitcoin-git> bitcoin/master c93082e Andrew Chow: Generate new keys for inactive seeds after marking used
< bitcoin-git> bitcoin/master 45f2f6a Andrew Chow: Determine inactive HD seeds from key metadata and track them in LegacyScri...
< bitcoin-git> bitcoin/master b59b450 Andrew Chow: have GenerateNewKey and DeriveNewChildKey take a CHDChain as an argument
< bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3a61c5f5c9...ccd85b57af60

2020-05-21

< bitcoin-git> bitcoin/master 9d3f7eb gzhao408: [mempool] sanity check that all unbroadcast txns are in mempool
< bitcoin-git> [bitcoin] fanquake merged pull request #18895: p2p: unbroadcast followups: rpcs, nLastResend, mempool sanity check (master...unbroadcast-followup) https://github.com/bitcoin/bitcoin/pull/18895
< bitcoin-git> bitcoin/master a7ebe48 gzhao408: [rpc] add unbroadcast info to mempool entries and getmempoolinfo
< bitcoin-git> bitcoin/master d160069 gzhao408: [wallet] remove nLastResend logic
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9abed46871a7...ad3a61c5f5c9
< bitcoin-git> [bitcoin] fanquake closed pull request #19045: qt: pt_BR translation adjustments (master...2020-05-qt-pt_BR-translation-adjustments) https://github.com/bitcoin/bitcoin/pull/19045
< bitcoin-git> [bitcoin] gabrieldonadel opened pull request #19045: qt: pt_BR translation adjustments (master...2020-05-qt-pt_BR-translation-adjustments) https://github.com/bitcoin/bitcoin/pull/19045
< bitcoin-git> [bitcoin] jnewbery opened pull request #19044: net processing: Add support for getcfilters (master...2020-05-cfilters) https://github.com/bitcoin/bitcoin/pull/19044
< bitcoin-git> [bitcoin] MDrollette opened pull request #19043: torcontrol: add -tortarget config (master...tor-hidden-target) https://github.com/bitcoin/bitcoin/pull/19043
< BlueMatt> my thinking was the goal wasnt to try to just scramble the bitcoin data to make it look like noise on the wire, it was to actually have redundant codepaths (and network paths) to fetch block data
< BlueMatt> ariard: maybe, but (1) provides you ability to get data from things that arent bidirectional high-bandwidth sockets. (2) is just a way to shove bitcoin p2p protocol over top of something else.
< BlueMatt> right, fair. i guess just in my past thinking on this I've always considered mostly more nice bitcoin data providers, less p2p-encryption/modoulation-style providers. I agree that would be a cool goal as well, though i guess is fully separate from things I was thinking about
< BlueMatt> sipa: as for "the goal", thats true, if we want to model after eg tor's pluggable transport, we want a byte stream, but I think bitcoin data is a little too unique for that - because its so small, we end up being able to shove it in all kinds of queries
< wumpus> BlueMatt: yes, I know, it was great! unfortuantely the approach to integrate them into bitcoin core didn't work with regard to review and organizationaly
< jnewbery> perhaps this more speculative discussion is better suited to bitcoin-wizards or similar?
< BlueMatt> eg you can write dns + http + radio + a full second p2p client with only these functions: https://github.com/TheBlueMatt/bitcoin/blob/d3ca09afbc38d7f73866da33948651ac2c40fd58/src/rusty/src/cpp_bridge.cpp
< jnewbery> ariard: what do you need help with? From my perspective, there's still a lot of work to be done internally in Bitcoin Core cleaning up the layer separation between net / net_processing / validation, but I haven't reviewed your branch yet
< BlueMatt> but you magically make the censor think you're connecting to that but are in fact connecting to a bitcoin core reset endpoint
< wumpus> bitcoin core is I/O bound but usually only on disk, not on P2P/network
< wumpus> if it runs in an external process and communicates with bitcoin core that's the right way
< wumpus> while I think alternative transports are great, I don't think we should integrate the code for all the transports into bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/18989 | Towards alternative transports first-class support · Issue #18989 · bitcoin/bitcoin · GitHub