2019-08-14

< bitcoin-git> bitcoin/0.18 5aac5e9 MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
< bitcoin-git> bitcoin/0.18 80cd3f0 MarcoFalke: travis: Bump timeout from 50 minutes to 90
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
< bitcoin-git> [bitcoin] laanwj opened pull request #16611: build: Remove src/obj directory from repository (master...2019_08_srcobj) https://github.com/bitcoin/bitcoin/pull/16611
< bitcoin-git> [bitcoin] laanwj merged pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f29790cd7e...a7aa80902763
< bitcoin-git> bitcoin/master 7cd069d Martin Zumsande: Add test for AddTimeData
< bitcoin-git> bitcoin/master a7aa809 Wladimir J. van der Laan: Merge #16563: test: Add unit test for AddTimeData
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16589: build: Remove unused src/obj-test folder (master...1908-buildNoSrcObjTest) https://github.com/bitcoin/bitcoin/pull/16589
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0753c7392796...24f29790cd7e
< bitcoin-git> bitcoin/master fa4ee0d MarcoFalke: build: Remove unused src/obj-test folder
< bitcoin-git> bitcoin/master 24f2979 MarcoFalke: Merge #16589: build: Remove unused src/obj-test folder
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
< bitcoin-git> [bitcoin] fanquake merged pull request #16596: rpc: Fix getblocktemplate CLI example (master...2019-08-helpexamplecli-fix) https://github.com/bitcoin/bitcoin/pull/16596
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/034575e9c7a3...0753c7392796
< bitcoin-git> bitcoin/master 14f7eec Emil Engler: rpc: Fix getblocktemplate CLI example (#16594)
< bitcoin-git> bitcoin/master 0753c73 fanquake: Merge #16596: rpc: Fix getblocktemplate CLI example
< wumpus> error: failed to push some refs to 'git@github.com:bitcoin/bitcoin'
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7df1ecd1758...034575e9c7a3
< bitcoin-git> bitcoin/master 3963856 fanquake: descriptor: fix missed m_script_arg arg renaming in #14934
< bitcoin-git> bitcoin/master 034575e MarcoFalke: Merge #16609: descriptor: fix missed m_script_arg arg renaming in #14934
< wumpus> To github.com:bitcoin/bitcoin
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #16584: gui: New filesave icon, updated copyright (master...branch4) https://github.com/bitcoin/bitcoin/pull/16584
< bitcoin-git> [bitcoin] fanquake opened pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
< bitcoin-git> [bitcoin] Sjors opened pull request #16608: [backport] Use wallet RBF default for walletcreatefundedpsbt (0.18...2018/08/backport-wallet-rbf-default) https://github.com/bitcoin/bitcoin/pull/16608
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/286332495d43...e7df1ecd1758
< bitcoin-git> bitcoin/master 2290269 Sjors Provoost: scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg
< bitcoin-git> bitcoin/master 2e68ffa Sjors Provoost: [doc] descriptor: explain GetPubKey() usage with cached public key
< bitcoin-git> bitcoin/master e7df1ec Wladimir J. van der Laan: Merge #14934: Descriptor expansion cache clarifications
< bitcoin-git> [bitcoin] laanwj merged pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
< bitcoin-git> [bitcoin] laanwj merged pull request #16605: Add missing contributor to 0.18.1 release notes (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b49e7796c298...286332495d43
< bitcoin-git> bitcoin/master 862cbf3 MeshCollider: Add missing contributor to release notes
< bitcoin-git> bitcoin/master 2863324 Wladimir J. van der Laan: Merge #16605: Add missing contributor to 0.18.1 release notes
< bitcoin-git> [bitcoin] fanquake closed pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
< bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
< bitcoin-git> [bitcoin] fanquake closed pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
< bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/fa27a0760792...bbc2970082a2
< bitcoin-git> bitcoin/0.18 bbc2970 Wladimir J. van der Laan: doc: Clean out release notes post-0.18.1
< bitcoin-git> [bitcoin] meshcollider opened pull request #16605: Add missing contributor to 0.18.1 release notes (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
< bitcoin-git> [bitcoin] meshcollider closed pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
< bitcoin-git> [bitcoin] laanwj merged pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b120645e8cfc...b49e7796c298
< bitcoin-git> bitcoin/master 3303124 fanquake: build: disable libxcb extensions
< bitcoin-git> bitcoin/master b49e779 Wladimir J. van der Laan: Merge #16533: build: disable libxcb extensions
< bitcoin-git> [bitcoin] meshcollider opened pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
< gribble> https://github.com/bitcoin/bitcoin/issues/16011 | addmultisigaddress does not fallback to legacy when there are uncompressed public keys in the parameters · Issue #16011 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16012 | rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided by ps1dr3x · Pull Request #16012 · bitcoin/bitcoin · GitHub
< fanquake> I've just closed the 0.18.1 milestone. https://github.com/bitcoin/bitcoin/milestones/41
< bitcoin-git> [bitcoin] laanwj merged pull request #16595: travis: use extended 90 minute timeout when available (master...1908-travisNoTimeout) https://github.com/bitcoin/bitcoin/pull/16595
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05ccbe9a2991...b120645e8cfc
< bitcoin-git> bitcoin/master fa1e9c6 MarcoFalke: travis: Bump timeout from 50 minutes to 90
< bitcoin-git> bitcoin/master b120645 Wladimir J. van der Laan: Merge #16595: travis: use extended 90 minute timeout when available
< bitcoin-git> [bitcoin] fanquake closed pull request #14079: Implement sighash cache in CHECKMULTISIG (master...cms_cache) https://github.com/bitcoin/bitcoin/pull/14079
< bitcoin-git> [bitcoin] fanquake closed pull request #15032: Nit fixes for PR 14565 (master...201812_pr_14565_nits) https://github.com/bitcoin/bitcoin/pull/15032
< bitcoin-git> [bitcoin] fanquake merged pull request #16598: test: Remove confusing hash256 function in util (master...2019-08-rename-hash256) https://github.com/bitcoin/bitcoin/pull/16598
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b605cf1301...05ccbe9a2991
< bitcoin-git> bitcoin/master afc0966 Elichai Turkel: Moved and renamed hash256 from util.py to zmq_interface.py
< bitcoin-git> bitcoin/master 05ccbe9 fanquake: Merge #16598: test: Remove confusing hash256 function in util
< bitcoin-git> [bitcoin] fanquake merged pull request #16586: doc: Mention other ways to conserve memory on compilation (master...1908-docLowMem) https://github.com/bitcoin/bitcoin/pull/16586
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b799ebcc17ea...c3b605cf1301
< bitcoin-git> bitcoin/master fa7789f MarcoFalke: doc: Mention other ways to conserve memory on compilation
< bitcoin-git> bitcoin/master c3b605c fanquake: Merge #16586: doc: Mention other ways to conserve memory on compilation

2019-08-13

< bitcoin-git> [bitcoin] elichai opened pull request #16598: Renaming confusing hash256 function name in the tests (master...2019-08-rename-hash256) https://github.com/bitcoin/bitcoin/pull/16598
< provoostenator> And without explaining why "bitcoin" was missing from the list of repos.
< bitcoin-git> [bitcoin] Sjors opened pull request #16597: Travis: run full test suite on native macOS (master...2019/08/travis-macos) https://github.com/bitcoin/bitcoin/pull/16597
< provoostenator> Why did Travis make their interface more confusing? I can't figure out how to build my a branch in my own fork of the bitcoin repo.
< bitcoin-git> [bitcoin] emilengler opened pull request #16596: rpc: Fix getblocktemplate CLI example (#16594) (master...2019-08-helpexamplecli-fix) https://github.com/bitcoin/bitcoin/pull/16596
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16595: travis: Bump timeout from 50 minutes to 90 (master...1908-travisNoTimeout) https://github.com/bitcoin/bitcoin/pull/16595
< bitcoin-git> [bitcoin] fanquake closed pull request #16593: sorry test (master...test) https://github.com/bitcoin/bitcoin/pull/16593
< bitcoin-git> [bitcoin] mech12 opened pull request #16593: block mining time : 1 -> 3second. (master...test) https://github.com/bitcoin/bitcoin/pull/16593
< bitcoin-git> [bitcoin] fanquake merged pull request #16566: util: refactor upper/lowercase functions (master...2019-08-casefuns-refactor) https://github.com/bitcoin/bitcoin/pull/16566
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b499d8576f30...b799ebcc17ea
< bitcoin-git> bitcoin/master 0481fa2 Karl-Johan Alm: util: refactor upper/lowercase functions
< bitcoin-git> bitcoin/master b799ebc fanquake: Merge #16566: util: refactor upper/lowercase functions

2019-08-12

< bitcoin-git> [bitcoin] emilengler opened pull request #16590: init: systemd directory fix (master...2019-08-systemd-fix) https://github.com/bitcoin/bitcoin/pull/16590
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16589: build: Remove unused src/obj-test folder (master...1908-buildNoSrcObjTest) https://github.com/bitcoin/bitcoin/pull/16589
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16557: [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay() (master...2019-08-restore-coinbase-check) https://github.com/bitcoin/bitcoin/pull/16557
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/00dad5e0e1dd...b499d8576f30
< bitcoin-git> bitcoin/master 214c4ec John Newbery: [wallet] restore coinbase check in SubmitMemoryPoolAndRelay()
< bitcoin-git> bitcoin/master c8b53c3 John Newbery: [wallet] Restore confirmed/conflicted tx check in SubmitMemoryPoolAndRelay...
< bitcoin-git> bitcoin/master b499d85 MarcoFalke: Merge #16557: [wallet] restore coinbase and confirmed/conflicted checks in...
< bitcoin-git> [bitcoin] ariard opened pull request #16587: doc: Improve versionbits.h documentation (master...2019-08-docs-versionbits) https://github.com/bitcoin/bitcoin/pull/16587
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16571: gui: Make Bitcoin Core logo pure black (master...1908-guiIcoPureBlack) https://github.com/bitcoin/bitcoin/pull/16571
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16586: doc: Mention other ways to conserve memory on compilation (master...1908-docLowMem) https://github.com/bitcoin/bitcoin/pull/16586
< bitcoin-git> [bitcoin] laanwj merged pull request #16581: sipsorcery gitian key (master...add_gitian_key) https://github.com/bitcoin/bitcoin/pull/16581
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9059a6f248d2...00dad5e0e1dd
< bitcoin-git> bitcoin/master 9063911 Aaron Clauson: sipsorcery gitian key.
< bitcoin-git> bitcoin/master 00dad5e Wladimir J. van der Laan: Merge #16581: sipsorcery gitian key
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #16349: qt: Remove redundant WalletController::addWallet slot (master...20190706-fix15453) https://github.com/bitcoin/bitcoin/pull/16349
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac3e65204af6...9059a6f248d2
< bitcoin-git> bitcoin/master 6285a31 Hennadii Stepanov: Remove redundant WalletController::addWallet slot
< bitcoin-git> bitcoin/master 9059a6f Jonas Schnelli: Merge #16349: qt: Remove redundant WalletController::addWallet slot
< bitcoin-git> [bitcoin] fanquake closed pull request #16559: Unified text outputs (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16559

2019-08-11

< bitcoin-git> [bitcoin] fanquake merged pull request #16585: doc: Update Markdown syntax for bdb packages (master...2019-08-build-unix-bdb-syntax) https://github.com/bitcoin/bitcoin/pull/16585
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e47e36cb4975...ac3e65204af6
< bitcoin-git> bitcoin/master 1f26328 Emil Engler: doc: Update Markdown syntax for bdb packages
< bitcoin-git> bitcoin/master ac3e652 fanquake: Merge #16585: doc: Update Markdown syntax for bdb packages
< bitcoin-git> [bitcoin] emilengler opened pull request #16585: doc: Update Markdown syntax for bdb packages (master...2019-08-build-unix-bdb-syntax) https://github.com/bitcoin/bitcoin/pull/16585
< bitcoin-git> [bitcoin] gapeman opened pull request #16584: [QT] New filesave icon, updated copyright (master...branch4) https://github.com/bitcoin/bitcoin/pull/16584
< bitcoin-git> [bitcoin] gapeman closed pull request #16583: [QT] New filesave icon (master...master) https://github.com/bitcoin/bitcoin/pull/16583
< bitcoin-git> [bitcoin] practicalswift closed pull request #16331: build: Add configure option --enable-lowmem to allow for building in low-memory environments (master...low-mem) https://github.com/bitcoin/bitcoin/pull/16331

2019-08-10

< bitcoin-git> [bitcoin] gapeman opened pull request #16583: [QT] New filesave icon (master...master) https://github.com/bitcoin/bitcoin/pull/16583
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16582: test: Rework ci (Use travis only as fallback env) (master...1908-ciRework) https://github.com/bitcoin/bitcoin/pull/16582
< bitcoin-git> [bitcoin] sipsorcery opened pull request #16581: sipsorcery gitian key (master...add_gitian_key) https://github.com/bitcoin/bitcoin/pull/16581
< gribble> https://github.com/bitcoin/bitcoin/issues/12134 | Build previous releases and run functional tests by Sjors · Pull Request #12134 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #15191: validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations. (master...cs_LastBlockFile) https://github.com/bitcoin/bitcoin/pull/15191
< bitcoin-git> [bitcoin] practicalswift closed pull request #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache(). Add missing locking annotations. (master...validation-cs_main) https://github.com/bitcoin/bitcoin/pull/15192
< bitcoin-git> [bitcoin] practicalswift closed pull request #16320: ci: Add Travis check to make sure unit test coverage reports stay deterministic (master...test-deterministic-coverage-in-travis) https://github.com/bitcoin/bitcoin/pull/16320

2019-08-09

< bitcoin-git> [bitcoin] achow101 opened pull request #16578: Do not pass in command line arguments to QApplication (master...no-qapp-args) https://github.com/bitcoin/bitcoin/pull/16578
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9ab9d6356938...e47e36cb4975
< bitcoin-git> bitcoin/master bf72b8a fanquake: build: disable libsecp256k1 benchmarks
< bitcoin-git> bitcoin/master e47e36c Wladimir J. van der Laan: Merge #16573: build: disable building libsecp256k1 benchmarks
< bitcoin-git> [bitcoin] laanwj merged pull request #16573: build: disable building libsecp256k1 benchmarks (master...disable-secp256k1-benchmarks) https://github.com/bitcoin/bitcoin/pull/16573
< bitcoin-git> [bitcoin] LarryRuane opened pull request #16577: util: CBufferedFile fixes and unit test (master...CBufferedFile-fixes) https://github.com/bitcoin/bitcoin/pull/16577
< provoostenator> "dig -6 -t AAAA +trace seed.bitcoin.sprovoost.nl" can be helpful seeing where the buck stops, ht BlueMatt
< provoostenator> 1. add an AAAA record from seed.bitcoin.sprovoost.nl. to the IPv6 address of the seed
< achow101> provoostenator: https://github.com/achow101/bitcoin/tree/wallet-boxes-2 it's currently broken as I didn't actually finish it
< provoostenator> BlueMatt: the good news is, this works now: dig -6 -t AAAA seed.bitcoin.sprovoost.nl
< gleb> Public bitcoin nodes use about 1200 ASNs. 20 of those ASNs represent 50% of the nodes, and just 3 ASNs represent 25%. This means that suggested ASN-based bucketing bias would make more (potentially, mission-critical) connections to those tiny unpopular ASNs than it is today. Is this well-understood? Is this the effect we want? I'm not sure.
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< BlueMatt> you want dig -6 +trace seed.bitcoin.sipa.be aaaa
< sipa> BlueMatt: $ dig -t AAAA seed.bitcoin.sipa.be
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16503: Remove p2pEnabled from Chain interface (master...2019-07-remove-p2p-chain) https://github.com/bitcoin/bitcoin/pull/16503
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32776276ef07...9ab9d6356938
< bitcoin-git> bitcoin/master b7b9f6e Antoine Riard: Remove p2pEnabled from Chain interface
< bitcoin-git> bitcoin/master 9ab9d63 MarcoFalke: Merge #16503: Remove p2pEnabled from Chain interface
< bitcoin-git> [bitcoin] fanquake merged pull request #16574: doc: Add historical release notes for 0.18.1 (master...2019_08_relnot_0_18_1) https://github.com/bitcoin/bitcoin/pull/16574
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5fdda68c6d2...32776276ef07
< bitcoin-git> bitcoin/master 61c5c64 Wladimir J. van der Laan: doc: Add historical release notes for 0.18.1
< bitcoin-git> bitcoin/master 3277627 fanquake: Merge #16574: doc: Add historical release notes for 0.18.1
< bitcoin-git> [bitcoin] laanwj opened pull request #16574: doc: Add historical release notes for 0.18.1 (master...2019_08_relnot_0_18_1) https://github.com/bitcoin/bitcoin/pull/16574
< bitcoin-git> [bitcoin] fanquake opened pull request #16573: build: disable building libsecp256k1 benchmarks (master...disable-secp256k1-benchmarks) https://github.com/bitcoin/bitcoin/pull/16573

2019-08-08

< bitcoin-git> [bitcoin] JeremyRubin opened pull request #16572: Fix Char as Bool in Wallet (master...fix-wallet-charbool) https://github.com/bitcoin/bitcoin/pull/16572
< gribble> https://github.com/bitcoin/bitcoin/issues/16443 | refactor: have CCoins* data managed under CChainState by jamesob · Pull Request #16443 · bitcoin/bitcoin · GitHub
< jonasschnelli> "Bitcoin Core implemente GitHub CI after talks with their CEO,... a week after they acted in massive censorship"
< MarcoFalke> Ok, that is a point I buy. They might say the GitHub ci is "approved by Bitcoin Core"
< achow101> just enable it for anyone in the bitcoin and bitcoin-core orgs :)
< gribble> https://github.com/bitcoin/bitcoin/issues/16550 | Distribute via flatpak · Issue #16550 · bitcoin/bitcoin · GitHub
< wumpus> #topic Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak (MarcoFalke)
< gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< jonasschnelli> (lets take the CI discussion to #bitcoin-builds plz)
< gribble> https://github.com/bitcoin/bitcoin/issues/16060 | Bury bip9 deployments by jnewbery · Pull Request #16060 · bitcoin/bitcoin · GitHub
< wumpus> there's one by MarcoFalke: Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak
< MarcoFalke> We can always keep the bitcoin-builds as a backup fallback ci
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< MarcoFalke> #proposedmeetingtopic Who wants to volunteer as co-maintainer of the Bitcoin Core flatpak?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16571: gui: Make Bitcoin Core logo pure black (master...1908-guiIcoPureBlack) https://github.com/bitcoin/bitcoin/pull/16571
< bitcoin-git> [bitcoin] davereikher opened pull request #16570: Make descriptor tests deterministic (master...make_descriptor_tests_deterministic) https://github.com/bitcoin/bitcoin/pull/16570
< bitcoin-git> [bitcoin] setpill opened pull request #16569: Disable systemd stop timeout (master...fix-systemd-shutdown) https://github.com/bitcoin/bitcoin/pull/16569
< setpill> I just tried `bitcoin-cli stop` (rather than `systemctl stop bitcoind.service`) and it took almost 9 minutes.
< jonasschnelli> Unfortunate that our current ChaCha20Poly1305@Bitcoin implementation works on a single buffer.
< belcher> setpill this is a question more for #bitcoin than here, but try running `bitcoin-cli stop`
< setpill> belcher: it's related to the default systemd service file of bitcoin core not shutting it down cleanly when using `systemctl stop bitcoind.service`
< gribble> https://github.com/bitcoin/bitcoin/issues/16562 | Refactor message transport packaging by jonasschnelli · Pull Request #16562 · bitcoin/bitcoin · GitHub
< fanquake> promag: I've put together a AppleScript that spams wallet loads and unloads in the GUI: https://github.com/bitcoin/bitcoin/issues/16307#issuecomment-519355809
< ariard> cfields: hey if you are around and have time, could you have a look on https://github.com/bitcoin/bitcoin/pull/16503 :) ? People are uncertain on it
< fanquake> Pushed up some signed sigs: https://github.com/bitcoin-core/gitian.sigs/pull/1065
< bitcoin-git> [bitcoin] kallewoof opened pull request #16566: util: refactor upper/lowercase functions (master...2019-08-casefuns-refactor) https://github.com/bitcoin/bitcoin/pull/16566

2019-08-07

< wumpus> I think the PR comments on https://github.com/bitcoin/bips/pull/766 is an ok place to keep track of things we want to change to the BIP until that
< wumpus> dongcarl: maybe this could be part of the https://github.com/bitcoin/bips/pull/766#issuecomment-517003833 sendaddrv2 message here to notify peers of addrv2 support (which was poroposed as alternative to the protocol version bump the BIP currently documents)
< jonasschnelli> requesting Cory review on https://github.com/bitcoin/bitcoin/pull/16562 (especially a comment on the joining of header&payload as single buffer in vSendMsg)
< bitcoin-git> [bitcoin] candrews opened pull request #16564: Always define the raii_event_tests test suite (0.18...patch-1) https://github.com/bitcoin/bitcoin/pull/16564
< bitcoin-git> [bitcoin] mzumsande opened pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
< provoostenator> Optech newsletter jumped the gun on "Upgrade to Bitcoin Core 0.18.1"
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #16562: Refactor message transport packaging (master...2019/06/net_refactor_2) https://github.com/bitcoin/bitcoin/pull/16562
< jonasschnelli> OSX sigs for 0.18.1 are ready to review and merge: https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/28
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
< bitcoin-git> [bitcoin] practicalswift opened pull request #16561: tests: Add test_runner.py option --parsable (master...parsable) https://github.com/bitcoin/bitcoin/pull/16561
< gribble> https://github.com/bitcoin/bitcoin/issues/16555 | [doc] mention whitelist is inbound, and applies to blocksonly by Sjors · Pull Request #16555 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15558 | Dont query all DNS seeds at once by sipa · Pull Request #15558 · bitcoin/bitcoin · GitHub

2019-08-06

< bitcoin-git> [bitcoin] luke-jr opened pull request #16560: Bugfix: QA: Run tests with UPnP disabled (master...test_without_upnp) https://github.com/bitcoin/bitcoin/pull/16560
< bitcoin-git> [bitcoin] gapeman opened pull request #16559: Unified text outputs (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16559
< bitcoin-git> [bitcoin] fanquake closed pull request #16558: Update headers to 2019 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16558
< bitcoin-git> [bitcoin] gapeman opened pull request #16558: Update headers to 2019 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16558
< bitcoin-git> [bitcoin] jnewbery opened pull request #16557: [wallet] restore coinbase check in SubmitMemoryPoolAndRelay() (master...2019-08-restore-coinbase-check) https://github.com/bitcoin/bitcoin/pull/16557
< jnewbery> The coinbase check was removed here: https://github.com/bitcoin/bitcoin/pull/15713/files#diff-b2bb174788c7409b671c46ccc86034bdL2163 (in PR 15713). I think we should just restore it
< bitcoin-git> [bitcoin] jamesob closed pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b725979a1175...e5fdda68c6d2
< bitcoin-git> bitcoin/master 2f37163 fanquake: test: only include and init openSSL where it's actually used
< bitcoin-git> bitcoin/master e5fdda6 MarcoFalke: Merge #16554: test: only include and use OpenSSL where it's actually neede...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fbe4b7665b97...b725979a1175
< bitcoin-git> bitcoin/master faff85a MarcoFalke: test: Format feature_fee_estimation with pep8
< bitcoin-git> bitcoin/master fa76285 MarcoFalke: test: Explain why -whitelist is used in feature_fee_estimation
< bitcoin-git> bitcoin/master b725979 MarcoFalke: Merge #16535: test: Explain why -whitelist is used in feature_fee_estimati...
< bitcoin-git> [bitcoin] setpill opened pull request #16556: Fix systemd service perms (master...fix-systemd-service-perms) https://github.com/bitcoin/bitcoin/pull/16556
< bitcoin-git> [bitcoin] Sjors opened pull request #16555: [doc] mention whitelist is inbound, and applies to blocksonly (master...2019/08/doc-whitelistrelay) https://github.com/bitcoin/bitcoin/pull/16555
< gribble> https://github.com/bitcoin/bitcoin/issues/15729 | rpc: Raise error in getbalance if minconf is not zero by promag · Pull Request #15729 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
< gribble> https://github.com/bitcoin/bitcoin/issues/16533 | build: disable libxcb extensions by fanquake · Pull Request #16533 · bitcoin/bitcoin · GitHub
< wumpus> fanquake: #2302 seems to be about bitcoin: URLs in general
< gribble> https://github.com/bitcoin/bitcoin/issues/2302 | Double-clicking bitcoin: URI link == duplicate Pay Tos · Issue #2302 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub
< emilengler> Does the argmanager also loads the bitcoin.conf? Or is this being done seperately
< bitcoin-git> [bitcoin] fanquake merged pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31d98584f3c5...fbe4b7665b97
< bitcoin-git> bitcoin/master b2ea20d Kristian Kramer: doc: Fix grammar and punctuation in developer notes
< bitcoin-git> bitcoin/master fbe4b76 fanquake: Merge #16530: doc: Fix grammar and punctuation in developer notes
< bitcoin-git> [bitcoin] fanquake merged pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62117f9f363e...31d98584f3c5
< bitcoin-git> bitcoin/master fa5a4cd MarcoFalke: gui: Generate bech32 addresses by default (take 2, fixup)
< bitcoin-git> bitcoin/master 31d9858 fanquake: Merge #16497: gui: Generate bech32 addresses by default (take 2, fixup)

2019-08-05

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16551: test: Test that low difficulty chain fork is rejected (master...1908-testDosLowHeader) https://github.com/bitcoin/bitcoin/pull/16551
< bitcoin-git> [bitcoin] Sjors opened pull request #16549: [WIP] UI external signer support (e.g. hardware wallet) (master...2019/08/hww-qt) https://github.com/bitcoin/bitcoin/pull/16549
< bitcoin-git> [bitcoin] emilengler closed pull request #16544: rpc: Add rpcallowstop (master...2019-08-rpc-disable-stop-parameter) https://github.com/bitcoin/bitcoin/pull/16544
< bitcoin-git> [bitcoin] mmachicao opened pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
< gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto closed pull request #16508: Disallow double negation syntax (-nofoo=0) for options (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
< bitcoin-git> [bitcoin] Alko89 opened pull request #16547: Check usages of #if defined(...) (master...if-defined-usages) https://github.com/bitcoin/bitcoin/pull/16547
< bitcoin-git> [bitcoin] ajtowns closed pull request #16229: Standardise deployment handling (master...201906-deployments) https://github.com/bitcoin/bitcoin/pull/16229
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d5ea8f4bf39a...62117f9f363e
< bitcoin-git> bitcoin/master 77770d9 MarcoFalke: test: Properly serialize BIP34 coinbase height
< bitcoin-git> bitcoin/master fa8489a MarcoFalke: test: Add test for BIP30 duplicate tx
< bitcoin-git> bitcoin/master 62117f9 MarcoFalke: Merge #16363: test: Add test for BIP30 duplicate tx
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c77f7cdbd1ce...d5ea8f4bf39a
< bitcoin-git> bitcoin/master 68f5466 Ben Woosley: test: Fix “local variable 'e' is assigned to but never used”
< bitcoin-git> bitcoin/master fa8a1d7 MarcoFalke: test: Adapt test framework for chains other than "regtest"
< bitcoin-git> bitcoin/master faf3683 MarcoFalke: test: Avoid hardcoding the chain name in combine_logs
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16197: net: Use mockable time for tx download (master...1906-netMock) https://github.com/bitcoin/bitcoin/pull/16197
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1063fc9cf9b5...c77f7cdbd1ce
< bitcoin-git> bitcoin/master fa883ab MarcoFalke: net: Use mockable time for tx download
< bitcoin-git> bitcoin/master fab3658 Suhas Daftuar: [qa] Test that getdata requests work as expected
< bitcoin-git> bitcoin/master c77f7cd MarcoFalke: Merge #16197: net: Use mockable time for tx download
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16536: doc: Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b6386e85492...1063fc9cf9b5
< bitcoin-git> bitcoin/master 05fdb97 Antoine Riard: [doc] Update and extend benchmarking.md
< bitcoin-git> bitcoin/master 1063fc9 MarcoFalke: Merge #16536: doc: Update and extend benchmarking.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e55444a2a8a2...6b6386e85492
< bitcoin-git> bitcoin/master fa566b2 MarcoFalke: test: Add missing sync_blocks to feature_pruning
< bitcoin-git> bitcoin/master 6b6386e MarcoFalke: Merge #16538: test: Add missing sync_blocks to feature_pruning
< gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub

2019-08-04

< bitcoin-git> [bitcoin] Sjors closed pull request #14912: [WIP] External signer support (e.g. hardware wallet) (master...2018/11/rpc-signer) https://github.com/bitcoin/bitcoin/pull/14912
< bitcoin-git> [bitcoin] Sjors closed pull request #15876: [rpc] signer send and fee bump convenience methods (master...2019/04/signerbumpfee) https://github.com/bitcoin/bitcoin/pull/15876
< bitcoin-git> [bitcoin] Sjors opened pull request #16546: [WIP] External signer support - Wallet Box edition (master...2019/08/hww-box2) https://github.com/bitcoin/bitcoin/pull/16546
< bitcoin-git> [bitcoin] ryanofsky opened pull request #16545: Implement missing error checking for ArgsManager flags (master...pr/argcheck) https://github.com/bitcoin/bitcoin/pull/16545
< bitcoin-git> [bitcoin] fanquake closed pull request #16138: Scripts and tools: Add sudoers.d, rc.local from docs to gitian script (master...gitian-automated-sudoers-br0) https://github.com/bitcoin/bitcoin/pull/16138
< bitcoin-git> [bitcoin] fanquake closed pull request #13612: Qt: Only call tryGetBalances in pollBalanceChanged if the result will be used. (master...bitcoin) https://github.com/bitcoin/bitcoin/pull/13612
< bitcoin-git> [bitcoin] fanquake closed pull request #14125: Add testcase to simulate bitcoin schema in leveldb (master...master) https://github.com/bitcoin/bitcoin/pull/14125
< bitcoin-git> [bitcoin] emilengler opened pull request #16544: rpc: Add rpcallowstop (master...2019-08-rpc-disable-stop-parameter) https://github.com/bitcoin/bitcoin/pull/16544
< elichai2> emilengler: yp need to add `-S` to everyt git command you run that modifies the commits. but an easier way to do this is just run `git config commit.gpgsign true` in your bitcoin dir which will force your git to sign every commit you make in that repo
< bitcoin-git> [bitcoin] fanquake merged pull request #16534: build: add Qt Creator Makefile.am.user to .gitignore (master...patch-3) https://github.com/bitcoin/bitcoin/pull/16534
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3a3d8b835712...e55444a2a8a2
< bitcoin-git> bitcoin/master 0a4e4a0 Peter Bushnell: [build] .gitignore add Qt Creator Makefile.am.user
< bitcoin-git> bitcoin/master e55444a fanquake: Merge #16534: build: add Qt Creator Makefile.am.user to .gitignore

2019-08-03

< emilengler> Hope it's ok to ask this question here, because I need it for Bitcoin Core development. How can I sign a commit which include squashed commits. Everytime I squash commits the "parent" commit is unsigned
< bitcoin-git> [bitcoin] mmachicao closed pull request #15137: Tests: Contract test for CCoinsView and CCoinsViewBacked (master...coins_contract_tests) https://github.com/bitcoin/bitcoin/pull/15137
< emilengler> Same with Bitcoin Core and FreeBSD for example
< achow101> fun fact, bitcoin 0.1 was released before Windows 7
< sipa> but in https://github.com/bitcoin/bitcoin/blob/v0.3.17/main.cpp you'll find direct calls from main.cpp into the UI :p
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< elichai2> btw if anyone is interested https://github.com/elichai/bitcoin/tree/2019-07-tap-desc (based on a merge between master and sipa/taproot)
< gribble> https://github.com/bitcoin/bitcoin/issues/16528 | [WIP] Native Descriptor Wallets (take 2) by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
< elichai2> yeah, but then I can import a desc and try to sign with it. but I guess i'm trying to do too much, for now i'll test manually and concentrate on adding more tests for the desc and then either ask someone to give my code a quick look (I am pretty new to bitcoin core's code and to c++) or look into PSBT/signing, but only after i'm 100% done with the desc

2019-08-02

< bitcoin-git> [bitcoin] achow101 opened pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
< ghost43> looks like the wallet and the node maximum absolute fees were recently separated: https://github.com/bitcoin/bitcoin/pull/15620
< bitcoin-git> [bitcoin] emilengler opened pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.1: https://github.com/bitcoin/bitcoin/compare/v0.18.1
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/bfa7183c4e5a...fa27a0760792
< bitcoin-git> bitcoin/0.18 fa27a07 Wladimir J. van der Laan: doc: Bump manpages pre-final
< bitcoin-git> [bitcoin] Sjors opened pull request #16539: [wallet] lower -txmaxfee default from 0.1 to 0.01 BTC (master...2019/08/lower_txmaxfee) https://github.com/bitcoin/bitcoin/pull/16539
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/673919caf72c...bfa7183c4e5a
< bitcoin-git> bitcoin/0.18 bfa7183 Wladimir J. van der Laan: build: set CLIENT_VERSION_RC to 0 pre-final
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/784e218610d4...673919caf72c
< bitcoin-git> bitcoin/0.18 5f5b444 David A. Harding: Doc: remove old release notes about systemd and riscv changes
< bitcoin-git> bitcoin/0.18 673919c Wladimir J. van der Laan: Merge #16532: [0.18] Doc: remove old release notes about systemd and riscv...
< bitcoin-git> [bitcoin] laanwj merged pull request #16532: [0.18] Doc: remove old release notes about systemd and riscv changes (0.18...2019-07-0.18.1-release-notes) https://github.com/bitcoin/bitcoin/pull/16532
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16528 | [WIP] Native Descriptor Wallets (take 2) by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub