< bitcoin-git>
[bitcoin] vasild opened pull request #18843: build: warn on potentially uninitialized reads (master...enable_Wconditional-uninitialized) https://github.com/bitcoin/bitcoin/pull/18843
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18842: wallet: Mark replaced tx to not be in the mempool anymore (master...2004-walletBumpFeeReplacedTxNoMempool) https://github.com/bitcoin/bitcoin/pull/18842
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18840: wallet: Fully process previous RPCs before accepting new ones (master...2004-walletFullyProcessRPCs) https://github.com/bitcoin/bitcoin/pull/18840
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18840: wallet: Fully process previous wallet calls before accepting new ones (master...2004-walletFullyProcessRPCs) https://github.com/bitcoin/bitcoin/pull/18840
< jonatack>
jnewbery: if this is an indicator, I'm not seeing any either... bitcoin-cli getpeerinfo | grep 'getblocks' | sort
< ariard>
we, Rust-Bitcoin ecosystem
< BlueMatt>
to, like, any real bitcoin use where you want to verify that something will be accepted, which is, largely, the point of libbitcoinconsensus as it exists today (given it cant do full verification)
< luke-jr>
I mean, if you really want to, you *could* just copy Bitcoin Core's test suite…
< luke-jr>
ariard: 1) regtest doesn't need any special setup; 2) I would expect every developer to have a full setup Bitcoin env anyway
< ariard>
luke-jr: you're asking people developping and testing higher stuff to have a full setup bitcoin env
< wumpus>
it might be more practical than linking against bitcoin core at compile time though :)
< luke-jr>
ariard: Bitcoin Core does testing this way; it works fine
< wumpus>
which makes me doubt this a bit in the first place, this function accepting your transaction only means that one version of bitcoin core accepted it at one point, it doesn't tell you about the current network
< luke-jr>
there is no "bitcoin core policy", there is "this node's policy" :/
< sipa>
if we expose a way to test policy, it is a "test things against current bitcoin core policy", not a "learn about all the things that may be wrong"
< sipa>
ariard: btw, bitcoin core internally also calls script verification twice to determine cause of failure (once with and once without standardness rules enabled)
< sipa>
i see no problem exposing a Bitcoin Core library that implements the same policies as Bitcoin Core; it's just a more convenient interface to do something you can already do with running a node
< wumpus>
yes, c-lightning depends on bitcoin core (at run time, not at build time)
< MarcoFalke>
ariard: Doesn't lightning depend on Bitcoin Core or a different full node impl anyway?
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18829: ci: Merge C++17 build with one of the existing ones (master...2004-ciSpeedupCxx17) https://github.com/bitcoin/bitcoin/pull/18829
< bitcoin-git>
bitcoin/master e5b9308 MarcoFalke: Merge #18829: ci: Merge C++17 build with one of the existing ones
< bitcoin-git>
bitcoin/master aaaacff MarcoFalke: ci: Merge C++17 build with one of the existing ones
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18829: ci: Merge C++17 build with one of the existing ones (master...2004-ciSpeedupCxx17) https://github.com/bitcoin/bitcoin/pull/18829
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18576: test: use unittest for test_framework unit testing (master...framework-unittests) https://github.com/bitcoin/bitcoin/pull/18576
< bitcoin-git>
bitcoin/master a66ba6d MarcoFalke: Merge #18576: test: use unittest for test_framework unit testing
< bitcoin-git>
bitcoin/master de8905a Gloria Zhao: test: use unittest and test_runner for test framework unit testing
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18809: rpc: Do not advertise dumptxoutset as a way to flush the chainstate (master...2004-rpcNoFlushAdvert) https://github.com/bitcoin/bitcoin/pull/18809
< bitcoin-git>
bitcoin/master 00c1a4d MarcoFalke: Merge #18809: rpc: Do not advertise dumptxoutset as a way to flush the cha...
< bitcoin-git>
bitcoin/master fac0cf6 MarcoFalke: rpc: Do not advertise dumptxoutset as a way to flush the chainstate
< bitcoin-git>
[bitcoin] rvagg opened pull request #18826: Expose txinwitness for coinbase in JSON form from RPC (master...rvagg/txinwitness-for-coinbase) https://github.com/bitcoin/bitcoin/pull/18826
< wumpus>
not something any CPU capable of running a bitcoin node in the first place will have any trouble with I guess, it's only per-incoming-connection not per packet
< vasild>
btw our current implementation https://github.com/bitcoin/bitcoin/blob/master/src/netaddress.cpp#L815 is checking all 16 bytes unnecessary - it could stop checking (break; from the loop) as soon as it finds a 0 byte in the netmask. E.g. with a netmask like /255.0.0.0 we don't need to check whether `(addr.ip[x] & netmask[x]) != network.ip[x]` is true or false for the last 3 bytes
< dongcarl>
vasild: Well, if it's acceptable to you, you should put yourself as co-author on the commits, and push as a branch to your remote on github e.g. `vaslid/bitcoin`, and I'll get those commits into my branch/PR
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18124: init: Clarify C and C++ locale assumptions. Add locale sanity checks to verify assumptions at run-time. (master...LocaleSanityCheck) https://github.com/bitcoin/bitcoin/pull/18124
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18147: qt: Kill the locale dependency bug class by not allowing Qt to mess with LC_NUMERIC (master...kill-locale-dependency-bug-class) https://github.com/bitcoin/bitcoin/pull/18147
< bitcoin-git>
[bitcoin] practicalswift closed pull request #17895: build: Enable Clang's -Wconditional-uninitialized to warn on potential uninitialized reads (master...continue-killing-of-uninitialized-reads) https://github.com/bitcoin/bitcoin/pull/17895
< bitcoin-git>
[bitcoin] rebroad closed pull request #18760: Disconnect nodes with bad messages during IBD (master...IBDDisconnectBadChecksum) https://github.com/bitcoin/bitcoin/pull/18760
< bitcoin-git>
[bitcoin] promag opened pull request #18814: rpc: Relock wallet only if most recent callback (master...2020-04-rpc-wallet-relock) https://github.com/bitcoin/bitcoin/pull/18814
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18809: rpc: Do not advertise dumptxoutset as a way to flush the chainstate (master...2004-rpcNoFlushAdvert) https://github.com/bitcoin/bitcoin/pull/18809
< bitcoin-git>
[bitcoin] jnewbery opened pull request #18808: [net processing] Drop unknown types in getdata (master...2020-04-getdata) https://github.com/bitcoin/bitcoin/pull/18808
< bitcoin-git>
[bitcoin] achow101 closed pull request #18655: gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior (master...split-bumpfeeaction) https://github.com/bitcoin/bitcoin/pull/18655
< bitcoin-git>
[bitcoin] achow101 closed pull request #18656: gui: Add a `Make unsigned` button next to `Send` (master...make-unsigned-button) https://github.com/bitcoin/bitcoin/pull/18656
< bitcoin-git>
[bitcoin] achow101 opened pull request #18789: qt: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin/bitcoin/pull/18789
< bitcoin-git>
[bitcoin] achow101 opened pull request #18788: wallet: tests: Update more tests to work with descriptor wallets (master...desc-wallet-tests) https://github.com/bitcoin/bitcoin/pull/18788
< bitcoin-git>
[bitcoin] achow101 opened pull request #18787: wallet: descriptor wallet release notes and cleanups (master...desc-wallet-followup) https://github.com/bitcoin/bitcoin/pull/18787
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18786: init: Remove boost from ThreadImport (master...2004-noBoostInitThreadImport) https://github.com/bitcoin/bitcoin/pull/18786
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #18785: Prevent valgrind false positive in rest_blockhash_by_height (master...pr/grind) https://github.com/bitcoin/bitcoin/pull/18785
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18784: net: RecordBytesSent under cs_vSend lock (master...2004-netLockRecordBytesSent) https://github.com/bitcoin/bitcoin/pull/18784
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18783: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h (master...fuzzers-message) https://github.com/bitcoin/bitcoin/pull/18783
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction (master...uninitialized-members) https://github.com/bitcoin/bitcoin/pull/18782
< bitcoin-git>
[bitcoin] fanquake closed pull request #17822: refactor: Use uint16_t instead of unsigned short (master...akh_uint16_t) https://github.com/bitcoin/bitcoin/pull/17822
< bitcoin-git>
[bitcoin] robot-visions opened pull request #18772: rpc: calculate fee in getblock using BlockUndo data (master...getblock-fee) https://github.com/bitcoin/bitcoin/pull/18772
2020-04-25
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18770: test: Remove raw-tx byte juggling in mempool_reorg (master...2004-testNoRawBytes) https://github.com/bitcoin/bitcoin/pull/18770
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #18769: qt: todo - remove bug fix for old versions of Qt (master...pr_qt_remove_todo) https://github.com/bitcoin/bitcoin/pull/18769
< bitcoin-git>
[bitcoin] darosior opened pull request #18766: Disable fee estimation in blocksonly mode (master...disable_feeest_blocksonly) https://github.com/bitcoin/bitcoin/pull/18766