2021-04-15

< bitcoin-git> [bitcoin] jonatack closed pull request #21696: DONOTMERGE test: drop cnetaddr link-local assert for macOS 10.14 to re-verify CI (master...cnetaddr-link-local-test-1) https://github.com/bitcoin/bitcoin/pull/21696
< bitcoin-git> [bitcoin] achow101 opened pull request #21701: [0.2] Speedy trial activation for Taproot (0.21...0.21-taproot-st) https://github.com/bitcoin/bitcoin/pull/21701
< kallewoof> luke-jr: You mean like https://github.com/bitcoin/bips/pull/1015 ? I don't have a preference personally.
< kallewoof> speaking of revisions of BIPs, it would be splendid if https://github.com/bitcoin/bips/pull/1016 moved forward.
< bitcoin-git> [bitcoin] luke-jr closed pull request #19573: Replace unused BIP 9 logic with draft BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573
< bitcoin-git> [bitcoin] vasild opened pull request #21700: net: expand Sock and fuzz-test more of CConnman (master...Sock_expand) https://github.com/bitcoin/bitcoin/pull/21700
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19573: Replace unused BIP 9 logic with draft BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573
< michaelfolkson> Anyone know the rationale for moving the start time a week earlier (April 24th) than Russell originally proposed (May 1st)? https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-March/018594.html
< vasild> ah, yes, travis is no longer, but I have free cirrus account for open source and linked it to https://github.com/vasild/bitcoin
< vasild> I am using my personal fork at https://github.com/vasild/bitcoin/pull/4/ for CI "experiments"
< gribble> https://github.com/bitcoin/bitcoin/issues/21690 | test: use higher value in cnetaddr_basic link-local test by jonatack · Pull Request #21690 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #21697: DONOTMERGE test: drop cnetaddr link-local assert for all CIs except macOS 10.14 (master...cnetaddr-link-local-test-2) https://github.com/bitcoin/bitcoin/pull/21697
< bitcoin-git> [bitcoin] jonatack opened pull request #21697: DONOTMERGE test: drop cnetaddr link-local assert for all CIs except macOS 10.14 (master...cnetaddr-link-local-test-2) https://github.com/bitcoin/bitcoin/pull/21697
< bitcoin-git> [bitcoin] jonatack opened pull request #21696: DONOTMERGE test: drop cnetaddr link-local assert for macOS 10.14 to re-verify CI (master...cnetaddr-link-local-test-1) https://github.com/bitcoin/bitcoin/pull/21696
< bitcoin-git> [bitcoin] hebasto opened pull request #21695: Remove no longer used contrib/bitcoin-qt.pro from the repo (master...210415-pro) https://github.com/bitcoin/bitcoin/pull/21695
< bitcoin-git> [bitcoin] hebasto opened pull request #21694: build: Use XLIFF file to provide more context to Transifex translators (master...210415-xliff) https://github.com/bitcoin/bitcoin/pull/21694
< hebasto> wumpus: I cannot see any way how the `contrib/bitcoin-qt.pro` is used in the translation process, neither in the main repo nor in https://github.com/bitcoin-core/bitcoin-maintainer-tools. Besides it looks outdated and unmaintained. May I ask you to confirm/deny my assumption?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21630: fuzz: split FuzzedSock interface and implementation (master...FuzzedSock_move) https://github.com/bitcoin/bitcoin/pull/21630
< bitcoin-git> bitcoin/master 0c90ff1 Vasil Dimov: fuzz: set errno from FuzzedSock::Wait() if it simulates a failure
< bitcoin-git> bitcoin/master 9668e43 Vasil Dimov: fuzz: make FuzzedSock::Wait() sometimes simulate an occurred event
< bitcoin-git> bitcoin/master 5198a02 Vasil Dimov: style: remove extra white space
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/7cb0bcb68110...c6b30ccb2eee
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21686: Speedy trial activation parameters for Taproot (master...taproot-mtp-st-params) https://github.com/bitcoin/bitcoin/pull/21686
< bitcoin-git> bitcoin/master 7cb0bcb MarcoFalke: Merge #21686: Speedy trial activation parameters for Taproot
< bitcoin-git> bitcoin/master f979b32 Andrew Chow: Add mainnet and testnet taproot activation params
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a5e756b74e18...7cb0bcb68110
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21676: test: Use mocktime to avoid intermittent failure in rpc_tests (master...2104-testFixMocktime) https://github.com/bitcoin/bitcoin/pull/21676
< bitcoin-git> bitcoin/master a5e756b MarcoFalke: Merge #21676: test: Use mocktime to avoid intermittent failure in rpc_test...
< bitcoin-git> bitcoin/master fa40d6a MarcoFalke: test: Reset mocktime in the common setup
< bitcoin-git> bitcoin/master fa78590 MarcoFalke: test: Use mocktime to avoid intermittent failure
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9712f75746e3...a5e756b74e18
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21691: test: Check that no versionbits are re-used (master...2104-testVersionbits) https://github.com/bitcoin/bitcoin/pull/21691
< bitcoin-git> [bitcoin] jonatack opened pull request #21690: test: use higher value in cnetaddr_basic link-local test (master...cnetaddr-link-local-test) https://github.com/bitcoin/bitcoin/pull/21690
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21392 | Implement BIP 8 based Speedy Trial activation by achow101 · Pull Request #21392 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #21689: test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in `cnetaddr_basic` (master...remove-intermittently-failing-and-largely-meaningless-ipv6-test) https://github.com/bitcoin/bitcoin/pull/21689
< gribble> https://github.com/bitcoin/bitcoin/issues/21614 | [0.21] test: Backports by MarcoFalke · Pull Request #21614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21686 | Speedy trial activation parameters for Taproot by achow101 · Pull Request #21686 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto closed pull request #21680: test: Use called_from_lib to point uninstrumented libs to TSan (master...210414-tsan) https://github.com/bitcoin/bitcoin/pull/21680
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21677: fuzz: Avoid use of low file descriptor ids (which may be in use) in FuzzedSock (master...avoid-open-fds-when-fuzzing) https://github.com/bitcoin/bitcoin/pull/21677
< bitcoin-git> bitcoin/master 9712f75 MarcoFalke: Merge #21677: fuzz: Avoid use of low file descriptor ids (which may be in ...
< bitcoin-git> bitcoin/master 6262182 practicalswift: Avoid use of low file descriptor ids (which may be in use) in FuzzedSock a...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2cd834e6c09d...9712f75746e3
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20558: test: Add MaybeCompactWalletDB tsan suppression (take 2) (master...2012-testSanTsan) https://github.com/bitcoin/bitcoin/pull/20558
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19573: Replace unused BIP 9 logic with draft BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573
< bitcoin-git> [bitcoin] jarolrod opened pull request #21688: doc: note on SDK for macOS depends cross-compile (master...depends-note-sdk) https://github.com/bitcoin/bitcoin/pull/21688
< bitcoin-git> [bitcoin] am33r opened pull request #21687: 1IP per-connection policy (master...ameer_prevent_duplicate_connections_from_same_ip) https://github.com/bitcoin/bitcoin/pull/21687
< bitcoin-git> [bitcoin] achow101 opened pull request #21686: Speedy trial activation parameters for Taproot (master...taproot-mtp-st-params) https://github.com/bitcoin/bitcoin/pull/21686
< bitcoin-git> [bitcoin] fanquake merged pull request #21377: Speedy trial support for versionbits (master...202103-bip9-speedy-trial-support) https://github.com/bitcoin/bitcoin/pull/21377
< bitcoin-git> bitcoin/master 9e6b65f Anthony Towns: tests: clean up versionbits test
< bitcoin-git> bitcoin/master 5932744 Anthony Towns: tests: test ComputeBlockVersion for all deployments
< bitcoin-git> bitcoin/master 63879f0 Anthony Towns: tests: pull ComputeBlockVersion test into its own function
< bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/7fcf53f7b452...2cd834e6c09d
< bitcoin-git> [bitcoin] fanquake merged pull request #21672: doc: remove boostrap info from GUIX_COMMON_FLAGS doc (master...fixup_guix_options) https://github.com/bitcoin/bitcoin/pull/21672
< bitcoin-git> bitcoin/master 7fcf53f fanquake: Merge #21672: doc: remove boostrap info from GUIX_COMMON_FLAGS doc
< bitcoin-git> bitcoin/master 09b3e46 fanquake: doc: remove boostrap info from GUIX_COMMON_FLAGS doc
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/773f8c1a7d56...7fcf53f7b452

2021-04-14

< amiti> kanzure: it was very odd, my email address wouldn't subscribe to bitcoin-dev, so per ReubenSomsen's suggestion we debugged by using bitcoin-discuss
< kanzure> amiti: also you may have sent to bitcoin-discuss instead of bitcoin-dev
< gribble> https://github.com/bitcoin/bitcoin/issues/21603 | log: Mitigate disk filling attacks by rate limiting LogPrintf by dergoegge · Pull Request #21603 · bitcoin/bitcoin · GitHub
< amiti> is anyone here admin for the bitcoin-dev mailing list? I've been trying to send an email and struggling :(
< wumpus> it is supposed to do Merge bitcoin-core/gui#266
< gribble> https://github.com/bitcoin/bitcoin/issues/266 | Backport to wx2.8 and dynamically link most libs. by TheBlueMatt · Pull Request #266 · bitcoin/bitcoin · GitHub
< wumpus> it links to the GUI repo: https://github.com/bitcoin-core/gui/pull/260
< gribble> https://github.com/bitcoin/bitcoin/issues/260 | Add esperanto translation. by TheBlueMatt · Pull Request #260 · bitcoin/bitcoin · GitHub
< da2ce7_> wumpus: "<bitcoin-git> [gui] laanwj merged pull request #260: Handle exceptions instead of crash (master...210326-ex) https://github.com/bitcoin-core/gui/pull/260" the merge script seems to have a bug...
< jonasschnelli> #proposedmeetingtopic short info/update on the "Bitcoin Core Code Signing Association" status.
< BlueMatt> plus voskuil *normally* disagrees very strongly on bitcoin fork activation stuff, so him agreeing is a pretty good "did we even slightly screw this up" check
< gribble> https://github.com/bitcoin/bitcoin/issues/21392 | Implement BIP 8 based Speedy Trial activation by achow101 · Pull Request #21392 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< luke-jr> jeremyrubin: literally everywhere people talk about Bitcoin/Taproot/activation
< bitcoin-git> [bitcoin] jamesob opened pull request #21681: validation: fix ActivateSnapshot to use hardcoded nChainTx (master...2021-04-au-nchaintx-fix) https://github.com/bitcoin/bitcoin/pull/21681
< michaelfolkson> AJ is literally only one opposing consistent use of block height https://github.com/bitcoin/bitcoin/pull/21377#issuecomment-818758277
< luke-jr> 21377 would make Core an enemy of Bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] jarolrod opened pull request #281: qt: set shortcuts for console's resize buttons (master...mul-shortcuts-resize) https://github.com/bitcoin-core/gui/pull/281
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21678: test: Fix TestPotentialDeadLockDetected suppression (master...210414-deadlock) https://github.com/bitcoin/bitcoin/pull/21678
< bitcoin-git> bitcoin/master 773f8c1 MarcoFalke: Merge #21678: test: Fix TestPotentialDeadLockDetected suppression
< bitcoin-git> bitcoin/master f2ef5a8 Hennadii Stepanov: test: Fix TSan suppression
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c867ed4ec6c...773f8c1a7d56
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21675: ci: Only cache depends/sdk-sources for macos/apk task in cirrus (master...2104-ciSdkMacosOnly) https://github.com/bitcoin/bitcoin/pull/21675
< bitcoin-git> bitcoin/master 8c867ed MarcoFalke: Merge #21675: ci: Only cache depends/sdk-sources for macos/apk task in cir...
< bitcoin-git> bitcoin/master 11115c8 MarcoFalke: ci: Only cache depends/sdk-sources for macos/apk task in cirrus
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a12962ca8940...8c867ed4ec6c
< _Sam--> Hi I just wanted to say thank you for doing all that work to make bitcoin. I appreciate you. I sit around and don't do anything, and make money just because of the work you did. Thanks dudes/girls. Have a nice day.
< gribble> https://github.com/bitcoin/bitcoin/issues/21422 | Add feerate histogram to getmempoolinfo by kiminuo · Pull Request #21422 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #21680: test: Use called_from_lib to point uninstrumented libs to TSan (master...210414-tsan) https://github.com/bitcoin/bitcoin/pull/21680
< Kiminuo> Hi, I'm working on https://github.com/bitcoin/bitcoin/pull/21422. Would you mind saying "concept ACK" if you find it useful?
< bitcoin-git> [bitcoin] promag opened pull request #21679: rpc: Keep default argument value in correct type (master...2021-04-rpc-defaults) https://github.com/bitcoin/bitcoin/pull/21679
< prayank> harding: Request you to review this PR: https://github.com/bitcoin/bitcoin/pull/21157
< bitcoin-git> bitcoin/master a12962c MarcoFalke: Merge #21585: Fix assumeutxo crash due to truncated file
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21585: Fix assumeutxo crash due to truncated file (master...2104-assumeutxoCrash03) https://github.com/bitcoin/bitcoin/pull/21585
< bitcoin-git> bitcoin/master fa73ce6 MarcoFalke: Fix assumeutxo crash due to truncated file
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03ecceedf6f1...a12962ca8940
< bitcoin-git> [bitcoin] jnewbery closed pull request #21533: mining: Remove unused extranonce logic (master...2021-03-extra-nonce) https://github.com/bitcoin/bitcoin/pull/21533
< bitcoin-git> bitcoin/master f7e260a Hennadii Stepanov: qt: Add GUIUtil::ExceptionSafeConnect function
< bitcoin-git> bitcoin/master 64a8755 Hennadii Stepanov: qt: Add BitcoinApplication::handleNonFatalException function
< bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/b8e5bbdf93e5...03ecceedf6f1
< bitcoin-git> bitcoin/master af7e365 Hennadii Stepanov: qt: Make PACKAGE_BUGREPORT link clickable
< bitcoin-git> [gui] laanwj merged pull request #260: Handle exceptions instead of crash (master...210326-ex) https://github.com/bitcoin-core/gui/pull/260
< bitcoin-git> [bitcoin] hebasto opened pull request #21678: test: Fix TSan suppression (master...210414-deadlock) https://github.com/bitcoin/bitcoin/pull/21678
< bitcoin-git> [bitcoin] practicalswift opened pull request #21677: fuzz: Avoid use of low file descriptor ids (which may be in use) in FuzzedSock (master...avoid-open-fds-when-fuzzing) https://github.com/bitcoin/bitcoin/pull/21677
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21676: test: Use mocktime to avoid intermittent failure in rpc_tests (master...2104-testFixMocktime) https://github.com/bitcoin/bitcoin/pull/21676
< bitcoin-git> [bitcoin] vasild closed pull request #21668: net: properly handle PF_NOBAN in CConnman::Bind() (master...fix_pf_noban_usage) https://github.com/bitcoin/bitcoin/pull/21668
< bitcoin-git> bitcoin/master b8e5bbd MarcoFalke: Merge #21669: test: Remove spurious double lock tsan suppressions by bumpi...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21669: test: Remove spurious double lock tsan suppressions by bumping to clang-12 (master...2104-tsanSupp) https://github.com/bitcoin/bitcoin/pull/21669
< bitcoin-git> bitcoin/master fadea0b MarcoFalke: Revert "test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles"
< bitcoin-git> bitcoin/master fadbd99 MarcoFalke: test: Remove spurious double lock tsan suppressions by bumping to clang-12
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e7af2f35af95...b8e5bbdf93e5
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21675: ci: Only cache depends/sdk-sources for macos task in cirrus (master...2104-ciSdkMacosOnly) https://github.com/bitcoin/bitcoin/pull/21675
< bitcoin-git> [bitcoin] fanquake merged pull request #21666: Miscellaneous external signer changes (master...external_signer_followups) https://github.com/bitcoin/bitcoin/pull/21666
< bitcoin-git> bitcoin/master 8fdbb89 fanquake: refactor: unify external wallet runtime errors
< bitcoin-git> bitcoin/master f4652bf fanquake: refactor: add missing includes to external signer code
< bitcoin-git> bitcoin/master 54569cc fanquake: refactor: move all signer code inside ENABLE_EXTERNAL_SIGNER #ifdefs
< bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a1f0b8b62eb8...e7af2f35af95
< bitcoin-git> [bitcoin] fanquake opened pull request #21672: doc: remove boostrap info from GUIX_COMMON_FLAGS doc (master...fixup_guix_options) https://github.com/bitcoin/bitcoin/pull/21672

2021-04-13

< bitcoin-git> [gui] prayank23 opened pull request #280: Remove user input from URI error message (master...uri-error) https://github.com/bitcoin-core/gui/pull/280
< sipa> you don't need to do anything in general; bitcoin core will try to make connections to the network automatically
< GarouDan> Thanks for these suggestions (#bitcoin or on https://bitcoin.stackexchange.com), I'll try to reach these options later as well, for future interactions
< sipa> this isn't a helpdesk though; perhaps try asking in #bitcoin or on https://bitcoin.stackexchange.com
< GarouDan> The current error is: 'Bitcoin Core is not connected!'
< bitcoin-git> [bitcoin] dongcarl opened pull request #21671: guix: Always canonicalize HOST using `./depends/config.sub` (master...2021-03-guix-canonicalization-HOST) https://github.com/bitcoin/bitcoin/pull/21671
< jeremyrubin> wumpus: who owns the Bitcoin Core wordmark and how is it's use governed?
< bitcoin-git> [bitcoin] rebroad reopened pull request #21618: WIP: Reduce MinRelayFee slower when Mempool utilised and faster when needed. (master...MinRelayFeeReductionChanges) https://github.com/bitcoin/bitcoin/pull/21618
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21669: test: Remove spurious double lock tsan suppressions by bumping to clang-12 (master...2104-tsanSupp) https://github.com/bitcoin/bitcoin/pull/21669
< bitcoin-git> [bitcoin] vasild opened pull request #21668: net: properly handle PF_NOBAN in CConnman::Bind() (master...fix_pf_noban_usage) https://github.com/bitcoin/bitcoin/pull/21668
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21634: tests: Skip SQLite fsyncs while testing (master...optimize-sqlite) https://github.com/bitcoin/bitcoin/pull/21634
< bitcoin-git> bitcoin/master a1f0b8b MarcoFalke: Merge #21634: tests: Skip SQLite fsyncs while testing
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f14130cb077...a1f0b8b62eb8
< bitcoin-git> bitcoin/master 41f891d Andrew Chow: tests: Skip SQLite fsyncs while testing
< bitcoin-git> [bitcoin] hebasto opened pull request #21667: build: Add -Werror=missing-noreturn (master...210413-external) https://github.com/bitcoin/bitcoin/pull/21667
< bitcoin-git> bitcoin/master fa91b2b MarcoFalke: move-only: Move AbortNode to shutdown
< bitcoin-git> [bitcoin] fanquake merged pull request #21575: refactor: Create blockstorage module (master...2104-blockstorage) https://github.com/bitcoin/bitcoin/pull/21575
< bitcoin-git> bitcoin/master fa413f0 MarcoFalke: move-only: Move ThreadImport to blockstorage
< bitcoin-git> bitcoin/master faf843c MarcoFalke: refactor: Move load block thread into ChainstateManager
< bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/88331aa8a762...1f14130cb077
< bitcoin-git> [bitcoin] fanquake merged pull request #21633: refactor: add [[noreturn]] attribute where applicable (master...build_with_noreturn) https://github.com/bitcoin/bitcoin/pull/21633
< bitcoin-git> bitcoin/master 88331aa fanquake: Merge #21633: refactor: add [[noreturn]] attribute where applicable
< bitcoin-git> bitcoin/master 003929c fanquake: refactor: add [[noreturn]] attribute where applicable
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3aa4935db722...88331aa8a762
< bitcoin-git> [bitcoin] fanquake merged pull request #17934: doc: Use CONFIG_SITE variable instead of --prefix option (master...20200115-prefix-depends) https://github.com/bitcoin/bitcoin/pull/17934
< bitcoin-git> bitcoin/master 3aa4935 fanquake: Merge #17934: doc: Use CONFIG_SITE variable instead of --prefix option
< bitcoin-git> bitcoin/master 223b1ba Hennadii Stepanov: doc: Use CONFIG_SITE instead of --prefix
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1f480fb2348...3aa4935db722
< bitcoin-git> [bitcoin] fanquake opened pull request #21666: Miscellaneous external signer changes (master...external_signer_followups) https://github.com/bitcoin/bitcoin/pull/21666
< wumpus> after the so-manieth spat with Cobra i was sick of it, no idea if it will continue hosting bitcoin core binaries at all, but i'm no longer going to upload them
< wumpus> i do not have access to bitcoin.org anymore
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21653: ci: Fix previous releases cache order (master...2104-ciFixCacheOrder) https://github.com/bitcoin/bitcoin/pull/21653
< bitcoin-git> bitcoin/master c1f480f MarcoFalke: Merge #21653: ci: Fix previous releases cache order
< bitcoin-git> bitcoin/master fa4f0b3 MarcoFalke: ci: Fix previous releases cache order
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0b457212f98...c1f480fb2348
< bitcoin-git> [bitcoin] fanquake closed pull request #21665: Update .gitignore (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21665
< bitcoin-git> [bitcoin] nha1012 opened pull request #21665: Update .gitignore (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21665
< bitcoin-git> [bitcoin] fanquake merged pull request #21467: Move external signer out of wallet module (master...2021/03/signer_no_wallet) https://github.com/bitcoin/bitcoin/pull/21467
< bitcoin-git> bitcoin/master 88d4d5f Sjors Provoost: rpc: add help for enumeratesigners and walletdisplayaddress
< bitcoin-git> bitcoin/master b0db187 Sjors Provoost: ci: use --enable-external-signer instead of --with-boost-process
< bitcoin-git> bitcoin/master b54b2e7 Sjors Provoost: Move external signer out of wallet module
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1f50f0bb389a...f0b457212f98
< harding> wumpus: (re achow101's comment above) if you push the -unsigned.exe binary to Bitcoin.org, I think this should be the only change necessary for the website. https://github.com/bitcoin-dot-org/Bitcoin.org/compare/master...harding:2021-04-unsigned-url?expand=1 I don't have a dev environment setup for Bitcoin.org, so it's untested.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21631: i2p: always check the return value of Sock::Wait() (master...SockWait_usage_fix) https://github.com/bitcoin/bitcoin/pull/21631
< bitcoin-git> bitcoin/master 1f50f0b MarcoFalke: Merge #21631: i2p: always check the return value of Sock::Wait()
< bitcoin-git> bitcoin/master 1c1467f Vasil Dimov: i2p: cancel the Accept() method if waiting on the socket errors
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd65a76b9d97...1f50f0bb389a
< achow101> harding: wumpus: can you make the same change to bitcoin.org that was done for bitcoincore.org to redirect users to download the 0.21-win-unsigned.exe? I'm seeing several users posting issues there about that.
< bitcoin-git> [bitcoin] fanquake opened pull request #21664: contrib: use LIEF for macOS and Windows symbol & security checks (master...macos_win_lief) https://github.com/bitcoin/bitcoin/pull/21664
< bitcoin-git> [bitcoin] fanquake merged pull request #21330: Deal with missing data in signature hashes more consistently (master...202103_missing_data_verify) https://github.com/bitcoin/bitcoin/pull/21330
< bitcoin-git> bitcoin/master 497718b Pieter Wuille: Treat amount<0 also as missing data for P2WPKH/P2WSH
< bitcoin-git> bitcoin/master 3820090 Pieter Wuille: Make all SignatureChecker explicit about missing data
< bitcoin-git> bitcoin/master b77b0cc Pieter Wuille: Add MissingDataBehavior and make TransactionSignatureChecker handle it
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/89b72ce045b5...bd65a76b9d97
< bitcoin-git> [bitcoin] fanquake merged pull request #21661: doc: Fix name of script guix-build (master...patch-2) https://github.com/bitcoin/bitcoin/pull/21661
< bitcoin-git> bitcoin/master 89b72ce fanquake: Merge #21661: doc: Fix name of script guix-build
< bitcoin-git> bitcoin/master 08151e1 Stephan Oeste: doc: Fix name of script guix-build
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/708517b2dd64...89b72ce045b5

2021-04-12

< bitcoin-git> [bitcoin] laanwj merged pull request #21663: ci: Fix macOS brew install command (master...210412-brew) https://github.com/bitcoin/bitcoin/pull/21663
< bitcoin-git> bitcoin/master 708517b W. J. van der Laan: Merge #21663: ci: Fix macOS brew install command
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f6c44e999b7d...708517b2dd64
< bitcoin-git> bitcoin/master b738155 Hennadii Stepanov: ci: Fix macOS brew install command
< gribble> https://github.com/bitcoin/bitcoin/issues/21663 | ci: Fix macOS brew install command by hebasto · Pull Request #21663 · bitcoin/bitcoin · GitHub
< jamesob> Anyone seen these 403 forbidden errors during CI runs before? https://github.com/bitcoin/bitcoin/pull/21526/checks?check_run_id=2327358485
< jakesyl> yeah - on btcd think we'll just match the bitcoin-core rpc interface there
< gribble> https://github.com/bitcoin/bitcoin/issues/21663 | ci: Fix macOS brew install command by hebasto · Pull Request #21663 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #21663: ci: Fix macOS brew install command (master...210412-brew) https://github.com/bitcoin/bitcoin/pull/21663
< bitcoin-git> [bitcoin] fdoving opened pull request #21662: build,boost: update download url. (master...fdov-boost-url) https://github.com/bitcoin/bitcoin/pull/21662
< bitcoin-git> [bitcoin] Emzy opened pull request #21661: doc: Fix name of script guix-build (master...patch-2) https://github.com/bitcoin/bitcoin/pull/21661
< bitcoin-git> [bitcoin] vasild opened pull request #21659: net: flag relevant Sock methods with [[nodiscard]] (master...Sock_nodiscard) https://github.com/bitcoin/bitcoin/pull/21659
< bitcoin-git> [bitcoin] AlbanAndrieu closed pull request #21646: -daemonwait change to -daemon (master...master) https://github.com/bitcoin/bitcoin/pull/21646
< bitcoin-git> [bitcoin] fanquake closed pull request #19242: Add -uaappend option to append a literal string to user agent (master...uaappend) https://github.com/bitcoin/bitcoin/pull/19242
< bitcoin-git> [bitcoin] hebasto reopened pull request #21591: build, qt: Fix wrong cross-compiling detection on macOS (master...210403-cross) https://github.com/bitcoin/bitcoin/pull/21591
< bitcoin-git> [bitcoin] hebasto closed pull request #21591: build, qt: Fix wrong cross-compiling detection on macOS (master...210403-cross) https://github.com/bitcoin/bitcoin/pull/21591
< instagibbs> someone ban chew917 here https://github.com/bitcoin/bitcoin/pull/21464
< jarthur> Looks like it was only Bitcoin Core 0.9.1 $file bitcoin-0.9.1-linux/bin/64/bitcoind.static
< jarthur> bitcoin-0.9.1-linux/bin/64/bitcoind.static: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, for GNU/Linux 2.6.24, BuildID[sha1]=8b02de16c470e9de817d6c551325517d2ad16a05, stripped
< jarthur> I believe 0.9.1 and possibly 0.9.2 distributables had binaries with statically linked glibc. Can't check now though as bitcoin.org took them down for security reasons.
< jarthur> Just tried the release binary, is dynamically linked to libc unfortunately. It looks like it stopped being fully static after this: https://github.com/bitcoin/bitcoin/pull/4042
< jarthur> I see other projects have added a custom --enable-static-exec or --fully-static ./configure args, so maybe --enable-static means you only get static libbitcoin and libtest. Also tried adding --disable-shared without luck. I'll see if I can whip something up from older gitian when it built a static bitcoin core distributable.
< jarthur> Maybe I don't either. jgarzik hinted it ought to do what I'm trying to do in this comment https://github.com/bitcoin/bitcoin/issues/3781#issuecomment-36507746
< bitcoin-git> [bitcoin] fanquake merged pull request #21640: [0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it (0.21...0.21-sig-ext) https://github.com/bitcoin/bitcoin/pull/21640
< bitcoin-git> bitcoin/0.21 e358b43 fanquake: Merge #21640: [0.21] Introduce DeferredSignatureChecker and have Signature...
< bitcoin-git> bitcoin/0.21 f79189c Andrew Chow: Test that signrawtx works when a signed CSV and CLTV inputs are present
< bitcoin-git> bitcoin/0.21 7de019b Andrew Chow: Introduce DeferringSignatureChecker and inherit with SignatureExtractor
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/0b9a046c1ae0...e358b43f7d89

2021-04-11

< bitcoin-git> [bitcoin] sgulls opened pull request #21658: build: fix make deploy for arm64-darwin (master...master) https://github.com/bitcoin/bitcoin/pull/21658
< bitcoin-git> [bitcoin] sgulls closed pull request #21555: build: fix make deploy for arm64-darwin (master...master) https://github.com/bitcoin/bitcoin/pull/21555
< bitcoin-git> [bitcoin] hebasto reopened pull request #21551: [PoC] ci: Add Windows task to Cirrus CI (master...210330-cirrus) https://github.com/bitcoin/bitcoin/pull/21551
< bitcoin-git> [bitcoin] hebasto closed pull request #21656: Pull3 (master...master) https://github.com/bitcoin/bitcoin/pull/21656
< bitcoin-git> [bitcoin] RonSherfey opened pull request #21656: Pull3 (master...master) https://github.com/bitcoin/bitcoin/pull/21656
< bitcoin-git> [bitcoin] fjahr closed pull request #19544: refactor: Add ParseBool to rpc/util (master...rpc_bool) https://github.com/bitcoin/bitcoin/pull/19544
< bitcoin-git> [bitcoin] hebasto opened pull request #21655: build, qt: No longer need to set QT_RCC_TEST=1 for determinism (master...210411-qhash) https://github.com/bitcoin/bitcoin/pull/21655
< bitcoin-git> [bitcoin] prayank23 reopened pull request #21157: doc: Improve Tor docs (master...tor-docs-add) https://github.com/bitcoin/bitcoin/pull/21157
< bitcoin-git> [bitcoin] hebasto opened pull request #21654: build: Move QT_RCC_SOURCE_DATE_OVERRIDE=1 into the Makefile (master...210411-rcc) https://github.com/bitcoin/bitcoin/pull/21654
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21653: ci: Fix previous releases cache order (master...2104-ciFixCacheOrder) https://github.com/bitcoin/bitcoin/pull/21653
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21602: rpc: add additional ban time fields to listbanned (master...ban-time-info) https://github.com/bitcoin/bitcoin/pull/21602
< bitcoin-git> bitcoin/master 5456b34 Jarol Rodriguez: rpc: add ban_duration field to listbanned
< bitcoin-git> bitcoin/master c95c616 Jarol Rodriguez: doc: improve listbanned help
< bitcoin-git> bitcoin/master dd3c8ea Jarol Rodriguez: rpc: swap position of banned_until and ban_created fields
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/1e3db6807d18...f6c44e999b7d
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21652: [WIP NOMERGE DRAFT] ci: Switch more tasks to self-hosted (master...2104-ciMoreSelf) https://github.com/bitcoin/bitcoin/pull/21652
< bitcoin-git> [bitcoin] hebasto closed pull request #21551: [PoC] ci: Add Windows task to Cirrus CI (master...210330-cirrus) https://github.com/bitcoin/bitcoin/pull/21551
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21619: ci: Run self-hosted ci (master...2103-ciSelfHosted) https://github.com/bitcoin/bitcoin/pull/21619
< bitcoin-git> bitcoin/master fa52a40 MarcoFalke: ci: Make cirrus cache folders relative to cirrus base dir
< bitcoin-git> bitcoin/master fa27841 MarcoFalke: ci: Restart docker before run
< bitcoin-git> bitcoin/master fad4f48 MarcoFalke: ci: [refactor] Create setting for ephemeral config in .cirrus.yml
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/dd01dc6a1d23...1e3db6807d18
< bitcoin-git> [bitcoin] fanquake merged pull request #21643: Ignore guix builds (master...210409-ignore) https://github.com/bitcoin/bitcoin/pull/21643
< bitcoin-git> bitcoin/master dd01dc6 fanquake: Merge #21643: Ignore guix builds
< bitcoin-git> bitcoin/master 8e84c18 Hennadii Stepanov: Ignore guix builds
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0fa32450ec3...dd01dc6a1d23

2021-04-10

< bitcoin-git> [gui] hebasto opened pull request #277: Do not use QClipboard::Selection on Windows and macOS. (master...210410-clip) https://github.com/bitcoin-core/gui/pull/277
< bitcoin-git> [gui] hebasto opened pull request #276: Elide long strings in their middle in the Peers tab (master...210410-elide) https://github.com/bitcoin-core/gui/pull/276
< bitcoin-git> [bitcoin] rebroad closed pull request #21618: WIP: Reduce MinRelayFee slower when Mempool utilised and faster when needed. (master...MinRelayFeeReductionChanges) https://github.com/bitcoin/bitcoin/pull/21618

2021-04-09

< bitcoin-git> [bitcoin] jonatack opened pull request #21644: net: use NetPermissions::HasFlag() in CConnman::Bind() (master...NetPermissionFlags-noban-bugfix) https://github.com/bitcoin/bitcoin/pull/21644
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21238 | A few descriptor improvements to prepare for Taproot support by sipa · Pull Request #21238 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
< achow101> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag
< core-meetingbot> Meeting started Fri Apr 9 19:03:19 2021 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< gribble> https://github.com/bitcoin/bitcoin/issues/21634 | tests: Skip SQLite fsyncs while testing by achow101 · Pull Request #21634 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21606: fuzz: Extend psbt fuzz target a bit (master...2104-fuzzPsbt) https://github.com/bitcoin/bitcoin/pull/21606
< bitcoin-git> bitcoin/master f0fa324 MarcoFalke: Merge #21606: fuzz: Extend psbt fuzz target a bit
< bitcoin-git> bitcoin/master faaf395 MarcoFalke: fuzz: Extend psbt fuzz target a bit
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4ad83a9597e4...f0fa32450ec3
< bitcoin-git> [bitcoin] hebasto opened pull request #21643: Ignore guix builds (master...210409-ignore) https://github.com/bitcoin/bitcoin/pull/21643
< Kiminuo> hebasto, but the same error is also here: https://github.com/bitcoin/bitcoin/pull/21244/checks?check_run_id=2305328000
< Kiminuo> How can I make my build to fail as this fail: https://github.com/bitcoin/bitcoin/pull/21244/checks?check_run_id=2305327996, please?
< wumpus> (of course, if you use a client-side tool like bitcoin-maintainer-tools's ghwatch to watch notifications, it's possible to do any kind of filterint you want)
< jnewbery> has anyone found a way to suppress github notifications of other projects merging bitcoin core commits that have your github handle in? I seem to get notifications almost every day of some randomcoin merging commits that happen to have my handle in the commit message.
< bitcoin-git> [gui] hebasto closed pull request #274: [PoC] [do not merge]: Support runtime appearance adjustment on macOS (master...210407-dark-poc) https://github.com/bitcoin-core/gui/pull/274
< bitcoin-git> [gui] hebasto opened pull request #275: Support runtime appearance adjustment on macOS (master...210409-dark) https://github.com/bitcoin-core/gui/pull/275
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21592: test: Remove option to make TestChain100Setup non-deterministic (master...2104-testCleanup) https://github.com/bitcoin/bitcoin/pull/21592
< bitcoin-git> bitcoin/master 4ad83a9 MarcoFalke: Merge #21592: test: Remove option to make TestChain100Setup non-determinis...
< bitcoin-git> bitcoin/master fa6183d MarcoFalke: test: Remove option to make TestChain100Setup non-deterministic
< bitcoin-git> bitcoin/master fa732bc MarcoFalke: test: Use compressed keys in TestChain100Setup
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/265a3a774b35...4ad83a9597e4
< bitcoin-git> [bitcoin] fanquake merged pull request #21445: cirrus: Use SSD cluster for speedup (master...2103-ciSSD) https://github.com/bitcoin/bitcoin/pull/21445
< bitcoin-git> bitcoin/master 265a3a7 fanquake: Merge #21445: cirrus: Use SSD cluster for speedup
< bitcoin-git> bitcoin/master fa21239 MarcoFalke: cirrus: Use SSD cluster for speedup
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c9597ce7db2...265a3a774b35

2021-04-08

< bitcoin-git> [bitcoin] achow101 opened pull request #21640: [0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it (0.21...0.21-sig-ext) https://github.com/bitcoin/bitcoin/pull/21640
< gribble> https://github.com/bitcoin/bitcoin/issues/20833 | rpc/validation: enable packages through testmempoolaccept by glozow · Pull Request #20833 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #21304: guix: Add guix-clean script + establish gc-root for container profiles (master...2021-02-guix-clean-script) https://github.com/bitcoin/bitcoin/pull/21304
< bitcoin-git> bitcoin/master 8f8b96f Carl Dong: guix: Update hint messages to mention guix-clean
< bitcoin-git> bitcoin/master 44f6d4f Carl Dong: guix: Record precious directories and add guix-clean
< bitcoin-git> bitcoin/master 84912d4 Carl Dong: build: Remove spaces from variable-printing rules
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6664211be2b6...0c9597ce7db2
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/19573 | Replace unused BIP 9 logic with draft BIP 8 by luke-jr · Pull Request #19573 · bitcoin/bitcoin · GitHub
< jeremyrubin> which says: " The idea can be implemented on top of either Bitcoin Core's existing BIP9 code or its proposed BIP8 patchset.[6]"
< gribble> https://github.com/bitcoin/bitcoin/issues/19521 | Coinstats Index by fjahr · Pull Request #19521 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19573 | Replace unused BIP 9 logic with draft BIP 8 by luke-jr · Pull Request #19573 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21392 | Implement BIP 8 based Speedy Trial activation by achow101 · Pull Request #21392 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 has 11 blockers, 2 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< NiamhOnMars> hi I was wondering why the original bitcoin code had some irc related code to join the #bitcoin IRC channel
< gribble> https://github.com/bitcoin/bitcoin/issues/12127 | Remove unused mempool index by sdaftuar · Pull Request #12127 · bitcoin/bitcoin · GitHub
< Kiminuo> sdaftuar, Hi, is there a reason why lines L288 and L289 were not deleted in PR #12127 (https://github.com/bitcoin/bitcoin/pull/12127/files#diff-f4f454edbfa1a878a9d4ad4371611c6c2812b7c77d2bd01baa66606524b61f9eL290)?