2019-07-17

< bitcoin-git> [bitcoin] promag opened pull request #16405: fix: tor: Call event_base_loopbreak from the event's callback (master...2019-07-fix-break-before-dispatch) https://github.com/bitcoin/bitcoin/pull/16405
< bitcoin-git> [bitcoin] promag opened pull request #16404: qa: Test ZMQ notification after chain reorg (master...2019-07-zmq-reorg) https://github.com/bitcoin/bitcoin/pull/16404
< bitcoin-git> [bitcoin] meshcollider merged pull request #16208: wallet: Consume ReserveDestination on successful CreateTransaction (master...createtransaction_keepkey) https://github.com/bitcoin/bitcoin/pull/16208
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/24dbcf380844...459baa1756b7
< bitcoin-git> bitcoin/master d9ff862 Gregory Sanders: CreateTransaction calls KeepDestination on ReserveDestination before succe...
< bitcoin-git> bitcoin/master e10e1e8 Gregory Sanders: Restrict lifetime of ReserveDestination to CWallet::CreateTransaction
< bitcoin-git> bitcoin/master 459baa1 MeshCollider: Merge #16208: wallet: Consume ReserveDestination on successful CreateTrans...

2019-07-16

< gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS · Issue #16296 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16306 | gui: crash in Console after loading & unloading wallet · Issue #16306 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16402: Remove wallet settings from chainparams (master...1907-walletNoChainParams) https://github.com/bitcoin/bitcoin/pull/16402
< bitcoin-git> [bitcoin] sdaftuar opened pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400
< bitcoin-git> [bitcoin] sdaftuar opened pull request #16401: Package relay (master...2019-07-package-relay) https://github.com/bitcoin/bitcoin/pull/16401
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15891: test: Require standard txs in regtest by default (master...1904-testRequireStandard) https://github.com/bitcoin/bitcoin/pull/15891
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8f604361ebaa...24dbcf380844
< bitcoin-git> bitcoin/master fa613ca MarcoFalke: chainparams: Remove unused fMineBlocksOnDemand
< bitcoin-git> bitcoin/master fa9b419 MarcoFalke: test: Add test that mainnet requires standard txs
< bitcoin-git> bitcoin/master fa89bad MarcoFalke: test: Require standard txs in regtest
< bitcoin-git> [bitcoin] hebasto closed pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
< bitcoin-git> [bitcoin] fjahr opened pull request #16399: wallet: Improve wallet creation (master...followup-16244) https://github.com/bitcoin/bitcoin/pull/16399
< bitcoin-git> [bitcoin] laanwj merged pull request #16194: refactor: share blockmetadata with BlockManager (master...2019-06-au-blockman) https://github.com/bitcoin/bitcoin/pull/16194
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8f9725c83f1d...8f604361ebaa
< bitcoin-git> bitcoin/master 613c46f James O'Beirne: refactoring: move block metadata structures into BlockManager
< bitcoin-git> bitcoin/master 4ed55df James O'Beirne: refactoring: add block_index_candidates arg to LoadBlockIndex
< bitcoin-git> bitcoin/master 55d525a James O'Beirne: refactoring: make pindexBestInvalid internal to validation.cpp
< sipa> stevenroose: what version of bitcoin core?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13804: WIP: Transaction Pool Layer (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/13804
< bitcoin-git> [bitcoin] stevenroose opened pull request #16397: Clarify includeWatching for fundrawtransaction (master...fundraw-includewatching) https://github.com/bitcoin/bitcoin/pull/16397
< stevenroose> promag: can you do multiwallet witn bitcoin-cli without having to change the url in the config file?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16390: qa: Add --filter option to test_runner.py (master...2019-07-testrunner-filter) https://github.com/bitcoin/bitcoin/pull/16390
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29082e8f40c3...8f9725c83f1d
< bitcoin-git> bitcoin/master 1a62425 João Barbosa: qa: Add --filter option to test_runner.py
< bitcoin-git> bitcoin/master 8f9725c MarcoFalke: Merge #16390: qa: Add --filter option to test_runner.py
< pinheadmz> I'm getting a leveldb checksum mismatch error `Fatal LevelDB error: Corruption: block checksum mismatch: /home/pi/.bitcoin/chainstate/2109327.ldb` but only when I shutdown with RPC stop... Since the error is in chainstate, can I try with -reindex ? Or do I need to redownload the chain...?
< bitcoin-git> [bitcoin] fanquake merged pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d37ed888e34...29082e8f40c3
< bitcoin-git> bitcoin/master fa0d0ff MarcoFalke: Remove unused bits from the service flags enum
< bitcoin-git> bitcoin/master 29082e8 fanquake: Merge #16380: Remove unused bits from the service flags enum

2019-07-15

< sipa> and if your end goal is integrating things into bitcoin core, i suspect getting familiar with the code is probably the best way to spend time now
< elichai2> don't you think that bitcoin core wallet should be like a reference for other wallets? because in that case other wallets got it faster :/
< sipa> well if you want to learn bitcoin core better (which i very much encourage you to!), i think it's better to focus on one piece at a time, but actually integrate it
< elichai2> because I still think that manual psbt without descriptors is still useful? altough you're right that I could've done it in rust-bitcoin and it would probabaly been easier and more native to the code but in the end I do want to get to know bitcoin core's code better so I will be able to make optimal solutions to bitcoin in the future :)
< sipa> so why do it in bitcoin core at all then?
< elichai2> and way more work. I'm trying to concentrate around PSBT for now. so i'm using `createpsbt` as a "hack" because that's the only psbt RPC command that doesn't relay on the wallet. (I'll probably move that logic to a seperate "createrawpsbt" or a `bitcoin-psbt` bin)
< bitcoin-git> [bitcoin] achow101 opened pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< bitcoin-git> [bitcoin] laanwj merged pull request #15824: docs: Improve netbase comments (master...2019-04-netbase-comments) https://github.com/bitcoin/bitcoin/pull/15824
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0822b44d8a68...6d37ed888e34
< bitcoin-git> bitcoin/master c7f6ce7 Carl Dong: docs: Improve netbase comments
< bitcoin-git> bitcoin/master 6d37ed8 Wladimir J. van der Laan: Merge #15824: docs: Improve netbase comments
< sipa> it seems highly unlikely that a change to the monetary policy will ever happen in bitcoin
< Raystonn> Bitcoin must remain <= 21 million coins.
< sipa> bitcoin does not have sub-satoshi units
< sipa> and again, bitcoin's consensus rules don't permit amounts above 2100000000000000 units
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/536590f358dc...0822b44d8a68
< bitcoin-git> bitcoin/master 8f250ab Steven Roose: TEST: Replace hard-coded hex tx with classes
< bitcoin-git> bitcoin/master 0822b44 MarcoFalke: Merge #15282: test: Replace hard-coded hex tx with class in test framework...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15282: test: Replace hard-coded hex tx with class in test framework (master...util-messages) https://github.com/bitcoin/bitcoin/pull/15282
< bitcoin-git> [bitcoin] fanquake opened pull request #16392: WIP build: macOS toolchain update (master...macos-toolchain-update) https://github.com/bitcoin/bitcoin/pull/16392
< fanquake> Does anyone know why Travis gets marked as failing, even though all tests are passing? i.e https://travis-ci.org/bitcoin/bitcoin/builds/558768209 is all green, but I see red in the GitHub UI (#16386) .It seems that running the extended lint stage will kick it over to green though..
< gribble> https://github.com/bitcoin/bitcoin/issues/16386 | depends: disable unused Qt features by fanquake · Pull Request #16386 · bitcoin/bitcoin · GitHub

2019-07-14

< bitcoin-git> [bitcoin] promag opened pull request #16390: qa: Add --filter option to test_runner.py (master...2019-07-testrunner-filter) https://github.com/bitcoin/bitcoin/pull/16390
< bitcoin-git> [bitcoin] hebasto opened pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
< gribble> https://github.com/bitcoin/bitcoin/issues/16387 | macOS Catalina · Issue #16387 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #16386: depends: disable unused Qt features (master...slim_qt_597) https://github.com/bitcoin/bitcoin/pull/16386

2019-07-13

< bitcoin-git> [bitcoin] jb55 opened pull request #16383: rpcwallet: default include_watchonly to true for watchonly wallets (master...20190713-watchonly-defaults) https://github.com/bitcoin/bitcoin/pull/16383
< bitcoin-git> [bitcoin] hebasto opened pull request #16381: Set minimum required Boost to 1.53.0 (master...20190713-bump-minimum-boost) https://github.com/bitcoin/bitcoin/pull/16381

2019-07-12

< bitcoin-git> [bitcoin] laanwj merged pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/3453cf26dbaf...536590f358dc
< bitcoin-git> bitcoin/master 604e2a9 Carl Dong: test: rpc_users: Add function for auth'd requests.
< bitcoin-git> bitcoin/master c73d871 Carl Dong: test: rpc_users: Add function for testing auth params.
< bitcoin-git> bitcoin/master 830dc2d Carl Dong: test: rpc_users: Also test rpcauth.py with specified password.
< emilengler> Can someone help me? I'm currently stucking at a PR and I have no idea why the travis build is failing on the tests (https://travis-ci.org/bitcoin/bitcoin/jobs/557960750)
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
< dongcarl> achow101: This section was written specifically for you: https://github.com/bitcoin/bitcoin/tree/master/contrib/guix#speeding-up-builds-with-substitute-servers
< instagibbs> achow101, https://github.com/bitcoin/bitcoin/tree/master/contrib/guix looks like you're supposed ot be able to use it
< bitcoin-git> [bitcoin] laanwj merged pull request #15277: contrib: Enable building in Guix containers (master...2019-01-guix) https://github.com/bitcoin/bitcoin/pull/15277
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/735d6b57e795...3453cf26dbaf
< bitcoin-git> bitcoin/master 3e80ec3 Carl Dong: contrib: Add deterministic Guix builds.
< bitcoin-git> bitcoin/master 8dff3e4 Carl Dong: contrib: guix: Clarify SOURCE_DATE_EPOCH.
< bitcoin-git> bitcoin/master cd3e947 Carl Dong: contrib: guix: Various improvements.
< bitcoin-git> [bitcoin] laanwj closed pull request #16310: refactor: small optimization for IsHex method (master...master) https://github.com/bitcoin/bitcoin/pull/16310
< bitcoin-git> [bitcoin] hebasto opened pull request #16379: Fix autostart filenames Linux for testnet/regtest (master...20190712-fix-autostart) https://github.com/bitcoin/bitcoin/pull/16379
< gribble> https://github.com/bitcoin/bitcoin/issues/16152 | Disable bloom filtering by default. by TheBlueMatt · Pull Request #16152 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #16378: [WIP] The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378
< bitcoin-git> [bitcoin] Sjors opened pull request #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt (master...2019/07/walletcreatefundedpsbt_addinputs) https://github.com/bitcoin/bitcoin/pull/16377
< fanquake> Hopefully no-one has to clean any toilets.. https://github.com/bitcoin/bitcoin/pull/16248#issuecomment-510831024

2019-07-11

< bitcoin-git> [bitcoin] antigaius closed pull request #16375: secp256k1/src/tests.c: Properly handle sscanf return value. (master...2019-07-12) https://github.com/bitcoin/bitcoin/pull/16375
< bitcoin-git> [bitcoin] antigaius opened pull request #16375: secp256k1/src/tests.c: Properly handle sscanf return value. (master...2019-07-12) https://github.com/bitcoin/bitcoin/pull/16375
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13947: Dandelion transaction relay (BIP 156) (master...Mf1804-dandelion) https://github.com/bitcoin/bitcoin/pull/13947
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13903: Significantly reduce GetTransaction cs_main locking (TheBlueMatt) (master...Mf1808-ReadBlockFromDiskCsMain) https://github.com/bitcoin/bitcoin/pull/13903
< gribble> https://github.com/bitcoin/bitcoin/issues/16301 | Use CWallet::Import* functions in all import* RPCs by achow101 · Pull Request #16301 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16227: Refactor CWallet's inheritance chain (master...rm-keystores) https://github.com/bitcoin/bitcoin/pull/16227
< bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/28d1353f4837...735d6b57e795
< bitcoin-git> bitcoin/master 1b699a5 Andrew Chow: Add HaveKey and HaveCScript to SigningProvider
< bitcoin-git> bitcoin/master c7797ec Andrew Chow: Remove CKeyStore and squash into CBasicKeyStore
< bitcoin-git> bitcoin/master a913e3f Andrew Chow: Move HaveKey static function from keystore to rpcwallet where it is used
< gribble> https://github.com/bitcoin/bitcoin/issues/16227 | Refactor CWallets inheritance chain by achow101 · Pull Request #16227 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #16374: test: Enable passing wildcard test names to test runner from root (master...enable-passing-wildcard-files-to-test-runner-from-root) https://github.com/bitcoin/bitcoin/pull/16374
< bitcoin-git> [bitcoin] laanwj merged pull request #15649: Add ChaCha20Poly1305@Bitcoin AEAD (master...2019/03/chachapoly1305) https://github.com/bitcoin/bitcoin/pull/15649
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4fcccdac785e...28d1353f4837
< bitcoin-git> bitcoin/master af5d1b5 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD implementation
< bitcoin-git> bitcoin/master 99aea04 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin tests
< bitcoin-git> bitcoin/master bb326ad Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD benchmark
< sipa> i'm suggesting this because i'd like a bitcoin-psbt tool that you just give psbts and utxos and descriptors and keys and figures out what it can do
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< bitcoin-git> [bitcoin] instagibbs opened pull request #16373: Add bumpfee option to return PSBT instead of commiting to wallet (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
< provoostenator> Some thoughs on how to apply achow101's The Box to hardware wallets: https://github.com/bitcoin/bitcoin/pull/14912#issuecomment-510520757
< jnewbery> provoostenator: from the base bitcoin directory: ./test/functional/test_runner.py $(for f in test/functional/wallet*; do echo $f | xargs -n 1 basename; done)
< bitcoin-git> [bitcoin] fanquake opened pull request #16371: trivial: build: ignore osx_volname & add it to clean-local (master...ignore_osx_volname) https://github.com/bitcoin/bitcoin/pull/16371
< bitcoin-git> [bitcoin] fanquake opened pull request #16370: depends: cleanup package configure flags (master...not_so_great_configure_cleanup) https://github.com/bitcoin/bitcoin/pull/16370

2019-07-10

< bitcoin-git> [bitcoin] ryanofsky opened pull request #16367: Multiprocess build support (master...pr/ipc-build) https://github.com/bitcoin/bitcoin/pull/16367
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16244: Move wallet creation out of the createwallet rpc into its own function (master...mv-createwallet) https://github.com/bitcoin/bitcoin/pull/16244
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff0aad8a40a0...4fcccdac785e
< bitcoin-git> bitcoin/master 1aecdf2 Andrew Chow: Move wallet creation out of the createwallet rpc into its own function
< bitcoin-git> bitcoin/master 4fcccda MarcoFalke: Merge #16244: Move wallet creation out of the createwallet rpc into its ow...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16361: Remove redundant pre-TopUpKeypool check (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c1e45c4c416...ff0aad8a40a0
< bitcoin-git> bitcoin/master 96b6dd4 Gregory Sanders: Remove redundant pre-TopUpKeypool checks
< bitcoin-git> bitcoin/master ff0aad8 MarcoFalke: Merge #16361: Remove redundant pre-TopUpKeypool check
< instagibbs> please no politics here. timeline for 0.19 here: https://github.com/bitcoin/bitcoin/issues/15940
< sipa> for bitcoin-psbt i'm more thinking something which you give a bunch of information and uses it where useful
< sipa> bitcoin-tx is really "transformation based" thing which you give an input and then specify some transformations to apply
< elichai2> so you think it should be separate from bitcoin-tx
< elichai2> I want to add it to the PSBT standard so that other wallets can start working on support this even before it's in bitcoin core's wallet (assuming of course taproot will get activated)
< sipa> and i think we need a bitcoin-psbt tool that can sign/update a psbt with keys and descriptors
< instagibbs> might be #bitcoin chat, achow101 would know
< elichai2> If I want to add manual psbt constructions support, does it makes sense to have it in `bitcoin-tx`? regular bitcoin core rpc or even a new `bitcoin-psbt`?
< gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16322 | wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16322 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15638 | Move-only: Pull wallet code out of libbitcoin_server by ryanofsky · Pull Request #15638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15778 | [wallet] Move maxtxfee from node to wallet by jnewbery · Pull Request #15778 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16366: init: Use InitError for all errors in bitcoind/qt (master...1907-initErrorGui) https://github.com/bitcoin/bitcoin/pull/16366
< bitcoin-git> [bitcoin] laanwj merged pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d1fc827300e2...6c1e45c4c416
< bitcoin-git> bitcoin/master 5c1b971 João Barbosa: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
< bitcoin-git> bitcoin/master 1775501 MarcoFalke: wallet: Remove unreachable code in CreateTransaction
< bitcoin-git> bitcoin/master 0d101a3 MarcoFalke: test: Add test for maxtxfee option
< bitcoin-git> [bitcoin] laanwj merged pull request #16270: depends: expat 2.2.7 (master...expat-2-2-7) https://github.com/bitcoin/bitcoin/pull/16270
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5859b7dc6ff5...d1fc827300e2
< bitcoin-git> bitcoin/master 0512f05 fanquake: depends: expat 2.2.7
< bitcoin-git> bitcoin/master d1fc827 Wladimir J. van der Laan: Merge #16270: depends: expat 2.2.7
< bitcoin-git> [bitcoin] laanwj merged pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8d1286014c61...5859b7dc6ff5
< bitcoin-git> bitcoin/master 48bcb2a qmma: Disable other targets when enable-fuzz is set
< bitcoin-git> bitcoin/master 84edfc7 qmma: Update doc and CI config
< bitcoin-git> bitcoin/master 5859b7d Wladimir J. van der Laan: Merge #16338: test: Disable other targets when enable-fuzz is set
< bitcoin-git> [bitcoin] laanwj merged pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/1fb747a8007c...410774ab89fd
< bitcoin-git> bitcoin/0.18 e2f7677 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
< bitcoin-git> bitcoin/0.18 df695db João Barbosa: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> bitcoin/0.18 410774a Wladimir J. van der Laan: Merge #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result"...
< bitcoin-git> [bitcoin] laanwj merged pull request #16237: Have the wallet give out destinations instead of keys (master...cwallet-getnewaddr) https://github.com/bitcoin/bitcoin/pull/16237
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/357488f660a5...8d1286014c61
< bitcoin-git> bitcoin/master 172213b Andrew Chow: Add GetNewDestination to CWallet to fetch new destinations
< bitcoin-git> bitcoin/master 33d13ed Andrew Chow: Replace CReserveKey with ReserveDestinatoin
< bitcoin-git> bitcoin/master 8e7f930 Andrew Chow: Add GetNewChangeDestination for getting new change Destinations
< gribble> https://github.com/bitcoin/bitcoin/issues/16362 | gui: Bilingual translation by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub

2019-07-09

< bitcoin-git> [bitcoin] darosior closed pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16240: JSONRPCRequest-aware RPCHelpMan (master...2019-06-json-aware-helper) https://github.com/bitcoin/bitcoin/pull/16240
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8046a3e0befe...357488f660a5
< bitcoin-git> bitcoin/master 0ab8ba1 Karl-Johan Alm: rpc: fix RPC help requirements for getblocktemplate
< bitcoin-git> bitcoin/master 5c5e32b Karl-Johan Alm: rpc: migrate JSONRPCRequest functionality into request.cpp
< bitcoin-git> bitcoin/master c7a9fc2 Karl-Johan Alm: Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper
< bitcoin-git> [bitcoin] LarryRuane opened pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363
< bitcoin-git> [bitcoin] hebasto opened pull request #16362: gui: Bilingual translation (master...20190709-bilingual-part-one) https://github.com/bitcoin/bitcoin/pull/16362
< bitcoin-git> [bitcoin] instagibbs opened pull request #16361: Remove redundant pre-TopUpKeypool checks (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
< bitcoin-git> [bitcoin] darosior opened pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360
< bitcoin-git> [bitcoin] darosior closed pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358
< bitcoin-git> [bitcoin] promag opened pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359
< bitcoin-git> [bitcoin] darosior opened pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358
< hebasto> MarcoFalke: I'm going to rebase my PR and implement your suggestion. Could you look into https://github.com/bitcoin/bitcoin/pull/15864#discussion_r301258664 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag · Pull Request #16348 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Remove redundant WalletController::addWallet signal by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] conscott closed pull request #14691: tests: Speedup feature_pruning test and refactor big transaction logic (master...2018_11_opreturn_splices) https://github.com/bitcoin/bitcoin/pull/14691
< bitcoin-git> [bitcoin] laanwj merged pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c799976c86e2...8046a3e0befe
< bitcoin-git> bitcoin/master f27bd96 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
< bitcoin-git> bitcoin/master 64fee48 João Barbosa: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> bitcoin/master 8046a3e Wladimir J. van der Laan: Merge #16348: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> [bitcoin] laanwj closed pull request #16357: util: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357

2019-07-08

< bitcoin-git> [bitcoin] nkostoulas opened pull request #16357: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357
< bitcoin-git> [bitcoin] cajunlady78 opened pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
< bitcoin-git> [bitcoin] cajunlady78 closed pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
< bitcoin-git> [bitcoin] instagibbs closed pull request #13057: refactor pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057
< bitcoin-git> [bitcoin] laanwj merged pull request #16128: Delete error-prone CScript constructor only used with FindAndDelete (master...cscript_construct) https://github.com/bitcoin/bitcoin/pull/16128
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345f42a9e3ae...c799976c86e2
< bitcoin-git> bitcoin/master e1a5569 Gregory Sanders: Delete error-prone CScript constructor
< bitcoin-git> bitcoin/master c799976 Wladimir J. van der Laan: Merge #16128: Delete error-prone CScript constructor only used with FindAn...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a6ee9797e65...345f42a9e3ae
< bitcoin-git> bitcoin/master c4606b8 practicalswift: Add Travis check for single parameter constructors not marked "explicit"
< bitcoin-git> bitcoin/master 345f42a Wladimir J. van der Laan: Merge #14505: test: Add linter to make sure single parameter constructors ...
< bitcoin-git> [bitcoin] laanwj merged pull request #14505: test: Add linter to make sure single parameter constructors are marked explicit (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
< bitcoin-git> [bitcoin] laanwj merged pull request #16267: bench: Benchmark blockToJSON (master...bench-blocktojson) https://github.com/bitcoin/bitcoin/pull/16267
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4882040182ea...0a6ee9797e65
< bitcoin-git> bitcoin/master 91509ff Kirill Fomichev: bench: Benchmark blockToJSON
< bitcoin-git> bitcoin/master 0a6ee97 Wladimir J. van der Laan: Merge #16267: bench: Benchmark blockToJSON
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2679bb8919b5...4882040182ea
< bitcoin-git> bitcoin/master fa5e9f1 MarcoFalke: build: Stop translating PACKAGE_NAME
< bitcoin-git> bitcoin/master fabe87d MarcoFalke: scripted-diff: Avoid passing PACKAGE_NAME for translation
< bitcoin-git> bitcoin/master fab8520 MarcoFalke: qt: Run «make translate» in ./src/
< gribble> https://github.com/bitcoin/bitcoin/issues/15891 | test: Require standard txs in regtest by default by MarcoFalke · Pull Request #15891 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jamesob opened pull request #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp (master...2019-07-au-coinscatcher) https://github.com/bitcoin/bitcoin/pull/16355
< bitcoin-git> [bitcoin] laanwj merged pull request #16106: gui: Sort wallets in open wallet menu (master...2019-05-followup-15957) https://github.com/bitcoin/bitcoin/pull/16106
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b5fa2319d863...2679bb8919b5
< bitcoin-git> bitcoin/master 224eb95 João Barbosa: gui: Sort wallets in open wallet menu
< bitcoin-git> bitcoin/master fa90fe6 João Barbosa: refactor: Rename getWallets to getOpenWallets in WalletController
< bitcoin-git> bitcoin/master 2679bb8 Wladimir J. van der Laan: Merge #16106: gui: Sort wallets in open wallet menu
< bitcoin-git> [bitcoin] fanquake closed pull request #16351: 0.18 backport: backport github-merge.py improvements (0.18...backport_github_merge_improvements) https://github.com/bitcoin/bitcoin/pull/16351
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/983c84844c59...b5fa2319d863
< bitcoin-git> bitcoin/master 1eb13f0 Jon Atack: test: Add log messages to test/functional/tool_wallet.py
< bitcoin-git> bitcoin/master 3bf2b3a Jon Atack: test: Split tool_wallet.py test into subtests
< bitcoin-git> bitcoin/master 7195fa7 Jon Atack: test: Tool wallet test coverage for unexpected writes to wallet
< bitcoin-git> [bitcoin] laanwj merged pull request #15687: test: tool wallet test coverage for unexpected writes to wallet (master...tool-wallet-tests-for-unexpected-writes-to-wallet-file) https://github.com/bitcoin/bitcoin/pull/15687
< bitcoin-git> [bitcoin] laanwj merged pull request #16352: build: prune dbus from depends (master...depends_prune_dbus) https://github.com/bitcoin/bitcoin/pull/16352
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5a01cf25986...983c84844c59
< bitcoin-git> bitcoin/master e8fabd9 fanquake: build: prune dbus from depends
< bitcoin-git> bitcoin/master 983c848 Wladimir J. van der Laan: Merge #16352: build: prune dbus from depends
< bitcoin-git> [bitcoin] laanwj merged pull request #16332: rpc: Add logpath description for getrpcinfo (master...getrpcinfo_logpath_help) https://github.com/bitcoin/bitcoin/pull/16332
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e1a8d76aff8d...f5a01cf25986
< bitcoin-git> bitcoin/master a30bd09 Gregory Sanders: Add logpath description for getrpcinfo
< bitcoin-git> bitcoin/master f5a01cf Wladimir J. van der Laan: Merge #16332: rpc: Add logpath description for getrpcinfo
< gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Fix "opening a wallet" issue #15453 by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16285 | rpc: Improve scantxoutset response and help message by promag · Pull Request #16285 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2b465195e09a...e1a8d76aff8d
< bitcoin-git> bitcoin/master 84ad4d2 Carl Dong: doc: Include static members in Doxygen
< bitcoin-git> bitcoin/master e1a8d76 Wladimir J. van der Laan: Merge #16347: doc: Include static members in Doxygen
< bitcoin-git> [bitcoin] fanquake merged pull request #16339: doc: add reduce-memory.md (master...doc-reduce-memory-usage) https://github.com/bitcoin/bitcoin/pull/16339
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05623c021681...2b465195e09a
< bitcoin-git> bitcoin/master 64b27c4 fanquake: docs: add reduce-memory.md
< bitcoin-git> bitcoin/master 2b46519 fanquake: Merge #16339: doc: add reduce-memory.md
< bitcoin-git> [bitcoin] fanquake merged pull request #16350: qt: Remove unused guard (master...20190707-remove-unused-guard) https://github.com/bitcoin/bitcoin/pull/16350
< bitcoin-git> bitcoin/master 05623c0 fanquake: Merge #16350: qt: Remove unused guard
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f373beebbcc0...05623c021681
< bitcoin-git> bitcoin/master d003110 Hennadii Stepanov: Remove unused guard

2019-07-07

< bitcoin-git> [bitcoin] fanquake opened pull request #16352: build: prune dbus from depends (master...depends_prune_dbus) https://github.com/bitcoin/bitcoin/pull/16352
< bitcoin-git> [bitcoin] fanquake opened pull request #16351: 0.18 backport: backport github-merge.py improvements (0.18...backport_github_merge_improvements) https://github.com/bitcoin/bitcoin/pull/16351
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/629c7b029cf9...1fb747a8007c
< bitcoin-git> bitcoin/0.18 1dc357d Anthony Towns: signrawtransactionwithkey: report error when missing redeemScript/witnessS...
< bitcoin-git> bitcoin/0.18 1fb747a fanquake: Merge #16342: 0.18 backport: report error when missing redeemScript/witnes...
< bitcoin-git> [bitcoin] fanquake merged pull request #16342: 0.18 backport: report error when missing redeemScript/witnessScript (0.18...201906-signrawerror-regression-018) https://github.com/bitcoin/bitcoin/pull/16342
< bitcoin-git> [bitcoin] hebasto opened pull request #16350: qt: Remove unused guard (master...20190707-remove-unused-guard) https://github.com/bitcoin/bitcoin/pull/16350
< bitcoin-git> [bitcoin] fanquake merged pull request #16344: build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) (master...2019/07/system-ifdef) https://github.com/bitcoin/bitcoin/pull/16344
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/584168c7f9d9...f373beebbcc0
< bitcoin-git> bitcoin/master 976b034 Sjors Provoost: [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
< bitcoin-git> bitcoin/master f373bee fanquake: Merge #16344: build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
< bitcoin-git> [bitcoin] fanquake merged pull request #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCCvertParam tables (master...2019-07-utxoupdatepsbt-args) https://github.com/bitcoin/bitcoin/pull/16326
< bitcoin-git> bitcoin/master 3b11420 John Newbery: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertP...
< bitcoin-git> bitcoin/master 91cc18f John Newbery: [docs] Add release notes for PR 15427
< bitcoin-git> bitcoin/master 584168c fanquake: Merge #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand an...
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8c69fae94410...584168c7f9d9

2019-07-06

< bitcoin-git> [bitcoin] hebasto opened pull request #16349: Fix "opening a wallet" issue #15453 (master...20190706-fix15453) https://github.com/bitcoin/bitcoin/pull/16349
< bitcoin-git> [bitcoin] promag opened pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348
< bitcoin-git> [bitcoin] dongcarl opened pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | WIP: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< hebasto> promag: hi, could you look into https://travis-ci.org/bitcoin/bitcoin/jobs/554836240 ?
< achow101> anyone familiar with MSVC know what's up with this error: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/25786259?

2019-07-05

< bitcoin-git> [bitcoin] sipsorcery closed pull request #15995: systemd service script: set usable permissions on /etc/bitcoin config dir (master...systemdconfig) https://github.com/bitcoin/bitcoin/pull/15995
< sipa> there's a website which is still actively being changed: http://bitcoin.sipa.be/miniscript
< sipa> this is about the bitcoin scirpt language as it exists today, without any softforks or other changes to consensus needed (but obviously prepared for those)
< sipa> so me and some colleagues of mine have been working on a way to make more complex bitcoin scripts more accessible, in a project called miniscript
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] emilengler opened pull request #16345: RPC: Add getblockbyheight (master...getblockbyheight) https://github.com/bitcoin/bitcoin/pull/16345
< provoostenator> emilengler: it does that here: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/client.cpp#L31
< sipa> bitcoin-cli knows that the first argument to generatetoaddress is to be interpreted as json instead of as a string
< sipa> emilengler: bitcoin-cli knows which arguments to treat as strings and which as json
< bitcoin-git> [bitcoin] Sjors opened pull request #16344: [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) (master...2019/07/system-ifdef) https://github.com/bitcoin/bitcoin/pull/16344
< emilengler> bitcoin-cli says "JSON value is not an integer as expected"
< emilengler> I currently have problems with bitcoin-cli to read an integer value on a new command I've implemented
< bitcoin-git> [bitcoin] laanwj merged pull request #15457: Check std::system for -[alert|block|wallet]notify (master...2019/02/std__system) https://github.com/bitcoin/bitcoin/pull/15457
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4f378ac30cf6...8c69fae94410
< bitcoin-git> bitcoin/master c1c91bb Sjors Provoost: [build] detect std::system or ::wsystem
< bitcoin-git> bitcoin/master cc3ad56 Sjors Provoost: [build] MSVC: set HAVE_SYSTEM for desktop apps
< bitcoin-git> bitcoin/master f874e14 Sjors Provoost: [build]: check std::system for -[alert|block|wallet]notify
< gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub