<gribble>
https://github.com/bitcoin/bitcoin/issues/24530 | wallet: assert BnBs internally calculated waste is the same as GetSelectionWaste by glozow · Pull Request #24530 · bitcoin/bitcoin · GitHub
<sipa>
this seems more like rust-miniscript API question than a question about wallets (and even less about bitcoin core's wallet)
<bitcoin-git>
[bitcoin] glozow opened pull request #24538: miner: bug fix? update for ancestor inclusion using modified fees, not base (master...2022-03-miner-prioritised) https://github.com/bitcoin/bitcoin/pull/24538
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24537: rpc: Split mempool RPCs from blockchain.cpp (master...2203-mempoolRpc-🌛) https://github.com/bitcoin/bitcoin/pull/24537
<bitcoin-git>
[bitcoin] achow101 merged pull request #24530: wallet: assert BnB's internally calculated waste is the same as GetSelectionWaste (master...2022-03-bnb-waste) https://github.com/bitcoin/bitcoin/pull/24530
<bitcoin-git>
bitcoin/master ec7d736 glozow: [wallet] assert BnB internally calculated waste is the same as GetSelectio...
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24535: test: Fix generate calls and comments in feature_segwit (master...2203-test_fix_seg-🏌) https://github.com/bitcoin/bitcoin/pull/24535
<bitcoin-git>
[bitcoin] prusnak opened pull request #24534: contrib: macdeploy: make gen-sdk deterministic (master...deterministic-macos-sdk) https://github.com/bitcoin/bitcoin/pull/24534
<bitcoin-git>
[bitcoin] theStack opened pull request #24533: test: use MiniWallet for feature_maxuploadtarget.py (master...202203-test-use_MiniWallet_for_feature_maxuploadtarget) https://github.com/bitcoin/bitcoin/pull/24533
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24453: Bugfix: doc: Correct change_address/changeAddress in wallet RPC help (master...fix_rpcdoc_changeaddr_STR) https://github.com/bitcoin/bitcoin/pull/24453
<bitcoin-git>
[bitcoin] glozow opened pull request #24530: wallet: assert BnB's internally calculated waste is the same as GetSelectionWaste (master...2022-03-bnb-waste) https://github.com/bitcoin/bitcoin/pull/24530
<bitcoin-git>
[bitcoin] jonatack opened pull request #24528: rpc: rename getdeploymentinfo status-next to status_next (master...getdeploymentinfo-rename-status-next-to-status_next) https://github.com/bitcoin/bitcoin/pull/24528
<ebaySatoshi>
Where can I see the lines of code of Satoshi that were removed, possibly related to the implementation of a shopping feature in Bitcoin a bit like ebay shopping system?
2022-03-10
<gribble>
https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24527: test: set segwit height back to 0 on regtest (master...202203_regtest_segwitheight) https://github.com/bitcoin/bitcoin/pull/24527
<dongcarl>
Could I have #24322 for high prio? Will update within the next hour with the changes just discussed in #bitcoin-core-builds (shouldn't change much)
<bitcoin-git>
[bitcoin] achow101 merged pull request #24520: guix: only check for the macOS SDK once (master...check_macOS_SDK_one_time) https://github.com/bitcoin/bitcoin/pull/24520
<bitcoin-git>
bitcoin/master e802310 fanquake: guix: only check for the macOS SDK once
<bitcoin-git>
bitcoin/master d1a940f Andrew Chow: Merge bitcoin/bitcoin#24520: guix: only check for the macOS SDK once
<bitcoin-git>
[bitcoin] fanquake opened pull request #24520: guix: only check for the macOS SDK once (master...check_macOS_SDK_one_time) https://github.com/bitcoin/bitcoin/pull/24520
<bitcoin-git>
[bitcoin] jonatack opened pull request #24519: doc: update multisig-tutorial.md to descriptor wallet by default (master...multisig-tutorial-update) https://github.com/bitcoin/bitcoin/pull/24519
<bitcoin-git>
[bitcoin] fanquake merged pull request #24511: [23.x] qt: Avoid crash on startup if int specified in settings.json (23.x...23.x-settings-json-crash) https://github.com/bitcoin/bitcoin/pull/24511
<bitcoin-git>
bitcoin/23.x 4607f70 Ryan Ofsky: test: Add tests for GetArg methods / settings.json type coercion
<bitcoin-git>
bitcoin/23.x 7e1b968 Ryan Ofsky: qt: Avoid crash on startup if int specified in settings.json
<sipa>
I think over time we should implement (2), and also change it from publishing through DNS to just listening on Bitcoin P2P and responding to getaddr.
<laanwj>
provoostenator: so that leaves two ways to go (1) strip tor and rudimentary I2P support from the crawler (2) add both (e.g. https://github.com/sipa/bitcoin-seeder/issues/92), both are valid ways to go depending on what is deemed to be the scope of it (and whoever implements it)
<bitcoin-git>
[bitcoin] hebasto opened pull request #24516: build, ci: Fix MSVC builds and other improvements (master...220310-msvc-ci) https://github.com/bitcoin/bitcoin/pull/24516
2022-03-09
<bitcoin-git>
[bitcoin] dongcarl opened pull request #24515: Only load BlockMan in BlockMan member functions (master...2022-03-kirby-p2.5) https://github.com/bitcoin/bitcoin/pull/24515
<ziggie>
are there some good resources to understand why we cannot have a lock until in bitcoin, having problems wrapping my head around it
<bitcoin-git>
[bitcoin] jonatack opened pull request #24512: [23.x] init, doc: improve -onlynet help and related tor/i2p documentation (23.x...23.x-onlynet-help-and-doc-improvements) https://github.com/bitcoin/bitcoin/pull/24512
<bitcoin-git>
[bitcoin] achow101 opened pull request #24511: [23.x] qt: Avoid crash on startup if int specified in settings.json (23.x...23.x-settings-json-crash) https://github.com/bitcoin/bitcoin/pull/24511
<bitcoin-git>
[bitcoin] achow101 merged pull request #24498: qt: Avoid crash on startup if int specified in settings.json (master...pr/setint) https://github.com/bitcoin/bitcoin/pull/24498
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24138: index: Commit MuHash and best block together for coinstatsindex (master...202201_coinstatsindex_commits) https://github.com/bitcoin/bitcoin/pull/24138
<bitcoin-git>
bitcoin/master 691d45f Ryan Ofsky: Add coinstatsindex_unclean_shutdown test
<bitcoin-git>
[bitcoin] fanquake merged pull request #24495: guix: only use native GCC 7 toolchain for Linux builds (master...fix_macos_build_m1) https://github.com/bitcoin/bitcoin/pull/24495
<bitcoin-git>
[gui] laanwj opened pull request #563: qt: Remove network detection based on address in BIP21 (master...2022-03-remove-autodetect-code) https://github.com/bitcoin-core/gui/pull/563
<laanwj>
to be honest i'm not sure how important that is, who is using testnet bitcoin URIs in a browser or such
<laanwj>
oh you mean selecting which set of parameters to use based on the provided bitcoin URI
<bitcoin-git>
[bitcoin] achow101 opened pull request #24506: build, mac: Include arch in codesignature tarball (master...mac-arch-in-codesig) https://github.com/bitcoin/bitcoin/pull/24506
<bitcoin-git>
[bitcoin] achow101 opened pull request #24505: wallet: Add a deprecation warning for newly created legacy wallets (master...deprecate-warning-new-legacy-wallets) https://github.com/bitcoin/bitcoin/pull/24505
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24496: test: refactor: use `random.sample` for choosing random keys in wallet_taproot.py (master...202203-test-refactor-replace_key_manual_key_sampling_with_randomsample) https://github.com/bitcoin/bitcoin/pull/24496
<laanwj>
i would suggest looking into reputable wallet recovery services (ther's one that has been running for a few years, i'm not going to link anything here though) and that said, it's off topic here, please move it to #bitcoin
<laanwj>
assuming it's a bitcoin core wallet it's a non trivial amount of work per iteration
<bitcoin-git>
[bitcoin] div72 opened pull request #24500: ci: use compiler version in ccache compiler check (master...ci-specify-compilercheck) https://github.com/bitcoin/bitcoin/pull/24500
2022-03-07
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24499: test, devtools: add script to mutate cpp files (master...2022-03-mutation-test) https://github.com/bitcoin/bitcoin/pull/24499
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #24498: qt: Avoid crash on startup if int specified in settings.json (master...pr/setint) https://github.com/bitcoin/bitcoin/pull/24498
<bitcoin-git>
[bitcoin] theStack opened pull request #24496: test: refactor: use `random.sample` for choosing random keys in wallet_taproot.py (master...202203-test-refactor-replace_key_manual_key_sampling_with_randomsample) https://github.com/bitcoin/bitcoin/pull/24496
<bitcoin-git>
[bitcoin] fanquake opened pull request #24495: guix: only use native GCC 7 toolchain for Linux builds (master...fix_macos_build_m1) https://github.com/bitcoin/bitcoin/pull/24495
<bitcoin-git>
bitcoin/master e22d10b Hennadii Stepanov: ci: Switch from bionic to buster
<bitcoin-git>
bitcoin/master c9ed992 fanquake: Merge bitcoin/bitcoin#24132: build: Bump minimum Qt version to 5.11.3
<bitcoin-git>
bitcoin/master 956f732 Hennadii Stepanov: build: Bump minimum Qt version to 5.11.3
<bitcoin-git>
[bitcoin] glozow opened pull request #24494: wallet: generate random change target for each tx for better privacy (master...2022-03-minchange) https://github.com/bitcoin/bitcoin/pull/24494
<bitcoin-git>
[bitcoin] fanquake merged pull request #24489: build: Move guix time machine to prelude (master...2022-03-time-machine-configuration) https://github.com/bitcoin/bitcoin/pull/24489
<bitcoin-git>
[bitcoin] fanquake opened pull request #24491: contrib: fix implicit function decleration in win symbol check (master...fix_implicit_declaration_win_checks) https://github.com/bitcoin/bitcoin/pull/24491
<prayank>
ariard: re: new avatar - yes I thought about it considering the things. I would do it after deleting all my accounts because I still want to contribute to Bitcoin. I gave up after I wake up, saw after everything on websites, asked one reliable dev who sadi pls dont give up as we all tried to at some point. Me giving up would affect bitcoin and thats not what I want.
<prayank>
jonatack: I respect you but where does "censorship" comes here or is it only for social media or when it affects you. Bitcoin dev mailing list is not same as anything as anything in this world for me. It was used to settle things when they could not be done on github, reddit, twitter etc. if that is vulnerable to one person deciding what is good enoug for others to see its same as facebook, twitter etc. I have tried my best to
<prayank>
contribute to bitcoin and sometimes being in places where you never would want to be.
<bitcoin-git>
[bitcoin] fanquake opened pull request #24485: [23.x] guix: use same commit for codesigning time-machine (23.x...backport_24484) https://github.com/bitcoin/bitcoin/pull/24485
<michaelfolkson>
Reminder that this channel is for Bitcoin Core development discussion. There is a #bitcoin-dev channel for discussion of mailing list, BIPs etc. prayank has been told that on multiple occasions now
<bitcoin-git>
[bitcoin] achow101 merged pull request #24484: guix: use same commit for codesigning time-machine (master...sync_guix_time_machine) https://github.com/bitcoin/bitcoin/pull/24484
<bitcoin-git>
bitcoin/master 29862bd fanquake: guix: use same commit for codesigning time-machine
<bitcoin-git>
[bitcoin] fanquake opened pull request #24484: guix: use same commit for codesigning time-machine (master...sync_guix_time_machine) https://github.com/bitcoin/bitcoin/pull/24484
2022-03-05
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24479: Bugfix: util: Correctly handle Number value types in GetArg/GetBoolArg (master...bugfix_settings_numberval) https://github.com/bitcoin/bitcoin/pull/24479