< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18584: test: Check that the version message does not leak the local address (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18584
< sipa>
fanquake: seeing the size of bitcoin-asmap in #18573
< bitcoin-git>
[bitcoin] promag opened pull request #18578: gui: Fix itemWalletAddress leak when not tree mode (master...2020-fix-coincontroldialog-leak) https://github.com/bitcoin/bitcoin/pull/18578
< bitcoin-git>
[bitcoin] gzhao408 opened pull request #18576: wip [test] use unittest for test_framework unit testing (master...framework-unittests) https://github.com/bitcoin/bitcoin/pull/18576
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18575: bench: Remove requirement that all benches use same testing setup (master...2004-benchNoGlobalReg) https://github.com/bitcoin/bitcoin/pull/18575
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18561: test: Properly raise FailedToStartError when rpc shutdown before warmup finished (master...2004-qaFailedToStartConnectionReset) https://github.com/bitcoin/bitcoin/pull/18561
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18572: Wallet: Accept "changedata" db key as an alias to "destdata" (master...changedata_forwardcompat) https://github.com/bitcoin/bitcoin/pull/18572
< Talkless>
jonasschnelli: alternative is just to wait until Bitcoin Qt has BIP39 support and easy HW wallet support, so I could just switch to Bitcoin Qt :)
< fjahr>
@Talkless have you checked out previous attempts to add this index? See for example #14053 which is still active and bitcoin core reviews session https://bitcoincore.reviews/14053.html. If you haven't seen it I think it will provide more context on the issues.
< Talkless>
I have LOCAL full node, LOCAL electrum wallet, I would like that my (and only my) local electrum wallet would connect DIRECTLY to that local bitcoin full node via RPC and could work just like that
< jonasschnelli>
Even if Bitcoin Core would have a such full address index,... I think it would be naive to also add the endpoint with all the required httpd hardening and authentication methods.
< jonasschnelli>
We can't have that in Bitcoin-Core
< jonasschnelli>
I see the usecase for a personal block explorer. But IMO you should use third party software for this. There is no need to add complex indexing to the software that provides also the Bitcoin consensus protocol.
< jonasschnelli>
With multiwallet and enforced watch-only support, I think using Bitcoin Core as a backand for personal wallets is possible/fine.
< bitcoin-git>
[bitcoin] hebasto closed pull request #18501: build: Fix boost detection on Ubuntu ARM 18.04 (master...20200402-boost-arm) https://github.com/bitcoin/bitcoin/pull/18501
< Talkless>
Could it be "controversial" to implement addrindex, so that other third party wallets (like Electrum) would not need intermediary server (like Electrumx) to make it work? It could access all info via Bitcoin RPC instead.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18555: wallet: Abort when assumption fails in debug mode (master...2004-walletAssumeAbortDebug) https://github.com/bitcoin/bitcoin/pull/18555
< bitcoin-git>
[bitcoin] mrwhythat opened pull request #18554: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/18554
< bitcoin-git>
bitcoin/master 7a2ecf1 Luke Dashjr: Wallet: Change IsMine check in CWallet::DelAddressBook from assert to fail...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
< bitcoin-git>
bitcoin/master 2952c46 Luke Dashjr: Wallet: Replace CAddressBookData.name with GetLabel() method
< bitcoin-git>
bitcoin/master d7092c3 Luke Dashjr: QA: Test that change doesn't turn into non-change when spent in an avoid-r...
< bitcoin-git>
[bitcoin] sipa opened pull request #18551: Do not clear validationinterface entries being executed (master...202004_fix_validation_notify_clear) https://github.com/bitcoin/bitcoin/pull/18551
2020-04-06
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18550: Store destdata for change in separate key for backward compatibility (master...changedata) https://github.com/bitcoin/bitcoin/pull/18550
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
< bitcoin-git>
bitcoin/master abc145c MarcoFalke: Merge #18543: test: Use one node to avoid a race due to missing sync in rp...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18543: test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
< bitcoin-git>
bitcoin/master fa2251d MarcoFalke: test: Use one node to avoid a race due to missing sync in rpc_signrawtrans...
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18192: Bugfix: Wallet: Safely deal with change in the address book (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18192
< bitcoin-git>
bitcoin/master 65b6bdc Luke Dashjr: Wallet: Add CAddressBookData::IsChange which returns true iff label has ne...
< bitcoin-git>
bitcoin/master 144b2f8 Luke Dashjr: Wallet: Require usage of new CAddressBookData::setLabel to change label
< bitcoin-git>
bitcoin/master b86cd15 Luke Dashjr: scripted-diff: Wallet: Rename mapAddressBook to m_address_book
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541
< gribble>
https://github.com/bitcoin/bitcoin/issues/18484 | rpc: Correctly compute redeemScript from witnessScript for signrawtransaction by achow101 · Pull Request #18484 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
< luke-jr>
"While the Snap packages use the deterministically generated executables, the Snap tool itself does not provide a streamlined way to reveal the contents of a Snap package. Thus, the Bitcoin Core project does not have the information necessary to help you verify the Bitcoin Core Snap packages."
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
< bitcoin-git>
bitcoin/master 425a7f9 MarcoFalke: Merge #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte
< bitcoin-git>
bitcoin/master 25e03ba Jon Atack: test: relax bumpfee dust_to_fee txsize an extra vbyte
< ryanofsky>
no, my pr is really just a refactor that doesn't change bitcoin behavior. #18338 is an actual bugfix but the implementation relies on behavior only implemented in new boost versions
< ryanofsky>
i don't know how things are normally done. i'd revert it on master for but some reason bitcoin projects treats reverts as more of a big deal than other projects i've worked on
< bitcoin-git>
[bitcoin] fanquake opened pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
2020-04-05
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18533: scripted-diff: Replace strCommand with msg_type (master...2004-netMsgType) https://github.com/bitcoin/bitcoin/pull/18533
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18532: rpc: Avoid initialization-order-fiasco on static CRPCCommand tables (master...2004-rpcNoFiasco) https://github.com/bitcoin/bitcoin/pull/18532
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18531: rpc: Assert that RPCArg names are equal to CRPCCommand ones (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18515: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py (master...20200403-test-check-for-CVE20135700-vuln-in-bip37-tests) https://github.com/bitcoin/bitcoin/pull/18515
< bitcoin-git>
bitcoin/master cf21293 MarcoFalke: Merge #18515: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p...
< bitcoin-git>
bitcoin/master 0ed2d8e Sebastian Falbesoner: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py
< bitcoin-git>
[bitcoin] glowang opened pull request #18530: WIP: add test for -blocksonly and -whitelistforcerelay (master...add_blocksonly_tests) https://github.com/bitcoin/bitcoin/pull/18530