2020-09-29

< bitcoin-git> bitcoin/master d813d26 Sjors Provoost: [rpc] send: various touch-ups
< bitcoin-git> bitcoin/master 0fc1c68 Sjors Provoost: [rpc] send: fix parsing replaceable option
< bitcoin-git> bitcoin/master efc9b85 Sjors Provoost: Mark send RPC experimental
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7ea649946daa...e36aa351a31c
< bitcoin-git> [bitcoin] fanquake closed pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
< bitcoin-git> bitcoin/master 7ea6499 fanquake: Merge #20028: test: Check that invalid peer traffic is accounted for
< bitcoin-git> [bitcoin] fanquake merged pull request #20028: test: Check that invalid peer traffic is accounted for (master...2009-testInvalidTraffic) https://github.com/bitcoin/bitcoin/pull/20028
< bitcoin-git> bitcoin/master fae243f MarcoFalke: test: Remove confusing cast to same type (int to int)
< bitcoin-git> bitcoin/master faa94cb MarcoFalke: test: Check that invalid peer traffic is accounted for
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5db44c740ebd...7ea649946daa
< bitcoin-git> [bitcoin] fanquake merged pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
< bitcoin-git> bitcoin/master 5db44c7 fanquake: Merge #20014: doc: Mention signet in -help output
< bitcoin-git> bitcoin/master b3972bc Hennadii Stepanov: doc: Mention signet in -help output
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/655937ebcbf6...5db44c740ebd

2020-09-28

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030
< bitcoin-git> [bitcoin] sipa merged pull request #19845: net: CNetAddr: add support to (un)serialize as ADDRv2 (master...ser_addrv2_cnetaddr) https://github.com/bitcoin/bitcoin/pull/19845
< bitcoin-git> bitcoin/master e0d7357 Vasil Dimov: net: CNetAddr: add support to (un)serialize as ADDRv2
< bitcoin-git> bitcoin/master d2bb681 Vasil Dimov: util: move HasPrefix() so it can be reused
< bitcoin-git> bitcoin/master fe42411 Vasil Dimov: test: move HasReason so it can be reused
< bitcoin-git> [bitcoin] sipa pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/255270200074...655937ebcbf6
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15367: feature: Added ability for users to add a startup command (master...startup_commands) https://github.com/bitcoin/bitcoin/pull/15367
< bitcoin-git> bitcoin/master 2552702 MarcoFalke: Merge #15367: feature: Added ability for users to add a startup command
< bitcoin-git> bitcoin/master 090530c Ben Carman: feature: Added ability for users to add a startup command
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c95784e3d31d...255270200074
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030
< emzy> cdecker / provoostenator: would you like to look into or test my dnsseed dnssec setup? https://github.com/Emzy/bitcoin-seeder/blob/master/README-dnssec.md
< gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19411 | Unable to build BDB 4.8 on macOS Big Sur beta or Xcode 12.0 · Issue #19411 · bitcoin/bitcoin · GitHub
< Bullit> Bitcoin core V0.20 keeps crashing 2020-09-28T12:21:12Z Verifying last 6 blocks at level 3 ; whats Bitcoin Core Network Trafic + Banking Stockbroker traffic
< harding> Can someone with either Travis access or GitHub admin access for the bitcoin-core organization take a look at https://github.com/bitcoin-core/bitcoincore.org/pull/722 please? I'd like to merge it but its travis job is stuck and the master branch is protected against merges that haven't passed CI.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20028: test: Check that invalid peer traffic is accounted for (master...2009-testInvalidTraffic) https://github.com/bitcoin/bitcoin/pull/20028
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20016: uint256: 1 is a constant (master...202009-uint256_1) https://github.com/bitcoin/bitcoin/pull/20016
< bitcoin-git> bitcoin/master 4cc7171 Anthony Towns: wallet: no need for duplicate storage for ABANDON_HASH constant
< bitcoin-git> bitcoin/master 82cf464 Anthony Towns: scripted-diff: Replace UINT256_ONE() with uint256::ONE
< bitcoin-git> bitcoin/master 183f308 Anthony Towns: uint256: Update constructors to c++11, make ONE static
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e7e6f0bf18b9...c95784e3d31d
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20026: test: typo in a functional test doc (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20026
< bitcoin-git> bitcoin/master e7e6f0b MarcoFalke: Merge #20026: test: typo in a functional test doc
< bitcoin-git> bitcoin/master a5a6965 kanon: [Trivial] python help message
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/055abfbc5a4d...e7e6f0bf18b9
< bitcoin-git> [bitcoin] jonatack closed pull request #19883: net, rpc: expose connection type in getpeerinfo (master...getpeerinfo-conn-type) https://github.com/bitcoin/bitcoin/pull/19883
< kallewoof> https://github.com/bitcoin/bitcoin/pull/19969 is mostly nit-fixes, and has 2 utACKs and 1 tested ACK (by me); looks ready for merging.

2020-09-27

< bitcoin-git> [bitcoin] sipa opened pull request #20027: Use mockable time everywhere in net_processing (master...202009_mockable_netproc) https://github.com/bitcoin/bitcoin/pull/20027
< bitcoin-git> [bitcoin] decryp2kanon opened pull request #20026: [Trivial] python help message (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20026
< jb55> rebuilding bitcoin/gcc and all transitive deps with the emit_diagnostic patch... hit a pubsub test in zmq and something in icu so far: https://jb55.com/s/31761d3ea0e88b4e.txt
< roconnor> luke-jr: https://gist.github.com/real-or-random/1548239059158370416dfdc6a866329a#gistcomment-3468827 is a patch to instrument GCC 9 (and I think GCC 10). It seems to imply that bitcoin and libsecp256k1 is unaffected by this bug.

2020-09-26

< bitcoin-git> [bitcoin] gzhao408 opened pull request #20025: validation/util: add GetTransactionFee (master...2020-09-getfee) https://github.com/bitcoin/bitcoin/pull/20025
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20023: test: remove unused constants in functional tests (master...20200926-test-remove-unused-constants) https://github.com/bitcoin/bitcoin/pull/20023
< bitcoin-git> bitcoin/master 055abfb MarcoFalke: Merge #20023: test: remove unused constants in functional tests
< bitcoin-git> bitcoin/master 92e28fa Sebastian Falbesoner: test: remove unused constants in functional tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4f45ea1f7393...055abfbc5a4d
< bitcoin-git> bitcoin/master df091b9 Amiti Uttarwar: [refactor] Rename test file to allow any getpeerinfo deprecations.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19725: [RPC] Add connection type to getpeerinfo, improve logs (master...2020-08-getpeerinfo-conn-type) https://github.com/bitcoin/bitcoin/pull/19725
< bitcoin-git> bitcoin/master 395acfa Amiti Uttarwar: [rpc] Add connection type to getpeerinfo RPC, update tests
< bitcoin-git> bitcoin/master 49c10a9 Amiti Uttarwar: [log] Add connection type to log statement
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8aa3a4a49874...4f45ea1f7393
< bitcoin-git> [bitcoin] practicalswift opened pull request #20024: init: Fix incorrect warning "Reducing -maxconnections from N to N-1, because of system limitations" (master...fix-incorrect-warning) https://github.com/bitcoin/bitcoin/pull/20024
< gloriazhao> Would someone be able to restart Travis for me please? https://travis-ci.org/github/bitcoin/bitcoin/jobs/730095344
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20022: test: use explicit p2p objects where available (master...p2p-conn-rename) https://github.com/bitcoin/bitcoin/pull/20022
< bitcoin-git> bitcoin/master 8aa3a4a MarcoFalke: Merge #20022: test: use explicit p2p objects where available
< bitcoin-git> bitcoin/master 0fcaf73 Oliver Gugger: test: use explicit p2p objects where available
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/78f912c9010f...8aa3a4a49874
< bitcoin-git> [bitcoin] theStack opened pull request #20023: test: remove unused constants in functional tests (master...20200926-test-remove-unused-constants) https://github.com/bitcoin/bitcoin/pull/20023
< bitcoin-git> [bitcoin] guggero opened pull request #20022: test: use explicit p2p objects where available (master...p2p-conn-rename) https://github.com/bitcoin/bitcoin/pull/20022

2020-09-25

< bitcoin-git> [bitcoin] dongcarl opened pull request #20019: depends: Properly pass $PATH to configure and pin (master...2020-09-resolve-PATH-prepending-madness) https://github.com/bitcoin/bitcoin/pull/20019
< bitcoin-git> [bitcoin] dhruv opened pull request #20018: p2p: ProcessAddrFetch(-seednode) is unnecessary if -connect is specified (master...seednode-not-needed-with-connect) https://github.com/bitcoin/bitcoin/pull/20018
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #20017: rpc: Add RPCContext (master...2020-09-rpcontext) https://github.com/bitcoin/bitcoin/pull/20017
< bitcoin-git> [bitcoin] ajtowns opened pull request #20016: uint256: 1 is a constant (master...202009-uint256_1) https://github.com/bitcoin/bitcoin/pull/20016
< bitcoin-git> [bitcoin] gr0kchain opened pull request #20015: doc: Added default signet config for linearize script (master...master) https://github.com/bitcoin/bitcoin/pull/20015
< bitcoin-git> [bitcoin] hebasto opened pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property (master...test-p2p-property) https://github.com/bitcoin/bitcoin/pull/19804
< bitcoin-git> bitcoin/master 549d30f gzhao408: scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx
< bitcoin-git> bitcoin/master 7a0de46 gzhao408: [doc] sample code for test framework p2p objects
< bitcoin-git> bitcoin/master 784f757 gzhao408: [refactor] clarify tests by referencing p2p objects directly
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1b313cacc99a...78f912c9010f
< hebasto> jonasschnelli: fanquake: begging review for https://github.com/bitcoin-core/gui/pull/46
< bitcoin-git> [bitcoin] kallewoof closed pull request #19957: rpc: alias helper (master...202009-rpc-alias) https://github.com/bitcoin/bitcoin/pull/19957
< bitcoin-git> [bitcoin] kallewoof opened pull request #20013: rpc: normalize parameter names (master...202009-rpc-normalize) https://github.com/bitcoin/bitcoin/pull/20013
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20012: rpc: Remove duplicate name and argNames from CRPCCommand (master...2009-rpcCheckMapping) https://github.com/bitcoin/bitcoin/pull/20012
< fanquake> MarcoFalke: FYI the bot seems to have run out of disk: https://github.com/bitcoin/bitcoin/pull/19868#issuecomment-698680164

2020-09-24

< elichai2> lol `base_uint` in arith_uint256.h seems to have dodged the bullet by pure luck https://github.com/bitcoin/bitcoin/blob/master/src/arith_uint256.h#L217-L222
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 13 blockers, 1 bugfix, 2 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< bitcoin-git> [bitcoin] jnewbery closed pull request #19759: [doc] Struct members should have m_ prefix (master...2020-08-struct-members) https://github.com/bitcoin/bitcoin/pull/19759
< bitcoin-git> [bitcoin] laanwj merged pull request #20008: [Backport] #19839 and #19842 to v0.20 (0.20...2020-09-appveyor-backport) https://github.com/bitcoin/bitcoin/pull/20008
< bitcoin-git> bitcoin/0.20 80aa83a Wladimir J. van der Laan: Merge #20008: [Backport] #19839 and #19842 to v0.20
< bitcoin-git> bitcoin/0.20 498b7cb Aaron Clauson: Update the vcpkg checkout commit ID in appveyor config.
< bitcoin-git> bitcoin/0.20 ad99777 Aaron Clauson: Set appveyor vm version to previous Visual Studio 2019 release.
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/30926997fa15...80aa83aa4064
< bitcoin-git> [bitcoin] naumenkogs reopened pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< bitcoin-git> [bitcoin] jnewbery opened pull request #20008: [Backport] #19839 and #19842 to v0.20 (0.20...2020-09-appveyor-backport) https://github.com/bitcoin/bitcoin/pull/20008
< bitcoin-git> [bitcoin] naumenkogs reopened pull request #19958: p2p: Better document features of feelers (master...2020-09-rename-feeler-to-probe) https://github.com/bitcoin/bitcoin/pull/19958
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19958: p2p: Better document features of feelers (master...2020-09-rename-feeler-to-probe) https://github.com/bitcoin/bitcoin/pull/19958
< roconnor> https://github.com/bitcoin/bitcoin/blob/0.20/src/netaddress.cpp#L237 also. ... assuming that IsIPv4 somehow isn't always returning true.
< bitcoin-git> [bitcoin] ajtowns closed pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970

2020-09-23

< bitcoin-git> [bitcoin] sanket1729 opened pull request #20006: Fix misleading error message: Clean stack rule (master...clean_stk) https://github.com/bitcoin/bitcoin/pull/20006
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19927: validation: Reduce direct g_chainman usage (master...2020-09-reduce-g_chainman-usage) https://github.com/bitcoin/bitcoin/pull/19927
< bitcoin-git> bitcoin/master f8d4975 Carl Dong: validation: Move PruneOneBlockFile to BlockManager
< bitcoin-git> bitcoin/master 74f73c7 Carl Dong: validation: Pass in chainman to UnloadBlockIndex
< bitcoin-git> bitcoin/master 4668ded Carl Dong: validation: Move ~CMainCleanup logic to ~BlockManager
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/43305e9810e4...1b313cacc99a
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19868: build: Fix target name (master...200904-make) https://github.com/bitcoin/bitcoin/pull/19868
< bitcoin-git> bitcoin/master 43305e9 MarcoFalke: Merge #19868: build: Fix target name
< bitcoin-git> bitcoin/master 7a89f2e Hennadii Stepanov: build: Fix target name
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5e14fafb316e...43305e9810e4
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19994: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet) (master...2009-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19994
< bitcoin-git> bitcoin/master 5e14faf MarcoFalke: Merge #19994: Assert that RPCArg names are equal to CRPCCommand ones (net,...
< bitcoin-git> bitcoin/master fa14f57 MarcoFalke: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8235dca6210d...5e14fafb316e
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19979: Replace LockAssertion with AssertLockHeld, remove LockAssertion (master...200919-tsa) https://github.com/bitcoin/bitcoin/pull/19979
< bitcoin-git> bitcoin/master 0bd1184 Hennadii Stepanov: Remove unused LockAssertion struct
< bitcoin-git> bitcoin/master ab2a442 Hennadii Stepanov: Replace LockAssertion with a proper thread safety annotations
< bitcoin-git> bitcoin/master 73f71e1 Hennadii Stepanov: refactor: Use explicit function type instead of template
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e217f5a6f08...8235dca6210d
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20004: test: Add signet witness commitment section parse tests (master...2009-testSignetParse) https://github.com/bitcoin/bitcoin/pull/20004
< gribble> https://github.com/bitcoin/bitcoin/issues/19043 | torcontrol: add -tortarget config by MDrollette · Pull Request #19043 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20003: net: Print error message if -proxy is specified without arguments (instead of continuing without proxy server) (master...error-on-empty-proxy) https://github.com/bitcoin/bitcoin/pull/20003
< bitcoin-git> [bitcoin] practicalswift closed pull request #20001: net: Use proxy server 127.0.0.1 if -proxy is specified without arguments (instead of continuing without proxy server) (master...use-localhost-instead-of-silently-skipping-proxy) https://github.com/bitcoin/bitcoin/pull/20001
< bitcoin-git> [bitcoin] laanwj merged pull request #19572: ZMQ: Create "sequence" notifier, enabling client-side mempool tracking (master...zmq_sequence_all) https://github.com/bitcoin/bitcoin/pull/19572
< bitcoin-git> bitcoin/master 68c3c7e Gregory Sanders: Add functional tests for zmq sequence topic and mempool sequence logic
< bitcoin-git> bitcoin/master e76fc2b Gregory Sanders: Add 'sequence' zmq publisher to track all block (dis)connects, mempool del...
< bitcoin-git> bitcoin/master 1b615e6 Gregory Sanders: zmq test: Actually make reorg occur
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/821989382557...9e217f5a6f08
< bitcoin-git> [bitcoin] jonatack opened pull request #20002: net, rpc, cli: expose CNetAddr::GetNetClass in getpeerinfo, use in -netinfo (master...getpeerinfo-GetNetClass) https://github.com/bitcoin/bitcoin/pull/20002
< bitcoin-git> [bitcoin] practicalswift opened pull request #20001: net: Use default proxy server (127.0.0.1:9050) if -proxy is specified without arguments (instead of continuing without proxy server) (master...use-localhost-instead-of-silently-skipping-proxy) https://github.com/bitcoin/bitcoin/pull/20001
< gribble> https://github.com/bitcoin/bitcoin/issues/19606 | Backport wtxid relay to v0.20 by jnewbery · Pull Request #19606 · bitcoin/bitcoin · GitHub
< vasild> luke-jr: https://github.com/bitcoin/bips/pull/907 can be merged? It has 4 ACKs, including from the BIP author (wumpus).
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19993: refactor: Signet fixups (master...2009-signetFixups) https://github.com/bitcoin/bitcoin/pull/19993
< bitcoin-git> bitcoin/master fae0548 MarcoFalke: fuzz: Remove needless guard
< bitcoin-git> bitcoin/master 77771a0 MarcoFalke: refactor: Remove SignetTxs::m_valid and use optional instead
< bitcoin-git> bitcoin/master fa2ad5d MarcoFalke: test: Run signet test even when wallet was not compiled
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b1291b2e8fc3...821989382557
< bitcoin-git> [bitcoin] vasild opened pull request #20000: test: fix DecodeBase32 tests (master...fix_base32_tests) https://github.com/bitcoin/bitcoin/pull/20000
< gribble> https://github.com/bitcoin/bitcoin/issues/20000 | HTTP Error 404: Not Found

2020-09-22

< bitcoin-git> [bitcoin] fanquake closed pull request #19751: depends: Split libpng out of Qt (master...depends_libpng) https://github.com/bitcoin/bitcoin/pull/19751
< bitcoin-git> [bitcoin] hebasto opened pull request #19998: rpc: Add `via_tor` to `getpeerinfo` output (master...200922-istor) https://github.com/bitcoin/bitcoin/pull/19998
< bitcoin-git> [bitcoin] sipa opened pull request #19997: History for Taproot PR #19953 (master...taproot-history) https://github.com/bitcoin/bitcoin/pull/19997
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19963: Clarify blocksonly whitelistforcerelay test (master...clarify-whitelist-force-relay-test) https://github.com/bitcoin/bitcoin/pull/19963
< bitcoin-git> bitcoin/master e153448 t-bast: Clarify blocksonly whitelistforcerelay test
< bitcoin-git> bitcoin/master b1291b2 MarcoFalke: Merge #19963: Clarify blocksonly whitelistforcerelay test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7eb85d00593...b1291b2e8fc3
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19959: build: patch qt libpng to fix powerpc build (master...powerpc_libpng_qt) https://github.com/bitcoin/bitcoin/pull/19959
< bitcoin-git> bitcoin/master c7eb85d MarcoFalke: Merge #19959: build: patch qt libpng to fix powerpc build
< bitcoin-git> bitcoin/master f07fb5a fanquake: build: patch qt libpng to fix powerpc build
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d692d192cda3...c7eb85d00593
< bitcoin-git> [bitcoin] practicalswift opened pull request #19995: log: Mitigate disk filling attacks by rate limiting LogPrintf(…) (master...mitigate-log-disk-filling-attacks) https://github.com/bitcoin/bitcoin/pull/19995
< sipa> i suspect some of bitcoin core's unit tests may be affected too
< gribble> https://github.com/bitcoin/bitcoin/issues/19315 | [tests] Allow outbound & block-relay-only connections in functional tests. by amitiuttarwar · Pull Request #19315 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19994: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet) (master...2009-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19994
< gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
< jnewbery> #topic Overview of https://github.com/bitcoin/bitcoin/pull/19988 (motivation/design philosphy rather than technical details that can be found in the PR)
< jnewbery> and to me, the wiki feels like the obvious place. This is information about Bitcoin Core's policy that is being communicated to external developers
< jnewbery> I don't think p2p policy belongs in BIPs. https://github.com/bitcoin-core/bitcoin-devwiki/wiki seems like a more appropriate place for it
< sdaftuar> i think it's reasonable to ask whether policy changes to Bitcoin Core should always be documented in a BIP so that wallet authors can take those changes into account
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction) (master...2008-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19849
< bitcoin-git> bitcoin/master d692d19 MarcoFalke: Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (bloc...
< bitcoin-git> bitcoin/master fa6bb0c MarcoFalke: Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction)
< bitcoin-git> bitcoin/master fa80c81 MarcoFalke: Assert that RPCArg names are equal to CRPCCommand ones (blockchain)
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/77376034d4ab...d692d192cda3
< gribble> https://github.com/bitcoin/bitcoin/issues/19820 | Transactions propagation design goals · Issue #19820 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19958 | Rename feelers to probes by naumenkogs · Pull Request #19958 · bitcoin/bitcoin · GitHub
< jnewbery> - Overview of https://github.com/bitcoin/bitcoin/pull/19988 (motivation/design philosphy rather than technical details that can be found in the PR)
< gribble> https://github.com/bitcoin/bitcoin/issues/19820 | Transactions propagation design goals · Issue #19820 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/22 | Update the list of hard-coded node IP addresses · Issue #22 · bitcoin/bitcoin · GitHub
< jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< gribble> https://github.com/bitcoin/bitcoin/issues/19958 | Rename feelers to probes by naumenkogs · Pull Request #19958 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/22 | Update the list of hard-coded node IP addresses · Issue #22 · bitcoin/bitcoin · GitHub
< jnewbery> Hi folks. There's a P2P meeting today in an hour. We have one proposed topic: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#22-sept-2020. Feel free to propose more in the next hour.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19993: refactor: Signet fixups (master...2009-signetFixups) https://github.com/bitcoin/bitcoin/pull/19993
< bitcoin-git> [bitcoin] hebasto opened pull request #19991: net: Use alternative port for incoming Tor connections (master...200922-tor) https://github.com/bitcoin/bitcoin/pull/19991
< gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ariard reopened pull request #19871: doc: Clarify scope of eviction protection of outbound block-relay peers (master...2020-09-clarify-eviction-block-relay) https://github.com/bitcoin/bitcoin/pull/19871
< bitcoin-git> [bitcoin] ariard closed pull request #19871: doc: Clarify scope of eviction protection of outbound block-relay peers (master...2020-09-clarify-eviction-block-relay) https://github.com/bitcoin/bitcoin/pull/19871

2020-09-21

< bitcoin-git> [bitcoin] laanwj merged pull request #17785: p2p: Unify Send and Receive protocol versions (master...20191220-unify-protocol-versions) https://github.com/bitcoin/bitcoin/pull/17785
< bitcoin-git> bitcoin/master e084d45 Hennadii Stepanov: p2p: Remove SetCommonVersion() from VERACK handler
< bitcoin-git> bitcoin/master 8d20267 Hennadii Stepanov: refactor: Rename local variable nSendVersion
< bitcoin-git> bitcoin/master e9a6d8b Hennadii Stepanov: p2p: Unify Send and Receive protocol versions
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8c5f68118cd0...77376034d4ab
< bitcoin-git> [bitcoin] laanwj merged pull request #18267: BIP-325: Signet [consensus] (master...2003-signet-consensus) https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> bitcoin/master e8990f1 Karl-Johan Alm: add signet chain and accompanying parameters
< bitcoin-git> bitcoin/master 404682b Karl-Johan Alm: add signet basic support (signet.cpp)
< bitcoin-git> bitcoin/master a2147d7 Karl-Johan Alm: validation: move GetWitnessCommitmentIndex to consensus/validation
< bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/c0c409dcd330...8c5f68118cd0
< gribble> https://github.com/bitcoin/bitcoin/issues/17785 | p2p: Unify Send and Receive protocol versions by hebasto · Pull Request #17785 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #19697: Improvements on ADDR caching (master...2020-08-addr-cache-follow-up) https://github.com/bitcoin/bitcoin/pull/19697
< bitcoin-git> bitcoin/master 83ad65f Gleb Naumenko: Address nits in ADDR caching
< bitcoin-git> bitcoin/master 81b00f8 Gleb Naumenko: Add indexing ADDR cache by local socket addr
< bitcoin-git> bitcoin/master 42ec558 Gleb Naumenko: Justify the choice of ADDR cache lifetime
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b99a1633b270...c0c409dcd330
< gribble> https://github.com/bitcoin/bitcoin/issues/18750 | build: optionally skip external warnings by vasild · Pull Request #18750 · bitcoin/bitcoin · GitHub
< vasild> hebasto: https://github.com/bitcoin/bitcoin/pull/18750#pullrequestreview-492222732 -- what is that crash? Do you think it may be related to the PR in some way?
< kallewoof> Signet PR now has 2 tACKs, 1 Approach ACK, and one misc review; please add yours :) https://github.com/bitcoin/bitcoin/pull/18267
< gribble> https://github.com/bitcoin/bitcoin/issues/19697 | Improvements on ADDR caching by naumenkogs · Pull Request #19697 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #19988: Overhaul transaction request logic (master...202009_txrequest_rand_wtxid) https://github.com/bitcoin/bitcoin/pull/19988
< bitcoin-git> [bitcoin] sipa closed pull request #19184: Overhaul transaction request logic (master...202004_txrequest_rand) https://github.com/bitcoin/bitcoin/pull/19184
< bitcoin-git> [bitcoin] fanquake closed pull request #19987: fix: remove confusing warning (#16343 #19603) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19987
< bitcoin-git> [bitcoin] monperrus opened pull request #19987: fix: remove confusing warning (#16343 #19603) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19987

2020-09-20

< bitcoin-git> [bitcoin] maskoficarus opened pull request #19986: Update scriptpubkeyman.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/19986
< bitcoin-git> [bitcoin] n-thumann opened pull request #19985: net: Prevent routing of deprecated Site Local IPv6 (master...net-deprecate-site-local-ipv6) https://github.com/bitcoin/bitcoin/pull/19985
< bitcoin-git> [bitcoin] practicalswift opened pull request #19984: log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)" (master...logging-should-not-be-static-department) https://github.com/bitcoin/bitcoin/pull/19984
< bitcoin-git> [bitcoin] hebasto opened pull request #19983: Drop some TSan suppressions (master...200920-supp) https://github.com/bitcoin/bitcoin/pull/19983
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19781: test: add parameterized constructor for msg_sendcmpct() (master...20200823-test-extend-msg_sendcmpct_ctor) https://github.com/bitcoin/bitcoin/pull/19781
< bitcoin-git> bitcoin/master b99a163 MarcoFalke: Merge #19781: test: add parameterized constructor for msg_sendcmpct()
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38fd1bdcd4a5...b99a1633b270
< bitcoin-git> bitcoin/master 6384419 Sebastian Falbesoner: test: add parameterized constructor for msg_sendcmpct()
< bitcoin-git> [bitcoin] hebasto opened pull request #19982: test: Fix inconsistent lock order in wallet_tests/CreateWalletFromFile (master...200920-leave-cs) https://github.com/bitcoin/bitcoin/pull/19982
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18949: doc: Add CODEOWNERS file to automatically nominate PR reviewers (master...2020-5-add-codeowners) https://github.com/bitcoin/bitcoin/pull/18949
< bitcoin-git> bitcoin/master 38fd1bd MarcoFalke: Merge #18949: doc: Add CODEOWNERS file to automatically nominate PR review...
< bitcoin-git> bitcoin/master a06eb03 Adam Jonas: doc: Add comments and additional reviewers to CODEOWNERS file
< bitcoin-git> bitcoin/master e02da22 Wladimir J. van der Laan: doc: Add CODEOWNERS file
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/831b0ecea915...38fd1bdcd4a5

2020-09-19

< bitcoin-git> [bitcoin] promag opened pull request #19980: 2020 09 wallet cleanups (master...2020-09-wallet-cleanups) https://github.com/bitcoin/bitcoin/pull/19980
< bitcoin-git> [bitcoin] prayank23 closed pull request #19945: Remove connect_nodes global and Replace connect_nodes(self.nodes[a], b) with self.connect_nodes(a, b) (master...master) https://github.com/bitcoin/bitcoin/pull/19945
< bitcoin-git> [bitcoin] fanquake closed pull request #17463: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...gui_custom_sendyes) https://github.com/bitcoin/bitcoin/pull/17463
< bitcoin-git> [bitcoin] fanquake closed pull request #15115: GUI: Replace send-to-self with dual send+receive entries (master...rm_send2self) https://github.com/bitcoin/bitcoin/pull/15115
< yanmaani> Do I just describe it informally on the mailing list and ask something like "Would you consider a BIP to this effect to be potentially suitable for inclusion in the Bitcoin protocol?"
< bitcoin-git> [bitcoin] hebasto opened pull request #19979: Use proper TSA attributes (attempt two) (master...200919-tsa) https://github.com/bitcoin/bitcoin/pull/19979
< bitcoin-git> [bitcoin] fanquake merged pull request #13686: ZMQ: Small cleanups in the ZMQ code (master...zmq-cleanup) https://github.com/bitcoin/bitcoin/pull/13686
< bitcoin-git> bitcoin/master 7f2ad1b Daniel Kraft: Use std::unique_ptr for CZMQNotifierFactory.
< bitcoin-git> bitcoin/master b93b9d5 Daniel Kraft: Simplify and fix notifier removal on error.
< bitcoin-git> bitcoin/master e15b1cf Daniel Kraft: Various cleanups in zmqnotificationinterface.
< bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/83b23848f730...831b0ecea915
< bitcoin-git> [bitcoin] fanquake merged pull request #18790: gui: Improve thread naming (master...200427-name-qthread) https://github.com/bitcoin/bitcoin/pull/18790
< bitcoin-git> bitcoin/master ad5f614 Hennadii Stepanov: qt: Name ClientModel timer QThread
< bitcoin-git> bitcoin/master 2c7f5d8 Hennadii Stepanov: qt: Name WalletController worker QThread
< bitcoin-git> bitcoin/master 27dcc37 Hennadii Stepanov: qt: Name RPCConsole executor QThread
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c30f79d418e2...83b23848f730
< bitcoin-git> [bitcoin] fanquake merged pull request #19940: rpc: Return fee and vsize from testmempoolaccept (master...rpc-testmempoolaccept-fee) https://github.com/bitcoin/bitcoin/pull/19940
< bitcoin-git> bitcoin/master c30f79d fanquake: Merge #19940: rpc: Return fee and vsize from testmempoolaccept
< bitcoin-git> bitcoin/master 23c35bf gzhao408: [test] add get_vsize util for more programmatic testing
< bitcoin-git> bitcoin/master 2233a93 codeShark149: [rpc] Return fee and vsize from testmempoolaccept
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/967be53aeec9...c30f79d418e2
< kallewoof> tryphe_: i'm all for making it more known, but not sure where to do so. perhaps add an entry about it to the bitcoin wiki might be a good idea
< bitcoin-git> [bitcoin] fanquake merged pull request #19971: test: create default wallet in extended tests (master...2020/09/fix_no_default_wallet_extended_tests) https://github.com/bitcoin/bitcoin/pull/19971
< bitcoin-git> bitcoin/master 967be53 fanquake: Merge #19971: test: create default wallet in extended tests
< bitcoin-git> bitcoin/master a5f5374 Sjors Provoost: test: create default wallet in extended tests
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/652c45fdbbd5...967be53aeec9
< tryphe_> also slightly related, when users look to enable features, they do ./bitcoind -help, ./bitcoin-cli -help, but not necessarily ./bitcoin-cli help, so they might not even stumble on setwalletflag. but not sure how to effectively get people to do this :(
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub

2020-09-18

< bitcoin-git> [bitcoin] practicalswift opened pull request #19972: tests: Add fuzzing harness for node eviction logic (master...fuzzers-eviction-logic) https://github.com/bitcoin/bitcoin/pull/19972
< bitcoin-git> [bitcoin] Sjors opened pull request #19971: test: create default wallet in extended tests (master...2020/09/fix_no_default_wallet_extended_tests) https://github.com/bitcoin/bitcoin/pull/19971
< gribble> https://github.com/bitcoin/bitcoin/issues/15454 | Remove the automatic creation and loading of the default wallet by achow101 · Pull Request #15454 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15454 | Remove the automatic creation and loading of the default wallet by achow101 · Pull Request #15454 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19970 | sync.h: fix LockAssertion error reporting by ajtowns · Pull Request #19970 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ajtowns opened pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970
< kallewoof> I switched to squeezecase and pushed change, FWIW. (Re-)review would be glorious. https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> [bitcoin] meshcollider merged pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454
< bitcoin-git> bitcoin/master 652c45f Samuel Dobson: Merge #15454: Remove the automatic creation and loading of the default wal...
< bitcoin-git> bitcoin/master d26f064 Andrew Chow: Tell users how to load or create a wallet when no wallet is loaded
< bitcoin-git> bitcoin/master 1bee1e6 Andrew Chow: Do not create default wallet
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/be3af4f31089...652c45fdbbd5

2020-09-17

< jonatack> vasild: Ok now have the node advertising both torv2 and torv3 local addresses...just needed to set proxy=127.0.0.1:9050 rather than letting bitcoin core create a tor HS automatically, as you mentioned
< vasild> 19954 is only about when bitcoin core creates a tor hidden service automatically via the tor control connection -- it would start creating torv3 with that PR
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: make a TORv3 hidden service instead of TORv2 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< sipa> "Bitcoin Core developer claims enabling debugging introduces bug"
< ryanofsky> For AssertLockHeld PRs, I just wanted to advertise wiki page https://github.com/bitcoin-core/bitcoin-devwiki/wiki/AssertLockHeld-PRs
< jnewbery> is https://github.com/bitcoin-core/qa-assets used for test assets?
< gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
< sipa> as it turned out that there is some risk it is encumbered by a patent, the GLV optimization was made optional, and defaults to off (and has been off in every bitcoin core release)
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< wumpus> PSA: the release schedule deadlines for 0.21 start october 1: https://github.com/bitcoin/bitcoin/issues/18947
< gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 12 blockers, 1 bugfix, 2 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james