< bitcoin-git>
[bitcoin] PiRK opened pull request #20857: update docstring in feature_csv_activation.py to account for 17921 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20857
< bitcoin-git>
bitcoin/master a0eb4c5 Pieter Wuille: Revert "Add patch to make codesign_allocate compatible with Apple's"
< jonasschnelli>
Users just care about a valid signature. Anyone can register at apple, get a valid signing key and sign a mallicious bitcoin core binary.
< jonasschnelli>
the private key is property of "Bitcoin Core Code Signing Association" (this is no joke).
< sipa>
tiny downside... anyone could sign binaries pretending to be bitcoin core
< bitcoin-git>
[bitcoin] sipa opened pull request #20855: Revert "Add patch to make codesign_allocate compatible with Apple's" (master...202101_revert_codesign_allocate_hack) https://github.com/bitcoin/bitcoin/pull/20855
< jonasschnelli>
As for rc4: i tried on macOS 11, verified the hash of bitcoin-0.21.0rc4-osx-unsigned.tar.gz (matched the others), verified the patched codesign_allocate, signed locally, verified the signed app (ok), gbuilt the signer with the created signature (failed)
< jonasschnelli>
the detached-sig-apply.sh takes the binary in bitcoin-0.21.0rc3-osx-unsigned.tar.gz, right?
< jonasschnelli>
^ the codesign_allocate is part of the bitcoin-0.21.0rc3-osx-unsigned.tar.gz? right?
< bitcoin-git>
[bitcoin] vasild opened pull request #20849: net: disconnect peers by address without using a subnet (master...disconnect_by_subnet_fix) https://github.com/bitcoin/bitcoin/pull/20849
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20845: net: Log to net debug in MaybeDiscourageAndDisconnect except for noban and manual peers (master...2101-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/20845
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20844: test: Add sanitizer suppressions for AMD EPYC CPUs (master...2101-testEpycSan) https://github.com/bitcoin/bitcoin/pull/20844
< bitcoin-git>
[bitcoin] hebasto closed pull request #20824: build: Do not set _FORTIFY_SOURCE if it causes compiler warnings (master...210101-fortify) https://github.com/bitcoin/bitcoin/pull/20824
< jonasschnelli>
used the signature to gbuild the signer: ./bin/gbuild --num-make 6 -j11 --memory 5000 --url bitcoin=/home/jonasschnelli/gitian/bitcoin --commit signature=v0.21.0rc4
< jonasschnelli>
Created the signature: ./detached-sig-create.sh -s "Bitcoin"
< jonasschnelli>
- Verified bitcoin-0.21.0rc4-osx-unsigned.tar.gz, got the correct 10ae57ee735cd2a894a75165082c384769da3b634eca9346b1d20585e1edfd0c
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (master...2012-rpcStdVariant) https://github.com/bitcoin/bitcoin/pull/20736
< bitcoin-git>
bitcoin/master bc8ada1 MarcoFalke: Merge #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_f...
< bitcoin-git>
bitcoin/master fa749fb MarcoFalke: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback
< bitcoin-git>
[gui] hebasto reopened pull request #174: refactor: No need to implement index for non-hierarchical models (master...210102-index) https://github.com/bitcoin-core/gui/pull/174
< bitcoin-git>
[gui] hebasto closed pull request #174: refactor: No need to implement index for non-hierarchical models (master...210102-index) https://github.com/bitcoin-core/gui/pull/174
< bitcoin-git>
[gui] hebasto opened pull request #174: refactor: No need to implement index for non-hierarchical models (master...210102-index) https://github.com/bitcoin-core/gui/pull/174
< bitcoin-git>
[gui] hebasto opened pull request #173: Follow Qt docs when implementing rowCount and columnCount (master...210102-table) https://github.com/bitcoin-core/gui/pull/173
< bitcoin-git>
[bitcoin] luke-jr opened pull request #20827: During IBD, prune as much as possible until we get close to where we will eventually keep blocks (master...ibd_prune_max) https://github.com/bitcoin/bitcoin/pull/20827
< bitcoin-git>
[bitcoin] BlockMechanic closed pull request #20814: qt: Request Android permissions on APi >= 23 (master...Fix-Android-Permissions) https://github.com/bitcoin/bitcoin/pull/20814
2021-01-01
< bitcoin-git>
[bitcoin] hebasto opened pull request #20824: build: Do not set _FORTIFY_SOURCE if it causes compiler warnings (master...210101-fortify) https://github.com/bitcoin/bitcoin/pull/20824
< bitcoin-git>
[bitcoin] nginocchio opened pull request #20808: test: Run rpc_generateblock.py even with wallet disabled (master...iss20078) https://github.com/bitcoin/bitcoin/pull/20808
2020-12-30
< bitcoin-git>
[bitcoin] emilengler opened pull request #20805: doc: Update license year range to 2021 (master...2020-12-update-license-year-range-to-2021) https://github.com/bitcoin/bitcoin/pull/20805
< sipa>
i'm not so much worried about such clients on the public network (we'd know, or at least be able to add monitoring for that to figure out), but there could be software communicating locally with bitcoin core (things like joinmarket, lightning clients, indexers, ...), for which we wouldn't really know
< phantomcircuit>
ariard, iirc bitcoin never does that but various modified clients do
< bitcoin-git>
[bitcoin] jnewbery opened pull request #20799: net processing: Only support compact blocks with witnesses (master...2020-12-remove-cmpctblock-v1) https://github.com/bitcoin/bitcoin/pull/20799
< bitcoin-git>
[bitcoin] jonatack opened pull request #20778: net, p2p, gui: replace direction with connection type in gui peer details window (master...display-peer-conn-types) https://github.com/bitcoin/bitcoin/pull/20778
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20756: [doc] Add missing field (permissions) to the getpeerinfo help (master...2020-12-getpeerinfo-permissions) https://github.com/bitcoin/bitcoin/pull/20756
< bitcoin-git>
bitcoin/master 02cf20b MarcoFalke: Merge #20756: [doc] Add missing field (permissions) to the getpeerinfo hel...
< bitcoin-git>
bitcoin/master 667d203 Amiti Uttarwar: [doc] Add permissions to the getpeerinfo help.
< jonatack>
I was thinking it might be good to have a detailed help doc for -netinfo, either with "help -netinfo", or expand the existing one at "./src/bitcoin-cli -h | grep -A3 netinfo", or add a doc/netinfo.md file
< jonatack>
(for more detailed help than in ./src/bitcoin-cli -h)
< jonatack>
Is there a reason why we don't have help for CLI options? e.g. ./src/bitcoin-cli help -getinfo, ./src/bitcoin-cli help -netinfo
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20771: refactor: Enable -Wswitch for FeeEstimateHorizon (master...2012-WswitchFeeEstimateHorizon) https://github.com/bitcoin/bitcoin/pull/20771
< bitcoin-git>
[bitcoin] jadijadi opened pull request #20769: net: fixes #20657 - Advertised address where nobody is listening (master...fixes-issue-20657) https://github.com/bitcoin/bitcoin/pull/20769
2020-12-25
< bitcoin-git>
[gui] hebasto opened pull request #166: refactor: Use enum type as switch argument in *TableModel (master...201225-header) https://github.com/bitcoin-core/gui/pull/166