2019-04-16

< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/fa3993bfe856...e57462c6ba60
< bitcoin-git> bitcoin/0.18 7fcbe7d Pieter Wuille: Keep full pubkeys in FlatSigningProvider::origins
< bitcoin-git> bitcoin/0.18 802dcd3 Pieter Wuille: Import all origin info in importmulti; even for non-importing pubkeys
< bitcoin-git> bitcoin/0.18 235550d Pieter Wuille: Take non-importing keys into account for spendability warning in descripto...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15803: [0.18] Backport 15749: importmulti only imports origin info for PKH outputs (0.18...201904_backport_15749) https://github.com/bitcoin/bitcoin/pull/15803
< gmaxwell> there was some bitcoin wallet that was spellcheck leaking its key field recently
< gmaxwell> you can use bash programmable completion so that tab works with bitcoin-cli if you really want...
< wumpus> it doesn't matter for programmatic use; I guess aliases on bitcoin-cli could be a thing
< gribble> https://github.com/bitcoin/bitcoin/issues/15615 | Add log output during initial header sync by jonasschnelli · Pull Request #15615 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #15826: Pure python EC (master...201904_pythonec) https://github.com/bitcoin/bitcoin/pull/15826
< bitcoin-git> [bitcoin] laanwj closed pull request #15791: net: Hardcoded seeds update for 0.18 (master...2019_04_hardcoded_seeds_update) https://github.com/bitcoin/bitcoin/pull/15791

2019-04-15

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/78295e97b8d3...598323911e93
< bitcoin-git> bitcoin/master aa410c2 João Barbosa: rpc: Validate maxfeerate with AmountFromValue
< bitcoin-git> bitcoin/master 5983239 MarcoFalke: Merge #15770: rpc: Validate maxfeerate with AmountFromValue
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15770: rpc: Validate maxfeerate with AmountFromValue (master...2019-04-maxfeerate) https://github.com/bitcoin/bitcoin/pull/15770
< bitcoin-git> [bitcoin] dongcarl opened pull request #15824: docs: Improve netbase comments (master...2019-04-netbase-comments) https://github.com/bitcoin/bitcoin/pull/15824
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15821: doc: Remove upgrade note in release notes from EOL versions (master...1904-docRelEOL) https://github.com/bitcoin/bitcoin/pull/15821
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
< bitcoin-git> [bitcoin] dongcarl opened pull request #15820: docs: Add productivity notes for dummy rebases (master...2019-04-more-productive) https://github.com/bitcoin/bitcoin/pull/15820
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/f42ed1442ec2...fa3993bfe856
< bitcoin-git> bitcoin/0.18 b3a04c9 John Newbery: [rpc] Remove the addresses field from the getaddressinfo return object
< bitcoin-git> bitcoin/0.18 fa3993b MarcoFalke: Merge #15800: Backport: [rpc] Remove the addresses field from the getaddre...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15800: Backport: [rpc] Remove the addresses field from the getaddressinfo return object (0.18...2019_04_remove_address_from_getaddressinfo_0.18) https://github.com/bitcoin/bitcoin/pull/15800
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15788: test: Unify testing setups for fuzz, bench, and unit tests (master...1904-testUnify) https://github.com/bitcoin/bitcoin/pull/15788
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2209b3ba25de...78295e97b8d3
< bitcoin-git> bitcoin/master 666696b MarcoFalke: test: Have segwit always active in (Basic)TestingSetup
< bitcoin-git> bitcoin/master fa8685d MarcoFalke: test: Use test_bitcoin setup in bench, Add test utils
< bitcoin-git> bitcoin/master fa82190 MarcoFalke: scripted-diff: Rename test_bitcoin to test/setup_common
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15799: doc: Clarify RPC versioning (master...1904-docRPC) https://github.com/bitcoin/bitcoin/pull/15799
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a854a178166...2209b3ba25de
< bitcoin-git> bitcoin/master fa74749 MarcoFalke: doc: Clarify RPC versioning
< bitcoin-git> bitcoin/master 2209b3b MarcoFalke: Merge #15799: doc: Clarify RPC versioning
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15750: [rpc] Remove the addresses field from the getaddressinfo return object (master...2019_04_remove_address_from_getaddressinfo) https://github.com/bitcoin/bitcoin/pull/15750
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a191b48463a...2a854a178166
< bitcoin-git> bitcoin/master b4338c1 John Newbery: [rpc] Remove the addresses field from the getaddressinfo return object
< bitcoin-git> bitcoin/master 2a854a1 MarcoFalke: Merge #15750: [rpc] Remove the addresses field from the getaddressinfo ret...
< gribble> https://github.com/bitcoin/bitcoin/issues/15819 | macOS: crash while loading wallet with berkeley-db@4 · Issue #15819 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #15818: [0.18] doc backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15818
< bitcoin-git> [bitcoin] laanwj merged pull request #15802: doc: mention creating application support bitcoin folder on OSX (master...fix/macos-docs) https://github.com/bitcoin/bitcoin/pull/15802
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9422e2c29fbc...2a191b48463a
< bitcoin-git> bitcoin/master 8dfbb5c Jack Mallers: doc: mention creating application support bitcoin folder on OSX
< bitcoin-git> bitcoin/master 2a191b4 Wladimir J. van der Laan: Merge #15802: doc: mention creating application support bitcoin folder on ...
< bitcoin-git> [bitcoin] laanwj merged pull request #15792: doc: describe onlynet option in doc/tor.md (master...add-onlynet-option-to-tor-docs) https://github.com/bitcoin/bitcoin/pull/15792
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c6487c74f8c...9422e2c29fbc
< bitcoin-git> bitcoin/master 140bbee Jon Atack: doc: describe onlynet option in doc/tor.md
< bitcoin-git> bitcoin/master 9422e2c Wladimir J. van der Laan: Merge #15792: doc: describe onlynet option in doc/tor.md
< bitcoin-git> [bitcoin] laanwj merged pull request #15790: [0.18] backport #15754 (0.18...0.18) https://github.com/bitcoin/bitcoin/pull/15790
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/164082c822b0...f42ed1442ec2
< bitcoin-git> bitcoin/0.18 60d4621 Ben Carman: rpc: getrpcinfo docs
< bitcoin-git> bitcoin/0.18 f42ed14 Wladimir J. van der Laan: Merge #15790: [0.18] backport #15754
< bitcoin-git> [bitcoin] fanquake closed pull request #15817: trivial: fixed typo (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15817
< bitcoin-git> [bitcoin] merland opened pull request #15817: trivial: fixed typo (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15817
< bitcoin-git> [bitcoin] laanwj merged pull request #15751: Speed up deriveaddresses for large ranges (master...201904_fasterderiveaddresses) https://github.com/bitcoin/bitcoin/pull/15751
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/617261eb1c8b...0c6487c74f8c
< bitcoin-git> bitcoin/master 41a46cb Pieter Wuille: Speed up deriveaddresses for large ranges
< bitcoin-git> bitcoin/master 0c6487c Wladimir J. van der Laan: Merge #15751: Speed up deriveaddresses for large ranges
< bitcoin-git> [bitcoin] laanwj merged pull request #15809: gitignore: plist and dat (master...2019-04-gitignore) https://github.com/bitcoin/bitcoin/pull/15809
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4f4ef3138b06...617261eb1c8b
< bitcoin-git> bitcoin/master e7acf44 James O'Beirne: gitignore: add *.dat
< bitcoin-git> bitcoin/master 17be9e0 James O'Beirne: gitignore: add *.plist (clang-check)
< bitcoin-git> bitcoin/master 617261e Wladimir J. van der Laan: Merge #15809: gitignore: plist and dat
< aj> jonasschnelli: bitcoin-cli logging '["net"]' # turns debug=net back on
< gribble> https://github.com/bitcoin/bitcoin/issues/15776 | Expire inflight GETDATA requests by ajtowns · Pull Request #15776 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #14949: [0.17] Backport #14849 Qt 5.9.7 (0.17...backport-qt-597) https://github.com/bitcoin/bitcoin/pull/14949
< bitcoin-git> [bitcoin] fanquake closed pull request #15815: remove duplicate boundary check in script.cpp (master...remove_duplicate_boundary_check) https://github.com/bitcoin/bitcoin/pull/15815

2019-04-14

< bitcoin-git> [bitcoin] meshcollider merged pull request #15557: Enhance `bumpfee` to include inputs when targeting a feerate (master...bumpall) https://github.com/bitcoin/bitcoin/pull/15557
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/adc55dbac5b5...4f4ef3138b06
< bitcoin-git> bitcoin/master 0ea47ba Gregory Sanders: generalize bumpfee to add inputs when needed
< bitcoin-git> bitcoin/master d08becf Gregory Sanders: add functional tests for feerate bumpfee with adding inputs
< bitcoin-git> bitcoin/master 184f878 Gregory Sanders: wallet_bumpfee.py: add test for change key preservation
< ujjwalt> I'm looking to build some apps on top of Bitcoin Core. Where can I learn more about running BC in production?
< bitcoin-git> [bitcoin] r8921039 opened pull request #15815: remove duplicate boundary check in script.cpp (master...remove_duplicate_boundary_check) https://github.com/bitcoin/bitcoin/pull/15815
< bitcoin-git> [bitcoin] promag closed pull request #15656: wallet: Keep all outputs in bumpfee (master...2019-03-bumpall) https://github.com/bitcoin/bitcoin/pull/15656
< bitcoin-git> [bitcoin] practicalswift opened pull request #15814: Remove all untested unused methods. Add test for bitcoinconsensus_version() to make it technically in use. (master...untested-unused-methods) https://github.com/bitcoin/bitcoin/pull/15814
< bitcoin-git> [bitcoin] promag closed pull request #14458: WIP: Add JSON-RPC interface documentation (master...2018-10-doc-json-rpc) https://github.com/bitcoin/bitcoin/pull/14458
< bitcoin-git> [bitcoin] meshcollider merged pull request #15748: [rpc] remove dead mining code (master...2019_04_simplify_generate) https://github.com/bitcoin/bitcoin/pull/15748
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/66ce95a43400...adc55dbac5b5
< bitcoin-git> bitcoin/master 9819ad6 John Newbery: [rpc] simplify generate RPC
< bitcoin-git> bitcoin/master 1b46a48 John Newbery: [cleanup] Remove unused CReserveKey
< bitcoin-git> bitcoin/master adc55db MeshCollider: Merge #15748: [rpc] remove dead mining code
< gribble> https://github.com/bitcoin/bitcoin/issues/15371 | gui: Uppercase bech32 addresses in qr codes by benthecarman · Pull Request #15371 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15622 | Remove globals: Avoid using the global namespace if possible by practicalswift · Pull Request #15622 · bitcoin/bitcoin · GitHub

2019-04-13

< jnewbery> moneyball: #proposedmeetingtopic Bitcoin Core design documentation
< gribble> https://github.com/bitcoin/bitcoin/issues/9302 | Return txid even if ATMP fails for new transaction by sipa · Pull Request #9302 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] crackercracked opened pull request #15812: not generate coverage report on test failures (master...fix-issue-15648-test-coverage-report) https://github.com/bitcoin/bitcoin/pull/15812
< harding> luke-jr: yes, that's the case. https://github.com/bitcoin/bitcoin/blob/master/src/policy/policy.cpp#L62 I don't see any comments about this on the original implementation, https://github.com/bitcoin/bitcoin/pull/11167/files#diff-d22bc3e058f8982972e2eb381a1df668R79
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15751 | Speed up deriveaddresses for large ranges by sipa · Pull Request #15751 · bitcoin/bitcoin · GitHub

2019-04-12

< bitcoin-git> [bitcoin] jnewbery opened pull request #15810: [WIP] Remove nAbsurdFee fee from AcceptToMemoryPool (master...2019-04-remove-absurd-fee) https://github.com/bitcoin/bitcoin/pull/15810
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15780 | wallet: add cachable accounts for caching credit/debit values by kallewoof · Pull Request #15780 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14447 | Armory 0.96.4 causies BitcoinCore 0.17 crash sometimes · Issue #14447 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< meshcollider> provoostenator is having IRC issues and can't send messages here atm but would like to point out he also has a slightly different (and perhaps less complete) PR open: https://github.com/bitcoin/bitcoin/pull/15487
< bitcoin-git> [bitcoin] jamesob opened pull request #15809: gitignore: plist and dat (master...2019-04-gitignore) https://github.com/bitcoin/bitcoin/pull/15809
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< harding> Wallet files are generally small. If you think a backup is important, it's probably better to just make one automatically and stuff it somewhere in ~/.bitcoin/
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15797 | travis: Bump second timeout to 33 minutes, Add rationale by MarcoFalke · Pull Request #15797 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15797: travis: Bump second timeout to 33 minutes, Add rationale (master...1904-travisTime) https://github.com/bitcoin/bitcoin/pull/15797
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e9cb2d24dbf...66ce95a43400
< bitcoin-git> bitcoin/master fa2dfbf MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
< bitcoin-git> bitcoin/master 66ce95a MarcoFalke: Merge #15797: travis: Bump second timeout to 33 minutes, Add rationale
< bsm117532> BlueMatt: ported your BetterHash mining server code to 0.18: https://github.com/mcelrath/bitcoin/tree/betterhash_bob
< bitcoin-git> [bitcoin] practicalswift closed pull request #15806: contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py (master...remove-SUSPICIOUS_HOSTS) https://github.com/bitcoin/bitcoin/pull/15806
< bitcoin-git> [bitcoin] practicalswift opened pull request #15806: contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py (master...remove-SUSPICIOUS_HOSTS) https://github.com/bitcoin/bitcoin/pull/15806
< bitcoin-git> [bitcoin] practicalswift opened pull request #15805: log: Increase signal-to-noise in bitcoind standard output. Don't print debug output "Pre-allocating to position ..." and "Leaving block file ..." when running with -nodebug (default). (master...stdout-signal-to-noise) https://github.com/bitcoin/bitcoin/pull/15805
< bitcoin-git> [bitcoin] meshcollider opened pull request #15803: [0.18] Backport 15749: importmulti only imports origin info for PKH outputs (0.18...201904_backport_15749) https://github.com/bitcoin/bitcoin/pull/15803
< bitcoin-git> [bitcoin] JimmyMow opened pull request #15802: doc: create application support bitcoin folder (master...fix/macos-docs) https://github.com/bitcoin/bitcoin/pull/15802

2019-04-11

< bitcoin-git> [bitcoin] luke-jr opened pull request #15801: Bugfix: GUI: Options: Initialise prune setting range before loading current value, and remove upper bound limit (master...bugfix_gui_prune_range) https://github.com/bitcoin/bitcoin/pull/15801
< bitcoin-git> [bitcoin] madeken closed pull request #15752: Remove redundant shuffle in KnapsackSolver (master...master) https://github.com/bitcoin/bitcoin/pull/15752
< anddam> I wonder how detached the Qt GUI and bitcoin core are
< anddam> wumpus: when starting bitcoin-qt does a separate bitcoind process get spawnd?
< anddam> (I cannot start bitcoin-qt right now to check)
< anddam> have there been rewrites of bitcoin-core in other languages?
< gribble> https://github.com/bitcoin/bitcoin/issues/1390 | Comply with the XDG Base Directory Specification · Issue #1390 · bitcoin/bitcoin · GitHub
< wumpus> so I"m removing two files from the upload: bitcoin-${VERSIONTO}-win32.zip and bitcoin-${VERSIONTO}-win32-setup.exe
< wumpus> the kind of CPUs that only run 32-bit don't really run bitcoin, you'd be better off with a rpi at that point
< bitcoin-git> [bitcoin] jnewbery opened pull request #15800: [rpc] Remove the addresses field from the getaddressinfo return object (0.18...2019_04_remove_address_from_getaddressinfo_0.18) https://github.com/bitcoin/bitcoin/pull/15800
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15799: doc: Clarify RPC versioning (master...1904-docRPC) https://github.com/bitcoin/bitcoin/pull/15799
< sipa> oh quick topic: there has been a bunch of improvements to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft lately (thanks, harding); people may want to look over it before it becomes a last-minute thing before release
< gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12490 | [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server by jnewbery · Pull Request #12490 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15750 | [rpc] Remove the addresses field from the getaddressinfo return object by jnewbery · Pull Request #15750 · bitcoin/bitcoin · GitHub
< jnewbery> I don't think it counts as controversial if some random drops in and says "NEVER CHANGE RPCS". If we let that stop useful changes to Bitcoin Core we'd never do anything.
< gribble> https://github.com/bitcoin/bitcoin/issues/15750 | [rpc] Remove the addresses field from the getaddressinfo return object by jnewbery · Pull Request #15750 · bitcoin/bitcoin · GitHub
< luke-jr> gmaxwell: UPnP might be generic enough that non-Bitcoin devs are interested too
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< wumpus> I really don't know, like if you and sipa are 100% against including rust in bitcoin core, it's a done deal I guess
< wumpus> a lot of the boilerplate we're introducing in bitcoin for queues, asyn handling,et c is simply part of rust already
< gmaxwell> I am skeptical also about this motivation about structurally elimiating bugs, when development in bitcoin core continues to _introduce_ bug in the form of things like memory-unbounded asynchronous layers.
< sipa> wumpus: i realize that; but bitcoin core is a c++ project with c++ reviewers
< wumpus> sipa: yes, maybe it means I need to move to rust-bitcoin :-)
< sipa> but i have no interest in seeing bitcoin core becoming developed in a mix of languages
< gribble> https://github.com/bitcoin/bitcoin/issues/14728 | fix uninitialized read when stringifying an addrLocal by kazcw · Pull Request #14728 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/6636 | net: correctly initialize nMinPingUsecTime by laanwj · Pull Request #6636 · bitcoin/bitcoin · GitHub
< MarcoFalke> luke-jr: Bitcoin is experimental
< instagibbs> you'd want to ping #rust-bitcoin folks
< luke-jr> anyway, CRust.. I don't think including Rust inside Bitcoin Core is a good idea, even optionally, so long as Rust requires trusting third party binaries
< cfields_> See #15798, lots of useful info there. tl;dr: This is a cool project from Jeremy Rubin that allows us to use rust code from inside of Bitcoin Core. No plan yet, I mostly just wanted to spread the word that people should try it out and report back. It pretty much just works. It is surprisingly complete, but has only been tested in a few environments so far.
< gribble> https://github.com/bitcoin/bitcoin/issues/15798 | RFC: Rust code integration by theuni · Pull Request #15798 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15750 | [rpc] Remove the addresses field from the getaddressinfo return object by jnewbery · Pull Request #15750 · bitcoin/bitcoin · GitHub
< wumpus> #topic Bitcoin CRust (cfields_)
< gribble> https://github.com/bitcoin/bitcoin/issues/15749 | Fix: importmulti only imports origin info for PKH outputs by sipa · Pull Request #15749 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/15776 | Expire inflight GETDATA requests by ajtowns · Pull Request #15776 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15749 | Fix: importmulti only imports origin info for PKH outputs by sipa · Pull Request #15749 · bitcoin/bitcoin · GitHub
< gmaxwell> speaking of a, we don't enable asm for libsecp256k1 in the bitcoin core build, do we?
< gribble> https://github.com/bitcoin/bitcoin/issues/13788 | Fix --disable-asm for newer assembly checks/code by luke-jr · Pull Request #13788 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] theuni opened pull request #15798: RFC: Rust code integration (master...with-rust-example-working) https://github.com/bitcoin/bitcoin/pull/15798
< cfields_> #proposedmeetingtopic Bitcoin CRust
< luke-jr> Bitcoin CRust?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15797: travis: Bump second timeout to 33 minutes, Add rationale (master...1904-travisTime) https://github.com/bitcoin/bitcoin/pull/15797
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15795: [WIP] scripted-diff: Avoid name collisions in CChainState (master...1904-m_chain) https://github.com/bitcoin/bitcoin/pull/15795
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15773: test: Add BitcoinTestFramework::sync_* methods (master...1904-qaSyncNew) https://github.com/bitcoin/bitcoin/pull/15773
< bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/bb68abe784b9...0e9cb2d24dbf
< bitcoin-git> bitcoin/master fa4680e MarcoFalke: scripted-diff: Rename sync_blocks to send_blocks to avoid name collisions ...
< bitcoin-git> bitcoin/master fafe008 MarcoFalke: test: Pass at most one node group to sync_all
< bitcoin-git> bitcoin/master fa6dc7c MarcoFalke: test: Add BitcoinTestFramework::sync_* methods
< bitcoin-git> [bitcoin] instagibbs opened pull request #15796: CReserveKey should not allow passive key re-use, KeepKey in destructor (master...burn_reserve) https://github.com/bitcoin/bitcoin/pull/15796
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15795: scripted-diff: Avoid name collisions in CChainState (master...1904-m_chain) https://github.com/bitcoin/bitcoin/pull/15795
< bitcoin-git> [bitcoin] dongcarl opened pull request #15794: docs: Clarify PR guidelines w/re documentation (master...2019-04-doc-doc) https://github.com/bitcoin/bitcoin/pull/15794
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
< bitcoin-git> [bitcoin] laanwj merged pull request #15718: docs: Improve netaddress comments (master...2019-04-netaddr-comments) https://github.com/bitcoin/bitcoin/pull/15718
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/570eb7b130c2...bb68abe784b9
< bitcoin-git> bitcoin/master 303372c Carl Dong: docs: Improve netaddress comments
< bitcoin-git> bitcoin/master bb68abe Wladimir J. van der Laan: Merge #15718: docs: Improve netaddress comments
< bitcoin-git> bitcoin/master 0b3a654 Peter Bushnell: Avoid redefine warning
< bitcoin-git> bitcoin/master 570eb7b Wladimir J. van der Laan: Merge #15782: Avoid redefine warning
< bitcoin-git> [bitcoin] laanwj merged pull request #15782: Avoid redefine warning (master...warning-redefine) https://github.com/bitcoin/bitcoin/pull/15782
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c536dfbcb00f...570eb7b130c2
< wumpus> `bitcoin-seeder --help` seems to return some options https://github.com/sipa/bitcoin-seeder/blob/master/main.cpp#L37
< emilr> I didn't crawl, I downloaded http://bitcoin.sipa.be/seeds.txt.gz as per README
< emilr> sorry, what I meant is that bitcoin core 0.17 has 120 hardcoded onion peers
< bitcoin-git> [bitcoin] jonatack opened pull request #15792: doc: describe onlynet option in doc/tor.md (master...add-onlynet-option-to-tor-docs) https://github.com/bitcoin/bitcoin/pull/15792
< bitcoin-git> [bitcoin] laanwj opened pull request #15791: [do not merge] net: Hardcoded seeds update for 0.18 (master...2019_04_hardcoded_seeds_update) https://github.com/bitcoin/bitcoin/pull/15791
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency (master...pr/link2) https://github.com/bitcoin/bitcoin/pull/15639
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f6120d40d583...c536dfbcb00f
< bitcoin-git> bitcoin/master fbc6bb8 Russell Yanofsky: bitcoin-wallet tool: Drop MakeChain calls
< bitcoin-git> bitcoin/master b874747 Russell Yanofsky: Remove access to node globals from wallet-linked code
< bitcoin-git> bitcoin/master 78a2fb5 Russell Yanofsky: bitcoin-wallet tool: Drop libbitcoin_server.a dependency
< emilr> most connections timeout at version handshake, takes about 10s for verack plus network latency, if bitcoin tor nodes run with the default timeout then you're out of luck
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15728: [wallet] Refactor relay transactions (master...2019_03_refactor_relay_transactions) https://github.com/bitcoin/bitcoin/pull/15728
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a135fbe5b30...f6120d40d583
< bitcoin-git> bitcoin/master 7a9046e John Newbery: [wallet] Refactor CWalletTx::RelayWalletTransaction()
< bitcoin-git> bitcoin/master f6120d4 MeshCollider: Merge #15728: [wallet] Refactor relay transactions
< jonasschnelli> Using obfuscation key for /btc/data/bitcoin/blocks/index: 0000000000000000
< wumpus> it does not relate to bip38 in any way; if anything, most people involved with bitcoin dev really dislike bip38 and it's per-key encryption
< kallewoof> Does the encryptwallet feature in bitcoin core relate to bip 38 in any way, or do they just look similar? It looks like it is basically doing the same thing but with scrypt replaced.
< emilr> I'll increase -timeout and wipe peers.dat to see if it makes much of a difference, I guess bitcoin needs to be more agressive when it has a limited number of peers
< emilr> gmaxwell: I was under the impression it would fetch all peers regardless of net but it did indeed discover some peers, I see 190 different .onions in two weeks, I think what happened is that bitcoin gave up on a lot of those peers after few failures but failure to connect is a normality in the tor land
< emilr> onlynet=onion and bitcoin user is blocked from making connections to the clearnet
< emilr> wumpus: sed -e 's|./bitcoin-cli|ANYTHING -you -want|g' banlist.cli.txt
< emilr> speaking of seeds/peers I have bitcoin running in an isolated environment: it can't connect to anything except .onions and it has some peers added with addnode, the behaviour that I'm seeing is that bitcoind does not learn about other peers from its existing ones, possibly because dns seeds fail, the expected behaviour is that bitcoin learns about other peers from it's existing ones (the ones
< bitcoin-git> [bitcoin] benthecarman opened pull request #15790: [0.18] backport #15754 (0.18...0.18) https://github.com/bitcoin/bitcoin/pull/15790
< wumpus> (it could still default to ./bitcoin-cli ofc)
< wumpus> gmaxwell: for me it would be convenient if banlist.cli.txt had ${BITCOIN_CLI} or something on every line instead of ./bitcoin-cli, and allowed it to be overridden, for example to point to a custom bitcoin-cli path or providing a -datadir/-conf argument
< dongcarl> gmaxwell: oh like connects to a bitcoin node and briefly get some other peers we can connect to from it then say bye?
< dongcarl> Oh I'm guessing the last time you tried to remove this, bitcoin only had support for SOCK4 and couldn't resolve thru the normal proxy?

2019-04-10

< jnewbery> Error! Initial build successful, but not enough time remains to run later build stages and tests. Please manually re-run this job by using the travis restart button or asking a bitcoin maintainer to restart. The next run should not time out because the build cache has been saved.
< bitcoin-git> [bitcoin] jnewbery reopened pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15788: test: Unify testing setups for fuzz, bench, and unit tests (master...1904-testUnify) https://github.com/bitcoin/bitcoin/pull/15788
< bitcoin-git> [bitcoin] jnewbery closed pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< dongcarl> wumpus: I see your comments here: https://github.com/bitcoin/bitcoin/pull/6053#issuecomment-128671852
< bitcoin-git> [bitcoin] laanwj merged pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638
< bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/e3a0688f8275...6a135fbe5b30
< bitcoin-git> bitcoin/master fdf8888 John Newbery: [build] Move CheckTransaction from lib_server to lib_consensus
< bitcoin-git> bitcoin/master 4a75c9d John Newbery: [build] Move policy settings to new src/policy/settings unit
< bitcoin-git> bitcoin/master 1acc61f John Newbery: [build] Move rpc utility methods to rpc/util
< bitcoin-git> [bitcoin] ariard opened pull request #15784: rpc: Remove dependency on interfaces::Chain in SignTransaction (master...2019-04-remove-chain-sign-tx-utility) https://github.com/bitcoin/bitcoin/pull/15784
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15783: Remove braces previously used for locks (master...unused-braces) https://github.com/bitcoin/bitcoin/pull/15783
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e82f6ad6f270...e3a0688f8275
< bitcoin-git> bitcoin/master c968780 r8921039: [docs] fix comment: the return value of findFork is _not_ an ancestor when...
< bitcoin-git> bitcoin/master e3a0688 MarcoFalke: Merge #15659: [docs] fix findFork comment
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15659: [docs] fix findFork comment (master...fix_findFork_comment) https://github.com/bitcoin/bitcoin/pull/15659
< bitcoin-git> [bitcoin] Bushstar opened pull request #15783: Remove braces previously used for locks (master...unused-braces) https://github.com/bitcoin/bitcoin/pull/15783
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c022e8ac401...e82f6ad6f270
< bitcoin-git> bitcoin/master f4b7a2f Ben Carman: rpc: getrpcinfo docs
< bitcoin-git> bitcoin/master e82f6ad MarcoFalke: Merge #15754: rpc: getrpcinfo docs
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15754: rpc: getrpcinfo docs (master...rpc_get_info_doc) https://github.com/bitcoin/bitcoin/pull/15754
< bitcoin-git> [bitcoin] Bushstar opened pull request #15782: Avoid redefine warning (master...warning-redefine) https://github.com/bitcoin/bitcoin/pull/15782
< gribble> https://github.com/bitcoin/bitcoin/issues/15780 | wallet: add cachable accounts for caching credit/debit values by kallewoof · Pull Request #15780 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof opened pull request #15780: wallet: add cachable accounts for caching credit/debit values (master...cachable-accounts) https://github.com/bitcoin/bitcoin/pull/15780
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15746: rpc: RPCHelpMan: Always name dictionary keys (master...1904-rpcUtilFix) https://github.com/bitcoin/bitcoin/pull/15746
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5392aee64fa2...8c022e8ac401
< bitcoin-git> bitcoin/master fa652b2 MarcoFalke: rpc: Add some doxygen comments to utils
< bitcoin-git> bitcoin/master fa26eb5 MarcoFalke: rpc: RPCHelpMan: Always push_name when outer type is an object
< bitcoin-git> bitcoin/master 8c022e8 MarcoFalke: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/93de9abe6d68...5392aee64fa2
< bitcoin-git> bitcoin/master dddd6f0 MarcoFalke: init: Throw error when network specific config is ignored
< bitcoin-git> bitcoin/master fa4a922 MarcoFalke: qa: Add test for missing testnet section in conf file
< bitcoin-git> bitcoin/master fa9058f MarcoFalke: doc: Add release notes for 15629
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15629: init: Throw error when network specific config is ignored (master...1903-InitErrorConf) https://github.com/bitcoin/bitcoin/pull/15629

2019-04-09

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
< gwillen> (I am testing https://github.com/bitcoin/bitcoin/pull/15024, but I don't know that it's related)
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15632: Remove ResendWalletTransactions from the Validation Interface (master...no_resend_wallet_txs) https://github.com/bitcoin/bitcoin/pull/15632
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/23712f8ab951...93de9abe6d68
< bitcoin-git> bitcoin/master f463cd1 John Newbery: [wallet] Keep track of the best block time in the wallet
< bitcoin-git> bitcoin/master 52b760f John Newbery: [wallet] Schedule tx rebroadcasts in wallet
< bitcoin-git> bitcoin/master 833d98a John Newbery: [wallet] Remove unnecessary Chain::Lock parameter from ResendWalletTransac...
< bitcoin-git> [bitcoin] jnewbery opened pull request #15778: Mmove maxtxfee from node (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git> [bitcoin] jnewbery opened pull request #15777: [docs] Add doxygen comments for keypool classes (master...2019_04_keypool_comments) https://github.com/bitcoin/bitcoin/pull/15777
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15693: travis: Switch to ubuntu keyserver to avoid timeouts (master...1903-travisKeyTimeout) https://github.com/bitcoin/bitcoin/pull/15693
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f9f6c11a7422...23712f8ab951
< bitcoin-git> bitcoin/master fa36a33 MarcoFalke: travis: Switch to ubuntu keyserver to avoid timeouts
< bitcoin-git> bitcoin/master fa2056a MarcoFalke: travis: Properly cache and error on timeout
< bitcoin-git> bitcoin/master 23712f8 MarcoFalke: Merge #15693: travis: Switch to ubuntu keyserver to avoid timeouts
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3ecf3025f82...f9f6c11a7422
< bitcoin-git> bitcoin/master 90bce24 João Barbosa: qa: Prevent concurrency issues reading .cookie file
< bitcoin-git> bitcoin/master f9f6c11 MarcoFalke: Merge #15771: qa: Prevent concurrency issues reading .cookie file
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15771: qa: Prevent concurrency issues reading .cookie file (master...2019-04-retry-open-cookie) https://github.com/bitcoin/bitcoin/pull/15771
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15775: [0.18] Doc Backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15775
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/32ec90085044...164082c822b0
< bitcoin-git> bitcoin/0.18 538fef6 Pieter Wuille: Update bips.md for 0.18.0
< bitcoin-git> bitcoin/0.18 956c0aa fanquake: doc: correct bitcoinconsensus_version in shared-libraries
< bitcoin-git> bitcoin/0.18 1b0752a Pieter Wuille: Mention new PSBT RPCs in psbt.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15772: test: Properly log named args in authproxy (master...1904-qaLogNamedArgs) https://github.com/bitcoin/bitcoin/pull/15772
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54798c3a31b0...f3ecf3025f82
< bitcoin-git> bitcoin/master fa07898 MarcoFalke: test: Properly log named args in authproxy
< bitcoin-git> bitcoin/master f3ecf30 MarcoFalke: Merge #15772: test: Properly log named args in authproxy
< tryphe> luke-jr, i see, that makes sense. but i got the knack that bitcoin devs earned come income from donations somehow or some sort of community funding. not so?
< luke-jr> tryphe: Bitcoin Core is an open source project many different people contribute to; there's no centralised entity accepting/distributing donations on everyone's behalf
< tryphe> luke-jr, so where are the real bitcoin core donation addresses?
< luke-jr> tryphe: either way, it's bitcoin.org you want to report any issues to
< luke-jr> tryphe: that one is to support bitcoin.org, again not related to Bitcoin Core
< luke-jr> tryphe: eh, the link doesn't say it's to donate to Bitcoin or Bitcoin Core
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15749: Fix: importmulti only imports origin info for PKH outputs (master...201904_importallorigins) https://github.com/bitcoin/bitcoin/pull/15749
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/db2985651d9f...54798c3a31b0
< bitcoin-git> bitcoin/master 9a93c91 Pieter Wuille: Keep full pubkeys in FlatSigningProvider::origins
< bitcoin-git> bitcoin/master 6e59700 Pieter Wuille: Import all origin info in importmulti; even for non-importing pubkeys
< bitcoin-git> bitcoin/master b5d3987 Pieter Wuille: Take non-importing keys into account for spendability warning in descripto...
< luke-jr> tryphe: that has nothing to do with Bitcoin Core; https://github.com/bitcoin-dot-org/bitcoin.org
< bitcoin-git> [bitcoin] ajtowns opened pull request #15776: Expire inflight GETDATA requests (master...201904-inflighttxtimeout) https://github.com/bitcoin/bitcoin/pull/15776
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15747: wallet: Remove plethora of Get*Balance (master...1903-walletBal) https://github.com/bitcoin/bitcoin/pull/15747
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8088ff21e401...db2985651d9f
< bitcoin-git> bitcoin/master fa57411 MarcoFalke: wallet: Get all balances in one call
< bitcoin-git> bitcoin/master db29856 MeshCollider: Merge #15747: wallet: Remove plethora of Get*Balance
< tryphe> the donation link seems to be broken on this page: https://bitcoin.org/en/support-bitcoin
< bitcoin-git> [bitcoin] fanquake opened pull request #15775: [0.18] Doc Backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15775
< bitcoin-git> [bitcoin] laanwj merged pull request #15765: doc: correct bitcoinconsensus_version in shared-libraries.md (master...bitcoin_consensus_version) https://github.com/bitcoin/bitcoin/pull/15765
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79f73436a910...8088ff21e401