2020-11-04

< bitcoin-git> bitcoin/master fc57217 Jon Atack: wallet: fix SetFeeEstimateMode() error message
< bitcoin-git> bitcoin/master 052427e Jon Atack: wallet, bugfix: fix bumpfee with explicit fee rate modes
< bitcoin-git> [bitcoin] meshcollider pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/17c6fb176a07...5d32009f1a3b
< bitcoin-git> [bitcoin] meshcollider merged pull request #20282: wallet: change upgradewallet return type to be an object (master...2020-11-upgrade-wallet-return) https://github.com/bitcoin/bitcoin/pull/20282
< bitcoin-git> bitcoin/master 17c6fb1 Samuel Dobson: Merge #20282: wallet: change upgradewallet return type to be an object
< bitcoin-git> bitcoin/master 2ead31f Sishir Giri: [wallet] Return object from upgradewallet RPC
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95bde34a7186...17c6fb176a07

2020-11-03

< sipa> https://flo.sh/download-bitcoin-blockchain-bootstrap/ apparently has a fairly recent one
< gribble> https://github.com/bitcoin/bitcoin/issues/19594 | refactor: Make mapBlocksUnknownParent local, and rename it by hebasto · Pull Request #19594 · bitcoin/bitcoin · GitHub
< wumpus> vasild: here is already one bitcoin node listening at yfsvsy467mt5xafaq7zaukkjyze hvmew445yaaejvrwpk53acejq.b32.i2p (irc gossip :-D) <- good to know, i'll have a look at setting up I2P too
< jonasschnelli> but the AEAD has no rekeying (@openssh and @Bitcoin)
< vasild> there is already one bitcoin node listening at yfsvsy467mt5xafaq7zaukkjyzehvmew445yaaejvrwpk53acejq.b32.i2p (irc gossip :-D)
< gribble> https://github.com/bitcoin/bitcoin/issues/20254 | Add I2P support using statically configured destinations by vasild · Pull Request #20254 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19728 | Increase the ip address relay branching factor for unreachable networks by sipa · Pull Request #19728 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20119 | BIP155 follow-ups by sipa · Pull Request #20119 · bitcoin/bitcoin · GitHub
< vasild> Anybody interested in I2P support - see https://github.com/vasild/bitcoin/wiki/I2P-connectivity and discuss here, I guess after the meeting or anytime
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | Complete the BIP155 implementation and upgrade to TORv3 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< jnewbery> #topic I2P support, some background at vasild/bitcoin/wiki/I2P-connectivity (vasild)
< wumpus> though it'd require updating a lot of documentation all over the place describing bitcoin core's files
< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
< jnewbery> luke-jr: they already lost part of their addrman upgrading to 0.20 because of https://github.com/bitcoin/bitcoin/pull/16702#discussion_r515608294, but I guess no-one noticed
< gribble> https://github.com/bitcoin/bitcoin/issues/20284 | addrman: ensure old versions dont parse peers.dat by vasild · Pull Request #20284 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | Complete the BIP155 implementation and upgrade to TORv3 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< wumpus> there's still quite a list of PRs tagged with 0.21.0, these either need to be merged or removed from the milestone first https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/03 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
< jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< gribble> https://github.com/bitcoin/bitcoin/issues/03 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
< jnewbery> Hi folks. Reminder that we have a P2P irc meeting in just under half an hour. Proposed topics are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#03-nov-2020
< bitcoin-git> [bitcoin] laanwj merged pull request #20237: net: Hardcoded seeds update for 0.21 (master...2020_10_seeds_update) https://github.com/bitcoin/bitcoin/pull/20237
< bitcoin-git> bitcoin/master 95bde34 Wladimir J. van der Laan: Merge #20237: net: Hardcoded seeds update for 0.21
< bitcoin-git> bitcoin/master 36e875b RandyMcMillan: contrib: Add new versions to makeseeds.py and update gitignore
< bitcoin-git> bitcoin/master 6866259 Wladimir J. van der Laan: net: Hardcoded seeds update for 0.21
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/218fe60d91a9...95bde34a7186
< bitcoin-git> [bitcoin] Sjors opened pull request #20295: rpc: getblockfrompeer (master...2020/11/getblockfrompeer) https://github.com/bitcoin/bitcoin/pull/20295
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20294: ci: Run more ci configs on cirrus (master...2011-ciCirrus) https://github.com/bitcoin/bitcoin/pull/20294
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20292: test: Fix intermittent feature_taproot issue (master...2011-testFixes) https://github.com/bitcoin/bitcoin/pull/20292
< bitcoin-git> [bitcoin] jonatack closed pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
< bitcoin-git> [bitcoin] jnewbery opened pull request #20291: [net] Consolidate logic around calling CAddrMan::Connected() (master...2020-11-consolidate-addrman-connect) https://github.com/bitcoin/bitcoin/pull/20291
< MarcoFalke> the meeting topics link in the IRC topic of this channel is no longer being updated. I created a wiki entry to collect meeting topics: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/General-IRC-meeting
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20290: fuzz: Fix DecodeHexTx fuzzing harness issue (master...fuzzers-decode_tx-fixup) https://github.com/bitcoin/bitcoin/pull/20290
< bitcoin-git> bitcoin/master 218fe60 MarcoFalke: Merge #20290: fuzz: Fix DecodeHexTx fuzzing harness issue
< bitcoin-git> bitcoin/master 28f8cb1 practicalswift: fuzz: Fix DecodeHexTx fuzzing harness issue
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5174b534da57...218fe60d91a9
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20289: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService (master...fuzzers-service_deserialize-addrv2) https://github.com/bitcoin/bitcoin/pull/20289
< bitcoin-git> bitcoin/master 5174b53 MarcoFalke: Merge #20289: fuzz: Check for addrv1 compatibility before using addrv1 ser...
< bitcoin-git> bitcoin/master c2cf8a1 practicalswift: fuzz: Check for addrv1 compatibility before using addrv1 serializer on CSe...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8387f832d693...5174b534da57
< bitcoin-git> [bitcoin] fanquake merged pull request #20187: Addrman: test-before-evict bugfix and improvements for block-relay-only peers (master...2020-10-addrman-block-relay) https://github.com/bitcoin/bitcoin/pull/20187
< bitcoin-git> bitcoin/master e8b215a Suhas Daftuar: Refactor test for existing peer connection into own function
< bitcoin-git> bitcoin/master 4fe338a Suhas Daftuar: Call CAddrMan::Good() on block-relay-only peer addresses
< bitcoin-git> bitcoin/master daf5553 Suhas Daftuar: Avoid calling CAddrMan::Connected() on block-relay-only peer addresses
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ca1886056325...8387f832d693

2020-11-02

< bitcoin-git> [bitcoin] practicalswift opened pull request #20290: fuzz: Fix DecodeHexTx fuzzing harness issue (master...fuzzers-decode_tx-fixup) https://github.com/bitcoin/bitcoin/pull/20290
< bitcoin-git> [bitcoin] practicalswift opened pull request #20289: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService (master...fuzzers-service_deserialize-addrv2) https://github.com/bitcoin/bitcoin/pull/20289
< bitcoin-git> [bitcoin] jonatack opened pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
< bitcoin-git> [bitcoin] mjdietzx opened pull request #20286: rpc: remove `reqSigs` from rpc outputs (master...remove-reqsigs-from-rpcs) https://github.com/bitcoin/bitcoin/pull/20286
< gribble> https://github.com/bitcoin/bitcoin/issues/20187 | Addrman: test-before-evict bugfix and improvements for block-relay-only peers by sdaftuar · Pull Request #20187 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20263: Update assumed chain params (master...2010-21assumed) https://github.com/bitcoin/bitcoin/pull/20263
< bitcoin-git> bitcoin/master ca18860 Wladimir J. van der Laan: Merge #20263: Update assumed chain params
< bitcoin-git> bitcoin/master fa90ba3 MarcoFalke: Update assumed chain params
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef4c7c4e0bf2...ca1886056325
< bitcoin-git> [bitcoin] laanwj merged pull request #18788: tests: Update more tests to work with descriptor wallets (master...desc-wallet-tests) https://github.com/bitcoin/bitcoin/pull/18788
< bitcoin-git> bitcoin/master 553dbf9 Andrew Chow: Make import tests in wallet_listtransactions.py legacy wallet only
< bitcoin-git> bitcoin/master dc81418 Andrew Chow: Use a separate watchonly wallet in rpc_fundrawtransaction.py
< bitcoin-git> bitcoin/master a357111 Andrew Chow: Update wallet_importprunedfunds to avoid dumpprivkey
< bitcoin-git> [bitcoin] laanwj pushed 20 commits to master: https://github.com/bitcoin/bitcoin/compare/b6a00e76ab6f...ef4c7c4e0bf2
< jnewbery> vasild: you found the right place for p2p topics: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< gribble> https://github.com/bitcoin/bitcoin/issues/20237 | net: Hardcoded seeds update for 0.21 by laanwj · Pull Request #20237 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20279: doc: release process updates/fixups (master...release-process-getchaintxstats-fix) https://github.com/bitcoin/bitcoin/pull/20279
< bitcoin-git> bitcoin/master b6a00e7 MarcoFalke: Merge #20279: doc: release process updates/fixups
< bitcoin-git> bitcoin/master e5f3e95 Jon Atack: doc: fix getchaintxstats fields in release-process.md
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5ec0367d718...b6a00e76ab6f
< vasild> Proposed topic for P2P meeting tomorrow (Nov 3): I2P, https://github.com/vasild/bitcoin/wiki/I2P-connectivity
< bitcoin-git> [gui] hebasto opened pull request #127: Replace QMetaObject::invokeMethod with Mutex locking (master...201102-queued) https://github.com/bitcoin-core/gui/pull/127
< bitcoin-git> [bitcoin] fanquake opened pull request #20285: Remove references to CreateWalletFromFile (master...createwalletfromfilenomore) https://github.com/bitcoin/bitcoin/pull/20285
< bitcoin-git> [bitcoin] vasild opened pull request #20284: addrman: ensure old versions don't parse peers.dat (master...peers_dat_format) https://github.com/bitcoin/bitcoin/pull/20284
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20165: Only relay Taproot spends if next block has it active (master...202010_taproot_policy) https://github.com/bitcoin/bitcoin/pull/20165
< bitcoin-git> bitcoin/master c5ec036 MarcoFalke: Merge #20165: Only relay Taproot spends if next block has it active
< bitcoin-git> bitcoin/master 3d0556d Pieter Wuille: Increase feature_taproot inactive test coverage
< bitcoin-git> bitcoin/master 525cbd4 Pieter Wuille: Only relay Taproot spends if next block has it active
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/867dbeba5f91...c5ec0367d718
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20283: test: Only try witness deser when checking for witness deser failure (master...2011-testWitnessFail) https://github.com/bitcoin/bitcoin/pull/20283
< bitcoin-git> [bitcoin] jnewbery opened pull request #20282: Wallet: Change upgradewallet return type to be an object (master...2020-11-upgrade-wallet-return) https://github.com/bitcoin/bitcoin/pull/20282
< sipa> adulrunaredviva: https://bitcoin.stackexchange.com is a better place for these questions; in short: the price is set by supply and demand
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20281: docs: Correct getblockstats documentation for (sw)total_weight (master...202011-getblockstats-docs-weight) https://github.com/bitcoin/bitcoin/pull/20281
< bitcoin-git> bitcoin/master 867dbeb MarcoFalke: Merge #20281: docs: Correct getblockstats documentation for (sw)total_weig...
< bitcoin-git> bitcoin/master 5d99174 Nadav Ivgi: docs: Correct getblockstats documentation for (sw)total_weight
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/26d7941224bc...867dbeba5f91

2020-11-01

< brianddk> Why does everything in bitcoin use double hash (HASH256) except BIP141 (P2WSH): https://www.reddit.com/r/Bitcoin/comments/jm9s2z/
< bitcoin-git> [bitcoin] meshcollider merged pull request #20230: wallet: Fix bug when just created encrypted wallet cannot get address (master...201023-signal) https://github.com/bitcoin/bitcoin/pull/20230
< bitcoin-git> bitcoin/master 26d7941 Samuel Dobson: Merge #20230: wallet: Fix bug when just created encrypted wallet cannot ge...
< bitcoin-git> bitcoin/master bf6855a Hennadii Stepanov: wallet: Fix bug when just created encrypted wallet cannot get address
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1fcbdea2555...26d7941224bc
< bitcoin-git> [bitcoin] meshcollider merged pull request #20271: doc: Document that wallet salvage is experimental (master...2010-docWalletSalvage) https://github.com/bitcoin/bitcoin/pull/20271
< bitcoin-git> bitcoin/master f1fcbde Samuel Dobson: Merge #20271: doc: Document that wallet salvage is experimental
< bitcoin-git> bitcoin/master fab9453 MarcoFalke: doc: Document that wallet salvage is experimental
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c2eb7f8deaa...f1fcbdea2555
< bitcoin-git> [bitcoin] meshcollider merged pull request #20262: tests: Skip --descriptor tests if sqlite is not compiled (master...tests-check-sqlite) https://github.com/bitcoin/bitcoin/pull/20262
< bitcoin-git> bitcoin/master 0c2eb7f Samuel Dobson: Merge #20262: tests: Skip --descriptor tests if sqlite is not compiled
< bitcoin-git> bitcoin/master 5866403 Andrew Chow: Skip --descriptor tests if sqlite is not compiled
< bitcoin-git> bitcoin/master 7411876 Andrew Chow: Ensure a legacy wallet for BDB format check
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5a6f3c5a01ea...0c2eb7f8deaa
< bitcoin-git> [bitcoin] meshcollider merged pull request #20080: Strip any trailing `/` in -datadir and -blocksdir paths (master...201004-strip) https://github.com/bitcoin/bitcoin/pull/20080
< bitcoin-git> bitcoin/master 5a6f3c5 Samuel Dobson: Merge #20080: Strip any trailing `/` in -datadir and -blocksdir paths
< bitcoin-git> bitcoin/master ad5cef5 Hennadii Stepanov: doc: Update data directory path comments
< bitcoin-git> bitcoin/master b19e882 Hennadii Stepanov: util: Add StripRedundantLastElementsOfPath function
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/42b66a6b814b...5a6f3c5a01ea
< bitcoin-git> [bitcoin] promag closed pull request #17878: wip: zmq: Support -zmqpubwallettx (master...2019-01-zmqpubwallettx) https://github.com/bitcoin/bitcoin/pull/17878
< bitcoin-git> [bitcoin] RandyMcMillan closed pull request #20280: doc: Add gh user to CODEOWNERS (master...codeowners) https://github.com/bitcoin/bitcoin/pull/20280
< bitcoin-git> [bitcoin] shesek opened pull request #20281: docs: Correct getblockstats documentation for (sw)total_weight (master...202011-getblockstats-docs-weight) https://github.com/bitcoin/bitcoin/pull/20281
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #20280: doc: Add gh user to CODEOWNERS (master...codeowners) https://github.com/bitcoin/bitcoin/pull/20280
< Kiminuo> https://github.com/bitcoin/bitcoin/issues/18947 - are those dates hard deadlines or soft deadlines?
< bitcoin-git> [bitcoin] jonatack opened pull request #20279: doc: fix getchaintxstats fields in release-process.md (master...release-process-getchaintxstats-fix) https://github.com/bitcoin/bitcoin/pull/20279

2020-10-31

< yanmaani> luke-jr: If Bitcoin Core is written in conforming C++, it should work on all arches, right?
< yanmaani> why does bitcoin only support certain arches?
< bitcoin-git> [bitcoin] vasild closed pull request #20272: Add missing thread safety annotations (master...add_missing_tsa) https://github.com/bitcoin/bitcoin/pull/20272
< bitcoin-git> [bitcoin] hebasto closed pull request #20274: util: Drop redundant NDEBUG check (master...201030-ndebug) https://github.com/bitcoin/bitcoin/pull/20274
< wumpus> ofc, it's clear there's not that much gain to supporting 2002 chips, practally, even high end 2008 chips have a hard time running a validating bitcoin node
< bitcoin-git> [bitcoin] ariard opened pull request #20277: p2p: Do not resolve orphans during IBD and extend p2p_ibd_txrelay.py coverage (master...2020-10-ibd-txrelay) https://github.com/bitcoin/bitcoin/pull/20277
< bitcoin-git> [bitcoin] mjdietzx opened pull request #20276: test: run mempool_expiry.py even with wallet disabled (master...mempool-expiry-miniwallet) https://github.com/bitcoin/bitcoin/pull/20276

2020-10-30

< bitcoin-git> [bitcoin] ryanofsky opened pull request #20275: wallet: List SQLite wallets in non-SQLite builds (master...pr/exist) https://github.com/bitcoin/bitcoin/pull/20275
< bitcoin-git> [bitcoin] hebasto opened pull request #20274: util: Drop redundant NDEBUG check (master...201030-ndebug) https://github.com/bitcoin/bitcoin/pull/20274
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20273: Extend support for nested commands to bitcoin-cli (master...2020/10/client_rpc_nested) https://github.com/bitcoin/bitcoin/pull/20273
< bitcoin-git> [bitcoin] vasild opened pull request #20272: Add missing thread safety annotations (master...add_missing_tsa) https://github.com/bitcoin/bitcoin/pull/20272
< ariard> sdaftuar: fyi, it's displayed properly if you go directly on the commit https://github.com/bitcoin/bitcoin/pull/20187/commits/e8b215a086d91a8774210bb6ce8d1560aaaf0789
< bitcoin-git> [bitcoin] vasild reopened pull request #20234: net: don't extra bind for Tor if binds are restricted (master...bind) https://github.com/bitcoin/bitcoin/pull/20234
< bitcoin-git> [bitcoin] vasild closed pull request #20234: net: don't extra bind for Tor if binds are restricted (master...bind) https://github.com/bitcoin/bitcoin/pull/20234
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20271: doc: Document that wallet salvage is experimental (master...2010-docWalletSalvage) https://github.com/bitcoin/bitcoin/pull/20271
< sdaftuar> fanquake: sure, not sure what documentation is helpful exactly but the last "show resolved" on https://github.com/bitcoin/bitcoin/pull/20187 is failing to expand for me, just get the spinny github logo
< gribble> https://github.com/bitcoin/bitcoin/issues/20187 | Addrman: test-before-evict bugfix and improvements for block-relay-only peers by sdaftuar · Pull Request #20187 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto reopened pull request #18077: net: Add NAT-PMP port forwarding support (master...20200130-natpmp) https://github.com/bitcoin/bitcoin/pull/18077
< real_or_random> hebasto: yes, what worries me is the travis migration to .com, see my comment here https://github.com/bitcoin/bitcoin/issues/17802
< bitcoin-git> [bitcoin] hebasto closed pull request #18077: net: Add NAT-PMP port forwarding support (master...20200130-natpmp) https://github.com/bitcoin/bitcoin/pull/18077
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20268: ci: Move s390x build to cirrus (master...2010-ciS390x) https://github.com/bitcoin/bitcoin/pull/20268
< bitcoin-git> [bitcoin] gwillen closed pull request #20264: test: Make secp tests optional in `make check` (master...feature-optional-secp-check) https://github.com/bitcoin/bitcoin/pull/20264
< wumpus> does anyone here have knowledge regarding bind-now, relro and such hardening flags on POWER64? it looks like on POWER64 architecture, the .plt section remains writable: https://github.com/bitcoin/bitcoin/pull/14066#pullrequestreview-520439303
< jonasschnelli> AdulrunaRedviva: please go to the channel #bitcoin
< jonasschnelli> AdulrunaRedviva -> head over to #bitcoin (this is the development channel)

2020-10-29

< bitcoin-git> [bitcoin] achow101 opened pull request #20267: Disable and fix tests for when BDB is not compiled (master...tests-opt-sqlite-bdb) https://github.com/bitcoin/bitcoin/pull/20267
< bitcoin-git> [bitcoin] achow101 opened pull request #20266: Fix change detection of imported internal descriptors (master...fix-desc-change) https://github.com/bitcoin/bitcoin/pull/20266
< real_or_random> I don't see the full log here for some reason but people saw https://github.com/bitcoin-core/secp256k1/pull/843 ?
< bitcoin-git> [bitcoin] mjdietzx closed pull request #20265: refactor: get wallet path relative to wallet_dir (master...refactor-get-relative-wallet-path) https://github.com/bitcoin/bitcoin/pull/20265
< bitcoin-git> [bitcoin] mjdietzx opened pull request #20265: refactor: get wallet path relative to wallet_dir (master...refactor-get-relative-wallet-path) https://github.com/bitcoin/bitcoin/pull/20265
< MarcoFalke> I guess the question is: will qemu-user be able to find endian issues in the Bitcoin Core codebase
< bitcoin-git> [bitcoin] gwillen opened pull request #20264: test: Make secp tests optional in `make check` (master...feature-optional-secp-check) https://github.com/bitcoin/bitcoin/pull/20264
< sipa> luke-jr: we can create a dummy bitcoin-core-ci user or something, no?
< sipa> (which, even if nobody actually uses bitcoin core on a big endian platform, is a good test for the correctness of the code, as it tends to expose implemention-dependency that isn't otherwise exposed)
< emzy> Is someone actually using bitcoin core on x390x?
< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< jonasschnelli> please help review 0.21: https://github.com/bitcoin/bitcoin/milestone/45 thanks
< gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
< jonasschnelli> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< bitcoin-git> [bitcoin] achow101 closed pull request #20260: wallet: Create named SQLite wallet files instead of wallet directories (master...single-file-sqlite) https://github.com/bitcoin/bitcoin/pull/20260
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20263: Update assumed chain params (master...2010-21assumed) https://github.com/bitcoin/bitcoin/pull/20263
< bitcoin-git> [bitcoin] achow101 opened pull request #20262: tests: Skip --descriptor tests if sqlite is not compiled (master...tests-check-sqlite) https://github.com/bitcoin/bitcoin/pull/20262
< bitcoin-git> [gui] luke-jr opened pull request #125: GUI: Enable changing the autoprune block space size in intro dialog (master...intro_prune_size) https://github.com/bitcoin-core/gui/pull/125
< real_or_random> we may want to reopen https://github.com/bitcoin/bitcoin/issues/17802
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20186: wallet: Make -wallet setting not create wallets (master...pr/nowa) https://github.com/bitcoin/bitcoin/pull/20186
< bitcoin-git> bitcoin/master 42b66a6 MarcoFalke: Merge #20186: wallet: Make -wallet setting not create wallets
< bitcoin-git> bitcoin/master 01476a8 Russell Yanofsky: wallet: Make -wallet setting not create wallets
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e9e190ea5ce...42b66a6b814b
< luke-jr> ryanofsky: I have no idea what you're missing in https://github.com/bitcoin/bitcoin/pull/20205#issuecomment-718758891
< bitcoin-git> [bitcoin] fanquake merged pull request #20257: Update secp256k1 subtree to latest master (master...202010-secp256k1) https://github.com/bitcoin/bitcoin/pull/20257
< bitcoin-git> bitcoin/master 8e9e190 fanquake: Merge #20257: Update secp256k1 subtree to latest master
< bitcoin-git> bitcoin/master 5803f5f Pieter Wuille: Update secp256k1 subtree to latest master
< bitcoin-git> bitcoin/master 6c0259f Pieter Wuille: Squashed 'src/secp256k1/' changes from c6b6b8f1bb..3967d96bf1
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5b82f253b69f...8e9e190ea5ce
< bitcoin-git> [bitcoin] laanwj merged pull request #20195: build: fix mutex detection when building bdb on macOS (master...bdb_xcode12_implicit_function_decleration) https://github.com/bitcoin/bitcoin/pull/20195
< bitcoin-git> bitcoin/master 5b82f25 Wladimir J. van der Laan: Merge #20195: build: fix mutex detection when building bdb on macOS
< bitcoin-git> bitcoin/master d0a829e fanquake: build: fix mutex detection when building bdb on macOS
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e2419711702...5b82f253b69f
< queip> fanquake: FYI this is same guy that in past days is running around various IRC channels, threatens to kill Bitcoin developers. He rambles about Zeronet (which he ~falsely claims to be top developer of), about politics, bitcoin wiki, uses VPN, switches nicks, runs some scam foundation for "human rights"
< bitcoin-git> [bitcoin] laanwj merged pull request #20115: cli: -netinfo quick updates/fixups for 0.21 (master...netinfo-fixups) https://github.com/bitcoin/bitcoin/pull/20115
< bitcoin-git> bitcoin/master 773f4c9 Jon Atack: cli -netinfo: handle longer tor v3 local addresses
< bitcoin-git> bitcoin/master 33e9874 Jon Atack: cli -netinfo: make age column variable-width
< bitcoin-git> bitcoin/master f8a1c4d Jon Atack: cli -netinfo: various quick updates and fixes
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f3727fd73538...2e2419711702
< bitcoin-git> [bitcoin] laanwj merged pull request #20156: build: Make sqlite support optional (compile-time) (master...opt_sqlite) https://github.com/bitcoin/bitcoin/pull/20156
< bitcoin-git> bitcoin/master bbb42a6 Luke Dashjr: RPC: createwallet: Nicer error message if descriptor wallet requested and ...
< bitcoin-git> bitcoin/master 6608fec Luke Dashjr: GUI: Create Wallet: Nicely disable descriptor wallet checkbox if sqlite su...
< bitcoin-git> bitcoin/master 7b54d76 Luke Dashjr: Make sqlite support optional (compile-time)
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/924a4ff7eb62...f3727fd73538
< gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #20242: fuzz: Properly initialize PrecomputedTransactionData (master...2010-fuzzInit) https://github.com/bitcoin/bitcoin/pull/20242
< bitcoin-git> bitcoin/master fa56d56 MarcoFalke: fuzz: Properly initialize PrecomputedTransactionData
< bitcoin-git> bitcoin/master 924a4ff Wladimir J. van der Laan: Merge #20242: fuzz: Properly initialize PrecomputedTransactionData
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6196cf77e574...924a4ff7eb62
< bitcoin-git> [bitcoin] laanwj merged pull request #19753: p2p: don't add AlreadyHave transactions to recentRejects (master...2020-08-clean-tx-processing) https://github.com/bitcoin/bitcoin/pull/19753
< bitcoin-git> bitcoin/master 6196cf7 Wladimir J. van der Laan: Merge #19753: p2p: don't add AlreadyHave transactions to recentRejects
< bitcoin-git> bitcoin/master d419fde Troy Giorshev: [net processing] Don't add AlreadyHave txs to recentRejects
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f512f3d5639...6196cf77e574
< bosch-0> Next Bitcoin Core design call is scheduled for next Wednesday at 9:00AM UTC - https://github.com/BitcoinDesign/Meta/issues/40 - For discussion around this join ##bitcoin-core-gui

2020-10-28

< bitcoin-git> [bitcoin] achow101 opened pull request #20260: wallet: Create named SQLite wallet files instead of wallet directories (master...single-file-sqlite) https://github.com/bitcoin/bitcoin/pull/20260
< bitcoin-git> [gui] hebasto opened pull request #123: rpc: Do not accept command while executing another one (master...201028-prompt) https://github.com/bitcoin-core/gui/pull/123
< gribble> https://github.com/bitcoin/bitcoin/issues/19960 | build: The vcpkg tool has introduced a proper way to use manifests by sipsorcery · Pull Request #19960 · bitcoin/bitcoin · GitHub
< sdaftuar_> anyone know what went wrong here: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/35983641 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20258: tests: Remove getnettotals/getpeerinfo consistency test (master...2020-10-remove-net-totals-test) https://github.com/bitcoin/bitcoin/pull/20258
< bitcoin-git> bitcoin/master 3f512f3 MarcoFalke: Merge #20258: tests: Remove getnettotals/getpeerinfo consistency test
< bitcoin-git> bitcoin/master 778cd0d John Newbery: [tests] Remove getnettotals/getpeerinfo consistency test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/db26eeba71fb...3f512f3d5639
< yanmaani> ah ok, it's https://github.com/bitcoin/bitcoin/blob/master/contrib/seeds/makeseeds.py that has max_per_net, and this is for ip4/6/onion.
< gribble> https://github.com/bitcoin/bitcoin/issues/20237 | net: Hardcoded seeds update for 0.21 by laanwj · Pull Request #20237 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16999 | net: 0.19 seeds update by laanwj · Pull Request #16999 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18506 | net: Hardcoded seeds update for 0.20 by laanwj · Pull Request #18506 · bitcoin/bitcoin · GitHub
< wumpus> jnewbery: previous PRs like it might be a guide there (#18506, #16999), e.g. people could try to repeat the last step in https://github.com/bitcoin/bitcoin/tree/master/contrib/seeds#seeds and see if it ends up with the same .h file, you could also repeat the entire process but as the list of peers from the seeder will be different every time that will give a (slightly, hopefully)
< gribble> https://github.com/bitcoin/bitcoin/issues/20237 | net: Hardcoded seeds update for 0.21 by laanwj · Pull Request #20237 · bitcoin/bitcoin · GitHub
< Relis> Hi, is anyone exploring using zk tech to scale bitcoin?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18784: net: RecordBytesSent under cs_vSend lock (master...2004-netLockRecordBytesSent) https://github.com/bitcoin/bitcoin/pull/18784
< bitcoin-git> [bitcoin] jnewbery opened pull request #20258: [tests] Remove getnettotals/getpeerinfo consistency test (master...2020-10-remove-net-totals-test) https://github.com/bitcoin/bitcoin/pull/20258
< wumpus> i've added the bitcoin/gui repository here for the bot, i hope it won't be a mess
< bitcoin-git> [bitcoin] laanwj merged pull request #19877: [test] clarify rpc_net & p2p_disconnect_ban functional tests (master...2020-09-rpcnet-fixes) https://github.com/bitcoin/bitcoin/pull/19877
< bitcoin-git> bitcoin/master db26eeb Wladimir J. van der Laan: Merge #19877: [test] clarify rpc_net & p2p_disconnect_ban functional tests...
< bitcoin-git> bitcoin/master 47ff509 Amiti Uttarwar: [test] Clarify setup of node topology.
< bitcoin-git> bitcoin/master 0672522 Amiti Uttarwar: [move-only, test]: Match test order with run order
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/488b77f72e8f...db26eeba71fb
< gribble> https://github.com/bitcoin/bitcoin/issues/19753 | p2p: dont add AlreadyHave transactions to recentRejects by troygiorshev · Pull Request #19753 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20256: qt: Pre-splitoff translations update (master...2020_10_translations_update) https://github.com/bitcoin/bitcoin/pull/20256
< bitcoin-git> bitcoin/master 488b77f MarcoFalke: Merge #20256: qt: Pre-splitoff translations update
< bitcoin-git> bitcoin/master a193f96 Wladimir J. van der Laan: qt: Pre-splitoff translations update
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/55b1ffcd259c...488b77f72e8f
< bitcoin-git> [bitcoin] sipa opened pull request #20257: Update secp256k1 subtree to latest master (master...202010-secp256k1) https://github.com/bitcoin/bitcoin/pull/20257
< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16856: Do not allow descendants of BLOCK_FAILED_VALID blocks to be BLOCK_FAILED_VALID (master...2019-09-invalidate-block-child-invalid) https://github.com/bitcoin/bitcoin/pull/16856

2020-10-27

< sipa> bip322 proves the ability to spend coins sent to a particular bitcoin address; a lightning equivalent sounds like it would need a lightning-specific solution
< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #20256: qt: Pre-splitoff translations update (master...2020_10_translations_update) https://github.com/bitcoin/bitcoin/pull/20256
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20255: util: Add Assume() identity function (master...2010-assume) https://github.com/bitcoin/bitcoin/pull/20255
< bitcoin-git> [bitcoin] jonatack closed pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240
< bitcoin-git> bitcoin/master 55b1ffc Jonas Schnelli: Merge bitcoin-core/gui#116: Fix unreasonable default size of the main wind...
< bitcoin-git> bitcoin/master 7b2e42e Hennadii Stepanov: qt: Add WalletFrame::sizeHint
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83363f7b62f9...55b1ffcd259c
< jonasschnelli> wumpus: I think you should add githubmerge.pushmirrors=git@github.com:bitcoin-core/gui.git to your merge master repository
< bitcoin-git> [bitcoin] vasild opened pull request #20254: Add I2P support using statically configured destinations (master...i2p_static) https://github.com/bitcoin/bitcoin/pull/20254
< bitcoin-git> [bitcoin] fanquake opened pull request #20253: net: use std::chrono throughout maxOutbound logic (master...net_unused_outbound) https://github.com/bitcoin/bitcoin/pull/20253
< vasild> https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L1346 - this looks strange, it would check whether both POLLERR and POLLHUP are set at the same time.
< bitcoin-git> bitcoin/master fa9b485 MarcoFalke: test: Add test for -blockversion
< bitcoin-git> [bitcoin] laanwj merged pull request #20167: test: Add test for -blockversion (master...2010-testBlockversion) https://github.com/bitcoin/bitcoin/pull/20167
< bitcoin-git> bitcoin/master fa7fb0e MarcoFalke: test: Default blockversion to 4 in feature_block
< bitcoin-git> bitcoin/master fa2b778 MarcoFalke: test: Remove unused -blockversion from tests
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c1564baf3b5e...83363f7b62f9
< gribble> https://github.com/bitcoin/bitcoin/issues/19877 | [test] clarify rpc_net & p2p_disconnect_ban functional tests by amitiuttarwar · Pull Request #19877 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #19124: doc: Document ALLOW_HOST_PACKAGES dependency option (master...allowHostDoc) https://github.com/bitcoin/bitcoin/pull/19124
< bitcoin-git> bitcoin/master 47e2a35 skmcontrib: doc: Document ALLOW_HOST_PACKAGES dependency option
< bitcoin-git> bitcoin/master c1564ba Wladimir J. van der Laan: Merge #19124: doc: Document ALLOW_HOST_PACKAGES dependency option
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67d4643a1a76...c1564baf3b5e
< bitcoin-git> [bitcoin] fanquake merged pull request #20152: doc: Update wallet files in files.md (master...201015-sqlite) https://github.com/bitcoin/bitcoin/pull/20152
< bitcoin-git> bitcoin/master 67d4643 fanquake: Merge #20152: doc: Update wallet files in files.md
< bitcoin-git> bitcoin/master defe48a Hennadii Stepanov: doc: Update wallet files in files.md
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa463f116377...67d4643a1a76
< bitcoin-git> [bitcoin] fanquake closed pull request #20224: doc: CI system link added, clarity increased (squashed into a single commit) (master...master) https://github.com/bitcoin/bitcoin/pull/20224
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20247: fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 serialization. (master...fuzzers-netaddr-post-addrv2) https://github.com/bitcoin/bitcoin/pull/20247
< bitcoin-git> bitcoin/master fa463f1 MarcoFalke: Merge #20247: fuzz: Check for addrv1 compatibility before using addrv1 ser...
< bitcoin-git> bitcoin/master 903f3d0 practicalswift: fuzz: Check for addrv1 compatibility before using addrv1 serializer
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d67883d01e50...fa463f116377
< gribble> https://github.com/bitcoin/bitcoin/issues/19224 | [0.20] Backports by fanquake · Pull Request #19224 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17621 | IsUsedDestination should count any known single-key address by instagibbs · Pull Request #17621 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19606 | Backport wtxid relay to v0.20 by jnewbery · Pull Request #19606 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19681 | 0.19: Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19681 · bitcoin/bitcoin · GitHub

2020-10-26

< luke-jr> actual consensus rules versioning would look something very different: https://en.bitcoin.it/wiki/Consensus_versions
< bitcoin-git> [bitcoin] luke-jr opened pull request #20251: Move major version to first version integer as specified by SemVer (master...semver2) https://github.com/bitcoin/bitcoin/pull/20251
< bitcoin-git> [bitcoin] luke-jr opened pull request #20250: Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely (master...rpcwallet_explicit_fixups) https://github.com/bitcoin/bitcoin/pull/20250
< roconnor> Strangely BitcoinABC's CNetAddr:IsRoutable() gets miscompiled, but not Bitcoin's. I have no explaination.
< bitcoin-git> [bitcoin] dgpv opened pull request #20248: Fix test: length of R check in test/key_tests.cpp:key_signature_tests (master...fix-test-key-signature-low-r) https://github.com/bitcoin/bitcoin/pull/20248
< bitcoin-git> [bitcoin] practicalswift opened pull request #20247: fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 address serialization. (master...fuzzers-netaddr-post-addrv2) https://github.com/bitcoin/bitcoin/pull/20247
< gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
< luke-jr> AdulrunaRedviva: again, #bitcoin
< luke-jr> AdulrunaRedviva: #Bitcoin for user questions, but rephrase it
< wumpus> AdulrunaRedviva: it's unclear to me what you mean, I suppose you are using multiwallet but what are yo trying to do? to select a wallet for RPC getbalance in bitcoin-cli you can pass -rpcwallet=<walletname>
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20245: test: Run script_assets_test even if built --with-libs=no (master...2010-testAssetTestlibconsensus) https://github.com/bitcoin/bitcoin/pull/20245
< bitcoin-git> [bitcoin] fanquake closed pull request #20244: Create BITCOIN (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20244
< bitcoin-git> [bitcoin] MewTww opened pull request #20244: Create BITCOIN (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20244
< bitcoin-git> [bitcoin] hebasto opened pull request #20243: rpc, wallet: Expose wallet id in getwalletinfo RPC output (master...201026-wid) https://github.com/bitcoin/bitcoin/pull/20243
< vasild> luke-jr: https://github.com/bitcoin/bitcoin/pull/20234#issuecomment-716045914 what do you mean in particular? I think all is in the PR description, but apparently not, since you ask...
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20242: fuzz: Properly initialize PrecomputedTransactionData (master...2010-fuzzInit) https://github.com/bitcoin/bitcoin/pull/20242
< bitcoin-git> [bitcoin] instagibbs closed pull request #18723: Expand on contracting carve-out rule test (master...onemore_again) https://github.com/bitcoin/bitcoin/pull/18723
< gribble> https://github.com/bitcoin/bitcoin/issues/19683 | depends: Pin clang search paths for darwin host by dongcarl · Pull Request #19683 · bitcoin/bitcoin · GitHub
< ossifrage> bitcoin-qt: validation.cpp:1977: bool CChainState::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, const CChainParams&, bool): Assertion `hashPrevBlock == view.GetBestBlock()' failed.

2020-10-25

< bitcoin-git> [bitcoin] jonatack opened pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240
< bitcoin-git> [bitcoin] decryp2kanon opened pull request #20238: Trivial: Missing comments for signet parameters (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20238
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19918: sync: Replace LockAssertion with AssertLockHeldUnverified (master...pr/lockb) https://github.com/bitcoin/bitcoin/pull/19918
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19865: scripted-diff: Restore AssertLockHeld after #19668, remove LockAssertion (master...pr/locka) https://github.com/bitcoin/bitcoin/pull/19865
< bitcoin-git> [bitcoin] laanwj opened pull request #20237: net: Hardcoded seeds update for 0.21 (master...2020_10_seeds_update) https://github.com/bitcoin/bitcoin/pull/20237