< bitcoin-git>
[bitcoin] fanquake opened pull request #18082: logging: enable thread_local usage on macOS (master...macos_thread_local) https://github.com/bitcoin/bitcoin/pull/18082
< bitcoin-git>
[bitcoin] fanquake opened pull request #18081: test: set a name for CI Docker containers (master...name_ci_docker_containers) https://github.com/bitcoin/bitcoin/pull/18081
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18079: [0.19] psbt: check that various indexes and amounts are within bounds (0.19...psbt_fix_pr17156-0.19.1) https://github.com/bitcoin/bitcoin/pull/18079
< bitcoin-git>
[bitcoin] luke-jr closed pull request #18078: [0.19] psbt: check that various indexes and amounts are within bounds (master...psbt_fix_pr17156-0.19.1) https://github.com/bitcoin/bitcoin/pull/18078
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18078: [0.19] psbt: check that various indexes and amounts are within bounds (master...psbt_fix_pr17156-0.19.1) https://github.com/bitcoin/bitcoin/pull/18078
< bitcoin-git>
[bitcoin] dongcarl opened pull request #18072: Use `libc++` headers from macOS SDK instead of from clang (master...2020-01-macos-sdk-with-headers) https://github.com/bitcoin/bitcoin/pull/18072
< bitcoin-git>
[bitcoin] fanquake merged pull request #17336: scripts: search for first block file for linearize-data with some block files pruned (master...linearize) https://github.com/bitcoin/bitcoin/pull/17336
< bitcoin-git>
bitcoin/master 317fb96 Rjected: Add search for first blk file with pruned node
< bitcoin-git>
bitcoin/master 8625446 fanquake: Merge #17336: scripts: search for first block file for linearize-data with...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16681: Tests: Use self.chain instead of 'regtest' in all current tests (master...b19-testchains-tests) https://github.com/bitcoin/bitcoin/pull/16681
< bitcoin-git>
bitcoin/master f32564f MarcoFalke: Merge #16681: Tests: Use self.chain instead of 'regtest' in all current te...
< bitcoin-git>
bitcoin/master 1abcecc Jorge Timon: Tests: Use self.chain instead of 'regtest' in almost all current tests
< gwillen>
(if you haven't read all the stuff under https://github.com/bitcoin/bitcoin/tree/master/doc , do take a look, especially check out productivity.md, which is where I would add this with the other git tips)
< gwillen>
well, I have no power over help.github.com, but perhaps we could add it to one of the docs in the bitcoin core repo, if it's not there already
< bitcoin-git>
[bitcoin] promag opened pull request #18064: gui: Drop WalletModel dependency to RecentRequestsTableModel (master...2020-02-recentrequeststablemodel) https://github.com/bitcoin/bitcoin/pull/18064
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #18063: Improve UpdateForDescendants by using Epochs and Removing CacheMap (master...epoch-mempool-clean-split-2) https://github.com/bitcoin/bitcoin/pull/18063
< gribble>
https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< bitcoin-git>
[bitcoin] promag opened pull request #18060: gui: Drop PeerTableModel dependency to ClientModel (master...2020-02-peertablemodel) https://github.com/bitcoin/bitcoin/pull/18060
< bitcoin-git>
[bitcoin] laanwj merged pull request #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid (master...2019-09-better-header-knowledge) https://github.com/bitcoin/bitcoin/pull/16974
< bitcoin-git>
bitcoin/master 651e343 Wladimir J. van der Laan: Merge #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is i...
< bitcoin-git>
bitcoin/master 0a50019 Matt Corallo: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid
< bitcoin-git>
[bitcoin] jonatack opened pull request #18054: net: reference instead of copy in BlockConnected range loop (master...block-connected-ref-instead-of-copy) https://github.com/bitcoin/bitcoin/pull/18054
< bitcoin-git>
[bitcoin] hebasto closed pull request #18045: build: Do not use QtDBus for macOS builds (master...20200131-macos-qdbus) https://github.com/bitcoin/bitcoin/pull/18045
< bitcoin-git>
[bitcoin] hebasto opened pull request #18051: [WIP] build: Fix behavior when ALLOW_HOST_PACKAGES unset (master...20200201-fix-allowhostpackages) https://github.com/bitcoin/bitcoin/pull/18051
< bitcoin-git>
[bitcoin] jonasschnelli closed pull request #18042: Don't check for DBUS notification on macOS (master...2020/01/mac_dbus) https://github.com/bitcoin/bitcoin/pull/18042
< bitcoin-git>
[bitcoin] hebasto opened pull request #18045: build: Do not use QtDBus for macOS builds (master...20200131-macos-qdbus) https://github.com/bitcoin/bitcoin/pull/18045
< gribble>
https://github.com/bitcoin/bitcoin/issues/17951 | Use rolling bloom filter of recent block txs for AlreadyHave() check by sdaftuar . Pull Request #17951 . bitcoin/bitcoin . GitHub
< bitcoin-git>
[bitcoin] promag closed pull request #18035: gui: Drop BanTableModel dependency to ClientModel (master...2020-01-bantablemodel) https://github.com/bitcoin/bitcoin/pull/18035
< bitcoin-git>
[bitcoin] amitiuttarwar opened pull request #18038: P2P: Mempool tracks locally submitted transactions to improve privacy (master...2020-01-unbroadcast) https://github.com/bitcoin/bitcoin/pull/18038
< bitcoin-git>
[bitcoin] amitiuttarwar opened pull request #18037: Util: Allow scheduler to be mocked (master...2020-01-mock-scheduler) https://github.com/bitcoin/bitcoin/pull/18037
< bitcoin-git>
[bitcoin] promag opened pull request #18036: gui: Drop ShutdownWindow dependency to BitcoinGUI (master...2020-01-utilitydialog) https://github.com/bitcoin/bitcoin/pull/18036
< elichai2>
Saw the thing MarcoFalke said about tools relying on the output of the benchmark utility, should I drop the commit that tries to make it more readable then? https://github.com/bitcoin/bitcoin/pull/18014
< bitcoin-git>
[bitcoin] achow101 opened pull request #18032: Output a descriptor in createmultisig and addmultisigaddress (master...createms-descriptor) https://github.com/bitcoin/bitcoin/pull/18032
< gribble>
https://github.com/bitcoin/bitcoin/issues/17951 | Use rolling bloom filter of recent block txs for AlreadyHave() check by sdaftuar . Pull Request #17951 . bitcoin/bitcoin . GitHub
< wumpus>
you can always decide to create another channel if it reall yends up monopolizing the channel (e.g. I guess that's why #bitcoin-builds is separate)
< bitcoin-git>
[bitcoin] jonatack closed pull request #17535: test: add block height test to listsinceblock.py (master...rpc-wallet-blockheight-followups) https://github.com/bitcoin/bitcoin/pull/17535
< bitcoin-git>
[bitcoin] Sjors opened pull request #18030: doc: Coin::IsSpent() can also mean never existed (master...2020/01/doc_is_spent) https://github.com/bitcoin/bitcoin/pull/18030
< gwillen>
so I got an email about my PR, saying that "bitcoin-core-ci" failed -- is this an experimental alternative to Travis and Appveyor? Is it known-broken? It appears to have failed due to reasons unrelated to the PR.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18029: tests: Add fuzzing harness for AS-mapping (asmap) (master...fuzzers-asmap) https://github.com/bitcoin/bitcoin/pull/18029
< bitcoin-git>
[bitcoin] laanwj merged pull request #17984: test: Add p2p test for forcerelay permission (master...2001-qaTxForceRelay) https://github.com/bitcoin/bitcoin/pull/17984
< bitcoin-git>
bitcoin/master aaaae4d MarcoFalke: test: Add p2p test for forcerelay permission
< bitcoin-git>
bitcoin/master fa6b57b MarcoFalke: test: Fix whitespace in p2p_permissions.py
< bitcoin-git>
bitcoin/master faf4081 MarcoFalke: test: Make msg_tx a witness tx
< bitcoin-git>
[bitcoin] ajtowns opened pull request #18026: psbt_wallet_tests: use unique_ptr for GetSigningProvider (master...202001-getsigningprovider-fix) https://github.com/bitcoin/bitcoin/pull/18026
< bitcoin-git>
[bitcoin] meshcollider merged pull request #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple (master...wallet-box-pr-2) https://github.com/bitcoin/bitcoin/pull/17261
< bitcoin-git>
bitcoin/master fadc08a Andrew Chow: Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
< bitcoin-git>
bitcoin/master eb81fc3 Andrew Chow: Refactor: Allow LegacyScriptPubKeyMan to be null
< gwillen>
yeah, and I think it's absolutely not bitcoin-specific, I have had similar problems with code review processes in most contexts where I've had code review
< gribble>
https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof . Pull Request #17892 . bitcoin/bitcoin . GitHub