2019-03-27

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/656a15e5394d...3702e1c17b6c
< bitcoin-git> bitcoin/master 529c1ae John Newbery: [tests] Add test for wallet rebroadcasts
< bitcoin-git> bitcoin/master 3702e1c MarcoFalke: Merge #15646: [tests] Add test for wallet rebroadcasts
< gribble> https://github.com/bitcoin/bitcoin/issues/15632 | Remove ResendWalletTransactions from the Validation Interface by jnewbery · Pull Request #15632 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15632 | Remove ResendWalletTransactions from the Validation Interface by jnewbery · Pull Request #15632 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15676: [doc] [trivial] fix grammar (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15676
< bitcoin-git> [bitcoin] HashUnlimited opened pull request #15676: [doc] [trivial] fix grammar (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15676
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15620: rpc: Uncouple non-wallet rpcs from maxTxFee global (master...1903-rpcNoMaxTxFee) https://github.com/bitcoin/bitcoin/pull/15620
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/848ec5603f72...656a15e5394d
< bitcoin-git> bitcoin/master fa965e0 MarcoFalke: rpc: Use IsValidNumArgs over hardcoded size checks
< bitcoin-git> bitcoin/master fa96d76 MarcoFalke: rpc: Uncouple rpcs from maxTxFee global
< bitcoin-git> bitcoin/master fa1ad20 MarcoFalke: doc: Add release notes for 15620
< bitcoin-git> [bitcoin] laanwj merged pull request #15643: contrib: gh-merge: Include ACKs in merge commit (master...1903-ghMergeAck) https://github.com/bitcoin/bitcoin/pull/15643
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/208406038c12...848ec5603f72
< bitcoin-git> bitcoin/master fa1c073 MarcoFalke: contrib: gh-merge: Include review comments in merge commit
< bitcoin-git> bitcoin/master 848ec56 Wladimir J. van der Laan: Merge #15643: contrib: gh-merge: Include ACKs in merge commit
< bitcoin-git> [bitcoin] laanwj merged pull request #15519: Add Poly1305 implementation (master...2019/03/poly1305) https://github.com/bitcoin/bitcoin/pull/15519
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e14cd04abbb5...208406038c12
< bitcoin-git> bitcoin/master 03be7f4 Jonas Schnelli: Add Poly1305 implementation
< bitcoin-git> bitcoin/master b34bf30 Jonas Schnelli: Add Poly1305 bench
< bitcoin-git> bitcoin/master e9d5e97 Jonas Schnelli: Poly1305: tolerate the intentional unsigned wraparound in poly1305.cpp
< bitcoin-git> [bitcoin] sipa closed pull request #15673: 0.18 (master...0.18) https://github.com/bitcoin/bitcoin/pull/15673
< bitcoin-git> [bitcoin] Chery46 opened pull request #15673: 0.18 (master...0.18) https://github.com/bitcoin/bitcoin/pull/15673

2019-03-26

< bitcoin-git> [bitcoin] dongcarl opened pull request #15672: [WIP] docs: Improve net comments (master...2019-02-net-comments) https://github.com/bitcoin/bitcoin/pull/15672
< bitcoin-git> [bitcoin] dongcarl opened pull request #15671: net: Don't return unreachable local addresses for peer (master...2019-03-fix-getlocal) https://github.com/bitcoin/bitcoin/pull/15671
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15668: p2p: Slightly more private initial tx relay (master...1903-p2pSlightlyPrivateTxRelay) https://github.com/bitcoin/bitcoin/pull/15668
< bitcoin-git> [bitcoin] ariard opened pull request #15670: refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTim… (master...2019-03-remove-find-first-block-time-height) https://github.com/bitcoin/bitcoin/pull/15670
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15637: rpc: Rename size to vsize in mempool related calls (master...rebased-13008-rename-size-vsize) https://github.com/bitcoin/bitcoin/pull/15637
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8a8b03ecd221...e14cd04abbb5
< bitcoin-git> bitcoin/master e16b6a7 Miguel Herranz: rpc: Rename size to vsize in mempool related calls
< bitcoin-git> bitcoin/master e14cd04 MarcoFalke: Merge #15637: rpc: Rename size to vsize in mempool related calls
< bitcoin-git> [bitcoin] torkelrogstad opened pull request #15669: rpc: Fix help text for signtransactionwithXXX (master...signrawtx-rpc-help) https://github.com/bitcoin/bitcoin/pull/15669
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15668: p2p: Slightly more private initial tx relay (master...1903-p2pSlightlyPrivateTxRelay) https://github.com/bitcoin/bitcoin/pull/15668
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15666: Remove duplicate LIBBITCOIN_SERVER (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15666
< bitcoin-git> [bitcoin] Bushstar opened pull request #15666: Remove duplicate LIBBITCOIN_SERVER (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15666
< gribble> https://github.com/bitcoin/bitcoin/issues/15638 | Move-only: Pull wallet code out of libbitcoin_server by ryanofsky · Pull Request #15638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< Pink_> Use bitcoin wallet JEFFREY HENRY BANKS
< Pink_> Bitcoin miner mining

2019-03-25

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15603: docs: Add more tips to productivity.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15603
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7b13c6464579...8a8b03ecd221
< bitcoin-git> bitcoin/master 5801dd6 gwillen: docs: Add more tips to productivity.md
< bitcoin-git> bitcoin/master 8a8b03e MarcoFalke: Merge #15603: docs: Add more tips to productivity.md
< achow101> https://github.com/bitcoin/bitcoin/blob/master/doc/psbt.md has some info on how to use them
< BostX> sipa: maybe some warnings would be helpful. Like "You're signing a TX w/ no inputs". Or maybe a better message in the `bitcoin-cli help signrawtransactionwithwallet`
< BostX> sipa: Uhm... I'd like to sign my TX on an offline computer where I don't want to install anything other than bitcoin-core.
< sipa> BostX: perhaps you should head to bitcoin.stackexchange.com
< BostX> sipa: I created: bitcoin-cli createrawtransaction '[]' '{"unused-new-address": <number>}'
< bitcoin-git> [bitcoin] instagibbs opened pull request #15664: change default Python block serialization to witness, test round-trip (master...default_wit_block) https://github.com/bitcoin/bitcoin/pull/15664
< midnightmagic> Just a hackish informational thing that means I don't have to use bitcoin-iterate
< gmaxwell> It gets used by things like custom wallet software to make bitcoin core track data needed for spending. I assume electrum personal server uses it. Joinmarket uses it.
< bitcoin-git> [bitcoin] practicalswift opened pull request #15663: Remove unused AES-128 code (master...aes-128) https://github.com/bitcoin/bitcoin/pull/15663
< harding> echeveria: yes, but (as I mentioned) Bitcoin Core trickles txes. That is, it doesn't send to each of its peers immediately but separates all of its peers into buckets of peers and maintains a queue of transactions for each bucket, sending to all the peers in the bucket on some schedule. This means a transaction may be propagated to a non-spy node, relayed through the network, and then heard about by the spy node from some other
< harding> echeveria: encryption by itself, if we assume no mitm and no eclipse, improves own-transaction relay privacy in combination with Bitcoin Core's existing tx trickling code. Right now when you send your own transaction, spy nodes can't be sure whether you originated a transaction or just relayed it. However, your ISP can see that you never received the tx over clearnet before sending it, so unless your node is also on Tor or
< echeveria> I couldn't work that out. its pretty clear what is running bitcoin, from the traffic or the port number.

2019-03-24

< gribble> https://github.com/bitcoin/bitcoin/issues/15658 | depends: files missing from bitcoincore.org fallback · Issue #15658 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15660: [qa] Overhaul p2p_compactblocks.py (master...2019-03-refactor-p2p-compactblocks-2) https://github.com/bitcoin/bitcoin/pull/15660
< bitcoin-git> [bitcoin] r8921039 opened pull request #15659: [docs] fix findFork comment (master...fix_findFork_comment) https://github.com/bitcoin/bitcoin/pull/15659
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14050: Add chacha20/poly1305 and chacha20poly1305_AEAD from openssh (master...2018/08/bip151_chachapoly1305) https://github.com/bitcoin/bitcoin/pull/14050
< echeveria> harding: the only other one I was thinking of was Parity Bitcoin, and they seemed to have only been funded to create that for a very short period.
< harding> echeveria: not that I'm aware of at the moment. I was thinking about 2015-17 contention between Bitcoin Core and some of the stuff Unlimited was doing. Also XT had BIP64 support and a different protocol version.
< echeveria> is there any actually used implementation of a bitcoin node other than btcd and bitcoin core?
< bitcoin-git> [bitcoin] promag closed pull request #13189: Remove 2nd mapTx lookup in CTxMemPool::removeForBlock (master...2018-05-txmempool-removeforblock) https://github.com/bitcoin/bitcoin/pull/13189
< gribble> https://github.com/bitcoin/bitcoin/issues/14853 | depends: latest RapidCheck by fanquake · Pull Request #14853 · bitcoin/bitcoin · GitHub
< Randolf> whiteface: That question is better-suited for the #bitcoin channel.
< gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15474 | rest/rpc: Make mempoolinfo atomic by promag · Pull Request #15474 · bitcoin/bitcoin · GitHub

2019-03-23

< echeveria> luke-jr: the thing they’re useful for in bitcoin core is wallet rescans.
< bitcoin-git> [bitcoin] promag opened pull request #15656: wallet: Keep all outputs in bumpfee (master...2019-03-bumpall) https://github.com/bitcoin/bitcoin/pull/15656
< bitcoin-git> [bitcoin] 251Labs opened pull request #15655: Resolve the checkpoints <-> validation circular dependency (master...patch/resolve-checkpoints-validation-cd) https://github.com/bitcoin/bitcoin/pull/15655
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15654: net: Remove unused unsanitized user agent string CNode::strSubVer (master...1903-netUABytes) https://github.com/bitcoin/bitcoin/pull/15654
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15647: [rpc] Remove deprecated functionality message from validateaddress help (0.18...2019_03_backport_remove_verifyaddress_deprecated_warning) https://github.com/bitcoin/bitcoin/pull/15647
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/b0222428879f...7eab2db849d9
< bitcoin-git> bitcoin/0.18 be8b9c6 John Newbery: [rpc] Remove deprecated functionality message from validateaddress help
< bitcoin-git> bitcoin/0.18 7eab2db MarcoFalke: Merge #15647: [rpc] Remove deprecated functionality message from validatea...
< bitcoin-git> [bitcoin] promag opened pull request #15652: wallet: Update transactions with current mempool after load (master...2019-03-fix-15591) https://github.com/bitcoin/bitcoin/pull/15652
< gribble> https://github.com/bitcoin/bitcoin/issues/15647 | [rpc] Remove deprecated functionality message from validateaddress help by jnewbery · Pull Request #15647 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15642: [rpc] Remove deprecated rpc warnings (master...2019_03_remove_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/15642
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/68520597ccf8...7b13c6464579
< bitcoin-git> bitcoin/master 839c3f7 John Newbery: [rpc] Remove signrawtransaction warning
< bitcoin-git> bitcoin/master 7b6616b John Newbery: [rpc] Remove deprecated functionality message from validateaddress help
< bitcoin-git> bitcoin/master 947f73c John Newbery: [docs] remove reference to signrawtransaction in the developer docs.
< gribble> https://github.com/bitcoin/bitcoin/issues/15642 | [rpc] Remove deprecated rpc warnings by jnewbery · Pull Request #15642 · bitcoin/bitcoin · GitHub
< gmaxwell> https://en.bitcoin.it/wiki/Bech32_adoption < useful reference.
< gribble> https://github.com/bitcoin/bitcoin/issues/15560 | When to make bech32 the default -addresstype? · Issue #15560 · bitcoin/bitcoin · GitHub
< gmaxwell> #proposedmeetingtopic Bech32 support shipped first in Bitcoin Core in Feb 2018, more than a year ago. We should consider making an announcement that Bitcoin Core intends to change the default addresstype from p2sh-segwit to bech32 in 0.19 or 0.20.
< bitcoin-git> [bitcoin] luke-jr opened pull request #15651: torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently (master...tor_standard_port) https://github.com/bitcoin/bitcoin/pull/15651
< bitcoin-git> [bitcoin] lucayepa opened pull request #15650: Handle the result of posix_fallocate system call (master...handle-posix-fallocate) https://github.com/bitcoin/bitcoin/pull/15650

2019-03-22

< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15649: Add ChaCha20Poly1305@Bitcoin AEAD (master...2019/03/chachapoly1305) https://github.com/bitcoin/bitcoin/pull/15649
< bitcoin-git> [bitcoin] jnewbery opened pull request #15647: [rpc] Remove deprecated functionality message from validateaddress help (0.18...2019_03_backport_remove_verifyaddress_deprecated_warning) https://github.com/bitcoin/bitcoin/pull/15647
< bitcoin-git> [bitcoin] jnewbery opened pull request #15646: [tests] Add test for wallet rebroadcasts (master...2019_03_wallet_rebroadcasat_test) https://github.com/bitcoin/bitcoin/pull/15646
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15631: qa: mininode: Clearer error message on invalid magic bytes (master...1903-qaMagicMininode) https://github.com/bitcoin/bitcoin/pull/15631
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/abd914ed34f1...68520597ccf8
< bitcoin-git> bitcoin/master fab0a68 MarcoFalke: qa: mininode: Clearer error message on invalid magic bytes
< bitcoin-git> bitcoin/master 6852059 MarcoFalke: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes
< bitcoin-git> [bitcoin] sipa opened pull request #15644: Make orphan processing interruptible (master...201903_interruptibleorphans) https://github.com/bitcoin/bitcoin/pull/15644
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15643: contrib: gh-merge: Include review comments in merge commit (master...1903-ghMergeAck) https://github.com/bitcoin/bitcoin/pull/15643
< bitcoin-git> [bitcoin] laanwj merged pull request #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019/03/promag/2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15641
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/238ef3369296...b0222428879f
< bitcoin-git> bitcoin/0.18 98a24a2 João Barbosa: gui: Defer removeAndDeleteWallet when no modal widget is active
< bitcoin-git> bitcoin/0.18 b022242 Wladimir J. van der Laan: Merge #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet wh...
< bitcoin-git> [bitcoin] jnewbery opened pull request #15642: [rpc] Remove deprecated rpc functionality (master...2019_03_remove_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/15642
< gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack reopened pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607
< bitcoin-git> [bitcoin] jonatack closed pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019/03/promag/2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15641
< gribble> https://github.com/bitcoin/bitcoin/issues/15591 | balance wrong after unloading wallet and loading it again · Issue #15591 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15614: gui: Defer removeAndDeleteWallet when no modal widget is active (master...2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15614
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/717fd58c4ba5...abd914ed34f1
< bitcoin-git> bitcoin/master a10972b João Barbosa: gui: Defer removeAndDeleteWallet when no modal widget is active
< bitcoin-git> bitcoin/master abd914e Jonas Schnelli: Merge #15614: gui: Defer removeAndDeleteWallet when no modal widget is act...
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency (master...pr/link2) https://github.com/bitcoin/bitcoin/pull/15639
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638
< bitcoin-git> [bitcoin] fanquake closed pull request #13008: rpc: Rename size to vsize in mempool related calls (master...rename-size-to-vsize) https://github.com/bitcoin/bitcoin/pull/13008
< bitcoin-git> [bitcoin] fanquake opened pull request #15637: rpc: Rename size to vsize in mempool related calls (master...rebased-13008-rename-size-vsize) https://github.com/bitcoin/bitcoin/pull/15637

2019-03-21

< echeveria> wumpus: for the record, I reported the malicious versions of the bitcoin core website to the host.
< sipa> or even that the source code is what people canonically understand to be bitcoin core
< jonasschnelli> (An attacker could register "Bitcoin Core Code Shitting Association" and signing the malicious binary with that and nobody would recognise that)
< gwillen> "the bitcoin core code signing association thinks Windows should not yell when running this binary"
< luke-jr> "this is bitcoin core" *should* be meaningless really
< jonasschnelli> It only tells users it was signed by an organisation called "Bitcoin Core Code Signing Association"
< sipa> or "this is bitcoin core"
< luke-jr> jonasschnelli: obviously there would have to be some reasonable policy on what gets signed (eg, gitian builds of Bitcoin-compatible software)
< jonasschnelli> There is another association I'm currently building up (with a proper structure) called "Bitcoin Developer and Researcher Association" (BitDRA) which should aim to finance real work/projects
< gwillen> yes I am happy to formally donate to the Bitcoin Core Code Signing Association, someone should tell me an amount and where to mail a check :-)
< jonasschnelli> Bitcoin Core Code Signing Association (based in Switzerland)
< warren> oh I missed the win signature discussion, will it be something other than Bitcoin Foundation in the future?
< wumpus> surprisingly much of the infrastructure and stuff around bitcoin is hanging together by a few threads, and single individuals that happily still care about it
< wumpus> thanks to the Linux Foundation too, then! it wouldn't be crazy for them to drop bitcoin-dev if it's such a hot potato
< warren> It's worth noting despite trying to deprecate the old mailman2 server they've tried to keep it online for us and a few other dev communities who had a hard time moving, and most of their downtime trouble was due to DoS attacks targeting only bitcoin-dev.
< wumpus> in principle it's even off topic in the bitcoin core meeting, the bitcoin-dev mailing list is outside it's scope, not that I mind
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15596 | rpc: Ignore sendmany::minconf as dummy value by MarcoFalke · Pull Request #15596 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< jonasschnelli> Would also be good to get a sponsor for the Bitcoin Core Code Signing Association at some point (raise your hand if your willing)
< jonasschnelli> cfields: should we register a new one via the Bitcoin Core Code Signing Association?
< promag> again, this is really very unlikely, you have to run bitcoin-qt -server
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...2019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15310 | gui: crash if encrypt / change passphrase window is open and wallet is unloaded · Issue #15310 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] gmaxwell closed pull request #15633: Ignore BIP-152 HB requests from non-witness peers. (master...201803-nohbcbfornonwit) https://github.com/bitcoin/bitcoin/pull/15633
< wumpus> I think it's one of the most popular devices to run a bitcoin node on
< emilr> I'm building bitcoin on a rpi, biggest hurdle thus far is the dependency tree, I had to give up on building boost-libs and use binaries
< bitcoin-git> [bitcoin] gmaxwell opened pull request #15633: Ignore BIP-152 HB requests from non-witness peers. (master...201803-nohbcbfornonwit) https://github.com/bitcoin/bitcoin/pull/15633
< gribble> https://github.com/bitcoin/bitcoin/issues/84 | Transaction-less transfer of value · Issue #84 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub
< wumpus> so apparently there's some funding initiative by Twitter/Square for core devs (I only learn of this through twitter now), https://twitter.com/jimmysong/status/1108500506106843137 - anyhow, if you're actively involved in Bitcoin Core's development and need this funding, and would like me to write a recommendation for you, let me know
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15625: refactor: Remove unused function (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/15625
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2607d960a02e...717fd58c4ba5
< bitcoin-git> bitcoin/master bb6195e practicalswift: refactor: Remove unused function
< bitcoin-git> bitcoin/master 717fd58 MeshCollider: Merge #15625: refactor: Remove unused function
< bitcoin-git> [bitcoin] MeshCollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b3f82284ba90...2607d960a02e
< bitcoin-git> bitcoin/master 91868e6 Russell Yanofsky: Remove use CValidationInterface in wallet code
< bitcoin-git> bitcoin/master 4e4d9e9 Russell Yanofsky: Remove use of CRPCTable::appendCommand in wallet code
< bitcoin-git> bitcoin/master b1b2b23 Russell Yanofsky: Remove use of CCoinsViewMemPool::GetCoin in wallet code
< bitcoin-git> [bitcoin] MeshCollider merged pull request #10973: Refactor: separate wallet from node (master...pr/wipc-sep) https://github.com/bitcoin/bitcoin/pull/10973
< echeveria> fanquake: I can confirm that this is an attack site (as if it wasn't obvious). depending on the links you follow, you either get the legit binaries, or "bitcoin.exe".

2019-03-20

< bitcoin-git> [bitcoin] jnewbery opened pull request #15632: Remove ResendWalletTransactions from the Validation Interface (master...no_resend_wallet_txs) https://github.com/bitcoin/bitcoin/pull/15632
< gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl · Pull Request #14856 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15631: qa: mininode: Clearer error message on invalid magic bytes (master...1903-qaMagicMininode) https://github.com/bitcoin/bitcoin/pull/15631
< gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
< dongcarl> ryanofsky: I see. When we have multiprocess bitcoin, will it be an interface violation for optionsmodel.cpp to include net.h?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15629: init: Throw error when network specific config is ignored (master...1903-InitErrorConf) https://github.com/bitcoin/bitcoin/pull/15629
< bitcoin-git> [bitcoin] laanwj pushed 18 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/392d1382c1b1...6cf81b01b48e
< bitcoin-git> bitcoin/0.17 f455979 Andrew Chow: Add function to close all Db's and reload the databae environment
< bitcoin-git> bitcoin/0.17 048fda2 Andrew Chow: After encrypting the wallet, reload the database environment
< bitcoin-git> bitcoin/0.17 435df68 Andrew Chow: Move BerkeleyEnvironment deletion from internal method to callsite
< bitcoin-git> [bitcoin] laanwj merged pull request #15575: 0.17: Backport 15297 (0.17...2019-03-backport-15297-017) https://github.com/bitcoin/bitcoin/pull/15575
< bitcoin-git> [bitcoin] laanwj merged pull request #15597: net: Generate log entry when blocks messages are received unexpectedly (master...2019-03-12-net-unexpected-block) https://github.com/bitcoin/bitcoin/pull/15597
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbc436e09ef1...b3f82284ba90
< bitcoin-git> bitcoin/master ef0019e Patrick Strateman: Generate log entry when blocks messages are received unexpectedly.
< bitcoin-git> bitcoin/master b3f8228 Wladimir J. van der Laan: Merge #15597: net: Generate log entry when blocks messages are received un...
< bitcoin-git> [bitcoin] laanwj merged pull request #15626: Docs: Update ACK description in CONTRIBUTING.md (master...update-ack-description-in-contributing-md) https://github.com/bitcoin/bitcoin/pull/15626
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/93623eea71e7...bbc436e09ef1
< bitcoin-git> bitcoin/master 0d9d2b3 Jon Atack: Doc: update ACK description in CONTRIBUTING.md
< bitcoin-git> bitcoin/master bbc436e Wladimir J. van der Laan: Merge #15626: Docs: Update ACK description in CONTRIBUTING.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15623: refactor: Expose UndoReadFromDisk in header (master...1903-UndoReadFromDiskHeader) https://github.com/bitcoin/bitcoin/pull/15623
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81f732bcaa30...93623eea71e7
< bitcoin-git> bitcoin/master fa11c03 MarcoFalke: refactor: Expose UndoReadFromDisk in header
< bitcoin-git> bitcoin/master 93623ee MarcoFalke: Merge #15623: refactor: Expose UndoReadFromDisk in header
< dongcarl> nothingmuch: basically, instead of having an actual IP, you have (0xFD + sha256("bitcoin")[0:5] + sha256(hostname))[0:16], which is useful in cases where you don't actually care about the IP, but the hostname, e.g. for seeds
< gribble> https://github.com/bitcoin/bitcoin/issues/10446 | net: avoid extra dns query per seed by theuni · Pull Request #10446 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11512 | Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding by TheBlueMatt · Pull Request #11512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10466 | Use localhost for bitcoin · Issue #10466 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #15627: Update bitcoin_de.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15627
< bitcoin-git> [bitcoin] layer1gfx opened pull request #15627: Update bitcoin_de.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15627
< gribble> https://github.com/bitcoin/bitcoin/issues/15607 | [Docs] Release process updates by jonatack · Pull Request #15607 · bitcoin/bitcoin · GitHub
< wumpus> there's also still a few PRs (such as #12493) that are marked "needs release note" https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=label%3A%22Needs+release+note%22+
< gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15607 | [Docs] Release process updates by jonatack · Pull Request #15607 · bitcoin/bitcoin · GitHub
< wumpus> i've added the list of PRs and authors to the preliminary release notes, if someone could double-check that'd be good, https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft
< bitcoin-git> [bitcoin] jonatack opened pull request #15626: Docs: Update ACK description in CONTRIBUTING.md (master...update-ack-description-in-contributing-md) https://github.com/bitcoin/bitcoin/pull/15626
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/d3a038200709...238ef3369296
< bitcoin-git> bitcoin/0.18 238ef33 Pieter Wuille: Do not relay banned IP addresses
< bitcoin-git> [bitcoin] laanwj merged pull request #15617: p2p: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45b7f20e651...81f732bcaa30
< bitcoin-git> bitcoin/master 054d01d Pieter Wuille: Do not relay banned IP addresses
< bitcoin-git> bitcoin/master 81f732b Wladimir J. van der Laan: Merge #15617: p2p: Do not relay banned IP addresses
< bitcoin-git> [bitcoin] practicalswift opened pull request #15625: refactor: Remove unused function (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/15625

2019-03-19

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15623: refactor: Expose UndoReadFromDisk in header (master...1903-UndoReadFromDiskHeader) https://github.com/bitcoin/bitcoin/pull/15623
< bitcoin-git> [bitcoin] practicalswift opened pull request #15622: Remove globals: Avoid using the global namespace if possible (master...globals-1) https://github.com/bitcoin/bitcoin/pull/15622

2019-03-18

< harding> moneyball: are you using the version with ./bitcoin-cli embedded? You need the one where the lines start with "setban"
< moneyball> $bitcoin-cli listbanned | grep address | wc -l
< moneyball> $bitcoin-cli listbanned | grep manually | wc -l
< gmaxwell> $ ./bitcoin-cli listbanned | grep address | wc -l
< moneyball> i used bitcoin-cli listbanned to determine i have 474 banned, all of which are manually added. greg's list has 670. so i am wondering why my ban list is less (likely due to error aborting prematurely?). i am also still wondering about the "already banned" error message since i have none in the ban list that are shown as automatic.
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c033c4b5cef8...e45b7f20e651
< bitcoin-git> bitcoin/master fa5c511 MarcoFalke: refactor: Remove unused function
< bitcoin-git> bitcoin/master e45b7f2 Wladimir J. van der Laan: Merge #15618: refactor: Remove unused function
< bitcoin-git> [bitcoin] laanwj merged pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15620: rpc: Uncouple rpcs from maxTxFee global (master...1903-rpcNoMaxTxFee) https://github.com/bitcoin/bitcoin/pull/15620
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #13541: wallet/rpc: sendrawtransaction maxfeerate (master...sendrawtransaction-maxfeerate) https://github.com/bitcoin/bitcoin/pull/13541
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2c336a9ccdf4...c033c4b5cef8
< bitcoin-git> bitcoin/master e5efacb Karl-Johan Alm: test: Refactor vout fetches in rpc_rawtransaction
< bitcoin-git> bitcoin/master 6c0a6f7 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to sendrawtransaction
< bitcoin-git> bitcoin/master 7abd2e6 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to testmempoolaccept
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/27781b6530c0...2c336a9ccdf4
< bitcoin-git> bitcoin/master 340ef50 Carl Dong: depends: Defer to Python detected by autoconf
< bitcoin-git> bitcoin/master 89bee1b Carl Dong: depends: tar: Always extract as yourself
< bitcoin-git> bitcoin/master f7696e6 Carl Dong: depends: qt: Don't hardcode pwd path
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15581: depends: Make less assumptions about build env (master...2019-03-true-neutral-depends) https://github.com/bitcoin/bitcoin/pull/15581
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15466: tests: Print remaining jobs in test_runner.py (master...remaining-jobs) https://github.com/bitcoin/bitcoin/pull/15466
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ec7aea44281...27781b6530c0
< bitcoin-git> bitcoin/master 2e5d482 Steven Roose: tests: Print remaining jobs in test_runner.py
< bitcoin-git> bitcoin/master 27781b6 MarcoFalke: Merge #15466: tests: Print remaining jobs in test_runner.py
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/acbbb7bf0d45...7ec7aea44281
< bitcoin-git> bitcoin/master faf3698 Glenn Willen: wallet: Improve log output for errors during load
< bitcoin-git> bitcoin/master 7ec7aea MeshCollider: Merge #15491: wallet: Improve log output for errors during load
< bitcoin-git> [bitcoin] sipa opened pull request #15617: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15616: rpc: Remove hex from decodescript RPCResult doc (master...1903-rpcDocDecodeS) https://github.com/bitcoin/bitcoin/pull/15616

2019-03-17

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15601: build: depends: Switch to python3 (take 3) (master...1903-buildPy3) https://github.com/bitcoin/bitcoin/pull/15601
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85f003274d8c...acbbb7bf0d45
< bitcoin-git> bitcoin/master fa0f92a MarcoFalke: build: depends: Switch to python3
< bitcoin-git> bitcoin/master acbbb7b MarcoFalke: Merge #15601: build: depends: Switch to python3 (take 3)
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15615: Add log output during initial header sync (master...2019/03/hdr_sync) https://github.com/bitcoin/bitcoin/pull/15615
< bitcoin-git> [bitcoin] promag opened pull request #15614: 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15614
< bitcoin-git> [bitcoin] pstratem opened pull request #15613: net: Simplify PONG handler, improve readability of the processing logic. (master...2019-03-17-net-processing-pong) https://github.com/bitcoin/bitcoin/pull/15613
< Guest41284> peers of this type pretend to be running various versions of Bitcoin software, but are not. they respond with compact blocks handshakes, pings and pongs, but never respond to headers, get blocks, or inventory messages. the addr messages they push are stuffed with like-peers, and in general seem to be over represented in outgoing connections of normal nodes.
< bitcoin-git> [bitcoin] laanwj merged pull request #15611: Add Gitian key for droark (master...master-keys-update) https://github.com/bitcoin/bitcoin/pull/15611
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2f501fb5c68d...85f003274d8c
< bitcoin-git> bitcoin/master 204c729 Douglas Roark: Add Gitian key for droark
< bitcoin-git> bitcoin/master 85f0032 Wladimir J. van der Laan: Merge #15611: Add Gitian key for droark
< gribble> https://github.com/bitcoin/bitcoin/issues/15611 | Add Gitian key for droark by droark · Pull Request #15611 · bitcoin/bitcoin · GitHub
< gmaxwell> you could try to compress up some non-bitcoin stuff to save you some space... or try to force a leveldb compaction.
< fanquake> dongcarl no worries. Yea, and I'll update my comment here: https://github.com/bitcoin/bitcoin/pull/15277#issuecomment-473539212, with some more info.

2019-03-16

< gribble> https://github.com/bitcoin/bitcoin/issues/14917 | wallet_multiwallet --usecli fails with "Duplicate -wallet filename specified" · Issue #14917 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] droark opened pull request #15611: Add Gitian key for droark (master...master-keys-update) https://github.com/bitcoin/bitcoin/pull/15611
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
< gmaxwell> Googling shows one or two other pages also saying "bitcoin bark" but it doesn't appear to be an altcoin.
< gribble> https://github.com/bitcoin/bitcoin/issues/15487 | [WIP] descriptor based wallet serialization and import by Sjors · Pull Request #15487 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15522: Document sizeof(size_t) assumptions and compiler assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/165ea14efeda...2f501fb5c68d
< bitcoin-git> bitcoin/master c7ea8d3 practicalswift: Add sizeof(size_t) assumptions
< bitcoin-git> bitcoin/master c7a7250 practicalswift: Document assumptions about C++ compiler
< bitcoin-git> bitcoin/master 2f501fb Wladimir J. van der Laan: Merge #15522: Document sizeof(size_t) assumptions and compiler assumptions...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cede01b41668...165ea14efeda
< bitcoin-git> bitcoin/master 92f3e80 John Newbery: [docs] release note for disabling reject messages by default
< bitcoin-git> bitcoin/master 165ea14 Wladimir J. van der Laan: Merge #15604: [docs] release note for disabling reject messages by default...
< bitcoin-git> [bitcoin] laanwj merged pull request #15604: [docs] release note for disabling reject messages by default (master...release_notes_bip61) https://github.com/bitcoin/bitcoin/pull/15604
< bitcoin-git> [bitcoin] laanwj merged pull request #15609: scripts and tools: Set 'distro' explicitly (master...20190314-set-distro) https://github.com/bitcoin/bitcoin/pull/15609
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/118a5c8d94de...cede01b41668
< bitcoin-git> bitcoin/master b8705a0 Hennadii Stepanov: Set 'distro' explicitly
< bitcoin-git> bitcoin/master cede01b Wladimir J. van der Laan: Merge #15609: scripts and tools: Set 'distro' explicitly
< gribble> https://github.com/bitcoin/bitcoin/issues/15609 | scripts and tools: Set distro explicitly by hebasto · Pull Request #15609 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15604 | [docs] release note for disabling reject messages by default by jnewbery · Pull Request #15604 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15541 | Reproducibility issue with 0.18.0rc1 · Issue #15541 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #15609: scripts and tools: Set 'distro' explicitly (master...20190314-set-distro) https://github.com/bitcoin/bitcoin/pull/15609
< warren> I apologize for not participating in gitian for a while. debootstrap has not worked on Fedora for a few years now. I'm hoping people can help https://github.com/bitcoin/bitcoin/pull/15277 so we have a deterministic buildsystem to replace gitian.

2019-03-15

< provoostenator> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb