2019-02-27

< bitcoin-git> bitcoin/master 6f43ed4 Wladimir J. van der Laan: Merge #15462: gui: Fix async open wallet call order
< gribble> https://github.com/bitcoin/bitcoin/issues/15478 | wip: gui: Refactor open wallet activity by promag · Pull Request #15478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15493: rfc: Add -printconfig arg to bitcoind (master...2019-02-printconfig) https://github.com/bitcoin/bitcoin/pull/15493
< bitcoin-git> [bitcoin] Sjors opened pull request #15492: [rpc] remove deprecated generate method (master...2019/02/rpc-generate-remove) https://github.com/bitcoin/bitcoin/pull/15492
< gribble> https://github.com/bitcoin/bitcoin/issues/15491 | wallet: Improve log output for errors during load by gwillen · Pull Request #15491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15424 | [wallet] wallet-tool: command to remove key metadata by Sjors · Pull Request #15424 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] gwillen opened pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
< bitcoin-git> [bitcoin] fanquake closed pull request #15490: Update copyright headers to 2019 (master...master) https://github.com/bitcoin/bitcoin/pull/15490
< bitcoin-git> [bitcoin] iamgru opened pull request #15490: Update copyright headers to 2019 (master...master) https://github.com/bitcoin/bitcoin/pull/15490
< gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15489: doc: Update release process for snap package (master...1902-docSnap) https://github.com/bitcoin/bitcoin/pull/15489

2019-02-26

< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< parmado> is the consensus here that bitcoin will dominate amongst electronic assets, or is there substantial disagreement on that?
< sipa> parmado: #bitcoin
< luke-jr> parmado: the channel is intentionally open to the public; however, if you have questions about Bitcoin, #bitcoin is usually a better place to ask
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14775: net: 'break' should be 'continue' here? (master...patch-6) https://github.com/bitcoin/bitcoin/pull/14775
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15487: [WIP] descriptor based wallet (master...2019/02/descriptor-wallet) https://github.com/bitcoin/bitcoin/pull/15487
< gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15486: [net] Allow feeler connections to go to the same netgroup as existing outbound peers (master...2019-02-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15486
< bitcoin-git> [bitcoin] adamjonas opened pull request #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (master...test_rpc_misc) https://github.com/bitcoin/bitcoin/pull/15485
< gribble> https://github.com/bitcoin/bitcoin/issues/15481 | Restrict timestamp when mining a diff-adjustment block to prev-600 by TheBlueMatt · Pull Request #15481 · bitcoin/bitcoin · GitHub
< achow101> Has anyone seen this issue with 0.17.1 on ubuntu 18.10 before: https://bitcoin.stackexchange.com/questions/84868/bitcoin-qt-testnet-0-17-1-send-and-receive-buttons-do-nothing?
< gribble> https://github.com/bitcoin/bitcoin/issues/15484 | No feeler connection is made when our tip is stale · Issue #15484 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15471: rpc/gui: Remove 'Unknown block versions being mined' warning (master...2019_02_false_positives) https://github.com/bitcoin/bitcoin/pull/15471
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f470ecc534d...d88f7f8764b1
< bitcoin-git> bitcoin/master ef362f2 Wladimir J. van der Laan: rpc/gui: Remove 'Unknown block versions being mined' warning
< bitcoin-git> bitcoin/master d88f7f8 MarcoFalke: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning...
< bitcoin-git> [bitcoin] darosior opened pull request #15483: Adding a 'logpath' entry to getrpcinfo, as discussed in #15438 (master...getrpcinfo_logpath) https://github.com/bitcoin/bitcoin/pull/15483
< Muoi> I run a Bitcoin node, there is no IP inserted to tried table since December, is this a problem?
< kanzure> just fyi, bitcoin-dev mailing list is temporarily broken
< gribble> https://github.com/bitcoin/bitcoin/issues/15482 | Implement BIPXXXs new softfork rules (The Great Consensus Cleanup) by TheBlueMatt · Pull Request #15482 · bitcoin/bitcoin · GitHub

2019-02-25

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #15482: Implement BIPXXX's new softfork rules (The Great Consensus Cleanup) (master...2019-02-great-consensus-cleanup) https://github.com/bitcoin/bitcoin/pull/15482
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #15481: Restrict timestamp when mining a diff-adjustment block to prev-600 (master...2019-02-600s-gbt) https://github.com/bitcoin/bitcoin/pull/15481
< sipa> dongcarl: it's hash160 of the public key. from bitcoin's perspective, compressed and uncompressed public keys are distinct
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15479: test: Add .style.yapf (master...Mf1902-testYapf) https://github.com/bitcoin/bitcoin/pull/15479
< bitcoin-git> [bitcoin] promag opened pull request #15478: wip: gui: Refactor open wallet activity (master...2019-02-refactor-open-wallet) https://github.com/bitcoin/bitcoin/pull/15478
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15477: doc: Remove misleading hint in getrawtransaction (master...Mf1902-rpcRawDocFix) https://github.com/bitcoin/bitcoin/pull/15477
< gribble> https://github.com/bitcoin/bitcoin/issues/15471 | rpc/gui: Remove Unknown block versions being mined warning by laanwj · Pull Request #15471 · bitcoin/bitcoin · GitHub
< provoostenator> sipa: see latest comment on PR: https://github.com/bitcoin/bitcoin/pull/15471#issuecomment-467137377
< provoostenator> on master nUpgraded tracks whether we send an alert https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2262
< bitcoin-git> [bitcoin] geekastute opened pull request #15475: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15475
< bitcoin-git> [bitcoin] geekastute closed pull request #15475: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15475
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15419: qa: Always refresh cache to be out of ibd (master...Mf1902-mocktime) https://github.com/bitcoin/bitcoin/pull/15419
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b4fc5257b7dc...8f470ecc534d
< bitcoin-git> bitcoin/master fab0d85 MarcoFalke: qa: Remove mocktime unless required
< bitcoin-git> bitcoin/master 1111aec MarcoFalke: qa: Always refresh stale cache to be out of ibd
< bitcoin-git> bitcoin/master fa25210 MarcoFalke: qa: Fix wallet_txn_doublespend issue
< bitcoin-git> [bitcoin] promag opened pull request #15474: rest/rpc: Make mempoolinfo atomic (master...2019-02-atomic-mempoolinfo) https://github.com/bitcoin/bitcoin/pull/15474
< aj> provoostenator: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-December/016556.html ? but NOINPUT tagging per the more recent threads seems more likely than OP_MASK at this point
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15473: bench: Benchmark MempoolToJSON (master...Mf1902-benchRpcMempool) https://github.com/bitcoin/bitcoin/pull/15473
< gribble> https://github.com/bitcoin/bitcoin/issues/13972 | Remove 16 bits from versionbits signalling system by btcdrak · Pull Request #13972 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15471 | rpc/gui: Remove Unknown block versions being mined warning by laanwj · Pull Request #15471 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] qingqingzijjin opened pull request #15472: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15472
< bitcoin-git> [bitcoin] fanquake closed pull request #15472: Create Bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15472
< provoostenator> Is there a SegWit v1 proposal on the bitcoin-dev list or elsewhere that I just managed to overlook? I though gmaxwell referred to that a few days ago in the context of SIGHASH_NO_INPUT_FULL_DISCLAIMER
< bitcoin-git> [bitcoin] laanwj merged pull request #15456: Enable PID file creation on WIN (master...master) https://github.com/bitcoin/bitcoin/pull/15456
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a8a5ede9fc3...b4fc5257b7dc
< bitcoin-git> bitcoin/master 3f5ad62 riordant: Enable PID file creation on Windows
< bitcoin-git> bitcoin/master b4fc525 Wladimir J. van der Laan: Merge #15456: Enable PID file creation on WIN
< bitcoin-git> [bitcoin] laanwj opened pull request #15471: rpc/gui: Remove 'Unknown block versions being mined' warning (master...2019_02_false_positives) https://github.com/bitcoin/bitcoin/pull/15471
< bitcoin-git> [bitcoin] laanwj merged pull request #15401: rpc: Actually throw help when passed invalid number of params (master...Mf1902-rpcNumArgs) https://github.com/bitcoin/bitcoin/pull/15401
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f3f9c1de19e6...1a8a5ede9fc3
< bitcoin-git> bitcoin/master fa05626 MarcoFalke: rpc: Add RPCHelpMan::IsValidNumArgs()
< bitcoin-git> bitcoin/master fa4ce70 MarcoFalke: rpc: Actually throw help when passed invalid number of params
< bitcoin-git> bitcoin/master 1a8a5ed Wladimir J. van der Laan: Merge #15401: rpc: Actually throw help when passed invalid number of param...
< moneyball> also there is now more information about the conference on the web site https://breaking-bitcoin.com/
< moneyball> the dates are set - same as communicated a few months ago. it will precede the breaking bitcoin conference, june 5-7, with the conference being that weekend june 8-9, in amsterdam. so you should feel comfortable booking flights with those dates in mind.
< bitcoin-git> [bitcoin] fanquake closed pull request #15469: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15469

2019-02-24

< bitcoin-git> [bitcoin] hfsam opened pull request #15469: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/15469
< flowctrl> I tried building from source, but the testsuite fails. Commented on existing (closed) issue @ https://github.com/bitcoin/bitcoin/issues/14349
< luke-jr> flowctrl: this is the development channel; try #bitcoin for support
< flowctrl> Hello! I downloaded a macos binary, bitcoin-0.17.1-osx.dmg, from bitcoin.org. In the image, there is a file that produces a 'permission denied' error message when I try to copy it to any location. The file is: /Volumes/Bitcoin-Core/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt

2019-02-23

< mischa010> in this thread it's claimed that compact blocks does indeed rank peers by their speed? https://www.reddit.com/r/Bitcoin/comments/5zo2ku/how_do_i_configure_my_node_to_use_highbandwidth/
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15468: wallet: Use fsbridge::ifstream to fix Windows path issue (master...win-wallet-fix) https://github.com/bitcoin/bitcoin/pull/15468
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< warren> https://github.com/bitcoin/bitcoin/pull/15277 Hoping people can help with what is hopefully a simple environment difference between Ubuntu and this other distro. dongcarl is really close to a deterministic replacement for gitian's toolchain. It may only be a matter of figuring out this linker issue then writing a wrapper around the entire thing.
< gmaxwell> MarcoFalke: re https://github.com/bitcoin/bitcoin/pull/15451 I assume that we broke some altcoin that has other kinds of invs, and the PR author is trying to suggest a comment change that would have avoided his confusion.

2019-02-22

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/169dced9a42b...f3f9c1de19e6
< bitcoin-git> bitcoin/master 39e20fc Daniel Kraft: Add missing #include.
< bitcoin-git> bitcoin/master f3f9c1d MarcoFalke: Merge #15435: rpc: Add missing #include
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15435: rpc: Add missing #include (master...fix-include) https://github.com/bitcoin/bitcoin/pull/15435
< bitcoin-git> [bitcoin] stevenroose opened pull request #15466: tests: Print remaining jobs in test_runner.py (master...remaining-jobs) https://github.com/bitcoin/bitcoin/pull/15466
< bitcoin-git> [bitcoin] promag opened pull request #15464: gui: Drop unused return values in WalletFrame (master...2019-02-walletframe) https://github.com/bitcoin/bitcoin/pull/15464
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77fcf252f65e...169dced9a42b
< bitcoin-git> bitcoin/master fa9b60c MarcoFalke: Remove unused TransactionError constants
< bitcoin-git> bitcoin/master 169dced MarcoFalke: Merge #15408: Remove unused TransactionError constants
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15408: Remove unused TransactionError constants (master...Mf1902-TransactionErrorConst) https://github.com/bitcoin/bitcoin/pull/15408
< bitcoin-git> [bitcoin] promag opened pull request #15463: rpc: Speedup getaddressesbylabel (master...2019-02-fix-15447) https://github.com/bitcoin/bitcoin/pull/15463
< bitcoin-git> [bitcoin] promag opened pull request #15462: gui: Fix async open wallet call order (master...2019-02-fix-15455) https://github.com/bitcoin/bitcoin/pull/15462
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15458: refactor: Drop redundant wallet reference (master...2019-02-interfaces-wallet) https://github.com/bitcoin/bitcoin/pull/15458
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a094b5433242...77fcf252f65e
< bitcoin-git> bitcoin/master 53b3103 João Barbosa: refactor: Drop redundant wallet reference
< bitcoin-git> bitcoin/master 77fcf25 MarcoFalke: Merge #15458: refactor: Drop redundant wallet reference
< bitcoin-git> [bitcoin] laanwj merged pull request #15273: docs: Slight tweak to the verify-commits script directions (master...tweak_verify_commit_dirs) https://github.com/bitcoin/bitcoin/pull/15273
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a83aedca1889...a094b5433242
< bitcoin-git> bitcoin/master a786c3b Douglas Roark: Slight tweak to the verify-commits script directions
< bitcoin-git> bitcoin/master a094b54 Wladimir J. van der Laan: Merge #15273: docs: Slight tweak to the verify-commits script directions
< bitcoin-git> [bitcoin] Sjors opened pull request #15461: [depends] update to Boost 1.66 (master...2019/02/depends_boost) https://github.com/bitcoin/bitcoin/pull/15461
< bitcoin-git> [bitcoin] Sjors closed pull request #15320: [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis (master...2019/02/do-not-merge-qt52) https://github.com/bitcoin/bitcoin/pull/15320
< gribble> https://github.com/bitcoin/bitcoin/issues/14740 | Update `rpcbind` doc to match the manpage by sp4ke · Pull Request #14740 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl closed pull request #11915: Qt: Reflect correct dbcache value in options panel. (master...dbcache_gui_fix) https://github.com/bitcoin/bitcoin/pull/11915
< dongcarl> gwillen: Here are some more tips (including the above)! https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#reference-prs-easily-with-refspecs

2019-02-21

< dongcarl> I remember hearing about libev used somewhere in bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
< dongcarl> I'm seeking context on libevent in bitcoin
< dongcarl> jonasschnelli: Any thoughts on this: https://github.com/bitcoin/bitcoin/pull/8888#issuecomment-457003118, I might remove #8888 from the board since it's really old (but has a very lucky issue number!)
< gribble> https://github.com/bitcoin/bitcoin/issues/8888 | CConnman: Remove some global usage in the gui by theuni · Pull Request #8888 · bitcoin/bitcoin · GitHub
< luke-jr> gmaxwell: unrelated to the PR itself, shouldn't there be checks that pos isn't beyond the end of input here? https://github.com/bitcoin-core/secp256k1/pull/578/files#diff-894075824bb67186a1d4e4cc3961644eR57
< jnewbery> I have one other announcement: we're closing applications to the residency on Sunday. We've found that some of our best applicants have been referrals, so if you know anyone who you think would be a good Bitcoin contributor, please send them our way! https://residency.chaincode.com
< luke-jr> [12:21:34] <gmaxwell> in particular: https://github.com/bitcoin-core/secp256k1/pull/578
< gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15401 | rpc: Actually throw help when passed invalid number of params by MarcoFalke · Pull Request #15401 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] laanwj merged pull request #13676: Explain that mempool memory is added to -dbcache (master...2018/07/dbcache-ibd-mempool) https://github.com/bitcoin/bitcoin/pull/13676
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b853746d4a8a...a83aedca1889
< bitcoin-git> bitcoin/master 7cb1a14 Sjors Provoost: Explain that unused mempool memory is added to -dbcache
< bitcoin-git> bitcoin/master a83aedc Wladimir J. van der Laan: Merge #13676: Explain that mempool memory is added to -dbcache
< gribble> https://github.com/bitcoin/bitcoin/issues/13676 | Explain that mempool memory is added to -dbcache by Sjors · Pull Request #13676 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15255 | [tests] Remove travis_wait from lint script by gkrizek · Pull Request #15255 · bitcoin/bitcoin · GitHub
< jnewbery> Hi all. dongcarl is doing great work picking up the p2p refactor project (https://github.com/bitcoin/bitcoin/projects/4). I think it makes sense for him to have write access so he can update that board. Due to github permissions, that would also allow give him write access to do things like tag and close issues. It would *not* give him commit permissions.
< bitcoin-git> [bitcoin] marcoagner opened pull request #15459: [doc] release process: how to calculate m_assumed_blockchain_size and m_assumed_chain_state_size (master...doc_blockchain_and_chainstate_size_calculation) https://github.com/bitcoin/bitcoin/pull/15459
< bitcoin-git> [bitcoin] promag opened pull request #15458: refactor: Drop redundant wallet reference (master...2019-02-interfaces-wallet) https://github.com/bitcoin/bitcoin/pull/15458
< bitcoin-git> [bitcoin] Sjors opened pull request #15457: Check std::system for -[alert|block|wallet]notify (master...2019/02/std__system) https://github.com/bitcoin/bitcoin/pull/15457
< gmaxwell> and one final one https://github.com/bitcoin-core/secp256k1/pull/568 (which mostly I want plain C code review-- as it previously had a silly pointer vs int bug, though this one touches more complicated code that might leave people unfamilar with the library feeling lost)
< gmaxwell> also https://github.com/bitcoin-core/secp256k1/pull/584 (cross compiling build system review)
< bitcoin-git> [bitcoin] riordant opened pull request #15456: Enable PID file creation on WIN (master...master) https://github.com/bitcoin/bitcoin/pull/15456
< bitcoin-git> [bitcoin] laanwj merged pull request #15222: docs: Add info about factors that affect dependency list (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15222
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d126f289c7d...b853746d4a8a
< bitcoin-git> bitcoin/master 55e05a8 Martin Erlandsson: Added some factors that affect the dependency list
< bitcoin-git> bitcoin/master b853746 Wladimir J. van der Laan: Merge #15222: docs: Add info about factors that affect dependency list
< gribble> https://github.com/bitcoin/bitcoin/issues/15267 | doc: explain AcceptToMemoryPoolWorkers coins_to_uncache by jamesob · Pull Request #15267 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master 901baf2 fanquake: doc: update FreeBSD build guide for 12.0
< bitcoin-git> bitcoin/master 4d126f2 Wladimir J. van der Laan: Merge #15416: doc: update FreeBSD build guide for 12.0
< bitcoin-git> [bitcoin] laanwj merged pull request #15416: doc: update FreeBSD build guide for 12.0 (master...docs-freebsd-120) https://github.com/bitcoin/bitcoin/pull/15416
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3e1ca1348cbd...4d126f289c7d
< bitcoin-git> [bitcoin] laanwj merged pull request #15278: Improve PID file error handling (master...20190128-pidfile-logging) https://github.com/bitcoin/bitcoin/pull/15278
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f9775a865597...3e1ca1348cbd
< bitcoin-git> bitcoin/master 745a2ac Hennadii Stepanov: Improve PID file removing errors logging
< bitcoin-git> bitcoin/master 561e375 Hennadii Stepanov: Make PID file creating errors fatal
< bitcoin-git> bitcoin/master 3782075 Hennadii Stepanov: Move all PID file stuff to init.cpp
< wumpus> it's cool that we're pretty much on schedule for 0.18 branch-off, two pulls to go for now https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub

2019-02-20

< bitcoin-git> [bitcoin] achow101 opened pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454
< bitcoin-git> [bitcoin] instagibbs opened pull request #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types (master...key_script_dest) https://github.com/bitcoin/bitcoin/pull/15452
< bitcoin-git> [bitcoin] HashUnlimited opened pull request #15451: [doc] clarify getdata limit after #14897 (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15451
< bitcoin-git> [bitcoin] achow101 opened pull request #15450: [GUI] Create wallet menu option (master...gui-create-wallet) https://github.com/bitcoin/bitcoin/pull/15450
< gribble> https://github.com/bitcoin/bitcoin/issues/15443 | qa: Add getdescriptorinfo functional test by promag · Pull Request #15443 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15448: bitcoin-cli: Eliminate "Error parsing JSON" errors (master...pr/unistr) https://github.com/bitcoin/bitcoin/pull/15448
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15439: tests: remove byte.hex() to keep compatibility (master...keep_compatiblity) https://github.com/bitcoin/bitcoin/pull/15439
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38429c4b6228...f9775a865597
< bitcoin-git> bitcoin/master 1a062b8 Akio Nakamura: tests: remove byte.hex() to keep compatibility
< bitcoin-git> bitcoin/master f9775a8 MarcoFalke: Merge #15439: tests: remove byte.hex() to keep compatibility
< gribble> https://github.com/bitcoin/bitcoin/issues/15439 | tests: remove byte.hex() to keep compatibility by AkioNak · Pull Request #15439 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14884 | Travis: enforce Python 3.4 support through linter by Sjors · Pull Request #14884 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< luke-jr> echeveria: a few years ago, someone decided to tip me unknownst to me, and googled "luke-jr bitcoin address", then paid a random address on the bc.i page (which luckily happened to be my *change* address in the transaction that came up)
< gmaxwell> luke-jr: at least by transaction count bitcoin core usage appears to outpace electrum something like 5:1

2019-02-19

< gmaxwell> booyah: and in bitcoin today users generally assume addresses can be reused. It's not a great assumption.
< gmaxwell> luke-jr: you've had years where you could have also written wallet features in bitcoin core to do stuff like pop up a message saying "You're paying to an address you've paid to before. Is this a mistake? Address reuse can be a symptom of a mistaken double payment and can lead to privacy or funds loss". but apparently it wasn't important enough to you to bother.
< gmaxwell> Not according to how bitcoin has always worked.
< booyah> is bitcoin somehow improving strength of normal random as provided by OS specific api?
< gmaxwell> overwhos fault it was. That kind of footgun isn't what you expect from bitcoin engineering, it sounds like something ethereum would do.
< bitcoin-git> [bitcoin] dongcarl opened pull request #15446: Improve depends debuggability (master...2019-02-improve-depends-debuggability) https://github.com/bitcoin/bitcoin/pull/15446
< bitcoin-git> [bitcoin] hebasto opened pull request #15445: [0.17] backport #14409 (0.17...20190219-backport-pr14409) https://github.com/bitcoin/bitcoin/pull/15445
< bitcoin-git> [bitcoin] Sjors opened pull request #15444: [docs] Additional productivity tips (master...2019/02/typo-productivity) https://github.com/bitcoin/bitcoin/pull/15444
< wumpus> well bitcoin_rw.conf overrides bitcoin.conf so...
< luke-jr> if only rwconf were allowed to modify bitcoin.conf directly, we could have a nice key/value config editor.. https://twitter.com/kakabakasa/status/1097764863168909313
< riordant> Hello, I have a question about this commit: https://github.com/bitcoin/bitcoin/commit/d6712db
< bitcoin-git> [bitcoin] laanwj merged pull request #15404: [test] Remove -txindex to start nodes (master...remove_txindex) https://github.com/bitcoin/bitcoin/pull/15404
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3e4fd4075381...38429c4b6228
< bitcoin-git> bitcoin/master 8e4b4f6 Amiti Uttarwar: Address test todos by removing -txindex to nodes.
< bitcoin-git> bitcoin/master 38429c4 Wladimir J. van der Laan: Merge #15404: [test] Remove -txindex to start nodes
< bitcoin-git> [bitcoin] promag opened pull request #15443: qa: Add getdescriptorinfo functional test (master...2019-02-qa-feature-descriptor) https://github.com/bitcoin/bitcoin/pull/15443
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15415: [test] functional: allow custom cwd, use tmpdir as default (master...2019/02/test_cwd) https://github.com/bitcoin/bitcoin/pull/15415
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/904308dca3ff...3e4fd4075381
< bitcoin-git> bitcoin/master e3e1a56 Sjors Provoost: [test] functional: set cwd of nodes to tmpdir
< bitcoin-git> bitcoin/master 3e4fd40 MarcoFalke: Merge #15415: [test] functional: allow custom cwd, use tmpdir as default
< harding> promag: works for me via bitcoin-cli on mainnet using commit 4064d048d6 (master from Sunday). Rebuilding now to try on latest.
< bitcoin-git> [bitcoin] Sjors opened pull request #15441: [doc] build: warn against spaces in working directory (master...2019/02/build_discourage_space) https://github.com/bitcoin/bitcoin/pull/15441
< gmaxwell> I am just imagining a create dialog with a text entry box where you can enter a seed, and then confused users not realizing they can ignore it, googling bitcoin seed and entering in some example they found online.. :P
< bitcoin-git> [bitcoin] AkioNak opened pull request #15439: tests: remove byte.hex() to keep compatibility (master...keep_compatiblity) https://github.com/bitcoin/bitcoin/pull/15439

2019-02-18

< belcher> luke-jr it does, bitcoin core's wallet has the history
< luke-jr> maybe we should take this to #bitcoin
< belcher> its a wrapper around bitcoin core's wallet that speaks the electrum server protocol, so it has no extra indexes and is compatible with pruning etc
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15433: Use a single wallet batch for UpgradeKeyMetadata (master...2019/02/wallet_key_upgrade_batch) https://github.com/bitcoin/bitcoin/pull/15433
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f78cd3dd5115...904308dca3ff
< bitcoin-git> bitcoin/master 0bedcba Jonas Schnelli: Use a single wallet batch for UpgradeKeyMetadata
< bitcoin-git> bitcoin/master 904308d MeshCollider: Merge #15433: Use a single wallet batch for UpgradeKeyMetadata
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15437: p2p: Remove remote debugging code (master...Mf1809-noBip61) https://github.com/bitcoin/bitcoin/pull/15437
< gmaxwell> I don't agree that any reduction of block sizes is "up for discussion" in bitcoin core development. Quite the opposite: You have already been privately censured for creating drama in the press for annoucing some absurd reduction fait accompli when you hadn't even brought the subject up with other developers.
< luke-jr> bitcoinEnthusias: the only thing up for discussion at this time is a reduction in block sizes; take this topic to #bitcoin if you want to continue it
< jarthur> bitcoinEnthusias: on the protocol side, sipa has been organizing a BIP for Schnorr signatures. It hasn't officially been proposed yet, and typically an implementation would follow a proposal. https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr.mediawiki if you want to see the current state. bitcoin-dev mailing list a fine place to discuss the proposal
< gribble> https://github.com/bitcoin/bitcoin/issues/15428 | GUI: Add Pairing tab with Tor onion address as copyable text and QR code by luke-jr · Pull Request #15428 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15348: doc: Add separate productivity notes document (master...2019-02-productivity-md) https://github.com/bitcoin/bitcoin/pull/15348
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6ba3f1fdfd88...f78cd3dd5115
< bitcoin-git> bitcoin/master 5b76c31 Carl Dong: doc: Add separate productivity notes document
< bitcoin-git> bitcoin/master f78cd3d MarcoFalke: Merge #15348: doc: Add separate productivity notes document
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15397: Remove manual byte editing in wallet_tx_clone func test (master...wallet_clone_magic) https://github.com/bitcoin/bitcoin/pull/15397
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29e82e460e19...6ba3f1fdfd88
< bitcoin-git> bitcoin/master 6aaa0ab Gregory Sanders: Remove manual byte editing in wallet_tx_clone func test
< bitcoin-git> bitcoin/master 6ba3f1f MarcoFalke: Merge #15397: Remove manual byte editing in wallet_tx_clone func test
< instagibbs> crised, #bitcoin-dev or #bitcoin for general development questions
< crised> Where can I learn the basics of bitcoin from developer point of view?
< bitcoin-git> [bitcoin] domob1812 opened pull request #15435: Add missing #include (master...fix-include) https://github.com/bitcoin/bitcoin/pull/15435
< bitcoin-git> [bitcoin] laanwj merged pull request #15250: Use RdSeed when available, and reduce RdRand load (master...201901_rdseed) https://github.com/bitcoin/bitcoin/pull/15250
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5a623eb66c8...29e82e460e19
< bitcoin-git> bitcoin/master 1435fab Pieter Wuille: Use RdSeed when available, and reduce RdRand load
< bitcoin-git> bitcoin/master 29e82e4 Wladimir J. van der Laan: Merge #15250: Use RdSeed when available, and reduce RdRand load
< bitcoin-git> [bitcoin] laanwj merged pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) https://github.com/bitcoin/bitcoin/pull/15429
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b72c787dc8f7...f5a623eb66c8
< bitcoin-git> bitcoin/master a083f75 Gregory Maxwell: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378...
< bitcoin-git> bitcoin/master f5a623e Wladimir J. van der Laan: Merge #15429: Update assumevalid, minimumchainwork, and getchaintxstats to...
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< gmaxwell> using bitcoin-cli over ssh is pretty dandy. I assume thats what most people in here do, it's just not super gui-enduser friendly. :)
< gribble> https://github.com/bitcoin/bitcoin/issues/11902 | NAT-PMP port forwarding support · Issue #11902 · bitcoin/bitcoin · GitHub
< gmaxwell> take a step back. I believe the history of this discussion is that luke told someone somewhere don't use wallet X (some untrusted server SPV thing) because its insecure. Then someone said something like "well obviously I'm not going to run bitcoin core on my phone so how should I solve this"?
< gmaxwell> provoostenator: it is because you don't need to know essentially anything about bitcoin.
< echeveria> what I don't want to deal with is the bitcoin project being responsible for a bunch of people running outdated, vulnerable tor software that's doing nothing but harm them. include some scripts for setting this up in contrib/ if people really want it. I certainly do not.
< provoostenator> wumpus: I tend to agree that remote control is a more generic internet problem that can be solved outside of Bitcoin.
< wumpus> remote control over bitcoin P2P? what?
< wumpus> routing your traffic over a relay would make zero sense for the bitcoin protocol as all the data is public
< gribble> https://github.com/bitcoin/bitcoin/issues/12288 | [WIP][NET] Add NATPMP support. by annanay25 · Pull Request #12288 · bitcoin/bitcoin · GitHub
< wumpus> also I've always believed the way forward would be to improve the bitcoin protocol itself; BIP150/151, Dandelion, as well as lightning onion routing
< aj> https://github.com/bitcoin/bitcoin/pull/12288 <-- there was a pr a while ago
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15433: Use a single wallet batch for UpgradeKeyMetadata (master...2019/02/wallet_key_upgrade_batch) https://github.com/bitcoin/bitcoin/pull/15433

2019-02-17

< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4064d048d61c...b72c787dc8f7
< bitcoin-git> bitcoin/master 8a1f0a3 Chun Kuan Lee: scripted-diff: Remove NDEBUG pre-define
< bitcoin-git> bitcoin/master 3ec56be Chun Kuan Lee: appveyor: Remove unused NDEBUG removal
< bitcoin-git> bitcoin/master b72c787 MarcoFalke: Merge #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project fil...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project file (master...msvc-no-ndebug) https://github.com/bitcoin/bitcoin/pull/15431
< wumpus> but tor is illegal in some countries where bitcoin is not so coupling them as the only option is a bad idea
< wumpus> I don't think we should be shipping tor binaries at all, at least not with the default download, I'm fine with a "tor bitcoin core" bundle
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project file (master...msvc-no-ndebug) https://github.com/bitcoin/bitcoin/pull/15431
< bitcoin-git> [bitcoin] practicalswift closed pull request #15215: rpc: Use the return value of GetProxy(...) in GetNetworksInfo(). Mark GetProxy(...) with [[nodiscard]]. (master...getnetworkinfo-getproxy) https://github.com/bitcoin/bitcoin/pull/15215
< gmaxwell> sipa: as requested, https://github.com/bitcoin/bitcoin/pull/15429 you might want to 0.18 tag.
< bitcoin-git> [bitcoin] gmaxwell opened pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) https://github.com/bitcoin/bitcoin/pull/15429
< gmaxwell> luke-jr: no, but if you care about authentication the bitcoin crypto/auth proposals are better for that...
< gmaxwell> like will we have to do emergency releases whenever tor has a vuln? ... will we finally get rid of the openssl induced firedrills in bitcoin only to regain them via tor? etc..
< bitcoin-git> [bitcoin] luke-jr opened pull request #15428: GUI: Add Pairing tab with Tor onion address as copyable text and QR code (master...tor_gui_pairing) https://github.com/bitcoin/bitcoin/pull/15428
< bitcoin-git> [bitcoin] laanwj merged pull request #15425: [Doc] add missing newline to listunspent help for witnessScript (master...2019-02-help-listunspent-missing-newline) https://github.com/bitcoin/bitcoin/pull/15425
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d0337992d81...4064d048d61c
< bitcoin-git> bitcoin/master d3661a3 David A. Harding: [Doc] add missing newline to witnessScript in listunspent help
< bitcoin-git> bitcoin/master 4064d04 Wladimir J. van der Laan: Merge #15425: [Doc] add missing newline to listunspent help for witnessScr...
< bitcoin-git> [bitcoin] laanwj merged pull request #15426: [Doc] importmulti: add missing description of keypool option (master...2019-02-importmulti-keypool) https://github.com/bitcoin/bitcoin/pull/15426
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9c190044df8...2d0337992d81
< bitcoin-git> bitcoin/master a607c9a David A. Harding: [Doc] importmulti: add missing description of keypool option
< bitcoin-git> bitcoin/master 2d03379 Wladimir J. van der Laan: Merge #15426: [Doc] importmulti: add missing description of keypool option...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f60d029a2a76...e9c190044df8
< bitcoin-git> bitcoin/master d067e81 Chun Kuan Lee: msvc: add rapid check property tests
< bitcoin-git> bitcoin/master e9c1900 Wladimir J. van der Laan: Merge #15398: msvc: add rapidcheck property tests
< bitcoin-git> [bitcoin] laanwj merged pull request #15398: msvc: add rapidcheck property tests (master...appveyor-rapid-check) https://github.com/bitcoin/bitcoin/pull/15398
< bitcoin-git> [bitcoin] sipa opened pull request #15427: Add support for descriptors to utxoupdatepsbt (master...201902_utxoupdatepsbtdesc) https://github.com/bitcoin/bitcoin/pull/15427

2019-02-16

< bitcoin-git> [bitcoin] harding opened pull request #15426: [Doc] importmulti: add missing description of keypool option (master...2019-02-importmulti-keypool) https://github.com/bitcoin/bitcoin/pull/15426
< bitcoin-git> [bitcoin] harding opened pull request #15425: [Doc] add missing newline to listunspent help for witnessScript (master...2019-02-help-listunspent-missing-newline) https://github.com/bitcoin/bitcoin/pull/15425
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d5b929c813ff...f60d029a2a76
< bitcoin-git> bitcoin/master 3b40bff Pieter Wuille: Descriptor checksum
< bitcoin-git> bitcoin/master b52cb63 Pieter Wuille: Add getdescriptorinfo to compute checksum
< bitcoin-git> bitcoin/master be62903 Pieter Wuille: Make descriptor checksums mandatory in deriveaddresses and importmulti
< bitcoin-git> [bitcoin] laanwj merged pull request #15368: Descriptor checksums (master...201902_descsum) https://github.com/bitcoin/bitcoin/pull/15368
< bitcoin-git> [bitcoin] Sjors opened pull request #15424: [wallet] wallet-tool: command to remove key metadata (master...2019/02/wallet_tool_remove_metadata) https://github.com/bitcoin/bitcoin/pull/15424
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/f9d50e83e290...d5b929c813ff
< bitcoin-git> bitcoin/master 7344a7b Andrew Chow: Implement utxoupdatepsbt RPC and tests
< bitcoin-git> bitcoin/master 08f749c Andrew Chow: Implement joinpsbts RPC and tests
< bitcoin-git> bitcoin/master cb40b3a Andrew Chow: Figure out what is missing during signing
< bitcoin-git> [bitcoin] laanwj merged pull request #13932: Additional utility RPCs for PSBT (master...psbt-util-rpcs) https://github.com/bitcoin/bitcoin/pull/13932
< achow101> harding: i do. I think it's because bitcoin has a lot of objects which the garbage collector cleans up every so often.
< harding> achow101: do you use worktrees with any other projects? I do, and I just checked a few and didn't find any of them broken (even ones on the same qube as my bitcoin repository). I don't know what would distinguish bitcoin from other repositories I use; the only thing I can think of is that it's the largest (size and object count) that I use with worktrees.
< harding> achow101: my git worktrees for the bitcoin repository also broke inexplicably two days ago in between my uses of them. I thought maybe something on my system broke them (I use Qubes 4 + Debian 9), e.g. some symlink was lost, but now I'm wondering if it was something else.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15410: test: txindex: interrupt threadGroup before calling destructor (master...Mf1902-testIndexInterr) https://github.com/bitcoin/bitcoin/pull/15410
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/743c2f461c0e...f9d50e83e290
< bitcoin-git> bitcoin/master fab6b07 MarcoFalke: test: txindex: interrupt threadGroup before calling destructor
< bitcoin-git> bitcoin/master f9d50e8 MarcoFalke: Merge #15410: test: txindex: interrupt threadGroup before calling destruct...
< bitcoin-git> [bitcoin] luke-jr opened pull request #15423: torcontrol: Query Tor for correct -onion configuration (master...tor_socks_port) https://github.com/bitcoin/bitcoin/pull/15423
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr reopened pull request #11803: Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet (master...bugfix_dumpwallet_hdkeypath) https://github.com/bitcoin/bitcoin/pull/11803
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< warren> midnightmagic: https://github.com/bitcoin/bitcoin/pull/15277 it needs more work
< gribble> https://github.com/bitcoin/bitcoin/issues/11803 | Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet by luke-jr · Pull Request #11803 · bitcoin/bitcoin · GitHub

2019-02-15

< bitcoin-git> [bitcoin] luke-jr opened pull request #15421: torcontrol: Launch a private Tor instance when not already running (master...tor_subprocess) https://github.com/bitcoin/bitcoin/pull/15421
< meshcollider> provoostenator: re https://github.com/bitcoin/bitcoin/pull/11803#issuecomment-464082302 I'm not sure the same thing Luke was changing has been done?
< bitcoin-git> [bitcoin] luke-jr closed pull request #11803: Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet (master...bugfix_dumpwallet_hdkeypath) https://github.com/bitcoin/bitcoin/pull/11803
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15399: fuzz: Script validation flags (master...Mf1902-fuzzSoft) https://github.com/bitcoin/bitcoin/pull/15399
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/95801902b987...743c2f461c0e
< bitcoin-git> bitcoin/master fabcfa5 MarcoFalke: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp