2020-09-19

< kallewoof> tryphe_: i'm all for making it more known, but not sure where to do so. perhaps add an entry about it to the bitcoin wiki might be a good idea
< bitcoin-git> [bitcoin] fanquake merged pull request #19971: test: create default wallet in extended tests (master...2020/09/fix_no_default_wallet_extended_tests) https://github.com/bitcoin/bitcoin/pull/19971
< bitcoin-git> bitcoin/master 967be53 fanquake: Merge #19971: test: create default wallet in extended tests
< bitcoin-git> bitcoin/master a5f5374 Sjors Provoost: test: create default wallet in extended tests
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/652c45fdbbd5...967be53aeec9
< tryphe_> also slightly related, when users look to enable features, they do ./bitcoind -help, ./bitcoin-cli -help, but not necessarily ./bitcoin-cli help, so they might not even stumble on setwalletflag. but not sure how to effectively get people to do this :(
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub

2020-09-18

< bitcoin-git> [bitcoin] practicalswift opened pull request #19972: tests: Add fuzzing harness for node eviction logic (master...fuzzers-eviction-logic) https://github.com/bitcoin/bitcoin/pull/19972
< bitcoin-git> [bitcoin] Sjors opened pull request #19971: test: create default wallet in extended tests (master...2020/09/fix_no_default_wallet_extended_tests) https://github.com/bitcoin/bitcoin/pull/19971
< gribble> https://github.com/bitcoin/bitcoin/issues/15454 | Remove the automatic creation and loading of the default wallet by achow101 · Pull Request #15454 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15454 | Remove the automatic creation and loading of the default wallet by achow101 · Pull Request #15454 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19970 | sync.h: fix LockAssertion error reporting by ajtowns · Pull Request #19970 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ajtowns opened pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970
< kallewoof> I switched to squeezecase and pushed change, FWIW. (Re-)review would be glorious. https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> [bitcoin] meshcollider merged pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454
< bitcoin-git> bitcoin/master 652c45f Samuel Dobson: Merge #15454: Remove the automatic creation and loading of the default wal...
< bitcoin-git> bitcoin/master d26f064 Andrew Chow: Tell users how to load or create a wallet when no wallet is loaded
< bitcoin-git> bitcoin/master 1bee1e6 Andrew Chow: Do not create default wallet
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/be3af4f31089...652c45fdbbd5

2020-09-17

< jonatack> vasild: Ok now have the node advertising both torv2 and torv3 local addresses...just needed to set proxy=127.0.0.1:9050 rather than letting bitcoin core create a tor HS automatically, as you mentioned
< vasild> 19954 is only about when bitcoin core creates a tor hidden service automatically via the tor control connection -- it would start creating torv3 with that PR
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: make a TORv3 hidden service instead of TORv2 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< sipa> "Bitcoin Core developer claims enabling debugging introduces bug"
< ryanofsky> For AssertLockHeld PRs, I just wanted to advertise wiki page https://github.com/bitcoin-core/bitcoin-devwiki/wiki/AssertLockHeld-PRs
< jnewbery> is https://github.com/bitcoin-core/qa-assets used for test assets?
< gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
< sipa> as it turned out that there is some risk it is encumbered by a patent, the GLV optimization was made optional, and defaults to off (and has been off in every bitcoin core release)
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
< wumpus> PSA: the release schedule deadlines for 0.21 start october 1: https://github.com/bitcoin/bitcoin/issues/18947
< gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 12 blockers, 1 bugfix, 2 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< bitcoin-git> [bitcoin] Sjors opened pull request #19969: Send RPC touch-ups (master...2020/09/send_touchups) https://github.com/bitcoin/bitcoin/pull/19969
< gleb> But node B running Bitcoin Core currently doesn't employ this ability, because it doesn't know it's permitted.
< bitcoin-git> [bitcoin] robot-dreams reopened pull request #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods (master...connect-nodes) https://github.com/bitcoin/bitcoin/pull/19967
< bitcoin-git> [bitcoin] robot-dreams closed pull request #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods (master...connect-nodes) https://github.com/bitcoin/bitcoin/pull/19967
< bitcoin-git> [bitcoin] robot-dreams opened pull request #19968: doc: make it easier to work out size of bloom filter (master...bloom-doc) https://github.com/bitcoin/bitcoin/pull/19968
< bitcoin-git> [bitcoin] robot-dreams opened pull request #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods (master...connect-nodes) https://github.com/bitcoin/bitcoin/pull/19967
< bitcoin-git> [bitcoin] ajtowns closed pull request #15502: p2p: Speed up initial connection to p2p network (master...201902-trytoavoiddns) https://github.com/bitcoin/bitcoin/pull/15502
< bitcoin-git> [bitcoin] fanquake closed pull request #19965: Fix GitHub format (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19965
< bitcoin-git> [bitcoin] eltociear opened pull request #19965: Fix GitHub format (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19965

2020-09-16

< Kiminuo> fanquake, Hi, would you possibly know how to do that? (see above: "Hi, I have opened https://github.com/bitcoin/bitcoin/pull/19245 PR (C++17 filesystem API) [...]")
< gribble> https://github.com/bitcoin/bitcoin/issues/19940 | rpc: Return fee and vsize from testmempoolaccept by gzhao408 · Pull Request #19940 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #19934: tests: Add fuzzing harness for Keccak and SHA3_256 (master...fuzzers-keccak-and-sha3_256) https://github.com/bitcoin/bitcoin/pull/19934
< bitcoin-git> bitcoin/master be3af4f Wladimir J. van der Laan: Merge #19934: tests: Add fuzzing harness for Keccak and SHA3_256
< bitcoin-git> bitcoin/master fc7f84a practicalswift: tests: Add fuzzing harness for Keccak and SHA3_256
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a518b1c26b71...be3af4f31089
< bitcoin-git> [bitcoin] laanwj merged pull request #19936: Test: batch rpc with params (master...batch_param) https://github.com/bitcoin/bitcoin/pull/19936
< bitcoin-git> bitcoin/master a518b1c Wladimir J. van der Laan: Merge #19936: Test: batch rpc with params
< bitcoin-git> bitcoin/master e1fdd29 Gregory Sanders: Test batch rpc with params
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1c4f59728c35...a518b1c26b71
< bitcoin-git> [bitcoin] t-bast opened pull request #19963: Clarify blocksonly whitelistforcerelay test (master...clarify-whitelist-force-relay-test) https://github.com/bitcoin/bitcoin/pull/19963
< bitcoin-git> bitcoin/0.19 76ec335 Wladimir J. van der Laan: qt: Translations update pre-rc1
< bitcoin-git> bitcoin/0.19 9fdaaec Wladimir J. van der Laan: Don't rename main thread at process level
< bitcoin-git> bitcoin/0.19 57eb126 Wladimir J. van der Laan: build: Bump version to 0.19.0
< bitcoin-git> [bitcoin] fanquake pushed 112 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/57eb126416ff^...aee9d2306ad1
< bitcoin-git> [bitcoin] fanquake deleted 0 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/aee9d2306ad1...000000000000
< bitcoin-git> [bitcoin] fanquake closed pull request #19962: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/19962
< bitcoin-git> [bitcoin] tnawanna opened pull request #19962: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/19962
< gribble> https://github.com/bitcoin/bitcoin/issues/9275 | ZapWalletTxes should backup the wallet · Issue #9275 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17985 | net: Remove forcerelay of rejected txs by MarcoFalke · Pull Request #17985 · bitcoin/bitcoin · GitHub
< vasild> provoostenator: the current one for review is at https://github.com/bitcoin/bitcoin/pull/19845
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: make a TORv3 hidden service instead of TORv2 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< Kiminuo> Command to reproduce the "./fs.h:14:10: fatal error: filesystem: No such file or directory" error is: `~/work/bitcoin$ ./autogen.sh && ./configure --enable-zmq --with-gui=qt5 --enable-glibc-back-compat --enable-reduce-exports --enable-c++17 --enable-debug CFLAGS="-g0 -O2 -funsigned-char" CXXFLAGS="-g0 -O2 -funsigned-char" --with-boost-process && make`
< Kiminuo> Hi, I have opened https://github.com/bitcoin/bitcoin/pull/19245 PR (C++17 filesystem API) that fails with https://travis-ci.org/github/bitcoin/bitcoin/jobs/723555598#L3210. I can reproduce the error on Ubuntu 18.04 virtual machine. There is a hint here https://www.bfilipek.com/2019/05/boost-to-stdfs.html that `-lstdc++fs` may help to resolve the issue. Would anyone be kind enough to help me locate proper place to pass that to verify whether it has
< bitcoin-git> [bitcoin] jnewbery closed pull request #17479: Return BlockValidationState from ProcessNewBlock if CheckBlock/AcceptBlock fails (master...2019-11-processnewblock-early-return) https://github.com/bitcoin/bitcoin/pull/17479
< bitcoin-git> [bitcoin] jonatack opened pull request #19961: doc: tor.md updates (master...update-tor-md) https://github.com/bitcoin/bitcoin/pull/19961
< gribble> https://github.com/bitcoin/bitcoin/issues/19598 | CVE-2012-2459, possible code and performance improvement · Issue #19598 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18884 | Tor v3 support · Issue #18884 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub

2020-09-15

< bitcoin-git> bitcoin/master 125c038 Amiti Uttarwar: [p2p] Remove dead code
< bitcoin-git> [bitcoin] fanquake merged pull request #19879: [p2p] miscellaneous wtxid followups (master...2020-08-wtxid-unbroadcast-followups) https://github.com/bitcoin/bitcoin/pull/19879
< bitcoin-git> bitcoin/master fc66d0a Adam Jonas: [p2p] Check for nullptr before dereferencing pointer
< bitcoin-git> bitcoin/master cb79b9d Amiti Uttarwar: [mempool] Revert unbroadcast set to tracking just txid
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/62e3eb988893...1c4f59728c35
< bitcoin-git> [bitcoin] fanquake reopened pull request #13533: [tests] Reduced number of validations in tx_validationcache_tests (master...reduce-txvalidationcache_tests-runtime) https://github.com/bitcoin/bitcoin/pull/13533
< bitcoin-git> [bitcoin] sipsorcery opened pull request #19960: WIP: The vcpkg tool has introduced a proper way to use manifests (master...vcpkg_manifest) https://github.com/bitcoin/bitcoin/pull/19960
< bitcoin-git> [bitcoin] mzumsande closed pull request #19794: p2p: Remove fGetAddr flag (master...202008_rm_fgetaddr) https://github.com/bitcoin/bitcoin/pull/19794
< bitcoin-git> [bitcoin] jnewbery closed pull request #19093: RPC: Return transaction fee from testmempoolaccept (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
< gribble> https://github.com/bitcoin/bitcoin/issues/19871 | doc: Clarify scope of eviction protection of outbound block-relay peers by ariard · Pull Request #19871 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #19959: build: patch qt libpng to fix powerpc build (master...powerpc_libpng_qt) https://github.com/bitcoin/bitcoin/pull/19959
< kallewoof> There's a nice number of tACKS/ACKs on the Signet PR, FWIW: https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> [bitcoin] laanwj merged pull request #19241: help: Generate checkpoint height from chainparams (master...help_checkpoint_num) https://github.com/bitcoin/bitcoin/pull/19241
< bitcoin-git> bitcoin/master 62e3eb9 Wladimir J. van der Laan: Merge #19241: help: Generate checkpoint height from chainparams
< bitcoin-git> bitcoin/master 916d359 Luke Dashjr: help: Generate checkpoint height from chainparams
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48a9968e5085...62e3eb988893
< wumpus> it's always a last step, copy and upload release notes everywhere, oh-- bitcoin.org travis fails on them with some terse error message
< bitcoin-git> [bitcoin] laanwj merged pull request #19558: build: split pthread flags out of ldflags and dont use when building libconsensus (master...split_out_pthread_flags) https://github.com/bitcoin/bitcoin/pull/19558
< bitcoin-git> bitcoin/master 15c27c4 fanquake: build: split PTHREAD_* flags out of AM_LDFLAGS
< bitcoin-git> bitcoin/master 68e3e22 fanquake: scripted-diff: add FUZZ_SUITE_LDFLAGS_COMMON
< bitcoin-git> bitcoin/master afecde8 fanquake: build: add PTHREAD_LIBS to LDFLAGS configure output
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a33651866c86...48a9968e5085
< gribble> https://github.com/bitcoin/bitcoin/issues/19558 | build: split pthread flags out of ldflags and dont use when building libconsensus by fanquake · Pull Request #19558 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #18897: qt: Handle exceptions instead of crash (master...200506-slot-ex) https://github.com/bitcoin/bitcoin/pull/18897
< bitcoin-git> [bitcoin] fanquake closed pull request #18728: GUI: Enable changing the autoprune block space size in intro dialog (master...intro_prune_size) https://github.com/bitcoin/bitcoin/pull/18728
< gribble> https://github.com/bitcoin/bitcoin/issues/2272676 | HTTP Error 404: Not Found
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19906: Bugfix: don't make collision from "tried" a feeler (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906
< bitcoin-git> [bitcoin] naumenkogs opened pull request #19958: Rename feelers to probes (master...2020-09-rename-feeler-to-probe) https://github.com/bitcoin/bitcoin/pull/19958
< bitcoin-git> [bitcoin] fanquake merged pull request #19643: Add -netinfo peer connections dashboard (master...netinfo) https://github.com/bitcoin/bitcoin/pull/19643
< bitcoin-git> bitcoin/master a3653c1 Jon Atack: cli: tally peer connections by type
< bitcoin-git> bitcoin/master 54799b6 Jon Atack: cli: add ipv6 and onion address type detection helpers
< bitcoin-git> bitcoin/master 12242b1 Jon Atack: cli: create initial -netinfo option, NetinfoRequestHandler class
< bitcoin-git> [bitcoin] fanquake pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/5d5e335f9697...a33651866c86
< bitcoin-git> [bitcoin] hebasto closed pull request #19783: build, doc: Make explicit dependency of system zlib for building depends (master...200823-zlib) https://github.com/bitcoin/bitcoin/pull/19783
< bitcoin-git> [bitcoin] fanquake closed pull request #13533: [tests] Reduced number of validations in tx_validationcache_tests (master...reduce-txvalidationcache_tests-runtime) https://github.com/bitcoin/bitcoin/pull/13533
< bitcoin-git> [bitcoin] fanquake closed pull request #14425: Net: Do not re-enable Onion network when it was disabled via onlynet (master...do-not-reenable-Tor-when-disabled-via-onlynet) https://github.com/bitcoin/bitcoin/pull/14425
< bitcoin-git> [bitcoin] fanquake closed pull request #19130: doc: make it easier to work out size of bloom filter (master...202005-bloom-doc) https://github.com/bitcoin/bitcoin/pull/19130
< bitcoin-git> [bitcoin] kallewoof opened pull request #19957: rpc: alias helper (master...202009-rpc-alias) https://github.com/bitcoin/bitcoin/pull/19957
< bitcoin-git> [bitcoin] fanquake merged pull request #19903: Update build-openbsd.md with GUI support (master...update-openbsd-build-instructions) https://github.com/bitcoin/bitcoin/pull/19903
< bitcoin-git> bitcoin/master 5d5e335 fanquake: Merge #19903: Update build-openbsd.md with GUI support
< bitcoin-git> bitcoin/master d110200 grubles: Add OpenBSD instructions for building the Qt GUI
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ffaac6e6142a...5d5e335f9697
< bitcoin-git> [bitcoin] meshcollider merged pull request #16378: The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378
< bitcoin-git> bitcoin/master 92326d8 Sjors Provoost: [rpc] add send method
< bitcoin-git> bitcoin/master 2c2a144 Sjors Provoost: [rpc] add snake case aliases for transaction methods
< bitcoin-git> bitcoin/master 1bc8d0f Sjors Provoost: [rpc] walletcreatefundedpsbt: allow inputs to be null
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/06dbbe76dd02...ffaac6e6142a

2020-09-14

< yanmaani> One approach to that would be to make all Bitcoin nodes connect to the BitTorrent DHT, then randomly enter the BitTorrent DHT by brute-forcing IPv4 IPs (<200 UDP packets on average), and then broadcast to them. Or you could have Bitcoin receive transactions on UDP, and just send them to 0.0.0.0/0:8333.
< sipa> emzy: if you use bitcoin core with -proxy, dns seeds are not used directly; instead, a connection is made to the NS name of the DNS seeds (which in case of tor causes the exit node to resolve it, pick a random result, and forward the connection there), and a getaddr is requested, and the connection is closed after getting a response
< sipa> emzy: on the other hand, when you're using bitcoin behind tor, you probably don't want to use dnsseeds in the first place, but addr_fetch nodes, which don't have that problem
< bitcoin-git> [bitcoin] n1rna opened pull request #19956: rpc: Improve invalid vout value rpc error message (master...rpc-invalid-vout-message) https://github.com/bitcoin/bitcoin/pull/19956
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< sdaftuar> sipa: i guess this version of #15141 was never merged (though it would have been fun): https://github.com/sdaftuar/bitcoin/commits/15141.9
< sipa> sdaftuar: i don't see any actual commits in the bitcoin/bitcoin history though
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< jb55> I created a mountpoint /zbig/bitcoin on top of my /zbig hdd so that I could snapshot specifically that directory and none others. I think this is where I f'd up somehow
< sipa> wumpus: it seems 0.20.1 is not bitcoin.org yet? https://github.com/bitcoin-dot-org/Bitcoin.org/pull/3435
< bitcoin-git> [bitcoin] vasild opened pull request #19954: tor: make a TORv3 hidden service instead of TORv2 (master...torv3) https://github.com/bitcoin/bitcoin/pull/19954
< bitcoin-git> [bitcoin] fanquake merged pull request #19931: Change CSipHasher's count variable to uint8_t (master...202009_siphash_sillyness) https://github.com/bitcoin/bitcoin/pull/19931
< bitcoin-git> bitcoin/master 06dbbe7 fanquake: Merge #19931: Change CSipHasher's count variable to uint8_t
< bitcoin-git> bitcoin/master 812037c Pieter Wuille: Change CSipHasher's count variable to uint8_t
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ba4b3fbcf213...06dbbe76dd02
< bitcoin-git> [bitcoin] vasild closed pull request #19929: sync: use proper TSA attributes (master...use_proper_tsa_attributes) https://github.com/bitcoin/bitcoin/pull/19929
< bitcoin-git> [bitcoin] sipa opened pull request #19953: Implement BIP 340-342 validation (Schnorr/taproot/tapscript) (master...taproot) https://github.com/bitcoin/bitcoin/pull/19953
< bitcoin-git> [bitcoin] sipa closed pull request #17977: Implement BIP 340-342 validation (Schnorr/taproot/tapscript) (master...taproot) https://github.com/bitcoin/bitcoin/pull/17977
< bitcoin-git> bitcoin/master ba4b3fb fanquake: Merge #19944: Update secp256k1 subtree (including BIP340 support)
< bitcoin-git> [bitcoin] fanquake merged pull request #19944: Update secp256k1 subtree (including BIP340 support) (master...202009_secp256k1_schnorr) https://github.com/bitcoin/bitcoin/pull/19944
< bitcoin-git> bitcoin/master 894fb33 Pieter Wuille: Update src/secp256k1 subtree to upstream libsecp256k1
< bitcoin-git> bitcoin/master b9c1a76 Pieter Wuille: Squashed 'src/secp256k1/' changes from 2ed54da18a..8ab24e8dad
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/be375b2206fe...ba4b3fbcf213

2020-09-13

< jonatack> All the CI jobs pass (bitcoin builds, cirrus, appveyor, travis) except those two travis jobs.
< kallewoof> Signet: 3 tACKs, 1 ACK, probably ready for merge, but if you think not, please do review. https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> [bitcoin] hebasto opened pull request #19952: build, ci: Add file-based logging for individual packages (master...200913-log) https://github.com/bitcoin/bitcoin/pull/19952
< bitcoin-git> [bitcoin] jonatack opened pull request #19951: net, test: CNetAddr scoped ipv6 test coverage, rename scopeId to m_scope_id (master...CNetAddr-scoped-ipv6-unit-tests-docs-and-rename-scopeId-to-m_scope_id) https://github.com/bitcoin/bitcoin/pull/19951
< phantomcircuit> Bullit, Using wallet \\l4p-mcc-dss\mv2 gate\Bitcoin\Bitcoinwallet20200216.dat
< sipa> for the rest, this is not a support channel; try #bitcoin or https://bitcoin.stackexchange.com
< sipa> i don't understand what you're saying, but in any case: it looks like your Bitcoin Core instance aborted unexpectedly, most likely due to a hardware issue or OOM
< Bullit> I was heavily opressed in free use of digital bitcoin currency by portugese british and german the response from law maker rotterdam was have valid signatures I can prove a chain to Bitonic with 47000 conformations as above hexdecimal
< Bullit> Unexpected Shutdown of Bitcoin QT during when Linkedin Photo Upload about broken car AI Detection
< bitcoin-git> [bitcoin] meshcollider merged pull request #19919: bugfix: make LoadWallet assigns status always (master...set_databasestatus) https://github.com/bitcoin/bitcoin/pull/19919
< bitcoin-git> bitcoin/master be375b2 Samuel Dobson: Merge #19919: bugfix: make LoadWallet assigns status always
< bitcoin-git> bitcoin/master 8b39a87 Akio Nakamura: bugfix: make LoadWallet assigns status always
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2d9934381bf...be375b2206fe

2020-09-12

< bitcoin-git> [bitcoin] fjahr opened pull request #19949: cli: Parse and allow hash value (master...jsonerr) https://github.com/bitcoin/bitcoin/pull/19949
< gribble> https://github.com/bitcoin/bitcoin/issues/19488 | Refactor mempool.dat to be extensible, and store missing info by luke-jr · Pull Request #19488 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr closed pull request #17940: doc: Rebasing, when and when not to do it (master...devnotes_rebasing) https://github.com/bitcoin/bitcoin/pull/17940
< bitcoin-git> [bitcoin] guggero opened pull request #19947: Test: Cover "change_type" option of "walletcreatefundedpsbt" RPC (master...psbt-test) https://github.com/bitcoin/bitcoin/pull/19947
< bitcoin-git> [bitcoin] jonatack closed pull request #19946: net: remove unused CNetAddr scopeId member (master...remove-unused-CNetAddr-scopeId) https://github.com/bitcoin/bitcoin/pull/19946
< kallewoof> Please review Signet PR, currently at 2 tested ACKs and one ACK: https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> [bitcoin] jonatack opened pull request #19946: net: remove unused CNetAddr scopeId member (master...remove-unused-CNetAddr-scopeId) https://github.com/bitcoin/bitcoin/pull/19946

2020-09-11

< wumpus> phantomcircuit: that's not relevant here, we don't do DNS lookups for bitcoin nodes, and in any case, how a DNS returns is separate from how they're gossiped (which is all that BIP155 is about)
< bitcoin-git> [bitcoin] prayank23 opened pull request #19945: Remove connect_nodes global and Replace connect_nodes(self.nodes[a], b) with self.connect_nodes(a, b) (master...master) https://github.com/bitcoin/bitcoin/pull/19945
< bitcoin-git> [bitcoin] sipa opened pull request #19944: Update secp256k1 subtree (including BIP340 support) (master...202009_secp256k1_schnorr) https://github.com/bitcoin/bitcoin/pull/19944
< gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] prayank23 closed pull request #19939: Remove connect_nodes global and replace connect_nodes(self.nodes[a], b) with self.connect_nodes(a, b) (master...master) https://github.com/bitcoin/bitcoin/pull/19939
< gribble> https://github.com/bitcoin/bitcoin/issues/9381 | Remove CWalletTx merging logic from AddToWallet by ryanofsky · Pull Request #9381 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto closed pull request #19891: depends: Fix `make --just-print` command (master...200906-dry) https://github.com/bitcoin/bitcoin/pull/19891
< jonatack> pinheadmz: some trivia, per harding, 11413 was the second longest-open PR in bitcoin core history
< pinheadmz> https://github.com/bitcoin/bitcoin/pull/11413 merged into master but doesn't seem to be included in latest release v0.20.1?
< TallTim> There's enough shillers out there without the bitcoin wallet going all-in on crapconis.
< yanmaani> If multiprocess gets merged, would it make sense to have bitcoin-gui deal with all (closely related) altcoins too?
< bitcoin-git> [bitcoin] laanwj merged pull request #19922: test: Run rpc_txoutproof.py even with wallet disabled (master...2009-testMoreMiniWallet) https://github.com/bitcoin/bitcoin/pull/19922
< bitcoin-git> bitcoin/master fa56e86 MarcoFalke: test: Run rpc_txoutproof.py even with wallet disabled
< bitcoin-git> bitcoin/master faba790 MarcoFalke: test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_...
< bitcoin-git> bitcoin/master fa65a11 MarcoFalke: test: bugfix: Actually pick largest utxo
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/9366a73d6951...f2d9934381bf
< bitcoin-git> [bitcoin] gzhao408 opened pull request #19940: rpc: Return fee and vsize from testmempoolaccept (master...rpc-testmempoolaccept-fee) https://github.com/bitcoin/bitcoin/pull/19940
< bitcoin-git> [bitcoin] prayank23 opened pull request #19939: Remove connect_nodes global and replace connect_nodes(self.nodes[a], b) with self.connect_nodes(a, b) (master...master) https://github.com/bitcoin/bitcoin/pull/19939
< bitcoin-git> [bitcoin] hebasto closed pull request #19193: qt: Deduplicate NumConnections enum (master...200606-numconn) https://github.com/bitcoin/bitcoin/pull/19193
< jonasschnelli> it looks like StartWallets (bitcoin-qt`StartWallets(scheduler=0x00007fc10b28df90, args=0x000000010fda5780) at load.cpp:96:18 [opt]) does delay the opening of the main window in the GUI
< gribble> https://github.com/bitcoin/bitcoin/issues/18605 | build: Link time garbage collection by fanquake · Pull Request #18605 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #19916: build: allow user to specify DIR_FUZZ_SEED_CORPUS for cov_fuzz (master...cov_fuzz_cleanup_0908) https://github.com/bitcoin/bitcoin/pull/19916
< bitcoin-git> bitcoin/master 9366a73 fanquake: Merge #19916: build: allow user to specify DIR_FUZZ_SEED_CORPUS for cov_fu...
< bitcoin-git> bitcoin/master fb3bacc eugene: .gitignore: ignore qa-assets/ folder
< bitcoin-git> bitcoin/master a9f2014 eugene: build: use DIR_FUZZ_SEED_CORPUS if specified for cov_fuzz target
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dffefda21de0...9366a73d6951
< bitcoin-git> [bitcoin] fanquake merged pull request #19870: doc: update PyZMQ install instructions, fix zmq_sub.py file permissions (master...zmq-doc-fix) https://github.com/bitcoin/bitcoin/pull/19870
< bitcoin-git> bitcoin/master dffefda fanquake: Merge #19870: doc: update PyZMQ install instructions, fix zmq_sub.py file ...
< bitcoin-git> bitcoin/master 062e669 Jon Atack: script: fix zmq_sub.py file permissions
< bitcoin-git> bitcoin/master 36f8e0c Jon Atack: doc: update PyZMQ installation instructions, ZeroMQ link
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a47e5964861d...dffefda21de0

2020-09-10

< bitcoin-git> [bitcoin] ajtowns opened pull request #19937: signet mining utility (master...202009-signet-generate) https://github.com/bitcoin/bitcoin/pull/19937
< gribble> https://github.com/bitcoin/bitcoin/issues/0 | HTTP Error 404: Not Found
< jonasschnelli> for the ones interested in the mempool size/fee chart: https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2020/03/mempool_graph?expand=1
< jnewbery> and then I guess there's a bot or something that is syncing bitcoin-core/gui to the latest master
< jnewbery> jonasschnelli: I think it's even easier than I said. Marco just merges the gui PR branch into the bitcoin/bitcoin repo
< gribble> https://github.com/bitcoin/bitcoin/issues/19461 | multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky · Pull Request #19461 · bitcoin/bitcoin · GitHub
< jnewbery> they seem to be pretty synchronized. The GUI repository is just one merge commit behind bitcoin/bitcoin
< wumpus> #topic Review the experience of 3 month bitcoin-core/gui repository (jonasschnelli)
< jnewbery> vasild: eg all of this would need to become a single call to the mempool: https://github.com/bitcoin/bitcoin/blob/564e1ab0f3dc573bd3ea60a80f6649c361243df9/src/rpc/blockchain.cpp#L1406-L1421
< bitcoin-git> [bitcoin] instagibbs opened pull request #19936: Test: batch rpc with params (master...batch_param) https://github.com/bitcoin/bitcoin/pull/19936
< gribble> https://github.com/bitcoin/bitcoin/issues/19303 | Replace all of the RecursiveMutex instances with the Mutex ones · Issue #19303 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 1 bugfix, 2 chasins concept ACK
< wumpus> strategies for removing recursive locking in the mempool (jnewbery), review the experience of 3 month bitcoin-core/gui repository (jonasschnelli)
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
< dongcarl> Anyone know what the `UnloadBlockIndex` call here does in the context of initialization? https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L1562
< bitcoin-git> [bitcoin] achow101 opened pull request #19935: Move SaltedHashers to separate file and add some new ones (master...mv-saltedhash) https://github.com/bitcoin/bitcoin/pull/19935
< bitcoin-git> [bitcoin] practicalswift opened pull request #19934: tests: Add fuzzing harness for Keccak and SHA3_256 (master...fuzzers-keccak-and-sha3_256) https://github.com/bitcoin/bitcoin/pull/19934
< bitcoin-git> [bitcoin] laanwj merged pull request #19841: Implement Keccak and SHA3_256 (master...202008_sha3) https://github.com/bitcoin/bitcoin/pull/19841
< bitcoin-git> bitcoin/master ab654c7 Pieter Wuille: Unroll Keccak-f implementation
< bitcoin-git> bitcoin/master 3f01ddb Pieter Wuille: Add SHA3 benchmark
< bitcoin-git> bitcoin/master 2ac8bf9 Pieter Wuille: Implement keccak-f[1600] and SHA3-256
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/564e1ab0f3dc...a47e5964861d
< bitcoin-git> [bitcoin] Saibato opened pull request #19933: wallet: bugfix; if datadir has a trailing '/' listwalletdir would strip lead char of walletname (master...wallet-fix-missing-chars-boost-1.47) https://github.com/bitcoin/bitcoin/pull/19933
< jonasschnelli> #proposedmeetingtopic review the experience of 3 month bitcoin-core/gui repository
< bitcoin-git> [bitcoin] hebasto closed pull request #19926: gui: Add Tor icon (master...200909-tor) https://github.com/bitcoin/bitcoin/pull/19926
< bitcoin-git> [bitcoin] sipa opened pull request #19931: Change CSipHasher's count variable to uint8_t (master...202009_siphash_sillyness) https://github.com/bitcoin/bitcoin/pull/19931
< gribble> https://github.com/bitcoin/bitcoin/issues/16910 | wallet: reduce loading time by using unordered maps by achow101 · Pull Request #16910 · bitcoin/bitcoin · GitHub
< phantomcircuit> sipa, yeah so this guy has no hope https://github.com/bitcoin/bitcoin/issues/19921
< kallewoof> Signet review beg -- no more changes planned, probably RFM: https://github.com/bitcoin/bitcoin/pull/18267

2020-09-09

< jb55> is there something in 0.20.0 -> 0.20.1 that would cause it to redownload the blockchain? trying to figure out why it's doing that after I upgraded my kernel+bitcoin. no configs changed ...
< gribble> https://github.com/bitcoin/bitcoin/issues/16801 | faster & less memory for sync: bulk pool allocator for node based containers by martinus · Pull Request #16801 · bitcoin/bitcoin · GitHub
< sipa> this was tried before though: https://github.com/bitcoin/bitcoin/pull/16801
< gribble> https://github.com/bitcoin/bitcoin/issues/19873 | [WIP] Flush dbcache early if system is under memory pressure by luke-jr · Pull Request #19873 · bitcoin/bitcoin · GitHub
< aj> andytoshi: (maybe rusty's bitcoin-iterate is faster?)
< gribble> https://github.com/bitcoin/bitcoin/issues/19521 | Coinstats Index (without UTXO set hash) by fjahr · Pull Request #19521 · bitcoin/bitcoin · GitHub
< andytoshi> hmm, so, i definitely did this in fall 2016 for scaling bitcoin milan and it only took a few hours
< bitcoin-git> [bitcoin] vasild opened pull request #19929: sync: use proper TSA attributes (master...use_proper_tsa_attributes) https://github.com/bitcoin/bitcoin/pull/19929
< bitcoin-git> [bitcoin] dongcarl opened pull request #19927: validation: Reduce direct g_chainman usage (master...2020-09-reduce-g_chainman-usage) https://github.com/bitcoin/bitcoin/pull/19927
< bitcoin-git> [bitcoin] hebasto opened pull request #19926: gui: Add Tor icon (master...200909-tor) https://github.com/bitcoin/bitcoin/pull/19926
< gribble> https://github.com/bitcoin/bitcoin/issues/19920 | test: Fuzzing siphash against reference implementation [Request for feedback] by elichai · Pull Request #19920 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19922: test: Run rpc_txoutproof.py even with wallet disabled (master...2009-testMoreMiniWallet) https://github.com/bitcoin/bitcoin/pull/19922
< jnewbery> #proposed meeting topic: stategies for removing recursive locking in the mempool (https://github.com/bitcoin/bitcoin/pull/19872#issuecomment-688852261)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19800: test: Mockwallet (master...2008-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/19800
< bitcoin-git> bitcoin/master fa188c9 MarcoFalke: test: Use MiniWalet in p2p_feefilter
< bitcoin-git> bitcoin/master 564e1ab MarcoFalke: Merge #19800: test: Mockwallet
< bitcoin-git> bitcoin/master fa39c62 MarcoFalke: test: inline hashToHex
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4f229d8904f8...564e1ab0f3dc
< gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #19695: [do not merge] Test impact of secp256k1 endianness detection change (master...202008_test_appveyer_secp256k1) https://github.com/bitcoin/bitcoin/pull/19695

2020-09-08

< bitcoin-git> [bitcoin] dr-orlovsky closed pull request #19907: util: add psbt combiner role (master...feat/psbt-combiner) https://github.com/bitcoin/bitcoin/pull/19907
< bitcoin-git> [bitcoin] elichai opened pull request #19920: test: Fuzzing siphash against reference implementation [Request for feedback] (master...2020-fuzzing-siphash) https://github.com/bitcoin/bitcoin/pull/19920
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19914: refactor: Do not pass chain params to CheckForStaleTipAndEvictPeers twice (master...2009-netNo2ChainParams) https://github.com/bitcoin/bitcoin/pull/19914
< bitcoin-git> bitcoin/master 4f229d8 MarcoFalke: Merge #19914: refactor: Do not pass chain params to CheckForStaleTipAndEvi...
< bitcoin-git> bitcoin/master fa7e407 MarcoFalke: Do not pass chain params to CheckForStaleTipAndEvictPeers twice
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/147d50d63e07...4f229d8904f8
< sipa> probably better for #bitcoin-wizards
< sipa> in that case, you're asking about proposal bitcoin protocol changes, not bitcoin core
< sipa> yanmaani: the current bitcoin protocol does not permit compact proofs for that
< yanmaani> is txn noninclusion proofs something bitcoin core intends to include?
< shesek> right, my claim was that the SPV model isn't all that important, and that if Satoshi released Bitcoin without considering light clients at all it would still be the incredible breakthrough that it is
< sipa> yeah, for a full-blocks-only bitcoin like protocol, the "merkle root" stored in the block header could just be a flat hash of all txids
< shesek> just curious. I was writing about that in a comment in the context of me claiming that merkle trees aren't an essential component of Bitcoin's breakthrough, and someone saying that they are (and being wrong :p)
< shesek> does bitcoin core ever verify merkle inclusion proofs? (I assume not, it only verifies that the merkle root matches the set of txids. but maybe I'm missing some other ways its being used?)
< gribble> https://github.com/bitcoin/bitcoin/issues/18766 | Disable fee estimation in blocksonly mode (by removing the fee estimates global) by darosior · Pull Request #18766 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] AkioNak opened pull request #19919: bugfix: make LoadWallet assigns status always (master...set_databasestatus) https://github.com/bitcoin/bitcoin/pull/19919
< gribble> https://github.com/bitcoin/bitcoin/issues/19843 | Refactoring and minor improvement for self-advertisements by naumenkogs · Pull Request #19843 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19643 | Add -netinfo peer connections dashboard by jonatack · Pull Request #19643 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17785 | p2p: Unify Send and Receive protocol versions by hebasto · Pull Request #17785 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19871 | doc: Clarify scope of eviction protection of outbound block-relay peers by ariard · Pull Request #19871 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< jnewbery> Any final topics before we end? Remember it's feature freeze in 5 weeks (https://github.com/bitcoin/bitcoin/issues/18947) so it's a great time to shill your PRs!
< gribble> https://github.com/bitcoin/bitcoin/issues/19820 | Transactions propagation design goals · Issue #19820 · bitcoin/bitcoin · GitHub
< jnewbery> great. Thanks. That'll also give people a bit more time to read your doc here: https://github.com/bitcoin/bitcoin/issues/19820