2020-11-13

< bitcoin-git> [bitcoin] practicalswift opened pull request #20383: Avoid signed integer overflow and invalid integer negation when loading malformed mempool.dat files (master...signed-integer-malformed-mempool-dat-and-rpc) https://github.com/bitcoin/bitcoin/pull/20383
< luke-jr> achow101: is this a fix we should be adding in 0.21? https://github.com/bitcoin/bitcoin/pull/20267/files#r523007716
< bitcoin-git> [bitcoin] practicalswift closed pull request #20089: validation: Increase robustness when loading malformed mempool.dat files (LoadMempool) (master...load-mempool-robustness) https://github.com/bitcoin/bitcoin/pull/20089
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20378: wallet: fix potential division by 0 in WalletLogPrintf (master...2020/11/fix_devnull_wallet) https://github.com/bitcoin/bitcoin/pull/20378
< bitcoin-git> bitcoin/master 543693b Jonas Schnelli: Merge #20378: wallet: fix potential division by 0 in WalletLogPrintf
< bitcoin-git> bitcoin/master 440f8d3 Jonas Schnelli: fix potential devision by 0
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/28cb61646b29...543693b92b95
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19065: tests: Add fuzzing harness for CAddrMan (master...fuzzers-2020-05-23) https://github.com/bitcoin/bitcoin/pull/19065
< bitcoin-git> bitcoin/master 28cb616 MarcoFalke: Merge #19065: tests: Add fuzzing harness for CAddrMan
< bitcoin-git> bitcoin/master d04a17a practicalswift: fuzz: Use ConsumeRandomLengthBitVector(...) in src/test/fuzz/connman and s...
< bitcoin-git> bitcoin/master e6bb9fd practicalswift: tests: Add fuzzing harness for CAddrMan
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99fcc2b4778f...28cb61646b29
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20379: tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp) (master...remove-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20379
< bitcoin-git> bitcoin/master 99fcc2b MarcoFalke: Merge #20379: tests: Remove no longer needed UBSan suppression (float divi...
< bitcoin-git> bitcoin/master 0ccb3ad practicalswift: tests: Remove no longer needed UBSan suppression (float-divide-by-zero in ...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0bd4929cd00e...99fcc2b4778f
< bitcoin-git> [bitcoin] fanquake closed pull request #19068: build: Use a zip instead of dmg for macOS releases (master...macdeploy_zip_instead_of_dmg) https://github.com/bitcoin/bitcoin/pull/19068
< bitcoin-git> [bitcoin] fanquake closed pull request #20336: build: automatically determine macOS base translations (master...auto_find_translations) https://github.com/bitcoin/bitcoin/pull/20336

2020-11-12

< gribble> Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< sipa> we do need a bitcoin core specific fuzzing farm that can run fuzzers with months of CPU time though
< gribble> https://github.com/bitcoin/bitcoin/issues/19387 | span: update constructors to match c++20 draft spec and add lifetimebound attribute by theuni · Pull Request #19387 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20380: doc: Add instructions on how to fuzz the P2P layer using Honggfuzz NetDriver (master...honggfuzz-p2p-fuzzing) https://github.com/bitcoin/bitcoin/pull/20380
< wumpus> bitcoin core is too big
< gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub
< wumpus> make it clear which areas of the code are the really risky ones that could break bitcoin as a thing
< Kiminuo> https://github.com/bitcoin/bitcoin/pull/19245 - Do I understand correctly that this is dead for foreseeable future?
< ja> provoostenator: i linked the commit https://github.com/bitcoin/bitcoin/commit/1d3ec2a1fda7446323786a52da1fd109c01aa6fb because i wanted to discuss this compromise on boolean blindness in general, not specific to the btcd issue
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< gribble> https://github.com/bitcoin/bitcoin/issues/19305 | doc: add C++17 release note for 0.21.0 by fanquake · Pull Request #19305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19716 | build: Qt 5.15.x by fanquake · Pull Request #19716 · bitcoin/bitcoin · GitHub
< ja> michaelfolkson: if you bitcoin node is deadlocked on a shared_mutex, are you online?
< ja> luke-jr: if you use bitcoin to back a lightning node, a deadlock could be pretty bad, no?
< jnewbery> Prompted by https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696, where Cory ran into a bug in glibc when using std::shared_mutex.
< jnewbery> As a reminder, our plan for C++17 is here: https://github.com/bitcoin/bitcoin/issues/16684
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #20379: tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp) (master...remove-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20379
< provoostenator> I'd like to get this in the release if possible: https://github.com/bitcoin-core/gui/pull/96
< wumpus> at least there's only three PRs left on the milestone: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< core-meetingbot> Meeting started Thu Nov 12 19:01:12 2020 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< ja> i see so many booleans, and i am suspicious. for example https://github.com/bitcoin/bitcoin/commit/1d3ec2a1fda7446323786a52da1fd109c01aa6fb
< jnewbery> #proposedmeetingtopic limiting C++17 feature usage (see https://github.com/bitcoin/bitcoin/issues/16684#issuecomment-726214696)
< bitcoin-git> [bitcoin] laanwj merged pull request #20284: addrman: ensure old versions don't parse peers.dat (master...peers_dat_format) https://github.com/bitcoin/bitcoin/pull/20284
< bitcoin-git> bitcoin/master 38ada89 Vasil Dimov: addrman: ensure old versions don't parse peers.dat
< bitcoin-git> bitcoin/master 0bd4929 Wladimir J. van der Laan: Merge #20284: addrman: ensure old versions don't parse peers.dat
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bd131669729...0bd4929cd00e
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20378: fix potential devision by 0 (master...2020/11/fix_devnull_wallet) https://github.com/bitcoin/bitcoin/pull/20378
< bitcoin-git> [bitcoin] practicalswift opened pull request #20377: fuzz: Fill various small fuzzing gaps (master...fuzzers-2020-11-12) https://github.com/bitcoin/bitcoin/pull/20377
< pinheadmz> shesek ive gotten a lot of great help from #bitcoin-core-pr-reviews
< pinheadmz> #bitcoin is basically /r/bitcoin
< jonasschnelli> shesek: yeah.. maybe also #bitcoin can help
< shesek> honestly I kinda knew it, its just that #bitcoin-dev appears pretty much dead, all my scrollback there is join/part/quit messages
< jonasschnelli> this channel is for bitcoin core development
< jonasschnelli> but I recommend to join #bitcoin-dev
< vasild> MarcoFalke: one of the test runs on https://github.com/bitcoin/bitcoin/pull/20284 is timing out, I restarted it 2 times, hmm
< bitcoin-git> bitcoin/master 2414342 João Barbosa: refactor: qt: Use vQueueNotifications.clear()
< bitcoin-git> bitcoin/master 989e579 João Barbosa: qt: Make transaction notification queue wallet specific
< bitcoin-git> bitcoin/master 7b3b230 João Barbosa: move-only: Define TransactionNotification before TransactionTablePriv
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8a486158cbc3...9bd131669729
< bitcoin-git> [gui] jonasschnelli merged pull request #120: Fix multiwallet transaction notifications (master...2020-10-fix-transaction-notifications) https://github.com/bitcoin-core/gui/pull/120
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate sat/vB param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< bitcoin-git> [gui] hebasto closed pull request #127: Replace QMetaObject::invokeMethod with atomic operations (master...201102-queued) https://github.com/bitcoin-core/gui/pull/127
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20188: tests: Add fuzzing harness for CConnman (master...fuzzers-connman) https://github.com/bitcoin/bitcoin/pull/20188
< bitcoin-git> bitcoin/master 8a48615 MarcoFalke: Merge #20188: tests: Add fuzzing harness for CConnman
< bitcoin-git> bitcoin/master 79ef832 practicalswift: tests: Add fuzzing harness for CConnman
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af8ec1d3e576...8a486158cbc3
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness (master...fuzzers-2020-11-11) https://github.com/bitcoin/bitcoin/pull/20375
< bitcoin-git> bitcoin/master 3c77b80 practicalswift: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness
< bitcoin-git> bitcoin/master af8ec1d MarcoFalke: Merge #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harnes...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/027e51f71517...af8ec1d3e576
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20372: Avoid signed integer overflow when loading a mempool.dat file with a malformed time field (master...load-mempool-time-integer-overflow) https://github.com/bitcoin/bitcoin/pull/20372
< bitcoin-git> bitcoin/master 027e51f MarcoFalke: Merge #20372: Avoid signed integer overflow when loading a mempool.dat fil...
< bitcoin-git> bitcoin/master ee11a41 practicalswift: Avoid signed integer overflow when loading a mempool.dat file with a malfo...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bcd142e479fa...027e51f71517
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20285: Remove references to CreateWalletFromFile (master...createwalletfromfilenomore) https://github.com/bitcoin/bitcoin/pull/20285
< bitcoin-git> bitcoin/master bcd142e MarcoFalke: Merge #20285: Remove references to CreateWalletFromFile
< bitcoin-git> bitcoin/master c82336c fanquake: Remove references to CreateWalletFromFile
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2d8ba6265a4...bcd142e479fa
< bitcoin-git> [bitcoin] fanquake closed pull request #18095: Fix crashes and infinite loop in ListWalletDir() (master...master) https://github.com/bitcoin/bitcoin/pull/18095
< gribble> https://github.com/bitcoin/bitcoin/issues/18095 | Fix crashes and infinite loop in ListWalletDir() by uhliksk · Pull Request #18095 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr · Pull Request #19502 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] meshcollider merged pull request #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks (master...bugfix_listwalletdir_errors) https://github.com/bitcoin/bitcoin/pull/19502
< bitcoin-git> bitcoin/master c2d8ba6 Samuel Dobson: Merge #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir fi...
< bitcoin-git> bitcoin/master 69f59af Luke Dashjr: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks
< bitcoin-git> bitcoin/master 24d2d33 Luke Dashjr: QA: wallet_multiwallet: Check that recursive symlink directory and wallet....
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9f5132736f3...c2d8ba6265a4

2020-11-11

< bitcoin-git> [bitcoin] practicalswift opened pull request #20375: fuzz: Improve coverage for CPartialMerkleTree fuzzing harness (master...fuzzers-2020-11-11) https://github.com/bitcoin/bitcoin/pull/20375
< bitcoin-git> [bitcoin] fanquake closed pull request #20374: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20374
< bitcoin-git> [bitcoin] practicalswift closed pull request #20137: tests: Update UBSan suppressions file with suppressions needed for clang 12 (current trunk) (master...clang-12-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20137
< bitcoin-git> [bitcoin] thomasdane opened pull request #20374: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20374
< bitcoin-git> [gui] hebasto closed pull request #107: Fix main window geometry save/restore (master...201023-geometry) https://github.com/bitcoin-core/gui/pull/107
< bitcoin-git> [bitcoin] hebasto opened pull request #20373: refactor, net: Increase CNode data member encapsulation (master...201111-cnode) https://github.com/bitcoin/bitcoin/pull/20373
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20344: wallet: fix scanning progress calculation for single block range (master...20201108-wallet-avoid_div_by_zero_on_single_block_rescan) https://github.com/bitcoin/bitcoin/pull/20344
< bitcoin-git> bitcoin/master d9f5132 MarcoFalke: Merge #20344: wallet: fix scanning progress calculation for single block r...
< bitcoin-git> bitcoin/master 5e14602 Sebastian Falbesoner: wallet: fix scanning progress calculation for single block range
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/179ece42734a...d9f5132736f3
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20218: test: Suppress epoll_ctl data race (master...2010-testSuppWalletRace) https://github.com/bitcoin/bitcoin/pull/20218
< bitcoin-git> bitcoin/master fa949b3 MarcoFalke: test: Suppress epoll_ctl data race
< bitcoin-git> bitcoin/master 179ece4 MarcoFalke: Merge #20218: test: Suppress epoll_ctl data race
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/155bf91c3b66...179ece42734a
< bitcoin-git> [bitcoin] practicalswift opened pull request #20372: Avoid signed integer overflow when loading a mempool.dat file with a malformed time field (master...load-mempool-time-integer-overflow) https://github.com/bitcoin/bitcoin/pull/20372
< jnewbery> vasild: can you explain what this line does: https://github.com/bitcoin/bitcoin/pull/20284/files#diff-49d1faa58beca1ee1509a247e0331bb91f8604e30a483a7b2dea813e6cea02e2R74 ? I don't understand how it fixes the build error
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20368: ci: Remove redundant valgrind fuzz task (master...2011-ciRemoveHeavyTask) https://github.com/bitcoin/bitcoin/pull/20368
< bitcoin-git> bitcoin/master 155bf91 MarcoFalke: Merge #20368: ci: Remove redundant valgrind fuzz task
< bitcoin-git> bitcoin/master fa92cf2 MarcoFalke: ci: Remove redundant valgrind fuzz task
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa8dd34e918c...155bf91c3b66
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20370: fuzz: Permission flags in net_processing fuzzers (master...2011-fuzzNetFlags) https://github.com/bitcoin/bitcoin/pull/20370
< vasild> jnewbery: wrt https://github.com/bitcoin/bitcoin/pull/20284#issuecomment-725341208 I guess you have verified that it would fix the link error?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20368: ci: Remove redundant valgrind fuzz task (master...2011-ciRemoveHeavyTask) https://github.com/bitcoin/bitcoin/pull/20368
< bitcoin-git> [bitcoin] hebasto opened pull request #20366: scripted-diff: Fix includes when secp256k1 is locally installed on macOS (master...201111-incl) https://github.com/bitcoin/bitcoin/pull/20366
< bitcoin-git> [bitcoin] S3RK opened pull request #20365: wallettool: add parameter to create descriptors wallet (master...wallet_tool_create_descriptors) https://github.com/bitcoin/bitcoin/pull/20365
< bitcoin-git> [bitcoin] jonatack reopened pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305
< bitcoin-git> [bitcoin] jonatack closed pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305
< brianddk> I was trying to build the first few versions of bitcoin (v0.1.5) with MSYS/MinGW (v1.0.11), but I'm failing on the OpenSSL build after applying the readme.txt patches. Anyone recall anything tricky to getting that to work?

2020-11-10

< bitcoin-git> [bitcoin] troygiorshev opened pull request #20364: Follow-ups to 19107 (master...2020-11-19107-follow-ups) https://github.com/bitcoin/bitcoin/pull/20364
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20332: test: Mock IBD in net_processing fuzzers (master...2011-fuzzNet) https://github.com/bitcoin/bitcoin/pull/20332
< bitcoin-git> bitcoin/master fa8dd34 MarcoFalke: Merge #20332: test: Mock IBD in net_processing fuzzers
< bitcoin-git> bitcoin/master fa4234d MarcoFalke: test: Mock IBD in net_processing fuzzers
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42f950cb27b7...fa8dd34e918c
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20362: test: Implicitly sync after generate* to preempt races and intermittent test failures (master...2011-noSync) https://github.com/bitcoin/bitcoin/pull/20362
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< core-meetingbot> Meeting started Tue Nov 10 13:33:42 2020 UTC. The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20322: test: Fix intermittent issue in wallet_listsinceblock (master...2011-testInt) https://github.com/bitcoin/bitcoin/pull/20322
< bitcoin-git> bitcoin/master 42f950c MarcoFalke: Merge #20322: test: Fix intermittent issue in wallet_listsinceblock
< bitcoin-git> bitcoin/master 4444128 MarcoFalke: test: Fix intermittent issue in wallet_listsinceblock
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b69bb90eed3...42f950cb27b7
< bitcoin-git> [bitcoin] mateusz-klatt opened pull request #20361: load wallets from entropy (as BIP39) (master...master) https://github.com/bitcoin/bitcoin/pull/20361
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20355: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet (master...fix-sub_net_deserialize) https://github.com/bitcoin/bitcoin/pull/20355
< bitcoin-git> bitcoin/master 79b8f8d practicalswift: fuzz: Assert roundtrip equality for both addrv1 and addrv2 versions of CSe...
< bitcoin-git> bitcoin/master 0b69bb9 MarcoFalke: Merge #20355: fuzz: Check for addrv1 compatibility before using addrv1 ser...
< bitcoin-git> bitcoin/master 0e3a78a practicalswift: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deseri...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1dfe19e2840b...0b69bb90eed3
< gribble> https://github.com/bitcoin/bitcoin/issues/20207 | Follow-up extra comments on taproot code and tests by sipa · Pull Request #20207 · bitcoin/bitcoin · GitHub

2020-11-09

< bitcoin-git> [bitcoin] dongcarl opened pull request #20359: depends: Various config.site.in improvements and linting (master...2020-11-config-site-cleanup) https://github.com/bitcoin/bitcoin/pull/20359
< bitcoin-git> [bitcoin] ffontaine opened pull request #20358: src/randomenv.cpp: fix build on uclibc (master...master) https://github.com/bitcoin/bitcoin/pull/20358
< bitcoin-git> [bitcoin] hebasto opened pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357
< bitcoin-git> [bitcoin] laanwj merged pull request #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet (master...importdesc_silent_fail) https://github.com/bitcoin/bitcoin/pull/20153
< bitcoin-git> bitcoin/master 1dfe19e Wladimir J. van der Laan: Merge #20153: wallet: do not import a descriptor with hardened derivations...
< bitcoin-git> bitcoin/master 538be42 Ivan Metlushko: wallet: fix importdescriptor silent fail
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79a3b59cc706...1dfe19e2840b
< az0re> user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 1 ECONOMICAL
< az0re> user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 10 ECONOMICAL
< az0re> user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 10 CONSERVATIVE
< az0re> user@host:~$ ./bitcoin-0.20.1/bin/bitcoin-cli -rpcuser=user --rpcpassword=... estimatesmartfee 1 CONSERVATIVE
< real_or_random> can we reopen https://github.com/bitcoin/bitcoin/issues/17802 ? I think this needs action before the end of the year.
< bitcoin-git> bitcoin/master 7b5bd31 Jon Atack: test: add getnetworkinfo network name regression tests
< bitcoin-git> [bitcoin] laanwj merged pull request #20120: net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests (master...fix-getnetworkinfo-empty-networks) https://github.com/bitcoin/bitcoin/pull/20120
< bitcoin-git> bitcoin/master 9a75e1e Jon Atack: rpc: update GetNetworksInfo() to not return unsupported networks
< bitcoin-git> bitcoin/master ba8997f Jon Atack: net: update GetNetworkName() with all enum Network cases
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4fd37d0a104f...79a3b59cc706
< bitcoin-git> [bitcoin] practicalswift opened pull request #20355: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet (master...fix-sub_net_deserialize) https://github.com/bitcoin/bitcoin/pull/20355
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20354: test: Add feature_taproot.py --previous_release (master...2010-testFeatureTaprootPreviousVersion) https://github.com/bitcoin/bitcoin/pull/20354
< bitcoin-git> [bitcoin] laanwj merged pull request #20292: test: Fix intermittent feature_taproot issue (master...2011-testFixes) https://github.com/bitcoin/bitcoin/pull/20292
< bitcoin-git> bitcoin/master fac865b MarcoFalke: test: Fix intermittent feature_taproot issue
< bitcoin-git> bitcoin/master fa1dea1 MarcoFalke: test: Fix deser issue in create_block
< bitcoin-git> bitcoin/master fa762a3 MarcoFalke: test: Remove unused unnamed parameter from block.serialize call
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/05aeeee34f15...4fd37d0a104f
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20339: ci: Run more ci configs on cirrus (master...2011-moreCirrus) https://github.com/bitcoin/bitcoin/pull/20339
< bitcoin-git> bitcoin/master fa0795f MarcoFalke: ci: Replace TRAVIS_OS_NAME with CI_OS_NAME
< bitcoin-git> bitcoin/master fa8b111 MarcoFalke: ci: Run arm ci config on cirrus
< bitcoin-git> bitcoin/master fafce1a MarcoFalke: ci: Move documentation to correct config file
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/663fd92b28c3...05aeeee34f15
< bitcoin-git> [bitcoin] laanwj merged pull request #20266: wallet: fix change detection of imported internal descriptors (master...fix-desc-change) https://github.com/bitcoin/bitcoin/pull/20266
< bitcoin-git> bitcoin/master 663fd92 Wladimir J. van der Laan: Merge #20266: wallet: fix change detection of imported internal descriptor...
< bitcoin-git> bitcoin/master bd93fc9 Andrew Chow: Fix change detection of imported internal descriptors
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f70eb51b05de...663fd92b28c3
< bitcoin-git> [bitcoin] laanwj merged pull request #20318: build: Ensure source tarball has leading directory name (master...2011-buildTar) https://github.com/bitcoin/bitcoin/pull/20318
< bitcoin-git> bitcoin/master f70eb51 Wladimir J. van der Laan: Merge #20318: build: Ensure source tarball has leading directory name
< bitcoin-git> bitcoin/master faa2f06 MarcoFalke: scripted-diff: [build] Ensure source tarball has leading directory name
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7e373294a5ae...f70eb51b05de
< bitcoin-git> [bitcoin] ajtowns opened pull request #20353: configure: Support -fdebug-prefix-map (master...202011-ccache-debug-prefix) https://github.com/bitcoin/bitcoin/pull/20353
< andytoshi> achow101: https://github.com/bitcoin/bitcoin/issues/20347 i'm not crazy :P

2020-11-08

< bitcoin-git> [bitcoin] tylerchambers opened pull request #20346: script: modify security-check.py to use "==" instead of "is" for literal comparison (master...literal-comparison-update) https://github.com/bitcoin/bitcoin/pull/20346
< andytoshi> let me try to extract a bitcoin example
< gribble> https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 · Pull Request #17458 · bitcoin/bitcoin · GitHub
< andytoshi> achow101: i think i'm right, this is a core thing not an elements thing ... https://github.com/bitcoin/bitcoin/blob/7e373294a5ae819099c39d9d03d1f5a311d63cfc/src/wallet/wallet.cpp#L3016-L3019 this comment says "nFeeNeeded should not have changed"
< andytoshi> achow101: oh i think my issue may have been resolved in https://github.com/bitcoin/bitcoin/pull/17458
< emzy> luke-jr: you are sure that they will blacklist all of dashjr.org? I think the http(s) blacklist of dnsseed.bitcoin.dashjr.org is right.
< jonatack> dnsseed.bitcoin.dashjr.org has been reported as a deceptive site. You can report a detection problem -> I filed an report
< luke-jr> ARGH, google has decided "dnsseed.bitcoin.dashjr.org" has deceptive content is now blacklisting all of dashjr.org -.-
< andytoshi> which means that when we recalculate nFeeRequired, we'll get a higher number than we did before. we set nFeeRet to nFeeRequired at the end of the previous iteration. so now this check will fail https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2984
< andytoshi> but then, when we do the next loop iteration, we skip SelectCoins and just set bnb_used to false https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2928
< andytoshi> but .. if we use bnb, but we don't get enough fees, and we have subtractfeefromeamount on, we hit this line https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3038
< andytoshi> the problem is that when we create txNew for the purpose of getting a tx size to estimate the fee required, in this line https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2940 we selectively add a change output based on whether bnb was used by SelectCoins
< bitcoin-git> [bitcoin] SatoshiBitcoin closed pull request #20345: Update README.md (master...Version1) https://github.com/bitcoin/bitcoin/pull/20345
< bitcoin-git> [bitcoin] SatoshiBitcoin opened pull request #20345: Update README.md (master...Version1) https://github.com/bitcoin/bitcoin/pull/20345
< bitcoin-git> [bitcoin] theStack opened pull request #20344: wallet: fix scanning progress calculation for single block range (master...20201108-wallet-avoid_div_by_zero_on_single_block_rescan) https://github.com/bitcoin/bitcoin/pull/20344
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20343: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/20343
< bitcoin-git> [bitcoin] fanliao1989 opened pull request #20343: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/20343
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20339: ci: Run macos ci config on cirrus (master...2011-moreCirrus) https://github.com/bitcoin/bitcoin/pull/20339
< bitcoin-git> [bitcoin] fanquake opened pull request #20336: build: automatically determine macOS base translations (master...auto_find_translations) https://github.com/bitcoin/bitcoin/pull/20336

2020-11-07

< bitcoin-git> [bitcoin] fanquake opened pull request #20333: build: remove native_biplist dependency (master...no_more_biplist) https://github.com/bitcoin/bitcoin/pull/20333
< bitcoin-git> [bitcoin] promag closed pull request #19917: Yet another change to reduce recursive mempool locking (master...2020-09-removeunbroadcasttx) https://github.com/bitcoin/bitcoin/pull/19917
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20332: test: Mock IBD in net_processing fuzzers (master...2011-fuzzNet) https://github.com/bitcoin/bitcoin/pull/20332
< bitcoin-git> [bitcoin] LarryRuane opened pull request #20331: allow -loadblock blocks to be unsorted (master...loadblock-unsorted) https://github.com/bitcoin/bitcoin/pull/20331

2020-11-06

< jonasschnelli> I tested the meetingbot (core-meetingbot) in ##bitcoin-core-gui and it works there...
< jonasschnelli> Indeed. Lightning bot also recorded the last meeting: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-05-19.00.log.txt (the one from yesterday).
< jonasschnelli> the wallet meeting was logged by my just created meetingbot (core-meetingbot) https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-06-19.00.moin.txt
< bitcoin-git> [bitcoin] luke-jr closed pull request #20250: Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely (master...rpcwallet_explicit_fixups) https://github.com/bitcoin/bitcoin/pull/20250
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< jonatack> 20305 implements the conclusion by wumpus at https://github.com/bitcoin/bitcoin/pull/20220#discussion_r513789526
< gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr · Pull Request #20250 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20315: travis: Remove s390x build (master...2010-ciS390x) https://github.com/bitcoin/bitcoin/pull/20315
< bitcoin-git> bitcoin/master 7e37329 MarcoFalke: Merge #20315: travis: Remove s390x build
< bitcoin-git> bitcoin/master fac0517 MarcoFalke: travis: Remove s390x build
< bitcoin-git> bitcoin/master fa2c3c0 MarcoFalke: ci: Set LC_ALL=C to allow running the s390x tests in qemu
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4727c1ca2493...7e373294a5ae
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20328: cirrus: Skip tasks on the gui repo main branch (master...2011-cirrusSkip) https://github.com/bitcoin/bitcoin/pull/20328
< bitcoin-git> bitcoin/master 4727c1c MarcoFalke: Merge #20328: cirrus: Skip tasks on the gui repo main branch
< bitcoin-git> bitcoin/master 66667ac MarcoFalke: cirrus: Skip tasks on the gui repo main branch
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0c00ff7c045...4727c1ca2493
< bitcoin-git> [bitcoin] dgpv opened pull request #20329: docs/descriptors.md: Remove hardened marker in the path after xpub (master...fix-descriptors-md-hardened-after-xpub) https://github.com/bitcoin/bitcoin/pull/20329
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20328: cirrus: Skip tasks on the gui repo main branch (master...2011-cirrusSkip) https://github.com/bitcoin/bitcoin/pull/20328
< gribble> https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr · Pull Request #20250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #20298: macOS deploy: use the new plistlib API (master...2020/11/macdeployfix) https://github.com/bitcoin/bitcoin/pull/20298
< bitcoin-git> bitcoin/master a0c00ff fanquake: Merge #20298: macOS deploy: use the new plistlib API
< bitcoin-git> bitcoin/master 04a69c2 Jonas Schnelli: macOS deploy: use the new plistlib API
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c51c2753a4ff...a0c00ff7c045
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20326: tests: Fix ecdsa_verify in test framework (master...fix-test-ecdsa-verification) https://github.com/bitcoin/bitcoin/pull/20326
< bitcoin-git> bitcoin/master c51c275 MarcoFalke: Merge #20326: tests: Fix ecdsa_verify in test framework
< bitcoin-git> bitcoin/master 568a1d7 Stepan Snigirev: fix ecdsa verify in test framework
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65460c207c0b...c51c2753a4ff
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20324: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase (master...2011-walletSqliteSuccess) https://github.com/bitcoin/bitcoin/pull/20324
< bitcoin-git> bitcoin/master 65460c2 MarcoFalke: Merge #20324: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase
< bitcoin-git> bitcoin/master faf5fa7 MarcoFalke: wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5cdc290d5a4...65460c207c0b
< gribble> https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr · Pull Request #19502 · bitcoin/bitcoin · GitHub

2020-11-05

< bitcoin-git> [bitcoin] stepansnigirev opened pull request #20326: tests: Fix ecdsa_verify in test framework (master...fix-test-ecdsa-verification) https://github.com/bitcoin/bitcoin/pull/20326
< bitcoin-git> [gui] jarolrod opened pull request #129: qt: Fix Shortcut Ambiguities, Clean up text (master...optionsMenuCleanup) https://github.com/bitcoin-core/gui/pull/129
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20324: wallet: Set DatabaseStatus::SUCCESSS in MakeSQLiteDatabase (master...2011-walletSqliteSuccess) https://github.com/bitcoin/bitcoin/pull/20324
< gribble> https://github.com/bitcoin/bitcoin/issues/20318 | build: Ensure source tarball has leading directory name by MarcoFalke · Pull Request #20318 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr · Pull Request #20250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20153 | wallet: do not import a descriptor with hardened derivations into a watch-only wallet by S3RK · Pull Request #20153 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20266 | wallet: fix change detection of imported internal descriptors by achow101 · Pull Request #20266 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr · Pull Request #19502 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack · Pull Request #20120 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack · Pull Request #20120 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr · Pull Request #19502 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20292 | test: Fix intermittent feature_taproot issue by MarcoFalke · Pull Request #20292 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20318 | build: Ensure source tarball has leading directory name by MarcoFalke · Pull Request #20318 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20284 | addrman: ensure old versions dont parse peers.dat by vasild · Pull Request #20284 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20305 | wallet: introduce fee_rate_sat_vb param/option by jonatack · Pull Request #20305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr · Pull Request #20250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20250 | Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr · Pull Request #20250 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< bitcoin-git> [bitcoin] dongcarl opened pull request #20323: tests: Create or use existing properly initialized NodeContexts (master...2020-10-chainman-fixes) https://github.com/bitcoin/bitcoin/pull/20323
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20322: test: Fix intermittent issue in wallet_listsinceblock (master...2011-testInt) https://github.com/bitcoin/bitcoin/pull/20322
< bitcoin-git> [bitcoin] mammix2 opened pull request #20320: Depends: Update FreeType package (CVE-2020-15999) (master...master) https://github.com/bitcoin/bitcoin/pull/20320
< bitcoin-git> [bitcoin] mammix2 closed pull request #20319: Depends: Update FreeType package (CVE-2020-15999) (master...master) https://github.com/bitcoin/bitcoin/pull/20319
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20316: test: Fix wallet_multiwallet test issue on Windows (master...2011-testWalletWindows) https://github.com/bitcoin/bitcoin/pull/20316
< bitcoin-git> bitcoin/master f5cdc29 MarcoFalke: Merge #20316: test: Fix wallet_multiwallet test issue on Windows
< bitcoin-git> bitcoin/master fa00ff0 MarcoFalke: test: Fix wallet_multiwallet test issue on Windows
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bb078351b09...f5cdc290d5a4
< MarcoFalke> looks like fanquake has bumped it too in https://github.com/bitcoin/bitcoin/pull/19716/commits/83582dcf23c23326fcb648b436d51469e66db5d5 so it might be fine after all
< bitcoin-git> [bitcoin] mammix2 opened pull request #20319: Depends: Update FreeType package (CVE-2020-15999) (master...master) https://github.com/bitcoin/bitcoin/pull/20319
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20318: build: Ensure source tarball has leading directory name (master...2011-buildTar) https://github.com/bitcoin/bitcoin/pull/20318
< bitcoin-git> [bitcoin] jnewbery opened pull request #20317: Backport wtxid orphan fetch to v0.20 (0.20...2020-07-v20-wtxid-orphan) https://github.com/bitcoin/bitcoin/pull/20317
< bitcoin-git> [bitcoin] laanwj merged pull request #19606: Backport wtxid relay to v0.20 (0.20...2020-07-v20-wtxid-relay) https://github.com/bitcoin/bitcoin/pull/19606
< bitcoin-git> bitcoin/0.20 3654937 Suhas Daftuar: Add a wtxid-index to mapRelay
< bitcoin-git> bitcoin/0.20 4df3d13 Suhas Daftuar: Add a wtxid-index to the mempool
< bitcoin-git> bitcoin/0.20 f7833b5 Suhas Daftuar: Just pass a hash to AddInventoryKnown
< bitcoin-git> [bitcoin] laanwj pushed 18 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/b9ac31f2d29a...a339289c2ef9
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20308: wallet: Set bilingual error completely (master...201105-fixbi) https://github.com/bitcoin/bitcoin/pull/20308
< bitcoin-git> bitcoin/master 090b838 Hennadii Stepanov: Set bilingual error completely
< bitcoin-git> bitcoin/master 9bb0783 MarcoFalke: Merge #20308: wallet: Set bilingual error completely
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d94777bd525a...9bb078351b09
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20316: test: Fix wallet_multiwallet test issue on Windows (master...2011-testWalletWindows) https://github.com/bitcoin/bitcoin/pull/20316
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20302: net: Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress) (master...NodeEvictionCandidate-addr) https://github.com/bitcoin/bitcoin/pull/20302
< bitcoin-git> bitcoin/master d94777b MarcoFalke: Merge #20302: net: Make it easier to reason about node eviction by removin...
< bitcoin-git> bitcoin/master f1f433e practicalswift: Make it easier to reason about node eviction by removing unused NodeEvicti...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f33e33254179...d94777bd525a
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20315: travis: Remove s390x build (master...2010-ciS390x) https://github.com/bitcoin/bitcoin/pull/20315