2020-05-21

< bitcoin-git> bitcoin/master 691c817 Russell Yanofsky: Add util::Ref class as temporary alternative for c++17 std::any
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/97b21b302a11...25ad2c623af3
< bitcoin-git> [bitcoin] hebasto closed pull request #19029: net: Fix CThreadInterrupt::sleep_for TSan issues (master...200520-interrupts) https://github.com/bitcoin/bitcoin/pull/19029
< fanquake> If you look here: https://travis-ci.org/github/bitcoin/bitcoin/requests, that was the status for your branch
< bitcoin-git> [bitcoin] fanquake merged pull request #18677: Multiprocess build support (master...pr/ipc-build2) https://github.com/bitcoin/bitcoin/pull/18677
< bitcoin-git> bitcoin/master e2bab2a Russell Yanofsky: multiprocess: add multiprocess travis configuration
< bitcoin-git> bitcoin/master 603fd6a Russell Yanofsky: depends: add MULTIPROCESS depends option
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/17df15efb546...97b21b302a11
< bitcoin-git> bitcoin/master 5d1377b Russell Yanofsky: build: multiprocess autotools changes
< vasild> fanquake: https://travis-ci.org/github/bitcoin/bitcoin/builds/689316499 that is the result from the initial run after PR was opened. Afterwards I push-f'ed 2 times, hopefully resolving those failures (first push -f) and rebasing (second push -f)
< gribble> https://github.com/bitcoin/bitcoin/issues/19036 | Cannot change passphrase even if it is correct · Issue #19036 · bitcoin/bitcoin · GitHub
< elichai2> Hi, I'm looking at issue #19036, and shouldn't this: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L328 be `continue;` instead of `return false;` so it will continue trying master keys?
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #18958: guix: Make V=1 more powerful for debugging (master...2020-05-guix-improvements) https://github.com/bitcoin/bitcoin/pull/18958
< bitcoin-git> bitcoin/master 17df15e fanquake: Merge #18958: guix: Make V=1 more powerful for debugging
< bitcoin-git> bitcoin/master f852761 Carl Dong: guix: Add clarifying documentation for V env var
< bitcoin-git> bitcoin/master 85f4a4b Carl Dong: guix: Make V=1 more powerful for debugging
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3eda7ea9ba72...17df15efb546

2020-05-20

< bitcoin-git> [bitcoin] promag opened pull request #19033: http: Fix workQueue race on InterruptHTTPServer (master...2020-05-fix-race-interrupt-http-server) https://github.com/bitcoin/bitcoin/pull/19033
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18764: refactor: test: replace inv type magic numbers by constants (master...20200425-test-replace_inv_types_by_constants) https://github.com/bitcoin/bitcoin/pull/18764
< bitcoin-git> bitcoin/master eeaaa58 Sebastian Falbesoner: test: replace inv type magic numbers by constants
< bitcoin-git> bitcoin/master b35e1d2 Sebastian Falbesoner: test: add inventory type constant MSG_CMPCT_BLOCK
< bitcoin-git> bitcoin/master 4a614ff Sebastian Falbesoner: test: explicit imports from test_framework.messages in p2p_invalid_message...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/448bdff26307...3eda7ea9ba72
< bitcoin-git> [bitcoin] sipa opened pull request #19032: Serialization improvements: final step (master...202005_noncastserial_final) https://github.com/bitcoin/bitcoin/pull/19032
< bitcoin-git> [bitcoin] dongcarl closed pull request #16748: [WIP] Add support for addrv2 (BIP155) (master...2019-07-addrv2v4) https://github.com/bitcoin/bitcoin/pull/16748
< bitcoin-git> [bitcoin] vasild opened pull request #19031: Implement ADDRv2 support (part of BIP155) (master...addrv2) https://github.com/bitcoin/bitcoin/pull/19031
< gribble> https://github.com/bitcoin/bitcoin/issues/18424 | qt: Use parent-child relation to manage lifetime of OptionsModel object by hebasto · Pull Request #18424 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #19029: net: Fix CThreadInterrupt::sleep_for TSan issues (master...200520-interrupts) https://github.com/bitcoin/bitcoin/pull/19029
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19028: test: Set -logthreadnames in unit tests (master...2005-testThreadNames) https://github.com/bitcoin/bitcoin/pull/19028
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18317: Serialization improvements step 6 (all except wallet/gui) (master...202003_noncastserial_6) https://github.com/bitcoin/bitcoin/pull/18317
< bitcoin-git> bitcoin/master d06fedd Russell Yanofsky: Add SER_READ and SER_WRITE for read/write-dependent statements
< bitcoin-git> bitcoin/master 6f9a1e5 Russell Yanofsky: Extend CustomUintFormatter to support enums
< bitcoin-git> bitcoin/master 769ee5f Pieter Wuille: Merge BigEndian functionality into CustomUintFormatter
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e20e964cb1ab...448bdff26307
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18996: net: Remove un-actionable TODO (master...2005-netNoTodo) https://github.com/bitcoin/bitcoin/pull/18996
< bitcoin-git> bitcoin/master e20e964 MarcoFalke: Merge #18996: net: Remove un-actionable TODO
< bitcoin-git> bitcoin/master fabea6d MarcoFalke: net: Run clang-format on protocol.h
< bitcoin-git> bitcoin/master facdeea MarcoFalke: net: Remove un-actionable TODO
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd5ec7c5284d...e20e964cb1ab
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19006: rpc: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git> bitcoin/master faf45d1 MarcoFalke: http: Avoid crash when g_thread_http was never started
< bitcoin-git> bitcoin/master fa12a37 MarcoFalke: test: Replace inline-comments with logs, pep8 formatting
< bitcoin-git> bitcoin/master fa83b39 MarcoFalke: init: Remove confusing and redundant InitError
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a587f85853ec...bd5ec7c5284d
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18587: gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged (master...pr/ipc-bal) https://github.com/bitcoin/bitcoin/pull/18587
< bitcoin-git> bitcoin/master bf0a510 Russell Yanofsky: gui: Avoid wallet tryGetBalances calls before TransactionChanged or BlockT...
< bitcoin-git> bitcoin/master 2bc9b92 Russell Yanofsky: Cancel wallet balance timer when shutdown requested
< bitcoin-git> bitcoin/master 83f69fa Russell Yanofsky: Switch transaction table to use wallet height not node height
< bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0aa2ff0f660e...a587f85853ec
< PaulTroon> BIP34 was an interesting historic read - is Gavin's speculation about a duplicate coinbase in 2048 technically impossible for a malicous miner? https://github.com/bitcoin/bitcoin/pull/1526#issuecomment-6796145
< bitcoin-git> [bitcoin] fanquake opened pull request #19025: [0.19] Backports (0.19...0_19_2_backports) https://github.com/bitcoin/bitcoin/pull/19025
< sipa> ah, i forgot: https://github.com/bitcoin/bitcoin/pull/16083 added statistics using undo data
< bitcoin-git> [bitcoin] fanquake merged pull request #18956: build: enforce minimum required Windows version (7) (master...window_enforce_runtime_version) https://github.com/bitcoin/bitcoin/pull/18956
< bitcoin-git> bitcoin/master 0aa2ff0 fanquake: Merge #18956: build: enforce minimum required Windows version (7)
< bitcoin-git> bitcoin/master e8a8cff fanquake: build: enforce minimum required Windows version (7)
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa8d76806c74...0aa2ff0f660e

2020-05-19

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19023: test: Fix intermittent ETIMEDOUT on FreeBSD (master...2005-testFixIntermFreeBsdTimeout) https://github.com/bitcoin/bitcoin/pull/19023
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19022: test: Fix intermittent failure in feature_dbcrash (master...2005-testFixIntermittentFailDbCrash) https://github.com/bitcoin/bitcoin/pull/19022
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19020: net: Use C++11 member initialization in protocol (master...2005-netCxx11MemberInit) https://github.com/bitcoin/bitcoin/pull/19020
< bitcoin-git> [bitcoin] luke-jr opened pull request #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.20...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19019
< bitcoin-git> [bitcoin] limpbrains opened pull request #19018: docs: fixing description of the field sequence in walletcreatefundedpsbt RPC method (master...walletcreatefundedpsbt-fix-docs) https://github.com/bitcoin/bitcoin/pull/19018
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] practicalswift closed pull request #18920: doc: Document how to analyze Bitcoin Core using Clang Static Analysis, clang-tidy and cppcheck (master...static-analysis-clang-tidy) https://github.com/bitcoin/bitcoin/pull/18920
< gribble> https://github.com/bitcoin/bitcoin/issues/18956 | build: enforce minimum required Windows version (7) by fanquake · Pull Request #18956 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key (master...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/17946
< bitcoin-git> bitcoin/master aa8d768 MarcoFalke: Merge #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key
< bitcoin-git> bitcoin/master 412d5fe Luke Dashjr: QA: feature_segwit: Check that template "rules" includes "!segwit" as appr...
< bitcoin-git> bitcoin/master 2abe8cc Luke Dashjr: Bugfix: Include "csv","!segwit" in "rules"
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d44dd513226f...aa8d76806c74
< bitcoin-git> [bitcoin] practicalswift opened pull request #19015: build: Enable some commonly enabled compiler diagnostics (master...compiler-diagnostics) https://github.com/bitcoin/bitcoin/pull/19015
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18152: qt: Use SynchronizationState enum for signals to GUI (master...20200215-pr18121-followup2) https://github.com/bitcoin/bitcoin/pull/18152
< bitcoin-git> bitcoin/master 2bec309 Hennadii Stepanov: refactor: Remove unused bool parameter in RPCNotifyBlockChange()
< bitcoin-git> bitcoin/master 1dab574 Hennadii Stepanov: refactor: Pass SynchronizationState enum to GUI
< bitcoin-git> bitcoin/master 1df7701 Hennadii Stepanov: refactor: Remove unused bool parameter in BlockNotifyGenesisWait()
< bitcoin-git> [bitcoin] jonasschnelli pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e7736854ef6c...d44dd513226f
< bitcoin-git> [bitcoin] fanquake closed pull request #18903: test: fix TEST_PREVIOUS_RELEASES check (master...getenv_defaults_to_None) https://github.com/bitcoin/bitcoin/pull/18903
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option (master...2005-testPrevReleases) https://github.com/bitcoin/bitcoin/pull/19014
< bitcoin-git> [bitcoin] Sjors opened pull request #19013: test: add v0.20.0 to backwards compatibility test (master...2020/05/previous_release_0.20) https://github.com/bitcoin/bitcoin/pull/19013
< bitcoin-git> [bitcoin] fanquake merged pull request #19008: ci: tsan on clang-9 (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
< bitcoin-git> bitcoin/master e773685 fanquake: Merge #19008: ci: tsan on clang-9
< bitcoin-git> bitcoin/master faf5521 MarcoFalke: ci: Set DEBIAN_FRONTEND=noninteractive
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/042ff521421f...e7736854ef6c
< bitcoin-git> bitcoin/master fa006ca MarcoFalke: ci: tsan on clang-9
< bitcoin-git> [bitcoin] hosseinamin closed pull request #14898: rpc listtransactions new argument options (paginatebypointer impl) (master...master) https://github.com/bitcoin/bitcoin/pull/14898
< elichai2> Finished reading http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-08-19.00.log.html, I have a naive question, no-one suggested using leveldb(since we already use that in validation) to replace bdb, is it because the main reason is for future table features or there is something bad/problematic with leveldb?
< bitcoin-git> [bitcoin] fanquake merged pull request #18999: log: Remove "No rpcpassword set" from logs (master...2005-logRpcPassword) https://github.com/bitcoin/bitcoin/pull/18999
< bitcoin-git> bitcoin/master fa243be MarcoFalke: log: Remove "No rpcpassword set" from logs
< bitcoin-git> bitcoin/master 042ff52 fanquake: Merge #18999: log: Remove "No rpcpassword set" from logs
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c73bd004ae81...042ff521421f
< bitcoin-git> [bitcoin] fanquake merged pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861
< bitcoin-git> bitcoin/master 2896c41 Pieter Wuille: Do not answer GETDATA for to-be-announced tx
< bitcoin-git> bitcoin/master c6131bf Pieter Wuille: Abstract logic to determine whether to answer tx GETDATA
< bitcoin-git> bitcoin/master f2f32a3 Pieter Wuille: Push down use of cs_main into FindTxForGetData
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/362f9c60a54e...c73bd004ae81
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< fanquake> tryphe: It's on by default if you're compiling using Ubuntu, which we are for gitian builds. We do have to add it explicitly when building for RISCV though: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml#L160
< gribble> https://github.com/bitcoin/bitcoin/issues/18152 | qt: Use SynchronizationState enum for signals to GUI by hebasto · Pull Request #18152 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18986: tests: Add capability to disable RPC timeout in functional tests (master...notimeout-flag) https://github.com/bitcoin/bitcoin/pull/18986
< bitcoin-git> bitcoin/master 362f9c6 MarcoFalke: Merge #18986: tests: Add capability to disable RPC timeout in functional t...
< bitcoin-git> bitcoin/master 784ae09 codeShark149: test: Add capability to disable RPC timeout in functional tests.
< bitcoin-git> bitcoin/master 38c3dd9 codeShark149: docs: Add notes on how to diasble rpc timeout in functional tests while at...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc5333d31f28...362f9c60a54e

2020-05-18

< tryphe> is there any way to resolve these review comments? i guess i've selected the wrong review type but it looks ugly to see all of my comments expanded: https://github.com/bitcoin/bitcoin/pull/19004#pullrequestreview-413807305
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
< bitcoin-git> [bitcoin] jnewbery opened pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
< bitcoin-git> [bitcoin] h2o10 opened pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19008: ci: tsan on focal (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
< gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: disable AppNap during sync by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19006: http: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC… (master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
< bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19004: script: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
< shesek> I guess there's no --bitcoin-unlimited parameter that would easily let me make blocks that are larger than the weight limit, right? :p
< hebasto> wumpus: kindly reminder -- is it time to upload rc2 to https://bitcoincore.org/bin/bitcoin-core-0.20.0/ ?
< gribble> https://github.com/bitcoin/bitcoin/issues/17946 | Fix GBT: Restore "!segwit" and "csv" to "rules" key by luke-jr · Pull Request #17946 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] shesek opened pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
< shesek> I'm afraid that I'm probably not the the right person for the job, but I will happily help with testing. :) but yes, sorry, I know that making these requests without offering any help implementing them is not very useful. bitcoin core has plenty of features that could be added if someone with the expertise and time prioritized them

2020-05-17

< shesek> does bitcoin-qt not show the fee of confirmed incoming transactions (ie where the spent prevouts are no longer in the utxo set)?
< shesek> bitcoin-qt does seem to somehow get it
< bitcoin-git> [bitcoin] sipa closed pull request #18977: [DONTMERGE] Test ranked_index (master...202005_try_ranked) https://github.com/bitcoin/bitcoin/pull/18977
< bitcoin-git> [bitcoin] 10xcryptodev opened pull request #19001: qt: bugfix unsupported QLocale languages (master...202005-bugfix-qlocale) https://github.com/bitcoin/bitcoin/pull/19001
< jonatack> tryphe: on github projects with a small number of collaborators i think they are fun; on more widely-watched ones like bitcoin core i tend to not use them to avoid it turning into a social media or slack feed. using an emoji inside a comment, sure. worked more ideas into the doc from all three of you, thanks!
< tryphe> when getting into bitcoin PR review i feel like there's this -almost- unscalable mountain in front of you; semi-scalable in terms of "things that i can actually review without much historical bitcoin knowlegde" (NATPMP for example, that was easy, but almost straightforward enough that it requires no comments), but also unscalable parts in terms of other PRs where the motivation was so ingenius that trying to review it almost seems like a
< jonatack> i think this was the last time recently where i reviewed the code before the concept ack https://github.com/bitcoin/bitcoin/pull/18962#issuecomment-627635800
< michaelfolkson> On your previous question tryphe I would say follow the guidelines as much as possible https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18999: 2005 log rpc password (master...2005-logRpcPassword) https://github.com/bitcoin/bitcoin/pull/18999
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18997: gui: Remove un-actionable TODO (master...2005-guiNoTodo) https://github.com/bitcoin/bitcoin/pull/18997
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18996: net: Remove un-actionable TODO (master...2005-netNoTodo) https://github.com/bitcoin/bitcoin/pull/18996
< michaelfolkson> jonatack: This isn't the guidance in the CONTRIBUTING doc. https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18938: tests: Fill fuzzing coverage gaps for functions in consensus/validation.h, primitives/block.h and util/translation.h (master...fuzzers-misc-5) https://github.com/bitcoin/bitcoin/pull/18938
< bitcoin-git> bitcoin/master fb559c1 practicalswift: tests: Fill fuzzing coverage gaps for functions in util/translation.h
< bitcoin-git> bitcoin/master b74f3d6 practicalswift: tests: Fill fuzzing coverage gaps for functions in consensus/validation.h
< bitcoin-git> bitcoin/master c0bbf81 practicalswift: tests: Fill fuzzing coverage gaps for functions in primitives/block.h
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f8123d483caa...dc5333d31f28
< jonatack> sipa: good point, i added your code review ack description to https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#peer-review
< jonatack> as for the need for a testing label: ACKs are normally followed by a description of how the reviewer did the review, including testing (https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review)
< bitcoin-git> [bitcoin] practicalswift opened pull request #18994: tests: Add fuzzing harnesses for functions in script/ (master...fuzzers-script-slash) https://github.com/bitcoin/bitcoin/pull/18994
< bitcoin-git> [bitcoin] 10xcryptodev opened pull request #18993: qt: increase console command max lenght (master...202005-increase-console-command) https://github.com/bitcoin/bitcoin/pull/18993
< bitcoin-git> [bitcoin] 10xcryptodev opened pull request #18992: qt: add sign and verify message support to AddressBookPage (master...202005-sign-message-ui) https://github.com/bitcoin/bitcoin/pull/18992
< bitcoin-git> [bitcoin] naumenkogs opened pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991
< gribble> https://github.com/bitcoin/bitcoin/issues/18989 | Towards alternative transports first-class support · Issue #18989 · bitcoin/bitcoin · GitHub

2020-05-16

< wumpus> Pavlenex: there's no need to open PRs for it, translations are updated from transifex periodically (complete or not), the last PR was yesterday: https://github.com/bitcoin/bitcoin/commit/0793eca3a63ed54ccaf27085ce664f64ae7f2b40
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18990: log: Properly log txs rejected from mempool (master...2005-logMempoolRej) https://github.com/bitcoin/bitcoin/pull/18990
< bitcoin-git> [bitcoin] ariard opened pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
< bitcoin-git> [bitcoin] ariard opened pull request #18987: RFC: Introducing Watchdog, a cross-layer anomaly detection module (master...2020-05-rfc-watchdog) https://github.com/bitcoin/bitcoin/pull/18987
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18952: test: avoid os-dependant path (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18952
< bitcoin-git> bitcoin/master f8123d4 MarcoFalke: Merge #18952: test: avoid os-dependant path
< bitcoin-git> bitcoin/master 8a22fd0 Ferdinando M. Ametrano: avoided os-dependant path
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5a454d78825f...f8123d483caa
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18634: ci: Add fuzzbuzz integration configuration file (master...fuzzbuzz) https://github.com/bitcoin/bitcoin/pull/18634
< bitcoin-git> bitcoin/master 5a454d7 MarcoFalke: Merge #18634: ci: Add fuzzbuzz integration configuration file
< bitcoin-git> bitcoin/master 8d30686 practicalswift: ci: Add fuzzbuzz integration
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/951870807ea2...5a454d78825f
< bitcoin-git> [bitcoin] rajarshimaitra opened pull request #18986: Adds a new --notimeout flag in test_framework. (master...notimeout-flag) https://github.com/bitcoin/bitcoin/pull/18986
< jonasschnelli> 0.20.0rc2 detached sigs are live: https://github.com/bitcoin-core/bitcoin-detached-sigs/commits/v0.20.0rc2
< bitcoin-git> [bitcoin] kallewoof closed pull request #18981: doc: add note about considering making issues over TODO source code comments (master...202005-no-todo) https://github.com/bitcoin/bitcoin/pull/18981
< bitcoin-git> [bitcoin] jb55 opened pull request #18985: bloom: use Span instead of std::vector for `insert` and `contains` [ZAP3] (master...2020-05-bloom-span) https://github.com/bitcoin/bitcoin/pull/18985

2020-05-15

< bitcoin-git> [bitcoin] dgenr8 opened pull request #18984: Remove unnecessary input blockfile SetPos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18984
< jonatack> I wonder if it would make any sense to bring bitcoinacks, with pierre_rochard's permission of course, into https://github.com/bitcoin-core/ to see more attention
< bitcoin-git> [bitcoin] tarboss closed pull request #18961: gui: remove assert in walletcontroller & run setparent in gui-qt main thread (master...master) https://github.com/bitcoin/bitcoin/pull/18961
< bitcoin-git> [bitcoin] ryanofsky opened pull request #18982: wallet: Minimal fix to restore conflicted transaction notifications (master...pr/cblock) https://github.com/bitcoin/bitcoin/pull/18982
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18781: Add templated GetRandDuration<> (master...2004-randDur) https://github.com/bitcoin/bitcoin/pull/18781
< bitcoin-git> bitcoin/master 9518708 MarcoFalke: Merge #18781: Add templated GetRandDuration<>
< bitcoin-git> bitcoin/master fa0e5b8 MarcoFalke: Add templated GetRandomDuration<>
< bitcoin-git> bitcoin/master 0000ea3 MarcoFalke: test: Add test for GetRandMillis and GetRandMicros
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e2f6866cca3e...951870807ea2
< bitcoin-git> [bitcoin] laanwj pushed tag v0.20.0rc2: https://github.com/bitcoin/bitcoin/compare/v0.20.0rc2
< bitcoin-git> bitcoin/0.20 6f7f94a Wladimir J. van der Laan: build: Bump RC to rc2
< bitcoin-git> bitcoin/0.20 0793eca Wladimir J. van der Laan: qt: Pre-rc2 translations update
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/17bdf2afaee0...6f7f94a27687
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
< bitcoin-git> bitcoin/0.20 1e73d72 Amiti Uttarwar: [net processing] ignore unknown INV types in GETDATA messages
< bitcoin-git> bitcoin/0.20 fb82173 Amiti Uttarwar: [net processing] ignore tx GETDATA from blocks-only peers
< bitcoin-git> bitcoin/0.20 315ae14 João Barbosa: gui: Fix itemWalletAddress leak when not tree mode
< bitcoin-git> [bitcoin] MarcoFalke pushed 16 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/aa7c6858e6e4...17bdf2afaee0
< bitcoin-git> [bitcoin] kallewoof opened pull request #18981: doc: add note about preferring issues over TODO source code comments (master...202005-no-todo) https://github.com/bitcoin/bitcoin/pull/18981
< bitcoin-git> [bitcoin] fanquake closed pull request #15706: build: Check QT library version (master...check-qt-version) https://github.com/bitcoin/bitcoin/pull/15706
< bitcoin-git> [bitcoin] hebasto opened pull request #18980: build: Decouple clientversion.cpp from the git repo (master...0515-decouple) https://github.com/bitcoin/bitcoin/pull/18980
< gribble> https://github.com/bitcoin/bitcoin/issues/18413 | script: prevent UB when computing abs value for num opcode serialize by pierreN · Pull Request #18413 · bitcoin/bitcoin · GitHub
< fanquake> Looking for opinions on just removing the remaining fuzz job for the 0.20 branch. It's not going to pass in Travis without even more backporting: https://github.com/bitcoin/bitcoin/pull/18973#issuecomment-629050088
< bitcoin-git> [bitcoin] fanquake merged pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git> bitcoin/master e2f6866 fanquake: Merge #18975: test: Remove const to work around compiler error on xenial
< bitcoin-git> bitcoin/master 050e2ee Wladimir J. van der Laan: test: Remove const to work around compiler error on xenial
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/553bb3fc3d95...e2f6866cca3e

2020-05-14

< MarcoFalke> And in reply to "removing boost should not be a goal". I think I disagree. Most of boost seems unmaintained at this point. For example the bug that crashed Bitcoin Core was reported to upstream with steps to reproduce and even a fix. I am still waiting for a reply...
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
< bitcoin-git> [bitcoin] sipa opened pull request #18977: Test ranked_index (master...202005_try_ranked) https://github.com/bitcoin/bitcoin/pull/18977
< gribble> https://github.com/bitcoin/bitcoin/issues/18349 | build: Fix quick hack for version string in releases by hebasto · Pull Request #18349 · bitcoin/bitcoin · GitHub
< wumpus> luke-jr talks about a security vulnerability importing data from a git repository above the bitcoin one, this can be avoided by checking in genbuild that we're really in a git repo right?
< gribble> https://github.com/bitcoin/bitcoin/issues/18909 | [0.20] Fix release tarball by luke-jr · Pull Request #18909 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8875 | Bump minimum required Boost version · Issue #8875 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 6 blockers, 1 bugfix, 4 chasing concept ACK now
< gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
< wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt (only a suggestion for high prio for review)
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] laanwj merged pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
< bitcoin-git> bitcoin/master 553bb3f Wladimir J. van der Laan: Merge #18962: net processing: Only send a getheaders for one block in an I...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d7489be8f77...553bb3fc3d95
< bitcoin-git> bitcoin/master 7467366 John Newbery: [net processing] Only send a getheaders for one block in an INV
< bitcoin-git> [bitcoin] laanwj merged pull request #18796: scripts: security-check.py refactors (master...security_check_no_more_32bit) https://github.com/bitcoin/bitcoin/pull/18796
< bitcoin-git> bitcoin/master 83d063e fanquake: scripts: add run_command to security-check.py
< bitcoin-git> bitcoin/master 13f606b fanquake: scripts: remove NONFATAL from security-check.py
< bitcoin-git> bitcoin/master 061acf6 fanquake: scripts: no-longer check for 32 bit windows in security-check.py
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4dd2e5255a7f...2d7489be8f77
< bitcoin-git> [bitcoin] laanwj merged pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
< bitcoin-git> bitcoin/master fa1f840 MarcoFalke: rpcwallet: Replace pwallet-> with wallet.
< bitcoin-git> bitcoin/master 4dd2e52 Wladimir J. van der Laan: Merge #18946: rpcwallet: Replace boost::optional<T>::emplace with simple a...
< bitcoin-git> bitcoin/master fa182a8 MarcoFalke: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T...
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b9c504cbc4ba...4dd2e5255a7f
< gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git> [bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/7d87ba0e0227...aa7c6858e6e4
< bitcoin-git> bitcoin/0.20 aa7c685 MarcoFalke: travis: Remove s390x
< bitcoin-git> bitcoin/0.20 7d87ba0 MarcoFalke: travis: Remove valgrind
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/5747c4ca1bf8...7d87ba0e0227
< wumpus> it's somewhat strange, but it's a by-effect of IPv4 addresses have always been encoded as a kind of IPv6 address in bitcoin
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
< gribble> https://github.com/bitcoin/bitcoin/issues/18757 | test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer by practicalswift · Pull Request #18757 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18287 | depends: Patch libevent build to fix IPv6 -rpcbind on Windows by luke-jr · Pull Request #18287 · bitcoin/bitcoin · GitHub
< jnewbery> fanquake: as long as it's not hiding and actual bugs that need to be backported. https://travis-ci.org/github/bitcoin/bitcoin/builds/686857580 do actually look like actual test failures rather than timeouts.
< gribble> https://github.com/bitcoin/bitcoin/issues/18899 | travis: Remove valgrind by MarcoFalke · Pull Request #18899 · bitcoin/bitcoin · GitHub
< jnewbery> theStack: I made some modifications to test_shell to connect to a running full node: https://github.com/jnewbery/bitcoin/tree/node-shell YMMV
< bitcoin-git> [bitcoin] fanquake merged pull request #18742: miner: Avoid stack-use-after-return in validationinterface (master...2004-minerNoCrash) https://github.com/bitcoin/bitcoin/pull/18742
< bitcoin-git> bitcoin/master fa5ceb2 MarcoFalke: test: Remove UninterruptibleSleep from test and replace it by SyncWithVali...
< bitcoin-git> bitcoin/master fab6d06 MarcoFalke: test: Add unregister_validation_interface_race test
< bitcoin-git> bitcoin/master fa770ce MarcoFalke: validationinterface: Rework documentation, Rename pwalletIn to callbacks
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/04c09553d898...b9c504cbc4ba
< gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974
< bitcoin-git> [bitcoin] elichai closed pull request #17953: refactor: Abstract boost::variant out (master...2020-01-variant) https://github.com/bitcoin/bitcoin/pull/17953
< bitcoin-git> [bitcoin] fanquake opened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
< bitcoin-git> [bitcoin] luke-jr opened pull request #18972: WIP: net: Add blockfilters white{bind,list} permission flag (master...neutrino_whitelist) https://github.com/bitcoin/bitcoin/pull/18972
< bitcoin-git> [bitcoin] achow101 opened pull request #18971: wallet: Refactor the classes in wallet/db.{cpp/h} (master...refactor-storage) https://github.com/bitcoin/bitcoin/pull/18971

2020-05-13

< bitcoin-git> [bitcoin] promag closed pull request #18791: wip: Only support shared validation interfaces (master...2020-04-only-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18791
< bitcoin-git> [bitcoin] laanwj merged pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887
< bitcoin-git> bitcoin/master 04c0955 Wladimir J. van der Laan: Merge #18887: build: enable -Werror=gnu
< bitcoin-git> bitcoin/master a30b0a2 Vasil Dimov: build: enable -Werror=gnu
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9a6d946e41b...04c09553d898
< gribble> https://github.com/bitcoin/bitcoin/issues/18742 | miner: Avoid stack-use-after-return in validationinterface by MarcoFalke · Pull Request #18742 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/master faa26d3 MarcoFalke: test: Remove RPCOverloadWrapper boilerplate
< bitcoin-git> bitcoin/master a9a6d94 MarcoFalke: Merge #18888: test: Remove RPCOverloadWrapper boilerplate
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51825aea7fa0...a9a6d946e41b
< bitcoin-git> bitcoin/master da16f95 Hennadii Stepanov: gui: Do not translate InitWarning messages in debug.log
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18922: gui: Do not translate InitWarning messages in debug.log (master...200509-initwarn) https://github.com/bitcoin/bitcoin/pull/18922
< bitcoin-git> bitcoin/master 4c9b9a4 Hennadii Stepanov: util: Enhance Join()
< bitcoin-git> bitcoin/master fe05dd0 Hennadii Stepanov: util: Enhance bilingual_str
< bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fc895d7700f9...51825aea7fa0
< bitcoin-git> [bitcoin] laanwj merged pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
< bitcoin-git> bitcoin/master 35f1189 Hennadii Stepanov: build: Rename BUILD_* macros and the code self-descriptive
< bitcoin-git> bitcoin/master dc1fba9 Hennadii Stepanov: scripted-diff: Rename share/genbuild.sh macros to more meaningful ones
< bitcoin-git> bitcoin/master 1e06bb6 Hennadii Stepanov: Drop unused CLIENT_VERSION_SUFFIX macro
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/5d18c0ae1827...fc895d7700f9
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
< bitcoin-git> [bitcoin] laanwj merged pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862
< bitcoin-git> bitcoin/master df6bde0 fanquake: test: remove glibc fdelt sanity check
< bitcoin-git> bitcoin/master 5d18c0a Wladimir J. van der Laan: Merge #18862: Remove fdelt_chk back-compat code and sanity check
< bitcoin-git> bitcoin/master 8bf1540 fanquake: build: remove fdelt_chk backwards compatibility code
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99c03728c07c...5d18c0ae1827
< gribble> https://github.com/bitcoin/bitcoin/issues/18878 | test: Add test for conflicted wallet tx notifications by ryanofsky · Pull Request #18878 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18965 | tests: implement base58_decode by 10xcryptodev · Pull Request #18965 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878
< bitcoin-git> bitcoin/master 99c0372 Wladimir J. van der Laan: Merge #18878: test: Add test for conflicted wallet tx notifications
< bitcoin-git> bitcoin/master f963a68 Russell Yanofsky: test: Add test for conflicted wallet tx notifications
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c647c89db28...99c03728c07c
< bitcoin-git> [bitcoin] fanquake merged pull request #18738: build: Suppress -Wdeprecated-copy warnings (master...200422-qt-warn) https://github.com/bitcoin/bitcoin/pull/18738
< bitcoin-git> bitcoin/master 6c647c8 fanquake: Merge #18738: build: Suppress -Wdeprecated-copy warnings
< bitcoin-git> bitcoin/master 0c63f80 Hennadii Stepanov: build: Suppress -Wdeprecated-copy warnings
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a33901cb6d82...6c647c89db28