2019-01-25

< bitcoin-git> bitcoin/master b09dab0 Akio Nakamura: Prevent mutex lock fail even if --enable-debug...
< bitcoin-git> bitcoin/master d14ef57 MarcoFalke: Merge #15233: Prevent mutex lock fail even if --enable-debug...
< bitcoin-git> [bitcoin] gkrizek opened pull request #15255: [tests] Remove travis_wait from lint script (master...remove-travis_wait) https://github.com/bitcoin/bitcoin/pull/15255
< bitcoin-git> [bitcoin] Empact closed pull request #15231: Drop defunct Windows compat fixes (master...ai-addrconfig) https://github.com/bitcoin/bitcoin/pull/15231
< bitcoin-git> [bitcoin] Empact opened pull request #15254: Trivial: fixup a few doxygen comments (master...doxygen-comments) https://github.com/bitcoin/bitcoin/pull/15254
< bitcoin-git> [bitcoin] Empact opened pull request #15253: Net: Consistently log outgoing INV messages (master...inv-log) https://github.com/bitcoin/bitcoin/pull/15253
< bitcoin-git> [bitcoin] fanquake opened pull request #15252: [0.17] Backport: Update zmq to 4.3.1 (0.17...017-backport-15188) https://github.com/bitcoin/bitcoin/pull/15252
< bitcoin-git> [bitcoin] fanquake opened pull request #15251: [0.17] doc: Remove errant paste from walletcreatefundedpsbt for nLocktime replaceable (0.17...017-backport-15213) https://github.com/bitcoin/bitcoin/pull/15251
< bitcoin-git> [bitcoin] sipa opened pull request #15250: Use RdSeed when available, and reduce RdRand load (master...201901_rdseed) https://github.com/bitcoin/bitcoin/pull/15250
< bitcoin-git> [bitcoin] Empact opened pull request #15249: Docs: Update python docs to reflect that wildcard imports are disallowed (master...wildcard-imports-doc) https://github.com/bitcoin/bitcoin/pull/15249
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15248: rpc: Compile on GCC4.8 (master...Mf1901-rpcCompileGCC48) https://github.com/bitcoin/bitcoin/pull/15248

2019-01-24

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
< meshcollider> sipa: I've been thinking about your comment here: https://github.com/bitcoin/bitcoin/pull/14491#discussion_r247192015
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15246: qa: Add tests for invalid message headers (master...Mf1901-qaMsgHeader) https://github.com/bitcoin/bitcoin/pull/15246
< bitcoin-git> [bitcoin] instagibbs opened pull request #15245: remove deprecated mentions of signrawtransaction from fundraw help (master...fundraw_signraw) https://github.com/bitcoin/bitcoin/pull/15245
< gmaxwell> I think it would be nice to even do more than what Bitcoin Core currently does.. but priorities, the sign/verify after generate is a pretty general protection at least.
< provoostenator> Even devices that don't have an official sign message feature, Bitcoin Core could just have it sign a fake transaction.
< provoostenator> "internally to bitcoin core is sign-after-generate" - I didn't know we did that, that seems smart.
< gmaxwell> right. Well we can only go so far too. :) But the standard we've set internally to bitcoin core is sign-after-generate.
< gmaxwell> Which is analogous to the process bitcoin uses internally when generating keys: it signs a message and verifies, to make sure that the generated address/key actually work.
< gmaxwell> Corruption inside bitcoin is also a concern, but a strictly less serious one than corruption by humans or across application boundaries.
< gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
< provoostenator> So we need something to replace xpub that has a better checksum? Or does that still data corruption risk? Because something goes wrong inside of Bitcoin Core during the import?
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14929 | net: Allow connections from misbehavior banned peers by gmaxwell · Pull Request #14929 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14929 | net: Allow connections from misbehavior banned peers by gmaxwell · Pull Request #14929 · bitcoin/bitcoin · GitHub
< jnewbery> 2. We're looking for recommendations for residents. If you know anyone who wants to immerse themselves in Bitcoin/Lightning over summer and is excited about making a real contribution to the project, please send them our way
< jnewbery> it's 2-3 weeks of seminars followed by 2 months of project work. We're expecting the residents to make really meaningful contributions to Bitcoin Core and other Bitcoin/Lightning projects while they're here
< gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15225 | GUI: Change the receive button to respond to keypool state changing by achow101 · Pull Request #15225 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15118 | Refactor block file logic by jimpo · Pull Request #15118 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15118 | Refactor block file logic by jimpo · Pull Request #15118 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15225 | GUI: Change the receive button to respond to keypool state changing by achow101 · Pull Request #15225 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15118 | Refactor block file logic by jimpo · Pull Request #15118 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] instagibbs opened pull request #15244: gdb attaching to process during tests has non-sudo solution (master...gdb_ptrace) https://github.com/bitcoin/bitcoin/pull/15244
< wumpus> seeing a lot of (ut)ACKs with commit ids that stay plain text, see e.g. https://github.com/bitcoin/bitcoin/pull/15112
< gribble> https://github.com/bitcoin/bitcoin/issues/15241 | travis: add --enable-debug macos build by kallewoof · Pull Request #15241 · bitcoin/bitcoin · GitHub
< provoostenator> Travis machine 10 cross compiles to bitcoin-x86_64-apple-darwin14, but that only compiles and doesn't run tests (obviously).
< gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15233 | Prevent mutex lock fail even if --enable-debug by AkioNak · Pull Request #15233 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15223 | Doc: add information about security to the JSON-RPC doc by harding · Pull Request #15223 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #15243: [doc] add notes on release notes (master...release_notes) https://github.com/bitcoin/bitcoin/pull/15243
< bitcoin-git> [bitcoin] laanwj closed pull request #15193: Default -whitelistforcerelay to off (master...2019-01-forcerelayoff) https://github.com/bitcoin/bitcoin/pull/15193
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5eb32d23841b...72bd4ab867e3
< bitcoin-git> bitcoin/master a36d97d Suhas Daftuar: Default -whitelistforcerelay to off
< bitcoin-git> bitcoin/master 72bd4ab Wladimir J. van der Laan: Merge #15193: Default -whitelistforcerelay to off...
< promag> lldb gives "frame #9: 0x000000010033d532 bitcoin-qt`(anonymous namespace)::RNGState::MixExtract(this=0x000000010269af80, out="", num=4335447936, hasher=0x00007ffeefbfc4d8, strong_seed=<unavailable>) at random.cpp:355 [opt]"
< gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15225 | GUI: Change the receive button to respond to keypool state changing by achow101 · Pull Request #15225 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #15223: Doc: add information about security to the JSON-RPC doc (master...2019-01-rpc-security) https://github.com/bitcoin/bitcoin/pull/15223
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/73a6bac9fffa...5eb32d23841b
< bitcoin-git> bitcoin/master 5a5ea93 David A. Harding: Doc: add information about security to the JSON-RPC doc
< bitcoin-git> bitcoin/master 5eb32d2 Wladimir J. van der Laan: Merge #15223: Doc: add information about security to the JSON-RPC doc...
< bitcoin-git> [bitcoin] kallewoof opened pull request #15241: travis: add --enable-debug macos build (master...travis-enable-debug-macos) https://github.com/bitcoin/bitcoin/pull/15241
< luke-jr> apparently since 2015, which wumpus closed with no explanation? https://github.com/bitcoin/bitcoin/issues/6628
< luke-jr> bitcoin-0.17.1/bin/bitcoin-qt: relocation error: bitcoin-0.17.1/bin/bitcoin-qt: symbol __chk_fail, version GLIBC_2.3.4 not defined in file libc.so.6 with link time reference
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15196: [test]: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/82cf6813a4ef...73a6bac9fffa
< bitcoin-git> bitcoin/master fdf82ba Graham Krizek: Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible...
< bitcoin-git> bitcoin/master 73a6bac Jonas Schnelli: Merge #15196: [test]: Update all subprocess.check_output functions to be Python 3.4 compatible...
< gribble> https://github.com/bitcoin/bitcoin/issues/15196 | [test]: Update all subprocess.check_output functions to be Python 3.4 compatible by gkrizek · Pull Request #15196 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13998 | Scripts and tools: gitian-build.py improvements and corrections by hebasto · Pull Request #13998 · bitcoin/bitcoin · GitHub

2019-01-23

< ryanofsky> i know specifying --prefix lets bitcoin autoconf find the "config.site" file generated by depends
< dongcarl> Question for people more knowledgeable about depends: in depends/README.md, it says that the way to use the results of calling `make` in depends for bitcoin is to do ./configure --prefix=`pwd`/depends/x86_64-w64-mingw32, but in our gitian descriptor we seem to use it like so: CONFIG_SITE=`pwd`/depends/x86_64-w64-mingw32/share/config.site ./configure --prefix=/. Is there a difference between the two?
< bitcoin-git> [bitcoin] hebasto opened pull request #15239: scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory (master...20190123-gitian-source-tarballs) https://github.com/bitcoin/bitcoin/pull/15239
< dongcarl> Can someone add https://github.com/bitcoin/bitcoin/pull/14856 to the P2P board?
< gribble> https://github.com/bitcoin/bitcoin/issues/11387 | net: remove more CConnman globals by theuni · Pull Request #11387 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] instagibbs opened pull request #15238: remove some magic mining constants in functional tests (master...magic_miner) https://github.com/bitcoin/bitcoin/pull/15238
< gribble> https://github.com/bitcoin/bitcoin/issues/14671 | Utility to replace RPC calls that dont need wallet or chain context · Issue #14671 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddresses RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #15236: scripts and tools: Make --setup command independent (master...20190123-gitian-build-setup) https://github.com/bitcoin/bitcoin/pull/15236
< bitcoin-git> [bitcoin] ken2812221 reopened pull request #14922: [WIP] windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
< bitcoin-git> [bitcoin] achow101 opened pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14353: REST: add blockhash call, fetch blockhash by height (master...2018/09/rest_blockhash) https://github.com/bitcoin/bitcoin/pull/14353
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/94167e2b5b7b...82cf6813a4ef
< bitcoin-git> bitcoin/master eb9ef04 Jonas Schnelli: REST: add "blockhashbyheight" call, fetch blockhash by height
< bitcoin-git> bitcoin/master 579d418 Jonas Schnelli: [QA] add rest tests for /rest/blockhashbyheight/<HEIGHT>.<FORMAT>
< bitcoin-git> bitcoin/master 42ff30e Jonas Schnelli: [Docs] add short documentation for /rest/blockhashbyheight
< bitcoin-git> [bitcoin] AkioNak opened pull request #15233: Prevent mutex lock fail even if --enable-debug (master...fix_mutex_lock_fail) https://github.com/bitcoin/bitcoin/pull/15233

2019-01-22

< bitcoin-git> [bitcoin] Empact opened pull request #15231: Drop defunct Windows LookupIntern exception (master...ai-addrconfig) https://github.com/bitcoin/bitcoin/pull/15231
< bitcoin-git> [bitcoin] laanwj closed pull request #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement (master...2019/01/macos_autostart) https://github.com/bitcoin/bitcoin/pull/15208
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bad1e0b22c1...94167e2b5b7b
< bitcoin-git> bitcoin/master 516437a Jonas Schnelli: Qt: remove macOS launch-at-startup option when compiled with > macOS 10.11
< bitcoin-git> bitcoin/master da60118 Jonas Schnelli: Fix macOS launch-at-startup memory issue
< bitcoin-git> bitcoin/master 94167e2 Wladimir J. van der Laan: Merge #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement...
< gribble> https://github.com/bitcoin/bitcoin/issues/15063 | GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing by luke-jr · Pull Request #15063 · bitcoin/bitcoin · GitHub
< wumpus> hm "2019-01-22 22:23:51 [ghi] Received repository 'bitcoin/bitcoin', but no pool is configured for it."
< gkrizek> wumpus is the bitcoin-git Nick registered (ie; needs a password)?
< wumpus> gkrizek: I've removed the github service from #bitcoin-commits, right setting up an account on my server to run ghi, and sure an example could be helpful :)
< bitcoin-git> [bitcoin] jamesob closed pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
< gkrizek> I was thinking it might be nice to add it as a webhook now and have it post to the #bitcoin-commits channel. That way we can test it out and see how it compares to the GitHub Service before it's EOL.
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
< booyah> oh I ment, maybe developers of Bitcoin, who use such vulnerable system
< bitcoin-git> [bitcoin] Sjors closed pull request #14938: Support creating an empty wallet (master...2018/12/create-empty-wallet) https://github.com/bitcoin/bitcoin/pull/14938
< gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto closed pull request #15220: Qt, Trivial: Refactor UI forms (master...20190120-form-ui-refactor) https://github.com/bitcoin/bitcoin/pull/15220
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub
< meshcollider> jonasschnelli: weird, in your github settings on the Authorized OAuth Apps page, does AppVeyor have access to read org and team membership, and the bitcoin org?
< bitcoin-git> [bitcoin] achow101 opened pull request #15226: Allow creating blank (empty) wallets (master...blank-wallets) https://github.com/bitcoin/bitcoin/pull/15226
< bitcoin-git> [bitcoin] Empact closed pull request #15221: lint: Bump flake8 to 3.6.0 (master...flake-36) https://github.com/bitcoin/bitcoin/pull/15221

2019-01-21

< bitcoin-git> [bitcoin] achow101 opened pull request #15225: GUI: Change the receive button to respond to keypool state changing (master...receive-button) https://github.com/bitcoin/bitcoin/pull/15225
< bitcoin-git> [bitcoin] sipa opened pull request #15224: Add RNG strengthening (10ms once every minute) (master...201901_rand_strengthen) https://github.com/bitcoin/bitcoin/pull/15224
< bitcoin-git> [bitcoin] harding opened pull request #15223: Doc: add information about security to the JSON-RPC doc (master...2019-01-rpc-security) https://github.com/bitcoin/bitcoin/pull/15223
< jonasschnelli> can someone restart https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/21780911 (or tell me how to do it)?
< bitcoin-git> [bitcoin] laanwj closed pull request #15219: lint: Enable python linters via an array (master...python-lint) https://github.com/bitcoin/bitcoin/pull/15219
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0c9e1c22b8a...9bad1e0b22c1
< bitcoin-git> bitcoin/master 948d8f4 Ben Woosley: lint: Enable python linters via an array...
< bitcoin-git> bitcoin/master 9bad1e0 Wladimir J. van der Laan: Merge #15219: lint: Enable python linters via an array...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e6b3b944d12...f0c9e1c22b8a
< bitcoin-git> bitcoin/master faf29dd lucash-dev: Minimal changes to comply with explicit CMutableTransaction -> CTranaction conversion....
< bitcoin-git> bitcoin/master b301950 lucash-dev: Made expicit constructor CTransaction(const CMutableTransaction &tx)....
< bitcoin-git> bitcoin/master f0c9e1c Wladimir J. van der Laan: Merge #14906: refactor: Make explicit CMutableTransaction -> CTransaction conversion....
< bitcoin-git> [bitcoin] laanwj closed pull request #14906: refactor: Make explicit CMutableTransaction -> CTransaction conversion. (master...explicit-CMutableTransaction-conversion) https://github.com/bitcoin/bitcoin/pull/14906
< bitcoin-git> [bitcoin] laanwj pushed 15 new commits to master: https://github.com/bitcoin/bitcoin/compare/ace87ea2b00a...6e6b3b944d12
< bitcoin-git> bitcoin/master 6a57ca9 Pieter Wuille: Use FRC::randbytes instead of reading >32 bytes from RNG...
< bitcoin-git> bitcoin/master 2d1cc50 Pieter Wuille: Don't log RandAddSeedPerfmon details...
< bitcoin-git> bitcoin/master 05fde14 Pieter Wuille: Automatically initialize RNG on first use.
< bitcoin-git> [bitcoin] laanwj closed pull request #14955: Switch all RNG code to the built-in PRNG (master...201812_generic_rand) https://github.com/bitcoin/bitcoin/pull/14955
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5baa9092c4b8...ace87ea2b00a
< bitcoin-git> bitcoin/master de7266f Stephan Oeste: [net] add dnsseed.emzy.de to DNS seeds
< bitcoin-git> bitcoin/master ace87ea Wladimir J. van der Laan: Merge #14970: [net] add dnsseed.emzy.de to DNS seeds...
< bitcoin-git> [bitcoin] laanwj closed pull request #14970: [net] add dnsseed.emzy.de to DNS seeds (master...dns-seed-emzy) https://github.com/bitcoin/bitcoin/pull/14970
< bitcoin-git> [bitcoin] laanwj pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f1576ab32c4...5baa9092c4b8
< bitcoin-git> bitcoin/master 7cc2b9f Cory Fields: net: Break disconnecting out of Ban()...
< bitcoin-git> bitcoin/master 136bd79 Cory Fields: tests: remove member connman/peerLogic in TestingSetup
< bitcoin-git> bitcoin/master 83c1ea2 Cory Fields: net: split up addresses/ban dumps in preparation for moving them
< bitcoin-git> [bitcoin] laanwj closed pull request #14605: Return of the Banman (master...banman) https://github.com/bitcoin/bitcoin/pull/14605
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/72506ed3491d...0f1576ab32c4
< bitcoin-git> bitcoin/master ca91661 Hennadii Stepanov: Fix wallet selector size adjustment
< bitcoin-git> bitcoin/master 0f1576a Wladimir J. van der Laan: Merge #15167: qt: Fix wallet selector size adjustment...
< bitcoin-git> [bitcoin] laanwj closed pull request #15167: qt: Fix wallet selector size adjustment (master...20190114-wallet-selector-size-adjust) https://github.com/bitcoin/bitcoin/pull/15167
< bitcoin-git> [bitcoin] laanwj closed pull request #15177: rest: Improve tests and documention of /headers and /block (master...2019-01-restheadersdoc) https://github.com/bitcoin/bitcoin/pull/15177
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9fa2b89ed1d7...72506ed3491d
< bitcoin-git> bitcoin/master be625f7 João Barbosa: doc: Explain empty result of /rest/headers
< bitcoin-git> bitcoin/master 0825b86 João Barbosa: doc: /rest/block responds with 404 if block does not exist
< bitcoin-git> bitcoin/master 7cf994d João Barbosa: qa: Improve tests of /rest/headers and /rest/block
< bitcoin-git> [bitcoin] laanwj closed pull request #15188: Update zmq to 4.3.1 (master...update-zmq) https://github.com/bitcoin/bitcoin/pull/15188
< bitcoin-git> bitcoin/master 6be52d6 Wladimir J. van der Laan: Merge #15213: doc: Remove errant paste from walletcreatefundedpsbt for nLocktime replaceable...
< bitcoin-git> [bitcoin] laanwj closed pull request #15213: doc: Remove errant paste from walletcreatefundedpsbt for nLocktime replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15213
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6be52d6f7e0d...9fa2b89ed1d7
< bitcoin-git> bitcoin/master 3046e5f Dimitris Apostolou: Update zmq to 4.3.1...
< bitcoin-git> bitcoin/master 9fa2b89 Wladimir J. van der Laan: Merge #15188: Update zmq to 4.3.1...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1522079d54cc...6be52d6f7e0d
< bitcoin-git> bitcoin/master 85f0ca9 Gregory Sanders: Remove errant past from walletcreatefundedpsbt for nLocktime replaceability
< gribble> https://github.com/bitcoin/bitcoin/issues/15196 | [test]: Update all subprocess.check_output functions to be Python 3.4 compatible by gkrizek · Pull Request #15196 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #15209: zmq: log outbound message high water mark when reusing socket (master...zmq-always-log-high-water-mark) https://github.com/bitcoin/bitcoin/pull/15209
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/978682b9dccf...7455ca2ae687
< bitcoin-git> bitcoin/master 1ed425e João Barbosa: gui: Fix window title update
< bitcoin-git> bitcoin/master 7455ca2 Wladimir J. van der Laan: Merge #15210: gui: Fix window title update...
< bitcoin-git> [bitcoin] laanwj closed pull request #15210: gui: Fix window title update (master...2019-01-fixwindowtitle) https://github.com/bitcoin/bitcoin/pull/15210
< stevenroose> In rust-bitcoin this somehow fails because of the segwit code that gets activated when the inputs are empty.
< bitcoin-git> [bitcoin] merland opened pull request #15222: Simplification of macOS build instructions (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15222
< echeveria> qpeng: this would be a better question for #bitcoin.
< qpeng> what is the way of bitcoin peer to peer work to find the other nodes?
< bitcoin-git> [bitcoin] Empact opened pull request #15221: lint: Bump flake8 to 3.6.0 (master...flake-36) https://github.com/bitcoin/bitcoin/pull/15221
< bitcoin-git> [bitcoin] hebasto opened pull request #15220: Qt, Trivial: Refactor UI forms (master...20190120-form-ui-refactor) https://github.com/bitcoin/bitcoin/pull/15220
< bitcoin-git> [bitcoin] Empact opened pull request #15219: lint: Enable python linters via an array (master...python-lint) https://github.com/bitcoin/bitcoin/pull/15219

2019-01-20

< bitcoin-git> [bitcoin] hebasto closed pull request #15217: Wallet: Remove "-Wunused-variable" warning while build with "--disable-wallet" option (master...20190120-unused-variable-warning) https://github.com/bitcoin/bitcoin/pull/15217
< bitcoin-git> [bitcoin] andrewtoth opened pull request #15218: validation: Flush state after initial sync (master...flush-after-ibd) https://github.com/bitcoin/bitcoin/pull/15218
< bitcoin-git> [bitcoin] hebasto opened pull request #15217: Wallet: Remove "-Wunused-variable" warning while build with "--disable-wallet" option (master...20190120-unused-variable-warning) https://github.com/bitcoin/bitcoin/pull/15217
< bitcoin-git> [bitcoin] hebasto opened pull request #15216: Scripts and tools: Replace script name with a special parameter (master...20190120-improve-shell-ux) https://github.com/bitcoin/bitcoin/pull/15216
< bitcoin-git> [bitcoin] laanwj closed pull request #15194: Add comment describing fDisconnect behavior (master...2019-01-add-fDisconnect-comment) https://github.com/bitcoin/bitcoin/pull/15194
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe60ee96e915...978682b9dccf
< bitcoin-git> bitcoin/master 5b4283c Carl Dong: Add comment describing fDisconnect behavior
< bitcoin-git> bitcoin/master 978682b Wladimir J. van der Laan: Merge #15194: Add comment describing fDisconnect behavior...
< bitcoin-git> [bitcoin] practicalswift opened pull request #15215: rpc: Use the return value of GetProxy(...) in GetNetworksInfo(). Mark GetProxy(...) with [[nodiscard]]. (master...getnetworkinfo-getproxy) https://github.com/bitcoin/bitcoin/pull/15215
< bitcoin-git> [bitcoin] instagibbs closed pull request #15179: doc: Slight clarity boost to SEQUENCE_LOCKTIME_DISABLE_FLAG (master...rel_lock_lang) https://github.com/bitcoin/bitcoin/pull/15179
< bitcoin-git> [bitcoin] practicalswift opened pull request #15214: Improve tests by checking for expected return values (master...check-return-values-in-tests) https://github.com/bitcoin/bitcoin/pull/15214
< bitcoin-git> [bitcoin] instagibbs opened pull request #15213: Remove errant past from walletcreatefundedpsbt for nLocktime replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15213
< bitcoin-git> [bitcoin] instagibbs closed pull request #15212: Remove errant paste from walletcreatefundedpsbt meant for replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15212
< bitcoin-git> [bitcoin] instagibbs opened pull request #15212: Remove errant paste from walletcreatefundedpsbt meant for replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15212
< booyah> and have compiler(s) compiler bitcoin into that IR, and have identical IR from them
< dongcarl> fanquake: For the part of completing reproducible builds of bitcoin with guix, I might write up some instrucitons to do so when I sort out the current sources of non-determinism (I think qt is the culprit right now)

2019-01-19

< * hebasto> can build Bitcoin Core against any Qt version for testing now: https://gist.github.com/hebasto/4c571f6b368ab2b0d75b94aaf4bb512a
< bitcoin-git> [bitcoin] promag opened pull request #15210: gui: Fix window title update (master...2019-01-fixwindowtitle) https://github.com/bitcoin/bitcoin/pull/15210
< bitcoin-git> [bitcoin] fanquake opened pull request #15209: zmq: log outbound message high water mark when reusing socket (master...zmq-always-log-high-water-mark) https://github.com/bitcoin/bitcoin/pull/15209
< bitcoin-git> bitcoin/master fe60ee9 Wladimir J. van der Laan: Merge #15186: rpc: remove duplicate solvable field from getaddressinfo...
< bitcoin-git> [bitcoin] laanwj closed pull request #15186: rpc: remove duplicate solvable field from getaddressinfo (master...duplicate-solvable-fields) https://github.com/bitcoin/bitcoin/pull/15186
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b59fa2ce8aa...fe60ee96e915
< bitcoin-git> bitcoin/master a2a6c8f fanquake: rpc: remove duplicate solvable field from getaddressinfo
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f55808ad6939...3b59fa2ce8aa
< bitcoin-git> bitcoin/master 979bc0c Hennadii Stepanov: Improve "help-console" message...
< bitcoin-git> bitcoin/master 3b59fa2 Wladimir J. van der Laan: Merge #15178: qt: Improve "help-console" message...
< bitcoin-git> [bitcoin] laanwj closed pull request #15178: qt: Improve "help-console" message (master...20190116-improve-help-console) https://github.com/bitcoin/bitcoin/pull/15178
< gribble> https://github.com/bitcoin/bitcoin/issues/15178 | qt: Improve "help-console" message by hebasto · Pull Request #15178 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11 (master...2019/01/macos_autostart) https://github.com/bitcoin/bitcoin/pull/15208
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15175: build: Drop macports support (master...drop-macports) https://github.com/bitcoin/bitcoin/pull/15175
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/63144335becb...f55808ad6939
< bitcoin-git> bitcoin/master 4e81438 Ben Woosley: build: Drop macports support...
< bitcoin-git> bitcoin/master f55808a Jonas Schnelli: Merge #15175: build: Drop macports support...
< sipa> coco: #bitcoin-wizards or so
< sipa> this channel is about development of the bitcoin core software, not wild redesigns

2019-01-18

< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15206: p2p: immediately disconnect on invalid net message checksum (master...2019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
< gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #13100: gui: Add dynamic wallets support (master...2018-04-ui-open-wallet) https://github.com/bitcoin/bitcoin/pull/13100
< promag> jnewbery: typo in "Add an "opem wallet" command in bitcoin-qt" 13059
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15101: gui: Add WalletController (master...2019-01-walletcontroller) https://github.com/bitcoin/bitcoin/pull/15101
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd42553b1178...63144335becb
< bitcoin-git> bitcoin/master cefb399 João Barbosa: gui: Use AutoConnection for WalletModel::unload signal
< bitcoin-git> bitcoin/master 8fa271f João Barbosa: gui: Add WalletController
< bitcoin-git> bitcoin/master 0dd9bde João Barbosa: gui: Refactor to use WalletController
< bitcoin-git> [bitcoin] jamesob opened pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
< bitcoin-git> [bitcoin] dooglus opened pull request #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) (master...fix-startup-crash) https://github.com/bitcoin/bitcoin/pull/15203
< rafalcpp> hi, how Bitcoin achieves deterministic builds of Qt client too?
< bitcoin-git> [bitcoin] DesWurstes closed pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
< bitcoin-git> [bitcoin] promag opened pull request #15202: gui: Add Close All Wallets action (master...2019-01-closeallwallets) https://github.com/bitcoin/bitcoin/pull/15202
< bitcoin-git> [bitcoin] practicalswift opened pull request #15201: net: Add missing cs_vNodes lock in CConnman::Stop(). Add missing locking annotation. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
< gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] DesWurstes opened pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
< gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
< wumpus> then, please file a bug report with as much info about the issue as possible: https://github.com/bitcoin/bitcoin/issues/new
< gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
< DeanGuss> Anybody happen to know why wallet.cpp shuts bitcoind down when encryptwallet rpc command is called? https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp line 676
< dufferzafar> okay, is it bitcoin-help? i saw this channel mentioned on slack, so came here
< wumpus> it's fine as long as you don't go arguing how bitcoin's P2P protocol works...
< wumpus> I think you need to read up on how your tooling is used with other TCP protocols, it's not really different for bitcoin
< dufferzafar> so, the ports 12192 & 12476 are the ones the two bitcoin processes (btc1 & btc2) are listening on
< dufferzafar> i'm doing some network measurement experiments on bitcoin
< dufferzafar> i have bitcoin daemons running on multiple machines
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197
< luke-jr> Alixe: this is not "talk to devs", it is "talk about development", and your question is not about development. some of us are in #bitcoin too
< sipa> #bitcoin
< Alixe> So I think mining hash power can't do anything because full nodes enforce consensus rules. But some people think governments or corporates can buy a lot of nodes to affect Bitcoin with having majority of full nodes. Is it possible?
< bitcoin-git> [bitcoin] gkrizek opened pull request #15196: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196
< bitcoin-git> [bitcoin] promag opened pull request #15195: gui: Add close wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195

2019-01-17

< bitcoin-git> [bitcoin] dongcarl opened pull request #15194: Add comment describing fDisconnect behavior (master...2019-01-add-fDisconnect-comment) https://github.com/bitcoin/bitcoin/pull/15194
< dongcarl> Any further review on https://github.com/bitcoin/bitcoin/pull/14605 ?
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15193: Default -whitelistforcelay to off (master...2019-01-forcerelayoff) https://github.com/bitcoin/bitcoin/pull/15193
< bitcoin-git> [bitcoin] practicalswift closed pull request #11652: Add missing locks: validation.cpp + related (master...init-and-validation-locks) https://github.com/bitcoin/bitcoin/pull/11652
< bitcoin-git> [bitcoin] practicalswift opened pull request #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache() and benchmarks/tests. Add annotations. (master...validation-cs_main) https://github.com/bitcoin/bitcoin/pull/15192
< gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15040: qt: Add workaround for QProgressDialog bug on macOS (master...20181226-fix-macos-qprogressdialog) https://github.com/bitcoin/bitcoin/pull/15040
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12b30105fc59...cd42553b1178
< bitcoin-git> bitcoin/master 7c572c4 Hennadii Stepanov: Add workaround for QProgressDialog bug on macOS...
< bitcoin-git> bitcoin/master cd42553 Jonas Schnelli: Merge #15040: qt: Add workaround for QProgressDialog bug on macOS...
< luke-jr> wumpus: fwiw, it's not exactly pretty, but I haven't had any problem reports from https://github.com/bitcoinknots/bitcoin/commit/8261704f7fec4e3879f2b018fc27eb8834e698a6 so far
< gribble> https://github.com/bitcoin/bitcoin/issues/15188 | Update zmq to 4.3.1 by rex4539 · Pull Request #15188 · bitcoin/bitcoin · GitHub
< gwillen> just replacing it with some kind of simple fixed notice with a pointer to the COPYING file, without varying years or names other than "the Bitcoin developers" or what have you
< bitcoin-git> [bitcoin] practicalswift closed pull request #15189: validation: Add missing lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189
< bitcoin-git> [bitcoin] practicalswift opened pull request #15191: validation: Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning. (master...cs_LastBlockFile) https://github.com/bitcoin/bitcoin/pull/15191
< sipa> gwillen: IANAL but i believe those copyright statements per file (and much less the year indications) are almost certainly worthless, especially when attributing to "The Bitcoin Core developers", which is not a legal entity
< bitcoin-git> [bitcoin] LifeIsPizza closed pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190
< bitcoin-git> [bitcoin] LifeIsPizza opened pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190
< bitcoin-git> [bitcoin] practicalswift opened pull request #15189: validation: Add missing cs_nBlockSequenceId lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189
< bitcoin-git> [bitcoin] practicalswift closed pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] rex4539 opened pull request #15188: Update zmq to 4.3.1 (master...update-zmq) https://github.com/bitcoin/bitcoin/pull/15188
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/003a47f804b1...12b30105fc59
< bitcoin-git> bitcoin/master 638e53b practicalswift: Pin shellcheck version to v0.6.0
< bitcoin-git> bitcoin/master 07a53dc practicalswift: Remove repeated suppression. Fix indentation.
< bitcoin-git> bitcoin/master 0b7196e practicalswift: Fix warnings introduced in shellcheck v0.6.0
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15166: qa: Pin shellcheck version (master...opt-out-of-new-shellcheck-warnings) https://github.com/bitcoin/bitcoin/pull/15166
< bitcoin-git> [bitcoin] practicalswift opened pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee604487f54...003a47f804b1
< bitcoin-git> bitcoin/master 31097b7 benthecarman: docs: Spelling error fix on fuzzing.md
< bitcoin-git> bitcoin/master 003a47f MarcoFalke: Merge #15185: docs: Spelling error fix on fuzzing.md...
< gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub