< kallewoof>
andytoshi: it seems to integrate really well with bitcoin core, from what i can tell so far. the old code was a split out thing of its own
< andytoshi>
kallewoof: no, i spent about 30 minutes on it :) the old spec was super straightforward (at least, with the existing rust-bitcoin/miniscript infrastructure i have)
< kallewoof>
andytoshi: hope you didn't spend too much time on your implementation. I have begun working on a rough implementation of BIP 322 support here, FYI: https://github.com/bitcoin/bitcoin/pull/20154
< bitcoin-git>
[bitcoin] S3RK opened pull request #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet (master...importdesc_silent_fail) https://github.com/bitcoin/bitcoin/pull/20153
< bitcoin-git>
[bitcoin] laanwj merged pull request #17775: DecodeHexTx: Try case where txn has inputs first (master...decode_wit_first) https://github.com/bitcoin/bitcoin/pull/17775
< bitcoin-git>
bitcoin/master 3956165 Wladimir J. van der Laan: Merge #17775: DecodeHexTx: Try case where txn has inputs first
< bitcoin-git>
bitcoin/master 27fc6a3 Gregory Sanders: DecodeHexTx: Break out transaction decoding logic into own function
< bitcoin-git>
bitcoin/master 6020ce3 Gregory Sanders: DecodeHexTx: Try case where txn has inputs first
< bitcoin-git>
[bitcoin] meshcollider merged pull request #19077: wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets (master...sqlite-wallet) https://github.com/bitcoin/bitcoin/pull/19077
< bitcoin-git>
bitcoin/master 7577b6e Andrew Chow: Add SQLiteDatabase and SQLiteBatch dummy classes
< bitcoin-git>
bitcoin/master e87df82 Andrew Chow: Add sqlite to travis and depends
< bitcoin-git>
bitcoin/master 54729f3 Andrew Chow: Add libsqlite3
< bitcoin-git>
[bitcoin] sipa opened pull request #20147: Update libsecp256k1 (endomorphism, test improvements) (master...202010_secp256k1) https://github.com/bitcoin/bitcoin/pull/20147
< wumpus>
bitcoin-commits did have secp256k1 notifications as far as I know? but don't know if it's still the case since github removed their own IRC notification
< jnewbery>
hmmm, #19988 is no longer showing up in my notifications stream in github. I can still open the PR and see it in the list of open bitcoin/bitcoin PRs
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20146: net: Send post-verack handshake messages at most once (master...2010-netPostVerackHandshake) https://github.com/bitcoin/bitcoin/pull/20146
< bitcoin-git>
[bitcoin] kallewoof opened pull request #20145: contrib: add getcoins.py script to get coins from (signet) faucet (master...202010-signet-getcoins) https://github.com/bitcoin/bitcoin/pull/20145
< jonatack>
pierre_rochard: thanks! i'm really happy to see you actively maintaining bitcoin-acks, and the new donation feature for PRs and review seems like a great initiative
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20137: tests: Update UBSan suppressions file with suppressions needed for clang 12 (current trunk) (master...clang-12-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20137
< aj>
generated by -- for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done and cat 19988_comments.? 19988_comments.?? | jq -r '.[] | (.user.login + " " + .path + ":" + ((.line//.original_line | tostring) // empty) + " " + (.created_at), .body, "--------------------------")' > 19988_COMMENTS.txt
< fanquake>
luke-jr: no idea what you're talking about. I was replying to "fanquake: why is 13478 linked from https://github.com/bitcoin/bitcoin/issues/20104 ? it doesn't have recent discussion like claimed"
< bitcoin-git>
[bitcoin] promag opened pull request #20125: rpc, wallet: Expose database format in getwalletinfo (master...2020-10-walletinfoformat) https://github.com/bitcoin/bitcoin/pull/20125
< ja>
luke-jr: when would an ack be necessary for marking 'obsolete'? i thought it would be analogous to 'final' which you seem to wait for an explicit ack for here: https://github.com/bitcoin/bips/pull/926
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20122: Make Assert(…) usable in all contexts. Make implicit assumptions explicit. (master...Assert) https://github.com/bitcoin/bitcoin/pull/20122
< bitcoin-git>
bitcoin/master 1d3ec2a Pieter Wuille: Support bypassing range check in ReadCompactSize
2020-10-10
< stevenroose>
jonatack: awesome :) yeah in rust-bitcoin it's been a u32 always AFAIK, but I was confused, my question didn't make much sense because as Pieter pointed out, the inv message can only have 32-byte hashes as there is no way to convey items of other lengths
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20112: test: Speed up wallet_resendwallettransactions with mockscheduler RPC (master...2010-testFasterMock) https://github.com/bitcoin/bitcoin/pull/20112
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
< bitcoin-git>
bitcoin/master 380705e MarcoFalke: Merge #20106: cirrus: Use kvm to avoid spurious CI failures in the default...
< bitcoin-git>
bitcoin/master faf2999 MarcoFalke: cirrus: Use kvm to avoid spurious CI failures in the default virtualizatio...
< sipa>
"Prominent among them is the discussion on what to call 1 billion Bitcoin, which symbol color to use for it, and when wallet clients should switch to it by default. "
< gribble>
https://github.com/bitcoin/bitcoin/issues/20050 | validation: Prune (in)direct g_chainman usage related to ::LookupBlockIndex (bundle 1) by dongcarl · Pull Request #20050 · bitcoin/bitcoin · GitHub
< aj>
wumpus: you pinged about moving https://github.com/users/ajtowns/projects/1 under bitcoin/ ; happy to, might be nice to move the automation into drahtbot at the same time
< gribble>
https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
< bitcoin-git>
bitcoin/master fae7a1c MarcoFalke: fuzz: Configure check for main function
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20027: Use mockable time everywhere in net_processing (master...202009_mockable_netproc) https://github.com/bitcoin/bitcoin/pull/20027
< bitcoin-git>
bitcoin/master 9dd4de2 MarcoFalke: Merge #20027: Use mockable time everywhere in net_processing
< bitcoin-git>
[bitcoin] achow101 opened pull request #20101: rpc: change no wallet loaded message to be clearer (master...better-no-wallet-error) https://github.com/bitcoin/bitcoin/pull/20101
< bitcoin-git>
[bitcoin] sanket1729 opened pull request #20100: split policy/error consensus codes for CLEANSTACK, MINAMALIF (master...minimal_if) https://github.com/bitcoin/bitcoin/pull/20100
2020-10-07
< gwillen>
this is possibly too long: "Wallet RPCs are disabled because no wallet is loaded. (NOTE: Bitcoin Core no longer creates a default wallet automatically. Load a wallet using `loadwallet`, or by running bitcoind with `-wallet`; or create a wallet with `createwallet`.)"
< wumpus>
aj: would it make sense to maintain that project board as part of the bitcoin/bitcoin repo? or do you prefer hosting it on your own repo
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20092: util: Do not use gArgs global in ArgsManager member functions (master...201006-gargs) https://github.com/bitcoin/bitcoin/pull/20092
< bitcoin-git>
bitcoin/master 283a73d MarcoFalke: Merge #20092: util: Do not use gArgs global in ArgsManager member function...
< bitcoin-git>
bitcoin/master d103484 Hennadii Stepanov: util: Do not use gArgs global in ArgsManager member functions
< bitcoin-git>
[bitcoin] achow101 opened pull request #20096: wallet: Remove WalletDatabase refcounting and enforce only one Batch access the database at a time (master...rm-bdb-refcount) https://github.com/bitcoin/bitcoin/pull/20096
< bitcoin-git>
[bitcoin] sipa merged pull request #20095: CI: Bump vcpkg commit ID to get new msys mirror list (master...vcpkg_commitid_bump) https://github.com/bitcoin/bitcoin/pull/20095
< bitcoin-git>
bitcoin/master d8cd7b1 Pieter Wuille: Merge #20095: CI: Bump vcpkg commit ID to get new msys mirror list
< bitcoin-git>
bitcoin/master c83155b Aaron Clauson: Bump vcpkg commit ID to get new msys mirror list
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #20095: CI: Bump vcpkg commit ID to get new msys mirror list (master...vcpkg_commitid_bump) https://github.com/bitcoin/bitcoin/pull/20095