< June 2025 >
Su Mo Tu We Th Fr Sa 1234567891011121314
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30
2025-01-30
<darosior>
Not everyone affected by the costs of adding more stuff get to say it in the review process. Plus the cost is dispersed among everyone, current and future contributors, whereas the benefits of "getting my stuff merged in Bitcoin Core" are concentrated.
<darosior>
sipa: It's not because something is being worked on and gets reviewed that it needs to live in Bitcoin Core.
<bitcoin-git>
[bitcoin] danielabrozzoni opened pull request #31767: rpc: Ensure -debug=0/none behaves consistently with -nodebug (master...debug_flag_consistency) https://github.com/bitcoin/bitcoin/pull/31767
<corebot>
https://github.com/bitcoin/bitcoin/issues/31407 | guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries by achow101 · Pull Request #31407 · bitcoin/bitcoin · GitHub
<jonatack>
Regarding the specific case of the GUI, getting funding for working on it has been a non-starter for years, perhaps somewha partially related to moving out of the bitcoin core repo
<corebot>
https://github.com/bitcoin/bitcoin/issues/31407 | guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries by achow101 · Pull Request #31407 · bitcoin/bitcoin · GitHub
<darosior>
TheCharlatan: thanks for asking, yes i think it would be nice if we all thought about "What should be the scope of the project", "What should be Bitcoin Core's mission", so we can get inputs from as many people as possible for this discussion
<darosior>
Bitcoin Core cannot be the "everything Bitcoin app" without also diluting priorities. Not doing anything about it is making this choice by default. Finally, defining a scope is not only about pruning stuff. It can also help us shift focus toward things we would see as in-scope but not making enough progress.
<bitcoin-git>
[bitcoin] hebasto opened pull request #31765: cmake: Install man pages for built targets only (master...250130-man-inst) https://github.com/bitcoin/bitcoin/pull/31765
<bitcoin-git>
[bitcoin] sr-gi opened pull request #31760: test: make sure we are on sync with a peer before checking if they have sent a message (master...2025-01-fix-p2p-orphan-halding-requests-check) https://github.com/bitcoin/bitcoin/pull/31760
<bitcoin-git>
[bitcoin] sr-gi opened pull request #31759: test: fixes p2p_ibd_txrelay wait time (master...2025-01-fix-p2p-ibd-txrelay-test) https://github.com/bitcoin/bitcoin/pull/31759
<bitcoin-git>
[bitcoin] jurraca opened pull request #31742: contrib: fix BUILDDIR in gen-bitcoin-conf script and gen-manpages.py (master...fix-builddir) https://github.com/bitcoin/bitcoin/pull/31742
<sipa>
i'm trying to add a new binary (just for experimentation, not something that ever needs to be PR'ed), i copied the {,src/}CMakeLists.txt logic for bitcoin-tx, and a new binary gets built which runs, but when i try to invoke any random.h function, i get this error:
<achow101>
lmk if there's other channels for bitcoin core where this bot would be useful, and if there's any other functionality that would be useful to add.
<corebot>
https://github.com/bitcoin/bips/issues/1695 | BIP373: Clarify where keys in MuSig fields may appear in the Taproot output by achow101 · Pull Request #1695 · bitcoin/bips · GitHub
<corebot>
https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] krishpranav opened pull request #31735: Fix compilation errors in blockchain.cpp related to serialization, UTXO dumping, and path conversion (master...master) https://github.com/bitcoin/bitcoin/pull/31735
<bitcoin-git>
[bitcoin] achow101 merged pull request #30322: test: raise an error in `_bulk_tx_` when `target_vsize` is too low (master...06-2024-fix_bulk_tx-with-low-weight) https://github.com/bitcoin/bitcoin/pull/30322
<bitcoin-git>
bitcoin/master 92787dd ismaelsadeeq: test: raise an error when target_vsize is below tx virtual size
<bitcoin-git>
bitcoin/master f6e8893 ismaelsadeeq: test: test that `create_self_transfer_multi` respects `target_vsize`
<bitcoin-git>
bitcoin/master a8780c9 ismaelsadeeq: test: raise an error if output value is <= 0 in `create_self_transfer`
<bitcoin-git>
[bitcoin] l0rinc closed pull request #31730: build: add `bitcoind-release` preset with only `BUILD_DAEMON` enabled with `release` build type (master...l0rinc/bitcoind-release-cmake-preset) https://github.com/bitcoin/bitcoin/pull/31730
<bitcoin-git>
[bitcoin] l0rinc opened pull request #31731: doc: update translation generation cmake example (master...l0rinc/dev-mode-translation-doc-fix) https://github.com/bitcoin/bitcoin/pull/31731
<bitcoin-git>
[bitcoin] l0rinc opened pull request #31730: build: add `bitcoind-release` preset with only `BUILD_DAEMON` enabled with `release` build type (master...l0rinc/bitcoind-release-cmake-preset) https://github.com/bitcoin/bitcoin/pull/31730
<bitcoin-git>
[bitcoin] Sjors closed pull request #28616: Show transactions as not fully confirmed during background validation (master...2023/10/assume-unconfirmed) https://github.com/bitcoin/bitcoin/pull/28616
<Sjors[m]>
If I have to maintain a node binary forever, then it makes no sense for me to use the more complicated IPC variant. That only makes sense as a temporary measure, if I'm sure eventually Bitcoin Core will ship it.
<Sjors[m]>
Bundling a custom Bitcoin Core with a sidecar makes no sense, it's just more complicated to install than the combined binary I've been shipping.
<Sjors[m]>
SRI is a Rust project, they're not going to release Bitcoin Core binaries I think.
<Sjors[m]>
It would basically say "Please install Bitcoin Core from X instead of the normal place", then install the sidecar app.
<darosior>
Exactly. It seems this is just not possible. Pools want the Bitcoin Core seal of approval because of our release standard. Breaking these standards to be able to release a binary is probably not a solution to get them to run it.
<Sjors[m]>
fanquake: if we vendor it, then we could guix build a bitcoin-node binary and ship that seperately?
<Sjors[m]>
I could do that myself, but it makes little sense for me to release two binaries myself: a Bitcoin Core IPC build + a Template Provider. Then it's easier for me to keep them combined.
<Sjors[m]>
darosior: getting a multiprocess binary released by the Bitcoin Core project in some way is the most useful. Can be seperate from the main release.
<fanquake>
sipa: I somewhat agree, if we have a longer term plan to actually do the process separation, in a way that gives the us the benefits of process separation. i.e currently, it's still a bitcoin-node process, if you don't care about wallet or gui etc
<darosior>
"I think it's perfectly fine if v29 still has bugs in it" - I don't feel very comfortable with the idea of Bitcoin Core releasing binaries that "may have bugs in them but it's fine".
<Sjors[m]>
Because people have to install Bitcoin Core binaries from some random guy (me).
<Sjors[m]>
fanquake: yes, it's partially a chicken-egg problem - without Bitcoin Core support Stratum v2 is dead on arrival
<gribble>
https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] hebasto opened pull request #31726: ci: Replace `CMAKE_CXX_FLAGS` with `APPEND_CXXFLAGS` (master...250123-ci-flags) https://github.com/bitcoin/bitcoin/pull/31726
<bitcoin-git>
[bitcoin] Sjors opened pull request #31725: test: clarify timewarp grace period griefing attack (master...2025/01/timewarp-grief) https://github.com/bitcoin/bitcoin/pull/31725
<bitcoin-git>
[bitcoin] fanquake merged pull request #31704: doc: add a section in the fuzzing documentation about using MSan (master...2501_doc_fuzz_msan) https://github.com/bitcoin/bitcoin/pull/31704
<bitcoin-git>
bitcoin/master 5c3e4d8 Antoine Poinsot: doc: add a section about using MSan
<bitcoin-git>
bitcoin/master 9914e73 merge-script: Merge bitcoin/bitcoin#31704: doc: add a section in the fuzzing documentati...
<bitcoin-git>
[bitcoin] fanquake merged pull request #31376: Miner: never create a template which exploits the timewarp bug (master...2411_miner_never_timewarp) https://github.com/bitcoin/bitcoin/pull/31376
<bitcoin-git>
bitcoin/master 59876b3 merge-script: Merge bitcoin/bitcoin#31376: Miner: never create a template which exploits...
<bitcoin-git>
bitcoin/master 733fa0b Antoine Poinsot: miner: never create a template which exploits the timewarp bug
<bitcoin-git>
[bitcoin] hebasto opened pull request #31722: cmake: Copy `cov_tool_wrapper.sh.in` to the build tree (master...250123-cmake-cov) https://github.com/bitcoin/bitcoin/pull/31722
<bitcoin-git>
[bitcoin] fanquake closed pull request #31619: ci: change the build to be verbose by default (master...ci_verbose_build) https://github.com/bitcoin/bitcoin/pull/31619
<bitcoin-git>
[bitcoin] tnndbtc opened pull request #31719: miniscript: fixes #29098 by only use first k valid signatures (master...fix-multi-sig-performance) https://github.com/bitcoin/bitcoin/pull/31719
<bitcoin-git>
[bitcoin] mzumsande opened pull request #31714: validation: Do less work in NeedsRedownload (master...202501_simpler_segwit_check) https://github.com/bitcoin/bitcoin/pull/31714
<bitcoin-git>
[bitcoin] ryanofsky merged pull request #31583: rpc: add target to getmininginfo field and show next block info (master...2024/12/gettarget) https://github.com/bitcoin/bitcoin/pull/31583
<bitcoin-git>
bitcoin/master 7ddbed4 Sjors Provoost: rpc: add nBits to getmininginfo
<bitcoin-git>
bitcoin/master ba7b9f3 Sjors Provoost: build: move pow and chain to bitcoin_common
<bitcoin-git>
bitcoin/master c4cc9e3 Sjors Provoost: consensus: add DeriveTarget() to pow.h
<bitcoin-git>
[bitcoin] theuni opened pull request #31711: build: set build type and per-build-type flags as early as possible (master...cmake-early-checks-flags) https://github.com/bitcoin/bitcoin/pull/31711
<bitcoin-git>
[bitcoin] ryanofsky merged pull request #31548: fuzz: Abort when global PRNG is used before SeedRand::ZEROS (master...2412-fuzz-abort-g-rng) https://github.com/bitcoin/bitcoin/pull/31548
<bitcoin-git>
bitcoin/master fa3c787 MarcoFalke: fuzz: Abort when global PRNG is used before SeedRand::ZEROS
<bitcoin-git>
bitcoin/master 78fa88c Ryan Ofsky: Merge bitcoin/bitcoin#31548: fuzz: Abort when global PRNG is used before S...
<bitcoin-git>
[bitcoin] hebasto opened pull request #31709: cmake: Fail if `Libmultiprocess` is missing when `WITH_MULTIPROCESS=ON` (master...250122-mp-error) https://github.com/bitcoin/bitcoin/pull/31709
<bitcoin-git>
[bitcoin] ryanofsky merged pull request #31490: refactor: inline `UndoWriteToDisk` and `WriteBlockToDisk` to reduce serialization calls (master...l0rinc/undo) https://github.com/bitcoin/bitcoin/pull/31490
<bitcoin-git>
[bitcoin] darosior opened pull request #31704: doc: add a section in the fuzzing documentation about using MSan (master...2501_doc_fuzz_msan) https://github.com/bitcoin/bitcoin/pull/31704
<bitcoin-git>
[bitcoin] maflcko opened pull request #31701: test: Bump sync_mempools timeout in p2p_1p1c_network.py (master...2501-test-fixup) https://github.com/bitcoin/bitcoin/pull/31701
<bitcoin-git>
[bitcoin] l0rinc opened pull request #31699: test,bench: validate `CheckTransaction`'s duplicate input detection in broader context (master...l0rinc/bench-processtransaction) https://github.com/bitcoin/bitcoin/pull/31699
<bitcoin-git>
[bitcoin] maflcko opened pull request #31696: test: Check that reindex with prune wipes blk files (master...2501-test-reindex-prune) https://github.com/bitcoin/bitcoin/pull/31696
<bitcoin-git>
[bitcoin] fanquake merged pull request #31590: descriptors: Try pubkeys of both parities when retrieving the private keys for an xonly pubkey in a descriptor (master...fix-constpubkey-xonly-getprivkey) https://github.com/bitcoin/bitcoin/pull/31590
<bitcoin-git>
bitcoin/master 092569e Ava Chow: descriptor: Try the other parity in ConstPubkeyProvider::GetPrivKey()