< October 2023 >
Su Mo Tu We Th Fr Sa 1234 5 6 7
8 9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30 31
2023-02-13
<bitcoin-git>
bitcoin/master 3a11adc John Moffett: Zero out wallet master key upon lock
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27093: test: Fix intermittent sync issue in wallet_pruning (master...2302-test-sync-int-🥈) https://github.com/bitcoin/bitcoin/pull/27093
<bitcoin-git>
[bitcoin] fanquake merged pull request #27016: mapport: require miniupnpc API version 17 or later (master...mostly_non_broken_upnp_verions) https://github.com/bitcoin/bitcoin/pull/27016
<bitcoin-git>
bitcoin/master 1ad0711 fanquake: Merge bitcoin/bitcoin#27016: mapport: require miniupnpc API version 17 or ...
<bitcoin-git>
bitcoin/master b3b673f fanquake: mapport: require miniupnpc API version 17 or later
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #27082: Minor edits - punctuation, spelling to make the contributing instructions more readable for all. (master...master) https://github.com/bitcoin/bitcoin/pull/27082
<montxero>
I am trying to run a bitcoin node and the download process has been stuck for over a week at ~56% verification progress. I am on a 12 core computer with 64 G ram. What can I do to make it work?
<bitcoin-git>
[bitcoin] davidgumberg opened pull request #27086: [WIP] p2p: Add random txn's from mempool to GETBLOCKTXN (master...wip-rndtxinclude) https://github.com/bitcoin/bitcoin/pull/27086
<bitcoin-git>
[bitcoin] TysonsTech opened pull request #27082: Minor edits - punctuation, spelling to make the contributing instructions more readable for all. (master...master) https://github.com/bitcoin/bitcoin/pull/27082
<bitcoin-git>
[bitcoin] john-moffett opened pull request #27080: Wallet: Zero out wallet master key upon locking so it doesn't persist in memory (master...2023_02_WipeMasterKeyOnLock) https://github.com/bitcoin/bitcoin/pull/27080
<gribble>
https://github.com/bitcoin/bitcoin/issues/25634 | wallet, tests: Expand and test when the blank wallet flag should be un/set by achow101 · Pull Request #25634 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] hebasto opened pull request #27077: ci: Make `ccache` hashing content of compiler binary (master...230210-ci-ccache) https://github.com/bitcoin/bitcoin/pull/27077
<bitcoin-git>
[bitcoin] achow101 opened pull request #27076: verify-commits: Bump trusted git root to after most recent laanwj merge (master...2023-02-vc-bump-trusted-root) https://github.com/bitcoin/bitcoin/pull/27076
<bitcoin-git>
[bitcoin] willcl-ark opened pull request #27073: Convert ArgsManager::GetDataDir to a read-only function (master...2022-02-cli-datadir) https://github.com/bitcoin/bitcoin/pull/27073
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #27063: ci: Use the latest Ubuntu LTS for "ARM64 Android APK" task (master...230208-ci-apk) https://github.com/bitcoin/bitcoin/pull/27063
<bitcoin-git>
bitcoin/master dc905f6 merge-script: Merge bitcoin/bitcoin#27063: ci: Use the latest Ubuntu LTS for "ARM64 Andr...
<bitcoin-git>
bitcoin/master 887bb53 Hennadii Stepanov: ci: Use the latest Ubuntu LTS for "ARM64 Android APK" task
2023-02-08
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27064: system: use %LOCALAPPDATA% as default datadir on windows (master...windows-local-datadir) https://github.com/bitcoin/bitcoin/pull/27064
<bitcoin-git>
[bitcoin] hebasto opened pull request #27063: ci: Use the latest Ubuntu LTS for "ARM64 Android APK" task (master...230208-ci-apk) https://github.com/bitcoin/bitcoin/pull/27063
<bitcoin-git>
[bitcoin] hebasto opened pull request #27062: ci: Use `GLOBAL_TASK_TEMPLATE` in "macOS 10.15" task (master...230208-ci-macos) https://github.com/bitcoin/bitcoin/pull/27062
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #27056: doc: use arch agnostic clang path in fuzzing doc (macOS) (master...macos_fuzzing_doc_arch_agnostic) https://github.com/bitcoin/bitcoin/pull/27056
<bitcoin-git>
bitcoin/master b49e19c fanquake: doc: use arch agnostic clang path in fuzzing doc (macOS)
<bitcoin-git>
bitcoin/master de1d189 MarcoFalke: Merge bitcoin/bitcoin#27056: doc: use arch agnostic clang path in fuzzing ...
<gribble>
https://github.com/bitcoin/bitcoin/issues/26350 | [22.x] Revert "build: Use Homebrews sqlite package if it is available" by fanquake · Pull Request #26350 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26507: test: remove unused vars in `feature_block` (master...2022-11-unused-feature-block-test) https://github.com/bitcoin/bitcoin/pull/26507
<bitcoin-git>
bitcoin/master 51d51d3 MarcoFalke: Merge bitcoin/bitcoin#26507: test: remove unused vars in `feature_block`
<bitcoin-git>
bitcoin/master 741c215 brunoerg: test: remove unused vars in `feature_block`
<bitcoin-git>
[bitcoin] achow101 opened pull request #27058: contrib: Improve verify-commits.py to work with maintainers leaving (master...improve-verify-commits) https://github.com/bitcoin/bitcoin/pull/27058
<bitcoin-git>
[bitcoin] fanquake opened pull request #27057: build: set boost cppflags with --enable-fuzz (master...still_set_boost_cppflags_when_enable_fuzz) https://github.com/bitcoin/bitcoin/pull/27057
<bitcoin-git>
[bitcoin] fanquake opened pull request #27056: doc: use arch agnostic clang path in fuzzing doc (macOS) (master...macos_fuzzing_doc_arch_agnostic) https://github.com/bitcoin/bitcoin/pull/27056
<bitcoin-git>
[gui] MarcoFalke merged pull request #697: Remove reindex special case from the progress bar label (master...2301-gui-reindex-👖) https://github.com/bitcoin-core/gui/pull/697
<bitcoin-git>
bitcoin/master faff2ba MarcoFalke: Remove reindex special case from the progress bar label
<bitcoin-git>
bitcoin/master 1bcabe6 MarcoFalke: Merge bitcoin-core/gui#697: Remove reindex special case from the progress ...
<bitcoin-git>
[bitcoin] fanquake merged pull request #17127: util: Set safe permissions for data directory and `wallets/` subdir (master...20191013-permissions) https://github.com/bitcoin/bitcoin/pull/17127
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26701: contrib: make DNS seeds file an argument in CLI (`makeseeds`) (master...2022-12-seeds-improv) https://github.com/bitcoin/bitcoin/pull/26701
<bitcoin-git>
bitcoin/master 5a80086 MarcoFalke: Merge bitcoin/bitcoin#26701: contrib: make DNS seeds file an argument in C...
<bitcoin-git>
bitcoin/master 1c07500 brunoerg: contrib: make DNS seeds file an argument in CLI
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27053: wallet: reuse change dest when re-creating TX with avoidpartialspends (master...change-addresses) https://github.com/bitcoin/bitcoin/pull/27053
<bitcoin-git>
[bitcoin] achow101 merged pull request #26345: refactor: modernize the implementation of uint256.* (master...refactor/uint256-modernize) https://github.com/bitcoin/bitcoin/pull/26345
<bitcoin-git>
bitcoin/master 52ddbd5 Andrew Chow: Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uin...
<bitcoin-git>
bitcoin/master 935acdc pasta: refactor: modernize the implementation of uint256.*
<bitcoin-git>
[bitcoin] LarryRuane opened pull request #27052: test: rpc: add last block announcement time to getpeerinfo result (master...2023-02-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/27052
<bitcoin-git>
[bitcoin] fanquake closed pull request #21319: RPC/Blockchain: Optimise getblock for simple disk-hex case (master...getblock_optimise) https://github.com/bitcoin/bitcoin/pull/21319
<bitcoin-git>
[bitcoin] fanquake closed pull request #25050: CValidationInterface: ValidationInterfaceUnregistering, called when being unregistered (master...validationIF_unregister) https://github.com/bitcoin/bitcoin/pull/25050
<bitcoin-git>
bitcoin/master 82f895d Martin Leitner-Ankerl: Update nanobench to version v4.3.10
<bitcoin-git>
[bitcoin] fanquake merged pull request #27009: validation: Skip VerifyDB checks of level =3 if dbcache is too small (master...202301_verifychain_assertfix) https://github.com/bitcoin/bitcoin/pull/27009
<bitcoin-git>
[gui] hebasto merged pull request #705: doc: Fix comment about how wallet txs are sorted (master...2023_01_FixIncorrectCommentTTM) https://github.com/bitcoin-core/gui/pull/705
<bitcoin-git>
[bitcoin] pinheadmz opened pull request #27039: blockstorage: do not flush block to disk if it is already there (master...reindex-read-only) https://github.com/bitcoin/bitcoin/pull/27039
<bitcoin-git>
[bitcoin] fanquake opened pull request #27038: security-check: test for `_FORTIFY_SOURCE` usage in release binaries (master...sec_check_fortify_source) https://github.com/bitcoin/bitcoin/pull/27038
<bitcoin-git>
[bitcoin] darosior opened pull request #27037: rpc: decode Miniscript descriptor when possible in decodescript (master...decodescript_miniscript) https://github.com/bitcoin/bitcoin/pull/27037
<bitcoin-git>
[bitcoin] john-moffett opened pull request #27036: test: Remove last uses of snprintf and simplify (master...2023_02_FixDBWrapperTest) https://github.com/bitcoin/bitcoin/pull/27036
<bitcoin-git>
[bitcoin] theStack opened pull request #27035: test: simplify and speedup mempool_updatefromblock.py by using MiniWallet (master...202302-test-use_MiniWallet_for_mempool_updatefromblock) https://github.com/bitcoin/bitcoin/pull/27035
<bitcoin-git>
[bitcoin] furszy opened pull request #27034: rpc: make importaddress compatible with descriptors wallet (master...2022_rpc_importaddress_descriptors_compatible) https://github.com/bitcoin/bitcoin/pull/27034
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26875: Tests: Fill out dust limit unit test for known types except bare multisig (master...add_dust_limits) https://github.com/bitcoin/bitcoin/pull/26875
<bitcoin-git>
bitcoin/master b093f56 Greg Sanders: Fill out dust limit unit test for known types except bare multisig
<bitcoin-git>
bitcoin/master aaa5597 MarcoFalke: Merge bitcoin/bitcoin#26875: Tests: Fill out dust limit unit test for know...
<hebasto>
as Ubuntu Bionic reaches "End of Standard Support" in April 2023, can we consider it is no longer supported as a build platform for Bitcoin Core v25+ ?
<bitcoin-git>
[bitcoin] hebasto closed pull request #24363: ci: Catch assertion error message into logs for test_bitcoin.exe (master...220216-assert) https://github.com/bitcoin/bitcoin/pull/24363
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27033: ci: Store depends in volume, not host folder (master...2302-ci-depends-vol-🏆) https://github.com/bitcoin/bitcoin/pull/27033
<sipa>
Maybe a bit more practical, do you expect that the txt range/asn map file will become part of the bitcoin core source repo? or just the combined binary dat file? or neither?
<fjahr>
but people can not expect Bitcoin core maintainers to do that work for them
<bitcoin-git>
[bitcoin] hebasto closed pull request #23609: build: Add -fvisibility=hidden flag for macOS host (master...211126-reduce) https://github.com/bitcoin/bitcoin/pull/23609
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #27028: ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks (master...2301-ci-cache-apt-🚴) https://github.com/bitcoin/bitcoin/pull/27028
<bitcoin-git>
[bitcoin] fanquake merged pull request #27012: ci: Print iwyu patch in git diff format (master...2302-ci-iwyu-git-diff-📖) https://github.com/bitcoin/bitcoin/pull/27012
<bitcoin-git>
bitcoin/master c2028f9 fanquake: Merge bitcoin/bitcoin#27012: ci: Print iwyu patch in git diff format
<fjahr>
And yeah, that was my understanding that we would work towards shipping a file with Bitcoin Core. Maybe in the first iteration it gets shipped with the release but it’s not used by default. However users could use the included file by just passing -asmap=1 and they don’t have to get the file from somewhere and provide it explicitly. I think that might be a good intermediate step. Of course they should still be able to
<bitcoin-git>
[bitcoin] Xekyo opened pull request #27021: Implement Mini version of BlockAssembler to calculate mining scores (master...add-mini-miner) https://github.com/bitcoin/bitcoin/pull/27021
<bitcoin-git>
[bitcoin] achow101 merged pull request #26910: wallet: migrate wallet, exit early if no legacy data exist (master...2022_wallet_prevent_descriptors_migration) https://github.com/bitcoin/bitcoin/pull/26910
<bitcoin-git>
bitcoin/master fdd363e Andrew Chow: Merge bitcoin/bitcoin#26910: wallet: migrate wallet, exit early if no lega...
<bitcoin-git>
bitcoin/master 6d31900 furszy: wallet: migrate wallet, exit early if no legacy data exist
<codo>
Does bitcoin-git detect when there is conversation and then keeps silent? Or is there no github activity because people are busy having the conversation?
<sipa>
Also, have you thought about how the data would (eventually) be included in Bitcoin Core? My thinking is that over time we'd perhaps just want it built into the binary, and that this built-in version would be used as default unless overridden. For auditability, that probably means a way to export the encoded asmap data, and/or RPCs to perform lookups in it.
<sipa>
I don't understand where the multimap idea fits in. I realize that there can be conflicting data, so there are multiple ASNs for a single IP range, but even if this were encodable in the asmap file format, how would Bitcoin Core use it? Unless there is a useful way to incorporate this information, my thinking is that you just need a deterministic mechanism for picking one of the options.
<gribble>
https://github.com/bitcoin/bitcoin/issues/27018 | mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool by glozow · Pull Request #27018 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] glozow opened pull request #27018: mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool (master...2023-01-flushandmine) https://github.com/bitcoin/bitcoin/pull/27018