< darosior>
wumpus: You want me to add a test for https://github.com/bitcoin/bitcoin/pull/17328 but I can't, on regtest the `verificationprogress` will always be 1, even when not synced..
< wumpus>
PSA: I've invited jonatack to the bitcoin and bitcoin-core orgs, seems a frequent enough contributor, also sipsorcery a few days ago (I was surprised the MSVC build maintainer wasn't in the org yet)
< bitcoin-git>
[bitcoin] laanwj merged pull request #17293: Add assertion to randrange that input is not 0 (master...assert-randrange) https://github.com/bitcoin/bitcoin/pull/17293
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17292: Add new mempool benchmarks for a complex pool (master...bench_mempool) https://github.com/bitcoin/bitcoin/pull/17292
< bitcoin-git>
[bitcoin] jnewbery closed pull request #16682: p2p: Disconnect peer that send us tx INVs when we opted out of tx relay (master...2019-08-disconnect-blocksonly-violators) https://github.com/bitcoin/bitcoin/pull/16682
< bitcoin-git>
bitcoin/master 59853c3 Hennadii Stepanov: test: Do not instantiate CAddrDB for static call
< bitcoin-git>
bitcoin/master 3f8d955 fanquake: Merge #17345: test: Do not instantiate CAddrDB for static call CAddrDB::Re...
< bitcoin-git>
[bitcoin] fanquake merged pull request #17345: test: Do not instantiate CAddrDB for static call CAddrDB::Read() (master...20191101-static-caddrdb-read) https://github.com/bitcoin/bitcoin/pull/17345
< bitcoin-git>
[bitcoin] fanquake closed pull request #17347: build:lint add "hist" to list of false positives (master...makeseeds-py) https://github.com/bitcoin/bitcoin/pull/17347
< bitcoin-git>
[bitcoin] RandyMcMillan opened pull request #17347: build:lint add "hist" to list of false positives (master...makeseeds-py) https://github.com/bitcoin/bitcoin/pull/17347
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #17346: Remove F401 (warning for unused imports) from lint-python.sh (master...2019-11-python-linter-sucks) https://github.com/bitcoin/bitcoin/pull/17346
< bitcoin-git>
[bitcoin] hebasto opened pull request #17345: test: Do not instantiate CAddrDB for static call CAddrDB::Read() (master...20191101-static-caddrdb-read) https://github.com/bitcoin/bitcoin/pull/17345
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15888: QA: Add wallet_implicitsegwit to test the ability to transform keys between address types (master...test_wallet_implicitsegwit) https://github.com/bitcoin/bitcoin/pull/15888
< bitcoin-git>
[bitcoin] jnewbery opened pull request #17340: Tests: speed up fundrawtransaction test (master...2019-11-speed-up-fundrawtransaction-test) https://github.com/bitcoin/bitcoin/pull/17340
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17218: Replace the LogPrint function with a macro (master...2019-10-log-print) https://github.com/bitcoin/bitcoin/pull/17218
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #17218: Replace the LogPrint function with a macro (master...2019-10-log-print) https://github.com/bitcoin/bitcoin/pull/17218
< bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #17218: Replace the LogPrint function with a macro (master...2019-10-log-print) https://github.com/bitcoin/bitcoin/pull/17218
< bitcoin-git>
[bitcoin] michaelfolkson opened pull request #17339: doc: Add template for good first issues (master...20191101-first-issue) https://github.com/bitcoin/bitcoin/pull/17339
< bitcoin-git>
[bitcoin] Rjected opened pull request #17336: scripts: search for first block file for linearize-data with some block files pruned (master...linearize) https://github.com/bitcoin/bitcoin/pull/17336
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #17335: Add test for syncing blocks generated after invalidateblock. (master...2019-10-invalid-mine-test) https://github.com/bitcoin/bitcoin/pull/17335
< jeremyrubin>
Here's a reductionist viewpoint: It's not worth jumping through too many hoops for apple users, because ultimately if the person shipping your kernel decides you don't want them running bitcoin, or a version of bitcoin, you're already, to put it lightly, fucked
< wumpus>
provoostenator: it would be a bad idea for bitcoin, so for bitcoin we should reject it
< cfields>
dongcarl: yes, and that's inevitible. Because we ARE bitcoin core. You know, the thing they're scanning their binaries for :)
< gribble>
https://github.com/bitcoin/bitcoin/issues/16974 | Walk pindexBestHeader back to ChainActive().Tip() if it is invalid by TheBlueMatt . Pull Request #16974 . bitcoin/bitcoin . GitHub
< bitcoin-git>
[bitcoin] sdaftuar opened pull request #17330: [qa] Add shrinkdebugfile=0 to regtest bitcoin.conf (master...2019-10-shrinkdebugfile0) https://github.com/bitcoin/bitcoin/pull/17330
< bitcoin-git>
[bitcoin] jnewbery opened pull request #17329: linter: Strip trailing / in path for git-subtree-check (master...2019-10-subtree-path) https://github.com/bitcoin/bitcoin/pull/17329
< bitcoin-git>
[bitcoin] darosior opened pull request #17328: GuessVerificationProgress: cap the ratio to 1 (master...fixup_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/17328
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17274: tests: Fix fuzzers eval_script and script_flags by re-adding ECCVerifyHandle dependency (master...fuzzer-initialization-follow-up) https://github.com/bitcoin/bitcoin/pull/17274
< bitcoin-git>
bitcoin/master 3b3b931 Carl Dong: nsis: Write to correct filename in first place
< bitcoin-git>
bitcoin/master feb1a8c Wladimir J. van der Laan: Merge #17308: nsis: Write to correct filename in first place
< bitcoin-git>
[bitcoin] laanwj merged pull request #17308: nsis: Write to correct filename in first place (master...2019-10-simplify-nsis-exe-rename) https://github.com/bitcoin/bitcoin/pull/17308
< bitcoin-git>
[bitcoin] fanquake merged pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
< bitcoin-git>
bitcoin/master d5dbb48 practicalswift: tests: Add fuzzing harness for ISO-8601 related functions
< bitcoin-git>
bitcoin/master 595cc9b practicalswift: docs: Add undefined to --with-sanitizers=fuzzer,address
< bitcoin-git>
bitcoin/master 341e8d3 MarcoFalke: Merge #17291: tests: Add fuzzing harness for ISO-8601 related functions
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17291: tests: Add fuzzing harness for ISO-8601 related functions (master...fuzzers-parse_iso8601) https://github.com/bitcoin/bitcoin/pull/17291
< bitcoin-git>
[bitcoin] adamjonas opened pull request #17318: replace asserts in RPC code with CHECK_NONFATAL and add linter (master...replace-rpc-asserts-for-CHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17318
< bitcoin-git>
[bitcoin] laanwj opened pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
< jtimon>
I've been rebasing a commit similar to https://github.com/bitcoin/bitcoin/pull/16681 for years (which is a bit annoying as new instances appeared) and people are still complaining because it is not complete and more instances may appear.
< bitcoin-git>
bitcoin/master f3b51eb Wladimir J. van der Laan: Fix occurences of c_str() used with size() to data()
< bitcoin-git>
bitcoin/master 5728f88 Wladimir J. van der Laan: Merge #17280: refactor: Change occurences of c_str() used with size() to d...
< bitcoin-git>
[bitcoin] laanwj merged pull request #17280: refactor: Change occurences of c_str() used with size() to data() (master...2019_10_c_str_size) https://github.com/bitcoin/bitcoin/pull/17280
< bitcoin-git>
bitcoin/master c1c6c41 Sebastian Falbesoner: test: add reason checks for non-standard txs in test_IsStandard
< bitcoin-git>
bitcoin/master ecad0a8 MarcoFalke: Merge #17299: test: add reason checks for non-standard txs in test_IsStand...
< bitcoin-git>
[bitcoin] fanquake opened pull request #17309: doc: update MSVC instructions to remove Qt OpenSSL linking (master...windows_notes_update) https://github.com/bitcoin/bitcoin/pull/17309
< bitcoin-git>
[bitcoin] dongcarl opened pull request #17308: nsis: Write to correct filename in first place (master...2019-10-simplify-nsis-exe-rename) https://github.com/bitcoin/bitcoin/pull/17308
< bitcoin-git>
[bitcoin] jtimon opened pull request #17306: Use name constants in chainparams initialization (master...b20-chain-constants) https://github.com/bitcoin/bitcoin/pull/17306
< bitcoin-git>
[bitcoin] achow101 opened pull request #17304: refactor: Move many functions into LegacyScriptPubKeyMan and further separate it from CWallet (master...wallet-box-pr-3) https://github.com/bitcoin/bitcoin/pull/17304
< gribble>
https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 . Pull Request #17261 . bitcoin/bitcoin . GitHub
< bitcoin-git>
[bitcoin] theStack opened pull request #17299: test: add reason checks for non-standard txs in test_IsStandard (master...20191029-test-also_check_reason_for_nonstd_txs) https://github.com/bitcoin/bitcoin/pull/17299
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (master...wallet-box-pr-1) https://github.com/bitcoin/bitcoin/pull/17260
< bitcoin-git>
[bitcoin] hebasto opened pull request #17297: refactor: Remove addrdb.h dependency from node.h (master...20191029-refactor-addrdb) https://github.com/bitcoin/bitcoin/pull/17297
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #17293: Add assertion to randrange that input is not 0 (master...assert-randrange) https://github.com/bitcoin/bitcoin/pull/17293
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #17292: Add new mempool benchmarks for a complex pool (master...bench_mempool) https://github.com/bitcoin/bitcoin/pull/17292
< bitcoin-git>
[bitcoin] practicalswift opened pull request #17291: tests: Add fuzzing harness for ISO-8601 related functions (master...fuzzers-parse_iso8601) https://github.com/bitcoin/bitcoin/pull/17291
< bitcoin-git>
[bitcoin] achow101 opened pull request #17290: Enable BnB coin selection for preset inputs and subtract fee from outputs (master...all-bnb) https://github.com/bitcoin/bitcoin/pull/17290
< gwillen>
13:24:54 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
< bitcoin-git>
[bitcoin] jachiang opened pull request #17288: Added TestWrapper class for interactive Python environments. (master...2019-10-testwrapper) https://github.com/bitcoin/bitcoin/pull/17288
< bitcoin-git>
[bitcoin] laanwj opened pull request #17280: Fix occurences of c_str() used with size() to data() (master...2019_10_c_str_size) https://github.com/bitcoin/bitcoin/pull/17280
< bitcoin-git>
[bitcoin] laanwj opened pull request #17279: refactor: Remove redundant c_str() calls in formatting (master...2019_10_redundant_c_str) https://github.com/bitcoin/bitcoin/pull/17279
< bitcoin-git>
bitcoin/master faeb666 MarcoFalke: util: Add CHECK_NONFATAL and use it in src/rpc
< bitcoin-git>
bitcoin/master 9ae468a Wladimir J. van der Laan: Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc
< bitcoin-git>
[bitcoin] laanwj merged pull request #17192: util: Add CHECK_NONFATAL and use it in src/rpc (master...1910-utilCHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17192