2020-12-13

< jonasschnelli> achow101: still getting dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< jonasschnelli> stat -c %s signed-app/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli> achow101: fatal error: /home/jonasschnelli/bitcoin-depends2/depends/x86_64-apple-darwin20/native/bin/x86_64-apple-darwin20-codesign_allocate: size for '-a x86_64 258611375' not a multiple of 16
< bitcoin-git> [bitcoin] sipa opened pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644
< jonasschnelli> still getting: dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< achow101> jonasschnelli: if you do "printf "\xfa\xde\x0c\xc0" | dd of=dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt bs=1 seek=26391600 count=4 conv=notrunc" and then try to sign, does it work?
< jonasschnelli> set -x tells me: + codesign -f --file-list sign.temp/signatures.txt -s Bitcoin dist/Bitcoin-Qt.app
< jonasschnelli> sipa: I ran ./detached-sig-create.sh but I guess the one that matter is the dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli> when calling ./detached-sig-create.sh -s "Bitcoin"
< jonasschnelli> dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< jonasschnelli> achow101: 6b2c9ac15da01cc4fa3951059fdf44c4eebd432288af6691ef94604f601b9ab9 bitcoin-6753b74195d8-osx-unsigned.tar.gz
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< harding> $ bitcoin-cli help scantxoutset | grep '"range"'
< harding> jamesob: sorry, I meant the derived address range, which I think non-Bitcoin Core software usually calls the gap limit.
< bitcoin-git> [bitcoin] hebasto opened pull request #20642: depends: Drop unneeded patches for qt package (master...201213-patch) https://github.com/bitcoin/bitcoin/pull/20642
< bitcoin-git> [bitcoin] hebasto opened pull request #20641: depends: Use Qt top-level build facilities (master...201213-top) https://github.com/bitcoin/bitcoin/pull/20641
< Talkless> Anyone using QtCreator to work with bitcoin core? It's code model does not find any of bitcoin core includes, all underlined. I've created project as Autotools.
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20639: doc: fix case of GitHub (master...fix-case-of-github) https://github.com/bitcoin/bitcoin/pull/20639
< bitcoin-git> [bitcoin] theStack opened pull request #20640: wallet, refactor: return out-params of CreateTransaction() as optional struct (master...202012-refactor-wallet-createtransaction-return_out_params_in_optstruct) https://github.com/bitcoin/bitcoin/pull/20640
< bitcoin-git> [bitcoin] fanquake merged pull request #20588: Remove unused and confusing CTransaction constructor (master...2012-txConstructor) https://github.com/bitcoin/bitcoin/pull/20588
< bitcoin-git> bitcoin/master ade38b6 fanquake: Merge #20588: Remove unused and confusing CTransaction constructor
< bitcoin-git> bitcoin/master fac39c1 MarcoFalke: wallet: document that tx in CreateTransaction is purely an out-param
< bitcoin-git> bitcoin/master faac315 MarcoFalke: Remove unused and confusing CTransaction constructor
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b18978066d87...ade38b6ee8f9
< gribble> https://github.com/bitcoin/bitcoin/issues/20638 | Mac codesign fixed alloc by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< fanquake> By Bitcoin-Qt I mean: Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< fanquake> It seems like macOS will only stop you from opening the .app though. You can still run Bitcoin-Qt with an invalid signature
< achow101> fanquake: do "codesign -v Bitcoin-Qt.app"
< achow101> I see there are 3 embedded certs: Apple, Devloper ID Certification Authority, and Bitcoin Core Code Signing Association

2020-12-12

< sipa> $ file Bitcoin-Qt.sign
< sipa> Bitcoin-Qt.sign: Mac OS X Detached Code Signature (non-executable) - 216249 bytes
< achow101> sipa: in the bitcoin-detached-sigs repo osx/dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt.sign
< sipa> wumpus: sounds similar to bitcoin's use of a sighash byte
< achow101> The hash is Bitcoin-Qt.app/Contents
< achow101> one of the hashes is of the file Bitcoin-Qt.app/Contents/_CodeSignature/CodeResources, and the other is Bitcoin-Qt.app/Contents/Info.plist
< bitcoin-git> [bitcoin] jbampton opened pull request #20639: doc: fix case of GitHub (master...fix-case-of-github) https://github.com/bitcoin/bitcoin/pull/20639
< achow101> 26891600 Dec 12 11:40 Bitcoin-Qt
< bitcoin-git> [bitcoin] achow101 opened pull request #20638: Mac codesign fixed alloc (master...mac-codesign-fixed-alloc) https://github.com/bitcoin/bitcoin/pull/20638
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20079: p2p: Treat handshake misbehavior like unknown message (master...2010-p2pNoVersion) https://github.com/bitcoin/bitcoin/pull/20079
< bitcoin-git> bitcoin/master b189780 MarcoFalke: Merge #20079: p2p: Treat handshake misbehavior like unknown message
< bitcoin-git> bitcoin/master faaad1b MarcoFalke: p2p: Ignore version msgs after initial version msg
< bitcoin-git> bitcoin/master fad68af MarcoFalke: p2p: Ignore non-version msgs before version msg
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ffc4d0499020...b18978066d87
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20275: wallet: List all wallets in non-SQLite and non-BDB builds (master...pr/exist) https://github.com/bitcoin/bitcoin/pull/20275
< bitcoin-git> bitcoin/master 6a7a636 Russell Yanofsky: refactor: Drop call to GetWalletEnv in wallet salvage code
< bitcoin-git> bitcoin/master 6ee9cbd Russell Yanofsky: refactor: Replace ListWalletDir() function with ListDatabases()
< bitcoin-git> bitcoin/master 5aaeb6c Russell Yanofsky: MOVEONLY: Move IsBDBFile, IsSQLiteFile, and ListWalletDir
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6a4806367177...ffc4d0499020
< jonasschnelli> and if anyone wants to test 0.20.2rc1, I just created the detached signature (no gitian build yet): https://bitcoin.jonasschnelli.ch/signature-osx_0.20.2rc1.tar.gz
< jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-0.21.0rc3-osx-unsigned-again-pagesize0.zip <--- signed with pagesize 0, check that is was not already codesigned
< jonasschnelli> sipa: jonasschnelli staff 18496 12 Dez 08:10 Bitcoin-Qt.sign
< jonasschnelli> sipa: okay... I executed "./detached-sig-create.sh -s "Bitcoin" --pagesize 0"
< bitcoin-git> [bitcoin] pox opened pull request #20635: fix misleading comment about call to non-existing function (master...master) https://github.com/bitcoin/bitcoin/pull/20635
< sipa> if you run "codesign_allocate -i <gitian Bitcoin-Qt filename> -a x86_64 $((225312+1024)) -o <newname>" in linux, does the resulting binary work in macos?
< sipa> codesign_allocate -i <unsigned Bitcoin-Qt filename> -a x86_64 $((225312+1024)) -o <some temp file>
< gribble> https://github.com/bitcoin/bitcoin/issues/67 | does not compile with boost_1_45_0 on OS X 10.6 · Issue #67 · bitcoin/bitcoin · GitHub
< achow101> of which version of Bitcoin-Qt
< sipa> what is the full output from that x86_64-apple-darwin-otool -l Bitcoin-Qt command?

2020-12-11

< sipa> achow101: if you run "codesign_allocate -i <unsigned Bitcoin-Qt filename> -a x86_64 225312 -o <some temp file>
< sipa> if you run "pagestuff -p Bitcoin-Qt | tail -2 | grep size | sed 's/[^0-9]*//g'", what do you get?
< sipa> yeah, what if you run that on the unsigned Bitcoin-Qt binary?
< sipa> x86_64-apple-darwin-otool -l Bitcoin-Qt
< achow101> x86_64-apple-darwin-otool -l Bitcoin-Qt for segment "__LINKEDIT" says "vmsize 0x000000000007b000" but on the other it's "vmsize 0x000000000007c000"
< achow101> the gitian result is https://bitcoin.jonasschnelli.ch/bitcoin-osx-signed3.dmg which comes from gitian builder combining the unsigned with the signature.tar.gz from the above zip
< achow101> the results from https://bitcoin.jonasschnelli.ch/bitcoin-osx-unsigned-nowsigned.zip which come from the signing process. it contains a fully signed binary
< jonasschnelli> my local signed and detached signature directory: https://bitcoin.jonasschnelli.ch/bitcoin-osx-unsigned-nowsigned.zip
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #20630: Allow providing local signatures in gitian osx signer (master...2020/12/macos_gitian_signer) https://github.com/bitcoin/bitcoin/pull/20630
< jonasschnelli> AFAIK 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 was the unsigned tarball (bitcoin-osx-unsigned.tar.gz)
< sipa> of bitcoin core?
< jonasschnelli> * /Volumes/Bitcoin-Core 4/Bitcoin-Qt.app: invalid signature (code or signature have been modified)
< jonasschnelli> ./detached-sig-create.sh -s "Bitcoin"
< jonasschnelli> verified code-signature codesign -v dist/Bitcoin-Qt.app
< jonasschnelli> I have downloaded again 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-osx-unsigned.tar.gz ...
< bitcoin-git> [bitcoin] dongcarl opened pull request #20629: depends: Improve id string robustness (master...2020-12-improve-depends-id-string) https://github.com/bitcoin/bitcoin/pull/20629
< jonasschnelli> I do that for bitcoin=
< luke-jr> jonasschnelli: -u bitcoin=/path/to/local/bitcoin
< jonasschnelli> but AFAIK the signer always pulls https://github.com/bitcoin-core/bitcoin-detached-sigs.git?
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #20628: Владелец (master...patch-10) https://github.com/bitcoin/bitcoin/pull/20628
< bitcoin-git> [bitcoin] vova557 opened pull request #20628: Владелец (master...patch-10) https://github.com/bitcoin/bitcoin/pull/20628
< jonasschnelli> the build log from the signer was actually a full macOS unsigned build: https://bitcoin.jonasschnelli.ch/gitian/builds/358/build_osx_signer.log (for whatever reason)
< jonasschnelli> my first gitian build went somehow wrong: https://bitcoin.jonasschnelli.ch/gitian/build/358
< jonasschnelli> luke-jr: 46cfa036d365d69db2a3b78377621d6b214f2d78f3082f9c7ebd7a9b89cfc599 is here -> https://bitcoin.jonasschnelli.ch/gitian/build/360
< jonasschnelli> I have verified the signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz and it works
< jonasschnelli> I double checked and I can confirm that I have signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< jonasschnelli> but I signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< jonasschnelli> But yes,... 46cfa036d365d69db2a3b78377621d6b214f2d78f3082f9c7ebd7a9b89cfc599 bitcoin-osx-signed.dmg has an invalid code signature
< jonasschnelli> I got 998dddf3c0f9b568fc0c39e61e3d61d2843dfb968016b7ceaf23aca94ace2542 bitcoin-osx-signed.dmg as the only one
< jonasschnelli> I codesigned 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< prusnak> Big Sur says Bitcoin Core installed from bitcoin-0.21.0rc3-osx.dmg is broken and should be moved to the bin; that said this happens on M1 system, so maybe on x86-64 it's fine
< jonasschnelli> Someone, my old (invalid) build has different bitcoin-osx-unsigned.tar.gz as input
< jonasschnelli> Old build (the one I pushed to gitian.signs): https://bitcoin.jonasschnelli.ch/gitian/build/358
< bitcoin-git> [bitcoin] ryanofsky closed pull request #19195: wallet: ScanForWalletTransactions cleanup (master...2020-06-06-scanforwallettransactions-cleanup) https://github.com/bitcoin/bitcoin/pull/19195
< aj> meanwhile regtest is kind-of bitcoin-core specific, and there's no point having wallets work with it
< wumpus> this is the best reference of course: https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki
< michaelfolkson> This is the context on why testnet and signet both start tb https://github.com/bitcoin/bitcoin/pull/18267#discussion_r491150895
< michaelfolkson> bech32 addresses start with bc representing Bitcoin and then 1 which is just a separator
< bitcoin-git> [bitcoin] jnewbery opened pull request #20624: net processing: Remove nStartingHeight check from block relay (master...2020-12-remove-starting-height) https://github.com/bitcoin/bitcoin/pull/20624
< bitcoin-git> [bitcoin] fanquake closed pull request #20623: Create msbuild.yml (master...master) https://github.com/bitcoin/bitcoin/pull/20623
< bitcoin-git> [bitcoin] Psyruss77 opened pull request #20623: Create msbuild.yml (master...master) https://github.com/bitcoin/bitcoin/pull/20623
< wumpus> at the least it'd need to rescan *all* `blk*` files, not stop when one is missing and delete the rest, e.g. get rid of this sledgehammer: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L658
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19858: Periodically make block-relay connections and sync headers (master...2020-08-blocks-only-rotation) https://github.com/bitcoin/bitcoin/pull/19858
< bitcoin-git> bitcoin/master daffaf0 Suhas Daftuar: Periodically make block-relay connections and sync headers
< bitcoin-git> bitcoin/master 3cc8a7a Suhas Daftuar: Use conn_type to identify block-relay peers, rather than m_tx_relay == nul...
< bitcoin-git> bitcoin/master 91d6195 Suhas Daftuar: Simplify and clarify extra outbound peer counting
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/736eb4d80838...6a4806367177
< mj_node> #bitcoin i mean...
< mj_node> @wumpus sorry for that, and I will make sure to go to #bitcoin-core-dev
< wumpus> in any case, this isn't a support channel, unless you're doing development and having questions about the code for that reason this is not the place, use #bitcoin next time
< jonasschnelli> macOS gitian build on master seems to fail: https://bitcoin.jonasschnelli.ch/gitian/build/359
< gribble> https://github.com/bitcoin/bitcoin/issues/20467 | Move travis linter job to cirrus · Issue #20467 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #19982: test: Fix inconsistent lock order in wallet_tests/CreateWallet (master...200920-leave-cs) https://github.com/bitcoin/bitcoin/pull/19982
< bitcoin-git> bitcoin/master e1e68b6 Hennadii Stepanov: test: Fix inconsistent lock order in wallet_tests/CreateWallet
< bitcoin-git> bitcoin/master cb23fe0 Hennadii Stepanov: [skip ci] sync: Check precondition in LEAVE_CRITICAL_SECTION() macro
< bitcoin-git> bitcoin/master c5e3e74 Hennadii Stepanov: sync: Improve CheckLastCritical()
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/da957cd62ecc...736eb4d80838
< bitcoin-git> [bitcoin] dongcarl opened pull request #20619: guix: Quality of life improvements (master...2020-12-guix-fixups) https://github.com/bitcoin/bitcoin/pull/20619

2020-12-10

< luke-jr> hebasto: promag: care to re-review https://github.com/bitcoin-core/gui/pull/125 - 2 ACKs, would be nice to get it in so I can move on to https://github.com/bitcoin-core/gui/pull/149 :P
< bitcoin-git> [gui] luke-jr opened pull request #149: Intro: Have user choose assumevalid (master...intro_assumevalid) https://github.com/bitcoin-core/gui/pull/149
< achow101> luke-jr: jonasschnelli results are at https://bitcoin.jonasschnelli.ch/gitian/build/358
< jonasschnelli> e72a9059a206a822fc02d7d304992a23acb9355fbf7b3b94353839075532bd5f bitcoin-0.21.0rc3-win-unsigned.tar.gz
< jonasschnelli> achow101: 0.21.0rc3 macOS sigs are up (hash matches with yours and hebasto's): https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21
< bitcoin-git> [bitcoin] laanwj pushed tag v0.20.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.20.2rc1
< bitcoin-git> [bitcoin] laanwj pushed tag v0.19.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.2rc1
< gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.19 e301a9f Wladimir J. van der Laan: doc: Pre-rc1 manual pages update
< bitcoin-git> bitcoin/0.19 f8d2a04 Wladimir J. van der Laan: gui: Pre-rc1 translations update
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/5f2f304cbec9...e301a9fde351
< bitcoin-git> bitcoin/0.20 a4bc4c1 Wladimir J. van der Laan: doc: Update manual pages pre-rc1
< bitcoin-git> bitcoin/0.20 98c9d79 Wladimir J. van der Laan: gui: Pre-rc1 translations update
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/2808593b7c8c...a4bc4c1f79d7
< jonasschnelli> luke-jr: macOS builds are fast (my script does that first): https://bitcoin.jonasschnelli.ch/gitian/build/358
< jonasschnelli> bb8c59034420709cdbae2e47ec1a1dce03c68ab4142ff3b67a23c415e6557be1 bitcoin-0.21.0rc3-osx-unsigned.dmg
< jonasschnelli> then probably: ./gitian-build.py --setup (see https://github.com/bitcoin-core/docs/blob/master/gitian-building.md)
< bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc3
< bitcoin-git> bitcoin/0.20 2808593 Wladimir J. van der Laan: build: Bump version to 0.20.2rc1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/953dddbd2058...2808593b7c8c
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< core-meetingbot> Meeting started Thu Dec 10 19:26:15 2020 UTC. The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< bitcoin-git> bitcoin/0.19 5f2f304 Wladimir J. van der Laan: build: Bump version to 0.19.2rc1
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/5baaea4410a1...5f2f304cbec9
< wumpus> Murch: yes a bit of a inside joke there was some discussion about bitcoin units again on twitter
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
< bitcoin-git> bitcoin/0.20 953dddb MarcoFalke: Merge #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction
< bitcoin-git> bitcoin/0.20 6a326cf Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
< bitcoin-git> bitcoin/0.20 2d48d7d Andrew Chow: Simplify and fix CWallet::SignTransaction
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/75bf23d8613a...953dddbd2058
< gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub
< wumpus> no proposed topics for this week on http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
< bitcoin-git> bitcoin/0.21 9ae536d Wladimir J. van der Laan: build: Bump RC to rc3
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/e6d0fa3ef6f6...9ae536d3684e
< wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< bitcoin-git> bitcoin/0.21 e6d0fa3 Wladimir J. van der Laan: gui: pre-rc3 translations update
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/3fee499bc3af...e6d0fa3ef6f6
< bitcoin-git> [bitcoin] hebasto closed pull request #19882: depends: Export variables from make to environment explicitly (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
< bitcoin-git> [bitcoin] laanwj merged pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
< bitcoin-git> bitcoin/0.21 06c8423 Jon Atack: wallet, bugfix: allow send to take string fee rate values
< bitcoin-git> bitcoin/0.21 bead935 Pieter Wuille: Send and require SENDADDRV2 before VERACK
< bitcoin-git> bitcoin/0.21 9e80688 Pieter Wuille: Don't send 'sendaddrv2' to pre-70016 software
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/aa4b8ebfecdd...3fee499bc3af
< bitcoin-git> [bitcoin] ariard opened pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
< bitcoin-git> bitcoin/master da957cd MarcoFalke: Merge #20613: test: Use Popen.wait instead of RPC in assert_start_raises_i...
< bitcoin-git> bitcoin/master fa918dd MarcoFalke: test: Use Popen.wait instead of RPC in assert_start_raises_init_error
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b76abae387b9...da957cd62ecc
< bitcoin-git> [bitcoin] lontivero opened pull request #20616: Check CJDNS address is valid (master...validate-cjdns-addresses) https://github.com/bitcoin/bitcoin/pull/20616
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615
< queip> the "score" field in getnetworkinfo, what does it actually mean? we are confused about it trying to provide support to user in #bitcoin . Could RPC help xxx command include short explanation for the outputed JSON fields for most commands?
< bitcoin-git> [bitcoin] Sjors opened pull request #20614: util: RunCommandParseJSON followups (master...2020/12/build-aux) https://github.com/bitcoin/bitcoin/pull/20614
< bitcoin-git> [bitcoin] laanwj merged pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587
< bitcoin-git> bitcoin/master b76abae Wladimir J. van der Laan: Merge #20587: [doc] Tidy up Tor doc (more stringent)
< bitcoin-git> bitcoin/master 32045bb wodry: [doc] Tidy up Tor doc (more stringent)
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86f20071931b...b76abae387b9
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< hebasto> promag: the combined branch for qml static builds https://github.com/hebasto/bitcoin/commits/201210-qml
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #20527: build: Do not ignore Homebrew's SQLite on macOS (master...201129-sqlite) https://github.com/bitcoin/bitcoin/pull/20527
< bitcoin-git> bitcoin/master c932e0d Hennadii Stepanov: doc: Update wallet database installation guide for macOS
< bitcoin-git> bitcoin/master ee7b84e Hennadii Stepanov: build: Use Homebrew's sqlite package if it is available
< bitcoin-git> bitcoin/master c96d1f6 Hennadii Stepanov: build, refactor: Check that Homebrew's qt5 package is actually installed
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1f9d62731c...86f20071931b
< bitcoin-git> [bitcoin] laanwj merged pull request #20549: Support make src/bitcoin-node and src/bitcoin-gui (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549
< bitcoin-git> bitcoin/master 8e1f9d6 Wladimir J. van der Laan: Merge #20549: Support make src/bitcoin-node and src/bitcoin-gui
< bitcoin-git> bitcoin/master 206f74e João Barbosa: Support make src/bitcoin-node and src/bitcoin-gui
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e20b488395c1...8e1f9d62731c
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
< bitcoin-git> [bitcoin] laanwj merged pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
< bitcoin-git> bitcoin/master e20b488 Wladimir J. van der Laan: Merge #20567: test: Add option to git-subtree-check to do full check, add ...
< bitcoin-git> bitcoin/master 34c80d9 Wladimir J. van der Laan: test: Add option to git-subtree-check to do full check, add help
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcff2ee1fbf4...e20b488395c1
< bitcoin-git> [bitcoin] laanwj merged pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
< bitcoin-git> bitcoin/master fa0d835 MarcoFalke: log: Clarify that failure to read fee_estimates.dat is non-fatal
< bitcoin-git> bitcoin/master dcff2ee Wladimir J. van der Laan: Merge #20589: log: Clarify that failure to read/write fee_estimates.dat is...
< bitcoin-git> bitcoin/master faefa5d MarcoFalke: log: Clarify that failure to write fee_estimates.dat is non-fatal
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb53c03b3680...dcff2ee1fbf4
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
< promag> fanquake: I have an issue, not sure how to proceed. see https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41
< bitcoin-git> [bitcoin] laanwj merged pull request #20595: Improve heuristic hex transaction decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
< bitcoin-git> bitcoin/master eb53c03 Wladimir J. van der Laan: Merge #20595: Improve heuristic hex transaction decoding
< bitcoin-git> bitcoin/master 39c42c4 Pieter Wuille: Improve heuristic hex transaction decoding
< bitcoin-git> bitcoin/master 0f949cd Pieter Wuille: Add regression test for incorrect decoding
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fdbb46bd92...eb53c03b3680
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611
< az0re> (I am new to the Bitcoin codebase and would appreciate some tips on the most relevant data structures)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
< bitcoin-git> bitcoin/master c8fdbb4 MarcoFalke: Merge #20609: configure: output notice that test binary is disabled by fuz...
< bitcoin-git> bitcoin/master 904d875 Andrew Poelstra: configure: output notice that test binary is disabled by fuzzing
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38176dc66523...c8fdbb46bd92
< bitcoin-git> [bitcoin] jarolrod opened pull request #20610: doc: update for NetBSD 9.1, add GUI Build Instructions (master...netbsd-docs) https://github.com/bitcoin/bitcoin/pull/20610
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
< bitcoin-git> bitcoin/master 38176dc MarcoFalke: Merge #20573: wallet, bugfix: allow send with string fee_rate amounts
< bitcoin-git> bitcoin/master 6fa72ce Jon Atack: test: add coverage for passing fee rate as a string
< bitcoin-git> bitcoin/master ce207d6 Jon Atack: wallet, bugfix: allow send to take string fee rate values
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22f13c1e088e...38176dc66523
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19776: net, rpc: expose high bandwidth mode state via getpeerinfo (master...20200821-rpc-expose-high-handwidth-mode-state-via-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19776
< bitcoin-git> bitcoin/master dab6583 Sebastian Falbesoner: doc: release note for new getpeerinfo fields "bip152_hb_{from,to}"
< bitcoin-git> bitcoin/master a7ed00f Sebastian Falbesoner: rpc: expose high-bandwidth mode states via getpeerinfo
< bitcoin-git> bitcoin/master 30bc8fa Sebastian Falbesoner: net: save high-bandwidth mode states in CNodeStats
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f5b2ea3e5918...22f13c1e088e
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20217: net: Remove g_relay_txes (master...2020-10-remove-grelaytxes) https://github.com/bitcoin/bitcoin/pull/20217
< bitcoin-git> bitcoin/master 4d510aa John Newbery: [init] Use MakeUnique<> to construct peerman
< bitcoin-git> bitcoin/master f3f61d0 John Newbery: [net processing] Add IgnoresIncomingTxs() function to PeerManager
< bitcoin-git> bitcoin/master 5805b82 John Newbery: [net processing] Move PushNodeVersion into PeerManager
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/054710615c5e...f5b2ea3e5918
< bitcoin-git> [bitcoin] fanquake merged pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
< bitcoin-git> bitcoin/master 0547106 fanquake: Merge #20608: contrib: add symbol check test for PE binaries
< bitcoin-git> bitcoin/master ae9b489 fanquake: contrib: add symbol check test for PE
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17918a987aee...054710615c5e
< bitcoin-git> [bitcoin] fanquake merged pull request #20046: depends: Set CMAKE_INSTALL_RPATH for native packages (master...pr/ipc-rpath) https://github.com/bitcoin/bitcoin/pull/20046
< bitcoin-git> bitcoin/master 17918a9 fanquake: Merge #20046: depends: Set CMAKE_INSTALL_RPATH for native packages
< bitcoin-git> bitcoin/master 7d0271b Russell Yanofsky: depends: Set CMAKE_INSTALL_RPATH for native packages
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038ce97584f...17918a987aee
< gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub

2020-12-09

< bitcoin-git> [bitcoin] apoelstra opened pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
< bitcoin-git> [gui] luke-jr opened pull request #148: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...bugfix_gui_bumpyes) https://github.com/bitcoin-core/gui/pull/148
< bitcoin-git> [bitcoin] laanwj merged pull request #20603: build: Update crc32c subtree (master...2012-crcSubtree) https://github.com/bitcoin/bitcoin/pull/20603
< bitcoin-git> bitcoin/master 0038ce9 Wladimir J. van der Laan: Merge #20603: build: Update crc32c subtree
< bitcoin-git> bitcoin/master fa7c8d1 MarcoFalke: build: Update crc32c subtree
< bitcoin-git> bitcoin/master 90c0f26 MarcoFalke: Squashed 'src/crc32c/' changes from 224988680f..b5ef9be675
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7212db4d2a55...0038ce97584f
< gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20602: util: Allow use of C++14 chrono literals (master...2012-chronoLiterals) https://github.com/bitcoin/bitcoin/pull/20602
< bitcoin-git> bitcoin/master 7212db4 MarcoFalke: Merge #20602: util: Allow use of C++14 chrono literals
< bitcoin-git> bitcoin/master fa11110 MarcoFalke: util: Allow use of C++14 chrono literals
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42ed7f51fafa...7212db4d2a55
< bitcoin-git> [bitcoin] laanwj merged pull request #20606: Remove unused bits from service flags enum (master...2012-netServiceFlags) https://github.com/bitcoin/bitcoin/pull/20606
< bitcoin-git> bitcoin/master 42ed7f5 Wladimir J. van der Laan: Merge #20606: Remove unused bits from service flags enum
< bitcoin-git> bitcoin/master fa40168 MarcoFalke: Remove unused bits from service flags enum
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/795afe6e63a1...42ed7f51fafa
< bitcoin-git> [bitcoin] fanquake opened pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
< bitcoin-git> [bitcoin] fanquake merged pull request #19910: net processing: Move peer_map to PeerManager (master...2020-08-peer-plv2) https://github.com/bitcoin/bitcoin/pull/19910
< bitcoin-git> bitcoin/master a20ab22 John Newbery: [net processing] Make GetPeerRef const
< bitcoin-git> bitcoin/master a529fd3 John Newbery: [net processing] Move GetNodeStateStats into PeerManager
< bitcoin-git> bitcoin/master ed7e469 John Newbery: [net_processing] Move peer_map to PeerManager
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a3586d592078...795afe6e63a1
< bitcoin-git> [bitcoin] naumenkogs reopened pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< bitcoin-git> [bitcoin] naumenkogs closed pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20434 | contrib: Parse ELF directly for symbol and security checks by laanwj · Pull Request #20434 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20606: Remove unused bits from service flags enum (master...2012-netServiceFlags) https://github.com/bitcoin/bitcoin/pull/20606
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20323: tests: Create or use existing properly initialized NodeContexts (master...2020-10-chainman-fixes) https://github.com/bitcoin/bitcoin/pull/20323
< bitcoin-git> bitcoin/master a3586d5 MarcoFalke: Merge #20323: tests: Create or use existing properly initialized NodeConte...
< bitcoin-git> bitcoin/master 81137c6 Carl Dong: test: Add new ChainTestingSetup and use it
< bitcoin-git> bitcoin/master 7e9e7fe Carl Dong: qt/test: [FIX] Add forgotten Context setting in RPCNestedTests
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/90ef622ab534...a3586d592078