2018-12-04

< bitcoin-git> bitcoin/master 8f1753b Wladimir J. van der Laan: Merge #14804: docs: Less confusing documentation for `torpassword`...
< bitcoin-git> [bitcoin] laanwj closed pull request #14804: docs: Less confusing documentation for `torpassword` (master...rebased-squashed-14609) https://github.com/bitcoin/bitcoin/pull/14804
< bitcoin-git> [bitcoin] laanwj closed pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64fc7c0c1b17...0257062e50ca
< bitcoin-git> bitcoin/master 2012d4d Gregory Sanders: Add CScriptNum decode python implementation in functional suite
< bitcoin-git> bitcoin/master 0257062 Wladimir J. van der Laan: Merge #14816: Add CScriptNum decode python implementation in functional suite...
< bitcoin-git> [bitcoin] AkioNak opened pull request #14866: Improve property evaluation way in bitcoin.conf (master...includeconf_eval_at_its_position) https://github.com/bitcoin/bitcoin/pull/14866
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14828: qt: Remove hidden columns in coin control dialog (master...2018-11-coincontroldialog) https://github.com/bitcoin/bitcoin/pull/14828
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c62b15118997...64fc7c0c1b17
< bitcoin-git> bitcoin/master 1c28feb João Barbosa: qt: Remove hidden columns in coin control dialog
< bitcoin-git> bitcoin/master 64fc7c0 Jonas Schnelli: Merge #14828: qt: Remove hidden columns in coin control dialog...
< ujjwalt> Hey, I’m new here and I want to start developing Bitcoin apps. I have basic idea about the protocol - enough to understand how the system largely works (keys, basic crypto etc) but where and how do I start if I want to make an app around this. I have a full node running now.
< sipa> you mean what does bitcoin core do if it doesn't hear back from a tx getdata request?
< gleb> A Bitcoin core node :)
< bitcoin-git> [bitcoin] dongcarl opened pull request #14864: test: Run scripted-diff in subshell (master...2018-12-unset-commit-script-check) https://github.com/bitcoin/bitcoin/pull/14864

2018-12-03

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14863: refactor: Add and use HaveTxsDownloaded() where appropriate (master...Mf1812-docNchainTx) https://github.com/bitcoin/bitcoin/pull/14863
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14862: [doc] chain: Declare BLOCK_VALID_HEADER unused (master...Mf1812-validationDocBLOCK_VALID_HEADER) https://github.com/bitcoin/bitcoin/pull/14862
< MarcoFalke> It is the last thing in https://github.com/bitcoin/bitcoin/milestone/39
< gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl opened pull request #14861: tests: Modify rpc_bind to conform to #14532 behaviour. (master...2018-12-fix-rpc-bind-tests) https://github.com/bitcoin/bitcoin/pull/14861
< bitcoin-git> [bitcoin] DrahtBot closed pull request #10794: Add simple light-client mode (RPC only) (master...2017/07/spv) https://github.com/bitcoin/bitcoin/pull/10794
< bitcoin-git> [bitcoin] DrahtBot closed pull request #12274: http: avoid fd exhaustion (master...http-fd-limit) https://github.com/bitcoin/bitcoin/pull/12274
< gribble> https://github.com/bitcoin/bitcoin/issues/14792 | rpc_bind tests failing locally for ipv6 and nonloopback · Issue #14792 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] DrahtBot closed pull request #12934: [net] [validation] Call ProcessNewBlock() asynchronously (master...module-isolation) https://github.com/bitcoin/bitcoin/pull/12934
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13413: [net,mempool] Call AcceptToMemoryPool() asynchronously in p2p (master...mempool-async) https://github.com/bitcoin/bitcoin/pull/13413
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14231: travis: Save cache even when build or test fail (master...travis-save-cache-on-error) https://github.com/bitcoin/bitcoin/pull/14231
< bitcoin-git> [bitcoin] DrahtBot closed pull request #13168: Thread names in logs and deadlock debug tools (take 2) (master...2018-05-threadnames-take-2) https://github.com/bitcoin/bitcoin/pull/13168
< molz> joiflores, you can talk about your issue in channel #bitcoin, let's hear it there
< joiflores> I know this channel is to discuss Bitcoin development, I am not a developer but I would like to talk with some developer about an issue
< bitcoin-git> [bitcoin] ken2812221 closed pull request #14489: refactor: Drop boost::thread and boost::chrono (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/14489
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< addressleakt> I do a "bitcoin-cli dumpwallet wallet.txt" and I get a 300 MB file which seems to contain all addresses.
< addressleakt> Reading the manual I got the impression that importwallet would be the command to use to import this wallet-dump. So on a different Bitcoin Core I do "bitcoin-cli importwallet wallet.txt", I then do a dumpwallet on this new node to verify that the wallet have imported all the addresses correctly.

2018-12-02

< bitcoin-git> [bitcoin] salisbury-espinosa closed pull request #14858: RPC getblock accepts height or hash (master...rpc_getblock_accepts_height_or_hash) https://github.com/bitcoin/bitcoin/pull/14858
< bitcoin-git> [bitcoin] salisbury-espinosa opened pull request #14858: RPC getblock accepts height or hash (master...rpc_getblock_accepts_height_or_hash) https://github.com/bitcoin/bitcoin/pull/14858
< bitcoin-git> [bitcoin] ch4ot1c closed pull request #14459: More RPC help description fixes (master...fix/rpc-descriptions) https://github.com/bitcoin/bitcoin/pull/14459
< instagibbs> amaclin, if it's a feature for bitcoin core, opening an issue as feature request is definitely appropriate
< molz> amaclin, you can do it in channel #bitcoin or #bitcoin-dev
< amaclin> may I propose Bitcoin client feature here?
< bitcoin-git> [bitcoin] instagibbs opened pull request #14857: wallet_keypool_topup.py: Test for all keypool address types (master...keypool_topup_addresstype) https://github.com/bitcoin/bitcoin/pull/14857
< bitcoin-git> [bitcoin] dongcarl opened pull request #14856: [rebase] net: remove more CConnman globals (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
< bitcoin-git> [bitcoin] practicalswift closed pull request #11551: Fix unsigned integer wrap-around in GetBlockProofEquivalentTime (master...proof-equivalent-time) https://github.com/bitcoin/bitcoin/pull/11551
< NicolasDorier> gmaxwell: The people who would not check the utxo set, would also never check the bitcoin core binaries via gitian and just download them from the website.
< gribble> https://github.com/bitcoin/bitcoin/issues/8708 | net: have CConnman handle message sending by theuni · Pull Request #8708 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact opened pull request #14855: test: Correct ineffectual WithOrVersion from transactions_tests (master...with-or-version-test) https://github.com/bitcoin/bitcoin/pull/14855
< NicolasDorier> Sorry, this conversation might be better on bitcoin-dev than on bitcoin-core-dev.
< NicolasDorier> I initially just wanted to propose the idea of including such utxo set snapshot hash in a text file in Bitcoin Core releases as part of the release process. So people trusting the gitian sigs, can also trust the snapshot hash. It would be one UTXO set snapshot at every core release, which is more than enough.
< NicolasDorier> Strictly better to use Bitcoin Core to filter the traffic for me

2018-12-01

< bitcoin-git> [bitcoin] hebasto opened pull request #14854: qt: Cleanup SplashScreen class (master...20181201-cleanup-splashscreen) https://github.com/bitcoin/bitcoin/pull/14854
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/924cf794e1f4...3362a95be360
< bitcoin-git> bitcoin/0.17 fcdea8a Andrew Chow: Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things...
< bitcoin-git> bitcoin/0.17 fcefc68 Andrew Chow: Convert non-witness UTXOs to witness if witness sig created...
< bitcoin-git> bitcoin/0.17 3362a95 MarcoFalke: Merge #14196: [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary...
< Chris_Stewart_5> basically reproducing https://github.com/bitcoin/bitcoin/pull/14853
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ab5341d1356...ed12fd83ca79
< bitcoin-git> bitcoin/master fe1ff50 Chun Kuan Lee: Hide spendable label if priveate key is disabled
< bitcoin-git> bitcoin/master 82d6c5a Chun Kuan Lee: gui: Show watch-only eye instead of HD disabled
< bitcoin-git> bitcoin/master ed12fd8 Wladimir J. van der Laan: Merge #13966: gui: When private key is disabled, only show watch-only balance...
< bitcoin-git> [bitcoin] laanwj closed pull request #13966: gui: When private key is disabled, only show watch-only balance (master...ui-disable-privkey) https://github.com/bitcoin/bitcoin/pull/13966
< gribble> https://github.com/bitcoin/bitcoin/issues/13930 | Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader by Sjors · Pull Request #13930 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14841: consensus: Move CheckBlock() call to critical section (master...20181129-checkblock-mutex) https://github.com/bitcoin/bitcoin/pull/14841
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/011c42c5bd17...5ab5341d1356
< bitcoin-git> bitcoin/master c5ed6e7 Hennadii Stepanov: Move CheckBlock() call to critical section...
< bitcoin-git> bitcoin/master 5ab5341 Wladimir J. van der Laan: Merge #14841: consensus: Move CheckBlock() call to critical section...
< provoostenator> luke-jr: my dedicated pizza provider accepts bitcoin via BitPay, and I generally finish my pizza before it's confirmed, depsite all the error messages and RBF fud.
< luke-jr> provoostenator: my dedicated server provider accepts bitcoin via BitPay, and I just use PayPal nowadays instead because BitPay screwed up one too many times
< luke-jr> sipa: well, chasing away centralising people would only be a means to a goal (keeping Bitcoin itself secure)
< luke-jr> well, if they move to altcoins, that's not so much Bitcoin's problem..
< gmaxwell> luke-jr: even if you don't care about compeating with paypal, other people in the bitcoin ecosystem do. And they'll make tradeoffs as required to do so, and drag the ecosystem in that direction, especially if people who don't so much care about paypal ignore the requirements.
< gribble> https://github.com/bitcoin/bitcoin/issues/13937 | Track best-possible-headers (TheBlueMatt) by Sjors · Pull Request #13937 · bitcoin/bitcoin · GitHub
< gmaxwell> luke-jr: well it does when to compete with paypal others make centeralized bitcoin solutions.
< luke-jr> people choosing paypal doesn't harm Bitcoin's security, though
< gmaxwell> And so low end SBC hardware or VPSes will continue to target low end usage, which will work with centeralized bitcoin alternatives.
< luke-jr> albypaul: if you're not testing, then ask in #bitcoin to learn why you can't
< albypaul> is there a way to change the difficulty of bitcoin core if you are mining off you're own computer just a question i need to ask.
< luke-jr> albypaul: #bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/9483 | Complete hybrid full block SPV mode by jonasschnelli · Pull Request #9483 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14841 | consensus: Move CheckBlock() call to critical section by hebasto · Pull Request #14841 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #14853: depends: latest rapidcheck, enable property based tests on Travis (master...latest-rapidcheck) https://github.com/bitcoin/bitcoin/pull/14853
< gribble> https://github.com/bitcoin/bitcoin/issues/14733 | P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. by zallarak · Pull Request #14733 · bitcoin/bitcoin · GitHub

2018-11-30

< gribble> https://github.com/bitcoin/bitcoin/issues/11551 | Fix unsigned integer wrap-around in GetBlockProofEquivalentTime by practicalswift · Pull Request #11551 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/252844329f17...924cf794e1f4
< bitcoin-git> bitcoin/0.17 53dcf2b Gregory Sanders: Remove stale comment in CalculateMaximumSignedInputSize
< bitcoin-git> bitcoin/0.17 2a5cc40 Gregory Sanders: CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change
< bitcoin-git> bitcoin/0.17 924cf79 MarcoFalke: Merge #14851: [backport] fix assert crash when specified change output spend size is unknown...
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< provoostenator> I wrote a document to describe what hardware wallet signing RPC calls could look like, what the hardware script should do (mostly achow101's HWI already does), and how that all ties together: https://github.com/Sjors/bitcoin/blob/2018/11/rpc-signer/doc/external-signer.md
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12134 | Build previous releases and run functional tests by Sjors · Pull Request #12134 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] laanwj closed pull request #13258: uint256: Remove unnecessary crypto/common.h dependency (master...uint256-no-crypto-alt) https://github.com/bitcoin/bitcoin/pull/13258
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81bd349c9c8d...011c42c5bd17
< bitcoin-git> bitcoin/master bf2e010 Karl-Johan Alm: uint256: Remove unnecessary crypto/common.h use
< bitcoin-git> bitcoin/master 011c42c Wladimir J. van der Laan: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14852: 0.17 backport: [tests] Add wallet_balance.py (0.17...Mf1811-walletBalanceTestBackport) https://github.com/bitcoin/bitcoin/pull/14852
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14845: [tests] Add wallet_balance.py (master...balance_tests) https://github.com/bitcoin/bitcoin/pull/14845
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14852: 0.17 backport: [tests] Add wallet_balance.py (0.17...Mf1811-walletBalanceTestBackport) https://github.com/bitcoin/bitcoin/pull/14852
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13a7454fbdac...81bd349c9c8d
< bitcoin-git> bitcoin/master c1825b9 John Newbery: [tests] Add wallet_balance.py...
< bitcoin-git> bitcoin/master 81bd349 MarcoFalke: Merge #14845: [tests] Add wallet_balance.py...
< bitcoin-git> [bitcoin] instagibbs opened pull request #14851: [backport] fix assert crash when specified change output spend size is unknown (0.17...change_crash_backport) https://github.com/bitcoin/bitcoin/pull/14851
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14380: fix assert crash when specified change output spend size is unknown (master...unknown_change_size) https://github.com/bitcoin/bitcoin/pull/14380
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/74254fea1ef0...13a7454fbdac
< bitcoin-git> bitcoin/master b06483c Gregory Sanders: Remove stale comment in CalculateMaximumSignedInputSize
< bitcoin-git> bitcoin/master 0fb2e69 Gregory Sanders: CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change
< bitcoin-git> bitcoin/master 13a7454 MarcoFalke: Merge #14380: fix assert crash when specified change output spend size is unknown...
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/9f556622c57d...d8bc0ce1da1c
< bitcoin-git> bitcoin/0.17 df5131b fanquake: gui: explicitly disable "Dark Mode" appearance on macOS...
< bitcoin-git> bitcoin/0.17 de5e48a Luke Dashjr: Bugfix: RPC: Add address_type named param for createmultisig...
< bitcoin-git> bitcoin/0.17 5782fdc Gregory Sanders: Throw error if CPubKey is invalid during PSBT keypath serialization...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14683: tests: better combine_logs.py behavior (master...2018-11-better-cons-log) https://github.com/bitcoin/bitcoin/pull/14683
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60b20c869f8d...74254fea1ef0
< bitcoin-git> bitcoin/master 4aabadb James O'Beirne: tests: have combine_logs default to most recent test dir
< bitcoin-git> bitcoin/master 74254fe MarcoFalke: Merge #14683: tests: better combine_logs.py behavior...
< gribble> https://github.com/bitcoin/bitcoin/issues/13044 | [RFC] Long term plan for wallet command-line args · Issue #13044 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #14849: [wip] depends: qt 5.9.7 (master...qt-5-9-7) https://github.com/bitcoin/bitcoin/pull/14849
< bitcoin-git> [bitcoin] cyounkins-bot opened pull request #14848: Fix broken Gmane URLs (master...fix-gmane-urls) https://github.com/bitcoin/bitcoin/pull/14848
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13676 | Explain that mempool memory is added to -dbcache by Sjors · Pull Request #13676 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12833 | [qt] move QSettings to bitcoin_rw.conf where possible by Sjors · Pull Request #12833 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors closed pull request #13470: WIP [bench] CCoinsView(Cache): measure various scenarios (master...2018/06/bench_db_cache) https://github.com/bitcoin/bitcoin/pull/13470
< gribble> https://github.com/bitcoin/bitcoin/issues/13998 | Scripts and tools: gitian-build.py improvements and corrections by hebasto · Pull Request #13998 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors closed pull request #13937: Track best-possible-headers (TheBlueMatt) (master...2018/08/best-header-tracking) https://github.com/bitcoin/bitcoin/pull/13937
< bitcoin-git> [bitcoin] fanquake closed pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
< bitcoin-git> [bitcoin] kallewoof closed pull request #14847: refactor: SHA256AutoDetect dead stores (master...20181129-sha256autodetect-deadstores) https://github.com/bitcoin/bitcoin/pull/14847
< gribble> https://github.com/bitcoin/bitcoin/issues/13258 | uint256: Remove unnecessary crypto/common.h dependency by kallewoof · Pull Request #13258 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof closed pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
< sdaftuar> "what is the hold up with implementing Dandelion in Bitcoin Core" <-- definitely a loaded question
< bitcoin-git> [bitcoin] kallewoof opened pull request #14847: refactor: SHA256Autodetect dead stores (master...20181129-sha256autodetect-deadstores) https://github.com/bitcoin/bitcoin/pull/14847
< gribble> https://github.com/bitcoin/bitcoin/issues/13947 | Dandelion transaction relay (BIP 156) by MarcoFalke · Pull Request #13947 · bitcoin/bitcoin · GitHub
< Chris_Stewart_5> if anyone wants to take a stab at answering this loaded question ;) ttps://bitcoin.stackexchange.com/questions/81503/what-is-the-tradeoff-between-privacy-and-implementation-complexity-of-dandelion

2018-11-29

< gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
< jnewbery> zallarak: any testing/review of PRs in 'high priority for review' is always appreciated: https://github.com/bitcoin/bitcoin/projects/8
< bitcoin-git> [bitcoin] vim88 opened pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
< BlueMatt> I have another bitcoin-dev post coming discussing package relay, but we have a few options there, if we just want to solve package relay for contracting applications like lightning, we can do so with limited consideration, I think
< sipa> here is another earlier proposed modification: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-February/015717.html
< wumpus> BlueMatt: ok what was your proposal, I'm not in #bitcoin-dev
< BlueMatt> oh, i meant bitcoin-dev ml but it hasnt passed moderation yet
< BlueMatt> next topic: the wall of text I just posted to bitcoin-dev :p
< wumpus> (see the commits in other backport PRs such as https://github.com/bitcoin/bitcoin/pull/14835)
< gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
< BlueMatt> but, at least IMO, its super annoying that you cant build+run bitcoin-qt on the now-several-months-old versions of various OSs, and I presume other rolling distros (eg arch) also have this issue
< wumpus> still lots of backports open https://github.com/bitcoin/bitcoin/milestone/39 I guess they need review, or at least merging
< gmaxwell> I guess I can argue the consequences either way, I can imagine someone losing a wallet file with lots of bitcoin in it because it showed a low balance due to some easily abandoned transactions.
< gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< BlueMatt> but 0.17.0 currently cannot be self-built and bitcoin-qt opened on latest fedora/ubuntu release
< gribble> https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
< bitcoin-git> [bitcoin] jnewbery opened pull request #14845: [tests] Add wallet_balance.py (master...balance_tests) https://github.com/bitcoin/bitcoin/pull/14845
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ariaamz opened pull request #14843: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14843
< bitcoin-git> [bitcoin] fanquake closed pull request #14843: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14843
< bitcoin-git> [bitcoin] hebasto opened pull request #14841: consensus: Move CheckBlock() call to critical section (master...20181129-checkblock-mutex) https://github.com/bitcoin/bitcoin/pull/14841
< bitcoin-git> [bitcoin] AmirAbrams opened pull request #14840: Remove duplicate libconsensus linking in test make (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14840
< bitcoin-git> [bitcoin] fanquake closed pull request #14342: threads: fix potential unitialized members in sched_param (master...fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14342
< bitcoin-git> [bitcoin] fanquake opened pull request #14839: [rebase] threads: fix unitialized members in sched_param (master...rebased-fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14839
< gribble> https://github.com/bitcoin/bitcoin/issues/14342 | threads: fix potential unitialized members in sched_param by theuni · Pull Request #14342 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14838: Use const in COutPoint class (master...20181129-const-null-outpoint) https://github.com/bitcoin/bitcoin/pull/14838
< bitcoin-git> [bitcoin] fanquake closed pull request #14387: Faster Input Deduplication Algorithm (master...faster-dedup) https://github.com/bitcoin/bitcoin/pull/14387
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #14837: Stricter & More Performant Invariant Checking in CheckBlock (master...faster-dedup-working-rebase) https://github.com/bitcoin/bitcoin/pull/14837
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #14836: Probabalistic Checker for Duplicate Inputs (master...faster-dedup-working-rebase) https://github.com/bitcoin/bitcoin/pull/14836
< bitcoin-git> [bitcoin] JeremyRubin closed pull request #14836: Probabalistic Checker for Duplicate Inputs (master...faster-dedup-working-rebase) https://github.com/bitcoin/bitcoin/pull/14836
< gmaxwell> Also this isn't merged yet, https://github.com/bitcoin/bitcoin/pull/14380 but looks done to me? and its a fix we should have in 0.17.1
< bitcoin-git> [bitcoin] fanquake opened pull request #14835: [0.17] Backport #14593, #14596 and #14690 (0.17...further-0-17-backports) https://github.com/bitcoin/bitcoin/pull/14835
< bitcoin-git> [bitcoin] kallewoof opened pull request #14834: validation: do not break assumption that pindexPrev may be null (master...20181129-contextualcheckblock-pindexprev-nullness) https://github.com/bitcoin/bitcoin/pull/14834
< bitcoin-git> [bitcoin] cryptosnail closed pull request #14833: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14833
< bitcoin-git> [bitcoin] cryptosnail opened pull request #14833: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14833

2018-11-28

< gribble> https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 13 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5150accdd2a7...9f556622c57d
< bitcoin-git> bitcoin/0.17 bb90695 gustavonalle: [wallet] Ensure wallet is unlocked before signing...
< bitcoin-git> bitcoin/0.17 85aacc4 Walter: Add autogen.sh in ARM Cross-compilation...
< bitcoin-git> bitcoin/0.17 9406502 Kaz Wesley: add a test demonstrating an overflow in a deserialization edge case...
< bitcoin-git> [bitcoin] ch4ot1c opened pull request #14832: docs: Add more Doxygen information to Developer Notes (master...improvement/doxygen-docs) https://github.com/bitcoin/bitcoin/pull/14832
< bitcoin-git> [bitcoin] vim88 opened pull request #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. (master...proper_shebang) https://github.com/bitcoin/bitcoin/pull/14831
< gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13005 | Make --enable-debug to pick better options by practicalswift · Pull Request #13005 · bitcoin/bitcoin · GitHub
< promag> another "An established connection was aborted by the software in your host machine" https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20621323
< bitcoin-git> [bitcoin] practicalswift opened pull request #14829: travis: Enable functional tests in the ThreadSanitizer (TSan) build job (master...tsan) https://github.com/bitcoin/bitcoin/pull/14829
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14822: bench: Destroy wallet txs instead of leaking their memory (master...Mf1811-benchWalletTxs) https://github.com/bitcoin/bitcoin/pull/14822
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a452d02cebb...60b20c869f8d
< bitcoin-git> bitcoin/master fa5cef0 MarcoFalke: bench: Destroy wallet txs instead of leaking their memory
< bitcoin-git> bitcoin/master 60b20c8 MarcoFalke: Merge #14822: bench: Destroy wallet txs instead of leaking their memory...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14487: Constexpr Everything Part 1: Constants (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14487
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ebfe0e92737...0a452d02cebb
< bitcoin-git> bitcoin/master b312cd7 practicalswift: Add missing locking annotations
< bitcoin-git> bitcoin/master 4894133 practicalswift: Add missing lock in CNode::copyStats(...)
< bitcoin-git> bitcoin/master 0a452d0 MarcoFalke: Merge #13123: net: Add Clang thread safety annotations for guarded variables in the networking code...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13123: net: Add Clang thread safety annotations for guarded variables in the networking code (master...net-guarded-by) https://github.com/bitcoin/bitcoin/pull/13123
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/600b85bb4172...9ebfe0e92737
< bitcoin-git> bitcoin/master 29aeed1 Luke Dashjr: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize...
< bitcoin-git> bitcoin/master 9ebfe0e MarcoFalke: Merge #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize...
< bitcoin-git> [bitcoin] hebasto closed pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817
< bitcoin-git> [bitcoin] fanquake closed pull request #14827: remove fCheckDuplicateInputs (master...master) https://github.com/bitcoin/bitcoin/pull/14827
< bitcoin-git> [bitcoin] promag opened pull request #14828: qt: Remove hidden columns in coin control dialog (master...2018-11-coincontroldialog) https://github.com/bitcoin/bitcoin/pull/14828
< bitcoin-git> [bitcoin] 3s3s opened pull request #14827: remove fCheckDuplicateInputs (master...master) https://github.com/bitcoin/bitcoin/pull/14827
< bitcoin-git> [bitcoin] promag opened pull request #14826: Avoid expanding descriptor scriptPubKeys (master...2018-11-faster-descriptor-expand) https://github.com/bitcoin/bitcoin/pull/14826
< Guest80> Again, the Bitcoin.org can have whatever build system, it doesn't help to see the result of their build.
< Guest80> Bitcoin.org has Windows installers. They build them somehow.
< dongcarl> gmaxwell: Huh... I was actually thinking that errors need error codes in Bitcoin... But perhaps that's a bad idea...
< Guest80> Anybody here experienced with bitcoin core build?
< sipa> for example, bitcoin core will use a very different codepath for an ecdsa signature that is too long vs one that is just invalid
< gmaxwell> like, yes maybe bitcoin core has a branch that checks the size and terminates... but without that branch it would still reject those cases because the hash function (a size triggered OR of two functions) will never match for inputs of other sizes.
< sipa> latest scaling bitcoin had a talk on improvements to cryptographic accumulators to make them more usable for this kind of application
< bitcoin-git> [bitcoin] laanwj closed pull request #14825: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14825
< bitcoin-git> [bitcoin] Mountains-and-rivers opened pull request #14825: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14825
< aj> $ time (blk=$(bitcoin-cli getblockhash 551601); echo $blk; bitcoin-cli invalidateblock $blk; bitcoin-cli gettxoutsetinfo | grep hash_serial; bitcoin-cli reconsiderblock $blk) # --> 666550387c3f5fa8e9353ce561fcee2a164022d31b97affd7c982388f19a4904as the hash, took about 1m12 all up
< NicolasDorier> aj: At least for the reviewers. People running those "bitcoin core in a box" are already blindly trusting binaries anyway.
< NicolasDorier> I think this is even better UX than embedding known utxo hash set anywhere into bitcoin core.
< gmaxwell> NicolasDorier: if the "bitcoin core in a box" then the entire software could do arbritary things, the hash it gives is meaningless.
< NicolasDorier> Yes I can understand. I am just worried that right now what we will see with those "Bitcoin Core in a box" is blind reliance on a pre-shipped UTXO Set
< NicolasDorier> So the user could fast sync from untrusted source, and would get a warning if that differ from Bitcoin Core website/twitter or whatever publish mechanism
< NicolasDorier> so instead I was thinking the following: What about Bitcoin Core share the txoutset hash on bitcoincore website or twitter or whatever (like every 1000 blocks). At BTCPay level, I would show the UTXOSet of their own node and check against the website
< NicolasDorier> At first I was thinking to do https://github.com/bitcoin/bitcoin/pull/13713#issuecomment-442333282

2018-11-27

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14822: bench: Destroy wallet txs instead of leaking their memory (master...Mf1811-benchWalletTxs) https://github.com/bitcoin/bitcoin/pull/14822
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14794: tests: Add AddressSanitizer (ASan) Travis build (master...asan-in-travis) https://github.com/bitcoin/bitcoin/pull/14794
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fdf146f3293c...600b85bb4172
< bitcoin-git> bitcoin/master ebd3bf2 practicalswift: Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase
< bitcoin-git> bitcoin/master ff7212e practicalswift: Add ASan Travis build
< bitcoin-git> bitcoin/master 6541d59 practicalswift: Add LSan suppression warnings
< bitcoin-git> [bitcoin] sipa opened pull request #14821: Replace CAffectedKeysVisitor with descriptor based logic (master...201810_die_caffectedkeysvisitor_die) https://github.com/bitcoin/bitcoin/pull/14821
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/0fa3703c1757...fdf146f3293c
< bitcoin-git> bitcoin/master 4d78bd9 Pieter Wuille: Add support for inferring descriptors from scripts
< bitcoin-git> bitcoin/master 225bf3e Pieter Wuille: Add Descriptor::IsSolvable() to distinguish addr/raw from others
< bitcoin-git> bitcoin/master 9b2a25b Pieter Wuille: Add tests for InferDescriptor and Descriptor::IsSolvable
< bitcoin-git> [bitcoin] sipa closed pull request #14477: Add ability to convert solvability info to descriptor (master...201810_inferdescript) https://github.com/bitcoin/bitcoin/pull/14477
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14820: test: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c119b27551f...0fa3703c1757
< bitcoin-git> bitcoin/master c77f092 Russell Yanofsky: Fix descriptor_tests not checking ToString output of public descriptors
< bitcoin-git> bitcoin/master 0fa3703 MarcoFalke: Merge #14820: test: Fix descriptor_tests not checking ToString output of public descriptors...
< bitcoin-git> [bitcoin] ryanofsky opened pull request #14820: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14813: qa: Add wallet_encryption error tests (master...Mf1811-qaWalletEncTest) https://github.com/bitcoin/bitcoin/pull/14813
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d49103007676...8c119b27551f
< bitcoin-git> bitcoin/master fa739d4 MarcoFalke: qa: Add wallet_encryption error tests
< bitcoin-git> bitcoin/master 8c119b2 MarcoFalke: Merge #14813: qa: Add wallet_encryption error tests...
< gmaxwell> provoostenator: 09:57:52 < jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason
< gribble> https://github.com/bitcoin/bitcoin/issues/10595 | Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients by luke-jr · Pull Request #10595 · bitcoin/bitcoin · GitHub
< jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason don't want to include a certain class of transaction in their blocks.
< bitcoin-git> [bitcoin] luke-jr opened pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819
< jnewbery> I think promag means 'what if the miner wants to take Bitcoin Core 0.18 but doesn't want to upgrade his pool software to support mining segwit blocks?'
< sipa> promag: currently, if the gbt client does not provide segwit flag, bitcoin core will produce a (suboptimal) block template without segwit txn
< bitcoin-git> [bitcoin] luke-jr opened pull request #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (master...bugfix_test_rpc_psbt) https://github.com/bitcoin/bitcoin/pull/14818
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4eaaa6ac536...d49103007676
< bitcoin-git> bitcoin/master fa71eb5 MarcoFalke: Convert comments to thread safety annotations
< bitcoin-git> bitcoin/master d491030 MarcoFalke: Merge #14772: refactor: Convert comments to thread safety annotations...
< jnewbery> I'm looking at #14602 and https://bitcoin.stackexchange.com/questions/80926/update-to-0-17-0-broke-several-rpc-api-calls-that-worked-under-0-16-3-how-to-mi and trying to understand exactly what the use case is for getbalance *
< gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817
< bitcoin-git> [bitcoin] instagibbs opened pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
< gribble> https://github.com/bitcoin/bitcoin/issues/14356 | fix converttopsbt permitsigdata arg, add basic test by instagibbs · Pull Request #14356 · bitcoin/bitcoin · GitHub

2018-11-26

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14812: qa: fix p2p_invalid_messages on macOS (master...2018-11-test-macos-mem-fix) https://github.com/bitcoin/bitcoin/pull/14812
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b5c3d7affc98...a4eaaa6ac536