< bitcoin-git>
[bitcoin] Sjors opened pull request #16546: [WIP] External signer support - Wallet Box edition (master...2019/08/hww-box2) https://github.com/bitcoin/bitcoin/pull/16546
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #16545: Implement missing error checking for ArgsManager flags (master...pr/argcheck) https://github.com/bitcoin/bitcoin/pull/16545
< bitcoin-git>
[bitcoin] fanquake closed pull request #16138: Scripts and tools: Add sudoers.d, rc.local from docs to gitian script (master...gitian-automated-sudoers-br0) https://github.com/bitcoin/bitcoin/pull/16138
< bitcoin-git>
[bitcoin] fanquake closed pull request #13612: Qt: Only call tryGetBalances in pollBalanceChanged if the result will be used. (master...bitcoin) https://github.com/bitcoin/bitcoin/pull/13612
< elichai2>
emilengler: yp need to add `-S` to everyt git command you run that modifies the commits. but an easier way to do this is just run `git config commit.gpgsign true` in your bitcoin dir which will force your git to sign every commit you make in that repo
< emilengler>
Hope it's ok to ask this question here, because I need it for Bitcoin Core development. How can I sign a commit which include squashed commits. Everytime I squash commits the "parent" commit is unsigned
< bitcoin-git>
[bitcoin] mmachicao closed pull request #15137: Tests: Contract test for CCoinsView and CCoinsViewBacked (master...coins_contract_tests) https://github.com/bitcoin/bitcoin/pull/15137
< emilengler>
Same with Bitcoin Core and FreeBSD for example
< achow101>
fun fact, bitcoin 0.1 was released before Windows 7
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< elichai2>
yeah, but then I can import a desc and try to sign with it. but I guess i'm trying to do too much, for now i'll test manually and concentrate on adding more tests for the desc and then either ask someone to give my code a quick look (I am pretty new to bitcoin core's code and to c++) or look into PSBT/signing, but only after i'm 100% done with the desc
2019-08-02
< bitcoin-git>
[bitcoin] achow101 opened pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
< bitcoin-git>
[bitcoin] emilengler opened pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] ariard opened pull request #16536: [doc] Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
< bitcoin-git>
bitcoin/master 9ed062b Sjors Provoost: [doc] rpc: remove "fallback to" from RBF default help
< bitcoin-git>
bitcoin/master d6b3640 Sjors Provoost: [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15911: Use wallet RBF default for walletcreatefundedpsbt (master...2019/04/walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/15911
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< emilengler>
Is there a cmake file for bitcoin core?
2019-08-01
< bitcoin-git>
[bitcoin] jtimon opened pull request #16527: Get rid of Params().RequireStandard() (master...b19-chainparams-no-requirestd) https://github.com/bitcoin/bitcoin/pull/16527
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16525
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #16513: [RFC] Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513
< bitcoin-git>
[bitcoin] jtimon opened pull request #16524: Truly decouple wallet from chainparams for -fallbackfee (master...b19-true-wallet-no-chainparams) https://github.com/bitcoin/bitcoin/pull/16524
< bitcoin-git>
[bitcoin] metalicjames opened pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523
< gribble>
https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] Remagpie opened pull request #16521: wallet/rpc: Use the default maxfeerate value as BTC/kB (master...maxfeerate-as-rate) https://github.com/bitcoin/bitcoin/pull/16521
< jonasschnelli>
If someone wants to pickup my. topic (bitcoin-dev mailing list moderation), feel free
< bitcoin-git>
[bitcoin] dongcarl opened pull request #16519: guix: Change manifest to use channels and inferiors (master...2019-06-guix-channels-and-inferiors) https://github.com/bitcoin/bitcoin/pull/16519
< emilengler>
And where is the config file initial be loaded? In src/qt/bitcoin.cpp or src/qt/intro.cpp
< bitcoin-git>
[bitcoin] hebasto closed pull request #16476: Use ArgsManager::ALLOW_STRING flag explicitly in simple cases (master...20190727-pr16097-new-flags) https://github.com/bitcoin/bitcoin/pull/16476
< bitcoin-git>
[bitcoin] laanwj merged pull request #16277: [Tests] Suppress output in test_bitcoin for expected errors (master...issue-15944) https://github.com/bitcoin/bitcoin/pull/16277
< fanquake>
wumpus: yep QT_RCC_SOURCE_DATE_OVERRIDE fixed the issues with bitcoin-qt 🤦
< coinmonks>
I am online if anyone have any feedback,,or they can just leave private notes on the post itself.. thank you every one for contributing on Bitcoin.. :]
< bitcoin-git>
[bitcoin] meshcollider merged pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< bitcoin-git>
bitcoin/master c5d3787 Andrew Chow: Allow createwallet to take empty passwords to make unencrypted wallets
< bitcoin-git>
bitcoin/master 6841b01 MeshCollider: Merge #16394: Allow createwallet to take empty passwords to make unencrypt...
< wumpus>
no, not using --prefix at the moment, I see a diffrence too between the same commits though, in bitcoin-qt but not bitcoind
< fanquake>
I've just done master (b7fbf74b980ebb122ae34b142f2cc49b44b92de3) and a dummy commit, still seeing the same difference in bitcoin-qt.
< wumpus>
i don't think i've ever used build-for-compare with bitcoin-qt, at all
< fanquake>
Doing a binary comparison of a bitcoin-qt built from HEAD~1 and HEAD~2, building on Debian using depends. Currently seeing this diff: https://gist.github.com/fanquake/653bb42176d7772578db08a0f8e60f11 . Any suggestions as to what could be causing the difference? bitcoind matches.
< bitcoin-git>
[bitcoin] promag opened pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515
< bitcoin-git>
bitcoin/master fa6fba3 MarcoFalke: test: Make local symbols in run_test members
< bitcoin-git>
bitcoin/master faf8318 MarcoFalke: test: Split fundrawtx test into subtests
< bitcoin-git>
bitcoin/master 5639d71 MarcoFalke: Merge #16293: test: Make test cases separate functions
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git>
[bitcoin] hebasto opened pull request #16508: Use ArgsManager::ALLOW_BOOL flag explicitly (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
< bitcoin-git>
[bitcoin] instagibbs opened pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
< emilengler>
wumpus: Well how does bitcoin-qt then detects when Ctrl+L is pressed? It only works when the console tab is open
< bitcoin-git>
[bitcoin] instagibbs closed pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
< sdaftuar>
on the bitcoin main chain, this is not actually a problem (modulo the hypothetical future problem we can have after block 1.9M or whatever it is)
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
< bitcoin-git>
bitcoin/master 80ba424 Amiti Uttarwar: extract min & max depth onto coin control
< bitcoin-git>
bitcoin/master 00922b8 Wladimir J. van der Laan: Merge #15906: [wallet] Move min_depth and max_depth to coin control
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
< bitcoin-git>
[bitcoin] promag opened pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
2019-07-30
< bitcoin-git>
[bitcoin] ariard opened pull request #16503: Remove p2pEnabled from Chain interface (master...2019-07-remove-p2p-chain) https://github.com/bitcoin/bitcoin/pull/16503
< fanquake>
In newer versions of Xcode some of the headers our depends packages rely on aren’t where they used to be, and there a a script you can run that’ll put them back. See this comment: https://github.com/bitcoin/bitcoin/pull/16392#issuecomment-515268092 and the one I’m referencing.
< bitcoin-git>
[bitcoin] promag closed pull request #16494: wallet: Drop support to serialize OldKey (master...2019-07-drop-oldkey-serialize) https://github.com/bitcoin/bitcoin/pull/16494
< bitcoin-git>
[bitcoin] ronaldstoner closed pull request #16501: Update configure.ac to remove extra no in $use_tests (master...master) https://github.com/bitcoin/bitcoin/pull/16501
< bitcoin-git>
[bitcoin] ronaldstoner opened pull request #16501: Update configure.ac to remove extra no in $use_tests (master...master) https://github.com/bitcoin/bitcoin/pull/16501
< bitcoin-git>
[bitcoin] instagibbs opened pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
< emilengler>
I don't get where the bitcoin-qt rpc console detecs when Ctrl-L is being pressed? With the help of the grep command I've only found the way how Ctrl-Q is being handled. Can someone tell me where I find it?
< gribble>
https://github.com/bitcoin/bitcoin/issues/16433 | txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN by MarcoFalke · Pull Request #16433 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] TheBlueMatt reopened pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497
< BlueMatt>
jonasschnelli: to answer your question, in a general case, the way you write a network layer (eg the way bitcoin core does it today) is step 1) read message header, step 2) check stuff about the header, step 3) allocate buffer for the size it told you, step 4) read message. this keeps things nice and simple, you dont have much allocation complexity and you avoid most buffer overflow issues if you misallocate in your network stack.
< bitcoin-git>
[bitcoin] promag opened pull request #16494: wallet: Drop support to serialize OldKey (master...2019-07-drop-oldkey-serialize) https://github.com/bitcoin/bitcoin/pull/16494
< elichai2>
oh. but they will need to implement the variable size type/functions anyway for the rest of the stuff in bitcoin. so why not use the same type we use everywhere?
< bitcoin-git>
bitcoin/master 0c78e49 practicalswift: tests: Switch one of the Travis jobs to an unsigned char environment (-fun...
< bitcoin-git>
bitcoin/master 74f1a27 Wladimir J. van der Laan: Merge #15134: tests: Switch one of the Travis jobs to an unsigned char env...
< bitcoin-git>
[bitcoin] laanwj merged pull request #15134: tests: Switch one of the Travis jobs to an unsigned char environment (-funsigned-char) (master...unsigned-char) https://github.com/bitcoin/bitcoin/pull/15134
< kallewoof>
achow101: https://github.com/bitcoin/bitcoin/pull/16440#discussion_r308332901 I basically need the wallet interface to give me a way to sign things from the QT side, and this was the only approach I could think of. sipa suggested I ping you to make sure I wasn't trampling on stuff with the descriptor wallet changes you are working on.
< bitcoin-git>
[bitcoin] pstratem opened pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
< bitcoin-git>
[bitcoin] laanwj merged pull request #16436: gui: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
< bitcoin-git>
[bitcoin] laanwj merged pull request #15993: net: Drop support of the insecure miniUPnPc versions (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993