< December 2024 >
Su Mo Tu We Th Fr Sa 12345 6 7
8 9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30 31
2020-08-18
< bitcoin-git>
[bitcoin] hebasto opened pull request #19758: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations (master...200818-tsa) https://github.com/bitcoin/bitcoin/pull/19758
< bitcoin-git>
[bitcoin] vasild closed pull request #18857: build: avoid repetitions when enabling warnings in configure.ac (master...avoid_repetitions_in_configure.ac) https://github.com/bitcoin/bitcoin/pull/18857
< bitcoin-git>
[bitcoin] hebasto closed pull request #16641: refactor: Improve special member functions definitions (master...20190817-psbt-copy-ctor) https://github.com/bitcoin/bitcoin/pull/16641
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #19757: net/net_processing: Convert net std::list buffers to std::forward_list (master...net-list-type) https://github.com/bitcoin/bitcoin/pull/19757
< bitcoin-git>
[bitcoin] kallewoof opened pull request #19756: tests: add sync_all to fix race condition in wallet groups test (master...202008-wallet-groups-sync-all) https://github.com/bitcoin/bitcoin/pull/19756
< bitcoin-git>
[bitcoin] achow101 opened pull request #19754: wallet: Move UpdateWalletSetting to wallet module and use from GUI interface (master...load-on-start-gui) https://github.com/bitcoin/bitcoin/pull/19754
< bitcoin-git>
[bitcoin] slmtpz opened pull request #19752: test: Update wait_until usage in tests not to use the one from utils (master...master) https://github.com/bitcoin/bitcoin/pull/19752
< bitcoin-git>
[bitcoin] hebasto closed pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
< bitcoin-git>
[bitcoin] hebasto opened pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
< bitcoin-git>
[bitcoin] meshcollider merged pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
< bitcoin-git>
bitcoin/master c831e10 Samuel Dobson: Merge #14582: wallet: always do avoid partial spends if fees are within a ...
< bitcoin-git>
bitcoin/master 7f13dfb Karl-Johan Alm: test: test the implicit avoid partial spends functionality
< bitcoin-git>
bitcoin/master b82067b Karl-Johan Alm: wallet: try -avoidpartialspends mode and use its result if fees are below ...
< bitcoin-git>
[bitcoin] achow101 opened pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
< gribble>
https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< shesek>
achow101, one unintended side-effect is that spending from that address reveals that you're using bitcoin core. but that can only be an issue if someone learns your xpub, which should not really happen normally anyway
< bitcoin-git>
bitcoin/master fa6583c MarcoFalke: ci: Set increased --timeout-factor by default
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19134: test: Replace global wait_until with BitcoinTestFramework.wait_until and mininode.wait_until (master...master) https://github.com/bitcoin/bitcoin/pull/19134
< bitcoin-git>
[bitcoin] jonatack opened pull request #19731: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo (master...add-eviction-criteria-to-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19731
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19730: ci: Set increased --timeout-factor by default (master...2008-ciTimeoutDefault) https://github.com/bitcoin/bitcoin/pull/19730
< bitcoin-git>
[bitcoin] sipa opened pull request #19728: Increase the ip address relay branching factor for unreachable networks (master...202008_increase_addr_branching) https://github.com/bitcoin/bitcoin/pull/19728
< bitcoin-git>
[bitcoin] meshcollider merged pull request #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct (master...cleanup-outputgroups) https://github.com/bitcoin/bitcoin/pull/17458
< bitcoin-git>
bitcoin/master f269165 Samuel Dobson: Merge #17458: Refactor OutputGroup effective value calculations and filter...
< bitcoin-git>
bitcoin/master 9adc2f8 Andrew Chow: Refactor OutputGroups to handle effective values, fees, and filtering
< bitcoin-git>
bitcoin/master 7d07e86 Andrew Chow: Use real value when calculating OutputGroup value
< gribble>
https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 · Pull Request #17458 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14582 | wallet: always do avoid partial spends if fees are within a specified range by kallewoof · Pull Request #14582 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj merged pull request #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) (master...201910_1negate_rebase) https://github.com/bitcoin/bitcoin/pull/17204
< bitcoin-git>
bitcoin/master 4d4bd5e Wladimir J. van der Laan: Merge #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in s...
< bitcoin-git>
bitcoin/master e629d07 Pieter Wuille: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code
< gribble>
https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< michaelfolkson>
It seems to me that the experiment has been very short. I will try to find out if there is genuine interest in contributing, reviewing on that Bitcoin Design Slack
< wumpus>
luke-jr_: that seems another issue, would make it imopssible to move bitcoin itself there
< luke-jr_>
also, while it used to be possible to have multiple forks under the same org (so bitcoin-core/gui and bitcoin-core/foobar), GitHub seems to have removed that possibility too
< wumpus>
then again if a lot of people feel like it would be easier if it's a bitcoin/bitcoin fork we could try asking github
< jnewbery>
if we delete bitcoin-core/gui and then recreate it as a fork of bitcoin/bitcoin, you'd be able to
< jnewbery>
wumpus: if you push a branch to <developer>/bitcoin , then you can't open a PR against bitcoin-core/gui because they don't share a common fork in gitub
< wumpus>
he wants to inherit it from bitcoin/bitcoin I think instead of having it as completely disparate repo
< luke-jr_>
Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
< wumpus>
#topic Can we recreate bitcoin-core/gui (Luke-jr)
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] hebasto opened pull request #19710: bench: Prevent thread oversubscription and decreases the variance of result values (master...200813-var) https://github.com/bitcoin/bitcoin/pull/19710
< bitcoin-git>
[bitcoin] laanwj merged pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
< bitcoin-git>
bitcoin/master f5c003d Jim Posen: [test] Add test for NODE_COMPACT_FILTER.
< bitcoin-git>
bitcoin/master 132b30d Jim Posen: [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters.
< bitcoin-git>
bitcoin/master b3fbc94 John Newbery: Apply cfilters review fixups
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
< bitcoin-git>
[bitcoin] meshcollider merged pull request #18654: rpc: separate bumpfee's psbt creation function into psbtbumpfee (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
< bitcoin-git>
bitcoin/master 79d6332 Andrew Chow: moveonly: Fix indentation in bumpfee RPC
< bitcoin-git>
[bitcoin] laanwj merged pull request #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman (master...2020-07-addrman-get) https://github.com/bitcoin/bitcoin/pull/19658
< jonatack>
review beg for #19455 (which arguably should have been in the last release with -generate to make multiple bitcoin command line tutorials work again for users), as requested by ajonas and MarcoFalke. It's a quick review with complete test coverage.
< luke-jr>
#proposedmeetingtopic Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
< gribble>
https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
< phantomcircuit>
adiabat, no even then you can trivially detect that it's a bitcoin node
< phantomcircuit>
without significantly delaying block relay, it's impossible to hide that you're running a bitcoin node from the network operator
< phantomcircuit>
adiabat, it has to be easy to identify a bitcoin node that's listening, and it's inherently going to be easy to identify a bitcoin node based on the network traffic
< jonatack>
i'm running bitcoin locally with nLastBlockTime and nLastTXTime added to getpeerinfo for my peer connections dashboard
< troygiorshev>
certainly is difficult (i imagine) to distinguish between "this is a really clean PR and I really have no comments on it, it's RFM" and "I've done my best but I'm not familiar enough with bitcoin to really review this"
< aj>
adiabat: i think the reason not to do other ports was to prevent bitcoin nodes being used as a primitive botnet that'll start connecting to arbitrary services (or to be mistaken for being part of a botnet if someone spams military.gov's rsh port as a thing to connect to for bitcoin p2p maybe. never been able to judge if that makes much sense these days
< jnewbery>
sdaftuar: do you know whether there are nodes that disconnect on unknown message types? Bitcoin Core just drops them (which I think is the only sensible behaviour)
< ariard>
sdaftuar: I think that's good it was unclear between matt and I on bip339 implemn in rust-bitcoin about why 339 bumps both protocol version and wtxid-relay
< sdaftuar>
however, i think we need to make sure software on the network knows to ignore unknown messages pre-verack to make this a possibility. bitcoin core historically has disallowed unknown messages pre-verack
< ajonas>
Ok. A few months ago, I was reading over https://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2018-03-07-priorities/, which articulates some possibilities for how to better coordinate review. Since then, I've been experimenting with asking for reviews directly. (This was also the motivation of #18949).
< * fanquake>
wonders if he should attend to achieve back to back to back bitcoin meetings 🤔
< bitcoin-git>
[bitcoin] naumenkogs opened pull request #19697: Minor improvements on ADDR caching (master...2020-08-addr-cache-follow-up) https://github.com/bitcoin/bitcoin/pull/19697
< gribble>
https://github.com/bitcoin/bitcoin/issues/19070 | p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS by jnewbery · Pull Request #19070 · bitcoin/bitcoin · GitHub
< jonasschnelli>
can someone unban me in #bitcoin #bitcoin-dev?