2018-11-23

< bitcoin-git> [bitcoin] laanwj closed pull request #14521: qt, docs: Fix `bitcoin-qt -version` output formatting (master...20181019-qt-cli-license) https://github.com/bitcoin/bitcoin/pull/14521
< bitcoin-git> [bitcoin] laanwj closed pull request #14678: [wallet] remove redundant KeyOriginInfo access, already done in CreateSig (master...redundant_keypath) https://github.com/bitcoin/bitcoin/pull/14678
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d3af69fd074...0595164dbaa3
< bitcoin-git> bitcoin/master f7beb95 Gregory Sanders: remove redundant KeyOriginInfo access, already done in CreateSig
< bitcoin-git> bitcoin/master b81a186 Gregory Sanders: GetPubKey: make sigdata const
< bitcoin-git> bitcoin/master 0595164 Wladimir J. van der Laan: Merge #14678: [wallet] remove redundant KeyOriginInfo access, already done in CreateSig...
< bitcoin-git> [bitcoin] laanwj closed pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/e3a1b74cdf7d...1d3af69fd074
< bitcoin-git> bitcoin/master 895e6bb Andrew Chow: build: if VERSION_BUILD is non-zero, include it in the package version...
< bitcoin-git> bitcoin/master 04b0bc7 Andrew Chow: build: include rc number in version number
< bitcoin-git> bitcoin/master 75a4bf6 Andrew Chow: Update release-process.md to include RC version bumping
< bitcoin-git> [bitcoin] laanwj closed pull request #14448: doc: Clarify rpcwallet flag url change (master...clarify_rpc_wallet_flag) https://github.com/bitcoin/bitcoin/pull/14448
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2479b779aae4...e3a1b74cdf7d
< bitcoin-git> bitcoin/master 0c69ff6 Jordan Baczuk: clarify rpcwallet flag url change
< bitcoin-git> bitcoin/master e3a1b74 Wladimir J. van der Laan: Merge #14448: doc: Clarify rpcwallet flag url change...
< bitcoin-git> [bitcoin] laanwj closed pull request #14728: fix uninitialized read when stringifying an addrLocal (master...uninit-scopeid) https://github.com/bitcoin/bitcoin/pull/14728
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a0d86815cda9...2479b779aae4
< bitcoin-git> bitcoin/master 8ebbef0 Kaz Wesley: add test demonstrating addrLocal UB
< bitcoin-git> bitcoin/master b7b36de Kaz Wesley: fix uninitialized read when stringifying an addrLocal...
< bitcoin-git> bitcoin/master 2479b77 Wladimir J. van der Laan: Merge #14728: fix uninitialized read when stringifying an addrLocal...
< bitcoin-git> [bitcoin] laanwj closed pull request #14726: Use RPCHelpMan for all RPCs (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14726
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d7fbe7d927ea...a0d86815cda9
< bitcoin-git> bitcoin/master fa520e7 MarcoFalke: lint: Must use RPCHelpMan to generate the RPC docs
< bitcoin-git> bitcoin/master fa91e8e MarcoFalke: Use RPCHelpMan for all RPCs
< bitcoin-git> bitcoin/master fa5e045 MarcoFalke: rpc: Documentation fixups
< gribble> https://github.com/bitcoin/bitcoin/issues/14792 | rpc_bind tests failing locally for ipv6 and nonloopback · Issue #14792 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3dda4c5f037b...d7fbe7d927ea
< bitcoin-git> bitcoin/master 8284756 John Newbery: A few minor formatting fixes and clarifications to descriptors.md
< bitcoin-git> bitcoin/master d7fbe7d Wladimir J. van der Laan: Merge #14778: A few minor formatting fixes and clarifications to descriptors.md...

2018-11-22

< bitcoin-git> [bitcoin] kristapsk opened pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14788: tests: Possible fix the permission error when the tests open the cookie file (master...fix-win-test-perm-deny) https://github.com/bitcoin/bitcoin/pull/14788
< bitcoin-git> [bitcoin] merland opened pull request #14787: Replace old instructions with links to official docs (master...issue14639) https://github.com/bitcoin/bitcoin/pull/14787
< bitcoin-git> [bitcoin] jl2012 opened pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14747: build: Drop AC_CHECK_DECLS for unused __builtin_clz (master...builtin-clz) https://github.com/bitcoin/bitcoin/pull/14747
< sipa> cjd: long time no see here, i think we met in 2011 or 2012 at a bitcoin conference
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14777: tests: Add regtest for JSON-RPC batch calls (master...batch-rpc) https://github.com/bitcoin/bitcoin/pull/14777
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a97f192ea92...3dda4c5f037b
< bitcoin-git> bitcoin/master 3d2c7d6 Daniel Kraft: Add regtest for JSON-RPC batch calls....
< bitcoin-git> bitcoin/master 3dda4c5 MarcoFalke: Merge #14777: tests: Add regtest for JSON-RPC batch calls...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/708cbb172dbf...2a97f192ea92
< bitcoin-git> bitcoin/master fa21ca0 MarcoFalke: test: Add BOOST_REQUIRE to getters returning optional
< bitcoin-git> bitcoin/master 2a97f19 MarcoFalke: Merge #14771: test: Add BOOST_REQUIRE to getters returning optional...
< cjd> Quick, call a vote to change bitcoin over to proof of stake ;)
< bitcoin-git> [bitcoin] cornelius opened pull request #14785: Scripts: Fix detection of copyright holders (master...copyright-header) https://github.com/bitcoin/bitcoin/pull/14785
< bitcoin-git> [bitcoin] promag opened pull request #14784: qt: Don't use the wallet name as map key (master...2018-11-qtwalletmodel) https://github.com/bitcoin/bitcoin/pull/14784
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14708 | Warn unrecognised sections in the config file by AkioNak · Pull Request #14708 · bitcoin/bitcoin · GitHub
< promag> maybe we should just call `noui_connect()` in bitcoin-qt?
< bitcoin-git> [bitcoin] promag opened pull request #14783: qt: Fix boost::signals2::no_slots_error in early calls to InitWarning (master...2018-11-fix-noslotserror) https://github.com/bitcoin/bitcoin/pull/14783
< bitcoin-git> [bitcoin] laanwj closed pull request #14756: Improve rpcauth.py by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e77a2258e4da...708cbb172dbf
< bitcoin-git> bitcoin/master d6cde00 João Barbosa: rpcauth: Improve by using argparse and getpass modules
< bitcoin-git> bitcoin/master 708cbb1 Wladimir J. van der Laan: Merge #14756: Improve rpcauth.py by using argparse and getpass modules...
< gribble> https://github.com/bitcoin/bitcoin/issues/14756 | Improve rpcauth.py by using argparse and getpass modules by promag · Pull Request #14756 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/e736b67467ef...e77a2258e4da
< bitcoin-git> bitcoin/master 3615003 Luke Dashjr: net: Always default rpcbind to localhost, never "all interfaces"...
< bitcoin-git> bitcoin/master d6a1287 Luke Dashjr: CNetAddr: Add IsBindAny method to check for INADDR_ANY
< bitcoin-git> bitcoin/master 27c44ef Luke Dashjr: rpcbind: Warn about exposing RPC to untrusted networks
< bitcoin-git> [bitcoin] laanwj closed pull request #14715: Drop defunct prevector compat handling (master...trivial-prevector) https://github.com/bitcoin/bitcoin/pull/14715
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d7b0258ff037...e736b67467ef
< bitcoin-git> bitcoin/master 7bad78c Ben Woosley: Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h...
< bitcoin-git> bitcoin/master 69ca487 Ben Woosley: Implement prevector::fill once...
< bitcoin-git> bitcoin/master e736b67 Wladimir J. van der Laan: Merge #14715: Drop defunct prevector compat handling...
< bitcoin-git> [bitcoin] luke-jr opened pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git> [bitcoin] luke-jr closed pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git> [bitcoin] luke-jr opened pull request #14782: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (0.17...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14782
< bitcoin-git> [bitcoin] sipa opened pull request #14780: PSBT backports to 0.17 (0.17...201811_psbt_backports_0.17) https://github.com/bitcoin/bitcoin/pull/14780
< gmaxwell> Stackexchange deleted the question, but this person: https://github.com/rollmeister/bitcoin-armv8/blob/master/src/crypto/sha256.cpp showed up asking some questions about optimizing sha256d64 for arm, he says the code he has there speeds up his sync 2x.
< gmaxwell> "I have made progress and while the current implementation is 20% slower than it could be it is still five times faster than before and think I will settle for that. Details are in my bitcoin-armv8 repo. It is reindexing my copy of the bitcoin blockchain at over double the pace."

2018-11-21

< bitcoin-git> [bitcoin] jnewbery opened pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< luke-jr> dgpv: here, you can submit this if you want: https://github.com/luke-jr/bitcoin/pull/new/sort-multisigs-0.17
< gribble> https://github.com/bitcoin/bitcoin/issues/8751 | RPC: Add parameter to addmultisigaddress / createmultisig to sort public keys by afk11 · Pull Request #8751 · bitcoin/bitcoin · GitHub
< dgpv> sipa: actually my initial question was should I submit a PR with change for sortedmulti() or just create an issue on bitcoin core github
< sipa> all i'm saying is that i don't think it makes sense to commit to "bitcoin core aims to be interoperable with software X"
< gmaxwell> dgpv: Seriously, the bitcoin project has been held back for years by misguided efforts towards interoperability with a largely indifferent industry. It's a bit irritating that you're advocating us burning more time here on this particular point of it, because it would be useful in your product.
< bitcoin-git> [bitcoin] laanwj closed pull request #14708: Warn unrecognised sections in the config file (master...warn_unrecognized_section) https://github.com/bitcoin/bitcoin/pull/14708
< sipa> dgpv: so far, the bitcoin core wallet also hasn't really supported HD chains created by other software as import
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/16498860546e...d7b0258ff037
< bitcoin-git> bitcoin/master 3fb09b9 Akio Nakamura: Warn unrecognized sections in the config file...
< bitcoin-git> bitcoin/master d7b0258 Wladimir J. van der Laan: Merge #14708: Warn unrecognised sections in the config file...
< bitcoin-git> [bitcoin] laanwj closed pull request #14719: qa: Check specific reject reasons in feature_block (master...Mf1811-qaRejectBlock) https://github.com/bitcoin/bitcoin/pull/14719
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/267793af8b03...16498860546e
< bitcoin-git> bitcoin/master fa7da06 MarcoFalke: qa: Check specific reject reasons in feature_block
< bitcoin-git> bitcoin/master 1649886 Wladimir J. van der Laan: Merge #14719: qa: Check specific reject reasons in feature_block...
< wumpus> please, don't insist. you could also try the bitcoin stack exchange (https://bitcoin.stackexchange.com/) if #bitcoin yields nothing
< phantomcircuit> dawud, still this channel is about bitcoin core development
< wumpus> ask general question in #bitcoin please
< gribble> https://github.com/bitcoin/bitcoin/issues/14777 | tests: Add regtest for JSON-RPC batch calls by domob1812 · Pull Request #14777 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] domob1812 opened pull request #14777: tests: Add regtest for JSON-RPC batch calls (master...batch-rpc) https://github.com/bitcoin/bitcoin/pull/14777
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6b90a2a0e065...267793af8b03
< bitcoin-git> bitcoin/master 6be7d14 Carl Dong: Properly generate salt in rpcauth.py, update tests...
< bitcoin-git> bitcoin/master 267793a Wladimir J. van der Laan: Merge #14742: Properly generate salt in rpcauth.py...
< bitcoin-git> [bitcoin] jameshilliard opened pull request #14776: Add process based prctl spectre mitigation controls. (master...spectre-prctl) https://github.com/bitcoin/bitcoin/pull/14776
< bitcoin-git> [bitcoin] dooglus opened pull request #14775: 'break' should be 'continue' here? (master...patch-6) https://github.com/bitcoin/bitcoin/pull/14775
< bitcoin-git> [bitcoin] kallewoof opened pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
< TGeek> Hi all, I am having an issue in bitcoin core 0.17.0.1 with the bumpfee rpc call.. It keeps throwing an error "(-4) Transaction does not have a change output". Which is strange because the output for the tx has two outputs, one for the to address and one for change. I have been troubleshooting this issue for 2 days now and cannot seem to find anything related in searches.. Any help would be greatly appreciated.

2018-11-20

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] vim88 closed pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
< wumpus> look, there's this concern we haven't even ever *thought* about and suddenly it needs to be considered in bitcoin core
< provoostenator> That makes sense. It might be good to document that intention to set expectations: https://github.com/bitcoin/bitcoin/blob/master/doc/REST-interface.md
< gribble> https://github.com/bitcoin/bitcoin/issues/11803 | Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet by luke-jr · Pull Request #11803 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14770: travis: Do not specify sudo in .travis (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14770
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afa506f6ebeb...6b90a2a0e065
< bitcoin-git> bitcoin/master feeef7d Julian Fleischer: Do not specify sudo in .travis...
< bitcoin-git> bitcoin/master 6b90a2a Wladimir J. van der Laan: Merge #14770: travis: Do not specify sudo in .travis...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14755: Remove redundant readme info in /doc (master...issue-14639) https://github.com/bitcoin/bitcoin/pull/14755
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< wumpus> LGzr: I think https://bitcoin.stackexchange.com/ is the best place to ask such things
< LGzr> Hola, all. I've a question about the p2sh example at https://bitcoin.org/en/developer-examples#p2sh-multisig; is there a more appropriate forum than here? (Question is: what purpose it serves that createmultisig uses public key for one, and addresses for the others)
< bitcoin-git> [bitcoin] scravy opened pull request #14770: Do not specify sudo in .travis (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14770
< bitcoin-git> [bitcoin] laanwj closed pull request #14552: wallet: detecting duplicate wallet by comparing the db filename. (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b99d153d071...afa506f6ebeb
< bitcoin-git> bitcoin/master c456fbd Russell Yanofsky: Refactor: Move m_db pointers into BerkeleyDatabase...
< bitcoin-git> bitcoin/master 15c93f0 Chun Kuan Lee: wallet: Add trailing wallet.dat when detecting duplicate wallet if it's a directory.
< bitcoin-git> bitcoin/master 5912031 Chun Kuan Lee: wallet: Create IsDatabaseLoaded function
< bitcoin-git> [bitcoin] laanwj closed pull request #14768: revert removal of fstream.hpp header in fs.h (master...restore-fs-h-include-boost-fs-fstream) https://github.com/bitcoin/bitcoin/pull/14768
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/09f1d7fe7243...1b99d153d071
< bitcoin-git> bitcoin/master e816b34 Karl-Johan Alm: revert removal of fstream.hpp header in fs.h...
< bitcoin-git> bitcoin/master 1b99d15 Wladimir J. van der Laan: Merge #14768: revert removal of fstream.hpp header in fs.h...
< bitcoin-git> [bitcoin] MeshCollider closed pull request #14763: Remove filesystem/fstream from EXPECTED_BOOST_INCLUDES (master...2018/11/expected_boost_includes) https://github.com/bitcoin/bitcoin/pull/14763
< bitcoin-git> [bitcoin] kallewoof opened pull request #14768: revert removal of fstream.hpp header in fs.h (master...restore-fs-h-include-boost-fs-fstream) https://github.com/bitcoin/bitcoin/pull/14768
< bitcoin-git> [bitcoin] qqz898 closed pull request #14766: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14766
< bitcoin-git> [bitcoin] qqz898 closed pull request #14766: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14766
< bitcoin-git> [bitcoin] qqz898 opened pull request #14766: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14766

2018-11-19

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14764: travis: Run thread sanitizer (master...Mf1811-travisSanThread) https://github.com/bitcoin/bitcoin/pull/14764
< bitcoin-git> [bitcoin] Sjors opened pull request #14763: Remove filesystem/fstream from EXPECTED_BOOST_INCLUDES (master...2018/11/expected_boost_includes) https://github.com/bitcoin/bitcoin/pull/14763
< gribble> https://github.com/bitcoin/bitcoin/issues/14718 | Remove unreferenced boost headers by murrayn · Pull Request #14718 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14718: Remove unreferenced boost headers (master...clang_warnings) https://github.com/bitcoin/bitcoin/pull/14718
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d58a5c3b055...09f1d7fe7243
< bitcoin-git> bitcoin/master c54e5a4 Murray Nesbitt: Remove unreferenced boost headers
< bitcoin-git> bitcoin/master 09f1d7f MarcoFalke: Merge #14718: Remove unreferenced boost headers...
< bitcoin-git> [bitcoin] mmachicao opened pull request #14761: Tests : timedata : median file filter shall not grow beyond size (master...timedata_tests) https://github.com/bitcoin/bitcoin/pull/14761
< bitcoin-git> [bitcoin] promag opened pull request #14760: Log env path in BerkeleyEnvironment::Flush (master...2018-11-logmultienvflush) https://github.com/bitcoin/bitcoin/pull/14760
< bitcoin-git> [bitcoin] practicalswift closed pull request #14757: Avoid reading uninitialized variables in serialization code (triggered when running "make check") (master...avoid-read-of-uninitialized-variable) https://github.com/bitcoin/bitcoin/pull/14757
< bitcoin-git> [bitcoin] practicalswift opened pull request #14757: Avoid reading uninitialized variables in serialization code (triggered when running "make check") (master...avoid-read-of-uninitialized-variable) https://github.com/bitcoin/bitcoin/pull/14757
< bitcoin-git> [bitcoin] promag opened pull request #14756: Improve by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< bitcoin-git> [bitcoin] merland opened pull request #14755: Remove redundant readme info in /doc (master...issue-14639) https://github.com/bitcoin/bitcoin/pull/14755
< gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12721 | Qt: remove "new" button during receive-mode in addressbook by jonasschnelli · Pull Request #12721 · bitcoin/bitcoin · GitHub
< gmaxwell> (I've seen other people get tricked into thinking that 'classic' is the orignal bitcoin. .. the most amusing of which was some post after BU caught fire that tried to claim that BU's problems were mostly because the original bitcoin software was such crap, and then went after a bunch of bugs in 'classic' that either never were in Bitcoin or had long since been fixed. :P )
< BlueMatt> you'll note the snaps in this case were pretty clearly some bitcoin classic troll
< gmaxwell> oh jesus. it's bitcoin "classic"?
< BlueMatt> no idea, the link to the "developer site" is bitcoin classic
< gmaxwell> occurs at the early startup stage of bitcoin-qt, it renders bitcoin-qt
< BlueMatt> afaict openssl 1.1 is completely 100% fucked for bitcoin-qt
< BlueMatt> so it says bitcoin isnt installed via the snap installer thinggy (the ubuntu software center)

2018-11-18

< zallarak> Any other eyes on this PR appreciated (https://github.com/bitcoin/bitcoin/pull/14733 - adding p2ptimeout to be configurable). Left a comment on test output.
< bitcoin-git> [bitcoin] vim88 opened pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
< bitcoin-git> [bitcoin] domob1812 opened pull request #14752: tests: Unit tests for IsPayToWitnessScriptHash and IsWitnessProgram (master...script-segwit-tests) https://github.com/bitcoin/bitcoin/pull/14752
< bitcoin-git> [bitcoin] laanwj closed pull request #14685: fix a deserialization overflow edge case (master...master) https://github.com/bitcoin/bitcoin/pull/14685
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/35739976c1d9...6d58a5c3b055
< bitcoin-git> bitcoin/master 051faf7 Kaz Wesley: add a test demonstrating an overflow in a deserialization edge case...
< bitcoin-git> bitcoin/master 6bed4b3 Kaz Wesley: fix a deserialization overflow edge case...
< bitcoin-git> bitcoin/master b08af10 Kaz Wesley: disallow oversized CBlockHeaderAndShortTxIDs...

2018-11-17

< zallarak> Thank you to those that left feedback on my PR. Does anyone else have thoughts? (https://github.com/bitcoin/bitcoin/pull/14733)
< bitcoin-git> [bitcoin] vim88 closed pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
< bitcoin-git> [bitcoin] vim88 opened pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
< dongcarl> Would it be possible to block a user from bitcoin/bitcoin? This guy's been spamming: https://github.com/bitcoin/bitcoin/pull/14742#issuecomment-439635586
< bitcoin-git> [bitcoin] Empact opened pull request #14747: build: Drop AC_CHECK_DECLS for unused __builtin_clz (master...builtin-clz) https://github.com/bitcoin/bitcoin/pull/14747
< bitcoin-git> [bitcoin] IPGlider closed pull request #14746: Check for invalid prefixes in config file (master...check_invalid_prefixes_in_config_file) https://github.com/bitcoin/bitcoin/pull/14746
< bitcoin-git> [bitcoin] IPGlider opened pull request #14746: Check for invalid prefixes in config file (master...check_invalid_prefixes_in_config_file) https://github.com/bitcoin/bitcoin/pull/14746
< bitcoin-git> [bitcoin] LucianaMarques opened pull request #14744: [Docs] Added NSIS install steps to build-windows.md (master...windows-doc) https://github.com/bitcoin/bitcoin/pull/14744
< dongcarl> we require python 3.4 for tests according to https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md
< bitcoin-git> [bitcoin] dongcarl opened pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
< dongcarl> Any reason why `bitcoin/share/rpcauth/rpcauth.py` generates a 16 byte salt instead of a 32 byte salt? I believe RFC 2104 recommends the key length to be larger than or equal to the hash output length: https://tools.ietf.org/html/rfc2104#section-3
< gribble> https://github.com/bitcoin/bitcoin/issues/14733 | p2p: allow p2ptimeout to be configurable, speed up slow test by zallarak · Pull Request #14733 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl opened pull request #14741: Indicate -rpcauth option password hashing alg (master...2018-11-improve-rpcauth-help) https://github.com/bitcoin/bitcoin/pull/14741

2018-11-16

< bitcoin-git> [bitcoin] sp4ke opened pull request #14740: Update `rpcbind` doc to match the manpage closes #9272 (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
< zallarak> MarcoFalke: friendly ping if you have any thoughts on the revised PR I submitted (https://github.com/bitcoin/bitcoin/pull/14733)
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
< gwillen> instagibbs: no update, other than I think https://github.com/bitcoin/bitcoin/pull/14588 getting in happened since the last time we had this meeting
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kristapsk opened pull request #14738: Fix running wallet_listtransactions.py individually through test_runner.py (master...listtransactions) https://github.com/bitcoin/bitcoin/pull/14738
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14731: doc: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/384967f311b4...35739976c1d9
< bitcoin-git> bitcoin/master 07e286d Carl Dong: Improve scripted-diff developer docs...
< bitcoin-git> bitcoin/master 3573997 MarcoFalke: Merge #14731: doc: Improve scripted-diff developer docs...
< Dizzle_> luke-jr: if the mined block is proposed to Bitcoin Core via getblock template, it gets called, and I couldn't find an indication that a valid proposal gets submitted by Core.
< gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kazcw opened pull request #14734: fix an undefined behavior in uint::SetHex (master...SetHex-bad-ptr) https://github.com/bitcoin/bitcoin/pull/14734

2018-11-15

< bitcoin-git> [bitcoin] zallarak opened pull request #14733: p2p: allow p2ptimeout to be configurable, speed up slow test (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
< sipa> Vita: #bitcoin-wizards or so, off topic here
< stevenroose> who is maintaining the gnusha.org logs? Are they open to adding more channels? We were thinging we'd love one for #rust-bitcoin
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/e74649e95122...384967f311b4
< bitcoin-git> bitcoin/master 7c5bc2a practicalswift: miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee
< bitcoin-git> bitcoin/master 145fe95 practicalswift: tests: Check return value of ParseParameters(...)
< bitcoin-git> bitcoin/master 579497e practicalswift: tests: Explicitly ignore the return value of DecodeBase58(...)
< MarcoFalke> Git should be installed on the machine, so you could do "git fetch https://github.com/promag/bitcoin branch && git merge FETCH_HEAD" before compiling?
< gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 current high priority PRs are by luke-jr promag achow101 phantomcircuit sipa
< gribble> https://github.com/bitcoin/bitcoin/issues/14552 | wallet: detecting duplicate wallet by comparing the db filename. by ken2812221 · Pull Request #14552 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] dongcarl opened pull request #14731: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
< bitcoin-git> [bitcoin] qubenix opened pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729

2018-11-14

< bitcoin-git> [bitcoin] kazcw opened pull request #14728: fix uninitialized read when stringifying an addrLocal (master...uninit-scopeid) https://github.com/bitcoin/bitcoin/pull/14728
< phantomcircuit> core_, mastering bitcoin is basically just a copy of the wiki
< core_> i am just starting with bitcoin core and I'm a little confused with the architecture
< core_> specifically how the client wallet fits in and connects to what pieces of the system (as shown in mastering bitcoin architecture diagram)
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14411: [wallet] Restore ability to list incoming transactions by label (master...pr/list-label) https://github.com/bitcoin/bitcoin/pull/14411
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7366d2399e2...e74649e95122
< bitcoin-git> bitcoin/master 65b740f Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git> bitcoin/master da427db Russell Yanofsky: Rename ListTransactions filter variable...
< bitcoin-git> bitcoin/master e74649e MarcoFalke: Merge #14411: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14478: Show error to user when corrupt wallet unlock fails (master...201810_wallet_corruption_error) https://github.com/bitcoin/bitcoin/pull/14478
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e8f9dc2bbb1...c7366d2399e2
< bitcoin-git> bitcoin/master b4f6e58 MeshCollider: Better error message for user when corrupt wallet unlock fails
< bitcoin-git> bitcoin/master c7366d2 MarcoFalke: Merge #14478: Show error to user when corrupt wallet unlock fails...
< gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14594 | qt: Fix minimized window bug on Linux by hebasto · Pull Request #14594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14577 | qt: Cleanup `textInteractionFlags` for `QLabel` by hebasto · Pull Request #14577 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14704: doc: add detached release notes for #14060 (master...zmq-release-notes) https://github.com/bitcoin/bitcoin/pull/14704
< bitcoin-git> [bitcoin] laanwj closed pull request #14688: Doc: update release notes for changes since 0.17.0 branch (master...2018-11-release-notes) https://github.com/bitcoin/bitcoin/pull/14688
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99a3e6f0b1ab...2e8f9dc2bbb1
< bitcoin-git> bitcoin/master 86cddf0 mruddy: doc: add detached release notes for #14060
< bitcoin-git> bitcoin/master 2e8f9dc Wladimir J. van der Laan: Merge #14704: doc: add detached release notes for #14060...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/74213fa4d13e...99a3e6f0b1ab
< bitcoin-git> bitcoin/master 6062f0e David A. Harding: Release notes: update notes through to 11e1ac3ae08
< bitcoin-git> bitcoin/master ba8f0c6 David A. Harding: Release notes: integrate detached release notes
< bitcoin-git> bitcoin/master 99a3e6f Wladimir J. van der Laan: Merge #14688: Doc: update release notes for changes since 0.17.0 branch...
< gribble> https://github.com/bitcoin/bitcoin/issues/14688 | Doc: update release notes for changes since 0.17.0 branch by harding · Pull Request #14688 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14704 | doc: add detached release notes for #14060 by mruddy · Pull Request #14704 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/33cd94279cd6...74213fa4d13e
< bitcoin-git> bitcoin/master 2bc3f11 Hennadii Stepanov: Bump the minimum Qt version to 5.2
< bitcoin-git> bitcoin/master 74213fa Wladimir J. van der Laan: Merge #14725: qt: Bump the minimum Qt version to 5.2...
< gribble> https://github.com/bitcoin/bitcoin/issues/14723 | Build with official Qt binary installer fails · Issue #14723 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14727 | Mac OSX High Sierra 10.13.6 Build error · Issue #14727 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14698: build: Add bitcoin-tx.exe into Windows installer (master...win-bitcoin-tx) https://github.com/bitcoin/bitcoin/pull/14698
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c59bb85f979...33cd94279cd6
< bitcoin-git> bitcoin/master 5c5902a Chun Kuan Lee: build: Add bitcoin-tx.exe into Windows installer
< bitcoin-git> bitcoin/master 33cd942 Wladimir J. van der Laan: Merge #14698: build: Add bitcoin-tx.exe into Windows installer...
< gribble> https://github.com/bitcoin/bitcoin/issues/14698 | build: Add bitcoin-tx.exe into Windows installer by ken2812221 · Pull Request #14698 · bitcoin/bitcoin · GitHub
< booyah> zhangzf: also, with such usage questions come to #bitcoin - there are more users to help. Also this channel here is only for developers of bitcoin itself so it's not good to ask here
< sipa> zhangzf: no, Bitcoin Core always runs as a full node
< zhangzf> #bitcoin
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14726: Use RPCHelpMan for all RPCs (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14726
< zhangzf> Hi everybody! Bitcoin core can run on Android?
< sipa> esotericnonsense: probably move to #bitcoin

2018-11-13

< bitcoin-git> [bitcoin] hebasto opened pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
< jarthur> Also, this is the development channel. #bitcoin is the place to ask general network usage questions.
< bralyclow> anyone around, posting a question I need your help with...question everyone, I have a bitcoin core full node and wallet, I tried sending a transaction today from a wallet on the node that spent all the BTC in all associated addresses at 1 satoshi per byte and the transaction has been unconfirmed now for over 8 hours which it should have been picked up by this 8 hour timeframe, my question is how can I increase the fee when ther
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f617e05c38c9...8c59bb85f979
< bitcoin-git> bitcoin/master fa0815c Jon Layton: rpc: Correctly name arguments
< bitcoin-git> bitcoin/master 8c59bb8 MarcoFalke: Merge #14720: rpc: Correctly name arguments...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14712: wallet: Require a start block in ScanForWalletTransactions (master...Mf1811-walletCrashScan) https://github.com/bitcoin/bitcoin/pull/14712
< gribble> https://github.com/bitcoin/bitcoin/issues/14721 | developer doc: Source code organization for standalone (util) functions · Issue #14721 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c651265c934c...f617e05c38c9
< bitcoin-git> bitcoin/master 7afddfa Gregory Sanders: importmulti: Don't add internal addresses to address book
< bitcoin-git> bitcoin/master f617e05 Wladimir J. van der Laan: Merge #14679: importmulti: Don't add internal addresses to address book...
< gribble> https://github.com/bitcoin/bitcoin/issues/14679 | importmulti: Dont add internal addresses to address book by instagibbs · Pull Request #14679 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
< bitcoin-git> [bitcoin] Empact closed pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14530: Use RPCHelpMan to generate RPC doc strings (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0c6bb782308...c651265c934c