2019-08-19

< bitcoin-git> [bitcoin] dongcarl closed pull request #15672: [WIP] docs: Improve net comments (master...2019-02-net-comments) https://github.com/bitcoin/bitcoin/pull/15672
< bitcoin-git> [bitcoin] practicalswift opened pull request #16659: refactoring: Remove unused includes (master...unused-includes) https://github.com/bitcoin/bitcoin/pull/16659
< bitcoin-git> [bitcoin] jnewbery opened pull request #16658: [validation] Rename CheckInputs to CheckInputScripts (master...2019-08-rename-CheckInputs) https://github.com/bitcoin/bitcoin/pull/16658
< bitcoin-git> [bitcoin] cvasqxz opened pull request #16657: Fix UpdateTip LogPrintf() whitespaces (master...master) https://github.com/bitcoin/bitcoin/pull/16657
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #16656: QA: fix rpc_setban.py race (master...2019/08/rpc_setban) https://github.com/bitcoin/bitcoin/pull/16656
< elichai2> sipa: https://github.com/bitcoin/bitcoin/issues/15621 requires a batch `secp256k1_ecdsa_recover` that recieves a list of signatures and returns a list of affine public keys, right?
< bitcoin-git> [bitcoin] laanwj merged pull request #16611: build: Remove src/obj directory from repository (master...2019_08_srcobj) https://github.com/bitcoin/bitcoin/pull/16611
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd62f8d6eed8...e00ecb3d7aae
< bitcoin-git> bitcoin/master b6e9ff8 Wladimir J. van der Laan: build: Remove src/obj directory from repository
< bitcoin-git> bitcoin/master e00ecb3 Wladimir J. van der Laan: Merge #16611: build: Remove src/obj directory from repository
< bitcoin-git> [bitcoin] konez2k opened pull request #16655: RPC: Extract scriptPubKey on getreceivedbyaddress (master...rpcwallet_patch) https://github.com/bitcoin/bitcoin/pull/16655
< bitcoin-git> [bitcoin] laanwj merged pull request #16645: doc: initial RapidCheck property-based testing documentation (master...rapidcheck-documentation) https://github.com/bitcoin/bitcoin/pull/16645
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83112db129de...bd62f8d6eed8
< bitcoin-git> bitcoin/master 8616c81 Jon Atack: doc: initial RapidCheck property-based testing documentation
< bitcoin-git> bitcoin/master bd62f8d Wladimir J. van der Laan: Merge #16645: doc: initial RapidCheck property-based testing documentation...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16625: scripts: remove github-merge.py (master...remove_github_merge_script) https://github.com/bitcoin/bitcoin/pull/16625
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15864: Fix datadir handling (master...20190421-datadir-handling) https://github.com/bitcoin/bitcoin/pull/15864
< bitcoin-git> bitcoin/master c1f3251 Hennadii Stepanov: Return absolute path early in AbsPathForConfigVal
< bitcoin-git> bitcoin/master 740d41c Hennadii Stepanov: Add CheckDataDirOption() function
< bitcoin-git> bitcoin/master 5082409 Hennadii Stepanov: Fix datadir handling in bitcoind
< bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/8b42db130ffd...83112db129de
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16623: ci: Add environment files for all settings (master...1908-ciEnv) https://github.com/bitcoin/bitcoin/pull/16623
< bitcoin-git> bitcoin/master fa21737 MarcoFalke: ci: Add environment files for all settings
< bitcoin-git> bitcoin/master 8b42db1 MarcoFalke: Merge #16623: ci: Add environment files for all settings
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1d74693e8a96...8b42db130ffd
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16555: doc: mention whitelist is inbound, and applies to blocksonly (master...2019/08/doc-whitelistrelay) https://github.com/bitcoin/bitcoin/pull/16555
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c79bf3277422...1d74693e8a96
< bitcoin-git> bitcoin/master 20ea9ef Sjors Provoost: [doc] mention whitelist is inbound, and applies to blocksonly
< bitcoin-git> bitcoin/master 1d74693 MarcoFalke: Merge #16555: doc: mention whitelist is inbound, and applies to blocksonly...
< gribble> https://github.com/bitcoin/bitcoin/issues/16608 | [0.18] Backport #15911: Use wallet RBF default for walletcreatefundedpsbt by Sjors · Pull Request #16608 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/43cf76b19395...00ffe5aca134
< bitcoin-git> bitcoin/0.18 ee950ec Sjors Provoost: [rpc] walletcreatefundedpsbt: use wallet default RBF
< bitcoin-git> bitcoin/0.18 0942a60 Sjors Provoost: [doc] rpc: remove "fallback to" from RBF default help
< bitcoin-git> bitcoin/0.18 576580f Sjors Provoost: [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16608: [0.18] Backport #15911: Use wallet RBF default for walletcreatefundedpsbt (0.18...2018/08/backport-wallet-rbf-default) https://github.com/bitcoin/bitcoin/pull/16608
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/27ee0cc5a6d9...c79bf3277422
< bitcoin-git> bitcoin/master 6c27fa0 fanquake: scripts: remove github-merge.py
< bitcoin-git> bitcoin/master c79bf32 Wladimir J. van der Laan: Merge #16625: scripts: remove github-merge.py
< bitcoin-git> [bitcoin] jonatack opened pull request #16654: [WIP] build: update RapidCheck Makefile (master...build-update-rapidcheck-makefile) https://github.com/bitcoin/bitcoin/pull/16654
< bitcoin-git> [bitcoin] laanwj merged pull request #16646: qa: Run tests with UPnP disabled (master...add_upnp_to_test_framework_conf) https://github.com/bitcoin/bitcoin/pull/16646
< bitcoin-git> bitcoin/master 27ee0cc Wladimir J. van der Laan: Merge #16646: qa: Run tests with UPnP disabled
< bitcoin-git> [bitcoin] laanwj merged pull request #16631: net: Restore default whitelistrelay to true (master...fix/default-whiterelay) https://github.com/bitcoin/bitcoin/pull/16631
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ed9a2a37c187...27ee0cc5a6d9
< bitcoin-git> bitcoin/master b168dd3 Luke Dashjr: Bugfix: QA: Run tests with UPnP disabled
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91ed1b3e06d5...ed9a2a37c187
< bitcoin-git> bitcoin/master ce7eac3 nicolas.dorier: [Fix] The default whitelistrelay should be true
< bitcoin-git> bitcoin/master 3b05f0f nicolas.dorier: Reformat p2p_permissions.py
< bitcoin-git> bitcoin/master ed9a2a3 Wladimir J. van der Laan: Merge #16631: net: The default whitelistrelay should be true
< bitcoin-git> [bitcoin] laanwj merged pull request #16634: doc: Refer in rpcbind doc to the manpage (master...1908-docManPage) https://github.com/bitcoin/bitcoin/pull/16634
< bitcoin-git> [bitcoin] laanwj closed pull request #14740: docs: Update rpcbind doc to match the manpage (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48e5bfe22405...91ed1b3e06d5
< bitcoin-git> bitcoin/master fa0119a MarcoFalke: doc: Refer in rpcbind doc to the manpage
< bitcoin-git> bitcoin/master 91ed1b3 Wladimir J. van der Laan: Merge #16634: doc: Refer in rpcbind doc to the manpage
< coinmonks> The 1 response I got (I won't name them),,tells that he is a freelancer, want to work on Bitcoin fulltime and currently use some economic help in that direction..
< coinmonks> We can always help these folks and create a path for more people working fulltime on Bitcoin
< coinmonks> I want to understand how BItcoin protocol development is getting funded now and are contributors in good economic condition
< coinmonks> Wanna look into a cool Bitcoin contributors visualisation? here you go - https://twitter.com/coincodecap/status/1163362262431571968
< coinmonks> Also I have created a survey to understand Bitcoin protocol development.. So for only 1 person filled it.. I would like you pls take 2 minutes and check it ..
< bitcoin-git> [bitcoin] kallewoof opened pull request #16653: script: add simple signature support (checker/creator) (master...2019-08-genpursigs) https://github.com/bitcoin/bitcoin/pull/16653
< bitcoin-git> [bitcoin] fanquake closed pull request #16652: Delete .python-version (master...master) https://github.com/bitcoin/bitcoin/pull/16652
< bitcoin-git> [bitcoin] ericcaclew opened pull request #16652: Delete .python-version (master...master) https://github.com/bitcoin/bitcoin/pull/16652
< bitcoin-git> [bitcoin] fanquake closed pull request #16651: Delete .python-version (master...master) https://github.com/bitcoin/bitcoin/pull/16651
< bitcoin-git> [bitcoin] ericcaclew opened pull request #16651: Delete .python-version (master...master) https://github.com/bitcoin/bitcoin/pull/16651
< bitcoin-git> [bitcoin] ericcaclew opened pull request #16650: Delete .python-version/@ericca (master...master) https://github.com/bitcoin/bitcoin/pull/16650
< bitcoin-git> [bitcoin] fanquake closed pull request #16650: Delete .python-version/@ericca (master...master) https://github.com/bitcoin/bitcoin/pull/16650
< bitcoin-git> [bitcoin] fanquake closed pull request #16649: @ericca (0.16...master) https://github.com/bitcoin/bitcoin/pull/16649
< bitcoin-git> [bitcoin] ericcaclew opened pull request #16649: @ericca (0.16...master) https://github.com/bitcoin/bitcoin/pull/16649
< bitcoin-git> [bitcoin] fanquake closed pull request #16648: ericcaclew (0.16...master) https://github.com/bitcoin/bitcoin/pull/16648
< bitcoin-git> [bitcoin] ericcaclew opened pull request #16648: ericcaclew (0.16...master) https://github.com/bitcoin/bitcoin/pull/16648
< bitcoin-git> [bitcoin] kallewoof closed pull request #16630: consensus: skip genesis block POW check (master...2019-08-validation-skip-genesis-pow) https://github.com/bitcoin/bitcoin/pull/16630
< bitcoin-git> [bitcoin] fanquake closed pull request #14649: RPC: add weight to mempool entry output (master...rpc_mempoolentry_weight) https://github.com/bitcoin/bitcoin/pull/14649
< bitcoin-git> [bitcoin] fanquake opened pull request #16647: rpc: add weight to getmempoolentry output (master...rpc_mempoolentry_weight_rebased_release_notes) https://github.com/bitcoin/bitcoin/pull/16647
< bitcoin-git> [bitcoin] fanquake closed pull request #16560: Bugfix: QA: Run tests with UPnP disabled (master...test_without_upnp) https://github.com/bitcoin/bitcoin/pull/16560
< bitcoin-git> [bitcoin] fanquake opened pull request #16646: Bugfix: QA: Run tests with UPnP disabled (master...add_upnp_to_test_framework_conf) https://github.com/bitcoin/bitcoin/pull/16646
< bitcoin-git> [bitcoin] fanquake merged pull request #16643: doc: Add ZMQ dependencies to the Fedora build instructions (master...20190818-doc-fedora-zmq) https://github.com/bitcoin/bitcoin/pull/16643
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e8a6d5272465...48e5bfe22405
< bitcoin-git> bitcoin/master dc1bc1c Hennadii Stepanov: doc: Add ZMQ dependencies to Fedora build
< bitcoin-git> bitcoin/master 48e5bfe fanquake: Merge #16643: doc: Add ZMQ dependencies to the Fedora build instructions
< bitcoin-git> [bitcoin] promag closed pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515

2019-08-18

< bitcoin-git> [bitcoin] jonatack opened pull request #16645: doc: initial RapidCheck property-based testing documentation (master...rapidcheck-documentation) https://github.com/bitcoin/bitcoin/pull/16645
< bitcoin-git> [bitcoin] meshcollider merged pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
< bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1124be6111d6...e8a6d5272465
< bitcoin-git> bitcoin/master c325f61 Andrew Chow: Return an error from descriptor Parse that gives more information about wh...
< bitcoin-git> bitcoin/master 625534d Andrew Chow: Give more errors for specific failure conditions
< bitcoin-git> bitcoin/master 6e1ae58 Andrew Chow: Check error messages in descriptor tests
< harding> kakobrekla: that question (and any followups you have) may be better asked in #bitcoin. The answer is that P2WPKH uses a 20-byte hash RIPEMD(SHA256()) and P2WSH uses a 32-byte hash SHA256(). For details, see https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#P2WSH
< bitcoin-git> [bitcoin] GChuf opened pull request #16644: scripts: attempt to fix some translations in update-translations.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16644
< bitcoin-git> [bitcoin] hebasto opened pull request #16643: doc: Add ZMQ dependencies to the Fedora build instructions (master...20190818-doc-fedora-zmq) https://github.com/bitcoin/bitcoin/pull/16643
< hebasto> fanquake: is Mine8801's activity in the bitcoin repo needed to be moderated?

2019-08-17

< bitcoin-git> [bitcoin] hebasto opened pull request #16641: refactor: Remove redundant PSBT copy constructor (master...20190817-psbt-copy-ctor) https://github.com/bitcoin/bitcoin/pull/16641
< bitcoin-git> [bitcoin] Sjors opened pull request #16639: [0.17] abort when attempting to fund a transaction above -maxtxfee (0.17...2019/08/backport_max_fee) https://github.com/bitcoin/bitcoin/pull/16639
< bitcoin-git> [bitcoin] fanquake opened pull request #16638: [0.17] Release preparations for 0.17.2 (0.17...0-17-2-release-prep) https://github.com/bitcoin/bitcoin/pull/16638
< bitcoin-git> [bitcoin] fanquake merged pull request #16622: build: echo property tests status during build (master...property-tests-autoconf-improvements) https://github.com/bitcoin/bitcoin/pull/16622
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7a960ba775a6...1124be6111d6
< bitcoin-git> bitcoin/master a6c1fc3 Jon Atack: build: echo prop tests status during build
< bitcoin-git> bitcoin/master 1124be6 fanquake: Merge #16622: build: echo property tests status during build
< bitcoin-git> [bitcoin] fanquake closed pull request #16636: [QT] Optimize spinner (master...mv0) https://github.com/bitcoin/bitcoin/pull/16636

2019-08-16

< bitcoin-git> [bitcoin] meshcollider merged pull request #15986: Add checksum to getdescriptorinfo (master...201905_justchecksum) https://github.com/bitcoin/bitcoin/pull/15986
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b80cdfec9a07...7a960ba775a6
< bitcoin-git> bitcoin/master 104b3a5 Pieter Wuille: Factor out checksum checking from descriptor parsing
< bitcoin-git> bitcoin/master 26d3fad Pieter Wuille: Add unmodified-but-with-checksum to getdescriptorinfo
< bitcoin-git> bitcoin/master 7a960ba MeshCollider: Merge #15986: Add checksum to getdescriptorinfo
< gribble> https://github.com/bitcoin/bitcoin/issues/13307 | Replace coin selection fallback strategy with Single Random Draw by achow101 · Pull Request #13307 · bitcoin/bitcoin · GitHub
< ariard> I'm trying to rationalize the way we track txn in the wallet, if any ones has opinions on it feel free to review : https://github.com/bitcoin/bitcoin/pull/16624
< gribble> https://github.com/bitcoin/bitcoin/issues/7315 | Minor wallet issue with conflicted txs · Issue #7315 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< bitcoin-git> [bitcoin] GChuf opened pull request #16636: [QT] Optimize spinner (master...mv0) https://github.com/bitcoin/bitcoin/pull/16636
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #16635: [Tests] fix chmod permissions on test files (master...fix/chmod) https://github.com/bitcoin/bitcoin/pull/16635
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16635: [Tests] fix chmod permissions on test files (master...fix/chmod) https://github.com/bitcoin/bitcoin/pull/16635
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16634: doc: Refer in rpcbind doc to the manpage (master...1908-docManPage) https://github.com/bitcoin/bitcoin/pull/16634
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16618: [Fix] Allow connection of a noban banned peer (master...fix/noban-banned) https://github.com/bitcoin/bitcoin/pull/16618
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/aed15edf179d...b80cdfec9a07
< bitcoin-git> bitcoin/master dc7529a nicolas.dorier: [Fix] Allow connection of a noban banned peer
< bitcoin-git> bitcoin/master d117f45 nicolas.dorier: Add test for setban
< bitcoin-git> bitcoin/master b80cdfe MarcoFalke: Merge #16618: [Fix] Allow connection of a noban banned peer
< bitcoin-git> [bitcoin] DrahtBot closed pull request #15150: gui: Show wallet selector on console window if there are wallets loaded (master...2019-01-consolewalletselector) https://github.com/bitcoin/bitcoin/pull/15150
< bitcoin-git> [bitcoin] DrahtBot closed pull request #15717: Changes to support NAT-PMP (master...master) https://github.com/bitcoin/bitcoin/pull/15717
< bitcoin-git> [bitcoin] DrahtBot closed pull request #15493: rfc: Add -printconfig arg to bitcoind (master...2019-02-printconfig) https://github.com/bitcoin/bitcoin/pull/15493
< bitcoin-git> [bitcoin] DrahtBot closed pull request #10729: Wrap EvalScript in a ScriptExecution class (master...scriptex) https://github.com/bitcoin/bitcoin/pull/10729
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #10729: Wrap EvalScript in a ScriptExecution class (master...scriptex) https://github.com/bitcoin/bitcoin/pull/10729
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #14687: zmq: enable tcp keepalive (master...zmq-keep-alive) https://github.com/bitcoin/bitcoin/pull/14687
< bitcoin-git> [bitcoin] DrahtBot closed pull request #13533: [tests] Reduced number of validations in tx_validationcache_tests (master...reduce-txvalidationcache_tests-runtime) https://github.com/bitcoin/bitcoin/pull/13533
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #13533: [tests] Reduced number of validations in tx_validationcache_tests (master...reduce-txvalidationcache_tests-runtime) https://github.com/bitcoin/bitcoin/pull/13533
< bitcoin-git> [bitcoin] DrahtBot closed pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
< bitcoin-git> [bitcoin] DrahtBot closed pull request #14687: zmq: enable tcp keepalive (master...zmq-keep-alive) https://github.com/bitcoin/bitcoin/pull/14687
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #14740: docs: Update rpcbind doc to match the manpage (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
< bitcoin-git> [bitcoin] DrahtBot closed pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
< bitcoin-git> [bitcoin] DrahtBot closed pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
< bitcoin-git> [bitcoin] DrahtBot reopened pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
< bitcoin-git> [bitcoin] DrahtBot closed pull request #14740: docs: Update rpcbind doc to match the manpage (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16633: travis: Fix test_runner.py timeouts (master...1908-travisTimeouts) https://github.com/bitcoin/bitcoin/pull/16633
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21a165325eda...aed15edf179d
< bitcoin-git> bitcoin/master faba46d MarcoFalke: ci: Set --ansi in test_runner
< bitcoin-git> bitcoin/master aed15ed MarcoFalke: Merge #16633: travis: Fix test_runner.py timeouts
< bitcoin-git> [bitcoin] GChuf reopened pull request #16621: doc: add default bitcoin.conf locations (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16621
< bitcoin-git> [bitcoin] GChuf closed pull request #16621: doc: add default bitcoin.conf locations (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16621
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16633: travis: Fix test_runner.py timeouts (master...1908-travisTimeouts) https://github.com/bitcoin/bitcoin/pull/16633
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16620: util: Move ResolveErrMsg to util/error (master...1908-utilErrorResolveErrMsg) https://github.com/bitcoin/bitcoin/pull/16620
< coinmonks> BTW this is last weeks code base analysis https://blog.coincodecap.com/bitcoin-development-stats/
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/93bacb8cc9c0...21a165325eda
< bitcoin-git> bitcoin/master fa27c55 MarcoFalke: util: Move ResolveErrMsg to util/error
< bitcoin-git> bitcoin/master 21a1653 MarcoFalke: Merge #16620: util: Move ResolveErrMsg to util/error
< coinmonks> hey guys, few days ago, I tried to understand the Bitcoin codebase using different metrics, for now i want to understand what is state of Bitcoin contributors and their economic well being..
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16631: [Fix] The default whitelistrelay should be true (master...fix/default-whiterelay) https://github.com/bitcoin/bitcoin/pull/16631
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d65106dce28...93bacb8cc9c0
< bitcoin-git> bitcoin/master 390874c Wladimir J. van der Laan: qt: Remove menu icons
< bitcoin-git> bitcoin/master 93bacb8 Jonas Schnelli: Merge #16612: qt: Remove menu icons
< bitcoin-git> [bitcoin] kallewoof opened pull request #16630: consensus: skip genesis block POW check (master...2019-08-validation-skip-genesis-pow) https://github.com/bitcoin/bitcoin/pull/16630
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16629: [Doc] Add documentation for the new whitelist permissions (master...doc/permissions) https://github.com/bitcoin/bitcoin/pull/16629
< bitcoin-git> [bitcoin] kallewoof closed pull request #16628: refactor: remove redundant pindexPrev from TestBlockValidity (master...2019-08-tbv-nopi) https://github.com/bitcoin/bitcoin/pull/16628
< gribble> https://github.com/bitcoin/bitcoin/issues/15081 | Doc: Update release notes for master through to 2019-01-01 by harding · Pull Request #15081 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/95a5918c9059...0d65106dce28
< bitcoin-git> bitcoin/master a50d9e6 William Casarin: rpcwallet: default include_watchonly to true for watchonly wallets
< bitcoin-git> bitcoin/master 003a3c7 William Casarin: rpcwallet: document include_watchonly default for watchonly wallets
< bitcoin-git> bitcoin/master 72ffbdc William Casarin: doc: add release note for include_watchonly default changes
< bitcoin-git> [bitcoin] fanquake merged pull request #16383: rpcwallet: default include_watchonly to true for watchonly wallets (master...20190713-watchonly-defaults) https://github.com/bitcoin/bitcoin/pull/16383
< bitcoin-git> [bitcoin] fanquake merged pull request #16587: doc: Improve versionbits.h documentation (master...2019-08-docs-versionbits) https://github.com/bitcoin/bitcoin/pull/16587
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/14982b87e945...95a5918c9059
< bitcoin-git> bitcoin/master 6576a87 Antoine Riard: doc: Improve versionbits.h documentation
< bitcoin-git> bitcoin/master 95a5918 fanquake: Merge #16587: doc: Improve versionbits.h documentation
< bitcoin-git> [bitcoin] kallewoof opened pull request #16628: refactor: remove redundant pindexPrev from TestBlockValidity (master...2019-08-tbv-nopi) https://github.com/bitcoin/bitcoin/pull/16628
< bitcoin-git> [bitcoin] fanquake merged pull request #16626: doc: Fix spelling error chache -> cache. (master...master) https://github.com/bitcoin/bitcoin/pull/16626
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bf2ff2bf8e8...14982b87e945
< bitcoin-git> bitcoin/master f9d40ce Nils Loewen: Fix spelling error chache -> cache.
< bitcoin-git> bitcoin/master 14982b8 fanquake: Merge #16626: doc: Fix spelling error chache -> cache.
< bitcoin-git> [bitcoin] nilswloewen opened pull request #16626: Fix spelling error chache -> cache. (master...master) https://github.com/bitcoin/bitcoin/pull/16626
< fanquake> Opened https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/29 to port the docs, feel free to nit-pick.
< fanquake> The github-merge.py script has been merged into the maintainer tools repo in: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/28
< bitcoin-git> [bitcoin] fanquake opened pull request #16625: scripts: remove github-merge.py (master...remove_github_merge_script) https://github.com/bitcoin/bitcoin/pull/16625

2019-08-15

< gribble> https://github.com/bitcoin/bitcoin/issues/15944 | Path error messages while executing test_bitcoin · Issue #15944 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16277 | [Tests] Suppress output in test_bitcoin for expected errors by gertjaap · Pull Request #16277 · bitcoin/bitcoin · GitHub
< roconnor> Hi all. After building bitcoin-0.18.0 and bitcoin-0.18.1 when I run the test_bitcoin program it lists a large number of "Error: Specified -walletdir "wallets" is a relative path ... followed by "*** No errors detected". I didn't have this issue with bitcoin-0.17.1. Have I made some sort of configuration error here?
< bitcoin-git> [bitcoin] ariard opened pull request #16624: wallet : encapsulate trransactions state (master...2019-08-encapsulate-tx-state) https://github.com/bitcoin/bitcoin/pull/16624
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16623: ci: Add environment files for all settings (master...1908-ciEnv) https://github.com/bitcoin/bitcoin/pull/16623
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/367b023ae444...1bf2ff2bf8e8
< bitcoin-git> bitcoin/master 3862e47 John Newbery: [rpc] Tidy up reporting of buried and ongoing softforks
< bitcoin-git> bitcoin/master 1c93b9b John Newbery: [Consensus] Bury CSV deployment height
< bitcoin-git> bitcoin/master 0328dcd John Newbery: [Consensus] Bury segwit deployment
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16060: Bury bip9 deployments (master...bury_bip9_deployments) https://github.com/bitcoin/bitcoin/pull/16060
< gribble> https://github.com/bitcoin/bitcoin/issues/16400 | [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar · Pull Request #16400 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16421 | Conservatively accept RBF bumps bumping one tx at the package limits by TheBlueMatt · Pull Request #16421 · bitcoin/bitcoin · GitHub
< wumpus> also a lot of bitcoin core reviewers don't have much knowledge of the details of the cryptography and implementation
< wumpus> #action move github-merge.py to bitcoin-maintainer-tools repo
< wumpus> yes, if it affects use in bitcoin, or is even an issue that threatens bitcoin, that seems an exception
< sipa> agree; though very serious issues that impact bitcoin could of course also be reported to bitcoin core
< wumpus> instead of having it in the bitcoin core repository
< sipa> i think that libsecp256k1 issues which don't directly affect bitcoin core can be kept inside the secp256k1 project (bitcoin core has no need for JNI... :p)
< real_or_random> which raises the question who should be in there. secp256k1 maintainers or bitcoin-core maintainers?
< sipa> we should probably add merge checks in CI just like in bitcoin core itself
< provoostenator> Could reuse some of the Bitcoin Core tools over?
< MarcoFalke> Is it that repo: https://github.com/bitcoin-core/secp256k1 ?
< wumpus> *leaves bitcoin core for secp256k1* hehe
< MarcoFalke> wumpus: We should make a rule that Bitcoin Core maintainers are not allowed to maintain other projects :)
< sipa> but i wanted to bring this up here, as the secp256k1 repo is under the bitcoin-core org
< MarcoFalke> jonasschnelli: Yeah let's continue in #bitcoin-builds or in one of my follow up pull requests that I plan to open soon :)
< gribble> https://github.com/bitcoin/bitcoin/issues/16367 | Multiprocess build support by ryanofsky · Pull Request #16367 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< gribble> https://github.com/bitcoin/bitcoin/issues/16599 | ASN-based bucketing of the network nodes · Issue #16599 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16582: test: Rework ci (Use travis only as fallback env) (master...1908-ciRework) https://github.com/bitcoin/bitcoin/pull/16582
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/85883a9f8ea0...367b023ae444
< bitcoin-git> bitcoin/master fafe78f MarcoFalke: ci: Rename .travis/ to ./ci/
< bitcoin-git> bitcoin/master fa0aac0 MarcoFalke: ci: Add retry
< bitcoin-git> bitcoin/master fa31bc3 MarcoFalke: ci: Remove dependence on travis, use it as fallback env
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16443: refactor: have CCoins* data managed under CChainState (master...2019-07-au-coins-under-chainstate) https://github.com/bitcoin/bitcoin/pull/16443
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8bd5e0af9983...85883a9f8ea0
< bitcoin-git> bitcoin/master fae6ab6 James O'Beirne: refactor: pcoinsTip -> CChainState::CoinsTip()
< bitcoin-git> bitcoin/master 5693530 James O'Beirne: refactor: have CCoins* data managed under CChainState
< bitcoin-git> bitcoin/master 582d2cd James O'Beirne: Cover UTXO set access with lock annotations
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
< gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #16622: autoconf: property tests status and options (master...property-tests-autoconf-improvements) https://github.com/bitcoin/bitcoin/pull/16622
< bitcoin-git> [bitcoin] emilengler closed pull request #16590: init: systemd directory fix (master...2019-08-systemd-fix) https://github.com/bitcoin/bitcoin/pull/16590
< bitcoin-git> [bitcoin] gapeman opened pull request #16621: doc: add default bitcoin.conf locations (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16621
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e00501e00ccd...8bd5e0af9983
< bitcoin-git> bitcoin/master fac3dcf MarcoFalke: test: Generate one block for each send in wallet_import_rescan
< bitcoin-git> bitcoin/master fa79af2 MarcoFalke: test: Replace fragile "rng" with call to random()
< bitcoin-git> bitcoin/master fa25668 MarcoFalke: test: Test p2sh-witness and bech32 in wallet_import_rescan
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16620: util: Move ResolveErrMsg to util/error (master...1908-utilErrorResolveErrMsg) https://github.com/bitcoin/bitcoin/pull/16620
< jonasschnelli> ariard: can you explain that comment further: https://github.com/bitcoin/bitcoin/pull/16562#discussion_r314112055
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16561: tests: Use colors and dots in test_runner.py output only if standard output is a terminal (master...parsable) https://github.com/bitcoin/bitcoin/pull/16561
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8fc7f0cba9b1...e00501e00ccd
< bitcoin-git> bitcoin/master 37f2784 practicalswift: tests: Use colors and dots in test_runner.py output only if standard outpu...
< bitcoin-git> bitcoin/master e00501e MarcoFalke: Merge #16561: tests: Use colors and dots in test_runner.py output only if ...
< bitcoin-git> [bitcoin] laanwj closed pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
< gribble> https://github.com/bitcoin/bitcoin/issues/15986 | Add checksum to getdescriptorinfo by sipa · Pull Request #15986 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16400 | [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar · Pull Request #16400 · bitcoin/bitcoin · GitHub
< fanquake> Is Travis just having a bad day? Seeing a lot of timeouts like https://travis-ci.org/bitcoin/bitcoin/jobs/572183150
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #16618: [Fix] Allow connection of a noban banned peer (master...fix/noban-banned) https://github.com/bitcoin/bitcoin/pull/16618
< bitcoin-git> [bitcoin] fanquake closed pull request #15954: refactor: remove old bootstrap relevant code (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15954
< bitcoin-git> [bitcoin] fanquake merged pull request #16578: Do not pass in command line arguments to QApplication (master...no-qapp-args) https://github.com/bitcoin/bitcoin/pull/16578
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8516285d2ea4...8fc7f0cba9b1
< bitcoin-git> bitcoin/master a2714a5 Andrew Chow: Give QApplication dummy arguments
< bitcoin-git> bitcoin/master 8fc7f0c fanquake: Merge #16578: Do not pass in command line arguments to QApplication
< bitcoin-git> [bitcoin] fanquake closed pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
< bitcoin-git> [bitcoin] fanquake opened pull request #16617: [0.18.2] Backports (0.18...0_18_2_backports) https://github.com/bitcoin/bitcoin/pull/16617
< bitcoin-git> [bitcoin] fanquake merged pull request #16615: doc: Fix typos in COPYRIGHT (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16615
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f418c3379cba...8516285d2ea4
< bitcoin-git> bitcoin/master 36f7697 Chuf: doc: Fix typos in COPYRIGHT
< bitcoin-git> bitcoin/master 8516285 fanquake: Merge #16615: doc: Fix typos in COPYRIGHT
< gribble> https://github.com/bitcoin/bitcoin/issues/16616 | Technical Issue : rename command ..It is recognized as a file. · Issue #16616 · bitcoin/bitcoin · GitHub

2019-08-14

< bitcoin-git> [bitcoin] jonasschnelli merged pull request #16435: autoconf: Sane `--enable-debug` defaults. (master...2019-07-better-debuggability) https://github.com/bitcoin/bitcoin/pull/16435
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67be6d7a177c...f418c3379cba
< bitcoin-git> bitcoin/master d6ac25b Carl Dong: autoconf: Sane --enable-debug defaults.
< bitcoin-git> bitcoin/master f418c33 Jonas Schnelli: Merge #16435: autoconf: Sane `--enable-debug` defaults.
< gribble> https://github.com/bitcoin/bitcoin/issues/16248 | Make whitebind/whitelist permissions more flexible by NicolasDorier · Pull Request #16248 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl closed pull request #14856: net: remove more CConnman globals (theuni) (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
< bitcoin-git> [bitcoin] gapeman opened pull request #16615: doc: Fix typos in COPYRIGHT (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16615
< bitcoin-git> [bitcoin] practicalswift closed pull request #16273: refactor: Remove unused includes (master...cut-compilation-bloat) https://github.com/bitcoin/bitcoin/pull/16273
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a7aa80902763...67be6d7a177c
< bitcoin-git> bitcoin/master e5b26de nicolas.dorier: Make whitebind/whitelist permissions more flexible
< bitcoin-git> bitcoin/master ecd5cf7 nicolas.dorier: Do not disconnect peer for asking mempool if it has NO_BAN permission
< bitcoin-git> bitcoin/master d541fa3 nicolas.dorier: Replace the use of fWhitelisted by permission checks
< bitcoin-git> [bitcoin] laanwj merged pull request #16248: Make whitebind/whitelist permissions more flexible (master...feature/permissions) https://github.com/bitcoin/bitcoin/pull/16248
< gribble> https://github.com/bitcoin/bitcoin/issues/16599 | ASN-based bucketing of the network nodes · Issue #16599 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/bbc2970082a2...43cf76b19395
< bitcoin-git> bitcoin/0.18 2c341e3 MarcoFalke: travis: Properly cache and error on timeout
< bitcoin-git> bitcoin/0.18 5aac5e9 MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
< bitcoin-git> bitcoin/0.18 80cd3f0 MarcoFalke: travis: Bump timeout from 50 minutes to 90
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
< bitcoin-git> [bitcoin] laanwj opened pull request #16611: build: Remove src/obj directory from repository (master...2019_08_srcobj) https://github.com/bitcoin/bitcoin/pull/16611
< bitcoin-git> [bitcoin] laanwj merged pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f29790cd7e...a7aa80902763
< bitcoin-git> bitcoin/master 7cd069d Martin Zumsande: Add test for AddTimeData
< bitcoin-git> bitcoin/master a7aa809 Wladimir J. van der Laan: Merge #16563: test: Add unit test for AddTimeData
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16589: build: Remove unused src/obj-test folder (master...1908-buildNoSrcObjTest) https://github.com/bitcoin/bitcoin/pull/16589
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0753c7392796...24f29790cd7e
< bitcoin-git> bitcoin/master fa4ee0d MarcoFalke: build: Remove unused src/obj-test folder
< bitcoin-git> bitcoin/master 24f2979 MarcoFalke: Merge #16589: build: Remove unused src/obj-test folder
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
< bitcoin-git> [bitcoin] fanquake merged pull request #16596: rpc: Fix getblocktemplate CLI example (master...2019-08-helpexamplecli-fix) https://github.com/bitcoin/bitcoin/pull/16596
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/034575e9c7a3...0753c7392796
< bitcoin-git> bitcoin/master 14f7eec Emil Engler: rpc: Fix getblocktemplate CLI example (#16594)
< bitcoin-git> bitcoin/master 0753c73 fanquake: Merge #16596: rpc: Fix getblocktemplate CLI example
< wumpus> error: failed to push some refs to 'git@github.com:bitcoin/bitcoin'
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7df1ecd1758...034575e9c7a3
< bitcoin-git> bitcoin/master 3963856 fanquake: descriptor: fix missed m_script_arg arg renaming in #14934
< bitcoin-git> bitcoin/master 034575e MarcoFalke: Merge #16609: descriptor: fix missed m_script_arg arg renaming in #14934
< wumpus> To github.com:bitcoin/bitcoin
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #16584: gui: New filesave icon, updated copyright (master...branch4) https://github.com/bitcoin/bitcoin/pull/16584
< bitcoin-git> [bitcoin] fanquake opened pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609