2018-10-23

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14417: Fix listreceivedbyaddress not taking address as a string (master...fix-rpc-calls-not-taking-valid-strings) https://github.com/bitcoin/bitcoin/pull/14417
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3668bb335c6a...94cf1ec94821
< bitcoin-git> bitcoin/master d4d70ed Eric Scrivner: Fix listreceivedbyaddress not taking address as a string...
< bitcoin-git> bitcoin/master 94cf1ec MarcoFalke: Merge #14417: Fix listreceivedbyaddress not taking address as a string...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14468: [wallet] Deprecate generate RPC method (master...deprecate_generate) https://github.com/bitcoin/bitcoin/pull/14468
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3f377daaa86...3668bb335c6a
< bitcoin-git> bitcoin/master c269209 John Newbery: [tests] Small fixups before deprecating generate...
< bitcoin-git> bitcoin/master aab8172 John Newbery: [tests] Add generate method to TestNode...
< bitcoin-git> bitcoin/master c9f0295 John Newbery: [wallet] Deprecate the generate RPC method
< bitcoin-git> [bitcoin] hebasto opened pull request #14556: qt: Fix bug #13299 (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
< bitcoin-git> [bitcoin] jimpo opened pull request #14555: Move util files to directory (master...util-cleanup) https://github.com/bitcoin/bitcoin/pull/14555
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14518 | rpc: Always throw in getblockstats if -txindex is required by promag · Pull Request #14518 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14554: qt: Remove unused `adjustedTime` parameter (master...20181023-unused-adjustedtime) https://github.com/bitcoin/bitcoin/pull/14554
< bitcoin-git> [bitcoin] merland opened pull request #14553: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
< bitcoin-git> [bitcoin] ken2812221 opened pull request #14552: wallet: throw an error if user load the wallet file by different ways (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
< bitcoin-git> [bitcoin] laanwj closed pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
< bitcoin-git> [bitcoin] preserveddarnell opened pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
< bitcoin-git> [bitcoin] fanquake closed pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
< bitcoin-git> [bitcoin] preserveddarnell opened pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
< bitcoin-git> [bitcoin] sipa closed pull request #14511: doc: Remove explicit storage requirement from README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8f519a0626...b3f377daaa86
< bitcoin-git> bitcoin/master 5918204 Martin Erlandsson: Removed explicit mention of storage requirement (squashed)...
< bitcoin-git> bitcoin/master b3f377d Pieter Wuille: Merge #14511: doc: Remove explicit storage requirement from README.md...
< bitcoin-git> [bitcoin] charlesrocket closed pull request #14539: add Apple SDK download to gitian-build.py (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539

2018-10-22

< bitcoin-git> [bitcoin] sipa closed pull request #14150: Add key origin support to descriptors (master...201807_minedesc_origin) https://github.com/bitcoin/bitcoin/pull/14150
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c25409d6851...0a8f519a0626
< bitcoin-git> bitcoin/master 2c6281f Pieter Wuille: Add key origin support to descriptors
< bitcoin-git> bitcoin/master ff37459 Pieter Wuille: Add tests for key origin support
< bitcoin-git> bitcoin/master 8afb166 Pieter Wuille: Update documentation to incude origin information
< bitcoin-git> [bitcoin] instagibbs opened pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
< bitcoin-git> [bitcoin] practicalswift closed pull request #13766: Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers. (master...initialize-members-in-initialization-list) https://github.com/bitcoin/bitcoin/pull/13766
< bitcoin-git> [bitcoin] practicalswift closed pull request #12984: logs: Make the columns in subsequent UpdateTip log entries horizontally aligned (master...attention-to-detail) https://github.com/bitcoin/bitcoin/pull/12984
< Wadexs> Bitcoin testnet exchange
< echeveria> might be best to continue this in #bitcoin then.
< sanket1729> This code appears to reject blocks 2 hours into future based on local time. https://github.com/bitcoin/bitcoin/blob/5c25409d6851182c5e351720cee36812c229b77a/src/validation.cpp#L3245 . What am I missing?
< sanket1729> Hello, can anyone comment on the following claim. "If there is a clock drifts more than 2 hours and and there are 2 chains similar PoW, then we can have a fork where both chains think they are longest in their own view. So, bitcoin network operates on some synchronous assumptions."
< gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14540 | Enable flake8 rule E231. by jbampton · Pull Request #14540 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14540: Enable flake8 rule E231. (master...flake8-fix-E231) https://github.com/bitcoin/bitcoin/pull/14540

2018-10-21

< bitcoin-git> [bitcoin] jbampton opened pull request #14540: Enable flake8 rule E231. (master...flake8-fix-E231) https://github.com/bitcoin/bitcoin/pull/14540
< bitcoin-git> [bitcoin] charlesrocket opened pull request #14539: add Apple SDK download and checksum (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539
< wumpus> if you're looking for a specific block, you could check block explorers if they have it, or ask here or in #bitcoin
< sanket1729> Hello, I have one small quick question. Does bitcoin core ever prune orphan blocks? I mean do all full nodes have a very old orphan block, say from 2014?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14161: doc/descriptors.md tweaks (master...pr/ddoc) https://github.com/bitcoin/bitcoin/pull/14161
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/73cddb36a88f...5c25409d6851
< bitcoin-git> bitcoin/master eb49412 Russell Yanofsky: doc/descriptors.md tweaks...
< bitcoin-git> bitcoin/master eeeaa29 Russell Yanofsky: descriptors.md: Refer to descriptors as describing instead of matching
< bitcoin-git> bitcoin/master 5c25409 MarcoFalke: Merge #14161: doc/descriptors.md tweaks...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14526: docs: Document lint tests (master...revive-document-lint-tests) https://github.com/bitcoin/bitcoin/pull/14526
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75795603dd2f...73cddb36a88f
< bitcoin-git> bitcoin/master 8640631 Mason Simon: docs: Document lint tests
< bitcoin-git> bitcoin/master 73cddb3 MarcoFalke: Merge #14526: docs: Document lint tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14309: Use non-throwing type-safe ChainType where possible (master...Mf1809-chainType) https://github.com/bitcoin/bitcoin/pull/14309
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96c409c919b9...75795603dd2f
< bitcoin-git> bitcoin/master 97ddc60 practicalswift: validation: Pass chainparams in AcceptToMemoryPoolWorker(...)
< bitcoin-git> bitcoin/master 7579560 MarcoFalke: Merge #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...)...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909

2018-10-20

< bitcoin-git> [bitcoin] jbampton opened pull request #14534: Enable flake8 rule E225 which checks for missing whitespace around op… (master...flake8-fix-E225) https://github.com/bitcoin/bitcoin/pull/14534
< bitcoin-git> [bitcoin] mrwhythat opened pull request #14533: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/14533
< bitcoin-git> [bitcoin] practicalswift reopened pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909
< bitcoin-git> [bitcoin] luke-jr opened pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git> [bitcoin] promag opened pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531
< gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14530: scripted-diff: Use RPCHelpMan on RPCs with no args (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git> [bitcoin] laanwj closed pull request #14527: qa: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6746a8951923...96c409c919b9
< bitcoin-git> bitcoin/master fadffae MarcoFalke: Revert "Make qt wallet test compatible with qt4"...
< bitcoin-git> bitcoin/master 96c409c Wladimir J. van der Laan: Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"...
< fanquake> Chris_Stewart_5 See the channel history, we've forked rapidcheck to bitcoin-core, could be a chance to use the new make install method etc. You should have gotten invite to /bitcoin and /bitcoin-core as well.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14528: travis: Compile once on xenial (master...Mf1810-travisXenial) https://github.com/bitcoin/bitcoin/pull/14528
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14527: Revert "Make qt wallet test compatible with qt4" (master...Mf1810-qtRemoveQT4file) https://github.com/bitcoin/bitcoin/pull/14527
< wumpus> invited to bitcoin and bitcoin-core at least
< wumpus> repo created, see https://github.com/bitcoin-core/rapidcheck, who needs commit access?
< fanquake> wumpus thanks. More context in my comment here: https://github.com/bitcoin/bitcoin/pull/14430#issuecomment-431555605
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< fanquake> wumpus Would we be able to fork emil-e/rapidcheck to github.com/bitcoin-core/?
< bitcoin-git> [bitcoin] laanwj closed pull request #14497: docs: Add doc/bitcoin-conf.md (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d433239a8d54...6746a8951923
< bitcoin-git> bitcoin/master 1fb3c16 Hennadii Stepanov: Add `doc/bitcoin-conf.md`
< bitcoin-git> bitcoin/master 6746a89 Wladimir J. van der Laan: Merge #14497: docs: Add doc/bitcoin-conf.md...
< gribble> https://github.com/bitcoin/bitcoin/issues/14497 | docs: Add doc/bitcoin-conf.md by hebasto · Pull Request #14497 · bitcoin/bitcoin · GitHub
< midnightmagic> still burns me atmel dropped avr for arm. wumpus: well if it does anything interesting with the bitcoin node, I know I at least would love to hear about it.
< wumpus> yes, bitcoin runs ok, syncing doesn't go super fast but it was a bit faster than most ARM boards from a few years ago I've tried on
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14456: test: forward timeouts properly in send_blocks_and_test (master...2018-10-test-forward-timeouts) https://github.com/bitcoin/bitcoin/pull/14456
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/544f3234384b...d433239a8d54
< bitcoin-git> bitcoin/master 94e21c1 James O'Beirne: test: forward timeouts properly in send_blocks_and_test
< bitcoin-git> bitcoin/master d433239 MarcoFalke: Merge #14456: test: forward timeouts properly in send_blocks_and_test...
< midnightmagic> runs bitcoin okay? how long did it take to sync with nbd..?
< wumpus> FWIW it runs a bitcoin + lightning node + tor fine :D
< fanquake> wumpus I've looked at the BSD configure issue a bit more. Looks like a bug fix in 1.16 might have broken something we do, https://github.com/bitcoin/bitcoin/issues/14404#issuecomment-431542526
< wumpus> midnightmagic: well... currently only run OpenBSD in VM; and yes, bitcoin builds fine on OpenBSD, there's special instructions for that, which fanquake updated for 6.4 and I'l like to test out but couldn't yet
< bitcoin-git> [bitcoin] fanquake closed pull request #14014: Scripts and tools: fix gitian-build.py --verify option (master...gitian-verify) https://github.com/bitcoin/bitcoin/pull/14014
< bitcoin-git> [bitcoin] fanquake closed pull request #13542: Adding Docker/docker-compose files (master...docker) https://github.com/bitcoin/bitcoin/pull/13542
< bitcoin-git> [bitcoin] fanquake opened pull request #14526: docs: Document lint tests (master...revive-document-lint-tests) https://github.com/bitcoin/bitcoin/pull/14526
< bitcoin-git> [bitcoin] fanquake closed pull request #13708: docs: Document lint tests (master...document-lint-tests) https://github.com/bitcoin/bitcoin/pull/13708
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/91482e5bf22d...544f3234384b
< bitcoin-git> bitcoin/master b6b9915 Martin Erlandsson: Textual improvements
< bitcoin-git> bitcoin/master 544f323 Pieter Wuille: Merge #14512: docs: Textual improvements in README.md...
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e754c6e33194...91482e5bf22d
< bitcoin-git> bitcoin/master 29ed2d6 Hennadii Stepanov: Improve CAmount tests...
< bitcoin-git> bitcoin/master 91482e5 Pieter Wuille: Merge #14460: tests: Improve 'CAmount' tests...
< bitcoin-git> [bitcoin] sipa closed pull request #14011: Disable wallet and address book Qt tests on macOS minimal platform (master...pr/fuqtmac) https://github.com/bitcoin/bitcoin/pull/14011
< gribble> https://github.com/bitcoin/bitcoin/issues/14512 | docs: Textual improvements in README.md by merland · Pull Request #14512 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc1e54206d76...e754c6e33194
< bitcoin-git> bitcoin/master a3197c5 Russell Yanofsky: Disable wallet and address book Qt tests on macOS minimal platform...
< bitcoin-git> bitcoin/master e754c6e Pieter Wuille: Merge #14011: Disable wallet and address book Qt tests on macOS minimal platform...
< gribble> https://github.com/bitcoin/bitcoin/issues/14011 | Disable wallet and address book Qt tests on macOS minimal platform by ryanofsky · Pull Request #14011 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5b47b8efd48d...1b5af2c177ee
< bitcoin-git> bitcoin/0.17 f7dbcaa Sjors Provoost: [doc] getblocktemplate: use SegWit in example
< bitcoin-git> bitcoin/0.17 1b5af2c Pieter Wuille: Merge #14509: [0.17] doc: use SegWit in getblocktemplate example...
< bitcoin-git> [bitcoin] sipa closed pull request #14474: bitcoin-tx: Use constant for n pubkeys check (master...bitcoin_tx_use_constant) https://github.com/bitcoin/bitcoin/pull/14474
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2863c0685a5...dc1e54206d76
< bitcoin-git> bitcoin/master 1f01fe0 Antoine Le Calvez: bitcoin-tx: Use constant for n pubkeys check...
< bitcoin-git> bitcoin/master dc1e542 Pieter Wuille: Merge #14474: bitcoin-tx: Use constant for n pubkeys check...
< bitcoin-git> [bitcoin] sipa closed pull request #14426: utils: Fix broken Windows filelock (master...filelock-test) https://github.com/bitcoin/bitcoin/pull/14426
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b14db5abab40...b2863c0685a5
< bitcoin-git> bitcoin/master 369244f Chun Kuan Lee: utils: Fix broken Windows filelock
< bitcoin-git> bitcoin/master b2863c0 Pieter Wuille: Merge #14426: utils: Fix broken Windows filelock...
< bitcoin-git> [bitcoin] sipa closed pull request #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (master...1<<31-again) https://github.com/bitcoin/bitcoin/pull/14513
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8010ded6da56...b14db5abab40
< bitcoin-git> bitcoin/master bc60c61 practicalswift: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG
< bitcoin-git> bitcoin/master b14db5a Pieter Wuille: Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG...
< bitcoin-git> [bitcoin] sipa closed pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d387507aeca6...8010ded6da56
< bitcoin-git> bitcoin/master 7e18673 Kristaps Kaupe: Fix typo
< bitcoin-git> bitcoin/master 8010ded Pieter Wuille: Merge #14524: Trivial: fix typo...

2018-10-19

< bitcoin-git> [bitcoin] kristapsk opened pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524
< jarthur> jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them.
< gribble> https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
< andytoshi> meshcollider: people today show up with 2012 wallets on #bitcoin, and it's a pretty impressive show of backward-compatibility that i can always say "just import it into the latest core"
< gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14503 | scantxoutset does not identify UTXO origins · Issue #14503 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14150 | Add key origin support to descriptors by sipa · Pull Request #14150 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< sipa> gwillen: discussed yesterday in the bitcoin core meeting :)
< sipa> welcome to the first bitcoin core wallet meeting!
< bitcoin-git> [bitcoin] jamesob opened pull request #14522: tests: add invalid P2P message tests (master...2018-10-invalid-msgs-test) https://github.com/bitcoin/bitcoin/pull/14522
< bitcoin-git> [bitcoin] hebasto opened pull request #14521: qt, docs: Fix `bitcoin-qt -version` output formatting (master...20181019-qt-cli-license) https://github.com/bitcoin/bitcoin/pull/14521
< midnightmagic> wumpus: I didn't know you were into OpenBSD. Bitcoin builds work okay on it still? There was a guy who was persistently building on OpenBSD for quite some time.
< bitcoin-git> [bitcoin] jamesob opened pull request #14519: test: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
< gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #14475: serialize: Document integer width assumptions we are making when calculating compact sizes (master...integer-width-assumptions) https://github.com/bitcoin/bitcoin/pull/14475
< bitcoin-git> [bitcoin] practicalswift closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909
< bitcoin-git> [bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969
< bitcoin-git> [bitcoin] practicalswift closed pull request #14010: tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization (master...SelectParams-when-fuzzing) https://github.com/bitcoin/bitcoin/pull/14010
< bitcoin-git> [bitcoin] practicalswift closed pull request #13971: Add tests and error handling to DecodeExtPubKey/DecodeExtKey. Add [[nodiscard]]. (master...DecodeExtKey) https://github.com/bitcoin/bitcoin/pull/13971
< bitcoin-git> [bitcoin] practicalswift closed pull request #14254: build: Add address sanitizer (ASan) Travis job (master...asan) https://github.com/bitcoin/bitcoin/pull/14254
< bitcoin-git> [bitcoin] promag opened pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518
< gribble> https://github.com/bitcoin/bitcoin/issues/14514 | Version number for `bitcoin.conf` · Issue #14514 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #14517: qt: Fix start with the `-min` option (master...20181019-start-minimized-to-tray) https://github.com/bitcoin/bitcoin/pull/14517
< gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa closed pull request #14465: tests: Stop node before removing the notification file (master...test-notification-fix) https://github.com/bitcoin/bitcoin/pull/14465
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8eb2cd1ddaab...d387507aeca6
< bitcoin-git> bitcoin/master ca6d86c Chun Kuan Lee: tests: Stop node before removing the notification file
< bitcoin-git> bitcoin/master d387507 Pieter Wuille: Merge #14465: tests: Stop node before removing the notification file...
< bitcoin-git> [bitcoin] fanquake opened pull request #14515: doc: Update OpenBSD build guide for 6.4 (master...openbsd-6-4) https://github.com/bitcoin/bitcoin/pull/14515
< bitcoin-git> [bitcoin] fanquake closed pull request #14314: Trivial: gitignore contents of db4 folder (master...master) https://github.com/bitcoin/bitcoin/pull/14314

2018-10-18

< gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletInfo class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14291: wallet: Add ListWalletDir utility function (master...2018-09-list-wallet-dir) https://github.com/bitcoin/bitcoin/pull/14291
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/3715b2489e98...8eb2cd1ddaab
< bitcoin-git> bitcoin/master fc4db35 João Barbosa: wallet: Add ListWalletDir utility...
< bitcoin-git> bitcoin/master d1b03b8 João Barbosa: interfaces: Add getWalletDir and listWalletDir to Node
< bitcoin-git> bitcoin/master cc33773 João Barbosa: rpc: Add listwalletdir RPC
< gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift closed pull request #13897: clientversion: Define only macros we’ll use (master...remove-unused-macros) https://github.com/bitcoin/bitcoin/pull/13897
< bitcoin-git> [bitcoin] practicalswift closed pull request #13548: Document assumptions made in PeerLogicValidation::SendMessages(...) and rescanblockchain(...) (master...document-non-nullptr-assumptions) https://github.com/bitcoin/bitcoin/pull/13548
< bitcoin-git> [bitcoin] practicalswift closed pull request #14506: Remove redundancies: redundant forward declaration, redundant namespace, redundant copying, redundant conditionals (master...remove) https://github.com/bitcoin/bitcoin/pull/14506
< bitcoin-git> [bitcoin] practicalswift opened pull request #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (master...1<<31-again) https://github.com/bitcoin/bitcoin/pull/14513
< gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits() (master...1<<31) https://github.com/bitcoin/bitcoin/pull/14510
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe23553edd84...3715b2489e98
< bitcoin-git> bitcoin/master 96f6dc9 practicalswift: Avoid triggering undefined behaviour in base_uint<BITS>::bits()
< bitcoin-git> bitcoin/master 3715b24 Wladimir J. van der Laan: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits()...
< gribble> https://github.com/bitcoin/bitcoin/issues/14510 | Avoid triggering undefined behaviour in base_uint ::bits() by practicalswift · Pull Request #14510 · bitcoin/bitcoin · GitHub
< wumpus> luke-jr: a bitcoin core-tor bundle has been talked about since 2012 at least
< luke-jr> says the guy who wrote bitcoin-qt..
< wumpus> yess I'm... not sure how I got involved in this at all tbh, I made bitcoin-qt because I thought it would help get actual GUI people invovled, make it easier for them
< jnewbery> Bitcoin core wallet
< meshcollider> phantomcircuit: if we already have the iOS certificate with the bitcoin one the windows one should be the same
< jonasschnelli> phantomcircuit: I think "Bitcoin Core" should be in the name
< phantomcircuit> rather than something bitcoin specific? (even if it's only signing bitcoin in practice)
< luke-jr> "Bitcoin Cash Code Signing Association" hopefully wouldn't have that confusion
< gmaxwell> (though the 'bitcoin foundation' thing did have an unfortunate effect of making people think BCF made the bitcoin software)
< jonasschnelli> I think no-one would recognise if the certificate would be issued to "Bitcoin Cash Code Signing Association"
< jonasschnelli> Ideally we get new keys also via the Bitcoin Core Code Signing Association (http://bitcoincorecodesigning.org)
< jnewbery> meta-topic suggestion: does it make sense to discuss qt UI issues in the general bitcoin core IRC meeting?
< gribble> https://github.com/bitcoin/bitcoin/issues/14482 | Better name for "Request Payment" button · Issue #14482 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12721 | Qt: remove "new" button during receive-mode in addressbook by jonasschnelli · Pull Request #12721 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14150 | Add key origin support to descriptors by sipa · Pull Request #14150 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14416 | [WIP] fix OSX dmg issue (10.12 to 10.14) by jonasschnelli · Pull Request #14416 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14150 | Add key origin support to descriptors by sipa · Pull Request #14150 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< wumpus> as you can't really make an assumption about the precision, yes if you write software for bitcoin specifically you can hardcode 10^-8, but anythign that needs to interface between different systems and APIs and databases needs to convert between them on their own terms
< gmaxwell> phantomcircuit: the old json library bitcoin used to use randomly inserted conversions to float in a minor upgrade!
< gmaxwell> phantomcircuit: depends on what you mean by float, common bitcoin values don't fit precisely in 32-bit floats, they do in 64-bit doubles.
< wumpus> gmaxwell: yes, it's trivial change to ValueFromAmount if you really want to, though I'd suggest looking at a better suited JSONRPC library, by now for most languages there's something for bitcoin specifically
< gmaxwell> in Bitcoin core they're just 64 bit integers.
< bitcoin-git> [bitcoin] hebasto closed pull request #14427: docs: Add config file docs to '-help' messages (master...20181004-help-config) https://github.com/bitcoin/bitcoin/pull/14427
< bitcoin-git> [bitcoin] merland opened pull request #14512: Textual improvements (master...merland-patch-2) https://github.com/bitcoin/bitcoin/pull/14512
< bitcoin-git> [bitcoin] merland opened pull request #14511: Increase storage requirement from 100GB to 200GB (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
< bitcoin-git> [bitcoin] ken2812221 closed pull request #13887: build: Compile leveldb with unicode enable on Windows (master...leveldb-windows-unicode) https://github.com/bitcoin/bitcoin/pull/13887
< bitcoin-git> [bitcoin] laanwj closed pull request #14374: qt: Add "Blocksdir" to Debug window (master...20181002-debugwindow-blocksdir) https://github.com/bitcoin/bitcoin/pull/14374
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/32c5f188d4fd...fe23553edd84
< bitcoin-git> bitcoin/master 3045704 Hennadii Stepanov: Add "Blocksdir" to Debug window...
< bitcoin-git> bitcoin/master 2ab9140 Hennadii Stepanov: Add tooltips for both datadir and blocksdir
< bitcoin-git> bitcoin/master fe23553 Wladimir J. van der Laan: Merge #14374: qt: Add "Blocksdir" to Debug window...
< bitcoin-git> [bitcoin] laanwj closed pull request #14177: qt: Set C locale for amountWidget (master...fix-amount-locale) https://github.com/bitcoin/bitcoin/pull/14177
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d98777f302e1...32c5f188d4fd
< bitcoin-git> bitcoin/master b0510d7 Hennadii Stepanov: Set C locale for amountWidget...
< bitcoin-git> bitcoin/master 32c5f18 Wladimir J. van der Laan: Merge #14177: qt: Set C locale for amountWidget...
< bitcoin-git> [bitcoin] practicalswift opened pull request #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits() (master...1<<31) https://github.com/bitcoin/bitcoin/pull/14510
< bitcoin-git> [bitcoin] laanwj closed pull request #14146: wallet: Remove trailing separators from -walletdir arg (master...wallet-env-bug) https://github.com/bitcoin/bitcoin/pull/14146
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c5f0d542d1d...d98777f302e1
< bitcoin-git> bitcoin/master ea3009e Pierre Rochard: wallet: Add walletdir arg unit tests
< bitcoin-git> bitcoin/master 2d47163 Pierre Rochard: wallet: Remove trailing separators from -walletdir arg
< bitcoin-git> bitcoin/master d98777f Wladimir J. van der Laan: Merge #14146: wallet: Remove trailing separators from -walletdir arg...
< bitcoin-git> [bitcoin] laanwj closed pull request #13878: utils: Add fstream wrapper to allow to pass unicode filename on Windows (master...iofstream-custom) https://github.com/bitcoin/bitcoin/pull/13878
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/041224a75c16...9c5f0d542d1d
< bitcoin-git> bitcoin/master 86eb3b3 Chun Kuan Lee: utils: Add fsbridge fstream function wrapper
< bitcoin-git> bitcoin/master a554cc9 Chun Kuan Lee: Move boost/std fstream to fsbridge
< bitcoin-git> bitcoin/master f86a571 Chun Kuan Lee: tests: Add test case for std::ios_base::ate
< sipa> bitcoin uses little endian everywhere, except when presenting things for human consumption :)
< karelb> I will add this to "weird stuff Bitcoin does for backwards compatibility reasons", just next to the endian switching
< gribble> https://github.com/bitcoin/bitcoin/issues/14125 | Add testcase to simulate bitcoin schema in leveldb by MapleLaker · Pull Request #14125 · bitcoin/bitcoin · GitHub
< sipa> karelb: also, inside bitcoin core there no conversion of amounts to floats ever (except feerates), even to convert to JSON
< bitcoin-git> [bitcoin] Sjors opened pull request #14509: [doc] getblocktemplate: use SegWit in example (0.17...2018/10/backport-doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14509
< karelb> thinking out loud- yesterday we talked with colleague how we hate that JSON RPC returns BTC values as floats. (at various points.) Do you think it would be a good idea to be able to somehow switch this with some option? either option for whole bitcoind, or just another parameter for bitcoin-cli
< bitcoin-git> [bitcoin] laanwj closed pull request #14472: [doc] getblocktemplate: use SegWit in example (master...2018/10/doc-getblocktemplate-segwit) https://github.com/bitcoin/bitcoin/pull/14472
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/816fab9ccae5...041224a75c16
< bitcoin-git> bitcoin/master d562027 Sjors Provoost: [doc] getblocktemplate: use SegWit in example
< bitcoin-git> bitcoin/master 041224a Wladimir J. van der Laan: Merge #14472: [doc] getblocktemplate: use SegWit in example...
< gribble> https://github.com/bitcoin/bitcoin/issues/14479 | serialization: Dont invoke undefined behaviour when doing type punning by practicalswift · Pull Request #14479 · bitcoin/bitcoin · GitHub
< gmaxwell> wumpus: I kinda thought I tried that too... or at least I know I moved a whole .bitcoin over, but I might have not tried with the wallet.
< gmaxwell> Though BE power is both real and an actually interesting host to run bitcoin on.
< wumpus> yes IBM power can run in BE as well (https://github.com/bitcoin/bitcoin/pull/14066 has some discussion in that regard whether we should ship executables for that case)
< wumpus> this is... telling, I don't suppose anyone ever used bitcoin on a big endian system
< promag> the last change was https://github.com/bitcoin/bitcoin/commit/743a3a9b20768519a11f54834d27fd7585a0670a <- I have to remove that #include though..
< bitcoin-git> [bitcoin] laanwj closed pull request #14370: utils and libraries: Allow values quoting in config files (master...20181002-config-quotes) https://github.com/bitcoin/bitcoin/pull/14370
< bitcoin-git> [bitcoin] kallewoof opened pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507
< gribble> https://github.com/bitcoin/bitcoin/issues/14478 | Show error to user when corrupt wallet unlock fails by MeshCollider · Pull Request #14478 · bitcoin/bitcoin · GitHub

2018-10-17

< promag> jnewbery: I think #13339 can be added to https://github.com/bitcoin/bitcoin/projects/2?
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14465 | tests: Stop node before removing the notification file by ken2812221 · Pull Request #14465 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14446 | tests: Some issue about running functional tests on Windows · Issue #14446 · bitcoin/bitcoin · GitHub
< gmaxwell> I don't know anything about gemini, but it is routine for bitcoin companies to more or less outright lie about their security.
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14450: qt: Fix QCompleter popup regression (master...20181009-console-autocomplete) https://github.com/bitcoin/bitcoin/pull/14450
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3036faf51a18...816fab9ccae5
< bitcoin-git> bitcoin/master 081cc02 Hennadii Stepanov: Fix QCompleter popup regression...
< bitcoin-git> bitcoin/master 816fab9 Jonas Schnelli: Merge #14450: qt: Fix QCompleter popup regression...
< bitcoin-git> [bitcoin] practicalswift opened pull request #14506: Remove redundancies: redundant forward declaration, redundant namespace, redundancy copying, redundant conditionals (master...remove) https://github.com/bitcoin/bitcoin/pull/14506
< bitcoin-git> [bitcoin] practicalswift opened pull request #14505: Make all single parameter constructors explicit (C++11) (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
< bitcoin-git> [bitcoin] sdaftuar closed pull request #14220: Transaction relay privacy bugfix (master...2018-09-txrelay) https://github.com/bitcoin/bitcoin/pull/14220
< promag> but I don't know how to build bitcoin-qt to test it
< bitcoin-git> [bitcoin] isghe opened pull request #14504: show the progress of functional test (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
< promag> ken2812221: do you build bitcoin-qt with msvc?
< bitcoin-git> [bitcoin] laanwj closed pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27bf14f6f3e0...3036faf51a18
< bitcoin-git> bitcoin/master ee0b7c4 practicalswift: build: Pin to specific versions of Python packages we install from PyPI in Travis
< bitcoin-git> bitcoin/master 3036faf Wladimir J. van der Laan: Merge #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis...
< wumpus> can you open an issue for that please? https://github.com/bitcoin/bitcoin/issues/new
< bitcoin-git> [bitcoin] karel-3d opened pull request #14502: Rpc helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
< bitcoin-git> [bitcoin] luke-jr opened pull request #14501: Fix possible data race when committing block files (master...fsync_dir) https://github.com/bitcoin/bitcoin/pull/14501
< bitcoin-git> [bitcoin] sipa closed pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
< bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/23419e4c4939...27bf14f6f3e0
< bitcoin-git> bitcoin/master 4ae50da practicalswift: Revert "qa: Fix codespell error and have lint-spelling error instead of warn"...
< bitcoin-git> bitcoin/master c32cf6a practicalswift: Add ignored word: mut
< bitcoin-git> bitcoin/master 27bf14f Pieter Wuille: Merge #14495: build: Warn (don't fail!) on spelling errors...
< gmaxwell> indeed, we've had people in #bitcoin that were having issues because some third party was trying to password bruteforce their rpc port or something like that..

2018-10-16

< bitcoin-git> [bitcoin] MeshCollider closed pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
< echeveria> all of their "privacy" tools are snake oil, to boot. it's unfortunate that they're impacting bitcoin node users as well as people fooled into using their incompetent software.
< gmaxwell> "We build the software that Bitcoin deserves" ... just so.
< gmaxwell> "Use your personal node to broadcast transactions to the bitcoin network"
< echeveria> gmaxwell: connect your wallet to your own node, using RPC! or something. I don't know much about it other than reading some people trying to do it in #bitcoin.
< bitcoin-git> [bitcoin] mrwhythat opened pull request #14498: rpcwallet: listsentbyaddress RPC (master...listsentbyaddress-rpc) https://github.com/bitcoin/bitcoin/pull/14498
< bitcoin-git> [bitcoin] hebasto opened pull request #14497: docs: Add `doc/bitcoin-conf.md` (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497
< gribble> https://github.com/bitcoin/bitcoin/issues/14494 | Error if # is used in rpcpassword in conf by MeshCollider · Pull Request #14494 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14335: net: refactor: cleanup ThreadSocketHandler (master...2018-09-24-thread-handler-cleanup) https://github.com/bitcoin/bitcoin/pull/14335
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2468471e1398...23419e4c4939