2020-01-04

< wumpus> even the github https://github.com/PierreRochard/bitcoin-acks is gone
< bitcoin-git> [bitcoin] emilengler closed pull request #17830: lint: Add linter to detect wrong file permissions (master...2019-12-test-file-permissions) https://github.com/bitcoin/bitcoin/pull/17830
< gribble> https://github.com/bitcoin/bitcoin/issues/17830 | test: Add test to detect wrong file permissions by emilengler . Pull Request #17830 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #17385: WIP: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
< bitcoin-git> [bitcoin] laanwj merged pull request #17850: Serialization improvements (minimal initial commits) (master...202001_noncastserial) https://github.com/bitcoin/bitcoin/pull/17850
< bitcoin-git> bitcoin/master 593f5e2 Wladimir J. van der Laan: Merge #17850: Serialization improvements (minimal initial commits)
< bitcoin-git> bitcoin/master 9250a08 Pieter Wuille: Convert addrdb/addrman to new serialization
< bitcoin-git> bitcoin/master ca33451 Pieter Wuille: Introduce new serialization macros without casts
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/392edbd49abe...593f5e239f27
< bitcoin-git> [bitcoin] hebasto opened pull request #17869: refactor: Remove unused defines in bitcoinunits.h (master...20200104-refactor-bitcoinunits) https://github.com/bitcoin/bitcoin/pull/17869
< harding> Kiminuo: this channel is for development of the Bitcoin Core software. I don't think Wasabi has a channel, but you can ask general Bitcoin questions in #bitcoin or on https://bitcoin.stackexchange.com/
< bitcoin-git> [bitcoin] fanquake merged pull request #17853: [0.19] psbt: handle unspendable psbts (0.19...fix_unspendable_psbt-0.19) https://github.com/bitcoin/bitcoin/pull/17853
< bitcoin-git> bitcoin/0.19 febf048 fanquake: Merge #17853: [0.19] psbt: handle unspendable psbts
< bitcoin-git> bitcoin/0.19 ca5f8de Andrew Chow: Mark PSBTs spending unspendable outputs as invalid in analysis
< bitcoin-git> bitcoin/0.19 5515833 Andrew Chow: Have a PSBTAnalysis state that indicates invalid PSBT
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/310b29f9c326...febf04841fd9
< bitcoin-git> [bitcoin] fanquake closed pull request #17868: added .vscode/ in .gitignore (master...master) https://github.com/bitcoin/bitcoin/pull/17868
< bitcoin-git> [bitcoin] darafshi opened pull request #17868: added .vscode/ in .gitignore (master...master) https://github.com/bitcoin/bitcoin/pull/17868
< bitcoin-git> [bitcoin] fanquake merged pull request #17859: [0.19] Fix origfee return for bumpfee with feerate arg (0.19...fix_bumpfee_uninitread-0.19) https://github.com/bitcoin/bitcoin/pull/17859
< bitcoin-git> bitcoin/0.19 310b29f fanquake: Merge #17859: [0.19] Fix origfee return for bumpfee with feerate arg
< bitcoin-git> bitcoin/0.19 bd8c6f1 Gregory Sanders: Fix origfee return for bumpfee with feerate arg
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/a284bbbee805...310b29f9c326
< bitcoin-git> [bitcoin] fanquake closed pull request #17459: Remove redundant NDEBUG preprocessor checks (master...20191112-remove-redundant-ndebug-checks) https://github.com/bitcoin/bitcoin/pull/17459
< bitcoin-git> [bitcoin] fanquake closed pull request #17865: scripts: Add system notice prior signing functions in gitian-build.py (master...system_notice-gitian) https://github.com/bitcoin/bitcoin/pull/17865
< bitcoin-git> [bitcoin] fanquake merged pull request #17817: build: Add default configure cache file to .gitignore (master...20191228-gitignore-configure-cache) https://github.com/bitcoin/bitcoin/pull/17817
< bitcoin-git> bitcoin/master 0661a3c Hennadii Stepanov: build: Add default configure cache to .gitignore
< bitcoin-git> bitcoin/master 392edbd fanquake: Merge #17817: build: Add default configure cache file to .gitignore
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a4cc52d734d...392edbd49abe
< bitcoin-git> [bitcoin] fanquake merged pull request #17688: doc: Add "ci" prefix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17688
< bitcoin-git> bitcoin/master 9a4cc52 fanquake: Merge #17688: doc: Add "ci" prefix to CONTRIBUTING.md
< bitcoin-git> bitcoin/master 19267cb Hennadii Stepanov: doc: Add ci prefix to CONTRIBUTING.md
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/816464198c34...9a4cc52d734d
< bitcoin-git> [bitcoin] charlesrocket opened pull request #17865: scripts: Add system notice for prior signing functions in gitan-build.py (master...system_notice-gitian) https://github.com/bitcoin/bitcoin/pull/17865
< bitcoin-git> [bitcoin] fanquake opened pull request #17863: scripts: Add MACHO dylib checks to symbol-check.py (master...add_macos_dylib_checks) https://github.com/bitcoin/bitcoin/pull/17863

2020-01-03

< gribble> https://github.com/bitcoin/bitcoin/issues/16373 | bumpfee: Return PSBT when wallet has privkeys disabled by instagibbs . Pull Request #16373 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #17861: Update .level() to .depth() (master...wallet) https://github.com/bitcoin/bitcoin/pull/17861
< bitcoin-git> [bitcoin] lord-cow opened pull request #17861: Update .level() to .depth() (master...wallet) https://github.com/bitcoin/bitcoin/pull/17861
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17851: tests: Add std::to_string to list of locale dependent functions (master...locale-dependence-of-to_string) https://github.com/bitcoin/bitcoin/pull/17851
< bitcoin-git> bitcoin/master 1f0adb3 practicalswift: tests: Add std::to_string to list of locale dependent functions
< bitcoin-git> bitcoin/master 8164641 MarcoFalke: Merge #17851: tests: Add std::to_string to list of locale dependent functi...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17e14ac92fce...816464198c34
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17860: fuzz: BIP 42, BIP 30, CVE-2018-17144 (master...1908-fuzzVal) https://github.com/bitcoin/bitcoin/pull/17860
< gribble> https://github.com/bitcoin/bitcoin/issues/17682 | util: Update tinyformat to upstream by laanwj . Pull Request #17682 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] luke-jr opened pull request #17859: [0.19] Fix origfee return for bumpfee with feerate arg (0.19...fix_bumpfee_uninitread-0.19) https://github.com/bitcoin/bitcoin/pull/17859
< gribble> https://github.com/bitcoin/bitcoin/issues/17427 | qt: Fix missing qRegisterMetaType for size_t by hebasto . Pull Request #17427 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] paulyc closed pull request #17852: util: Close txindex LDB before exiting bitcoind (master...util_close_txindex_leveldb) https://github.com/bitcoin/bitcoin/pull/17852
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16411: BIP-325: Signet support (master...signet) https://github.com/bitcoin/bitcoin/pull/16411
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16411: BIP-325: Signet support (master...signet) https://github.com/bitcoin/bitcoin/pull/16411
< bitcoin-git> [bitcoin] fanquake opened pull request #17858: [0.19] Backports (0.19...0_19_1_backports) https://github.com/bitcoin/bitcoin/pull/17858
< bitcoin-git> [bitcoin] fanquake opened pull request #17857: scripts: fix symbol-check & security-check argument passing (master...security_check_args) https://github.com/bitcoin/bitcoin/pull/17857
< bitcoin-git> [bitcoin] kallewoof closed pull request #17855: gitignore: add fuzz binaries (master...200103-gitignore-fuzz-binaries) https://github.com/bitcoin/bitcoin/pull/17855
< bitcoin-git> [bitcoin] kallewoof opened pull request #17855: gitignore: add fuzz binaries (master...200103-gitignore-fuzz-binaries) https://github.com/bitcoin/bitcoin/pull/17855
< gribble> https://github.com/bitcoin/bitcoin/issues/17854 | feature: customize OUTPUT_GROUP_MAX_ENTRIES . Issue #17854 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] luke-jr opened pull request #17853: [0.19] psbt: handle unspendable psbts (0.19...fix_unspendable_psbt-0.19) https://github.com/bitcoin/bitcoin/pull/17853
< bitcoin-git> [bitcoin] emilengler closed pull request #17841: util: Make -help more Unix and grep friendly (master...2020-01-unix-and-grep-friendly-help) https://github.com/bitcoin/bitcoin/pull/17841
< bitcoin-git> [bitcoin] paulyc opened pull request #17852: util: Close txindex LDB before exiting bitcoind (master...util_close_txindex_leveldb) https://github.com/bitcoin/bitcoin/pull/17852

2020-01-02

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17781: rpc: Remove mempool global from miner (master...1912-mempoolMiner) https://github.com/bitcoin/bitcoin/pull/17781
< bitcoin-git> bitcoin/master 17e14ac MarcoFalke: Merge #17781: rpc: Remove mempool global from miner
< bitcoin-git> bitcoin/master faa92a2 MarcoFalke: rpc: Remove mempool global from miner
< bitcoin-git> bitcoin/master 6666ef1 MarcoFalke: test: Properly document blockinfo size in miner_tests
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/190a4051fde7...17e14ac92fce
< bitcoin-git> [bitcoin] practicalswift opened pull request #17851: tests: Add std::to_string to list of locale dependent functions (master...locale-dependence-of-to_string) https://github.com/bitcoin/bitcoin/pull/17851
< bitcoin-git> [bitcoin] laanwj merged pull request #17762: net: Log to net category for exceptions in ProcessMessages (master...2019_12_network_exceptions) https://github.com/bitcoin/bitcoin/pull/17762
< bitcoin-git> bitcoin/master 190a405 Wladimir J. van der Laan: Merge #17762: net: Log to net category for exceptions in ProcessMessages
< bitcoin-git> bitcoin/master 4bdd68f Wladimir J. van der Laan: Add missing typeinfo includes
< bitcoin-git> bitcoin/master 4d88c3d Wladimir J. van der Laan: net: Log to net category for exceptions in ProcessMessages
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/52900a764c42...190a4051fde7
< luke-jr> maybe deleting the bitcoin/bitcoin PPA will work best - it won't uninstall anything, and will give the user an error when they update repos
< achow101> I'm pretty sure lots of instructions point to the bitcoin/bitcoin ppa
< MarcoFalke> There is a debian subfolder, but no one has touched it in years: https://github.com/bitcoin-core/packaging/tree/master/debian
< wumpus> packaging bitcoin is a difficult issue
< MarcoFalke> luke-jr: It should be maintained in https://github.com/bitcoin-core/packaging
< luke-jr> I suppose I could update bitcoin/bitcoin if Matt wants to give me access - I just figured it made more sense to retire it
< wumpus> the bitcoin/bitcoin ones are unmaintained at the moment but that's not a fault in PPA
< MarcoFalke> And the bitcoin Core PPA is being used against best practices, so providing one is like encouraging those bad practices
< MarcoFalke> 1) We release versions of Bitcoin Core with different versions of leveldb. So the versioning shouldnt' be an issue. If the packaging is an issue, it can be changed, maybe
< MarcoFalke> luke-jr: Are you volunteering to update the PPA timely for the full matrix of distros/version of Bitcoin Core?
< wumpus> I'm interested in that problem, yes, auto-update kind of sucks for bitcoin
< MarcoFalke> * The ppa only supports one version of Bitcoin Core, so (not) updating Bitcoin Core might lead to issues
< bitcoin-git> [bitcoin] sipa opened pull request #17850: Serialization improvements (minimal initial commits) (master...202001_noncastserial) https://github.com/bitcoin/bitcoin/pull/17850
< luke-jr> wumpus: the bitcoin/bitcoin one Matt used to have is unmaintained now
< wumpus> #topic Vanilla debian Bitcoin Core package (MarcoFalke)
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa . Pull Request #10785 . bitcoin/bitcoin . GitHub
< wumpus> 10 blockers (!), 7 chasing concept ACK https://github.com/bitcoin/bitcoin/projects/8
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
< gribble> https://github.com/bitcoin/bitcoin/issues/17343 | Meta: Packaging Bitcoin Core as vanilla system package . Issue #17343 . bitcoin/bitcoin . GitHub
< wumpus> one proposed topic this week by MarcoFalke : Vanilla debian Bitcoin Core package, #17343
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] hebasto opened pull request #17849: ci: Fix brew python link (master...20200102-travis-brew-python) https://github.com/bitcoin/bitcoin/pull/17849
< gribble> https://github.com/bitcoin/bitcoin/issues/16963 | wallet: Fix unique_ptr usage in boost::signals2 by promag . Pull Request #16963 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17343 | Meta: Packaging Bitcoin Core as vanilla system package . Issue #17343 . bitcoin/bitcoin . GitHub
< MarcoFalke> #proposedmeetingtopic Vanilla debian Bitcoin Core package, #17343
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16658: validation: Rename CheckInputs to CheckInputScripts (master...2019-08-rename-CheckInputs) https://github.com/bitcoin/bitcoin/pull/16658
< bitcoin-git> bitcoin/master 3f8dbcd MarcoFalke: Merge #16658: validation: Rename CheckInputs to CheckInputScripts
< bitcoin-git> bitcoin/master 3bd8db8 John Newbery: [validation] fix comments in CheckInputScripts()
< bitcoin-git> bitcoin/master 6f6465c John Newbery: scripted-diff: [validation] Rename CheckInputs to CheckInputScripts
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0655c7a94cc9...3f8dbcd65547
< Chris_Stewart_5> Is there a document anywhere on bitcoin core's key handling and storage procedures? Or is this a "read the code" situation?
< gribble> https://github.com/bitcoin/bitcoin/issues/15442 | Running iwyu on Bitcoin Core . Issue #15442 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] emilengler closed pull request #17842: util: Check for curl in Posix PATH (master...2020-01-check-curl-path) https://github.com/bitcoin/bitcoin/pull/17842
< bitcoin-git> [bitcoin] laanwj merged pull request #17787: scripts: add MACHO PIE check to security-check.py (master...add_macOS_to_security_check) https://github.com/bitcoin/bitcoin/pull/17787
< bitcoin-git> bitcoin/master 0655c7a Wladimir J. van der Laan: Merge #17787: scripts: add MACHO PIE check to security-check.py
< bitcoin-git> bitcoin/master 7c9e821 fanquake: scripts: add MACHO NOUNDEFS check to security-check.py
< bitcoin-git> bitcoin/master 4ca92dc fanquake: scripts: add MACHO PIE check to security-check.py
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/35fff5be60e8...0655c7a94cc9
< gribble> https://github.com/bitcoin/bitcoin/issues/17827 | Blocks directory on macOS uses more disk space than expected . Issue #17827 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17787 | scripts: add MACHO PIE check to security-check.py by fanquake . Pull Request #17787 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa . Pull Request #10785 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fjahr opened pull request #17843: wallet: Reset reused transactions cache (master...getbalances) https://github.com/bitcoin/bitcoin/pull/17843

2020-01-01

< bitcoin-git> [bitcoin] emilengler opened pull request #17842: util: Check for curl in Posix PATH (master...2020-01-check-curl-path) https://github.com/bitcoin/bitcoin/pull/17842
< bitcoin-git> [bitcoin] emilengler opened pull request #17841: util: Make -help more Unix and grep friendly (master...2020-01-unix-and-grep-friendly-help) https://github.com/bitcoin/bitcoin/pull/17841

2019-12-31

< bitcoin-git> [bitcoin] fanquake closed pull request #17792: 0.19: Backports (0.19...2019-12-backports) https://github.com/bitcoin/bitcoin/pull/17792
< fanquake> Agreement that 600 lines of copyright header "management" bash doesn't belong in the same repository as (in an ideal world would only be) bitcoin core protocol development
< gribble> https://github.com/bitcoin/bitcoin/issues/16625 | scripts: remove github-merge.py by fanquake . Pull Request #16625 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99813a9745fe...35fff5be60e8
< bitcoin-git> bitcoin/master df97e59 Hennadii Stepanov: doc: Update dependencies.md
< bitcoin-git> bitcoin/master 35fff5b fanquake: Merge #17825: doc: Update dependencies.md
< bitcoin-git> [bitcoin] fanquake merged pull request #17825: doc: Update dependencies.md (master...20191229-update-dependencies) https://github.com/bitcoin/bitcoin/pull/17825
< bitcoin-git> [bitcoin] fanquake closed pull request #15103: fix getentropy import check on osx (master...getentropy-weak) https://github.com/bitcoin/bitcoin/pull/15103
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8830cb58abc8...99813a9745fe
< bitcoin-git> bitcoin/master aaaaad6 MarcoFalke: scripted-diff: Bump copyright of files changed in 2019
< bitcoin-git> bitcoin/master 99813a9 fanquake: Merge #17829: scripted-diff: Bump copyright of files changed in 2019
< bitcoin-git> [bitcoin] fanquake merged pull request #17829: scripted-diff: Bump copyright of files changed in 2019 (master...1912-bumpC) https://github.com/bitcoin/bitcoin/pull/17829
< bitcoin-git> [bitcoin] rex4539 opened pull request #17839: [build] depends macOS: hide linker visibility warnings (master...hide-warnings) https://github.com/bitcoin/bitcoin/pull/17839
< bitcoin-git> [bitcoin] kallewoof opened pull request #17838: test: test the >10 UTXO case for output groups (master...191231-test-avoidreuse-many-utxos) https://github.com/bitcoin/bitcoin/pull/17838
< bitcoin-git> [bitcoin] hebasto closed pull request #17837: build: Refactor out Qt version check macro (master...20191230-autoconf-qt-version-macro) https://github.com/bitcoin/bitcoin/pull/17837
< bitcoin-git> [bitcoin] hebasto closed pull request #17836: build: Fix --with-gui configure option without argument (master...20191230-fix-withgui) https://github.com/bitcoin/bitcoin/pull/17836
< bitcoin-git> [bitcoin] hebasto opened pull request #17837: build: Refactor out Qt version check macro (master...20191230-autoconf-qt-version-macro) https://github.com/bitcoin/bitcoin/pull/17837
< gwillen> hmm, what does this mean for using strings from e.g. https://github.com/bitcoin/bitcoin/blob/master/src/util/error.cpp in the UI?
< emilengler> IIRC translations are only in bitcoin-qt
< gwillen> thanks, I found https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md which only references tr() and does not mention _()

2019-12-30

< bitcoin-git> [bitcoin] hebasto opened pull request #17836: build: Fix --with-gui configure option without argument (master...20191230-fix-withgui) https://github.com/bitcoin/bitcoin/pull/17836
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17741: build: Included test_bitcoin-qt in msvc build (master...qt_test) https://github.com/bitcoin/bitcoin/pull/17741
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b931f61b9ab0...8830cb58abc8
< bitcoin-git> bitcoin/master 6e22151 Aaron Clauson: Included test_bitcoin-qt in msvc build.
< bitcoin-git> bitcoin/master 592af5a Aaron Clauson: Moved the include of the system projects to before the build depends on ta...
< bitcoin-git> bitcoin/master 8830cb5 MarcoFalke: Merge #17741: build: Included test_bitcoin-qt in msvc build
< bitcoin-git> [bitcoin] elichai opened pull request #17833: doc: Added running functional tests in valgrind (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17833
< bitcoin-git> [bitcoin] asoltys opened pull request #17831: rpc: doc: Fix and extend getblockstats examples (master...getblockstats-examples) https://github.com/bitcoin/bitcoin/pull/17831

2019-12-29

< bitcoin-git> [bitcoin] emilengler opened pull request #17830: test: Add test to detect wrong file permissions (master...2019-12-test-file-permissions) https://github.com/bitcoin/bitcoin/pull/17830
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17829: scripted-diff: Bump copyright of files changed in 2019 (master...1912-bumpC) https://github.com/bitcoin/bitcoin/pull/17829
< bitcoin-git> [bitcoin] practicalswift opened pull request #17828: net: Use log categories when logging events that P2P peers can trigger arbitrarily (master...log-categories) https://github.com/bitcoin/bitcoin/pull/17828
< bitcoin-git> [bitcoin] hebasto opened pull request #17826: qt: Add -host command-line option (master...20191229-host-info) https://github.com/bitcoin/bitcoin/pull/17826
< bitcoin-git> [bitcoin] hebasto opened pull request #17825: doc: Update dependencies.md (master...20191229-update-dependencies) https://github.com/bitcoin/bitcoin/pull/17825
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fjahr opened pull request #17824: wallet: Fix coin selection for destination groups >10 (master...i17603) https://github.com/bitcoin/bitcoin/pull/17824
< bitcoin-git> [bitcoin] sanjaykdragon opened pull request #17823: script: makeseeds.py improvements (master...master) https://github.com/bitcoin/bitcoin/pull/17823

2019-12-28

< bitcoin-git> [bitcoin] ahook opened pull request #17822: refactor: Use uint16_t instead of unsigned short (master...akh_uint16_t) https://github.com/bitcoin/bitcoin/pull/17822
< bitcoin-git> [bitcoin] fanquake closed pull request #17811: Optimize ToLower() and ToUpper() (master...strcase-bithack) https://github.com/bitcoin/bitcoin/pull/17811
< jonatack> sipsorcery: any tips on fixing this appveyor error for #16702 would be great (travis is green): C:\projects\bitcoin\src\test\addrman_tests.cpp(9,10): fatal error C1083: Cannot open include file: 'test/data/asmap.raw.h': No such file or directory [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #17820: build, qt: Remove duplicated AC_DEFINE(QT_STATICPLUGIN...) macro (master...20191228-remove-duplicated-qtstaticplugin) https://github.com/bitcoin/bitcoin/pull/17820
< bitcoin-git> [bitcoin] jonatack opened pull request #17819: doc: developer notes guideline on RPCExamples addresses (master...rpc-examples-use-invalid-addresses) https://github.com/bitcoin/bitcoin/pull/17819
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6cb80a068dc1...b931f61b9ab0
< bitcoin-git> bitcoin/master 8dc9aa9 Emil Engler: doc: Update license year range to 2020
< bitcoin-git> bitcoin/master b931f61 MarcoFalke: Merge #17801: doc: Update license year range to 2020
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17801: doc: Update license year range to 2020 (master...2019-12-update-license-year-range-to-2020) https://github.com/bitcoin/bitcoin/pull/17801
< bitcoin-git> [bitcoin] sanjaykdragon closed pull request #17816: utils refactor: strencode changes (master...strencode_changes) https://github.com/bitcoin/bitcoin/pull/17816
< bitcoin-git> [bitcoin] fanquake closed pull request #17814: consensus refactor: range based for loops (master...master) https://github.com/bitcoin/bitcoin/pull/17814
< bitcoin-git> [bitcoin] hebasto opened pull request #17817: build: Add default configure cache file to .gitignore (master...20191228-gitignore-configure-cache) https://github.com/bitcoin/bitcoin/pull/17817
< bitcoin-git> [bitcoin] sanjaykdragon opened pull request #17816: utils refactor: strencode changes (master...strencode_changes) https://github.com/bitcoin/bitcoin/pull/17816
< sipa> gleb: they don't use the bitcoin p2p protocol
< bitcoin-git> [bitcoin] emilengler opened pull request #17815: rpc: Make __cookie__ user immune to rpcwhitelist (master...2019-12-rpc-cookie-user-independence) https://github.com/bitcoin/bitcoin/pull/17815
< bitcoin-git> [bitcoin] sanjaykdragon opened pull request #17814: consensus refactor: range based for loops (master...master) https://github.com/bitcoin/bitcoin/pull/17814
< TheFuzzStone[m]> Where how I can create a bot such as bitcoin-git but for other project?
< TheFuzzStone[m]> * How I can create a bot such as bitcoin-git but for other project?
< bitcoin-git> [bitcoin] jonatack opened pull request #17812: net, test: asmap functional tests and feature refinements (master...feature-asmap) https://github.com/bitcoin/bitcoin/pull/17812
< bitcoin-git> [bitcoin] kristapsk opened pull request #17811: Optimize ToLower() and ToUpper() (master...strcase-bithack) https://github.com/bitcoin/bitcoin/pull/17811

2019-12-27

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17806: test: Change filemode of rpc_whitelist.py (master...2019-12-filemode-rpc-whitelist-test) https://github.com/bitcoin/bitcoin/pull/17806
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1dbf3350c683...6cb80a068dc1
< bitcoin-git> bitcoin/master 90df922 Emil Engler: test: Change filemode of rpc_whitelist.py
< bitcoin-git> bitcoin/master 6cb80a0 MarcoFalke: Merge #17806: test: Change filemode of rpc_whitelist.py
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17809: rpc: Auto-format RPCResult (master...1906-rpcResult) https://github.com/bitcoin/bitcoin/pull/17809
< bitcoin-git> [bitcoin] ahook opened pull request #17808: util: Replace itostr/i64tostr with c++11 to_string (master...akh_to_string) https://github.com/bitcoin/bitcoin/pull/17808
< bitcoin-git> [bitcoin] ahook opened pull request #17807: net: Remove unnecessary portability typedef (master...akh_socket_arg_type) https://github.com/bitcoin/bitcoin/pull/17807
< bitcoin-git> [bitcoin] emilengler opened pull request #17806: test: Change filemode of rpc_whitelist.py (master...2019-12-filemode-rpc-whitelist-test) https://github.com/bitcoin/bitcoin/pull/17806
< bitcoin-git> [bitcoin] emilengler opened pull request #17805: test: Add test for rpcwhitelistdefault (master...2019-12-rpc-whitelistdefault-test) https://github.com/bitcoin/bitcoin/pull/17805
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17804: doc: Misc RPC help fixes (master...1912-rpcDocFixes) https://github.com/bitcoin/bitcoin/pull/17804

2019-12-26

< bitcoin-git> [bitcoin] emilengler opened pull request #17801: trivial: Update license year range to 2020 (master...2019-12-update-license-year-range-to-2020) https://github.com/bitcoin/bitcoin/pull/17801
< bitcoin-git> [bitcoin] elichai closed pull request #17402: ci: Travis support for PowerPC64 (master...2019-11-powerpc64) https://github.com/bitcoin/bitcoin/pull/17402

2019-12-25

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17770: bump test timeouts so all functional test run on CI (WIP) (master...bump) https://github.com/bitcoin/bitcoin/pull/17770
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17770: bump test timeouts so all functional test run on CI (WIP) (master...bump) https://github.com/bitcoin/bitcoin/pull/17770

2019-12-24

< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #17055: [0.19] Backport of #15706 (0.19...check-qt-version-0.19) https://github.com/bitcoin/bitcoin/pull/17055
< bitcoin-git> [bitcoin] fanquake opened pull request #17800: random: don't special case clock usage on macOS (master...random_macos_clocks) https://github.com/bitcoin/bitcoin/pull/17800
< bitcoin-git> [bitcoin] fanquake closed pull request #17799: Create 1 (master...master) https://github.com/bitcoin/bitcoin/pull/17799
< bitcoin-git> [bitcoin] thomcari81 opened pull request #17799: Create 1 (master...master) https://github.com/bitcoin/bitcoin/pull/17799
< bitcoin-git> [bitcoin] fanquake closed pull request #17798: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/17798
< bitcoin-git> [bitcoin] thomcari81 opened pull request #17798: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/17798

2019-12-23

< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0cda5573405d...1dbf3350c683
< bitcoin-git> bitcoin/master b6fa752 Hennadii Stepanov: ci: Update Qt binaries for GitHub Actions
< bitcoin-git> bitcoin/master 0b5a366 Hennadii Stepanov: ci: Update vcpkg cache on MSBuild update
< bitcoin-git> bitcoin/master 1dbf335 fanquake: Merge #17793: ci: Update GitHub Actions CI vcpkg cache on MSBuild update
< bitcoin-git> [bitcoin] fanquake merged pull request #17793: ci: Update GitHub Actions CI vcpkg cache on MSBuild update (master...20191223-vcpkg-cache) https://github.com/bitcoin/bitcoin/pull/17793
< bitcoin-git> [bitcoin] emilengler opened pull request #17795: gui: Shortcut to close RPC Console (master...2019-12-gui-close-rpcconsole-shortcut) https://github.com/bitcoin/bitcoin/pull/17795
< bitcoin-git> [bitcoin] sipsorcery closed pull request #17789: Update Qt binaries for GitHub Action CI job (master...ghaction-vs2019) https://github.com/bitcoin/bitcoin/pull/17789
< bitcoin-git> [bitcoin] jbampton opened pull request #17794: Use best practice for Python chained comparisions. (master...fix-chained-comparision) https://github.com/bitcoin/bitcoin/pull/17794
< bitcoin-git> [bitcoin] hebasto opened pull request #17793: ci: Update GitHub Actions CI vcpkg cache on MSBuild update (master...20191223-vcpkg-cache) https://github.com/bitcoin/bitcoin/pull/17793
< bitcoin-git> [bitcoin] promag opened pull request #17792: 0.19: Backports (0.19...2019-12-backports) https://github.com/bitcoin/bitcoin/pull/17792

2019-12-22

< bitcoin-git> [bitcoin] hebasto opened pull request #17791: Remove UBSan suppressions for CTxMemPool* (master...20191222-mempool-ub) https://github.com/bitcoin/bitcoin/pull/17791
< bitcoin-git> [bitcoin] andrewtoth opened pull request #17790: Fix getmininginfo currentblockweight inaccuracy (master...getmininginfo-weight) https://github.com/bitcoin/bitcoin/pull/17790
< bitcoin-git> [bitcoin] sipsorcery opened pull request #17789: Update Qt binaries for GitHub Action CI job (master...ghaction-vs2019) https://github.com/bitcoin/bitcoin/pull/17789

2019-12-21

< bitcoin-git> [bitcoin] fanquake opened pull request #17787: scripts: add MACHO PIE check to security-check.py (master...add_macOS_to_security_check) https://github.com/bitcoin/bitcoin/pull/17787
< bitcoin-git> [bitcoin] hebasto opened pull request #17786: refactor: Nuke policy/fees->mempool circular dependencies (master...20191221-mempool-circ-dep) https://github.com/bitcoin/bitcoin/pull/17786

2019-12-20

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6677be64f69b...0cda5573405d
< bitcoin-git> bitcoin/master 6094222 hackerrdave: use preferred shebang approach for documentation
< bitcoin-git> bitcoin/master 0cda557 MarcoFalke: Merge #17751: doc: use recommended shebang approach in documentation code ...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17751: doc: use recommended shebang approach in documentation code block (master...docs-shebang) https://github.com/bitcoin/bitcoin/pull/17751
< bitcoin-git> [bitcoin] hebasto opened pull request #17785: p2p: Unify Send and Receive protocol versions (master...20191220-unify-protocol-versions) https://github.com/bitcoin/bitcoin/pull/17785
< gribble> https://github.com/bitcoin/bitcoin/issues/17500 | refactor, qt: Nuke walletframe circular dependency by hebasto . Pull Request #17500 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17783: util: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior (master...pr/wdnolist) https://github.com/bitcoin/bitcoin/pull/17783
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17781: rpc: Remove mempool global from miner (master...1912-mempoolMiner) https://github.com/bitcoin/bitcoin/pull/17781

2019-12-19

< gribble> https://github.com/bitcoin/bitcoin/issues/17746 | rpc: Remove vector copy from listtransactions by promag . Pull Request #17746 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #17777: tests: Add fuzzing harness for DecodeHexTx(...) (master...fuzzers-decode_tx) https://github.com/bitcoin/bitcoin/pull/17777
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3e949380725c...6677be64f69b
< bitcoin-git> bitcoin/master 3f7dc9b Russell Yanofsky: refactor: Clean up long lines in settings code
< bitcoin-git> bitcoin/master 57e8b7a Russell Yanofsky: refactor: Clean up includeconf comments
< bitcoin-git> bitcoin/master dc0f148 Russell Yanofsky: refactor: Replace FlagsOfKnownArg with GetArgFlags
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17473: refactor: Settings code cleanups (master...pr/cleanset) https://github.com/bitcoin/bitcoin/pull/17473
< fanquake> dongcarl I think the resolution is in the #bitcoin-builds log, will recheck
< wumpus> #link fanquake's build system plans https://github.com/bitcoin/bitcoin/issues/17768
< gribble> https://github.com/bitcoin/bitcoin/issues/17768 | build: various build system improvements . Issue #17768 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 . Pull Request #17261 . bitcoin/bitcoin . GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< elichai2> luke-jr: Google is really angry about your site: http://luke.dashjr.org/programs/bitcoin/
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17773: test: Properly deserialize witness transactions in wallet_basic test (master...1912-testWalletVsizeWitness) https://github.com/bitcoin/bitcoin/pull/17773
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f9fbb89e82f...3e949380725c
< bitcoin-git> bitcoin/master 34d826e Emil Engler: doc: Mention PR Club in CONTRIBUTING.md
< bitcoin-git> bitcoin/master 3e94938 MarcoFalke: Merge #17772: doc: Mention PR Club in CONTRIBUTING.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17772: doc: Mention PR Club in CONTRIBUTING.md (master...2019-12-pr-club) https://github.com/bitcoin/bitcoin/pull/17772
< bitcoin-git> [bitcoin] fanquake merged pull request #17769: build: set AC_PREREQ to 2.69 (master...set_ac_prereq_264) https://github.com/bitcoin/bitcoin/pull/17769
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fef85bfa3cd...7f9fbb89e82f
< bitcoin-git> bitcoin/master 4f4ae6f fanquake: build: set AC_PREREQ to 2.69
< bitcoin-git> bitcoin/master 7f9fbb8 fanquake: Merge #17769: build: set AC_PREREQ to 2.69
< fanquake> you could ask james to benchmark something specific https://github.com/bitcoin/bitcoin/pull/17398#issuecomment-556038507
< bitcoin-git> [bitcoin] instagibbs opened pull request #17775: DecodeHexTx: Try case where txn has inputs first (master...decode_wit_first) https://github.com/bitcoin/bitcoin/pull/17775

2019-12-18

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17773: test: Fix rare error in wallet_basic test for witness transactions (master...1912-testWalletVsizeWitness) https://github.com/bitcoin/bitcoin/pull/17773
< jtimon> review beg, one more time https://github.com/bitcoin/bitcoin/pull/17037
< gribble> https://github.com/bitcoin/bitcoin/issues/17769 | build: set AC_PREREQ to 2.64 by fanquake . Pull Request #17769 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] emilengler opened pull request #17772: doc: Mention PR Club in CONTRIBUTING.md (master...2019-12-pr-club) https://github.com/bitcoin/bitcoin/pull/17772
< bitcoin-git> [bitcoin] practicalswift opened pull request #17771: tests: Add fuzzing harness for V1TransportDeserializer (P2P transport) (master...fuzzers-p2p_transport_deserializer) https://github.com/bitcoin/bitcoin/pull/17771
< jamesob> review beg for what should be a pretty uncontroversial test-only change that increases coverage of the coins infrastructure: https://github.com/bitcoin/bitcoin/pull/17669
< gribble> https://github.com/bitcoin/bitcoin/issues/6971 | Is the InitialBlockDownload() check in getheaders too strict? . Issue #6971 . bitcoin/bitcoin . GitHub
< sipsorcery> elichai2: do you know about, bitcoin-cli help addnode
< bitcoin-git> [bitcoin] michiboo opened pull request #17770: bump test timeouts so all functional test run on CI (WIP) (master...bump) https://github.com/bitcoin/bitcoin/pull/17770
< bitcoin-git> [bitcoin] fanquake opened pull request #17769: build: set AC_PREREQ to 2.64 (master...set_ac_prereq_264) https://github.com/bitcoin/bitcoin/pull/17769

2019-12-17

< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/47f45b677653...6fef85bfa3cd
< bitcoin-git> bitcoin/master faede70 MarcoFalke: doc: Add formatting to the good first issue template
< bitcoin-git> bitcoin/master 6fef85b fanquake: Merge #17764: doc: Add formatting to the good first issue template
< bitcoin-git> [bitcoin] fanquake merged pull request #17764: doc: Add formatting to the good first issue template (master...1912-docGFI) https://github.com/bitcoin/bitcoin/pull/17764
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17767: ci: Fix qemu issues (master...1912-ciFixWrapQemu) https://github.com/bitcoin/bitcoin/pull/17767
< bitcoin-git> [bitcoin] fanquake merged pull request #17686: build: add -bind_at_load to macOS hardened LDFLAGS (master...macos_ld_explicit_bind_at_load) https://github.com/bitcoin/bitcoin/pull/17686
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab4e6ad76294...47f45b677653
< bitcoin-git> bitcoin/master c78b123 fanquake: build: add -bind_at_load to hardened LDFLAGS
< bitcoin-git> bitcoin/master 47f45b6 fanquake: Merge #17686: build: add -bind_at_load to macOS hardened LDFLAGS
< bitcoin-git> [bitcoin] fanquake closed pull request #17766: https://money.alfabank.ru/p2p/web/transfer/ssaprygin3 (#1) (master...master) https://github.com/bitcoin/bitcoin/pull/17766
< bitcoin-git> [bitcoin] 1b3634f6-9166-46d7-a43a-51d575159cf0 opened pull request #17766: https://money.alfabank.ru/p2p/web/transfer/ssaprygin3 (#1) (master...master) https://github.com/bitcoin/bitcoin/pull/17766
< bitcoin-git> [bitcoin] fanquake merged pull request #17756: build: remove WINDOWS_BITS from build system (master...remove_windows_bitness) https://github.com/bitcoin/bitcoin/pull/17756
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e6acd9f72c61...ab4e6ad76294
< bitcoin-git> bitcoin/master abc147d fanquake: build: remove WINDOWS_BITS from build system
< bitcoin-git> bitcoin/master ab4e6ad fanquake: Merge #17756: build: remove WINDOWS_BITS from build system
< bitcoin-git> [bitcoin] fanquake merged pull request #17537: wallet: Cleanup and move opportunistic and superfluous TopUp()s (master...cleanup-topups) https://github.com/bitcoin/bitcoin/pull/17537
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17764: doc: Add formatting to the good first issue template (master...1912-docGFI) https://github.com/bitcoin/bitcoin/pull/17764
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/890eac8f8286...e6acd9f72c61
< bitcoin-git> bitcoin/master bb2c8ce Andrew Chow: keypool: Remove superfluous topup from CWallet::GetNewChangeDestination
< bitcoin-git> bitcoin/master ea50e34 Andrew Chow: keypool: Move opportunistic TopUps from LegacyScriptPubKeyMan to CWallet a...
< bitcoin-git> bitcoin/master 6e77a7b Andrew Chow: keypool: Add comment about TopUp and when to use it
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a54c16cdb652...890eac8f8286
< bitcoin-git> bitcoin/master facb416 MarcoFalke: ci: Add valgrind run
< bitcoin-git> bitcoin/master 890eac8 MarcoFalke: Merge #17725: ci: Add valgrind run
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17725: ci: Add valgrind run (master...1911-ciValgrind) https://github.com/bitcoin/bitcoin/pull/17725
< gribble> https://github.com/bitcoin/bitcoin/issues/17537 | wallet: Cleanup and move opportunistic and superfluous TopUp()s by achow101 . Pull Request #17537 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7df6a7ea9812...a54c16cdb652
< bitcoin-git> bitcoin/master e190000 Elichai Turkel: ci-s390x: Add qemu and depends support in the ci script
< bitcoin-git> bitcoin/master a54c16c MarcoFalke: Merge #17661: ci: use depends for s390x
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17661: ci: use depends for s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17661
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03dfa3664107...7df6a7ea9812
< bitcoin-git> bitcoin/master 419ef3b Mark Tyneway: CNetAddr: fix IsRFC2544 comment