< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11762: Avoid locking mutexes that are already held by the same thread (master...remove-double-locks) https://github.com/bitcoin/bitcoin/pull/11762
< bitcoin-git>
bitcoin/master 05714f9 MarcoFalke: Merge #11762: Avoid locking mutexes that are already held by the same thread...
< bitcoin-git>
bitcoin/master 01a06d6 practicalswift: Avoid locking mutexes that are already held by the same thread
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #12764: doc: Remove field in getblocktemplate help that has never been used. (master...remove_unused_gbt_field) https://github.com/bitcoin/bitcoin/pull/12764
< bitcoin-git>
bitcoin/master ac8a1d0 Conor Scott: [RPC] Remove field in getblocktemplate help that has never been used
< bitcoin-git>
bitcoin/master 10b9a81 MarcoFalke: Merge #12764: doc: Remove field in getblocktemplate help that has never been used....
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #12825: Only allocate a LevelDB block cache if LevelDB will actually use it (master...buffer-cache) https://github.com/bitcoin/bitcoin/pull/12825
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #12984: logs: Make the columns in subsequent UpdateTip log entries horizontally aligned (master...attention-to-detail) https://github.com/bitcoin/bitcoin/pull/12984
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13729: travis: Avoid unnecessarily setting env variables on the lint build (master...ci-lint-env) https://github.com/bitcoin/bitcoin/pull/13729
< bitcoin-git>
bitcoin/master 515348f Ben Woosley: Don't unnecessarily install shellcheck on the lint build...
< bitcoin-git>
bitcoin/master 751c958 Ben Woosley: Use the Travis python language feature on the lint build...
< bitcoin-git>
bitcoin/master 1be5c33 Ben Woosley: Avoid unnecessarily setting env variables on the lint build...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13683: wallet: Introduce assertion to document the assumption that cache and cache_used are always set in tandem (master...null-pointer-dereference) https://github.com/bitcoin/bitcoin/pull/13683
< bitcoin-git>
bitcoin/master e8c7434 MarcoFalke: Merge #13683: wallet: Introduce assertion to document the assumption that cache and cache_used are always set in tandem...
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #12764: Remove field in getblocktemplate help that has never been used. (master...remove_unused_gbt_field) https://github.com/bitcoin/bitcoin/pull/12764
< bitcoin-git>
[bitcoin] AtsukiTak opened pull request #13733: Utils: Refactor ArgsManager a little (master...tiny-refactor-args-manager) https://github.com/bitcoin/bitcoin/pull/13733
< walletissue>
I have big problem with my wallet , I have synced the bitcoin core wallet with blockchain network recently and now I can see transactions in my wallet and I have positive receive transactions but I cant see my btc in my balance or transfer it to other addresses I need urgent help to fic problem.
< fanquake>
I've added a "Mergeable" list to https://github.com/bitcoin/bitcoin/projects/8. It'll be easy to add very close to/mergeable PRs to that, rather than always calling them out here.
< bitcoin-git>
[bitcoin] Empact opened pull request #13729: Scripts and tools: Avoid unnecessarily setting env variables on the lint build (master...ci-lint-env) https://github.com/bitcoin/bitcoin/pull/13729
< bitcoin-git>
[bitcoin] Empact opened pull request #13728: Run the CI lint stage on mac and linux both (master...bsd-bash-compatibility) https://github.com/bitcoin/bitcoin/pull/13728
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #13724: [contrib] Support ARM and RISC-V symbol check (master...symbol-check-all) https://github.com/bitcoin/bitcoin/pull/13724
< bitcoin-git>
[bitcoin] hmel opened pull request #13722: [Trivial] Use variable name instead of relying on class layout (master...use_varname_not_this) https://github.com/bitcoin/bitcoin/pull/13722
< kallewoof>
I'm torn on https://github.com/bitcoin/bitcoin/pull/12257#discussion_r203741762 -- on the one hand, we want to give correct values for ancestor count; on the other hand, the reason ancestor count is taken into account is because we want to avoid too-long chains of unconfirmed transactions, which is separate. on the third (?) hand, the accurate ancestor count will give a hint at the number of ancestors the resulting transaction
< bitcoin-git>
[bitcoin] achow101 opened pull request #13721: Bugfixes for BIP 174 combining and deserialization (master...psbt-fixes) https://github.com/bitcoin/bitcoin/pull/13721
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13712: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation. (master...check-ParseUInt32-return-value) https://github.com/bitcoin/bitcoin/pull/13712
< bitcoin-git>
bitcoin/master 27ee53c practicalswift: wallet: Add error handling. Check return value of ParseUInt32(...) in ParseHDKeypath(...).
< bitcoin-git>
bitcoin/master aba2e66 MarcoFalke: Merge #13712: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation....
< bitcoin-git>
bitcoin/master 7223263 practicalswift: wallet: Add tests for ParseHDKeypath(...)
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13720: build: Make lint-locale-dependence.sh work with BSD grep (avoid empty subexpressions) (master...bsd-grep-compatibility) https://github.com/bitcoin/bitcoin/pull/13720
< bitcoin-git>
[bitcoin] sipa opened pull request #13719: Avoid creating a temporary vector for size-prefixed elements (master...201807_psbt_no_vec_serialize) https://github.com/bitcoin/bitcoin/pull/13719
< gmaxwell>
wumpus: right, I think the reason I found the socket most interesting was better security, e.g. making it easy to give a group access to the bitcoin daemon rather than all of localhost.
< gmaxwell>
wumpus: Do we have a way to test it without bitcoin-cli support?
< wumpus>
otherwise I'm not sure this is ever going to happen, though I still think it's useful even without bitcoin-cli support
< cfields>
wumpus: I think that makes sense. They're Bitcoin Core downloads, not Bitcoin downloads. If bitcoin.org wants to mirror them, that's their prerogative.
< luke-jr>
wumpus: I think we should leave that up to bitcoin.org, and encourage them to be multi-fullnode
< wumpus>
provoostenator: so can you connect locally to the 127.0.0.1:port that tor connects on to reach bitcoin?
< wumpus>
so in any case: does everyone think I should stop uploading bitcoin core to bitcoin.org? this would be a complete break with them, maybe that's better than waiting for cobra to decide to no longer support core as he's already threatened at least once, but I'm ambivalent abouti t
< moneyball>
The current thinking is to have it in Tokyo in October after Scaling Bitcoin
< luke-jr>
(and making it harder to "just run bitcoin.org" seems a step in that direction)
< luke-jr>
if people are running/updating Core simply because it's on bitcoin.org, that is kind of a systemic risk we should address if possible
< achow101>
there's ongoing work to move all of the bitcoin core stuff from bitcoin.org to bitcoincore.org
< luke-jr>
Cobra wanted to make Knots the "default" on bitcoin.org a while back; we could encourage that, or (probably better) encourage not having a "default"
< achow101>
wumpus: are you aware of the recent events on bitcoin.org?
< wumpus>
achow101: are you seriously suggesting I should no longer update bitcoin.org and upload binaries there?
< wumpus>
luke-jr: possibly, but at the least it loses the qsettings, that's also why it's not "Bitcoin core" named there yet
< achow101>
as in we should simply take the bitcoin.org steps out of our release process and if someone wants to do them later, then that's fine
< achow101>
I was thinking that it may not be appropriate to make release posts on bitcoin.org, at least not before they go up on bitcoincore.or
< wumpus>
I think the link to bitcoin.org is only for the *general* descriptoin of bitcoin
< luke-jr>
bitcoin.org could increase distance further, but someone needs to do that work, and people whined when they tried, so I think it's stuck
< provoostenator>
And there's guiconstants.h: QAPP_ORG_DOMAIN "bitcoin.org"
< jnewbery>
I don't think we link to bitcoin.org for downloads any more
< achow101>
we still link to bitcoin.org for things like downloads
< wumpus>
#topic moving away from bitcoin.org more (achow101)
< achow101>
topic suggestion: moving away from bitcoin.org more
< jonasschnelli>
No strong opinion... but slighly prefere to have it under the bitcoin-core repository
< lclc>
I know there are several seeder implementations but it appears to be the most used one. And since getting new node IPs by DNS is the default way to bootstrap a node in Core I think it makes sense to have one implementation in the bitcoin-core org.
< luke-jr>
should we put bfgminer, knots, kallewoof's script debugger stuff, etc under bitcoin-core too? :p
< lclc>
I though because there are a few open issues and simple PRs for bitcoin-seeder and it might would make sense that several Bitcoin maintainers have merge rights.
< wumpus>
#topic bitcoin-seeder under bitcoin-core GitHub organisation (lclc)
< bitcoin-git>
[bitcoin] masonicboom opened pull request #13717: docs: Link to python style guidelines from developer notes (master...link-to-python-style-guidelines-from-dev-notes) https://github.com/bitcoin/bitcoin/pull/13717
< gribble>
https://github.com/bitcoin/bitcoin/issues/13712 | wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation. by practicalswift · Pull Request #13712 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/13426 | [bugfix] Add u8path and u8string to fix encoding issue for Windows by ken2812221 · Pull Request #13426 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] marcoagner opened pull request #13715: tests: fixes mininode's P2PConnection sending messages on closing transport (master...fix_mininode_p2pconnection_send_message) https://github.com/bitcoin/bitcoin/pull/13715
< bitcoin-git>
[bitcoin] ken2812221 closed pull request #13660: [depends] Don't build Qt dependencies if it doesn't support Qt (master...qt-packages-fix) https://github.com/bitcoin/bitcoin/pull/13660
< gribble>
https://github.com/bitcoin/bitcoin/issues/9662 | Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets by jonasschnelli · Pull Request #9662 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #13714: [gitian-build] Add automatical lxc network setup for Bionic (master...gitian-build-auto-install) https://github.com/bitcoin/bitcoin/pull/13714
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #13713: Ignore new blocks when -stopatheight target has been reached (master...2018/07/stopatheight) https://github.com/bitcoin/bitcoin/pull/13713
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13712: wallet: Add error handling. Check return value of ParseUInt32(...) in… (master...check-ParseUInt32-return-value) https://github.com/bitcoin/bitcoin/pull/13712
< bitcoin-git>
[bitcoin] AkioNak opened pull request #13711: [bench] Add benchmark for unserialize prevector (master...add_bench_unserialize) https://github.com/bitcoin/bitcoin/pull/13711
< bitcoin-git>
[bitcoin] masonicboom opened pull request #13707: Tests: add usage note to check-rpc-mappings.py (master...add-usage-note-to-check-rpc-mappings) https://github.com/bitcoin/bitcoin/pull/13707
2018-07-18
< bitcoin-git>
[bitcoin] mitchellcash opened pull request #13706: doc: Minor improvements to release-process.md (master...release_process_doc) https://github.com/bitcoin/bitcoin/pull/13706
< bitcoin-git>
bitcoin/master 585db54 Wladimir J. van der Laan: Merge #13655: bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err...
< bitcoin-git>
bitcoin/master 417b6c1 Thomas Kerin: bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes
< bitcoin-git>
[bitcoin] laanwj closed pull request #13625: doc: Add release notes for -printtoconsole and -debuglogfile changes (master...printtoconsole_release_notes) https://github.com/bitcoin/bitcoin/pull/13625
< bitcoin-git>
bitcoin/master 801cb30 Samuel B. Atwood: doc: Add release notes for -printtoconsole and -debuglogfile changes...
< bitcoin-git>
bitcoin/master 7146672 Wladimir J. van der Laan: Merge #13625: doc: Add release notes for -printtoconsole and -debuglogfile changes...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13687: travis: Check that ~/.bitcoin is never created (master...Mf1709-travisHomeDirBtc) https://github.com/bitcoin/bitcoin/pull/13687
< bitcoin-git>
bitcoin/master 9d26b69 Wladimir J. van der Laan: Merge #13687: travis: Check that ~/.bitcoin is never created...
< bitcoin-git>
bitcoin/master fabe28a MarcoFalke: qa: Temporarily disable test that reads the default datadir location
< bitcoin-git>
bitcoin/master 41a8c8d MarcoFalke: travis: Check that ~/.bitcoin is never created
< bitcoin-git>
[bitcoin] laanwj closed pull request #13672: Modified in_addr6 cast in CConman class to work with msvc (master...ip6castfix) https://github.com/bitcoin/bitcoin/pull/13672
< gribble>
https://github.com/bitcoin/bitcoin/issues/13247 | Add tests to SingleThreadedSchedulerClient() and document the memory model by skeees · Pull Request #13247 · bitcoin/bitcoin · GitHub
< kallewoof>
AHemlocksLie: start off reading all the docs you can find on github.com/bitcoin/bitcoin in particular the developer docs and contributor guidelines. Then look at pull requests people have made and get a feel for how the process works. To actually do something, I suggest actually using the software. You run into things you want to improve and then you work on that.
< bitcoin-git>
[bitcoin] masonicboom opened pull request #13698: doc: Document contributing a scripted diff (master...scripted-diff-docs) https://github.com/bitcoin/bitcoin/pull/13698
< abitman>
hi everyone, i am new to bitcoin core development. I have setup my bitcoin core project with Eclipse CDT on a Mac. I am able to compile, run and debug the build. However, I am not make my IDE to find the #include<util.h> and all the header source files.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #13692: contrib: Clone core repo in gitian-build (master...Mf1807-contribGitianBuild) https://github.com/bitcoin/bitcoin/pull/13692
< bitcoin-git>
[bitcoin] qmma70 closed pull request #13490: Break when active block tip is higher than nStopAtHeight (master...rewind) https://github.com/bitcoin/bitcoin/pull/13490
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11359: Add a pruning 'high water mark' to reduce the frequency of pruning events (master...2017-09-add-pruning-hwm) https://github.com/bitcoin/bitcoin/pull/11359
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #13663: tests: Avoid read/write to default datadir (master...Mf1807-qaNoDefaultDatadir) https://github.com/bitcoin/bitcoin/pull/13663
< bitcoin-git>
[bitcoin] Sjors opened pull request #13662: Explain when reindex-chainstate can be used instead of reindex (master...2018/07/reindex-chainstate-doc) https://github.com/bitcoin/bitcoin/pull/13662
< bitcoin-git>
[bitcoin] ken2812221 reopened pull request #13660: [depends] Don't build Qt dependencies if it doesn't support Qt (master...qt-packages-fix) https://github.com/bitcoin/bitcoin/pull/13660
< bitcoin-git>
[bitcoin] ken2812221 closed pull request #13660: [depends] Don't build Qt dependencies if it doesn't support Qt (master...qt-packages-fix) https://github.com/bitcoin/bitcoin/pull/13660
< sipa>
Tony_: #bitcoin or bitcoin.stackexchange.clm
< bitcoin-git>
[bitcoin] sipa closed pull request #11658: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after (master...ibd_prune_extra) https://github.com/bitcoin/bitcoin/pull/11658
< bitcoin-git>
bitcoin/master 9a1ad2c Pieter Wuille: Merge #11658: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after...
< bitcoin-git>
bitcoin/master ac51a26 Luke Dashjr: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after...