< wumpus>
agree, though 'as part of the bitcoin core project' is in one place, more or less, it doesn't necessarily mean one repository
< phantomcircuit>
sipa, ip<->asn lookup is definitely something that would be useful outside of bitcoin, i've tried myself to do it in the past but without an active bgp session it's basically impossible to get the map at all
< sipa>
so the process is (bgp dumps) -> mapping (currently, using gleb's rust tool); mapping -> asmap file (currently using some python scripts, or the bitcoin-asmap tool i'm adding in 18573)
< jb55>
if it was signed with the same key we're using for verifying bitcoin releases for instance
< sipa>
it's a binary blob you can load into bitcoin core that affects how it selects outgoing peers and prioritizes incoming connections
< jb55>
sipa: is there a writeup about the asmap stuff somewhere? what's problems its trying to solve, how and why I need to generate those files, etc. as one of the people who maintains the bitcoin package on nixos, would I need to generate that and package it for users, etc?
< sipa>
my fuzz test right now generates random inputs to the encoder function used by bitcoin-asmap directly
< luke-jr>
if bitcoin-asmap is available, we can use it for tests too, but still separate from the main repo
< sipa>
luke-jr: i think the primary advantage is that it allows testing/fuzzing the encoder together with the exact code bitcoin core is using for lookups
< wumpus>
sipa: we've intentionally kept all kinds of developer tools in bitcoin-maintainer-tools repo instead, but if you think this is something a lot of users are going to need we could ship it with bitcoin core itself sure
< sipa>
i have #18573 that adds a binary for constructing/decoding these map files, which is an approach i like, but perhaps it's better to keep this out of bitcoin core's scope for now, unsure
< sipa>
for the wallet<->node communication my big hope was that the protocol would be Bitcoin P2P, so that it can be substituted with whatever on either side... but it doesn't seem anyone's working on that
< wumpus>
tryphe: if that's your concern, encrypt the entire wallet file or store it on an encrypted file system, it's not something bitcoin core's wallet encyrption solves
< wumpus>
tryphe: I think that's unrelated; wallet encryption in bitcoin core only protects private keys, nothing more. Labels and such are not part of that either and should definitely be kept.
< bitcoin-git>
[bitcoin] jnewbery opened pull request #18675: tests: Don't initialize PrecomputedTransactionData in txvalidationcache tests (master...2020-04-precomputedtransactiondata-txvalidationcache) https://github.com/bitcoin/bitcoin/pull/18675
< gribble>
https://github.com/bitcoin/bitcoin/issues/18550 | Store destdata for change in separate key for backward compatibility by luke-jr · Pull Request #18550 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/18550 | Store destdata for change in separate key for backward compatibility by luke-jr · Pull Request #18550 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] theStack opened pull request #18672: test: add further BIP37 size limit checks to p2p_filter.py (master...20200416-test-add-further-bloom-filter-size-limit-checks) https://github.com/bitcoin/bitcoin/pull/18672
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
< bitcoin-git>
bitcoin/master bee88b8 James O'Beirne: tests: have coins simulation test also use CCoinsViewDB
< bitcoin-git>
bitcoin/master d8dfcea MarcoFalke: Merge #17669: tests: have coins simulation test also use CCoinsViewDB
< bitcoin-git>
[bitcoin] hebasto opened pull request #18665: Do not expose -logthreadnames when it does not work (master...200416-logthreads) https://github.com/bitcoin/bitcoin/pull/18665
< bitcoin-git>
[bitcoin] meshcollider closed pull request #18572: Wallet: Accept "changedata" db key as an alias to "destdata" (master...changedata_forwardcompat) https://github.com/bitcoin/bitcoin/pull/18572
< bitcoin-git>
[bitcoin] meshcollider closed pull request #18550: Store destdata for change in separate key for backward compatibility (master...changedata) https://github.com/bitcoin/bitcoin/pull/18550
< gribble>
https://github.com/bitcoin/bitcoin/issues/18550 | Store destdata for change in separate key for backward compatibility by luke-jr · Pull Request #18550 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] saahilshangle opened pull request #18663: doc: Adding hyperlink to INSTALL.md in README.md (master...readme-build-instructions) https://github.com/bitcoin/bitcoin/pull/18663
2020-04-15
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18662: refactor: Replace gArgs with local argsman in all utility tools (master...2004-toolsArgsman) https://github.com/bitcoin/bitcoin/pull/18662
< elichai2>
and if I understand correctly Google will actually pay you if you integrate into oss-fuzz https://github.com/bitcoin-core/secp256k1/issues/739 "We want to stress that anyone who meets the eligibility criteria and integrates a project with OSS-Fuzz is eligible for a reward."
< BlueMatt>
well by the time you've done that much work you might as well run it on our own hardware (without the aggressive public-disclosure timelines that may put bitcoin users at risk...)
< elichai2>
I have my own PC dedicated for profiling benchmarking, trying different system wide changes to Bitcoin Core
< BlueMatt>
a few bitcoin groups gave them some funds afaiu
< BlueMatt>
(as a reminder: lots of cpu cores are available in a few locations for those doing bitcoin open source work)
< BlueMatt>
elichai2: also note that oss-fuzz primarily just provides cpu hours, it doesn't do any actual implementation work for you, and getting access to a few hundred cores for bitcoin core fuzzing is rather easy :p
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18645: [doc] Update thread information in developer docs (master...2020-04-doc-threads) https://github.com/bitcoin/bitcoin/pull/18645
< bitcoin-git>
bitcoin/master e84a5f0 MarcoFalke: Merge #18645: [doc] Update thread information in developer docs
< bitcoin-git>
bitcoin/master 808ef36 John Newbery: [doc] Update thread information in developer docs
< sipa>
though if i remember correctly, at the time there also was no (meaningful) fuzzers for bitcoin core, so it was mostly a philosophical point
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657
< bitcoin-git>
[bitcoin] achow101 closed pull request #18627: rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items (master...split-watchonly) https://github.com/bitcoin/bitcoin/pull/18627
< bitcoin-git>
[bitcoin] achow101 opened pull request #18656: gui: Add a `Make unsigned` button next to `Send` (master...make-unsigned-button) https://github.com/bitcoin/bitcoin/pull/18656
< bitcoin-git>
[bitcoin] achow101 opened pull request #18655: gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior (master...split-bumpfeeaction) https://github.com/bitcoin/bitcoin/pull/18655
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18650: qt: Make bitcoin.ico non-executable (master...bitcoin.ico-executable-flag) https://github.com/bitcoin/bitcoin/pull/18650
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18649: tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh (master...locale-dependent-functions) https://github.com/bitcoin/bitcoin/pull/18649
< bitcoin-git>
[bitcoin] naumenkogs opened pull request #18642: Use std::chrono for the time to rotate destination of addr messages + tests (master...2020_04_mock_addr_rotation_time) https://github.com/bitcoin/bitcoin/pull/18642
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18641: test: Create cached blocks not in the future (master...2004-qaNoCacheFuture) https://github.com/bitcoin/bitcoin/pull/18641
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18596: test: Try once more when RPC connection fails on Windows (master...2004-testWin) https://github.com/bitcoin/bitcoin/pull/18596
< bitcoin-git>
bitcoin/master faa6557 MarcoFalke: test: Document why connection is re-constructed on windows
< bitcoin-git>
bitcoin/master fae760f MarcoFalke: cirrus: Bump freebsd to 12.1
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18615: test: Avoid accessing free'd memory in validation_chainstatemanager_tests (master...2004-testNoAccessFreeMem) https://github.com/bitcoin/bitcoin/pull/18615
2020-04-12
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18555: wallet: Abort when assumption fails in debug mode (master...2004-walletAssumeAbortDebug) https://github.com/bitcoin/bitcoin/pull/18555
< bitcoin-git>
bitcoin/master c49971f MarcoFalke: Merge #18584: test: Check that the version message does not leak the local...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18584: test: Check that the version message does not leak the local address (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18584
< bitcoin-git>
bitcoin/master fa404f1 MarcoFalke: test: Check that the version message does not leak the local address of th...
< bitcoin-git>
[bitcoin] pierreN opened pull request #18606: test: check that bitcoin-cli autocomplete is in sync (master...feature-auto-cli) https://github.com/bitcoin/bitcoin/pull/18606
< bitcoin-git>
[bitcoin] fanquake opened pull request #18605: [WIP] build: Link time garbage collection (master...link_time_garbage_collection) https://github.com/bitcoin/bitcoin/pull/18605
< bitcoin-git>
[bitcoin] rebroad opened pull request #18604: Display command line usage to console without requiring X Windows (master...UsageToConsoleIfNotWin32) https://github.com/bitcoin/bitcoin/pull/18604
< jonasschnelli>
achow101: I passed a -upgrade to gbuild and even get a different shasum for bitcoin-0.20.0rc1-osx-unsigned.tar.gz
< bitcoin-git>
[bitcoin] fanquake closed pull request #17272: [POLICY] Make multiple OP_RETURNS in a single TX standard (master...allow-multi-op_return) https://github.com/bitcoin/bitcoin/pull/17272
< bitcoin-git>
[bitcoin] fanquake closed pull request #15268: doc: suggest using timeoutstopsec in systemd file during IBD (master...systemd-tweaks) https://github.com/bitcoin/bitcoin/pull/15268
< bitcoin-git>
bitcoin/master df953a4 Carl Dong: guix: Appease shellcheck.
< bitcoin-git>
[bitcoin] fanquake merged pull request #17595: guix: Enable building for `x86_64-w64-mingw32` target (master...2019-09-guix-staging-win-mingw-6.0.0) https://github.com/bitcoin/bitcoin/pull/17595