2020-05-12

< bitcoin-git> [bitcoin] fanquake merged pull request #18910: p2p: add MAX_FEELER_CONNECTIONS constant (master...add_max_feeler_connections) https://github.com/bitcoin/bitcoin/pull/18910
< bitcoin-git> bitcoin/master 8da1e43 fanquake: Merge #18910: p2p: add MAX_FEELER_CONNECTIONS constant
< bitcoin-git> bitcoin/master e3047ed fanquake: test: use p2p constants in denial of service tests
< bitcoin-git> bitcoin/master 25d8264 tryphe: p2p: add MAX_FEELER_CONNECTIONS constant
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e45fb7e0d276...8da1e43b63cb
< bitcoin-git> [bitcoin] practicalswift reopened pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18877: Serve cfcheckpt requests (master...2020-04-serve-getcfcheckpt) https://github.com/bitcoin/bitcoin/pull/18877
< bitcoin-git> bitcoin/master 2308385 Jim Posen: [test] Add test for cfcheckpt
< bitcoin-git> bitcoin/master 9ccaaba Jim Posen: [init] Add -peerblockfilters option
< bitcoin-git> bitcoin/master f9e00bb Jim Posen: [net processing] Message handling for getcfcheckpt.
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4fa31570144e...e45fb7e0d276
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18929: ci: Pass down LD_LIBRARY_PATH and MAKEJOBS to fuzz test_runner (master...2005-fuzzMakejobs) https://github.com/bitcoin/bitcoin/pull/18929
< bitcoin-git> bitcoin/master cbd6611 Russell Yanofsky: Set LD_LIBRARY_PATH consistently in travis tests
< bitcoin-git> bitcoin/master fa35c34 MarcoFalke: Remove unused ci configs that have been moved elsewhere
< bitcoin-git> bitcoin/master 3333cb9 MarcoFalke: fuzz: Pass down MAKEJOBS to test_runner
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0f2fa599aee0...4fa31570144e
< bitcoin-git> [bitcoin] fanquake merged pull request #18931: net: use CMessageHeader::HEADER_SIZE, add missing include (master...netcpp-use-CMessageHeader_HEADER_SIZE) https://github.com/bitcoin/bitcoin/pull/18931
< bitcoin-git> bitcoin/master 0f2fa59 fanquake: Merge #18931: net: use CMessageHeader::HEADER_SIZE, add missing include
< bitcoin-git> bitcoin/master 83da576 Jon Atack: net: use CMessageHeader::HEADER_SIZE, add missing include
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad1b7b18177a...0f2fa599aee0
< bitcoin-git> [bitcoin] fanquake merged pull request #18957: Add a link from ZMQ doc to ZMQ example in contrib/ (master...zmq-doc-link) https://github.com/bitcoin/bitcoin/pull/18957
< bitcoin-git> bitcoin/master ad1b7b1 fanquake: Merge #18957: Add a link from ZMQ doc to ZMQ example in contrib/
< bitcoin-git> bitcoin/master d97fac4 Damian Mee: Add a link from ZMQ doc to ZMQ example in contrib/
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/49d237ce3230...ad1b7b18177a
< bitcoin-git> [bitcoin] fanquake merged pull request #18928: build: don't pass -w when building for Windows (master...dont_try_suppress_all_warnings_win) https://github.com/bitcoin/bitcoin/pull/18928
< bitcoin-git> bitcoin/master 49d237c fanquake: Merge #18928: build: don't pass -w when building for Windows
< bitcoin-git> bitcoin/master 89fea68 fanquake: build: don't pass -w when building for Windows
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7a5767423f37...49d237ce3230
< bitcoin-git> [bitcoin] meeDamian opened pull request #18957: Add a link from ZMQ doc to ZMQ example in contrib/ (master...zmq-doc-link) https://github.com/bitcoin/bitcoin/pull/18957
< bitcoin-git> [bitcoin] fanquake opened pull request #18956: build: enforce minumim required Windows version (7) (master...window_enforce_runtime_version) https://github.com/bitcoin/bitcoin/pull/18956
< elichai2> jonatack: https://github.com/bitcoin/bitcoin/pull/18949#issuecomment-626901015 that's the main reason why I suggested this will be a thing anyone can add themselves, I don't think we have good metrics to choose reviewers ourselves
< bitcoin-git> [bitcoin] practicalswift closed pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
< bitcoin-git> [bitcoin] practicalswift closed pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git> [bitcoin] practicalswift closed pull request #18432: util: Make our stringstream usage locale independent (master...cpp-locale) https://github.com/bitcoin/bitcoin/pull/18432
< bitcoin-git> [bitcoin] andrewtoth reopened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< bitcoin-git> [bitcoin] jnewbery closed pull request #18955: net processing: requeue transaction GETDATA requests more frequently (master...2020-05-requeue-txrequest) https://github.com/bitcoin/bitcoin/pull/18955
< bitcoin-git> [bitcoin] fanquake merged pull request #18808: [net processing] Drop unknown types in getdata (master...2020-04-getdata) https://github.com/bitcoin/bitcoin/pull/18808
< bitcoin-git> bitcoin/master 2f03255 Amiti Uttarwar: [test] test that an invalid GETDATA doesn't prevent processing of future m...
< bitcoin-git> bitcoin/master e257cf7 Amiti Uttarwar: [net processing] ignore unknown INV types in GETDATA messages
< bitcoin-git> bitcoin/master 047ceac Amiti Uttarwar: [net processing] ignore tx GETDATA from blocks-only peers
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/eb2ffbb7c134...7a5767423f37
< gribble> https://github.com/bitcoin/bitcoin/issues/18700 | Fix locking on WSL using flock instead of fcntl by meshcollider · Pull Request #18700 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #18955: net processing: requeue transaction GETDATA requests more frequently (master...2020-05-requeue-txrequest) https://github.com/bitcoin/bitcoin/pull/18955

2020-05-11

< bitcoin-git> [bitcoin] andrewtoth closed pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< bitcoin-git> [bitcoin] fametrano opened pull request #18952: avoided os-dependant path (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18952
< amiti> I’m learning a lot and I appreciate your patience with me along the way. Its an honor to work with you all on bitcoin core <3
< amiti> I feel deeply grateful to get to work on bitcoin core on a daily basis. I 100% do not think I would be here if it weren’t for the many of you who have believed in me & taught me so much, even when I doubt myself. I’ve found the bitcoin core community to be welcoming & supportive, and I wish to share that with others who feel intimidated but interested
< reardencode> nope, this countdown lies: https://www.bitcoinsensus.com/bitcoin-halving-countdown/
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18914: refactor: Apply override specifier consistently (master...200508-override) https://github.com/bitcoin/bitcoin/pull/18914
< bitcoin-git> bitcoin/master d044e0e Hennadii Stepanov: refactor: Remove override for final overriders
< bitcoin-git> bitcoin/master eb2ffbb MarcoFalke: Merge #18914: refactor: Apply override specifier consistently
< bitcoin-git> bitcoin/master 1551cea Hennadii Stepanov: refactor: Use override for non-final overriders
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f71a3a882974...eb2ffbb7c134
< MarcoFalke> [11:37] [435] MarcoFalke_2 MarcoFalke #bitcoin-core-dev Cannot change nickname while banned/quieted on channel
< bitcoin-git> [bitcoin] adamjonas opened pull request #18949: doc: Add CODEOWNERS file to automatically nominate PR reviewers (master...2020-5-add-codeowners) https://github.com/bitcoin/bitcoin/pull/18949
< bitcoin-git> [bitcoin] hebasto closed pull request #18883: qt: Fix OpenWalletActivity::open() (master...200505-fix-win) https://github.com/bitcoin/bitcoin/pull/18883
< bitcoin-git> [bitcoin] hebasto opened pull request #18948: qt: Do not call setParent() for WalletModel instances (master...200511-qt-assert) https://github.com/bitcoin/bitcoin/pull/18948
< wumpus> thanks for weighing in; I think having contributed *something* is good before starting to review, unless you can somehow start reviewing at a deep technical level without having written any code for bitcoin core (e.g. contributor to a similar or adjacent project), but that's rare
< wumpus> what i tend to do is click the "0.20.0" next to a PR, though that ends up here (both issues and PRs view): https://github.com/bitcoin/bitcoin/milestone/42
< provoostenator> It's a pain to navigate to a milestone in Github, so I'll just spam this link, also a reminder to self: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.20.0
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18939: doc: add c++17-enable flag to fuzzing instructions (master...202005_fuzz_doc) https://github.com/bitcoin/bitcoin/pull/18939
< bitcoin-git> bitcoin/master f71a3a8 MarcoFalke: Merge #18939: doc: add c++17-enable flag to fuzzing instructions
< bitcoin-git> bitcoin/master 872aa25 Martin Zumsande: doc: add c++17-enable to fuzzing instructions
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec4d27fa8bdc...f71a3a882974
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
< bitcoin-git> [bitcoin] laanwj opened pull request #18945: build: Ensure source tarball has leading directory name (0.20...2020_11_0.20_tarball_prefix) https://github.com/bitcoin/bitcoin/pull/18945
< bitcoin-git> [bitcoin] laanwj merged pull request #18748: [0.20] rc2 Backports (0.20...0_20_rc2_backports) https://github.com/bitcoin/bitcoin/pull/18748
< wumpus> I very much understand how stressful it is to do PRs to bitcoin core in the first place, and this was probably the last straw for him
< bitcoin-git> [bitcoin] fanquake opened pull request #18942: doc: Increase minimum required GCC to 5.1 (master...gcc_5_1_for_codecvt) https://github.com/bitcoin/bitcoin/pull/18942
< bitcoin-git> [bitcoin] fanquake merged pull request #18216: test, build: Enable -Werror=sign-compare (master...2020-02-sign-compare) https://github.com/bitcoin/bitcoin/pull/18216
< bitcoin-git> bitcoin/master 6853727 Ben Woosley: build: Enable -Werror=sign-compare
< bitcoin-git> bitcoin/master eac6a30 Ben Woosley: refactor: Rework asmap Interpret to avoid ptrdiff_t
< bitcoin-git> bitcoin/master df37377 Ben Woosley: test: Fix outstanding -Wsign-compare errors
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/88d8b4e182bf...ec4d27fa8bdc
< bitcoin-git> [bitcoin] andrewtoth opened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< bitcoin-git> [bitcoin] andrewtoth closed pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
< bitcoin-git> [bitcoin] theStack opened pull request #18940: miner: fix off-by-ones in BlockAssembler::TestPackage (master...20200511-miner-fix-off-by-one-in-test-package) https://github.com/bitcoin/bitcoin/pull/18940

2020-05-10

< bitcoin-git> [bitcoin] mzumsande opened pull request #18939: doc: add c++17-enable flag to fuzzing instructions (master...202005_fuzz_doc) https://github.com/bitcoin/bitcoin/pull/18939
< gribble> https://github.com/bitcoin/bitcoin/issues/18930 | test: Remove sync_blocks global · Issue #18930 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] brakmic closed pull request #18830: rpc: add user field to getrpcinfo's json (master...getrpcinfo) https://github.com/bitcoin/bitcoin/pull/18830
< bitcoin-git> [bitcoin] brakmic closed pull request #18935: test: add more assert_* methods (master...new-asserts-for-functional-testing) https://github.com/bitcoin/bitcoin/pull/18935
< bitcoin-git> [bitcoin] brakmic closed pull request #18932: test: move sync_* implementations to framework member functions (master...move-sync-blocks-to-framework) https://github.com/bitcoin/bitcoin/pull/18932
< bitcoin-git> [bitcoin] brakmic closed pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871
< bitcoin-git> [bitcoin] brakmic closed pull request #18827: rpc: added getrpcwhitelist method (master...getrpcwhitelist) https://github.com/bitcoin/bitcoin/pull/18827
< bitcoin-git> [bitcoin] brakmic closed pull request #18611: cli: show default values in config args log (master...compare-params) https://github.com/bitcoin/bitcoin/pull/18611
< bitcoin-git> [bitcoin] brakmic closed pull request #18592: rpc: replace raw pointers with shared_ptrs (master...rpcwallet-replace-pointers) https://github.com/bitcoin/bitcoin/pull/18592
< bitcoin-git> [bitcoin] brakmic closed pull request #18570: rpc: return block hash & height in getbalances, gettransaction & getwalletinfo JSONs (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/18570
< bitcoin-git> [bitcoin] brakmic closed pull request #17623: rpc: add extensive file checks for dumptxoutset and dumpwallet (master...checks-for-dump-functions) https://github.com/bitcoin/bitcoin/pull/17623
< bitcoin-git> [bitcoin] brakmic closed pull request #17732: test: check for valgrind presence and set appropriate exit flags (master...valgrind-detection) https://github.com/bitcoin/bitcoin/pull/17732
< bitcoin-git> [bitcoin] brakmic closed pull request #17700: cli: add -generate option (master...resurrect-generate-method) https://github.com/bitcoin/bitcoin/pull/17700
< bitcoin-git> [bitcoin] brakmic closed pull request #17551: test: added test for RPCConvertNamedValues in rpc_tests (master...expanding-test-coverage) https://github.com/bitcoin/bitcoin/pull/17551
< bitcoin-git> [bitcoin] practicalswift opened pull request #18938: tests: Fill fuzzing coverage gaps for functions in consensus/validation.h, primitives/block.h and util/translation.h (master...fuzzers-misc-5) https://github.com/bitcoin/bitcoin/pull/18938
< bitcoin-git> [bitcoin] theStack opened pull request #18937: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg (master...20200520-refactor-replace-command-by-msgtype-part-3) https://github.com/bitcoin/bitcoin/pull/18937
< luke-jr> phantomcircuit: bitcoin-wallet doesn't do blockchain stuff
< bitcoin-git> [bitcoin] andrewtoth opened pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
< bitcoin-git> [bitcoin] brakmic opened pull request #18935: test: add more assert_* methods (master...new-asserts-for-functional-testing) https://github.com/bitcoin/bitcoin/pull/18935
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18933: rpc: Add submit option to generateblock (master...2004-rpcBlock) https://github.com/bitcoin/bitcoin/pull/18933
< bitcoin-git> [bitcoin] brakmic opened pull request #18932: test: move sync_blocks implementation to framework member function (master...move-sync-blocks-to-framework) https://github.com/bitcoin/bitcoin/pull/18932
< bitcoin-git> [bitcoin] jonatack opened pull request #18931: net: use CMessageHeader::HEADER_SIZE, add missing include (master...netcpp-use-CMessageHeader_HEADER_SIZE) https://github.com/bitcoin/bitcoin/pull/18931
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18929: ci: Pass down MAKEJOBS to fuzz test_runner (master...2005-fuzzMakejobs) https://github.com/bitcoin/bitcoin/pull/18929
< bitcoin-git> [bitcoin] fanquake opened pull request #18928: build: don't pass -w when building for Windows (master...dont_try_suppress_all_warnings_win) https://github.com/bitcoin/bitcoin/pull/18928
< bitcoin-git> [bitcoin] hebasto opened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927

2020-05-09

< bitcoin-git> [bitcoin] glowang opened pull request #18926: Pass ArgsManager into functions that register args with AddArg (master...replace_global_gArgs_with_local_argsman) https://github.com/bitcoin/bitcoin/pull/18926
< bitcoin-git> [bitcoin] naumenkogs opened pull request #18925: Add extra thread for scheduler, move TorControl and OpenAddedConnections to scheduler (master...2020_05_extra_scheduler_thread) https://github.com/bitcoin/bitcoin/pull/18925
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18923: wallet: Never schedule MaybeCompactWalletDB when -flushwallet is off (master...2005-walletNoFlush) https://github.com/bitcoin/bitcoin/pull/18923
< bitcoin-git> [bitcoin] hebasto opened pull request #18922: gui: Do not translate InitWarning messages in debug.log (master...200509-initwarn) https://github.com/bitcoin/bitcoin/pull/18922
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18901: fuzz: use std::optional for sep_pos_opt variable (master...warning-in-fuzz-tests) https://github.com/bitcoin/bitcoin/pull/18901
< bitcoin-git> bitcoin/master 88d8b4e MarcoFalke: Merge #18901: fuzz: use std::optional for sep_pos_opt variable
< bitcoin-git> bitcoin/master 420fa07 Harris: fuzz: use std::optional for sep_pos variable
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/376294cde6b1...88d8b4e182bf
< bitcoin-git> [bitcoin] fanquake opened pull request #18921: build: add stack-clash and control-flow protection options to hardening flags (master...add_cfi_to_hardening) https://github.com/bitcoin/bitcoin/pull/18921
< bitcoin-git> [bitcoin] practicalswift opened pull request #18920: doc: Document how to analyze Bitcoin Core using clang-tidy (master...static-analysis-clang-tidy) https://github.com/bitcoin/bitcoin/pull/18920

2020-05-08

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18866: test: Fix verack race to avoid intermittent test failures (master...2005-qaVerackRace) https://github.com/bitcoin/bitcoin/pull/18866
< bitcoin-git> bitcoin/master 376294c MarcoFalke: Merge #18866: test: Fix verack race to avoid intermittent test failures
< bitcoin-git> bitcoin/master fae153b MarcoFalke: test: Fix verack race to avoid intermittent test failures
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b55866969e24...376294cde6b1
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18919: test: Add gettransaction test for "coin-join" tx (master...2005-testCoinJoinGetTx) https://github.com/bitcoin/bitcoin/pull/18919
< bitcoin-git> [bitcoin] achow101 opened pull request #18918: wallet: Move salvagewallet into wallettool (master...wallettool-salvagewallet) https://github.com/bitcoin/bitcoin/pull/18918
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18917: fuzz: fix vector size problem in system fuzzer (master...fix-system-fuzzer) https://github.com/bitcoin/bitcoin/pull/18917
< bitcoin-git> bitcoin/master b558669 MarcoFalke: Merge #18917: fuzz: fix vector size problem in system fuzzer
< bitcoin-git> bitcoin/master 095bc9a Harris: fuzz: fix vector size problem in system fuzzer
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5b24f6084ede...b55866969e24
< sipa> when using the snap package, is it expected that the binaries are called bitcoin-core.daemon bitcoin-core.cli ... instead of the usual ones?
< gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub
< jnewbery> Does anyone know what this failure in appveyor means: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/32747418 ? I tried rerunning and it's happened twice in a row
< bitcoin-git> [bitcoin] brakmic closed pull request #18908: util: raise a deadly signal in system.cpp fuzzer (master...fuzz-ub-argsmanager) https://github.com/bitcoin/bitcoin/pull/18908
< gribble> https://github.com/bitcoin/bitcoin/issues/18594 | cli: display multiwallet balances in -getinfo by jonatack · Pull Request #18594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16549 | UI external signer support (e.g. hardware wallet) by Sjors · Pull Request #16549 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17681 | wallet: Keep inactive seeds after sethdseed and derive keys from them as needed by achow101 · Pull Request #17681 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16946 | wallet: include a checksum of encrypted private keys by achow101 · Pull Request #16946 · bitcoin/bitcoin · GitHub
< jnewbery> My opinion on forward/backward wallet compatibility is that we should support 2 versions in either direction, and make sure that we have 100% test coverage of all features. The fact that we have code like https://github.com/bitcoin/bitcoin/blob/5b24f6084ede92d0f493ff416b4726245140b2c1/src/wallet/walletdb.cpp#L284 which is supposed to support some wallet quirk in 2012 that isn't tested and
< gribble> https://github.com/bitcoin/bitcoin/issues/1889 | let user select wallet file with -wallet=foo.dat by tcatm · Pull Request #1889 · bitcoin/bitcoin · GitHub
< ryanofsky> jnewbery, it means they started bitcoin at some point with a -wallet=something command line argument, but maybe that is advanced enough
< gwillen> luke-jr: your point is that sqlite has not changed its format in 16 years, since before bitcoin was invented?
< jnewbery> luke-jr: is your opposition to this because it makes it more difficult to maintain bitcoin knots if the dependencies in bitcoin core change?
< provoostenator> jnewbery: we do have tests for it, as of recently: https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_backwards_compatibility.py#L221
< provoostenator> luke-jr: is it illegal in places where Bitcoin is legal?
< gribble> https://github.com/bitcoin/bitcoin/issues/18916 | Sqlite wallet storage · Issue #18916 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] brakmic opened pull request #18917: fuzz: fix vector size problem in system fuzzer (master...fix-system-fuzzer) https://github.com/bitcoin/bitcoin/pull/18917
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16224: gui: Bilingual GUI error messages (master...20190617-bilingual-errors) https://github.com/bitcoin/bitcoin/pull/16224
< bitcoin-git> bitcoin/master 7e923d4 Hennadii Stepanov: Make InitError bilingual
< bitcoin-git> bitcoin/master 23b9fa2 Hennadii Stepanov: gui: Add detailed text to BitcoinGUI::message
< bitcoin-git> bitcoin/master 917ca93 Hennadii Stepanov: Make ThreadSafe{MessageBox|Question} bilingual
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/3930014abcdd...5b24f6084ede
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18864: Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 (master...2020/05/backwards_compat) https://github.com/bitcoin/bitcoin/pull/18864
< bitcoin-git> bitcoin/master d135c29 Sjors Provoost: [ci] make list of previous releases to download a setting
< bitcoin-git> bitcoin/master 89a28e0 Sjors Provoost: [test] add v0.16.3 backwards compatibility test
< bitcoin-git> bitcoin/master 9c246b8 Sjors Provoost: [test] backwards compatibility: bump v0.19.0.1 to v0.19.1
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f54753293fe7...3930014abcdd
< belcher> dfmb_ thats a common question, have a read of this https://blog.lopp.net/who-controls-bitcoin-core-/
< dfmb_> Hi im a noob, just wondering who decides which updates to deploy on bitcoin code? Letś say I make a pull request on the bitcoin github who decides that udpate is valid or it isn't ?
< bitcoin-git> [bitcoin] hebasto opened pull request #18914: refactor: Apply override specifier consistently (master...200508-override) https://github.com/bitcoin/bitcoin/pull/18914
< bitcoin-git> [bitcoin] practicalswift opened pull request #18912: ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to catch memory errors (master...fuzzers-under-valgrind) https://github.com/bitcoin/bitcoin/pull/18912
< bitcoin-git> [bitcoin] fanquake opened pull request #18910: p2p: add MAX_FEELER_CONNECTIONS constant (master...add_max_feeler_connections) https://github.com/bitcoin/bitcoin/pull/18910

2020-05-07

< bitcoin-git> [bitcoin] fanquake closed pull request #16003: init: Fixes for file descriptor accounting (master...fd-limits-3) https://github.com/bitcoin/bitcoin/pull/16003
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15845: wallet: Fast rescan with BIP157 block filters (master...1904-walletFastRescan) https://github.com/bitcoin/bitcoin/pull/15845
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18352: WIP NOMERGE [bench] gitian builds for OP_IF bench (master...2003-benchGitianOPIF) https://github.com/bitcoin/bitcoin/pull/18352
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18385: WIP contrib: Add keys.openpgp.org as backup server (master...2003-contribPGPBackupServer) https://github.com/bitcoin/bitcoin/pull/18385
< * luke-jr> still hasn't heard a use case for merging BIP157 at all, aside from harming Bitcoin
< sipa> luke-jr: my belief is that bitcoin offers a choice for financial autonomy, and choice is a good thing - not everyone will choose to make maximal use of that, but everyone who wants to should be able to
< luke-jr> at least, that as long as the situation is not good, anything that makes light clients better, is harmful to Bitcoin, and shouldn't be merged
< luke-jr> sipa: if 99.99% don't have their own full node, Bitcoin has failed
< luke-jr> Bitcoin's security model depends on at least most people using their own full ndoe
< jnewbery> not everyone wants to use bitcoin in the same way as you, and that's ok
< gribble> https://github.com/bitcoin/bitcoin/issues/18691 | test: add wait_for_cookie_credentials() to framework for rpcwait tests by jonatack · Pull Request #18691 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18681 | donotmerge: build: Enable thread-local with glibc compat by laanwj · Pull Request #18681 · bitcoin/bitcoin · GitHub
< jonatack> jonasschnelli: yes, i always look at bitcoinbuilds for first feedback, then much later, travis on my own github branch and on bitcoin/bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/18488 | Support for non-immediate periodic tasks with variable runtime · Issue #18488 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr opened pull request #18909: [0.20] Fix release tarball (0.20...fix_release_tarball-0.20) https://github.com/bitcoin/bitcoin/pull/18909
< gribble> https://github.com/bitcoin/bitcoin/issues/18421 | Periodically update DNS caches for better privacy of non-reachable nodes by naumenkogs · Pull Request #18421 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16946 | wallet: include a checksum of encrypted private keys by achow101 · Pull Request #16946 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17994 | validation: flush undo files after last block write by kallewoof · Pull Request #17994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17037 | Testschains: Many regtests with different genesis and default datadir by jtimon · Pull Request #17037 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18877 | Serve cfcheckpt requests by jnewbery · Pull Request #18877 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 4 blockers, 1 bugfix, 5 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/18421 | Periodically update DNS caches for better privacy of non-reachable nodes by naumenkogs · Pull Request #18421 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] brakmic opened pull request #18908: util: fix UB error in ArgsManager::ParseParameters (master...fuzz-ub-argsmanager) https://github.com/bitcoin/bitcoin/pull/18908
< gribble> https://github.com/bitcoin/bitcoin/issues/18894 | gui: Fix manual coin control with multiple wallets loaded by promag · Pull Request #18894 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18578 | gui: Fix leak in CoinControlDialog::updateView by promag · Pull Request #18578 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] achow101 opened pull request #18907: walletdb: Don't remove database transaction logs and instead error (master...dont-retry-bdbenv) https://github.com/bitcoin/bitcoin/pull/18907
< hebasto> it seems the simplest solution along with your commit https://github.com/bitcoin/bitcoin/pull/18818/commits/b9054bce073620f9bf8ff99cde23056e93012b53
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18905: travis: Remove s390x (master...2005-removeTravis) https://github.com/bitcoin/bitcoin/pull/18905
< bitcoin-git> bitcoin/master 8c705ff MarcoFalke: travis: Remove s390x
< bitcoin-git> bitcoin/master f547532 MarcoFalke: Merge #18905: travis: Remove s390x
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/56611b0e2405...f54753293fe7
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18905: travis: Remove s390x (master...2005-removeTravis) https://github.com/bitcoin/bitcoin/pull/18905
< gribble> https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #18743: depends: Add --sysroot option to mac os native compile flags (master...pr/sysroot) https://github.com/bitcoin/bitcoin/pull/18743
< bitcoin-git> bitcoin/master 56611b0 fanquake: Merge #18743: depends: Add --sysroot option to mac os native compile flags...
< bitcoin-git> bitcoin/master 1e94a2b Russell Yanofsky: depends: Add --sysroot option to mac os native compile flags
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1cd2b5a97f4...56611b0e2405
< gribble> https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18899: travis: Remove valgrind (master...2005-RemoveTravis) https://github.com/bitcoin/bitcoin/pull/18899
< bitcoin-git> bitcoin/master c1cd2b5 MarcoFalke: Merge #18899: travis: Remove valgrind
< bitcoin-git> bitcoin/master fa082d0 MarcoFalke: travis: Remove valgrind
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3b1e289248dc...c1cd2b5a97f4
< bitcoin-git> [bitcoin] fanquake merged pull request #18535: build: remove -Qunused-arguments workaround for clang + ccache (master...dont_quash_unused_driver_arguments) https://github.com/bitcoin/bitcoin/pull/18535
< bitcoin-git> bitcoin/master 3b1e289 fanquake: Merge #18535: build: remove -Qunused-arguments workaround for clang + ccac...
< bitcoin-git> bitcoin/master a029805 fanquake: build: remove -Qunused-arguments workaround for clang + ccache
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7bcc42b4035b...3b1e289248dc
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14046: net: Refactor message parsing (CNetMessage), adds flexibility (master...2018/08/bip151_pre_refactor) https://github.com/bitcoin/bitcoin/pull/14046
< bitcoin-git> [bitcoin] bvbfan opened pull request #18904: Don't call lsn_reset in periodic flush (master...lsn_reset_fix) https://github.com/bitcoin/bitcoin/pull/18904
< bitcoin-git> [bitcoin] fanquake opened pull request #18903: test: fix TEST_PREVIOUS_RELEASES check (master...getenv_defaults_to_None) https://github.com/bitcoin/bitcoin/pull/18903
< bitcoin-git> [bitcoin] luke-jr opened pull request #18902: Bugfix: Only use git for build info if the repository is actually the right one (master...fix_gitdir_again) https://github.com/bitcoin/bitcoin/pull/18902

2020-05-06

< bitcoin-git> [bitcoin] brakmic opened pull request #18901: fuzz: initialize variable sep_pos to get rid of warning (master...warning-in-fuzz-tests) https://github.com/bitcoin/bitcoin/pull/18901
< gribble> https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18556 | build: Drop make dist in gitian builds by hebasto · Pull Request #18556 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18899: travis: Remove valgrind (master...2005-RemoveTravis) https://github.com/bitcoin/bitcoin/pull/18899
< gribble> https://github.com/bitcoin/bitcoin/issues/17167 | Allow whitelisting outgoing connections by luke-jr · Pull Request #17167 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10594 | Bugfix: net: Apply whitelisting criteria to outgoing connections by luke-jr · Pull Request #10594 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jtimon closed pull request #17032: Tests: Chainparams: Make regtest almost fully customizable (master...b20-customizable-regtest) https://github.com/bitcoin/bitcoin/pull/17032
< bitcoin-git> [bitcoin] jtimon closed pull request #17037: Testschains: Many regtests with different genesis and default datadir (master...b20-n-chains) https://github.com/bitcoin/bitcoin/pull/17037
< bitcoin-git> [bitcoin] jtimon closed pull request #16770: Chainparams: Rename IsTestChain() to AllowAcceptNonstd() (master...b19-chainparams-allownonstd) https://github.com/bitcoin/bitcoin/pull/16770
< bitcoin-git> [bitcoin] laanwj merged pull request #18873: test: Fix intermittent sync_blocks failures (master...2005-testSyncBlocks) https://github.com/bitcoin/bitcoin/pull/18873
< bitcoin-git> bitcoin/master 7bcc42b Wladimir J. van der Laan: Merge #18873: test: Fix intermittent sync_blocks failures
< bitcoin-git> bitcoin/master fa3f9a0 MarcoFalke: test: Fix intermittent sync_blocks failures
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c6b15ec0ee46...7bcc42b4035b
< gribble> https://github.com/bitcoin/bitcoin/issues/18741 | guix: Make source tarball using git-archive by dongcarl · Pull Request #18741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18742 | miner: Avoid stack-use-after-return in validationinterface by MarcoFalke · Pull Request #18742 · bitcoin/bitcoin · GitHub
< MarcoFalke> Congrats cfields on a commit to Bitcoin Core ;)
< bitcoin-git> [bitcoin] laanwj merged pull request #17874: build: make linker checks more robust (master...make_linker_checks_more_robust) https://github.com/bitcoin/bitcoin/pull/17874
< bitcoin-git> bitcoin/master c6b15ec Wladimir J. van der Laan: Merge #17874: build: make linker checks more robust
< bitcoin-git> bitcoin/master 03da4c7 Cory Fields: build: make linker checks more robust
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f763283b65ad...c6b15ec0ee46
< bitcoin-git> [bitcoin] laanwj merged pull request #18512: Improve asmap checks and add sanity check (master...202003_asmap_checks) https://github.com/bitcoin/bitcoin/pull/18512
< bitcoin-git> bitcoin/master 5feefbe Pieter Wuille: Improve asmap Interpret checks and document failures
< bitcoin-git> bitcoin/master 2b3dbfa Pieter Wuille: Deal with decoding failures explicitly in asmap Interpret
< bitcoin-git> bitcoin/master 1479007 Pieter Wuille: Introduce Instruction enum in asmap
< bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/88b2652fadf6...f763283b65ad
< bitcoin-git> [bitcoin] hebasto opened pull request #18898: gui: Drop HTML tags in exception messages (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
< fanquake> We need to look through https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+label%3A%22Needs+backport+%280.20%29%22 as well, a few more PRs that have been tagged for 0.20.0.
< gribble> https://github.com/bitcoin/bitcoin/issues/18589 | Fix naming of macOS SDK and clarify version by achow101 · Pull Request #18589 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18598 | gitian: Add missing automake package to gitian-win-signer.yml by achow101 · Pull Request #18598 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18553 | Avoid non-trivial global constants in SHA-NI code by sipa · Pull Request #18553 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18702 | build: fix ASLR for bitcoin-cli on Windows by fanquake · Pull Request #18702 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18748 | [0.20] rc2 Backports by fanquake · Pull Request #18748 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
< bitcoin-git> bitcoin/master 88b2652 Wladimir J. van der Laan: Merge #18853: wallet: Fix typo in assert that is compile-time true
< bitcoin-git> bitcoin/master fa47cf9 MarcoFalke: wallet: Fix typo in assert that is compile-time true
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6621be53517d...88b2652fadf6
< bitcoin-git> [bitcoin] hebasto opened pull request #18897: gui: Handle NonFatalCheckError instead of crash (master...200506-slot-ex) https://github.com/bitcoin/bitcoin/pull/18897
< bitcoin-git> [bitcoin] laanwj merged pull request #18843: build: warn on potentially uninitialized reads (master...enable_Wconditional-uninitialized) https://github.com/bitcoin/bitcoin/pull/18843
< bitcoin-git> bitcoin/master 6621be5 Wladimir J. van der Laan: Merge #18843: build: warn on potentially uninitialized reads
< bitcoin-git> bitcoin/master 71f183a Vasil Dimov: build: warn on potentially uninitialized reads
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd3310bbb815...6621be53517d
< bitcoin-git> [bitcoin] laanwj merged pull request #18854: doc: Fix typo in Coin doxygen comment (master...2005-docCoins) https://github.com/bitcoin/bitcoin/pull/18854
< bitcoin-git> bitcoin/master dd3310b Wladimir J. van der Laan: Merge #18854: doc: Fix typo in Coin doxygen comment
< bitcoin-git> bitcoin/master fa09110 MarcoFalke: doc: Fix typo in Coin doxygen comment
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/551dc7f66466...dd3310bbb815
< gribble> https://github.com/bitcoin/bitcoin/issues/18835 | debug assert in walletcontroller.cpp in func getOrCreateWallet, if thread is not gui · Issue #18835 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18883 | qt: Fix OpenWalletActivity::open() by hebasto · Pull Request #18883 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18335 | bitcoin-cli: print useful error if bitcoind rpc work queue exceeded by LarryRuane · Pull Request #18335 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake merged pull request #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix (master...20200428-net-clarify-divide-by-zero-fix) https://github.com/bitcoin/bitcoin/pull/18806
< bitcoin-git> bitcoin/master 551dc7f fanquake: Merge #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify ...
< bitcoin-git> bitcoin/master 1ad8ea2 Sebastian Falbesoner: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d96fdc2a396f...551dc7f66466
< bitcoin-git> [bitcoin] hebasto opened pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896
< bitcoin-git> [bitcoin] fanquake merged pull request #18741: guix: Make source tarball using git-archive (master...2020-04-sync-guix) https://github.com/bitcoin/bitcoin/pull/18741
< bitcoin-git> bitcoin/master 1470160 Carl Dong: guix: Expose GIT_COMMON_DIR in container as readonly
< bitcoin-git> bitcoin/master f5a6ac4 Carl Dong: guix: Make source tarball using git-archive
< bitcoin-git> bitcoin/master 395c113 Carl Dong: gitian: Limit sourced script to just assignments
< bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/60091d20f9bb...d96fdc2a396f
< bitcoin-git> [bitcoin] gzhao408 opened pull request #18895: [wip] unbroadcast followups (master...unbroadcast-followup) https://github.com/bitcoin/bitcoin/pull/18895

2020-05-05

< bitcoin-git> [bitcoin] meshcollider merged pull request #9381: Remove CWalletTx merging logic from AddToWallet (master...pr/atw-nomerge) https://github.com/bitcoin/bitcoin/pull/9381
< bitcoin-git> bitcoin/master 65b9d8f Russell Yanofsky: Avoid copying CWalletTx in LoadToWallet
< bitcoin-git> bitcoin/master bd2fbc7 Russell Yanofsky: Get rid of unneeded CWalletTx::Init parameter
< bitcoin-git> bitcoin/master 2b9cba2 Russell Yanofsky: Remove CWalletTx merging logic from AddToWallet
< bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fbd522721cb8...60091d20f9bb
< bitcoin-git> [bitcoin] promag closed pull request #17457: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725) https://github.com/bitcoin/bitcoin/pull/17457
< bitcoin-git> [bitcoin] promag opened pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894
< gribble> https://github.com/bitcoin/bitcoin/issues/18870 | build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb by achow101 · Pull Request #18870 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] robot-visions opened pull request #18890: test: disconnect_nodes should warn if nodes were already disconnected (master...disconnect-nodes) https://github.com/bitcoin/bitcoin/pull/18890
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885
< bitcoin-git> bitcoin/master fbd5227 MarcoFalke: Merge #18885: contrib: Move optimize-pngs.py script to the maintainer repo...
< bitcoin-git> bitcoin/master fa13090 MarcoFalke: contrib: Remove optimize-pngs.py script, which lives in the maintainer rep...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52ce396b2a47...fbd522721cb8
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879
< bitcoin-git> bitcoin/master 52ce396 MarcoFalke: Merge #18879: valgrind: remove outdated suppressions
< bitcoin-git> bitcoin/master d7120f7 fanquake: valgrind : remove duplicate BCLog::Logger suppression
< bitcoin-git> bitcoin/master 708e3c7 fanquake: valgrind: remove rest_blockhash_by_height suppression
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ec79b5f86b22...52ce396b2a47
< bitcoin-git> [bitcoin] promag closed pull request #18246: wip: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246
< gribble> https://github.com/bitcoin/bitcoin/issues/18863 | refactor: Drop unused CScriptVisitor return type by promag · Pull Request #18863 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] vasild opened pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887