2019-11-09

< gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag . Pull Request #17135 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag . Pull Request #16348 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17427 | qt: Fix missing qRegisterMetaType for size_t by hebasto . Pull Request #17427 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag . Pull Request #16348 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #17427: qt: Fix missing qRegisterMetaType for size_t (master...20191109-fix-signal-argument-type) https://github.com/bitcoin/bitcoin/pull/17427
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17424: doc:Travis CI note on Build Timeouts (master...travis-note) https://github.com/bitcoin/bitcoin/pull/17424
< harding> wumpus: FYI, release PR for BitcoinCore.org: https://github.com/bitcoin-core/bitcoincore.org/pull/679

2019-11-08

< harding> emilengler: I don't have any data on BitcoinCore.org, but back when the binaries were exclusively hosted on Bitcoin.org, there was less than 1% as many downloads of SHA256SUMS.asc than there was of the binary files.
< wumpus> midnight: I don't know, I dont' think *that* is so bad with bitcoin core. I do have experiences like that with things like printer settings though, where the software tries to 'intelligently' guess what your're trying to do, correcting for some settings, so at some point you need to make second-order guesses so that the software will make the correct guess and eventually send the right value to the
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17423: ci: Make ci system read-only on the git work tree (master...1911-ciRo) https://github.com/bitcoin/bitcoin/pull/17423
< gribble> https://github.com/bitcoin/bitcoin/issues/1044 | Problems with command-line options silently ignored . Issue #1044 . bitcoin/bitcoin . GitHub
< wumpus> thanks for improving the horror that is bitcoin core option parsing a bit :)
< bitcoin-git> [bitcoin] laanwj merged pull request #15934: Merge settings one place instead of five places (master...pr/mergeset) https://github.com/bitcoin/bitcoin/pull/15934
< bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/adceca2ba56a...a7aec7ad9794
< bitcoin-git> bitcoin/master dc8e1e7 Russell Yanofsky: Clarify emptyIncludeConf logic
< bitcoin-git> bitcoin/master 5a84aa8 Russell Yanofsky: Rename includeconf variables for clarity
< bitcoin-git> bitcoin/master e2e37cf Russell Yanofsky: Remove includeconf nested scope
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e0aabe50cbb...adceca2ba56a
< bitcoin-git> bitcoin/master fec230e fanquake: doc: add historical 0.19.0 release notes
< bitcoin-git> bitcoin/master adceca2 Wladimir J. van der Laan: Merge #17422: doc: add historical 0.19.0 release notes
< bitcoin-git> [bitcoin] laanwj merged pull request #17422: doc: add historical 0.19.0 release notes (master...add_019_relnotes) https://github.com/bitcoin/bitcoin/pull/17422
< gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky . Pull Request #15934 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #17422: doc: add historical 0.19.0 release notes (master...add_019_relnotes) https://github.com/bitcoin/bitcoin/pull/17422
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8021392b825c...9e0aabe50cbb
< bitcoin-git> bitcoin/master fa56bcb MarcoFalke: ci: Run CI_WAIT only on travis
< bitcoin-git> bitcoin/master fa8a60b MarcoFalke: ci: Run non-cross-compile builds natively
< bitcoin-git> bitcoin/master faf757a MarcoFalke: ci: Guess the native host when not cross compiling
< bitcoin-git> [bitcoin] laanwj merged pull request #17367: ci: Run non-cross-compile builds natively (master...1911-ciNative) https://github.com/bitcoin/bitcoin/pull/17367
< bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0: https://github.com/bitcoin/bitcoin/compare/v0.19.0
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/84908668a0a8...42414bfd0547
< bitcoin-git> bitcoin/0.19 42414bf Wladimir J. van der Laan: build: set CLIENT_VERSION_RC to 0 pre-final
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/7358ae6d71cd...84908668a0a8
< bitcoin-git> bitcoin/0.19 2a15679 fanquake: doc: reintegrate release notes from wiki
< bitcoin-git> bitcoin/0.19 8bca3ce fanquake: doc: add macOS DMG opening note to release notes
< bitcoin-git> bitcoin/0.19 8490866 Wladimir J. van der Laan: Merge #17403: doc: reintegrate 0.19.0 release notes
< bitcoin-git> [bitcoin] laanwj merged pull request #17403: doc: reintegrate 0.19.0 release notes (0.19...reintegrate_relnotes_019) https://github.com/bitcoin/bitcoin/pull/17403
< gribble> https://github.com/bitcoin/bitcoin/issues/17373 | wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet by achow101 . Pull Request #17373 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16426 | Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard . Pull Request #16426 . bitcoin/bitcoin . GitHub
< jonatack> achow101: review beg for https://github.com/bitcoin/bitcoin/pull/17261 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors . Pull Request #16944 . bitcoin/bitcoin . GitHub
< jonatack> (yes it is indeed https://github.com/bitcoin/bitcoin/pull/12892 despite the PR name)
< gribble> https://github.com/bitcoin/bitcoin/issues/12892 | [wallet] [rpc] introduce label API for wallet by jnewbery . Pull Request #12892 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17283 | rpc: improve getaddressinfo test coverage, help, code docs by jonatack . Pull Request #17283 . bitcoin/bitcoin . GitHub
< jonatack> was added by jnewbery i believe? https://github.com/bitcoin/bitcoin/pull/12892
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< bitcoin-git> [bitcoin] sdaftuar closed pull request #17332: p2p: Proof-of-concept: Improve DoS-resistance to low-work headers chains (master...2019-10-no-checkpoints-cleanedup) https://github.com/bitcoin/bitcoin/pull/17332
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17420: travis: Rework CACHE_ERR_MSG (master...1911-docTravis) https://github.com/bitcoin/bitcoin/pull/17420
< bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17389: build: add background.tiff and .pngs to "make clean" (master...make-clean-tiff) https://github.com/bitcoin/bitcoin/pull/17389
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17418: Build: add REPO_SLUG to fix errors in forked builds (master...repo-slug) https://github.com/bitcoin/bitcoin/pull/17418
< gribble> https://github.com/bitcoin/bitcoin/issues/17416 | Appveyor improvement - adds check for all required vcpkg packages by sipsorcery . Pull Request #17416 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17412 | Add Boost::Process to AppVeyor dependencies by Sjors . Pull Request #17412 . bitcoin/bitcoin . GitHub
< michaelfolkson> For anybody who knows about policy language, Miniscript just posted this on Bitcoin StackExchange https://bitcoin.stackexchange.com/questions/91565/what-does-bitcoin-policy-language-offer-the-developer-that-miniscript-doesnt-w
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17418: Build: add REPO_SLUG to fix errors in forked builds (master...repo-slug) https://github.com/bitcoin/bitcoin/pull/17418
< bitcoin-git> [bitcoin] fanquake closed pull request #17412: Add Boost::Process to AppVeyor dependencies (master...2019/11/msvc_boost_process) https://github.com/bitcoin/bitcoin/pull/17412
< bitcoin-git> [bitcoin] fanquake opened pull request #17417: [0.19] cli: fix -getinfo output when compiled with no wallet (0.19...backport_17368_019) https://github.com/bitcoin/bitcoin/pull/17417
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a3b6f47cd75...8021392b825c
< bitcoin-git> bitcoin/master fad1de6 MarcoFalke: wallet: Remove unused boost::this_thread::interruption_point
< bitcoin-git> bitcoin/master 8021392 fanquake: Merge #17405: wallet: Remove unused boost::this_thread::interruption_point...
< bitcoin-git> [bitcoin] fanquake merged pull request #17405: wallet: Remove unused boost::this_thread::interruption_point (master...1911-walletNoBoost) https://github.com/bitcoin/bitcoin/pull/17405
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99ab3a72c5ff...4a3b6f47cd75
< bitcoin-git> bitcoin/master 01f45dd Joao Barbosa: wallet: Avoid recursive lock in CWallet::SetUsedDestinationState
< bitcoin-git> bitcoin/master 0b75a7f Joao Barbosa: wallet: Reuse existing batch in CWallet::SetUsedDestinationState
< bitcoin-git> bitcoin/master 4a3b6f4 fanquake: Merge #17354: wallet: Tidy CWallet::SetUsedDestinationState
< bitcoin-git> [bitcoin] fanquake merged pull request #17354: wallet: Tidy CWallet::SetUsedDestinationState (master...2019-11-setuseddestinationstate) https://github.com/bitcoin/bitcoin/pull/17354
< bitcoin-git> [bitcoin] sipsorcery opened pull request #17416: Appveyor improvement - adds check for all required vcpkg packages (master...check-missing-vcpkgs) https://github.com/bitcoin/bitcoin/pull/17416
< bitcoin-git> [bitcoin] meshcollider merged pull request #15931: Remove GetDepthInMainChain dependency on locked chain interface (master...2019-04-remove-external-locking) https://github.com/bitcoin/bitcoin/pull/15931
< bitcoin-git> [bitcoin] meshcollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/2fb6140d585f...99ab3a72c5ff
< bitcoin-git> bitcoin/master 10b4729 Antoine Riard: Pass block height in Chain::BlockConnected/Chain::BlockDisconnected
< bitcoin-git> bitcoin/master 5aacc3e Antoine Riard: Add m_last_block_processed_height field in CWallet
< bitcoin-git> bitcoin/master 9700fcb Antoine Riard: Replace CWalletTx::SetConf by Confirmation initialization list
< elichai2> wumpus: I actually don't completely on that. for a long time I didn't understood a thing about bitcoin's build system and/or code and I liked that it installed basically everything I could manage (I'm one of those freaks who likes the GUI :) )
< wumpus> BlueMatt: https://github.com/bitcoin/bitcoin/pull/15382#issuecomment-551451359 kind of reminds me what has bothing me about the rust stuff; I think the build system there also needs to focus on features, not "use rust or not", don't group them on programmings language/dependency; if someone wants to enable a feature that happens to be implemented in rust, request them to install a rust compiler :)
< wumpus> so yes maybe it's better to sort out the linters instead of moving around things in the tree, trying with "good first issue"... https://github.com/bitcoin/bitcoin/issues/17413
< bitcoin-git> [bitcoin] Sjors opened pull request #17412: Add Boost::Process to AppVeyor dependencies (master...2019/11/msvc_boost_process) https://github.com/bitcoin/bitcoin/pull/17412
< bitcoin-git> [bitcoin] laanwj opened pull request #17411: doc: Add some better examples for scripted diff (master...2019_11_scripted_diff_examples) https://github.com/bitcoin/bitcoin/pull/17411
< bitcoin-git> [bitcoin] laanwj opened pull request #17410: Rename `db` log category to `walletdb` (like `coindb`) (master...2019_11_rename_db_log_category) https://github.com/bitcoin/bitcoin/pull/17410
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17409: build: Avoid hardcoded libfaketime dir in gitian (master...1911-gitianArm64) https://github.com/bitcoin/bitcoin/pull/17409

2019-11-07

< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17408: Replace assert with ASSERT (master...1911-assertASSERT) https://github.com/bitcoin/bitcoin/pull/17408
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17408: Replace assert with ASSERT (master...1911-assertASSERT) https://github.com/bitcoin/bitcoin/pull/17408
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17407: Add MempoolInstance() to get the current mempool (master...1911-txPoolOptional) https://github.com/bitcoin/bitcoin/pull/17407
< bitcoin-git> [bitcoin] BlockMechanic opened pull request #17406: Fix http server (master...fix-http-server) https://github.com/bitcoin/bitcoin/pull/17406
< bitcoin-git> [bitcoin] BlockMechanic closed pull request #17406: Fix http server (master...fix-http-server) https://github.com/bitcoin/bitcoin/pull/17406
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17405: wallet: Remove unused boost::this_thread::interruption_point (master...1911-walletNoBoost) https://github.com/bitcoin/bitcoin/pull/17405
< bitcoin-git> [bitcoin] fanquake merged pull request #17404: Remove redundant class file include from test_bitcoin msvc project (master...msvc_test) https://github.com/bitcoin/bitcoin/pull/17404
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/270616228bc9...2fb6140d585f
< bitcoin-git> bitcoin/master b80f7db Aaron Clauson: Remove redundant class file includes from test_bitcoin project.
< bitcoin-git> bitcoin/master 2fb6140 fanquake: Merge #17404: Remove redundant class file include from test_bitcoin msvc p...
< gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard . Pull Request #15931 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag . Pull Request #13339 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] sipsorcery opened pull request #17404: Remove redundant class file include from test_bitcoin msvc project (master...msvc_test) https://github.com/bitcoin/bitcoin/pull/17404
< gribble> https://github.com/bitcoin/bitcoin/issues/15847 | Feedback for GitHub CEO . Issue #15847 . bitcoin/bitcoin . GitHub
< wumpus> I'm not sure having rustc in your path should change anything automatically to bitcoin configuration
< BlueMatt> promag: maybe zmq is a better example, at least with qt you just totally miss the bitcoin-qt binary
< gribble> https://github.com/bitcoin/bitcoin/issues/17090 | RFC: Rust code integration . Issue #17090 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16834 | Fetch Headers over DNS by TheBlueMatt . Pull Request #16834 . bitcoin/bitcoin . GitHub
< wumpus> #topic rust in bitcoin core (BlueMatt)
< wumpus> it's meant to document bitcoin core, not leveldb, or a crc32 library
< bitcoin-git> [bitcoin] fanquake opened pull request #17403: doc: reintegrate 0.19.0 release notes (0.19...reintegrate_relnotes_019) https://github.com/bitcoin/bitcoin/pull/17403
< jonatack> perhaps it needs awareness raised about it? via bitcoin optech, forums, etc.
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 . Pull Request #17331 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] elichai opened pull request #17402: Travis support for PowerPC64 (master...2019-11-powerpc64) https://github.com/bitcoin/bitcoin/pull/17402
< nickler> We're adding a SECURITY.md file to the bitcoin-core/secp256k1 repo and considered secp256k1-security@bitcoincore.org as security email address.Would it be possible to add such an email address? How are we making sure that security contacts will actually get emails forwarded to them? Who can see the content of a vulnerability report if it's sent unencrypted?
< wumpus> yes, I can make a forward address on bitcoin-core.org
< wumpus> #topic security email address for bitcoin-core/secp256k1 (nickler)
< gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17326 | rfc, p2p: Eclipse attack mitigation . Issue #17326 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17373 | wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet by achow101 . Pull Request #17373 . bitcoin/bitcoin . GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< gribble> https://github.com/bitcoin/bitcoin/issues/17079 | v0.19.0 testing . Issue #17079 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16996 | Release process for 0.19.0 . Issue #16996 . bitcoin/bitcoin . GitHub
< wumpus> already had to make a patch on top on crc32c too, build system related, https://github.com/bitcoin-core/crc32c/commit/a3f2c1c13051d922cef031aec505801462080579 but should be upstreamable too I think
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr . Pull Request #14066 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr . Pull Request #14066 . bitcoin/bitcoin . GitHub
< BlueMatt> I work daily on ppc64, though I dont daily build bitcoin core
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/772673dfbe70...270616228bc9
< bitcoin-git> bitcoin/master 6d50b26 Jon Atack: test: add logging to wallet_avoidreuse.py
< bitcoin-git> bitcoin/master 0e7c90e Jon Atack: test: speed up wallet_avoidreuse.py
< bitcoin-git> bitcoin/master 2706162 fanquake: Merge #17362: test: speed up wallet_avoidreuse, add logging
< elichai2> hmmm `/home/travis/build/elichai/bitcoin/build/bitcoin-powerpc64le-unknown-linux-gnu/src/compat/glibc_compat.cpp:75: undefined reference to `log2f_old'`
< bitcoin-git> [bitcoin] fanquake merged pull request #17362: test: speed up wallet_avoidreuse, add logging (master...wallet_avoidreuse-test-improvements) https://github.com/bitcoin/bitcoin/pull/17362
< elichai2> (it's still building with no depends https://travis-ci.org/elichai/bitcoin/jobs/608821982)
< elichai2> k. i'll for now try without depends to see if any other erros come up that are more directly related to bitcoin
< elichai2> Getting frustrated. at this point any help would be wellcome. I can't figure out why this test is failing :/ https://travis-ci.org/elichai/bitcoin/jobs/608789848
< gribble> https://github.com/bitcoin/bitcoin/issues/15847 | Feedback for GitHub CEO . Issue #15847 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d14e35f3fb7...772673dfbe70
< bitcoin-git> bitcoin/master fae43a9 MarcoFalke: test: Seed test RNG context for each test case, print seed
< bitcoin-git> bitcoin/master 772673d MarcoFalke: Merge #16978: test: Seed test RNG context for each test case, print seed
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16978: test: Seed test RNG context for each test case, print seed (master...1909-testSeed) https://github.com/bitcoin/bitcoin/pull/16978
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17342: refactor: Clean up nScriptCheckThreads (master...2019-11-nScriptCheckThreads-comment) https://github.com/bitcoin/bitcoin/pull/17342
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/46e0e276398e...7d14e35f3fb7
< bitcoin-git> bitcoin/master d995762 John Newbery: [tests] Don't use TestingSetup in the checkqueue_tests
< bitcoin-git> bitcoin/master 5506ecf John Newbery: [refactor] Replace global int nScriptCheckThreads with bool
< bitcoin-git> bitcoin/master 7d14e35 MarcoFalke: Merge #17342: refactor: Clean up nScriptCheckThreads
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/46fc4d1a24c8...46e0e276398e
< bitcoin-git> bitcoin/master 3c84dee Aaron Clauson: Updated appveyor config:
< bitcoin-git> bitcoin/master 46e0e27 MarcoFalke: Merge #17364: Updates to appveyor config for VS2019 and Qt5.9.8 + msvc pro...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17364: Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
< gribble> https://github.com/bitcoin/bitcoin/issues/14264 | doc: Split depends installation instructions per arch by MarcoFalke . Pull Request #14264 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13510 | Scripts and tools: Obsolete #!/bin/bash shebang by DesWurstes . Pull Request #13510 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17384 | test: Create new test library by MarcoFalke . Pull Request #17384 . bitcoin/bitcoin . GitHub
< wumpus> e.g. https://github.com/bitcoin/bitcoin/pull/17398/commits/b9b829574c517fcbc0fbcbda67ed667b04a73899 the other option would be to have an unified exclude path, but having to specify it 10+ times is absurd
< gribble> https://github.com/bitcoin/bitcoin/issues/17398 | WIP: build: Update leveldb to 1.22+ by laanwj . Pull Request #17398 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17384: test: Create new test library (master...1911-testLib) https://github.com/bitcoin/bitcoin/pull/17384
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e65b4160e99f...46fc4d1a24c8
< bitcoin-git> bitcoin/master faec282 MarcoFalke: scripted-diff: test: Move setup_common to test library
< bitcoin-git> bitcoin/master fa4c6fa MarcoFalke: doc: Add documentation for new test/lib
< bitcoin-git> bitcoin/master 46fc4d1 MarcoFalke: Merge #17384: test: Create new test library
< elichai2> if any docker wizard has any inputs on what's going on here it'll be appretiated :) (added `set -x` and some docker ls's here and there) https://travis-ci.org/elichai/bitcoin/jobs/608713371#L435
< elichai2> Still have some problems but look at build no. 3 :) https://travis-ci.org/elichai/bitcoin/builds/608703220
< jonatack> promag: yes, what real_or_random said. See discussion at https://github.com/bitcoin/bitcoin/pull/16047#discussion_r285628201
< gribble> https://github.com/bitcoin/bitcoin/issues/17384 | test: Create new test library by MarcoFalke . Pull Request #17384 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] jkczyz opened pull request #17399: validation: Templatize ValidationState instead of subclassing (master...2019-11-validation-state) https://github.com/bitcoin/bitcoin/pull/17399

2019-11-06

< gribble> https://github.com/bitcoin/bitcoin/issues/17384 | test: Create new test library by MarcoFalke . Pull Request #17384 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #17398: WIP: Update leveldb to 1.22+ (master...2019_11_leveldb_upstream) https://github.com/bitcoin/bitcoin/pull/17398
< sipa> i think we could reasonable create a new branch in bitcoin-core/leveldb which is equal to the google/leveldb one + a few patches
< wumpus> even tests that pass, I'd guess (https://github.com/bitcoin-core/leveldb/issues/8)
< wumpus> oh nice, there's a env_windows.cpp in the new upstream leveldb, we might be able to stop maintaining our own env_win https://github.com/bitcoin-core/leveldb/pull/26 this handles the file functions and such, it will be a lot of work to test/investigate the differences though
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/976cc766c428...e65b4160e99f
< bitcoin-git> bitcoin/master 646b593 John Newbery: [tests] Speed up rpc_fundrawtransaction.py
< bitcoin-git> bitcoin/master 9a85052 John Newbery: [tests] Use -whitelist in rpc_fundrawtransaction.py
< bitcoin-git> bitcoin/master af7bae7 John Newbery: [tests] Don't stop-start unnecessarily in rpc_fundrawtransaction.py
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17340: Tests: speed up fundrawtransaction test (master...2019-11-speed-up-fundrawtransaction-test) https://github.com/bitcoin/bitcoin/pull/17340
< bitcoin-git> [bitcoin] laanwj reopened pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
< bitcoin-git> [bitcoin] icota opened pull request #17396: build: modest Android improvements (master...2019-11-android-static-libstdc) https://github.com/bitcoin/bitcoin/pull/17396
< instagibbs> ryanofsky, https://github.com/bitcoin/bitcoin/pull/17258 has all the breadcrumbs necessary in the OP, I think that's plenty of credit
< bitcoin-git> [bitcoin] laanwj merged pull request #17381: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup2) https://github.com/bitcoin/bitcoin/pull/17381
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6f4e24735791...976cc766c428
< bitcoin-git> bitcoin/master b07b07c Russell Yanofsky: Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp
< bitcoin-git> bitcoin/master 4a0abf6 Russell Yanofsky: Pass CTxDestination to ScriptPubKeyMan::GetMetadata
< bitcoin-git> bitcoin/master 491a599 Russell Yanofsky: Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method
< gribble> https://github.com/bitcoin/bitcoin/issues/13859 | qa: Add emojis to test_runner path and wallet filename by MarcoFalke . Pull Request #13859 . bitcoin/bitcoin . GitHub
< wumpus> promag: congrats with getting an emoji into a commit message, dunno if it's a first ? https://github.com/bitcoin/bitcoin/commit/6f4e2473579168dffd46d54fa1eedd287395200b
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86771d431054...6f4e24735791
< bitcoin-git> bitcoin/master 286f197 Russell Yanofsky: Add util_ArgParsing test
< bitcoin-git> bitcoin/master 6f4e247 Wladimir J. van der Laan: Merge #17390: test: Add util_ArgParsing test
< bitcoin-git> [bitcoin] laanwj merged pull request #17390: test: Add util_ArgParsing test (master...pr/argparse-test) https://github.com/bitcoin/bitcoin/pull/17390
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22a58811d4ee...86771d431054
< bitcoin-git> bitcoin/master 7b78b8d Michael Folkson: doc: Add template for good first issues
< bitcoin-git> bitcoin/master 86771d4 Wladimir J. van der Laan: Merge #17339: doc: Add template for good first issues
< bitcoin-git> [bitcoin] laanwj merged pull request #17339: doc: Add template for good first issues (master...20191101-first-issue) https://github.com/bitcoin/bitcoin/pull/17339
< gribble> https://github.com/bitcoin/bitcoin/issues/17357 | tests: Add fuzzing harness for Bech32 encoding/decoding by practicalswift . Pull Request #17357 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7967104aee05...22a58811d4ee
< bitcoin-git> bitcoin/master 2ad74b7 Hennadii Stepanov: doc: Add ShellCheck to lint tests dependencies
< bitcoin-git> bitcoin/master 80c9e66 Hennadii Stepanov: build: Remove install command samples
< bitcoin-git> bitcoin/master 22a5881 MarcoFalke: Merge #17353: doc: Add ShellCheck to lint tests dependencies
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17353: doc: Add ShellCheck to lint tests dependencies (master...20191102-lint-dependencies) https://github.com/bitcoin/bitcoin/pull/17353
< wumpus> re: leveldb upstream merge https://github.com/bitcoin-core/leveldb/issues/25
< bitcoin-git> [bitcoin] sipsorcery reopened pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
< bitcoin-git> [bitcoin] sipsorcery closed pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
< bitcoin-git> [bitcoin] laanwj merged pull request #17368: cli: fix -getinfo output when compiled with no wallet (master...fix_getinfo_no_wallet) https://github.com/bitcoin/bitcoin/pull/17368
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/224c19645fa0...7967104aee05
< bitcoin-git> bitcoin/master 3d05d33 fanquake: cli: fix -getinfo output when compiled with no wallet
< bitcoin-git> bitcoin/master 7967104 Wladimir J. van der Laan: Merge #17368: cli: fix -getinfo output when compiled with no wallet
< bitcoin-git> [bitcoin] gr0kchain opened pull request #17393: Updated config file to include regtest (master...patch-2) https://github.com/bitcoin/bitcoin/pull/17393
< wumpus> how does this work, if I wanted to update leveldb to upstream, I guess I first need to update https://github.com/bitcoin-core/leveldb?
< bitcoin-git> [bitcoin] laanwj closed pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e21f72980a7...224c19645fa0
< bitcoin-git> bitcoin/master 3645e4c Russell Yanofsky: Add missing newline in util_ChainMerge test
< bitcoin-git> bitcoin/master 224c196 Wladimir J. van der Laan: Merge #17388: Add missing newline in util_ChainMerge test
< bitcoin-git> [bitcoin] laanwj merged pull request #17388: Add missing newline in util_ChainMerge test (master...pr/chainmerge-nl) https://github.com/bitcoin/bitcoin/pull/17388
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45e65376ac9e...4e21f72980a7
< bitcoin-git> bitcoin/master fa7f5a4 MarcoFalke: doc: Update doc/bips.md with recent changes in master
< bitcoin-git> bitcoin/master 4e21f72 fanquake: Merge #17370: doc: Update doc/bips.md with recent changes in master
< bitcoin-git> [bitcoin] fanquake merged pull request #17370: doc: Update doc/bips.md with recent changes in master (master...1911-docBips) https://github.com/bitcoin/bitcoin/pull/17370
< bitcoin-git> [bitcoin] MarceloGra closed pull request #17391: 0.8 (master...0.8) https://github.com/bitcoin/bitcoin/pull/17391
< bitcoin-git> [bitcoin] MarceloGra opened pull request #17391: 0.8 (master...0.8) https://github.com/bitcoin/bitcoin/pull/17391
< bitcoin-git> [bitcoin] Empact closed pull request #17386: [moveonly] Extract CWallet::CompactDatabase (master...get-db-handle) https://github.com/bitcoin/bitcoin/pull/17386
< gribble> https://github.com/bitcoin/bitcoin/issues/17385 | refactor: Use our own integer parsing/formatting everywhere by laanwj . Pull Request #17385 . bitcoin/bitcoin . GitHub

2019-11-05

< bitcoin-git> [bitcoin] ryanofsky opened pull request #17390: Add util_ArgParsing test (master...pr/argparse-test) https://github.com/bitcoin/bitcoin/pull/17390
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17389: build: add background.tiff and .pngs to "make clean" (master...make-clean-tiff) https://github.com/bitcoin/bitcoin/pull/17389
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/40b6070ad7e8...45e65376ac9e
< bitcoin-git> bitcoin/master fa5facd MarcoFalke: rpc: Remove unused boost::this_thread::interruption_point
< bitcoin-git> bitcoin/master 45e6537 Wladimir J. van der Laan: Merge #17382: rpc: Remove unused boost::this_thread::interruption_point
< bitcoin-git> [bitcoin] laanwj merged pull request #17382: rpc: Remove unused boost::this_thread::interruption_point (master...1911-noBoostThreadInt) https://github.com/bitcoin/bitcoin/pull/17382
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9a45500018f...40b6070ad7e8
< bitcoin-git> bitcoin/master 41edaf2 James O'Beirne: logs: add BCLog::Timer and related macros
< bitcoin-git> bitcoin/master dcef9a2 James O'Beirne: logs: add timing information to FlushStateToDisk()
< bitcoin-git> bitcoin/master 40b6070 Wladimir J. van der Laan: Merge #16805: logs: add timing information to FlushStateToDisk()
< bitcoin-git> [bitcoin] laanwj merged pull request #16805: logs: add timing information to FlushStateToDisk() (master...2019-09-flush-logs) https://github.com/bitcoin/bitcoin/pull/16805
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17388: Add missing newline in util_ChainMerge test (master...pr/chainmerge-nl) https://github.com/bitcoin/bitcoin/pull/17388
< bitcoin-git> [bitcoin] achow101 opened pull request #17387: wallet_importmulti: use addresses of the same type as being imported (master...tests-fix-getaddrinfo-type-consistency) https://github.com/bitcoin/bitcoin/pull/17387
< bitcoin-git> [bitcoin] Empact opened pull request #17386: [moveonly] Extract CWallet::CompactDatabase (master...get-db-handle) https://github.com/bitcoin/bitcoin/pull/17386
< bitcoin-git> [bitcoin] achow101 closed pull request #17374: IsMine: Set state to WATCH_ONLY if we can get the pubkey (master...wallet-box-pr-7) https://github.com/bitcoin/bitcoin/pull/17374
< bitcoin-git> [bitcoin] laanwj opened pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17384: test: Create new test library (master...1911-testLib) https://github.com/bitcoin/bitcoin/pull/17384
< bitcoin-git> [bitcoin] jnewbery opened pull request #17383: Refactor: Move consts to their correct translation units (master...2019-11-net-processing-consts) https://github.com/bitcoin/bitcoin/pull/17383
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fea532a5f20c...d9a45500018f
< bitcoin-git> bitcoin/master 1c26c16 Danny-Scott: Improve "Hide" button tool-tip message
< bitcoin-git> bitcoin/master d9a4550 Wladimir J. van der Laan: Merge #17360: gui: Improve "Hide" button tool-tip message
< bitcoin-git> [bitcoin] laanwj merged pull request #17360: gui: Improve "Hide" button tool-tip message (master...nov-2019-hide-button-tool-tip) https://github.com/bitcoin/bitcoin/pull/17360
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b05b28183c0a...fea532a5f20c
< bitcoin-git> bitcoin/master fa1936f MarcoFalke: logging: Add member for arbitrary print callbacks
< bitcoin-git> bitcoin/master fa2c44c MarcoFalke: test: Add ASSERT_DEBUG_LOG to unit test framework
< bitcoin-git> bitcoin/master fea532a MarcoFalke: Merge #16540: test: Add ASSERT_DEBUG_LOG to unit test framework
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17382: rpc: Remove unused boost::this_thread::interruption_point (master...1911-noBoostThreadInt) https://github.com/bitcoin/bitcoin/pull/17382
< gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard . Pull Request #15931 . bitcoin/bitcoin . GitHub
< luke-jr> MarcoFalke: but UniValue is an upstream dependency, not Bitcoin Core; it shouldn't be bundled at all
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d35b12107e9e...b05b28183c0a
< bitcoin-git> bitcoin/master 707fde7 James O'Beirne: add unused SnapshotMetadata class
< bitcoin-git> bitcoin/master 92fafb3 James O'Beirne: coinstats: add coins_count
< bitcoin-git> bitcoin/master 57cf74c James O'Beirne: rpc: add dumptxoutset
< bitcoin-git> [bitcoin] laanwj merged pull request #16899: UTXO snapshot creation (dumptxoutset) (master...2019-09-au-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/16899
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22e7eea629e2...d35b12107e9e
< bitcoin-git> bitcoin/master 104f7de tryphe: remove old bootstrap relevant code
< bitcoin-git> bitcoin/master d35b121 Wladimir J. van der Laan: Merge #17044: init: Remove auto-import of `bootstrap.dat` and associated c...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/50591f6ec61b...22e7eea629e2
< bitcoin-git> bitcoin/master b2ff500 Sebastian Falbesoner: test: add "diamond" unit test to MempoolAncestryTests
< bitcoin-git> bitcoin/master 22e7eea MarcoFalke: Merge #17363: test: add "diamond" unit test to MempoolAncestryTests
< gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard . Pull Request #15931 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c7e6b3b343e8...50591f6ec61b
< bitcoin-git> bitcoin/master 85a34b1 practicalswift: tests: Move CaseInsensitiveEqual to test/util/str
< bitcoin-git> bitcoin/master b754170 practicalswift: tests: Add fuzzing harness for Bech32 encoding/decoding
< bitcoin-git> bitcoin/master 50591f6 MarcoFalke: Merge #17357: tests: Add fuzzing harness for Bech32 encoding/decoding
< MarcoFalke> luke-jr: Fine, but we don't use goto in the Bitcoin Core dialect of C++
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e204dc11b562...54a337478dfb
< bitcoin-git> bitcoin/master d3ed06e James Chiang: TestShell: Fix typo in TestShell warning printout
< bitcoin-git> bitcoin/master 9c7806e James Chiang: Doc: Remove backticks in test-shell.md code block
< bitcoin-git> bitcoin/master a8dea45 James Chiang: TestShell: Simplify default setting of num_nodes
< bitcoin-git> [bitcoin] laanwj merged pull request #17044: init: Remove auto-import of `bootstrap.dat` and associated code (master...pr15954) https://github.com/bitcoin/bitcoin/pull/17044
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17363: test: add "diamond" unit test to MempoolAncestryTests (master...20191104-test-add_diamond_ancestors_unit_test) https://github.com/bitcoin/bitcoin/pull/17363
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17357: tests: Add fuzzing harness for Bech32 encoding/decoding (master...fuzzers-bech32) https://github.com/bitcoin/bitcoin/pull/17357
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17243: p2p: add PoissonNextSend method that returns mockable time (master...1910-mockable-poisson) https://github.com/bitcoin/bitcoin/pull/17243
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/54a337478dfb...c7e6b3b343e8
< bitcoin-git> bitcoin/master 4de6303 Amiti Uttarwar: [tools] add PoissonNextSend method that returns mockable time
< bitcoin-git> bitcoin/master 1a8f0d5 Amiti Uttarwar: [tools] update nNextInvSend to use mockable time
< bitcoin-git> bitcoin/master c7e6b3b MarcoFalke: Merge #17243: p2p: add PoissonNextSend method that returns mockable time
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17378: TestShell: Fix typos & implement cleanups (master...2019-11-testshell-followup) https://github.com/bitcoin/bitcoin/pull/17378
< bitcoin-git> [bitcoin] fanquake closed pull request #17377: wallet: remove unused variable spk_man in import* RPCs (master...20191105-refactor-remove_unused_variable_spkman) https://github.com/bitcoin/bitcoin/pull/17377
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17381: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup2) https://github.com/bitcoin/bitcoin/pull/17381
< luke-jr> #17356 is now passing and ready for concept review; in particular, one open question is how to deal with the `echo` JSON-RPC method: https://github.com/bitcoin/bitcoin/pull/17356#issuecomment-549565616
< gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr . Pull Request #17356 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bdda13787890...e204dc11b562
< bitcoin-git> bitcoin/master aa9b84a Igor Cota: depends: update README.md with working Android targets and API levels
< bitcoin-git> bitcoin/master 3fe1aba Igor Cota: depends: move README.md Android instructions to a separate section
< bitcoin-git> bitcoin/master e204dc1 MarcoFalke: Merge #17365: depends: update README.md with working Android targets and A...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17365: depends: update README.md with working Android targets and API levels (master...update-android-depends-doc) https://github.com/bitcoin/bitcoin/pull/17365
< bitcoin-git> [bitcoin] jachiang opened pull request #17378: TestShell: Fix typos & implement cleanups (master...2019-11-testshell-followup) https://github.com/bitcoin/bitcoin/pull/17378