< bitcoin-git>
[bitcoin] promag opened pull request #16037: rpc: Fail importwallet only if a required block is pruned (master...2019-05-importwallet-pruned) https://github.com/bitcoin/bitcoin/pull/16037
< bitcoin-git>
[bitcoin] laanwj merged pull request #15970: Utils and libraries: fix static_assert for macro HAVE_THREAD_LOCAL (master...master) https://github.com/bitcoin/bitcoin/pull/15970
< bitcoin-git>
bitcoin/master 662d117 Andrew Chow: Add option to create an encrypted wallet
< bitcoin-git>
bitcoin/master 1c719f7 Wladimir J. van der Laan: Merge #15006: Add option to create an encrypted wallet
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15870: wallet: Only fail rescan when blocks have actually been pruned (master...1904-walletRescanPruned) https://github.com/bitcoin/bitcoin/pull/15870
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16034: Add assertion to make sure the LockAnnotation guarantees we give are truthful (ifdef DEBUG_LOCKORDER) (master...make-sure-LockAnnotation-promises-are-truthful) https://github.com/bitcoin/bitcoin/pull/16034
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16033: Hold cs_main when reading chainActive via getTipLocator(). Remove assumeLocked(). (master...assumeLocked) https://github.com/bitcoin/bitcoin/pull/16033
< bitcoin-git>
bitcoin/master fad0ce5 MarcoFalke: tests: Fail if RPC has been added without tests
< bitcoin-git>
bitcoin/master 9d266db MarcoFalke: Merge #15943: tests: Fail if RPC has been added without tests
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15943: tests: Fail if RPC has been added without tests (master...1905-testFailNoRpcCov) https://github.com/bitcoin/bitcoin/pull/15943
< bitcoin-git>
[bitcoin] dongcarl closed pull request #15586: chainparams: Explicitly use uint16 for nDefaultPort (master...2019-03-uint16-port) https://github.com/bitcoin/bitcoin/pull/15586
< bitcoin-git>
[bitcoin] dongcarl opened pull request #16029: netbase: Remove "tor" as a network specification (master...2019-05-remove-net-tor) https://github.com/bitcoin/bitcoin/pull/16029
< bitcoin-git>
[bitcoin] achow101 opened pull request #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address (master...dont-sw-ms-uncomp) https://github.com/bitcoin/bitcoin/pull/16026
< gmaxwell>
"Simple multisig spending using Taproot" in particular mentions the key-aggregation multisig approach, but my discussions with Bitcoin businesses suggest that few will use it as described there, due to accountability.
2019-05-14
< bitcoin-git>
[bitcoin] ccapo opened pull request #16024: [rpc] deriveaddresses: Correction of descriptor checksum in RPC example (master...2019-05-14-deriveaddresses-example-checksum) https://github.com/bitcoin/bitcoin/pull/16024
< bitcoin-git>
[bitcoin] achow101 opened pull request #16022: Don't sign when segwit signatures are being used and the pubkey(s) are uncompressed (master...dont-sign-uncomp-segwit) https://github.com/bitcoin/bitcoin/pull/16022
< gribble>
https://github.com/bitcoin/bitcoin/issues/16012 | rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided by ps1dr3x · Pull Request #16012 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16021: p2p: Disallow extended encoding for non-witness transactions (take 3) (master...1905-illegalWitnessP2P) https://github.com/bitcoin/bitcoin/pull/16021
< bitcoin-git>
[bitcoin] promag closed pull request #16017: rpc: Drop -rpcuser and -rpcpassword from server (master...2019-05-remove-rpcpassword) https://github.com/bitcoin/bitcoin/pull/16017
< bitcoin-git>
[bitcoin] promag opened pull request #16019: refactor: Move result instead of copy in Solver() (master...2019-05-solver-nit) https://github.com/bitcoin/bitcoin/pull/16019
< bitcoin-git>
[bitcoin] promag opened pull request #16017: rpc: Drop -rpcuser and -rpcpassword from server (master...2019-05-remove-rpcpassword) https://github.com/bitcoin/bitcoin/pull/16017
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #15989: RPC: Do not use cookie auth if -rpcauth set (master...20190509-rpcauth) https://github.com/bitcoin/bitcoin/pull/15989
2019-05-12
< bitcoin-git>
[bitcoin] practicalswift opened pull request #16015: validation: Hold cs_main when reading chainActive in RewindBlockIndex (master...missing-cs_main-in-RewindBlockIndex) https://github.com/bitcoin/bitcoin/pull/16015
< sipa>
bitcoin core does not in any way interact with lightning
< sipa>
jdabber: bitcoin core is an implementation of the bitcoin protocol; lnd and c-lightning are implementations of the lightning protocol
< bitcoin-git>
[bitcoin] ps1dr3x opened pull request #16012: rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided (master...master) https://github.com/bitcoin/bitcoin/pull/16012
2019-05-11
< gmaxwell>
sipa: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-May/016918.html in this message Sjors recommends listing alternatives in the BIP, I strongly recommend against doing that-- it would be confusing due to distracting from what the BIP also does. BIPs should give rationale where they help add clarity on whats being done, but comparisons with untaken alternatives should generally
< tryphe>
gmaxwell, thanks. my hunch was that the feeler count was incorporated into maxconnections, in order to reserve the feeler, ie default maxconnections=125, so you get 116 inbound, 8 outbound, and 1 feeler (see https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L895)
< bitcoin-git>
bitcoin/master d20d756 Felix Weis: rpc: faster getblockstats using BlockUndo data
< bitcoin-git>
bitcoin/master e2371f8 MarcoFalke: Merge #14802: rpc: faster getblockstats using BlockUndo data
< bitcoin-git>
[bitcoin] nalinbhardwaj closed pull request #16006: rpc: use walletrbf as default setting in walletcreatefundedpsbt (master...walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/16006
< bitcoin-git>
[bitcoin] nalinbhardwaj opened pull request #16006: rpc: use walletrbf as default setting in walletcreatefundedpsbt (master...walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/16006
< bitcoin-git>
[bitcoin] tryphe opened pull request #16003: [init] an incorrect amount of file descriptors is requested, and a different amount is also asserted (master...fd-limits-3) https://github.com/bitcoin/bitcoin/pull/16003
< bitcoin-git>
[bitcoin] instagibbs opened pull request #15996: Deprecate totalfee argument in `bumpfee` (master...deprecate_totalfee) https://github.com/bitcoin/bitcoin/pull/15996
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #15995: systemd service script: set usable permissions on /etc/bitcoin config dir (master...systemdconfig) https://github.com/bitcoin/bitcoin/pull/15995
< wumpus>
pretty sure sipsorcery & other MSVC builders only use windows 64, too, also, anything x86 32-bit-only is going to be too slow to either compile bitcoin core or do the initial sync
< bitcoin-git>
bitcoin/master 70946e7 Gregory Sanders: Replace CScriptID and CKeyID in CTxDestination with dedicated types
< bitcoin-git>
bitcoin/master 78e407a Gregory Sanders: GetKeyBirthTimes should return key ids, not destinations
< bitcoin-git>
bitcoin/master de5af41 Wladimir J. van der Laan: Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicate...
< bitcoin-git>
[bitcoin] laanwj merged pull request #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types (master...key_script_dest) https://github.com/bitcoin/bitcoin/pull/15452
< bitcoin-git>
[bitcoin] hebasto opened pull request #15993: net: Drop the ancient miniUPnPc API version support (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993
< gmaxwell>
re https://github.com/bitcoin/bitcoin/pull/15985 ... it's not great if almost all our travis runs are using sanitizers, they radically change the compilers behavior (as that PR observes)
2019-05-08
< bitcoin-git>
[bitcoin] luke-jr opened pull request #15987: Wallet, GUI: Warn when sending to already-used Bitcoin addresses (also RPC: include such information in getaddressinfo) (master...wallet_no_reuse) https://github.com/bitcoin/bitcoin/pull/15987
< bitcoin-git>
[bitcoin] sipa opened pull request #15986: Add unmodified-descriptor-with-checksum to getdescriptorinfo (master...201905_justchecksum) https://github.com/bitcoin/bitcoin/pull/15986
< bitcoin-git>
[bitcoin] Bushstar opened pull request #15979: Replace incorrectly named comment with func (master...replace-with-func) https://github.com/bitcoin/bitcoin/pull/15979
< tryphe>
i noticed there's not a lot of usage of 'const' in a lot of bitcoin code where there could be. is this for readability purposes, or are changes welcome?
< provoostenator>
sipa: can you make a pull request to yourself with the "tapoot" brach, or a Draft pull request to Bitcoin Core? I find that easier to review than just a branch.
< bitcoin-git>
[bitcoin] jamesob opened pull request #15976: refactor: move methods under CChainState (pt. 1) (master...2019-05-au-cchainstate) https://github.com/bitcoin/bitcoin/pull/15976
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #14033: p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater (master...nVersion-checks) https://github.com/bitcoin/bitcoin/pull/14033
< bitcoin-git>
[bitcoin] DrahtBot reopened pull request #14033: p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater (master...nVersion-checks) https://github.com/bitcoin/bitcoin/pull/14033
< bitcoin-git>
[bitcoin] DrahtBot closed pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818
< bitcoin-git>
[bitcoin] practicalswift closed pull request #15721: validation: Check absence of locks at compile-time (LOCKS_EXCLUDED) in addition to the current run-time checking (AssertLockNotHeld) (master...negative-locking-annotations) https://github.com/bitcoin/bitcoin/pull/15721
< bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #15045: [test] Apply maximal flags to tx_valid tests and minimal flags to tx_invalid tests (master...min_txtests_flags) https://github.com/bitcoin/bitcoin/pull/15045
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #15045: [test] Apply maximal flags to tx_valid tests and minimal flags to tx_invalid tests (master...min_txtests_flags) https://github.com/bitcoin/bitcoin/pull/15045
< bitcoin-git>
[bitcoin] instagibbs closed pull request #13045: [p2p] getblock for 1-block reorgs in response to compact block message (master...cmpcttie) https://github.com/bitcoin/bitcoin/pull/13045
< bitcoin-git>
[bitcoin] joemphilips closed pull request #11770: [REST] add a rest endpoint for estimatesmartfee, docs, and test (master...rest_fee) https://github.com/bitcoin/bitcoin/pull/11770
< bitcoin-git>
[bitcoin] promag opened pull request #15975: univalue: Drop overloaded members (master...2019-05-drop-univalue-overloads) https://github.com/bitcoin/bitcoin/pull/15975
< bitcoin-git>
[bitcoin] JeremyRubin opened pull request #15969: Refactor: explicit VerifyScript control flow based on pattern matching (master...explicit-verifyscript) https://github.com/bitcoin/bitcoin/pull/15969
< bitcoin-git>
[bitcoin] hebasto closed pull request #15966: net: Drop the ancient miniUPnPc API version support (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15966