2018-05-31

< gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13026 | Fix include comment in src/interfaces/wallet.h by promag · Pull Request #13026 · bitcoin/bitcoin · GitHub
<@wumpus> yes, rc1 is out with email to bitcoin-core-dev mailing list
<@wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark mi
< bitcoin-git> [bitcoin] jl2012 opened pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13359: wallet: Directly operate with CMutableTransaction (master...Mf1806-avoidTxConstuctor) https://github.com/bitcoin/bitcoin/pull/13359
< bitcoin-git> [bitcoin] jl2012 opened pull request #13357: Accurately determine the use of SIGHASH_SINGLE in signing (master...signsingle) https://github.com/bitcoin/bitcoin/pull/13357
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13347: travis: Skip cache for lint stage (master...Mf1806-travisLintNoCache) https://github.com/bitcoin/bitcoin/pull/13347
< bitcoin-git> bitcoin/master 87a9d03 MarcoFalke: Merge #13347: travis: Skip cache for lint stage...
< bitcoin-git> bitcoin/master fa2d83e MarcoFalke: travis: Skip cache for lint stage
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/24f70118414f...87a9d03c0c1e
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13349: bench: Don't return a bool from main (master...2017_05_bench_warning) https://github.com/bitcoin/bitcoin/pull/13349
< bitcoin-git> bitcoin/master 24f7011 MarcoFalke: Merge #13349: bench: Don't return a bool from main...
< bitcoin-git> bitcoin/master 493a166 Wladimir J. van der Laan: bench: Don't return a bool from main...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/36fc8052f62b...24f70118414f
< gribble> https://github.com/bitcoin/bitcoin/issues/13356 | RFC: C++14 Requirement · Issue #13356 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13309: Directly operate with CMutableTransaction in SignSignature (master...SignSignature-with-CMutableTransaction) https://github.com/bitcoin/bitcoin/pull/13309
< bitcoin-git> bitcoin/master 36fc805 Wladimir J. van der Laan: Merge #13309: Directly operate with CMutableTransaction in SignSignature...
< bitcoin-git> bitcoin/master 6b8b63a Martin Ankerl: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/472fe8a2ce9f...36fc8052f62b
< gribble> https://github.com/bitcoin/bitcoin/issues/13309 | Directly operate with CMutableTransaction in SignSignature by martinus · Pull Request #13309 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #13355: Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling (master...openbsd-gmake-check) https://github.com/bitcoin/bitcoin/pull/13355
< gribble> https://github.com/bitcoin/bitcoin/issues/13309 | Directly operate with CMutableTransaction in SignSignature by martinus · Pull Request #13309 · bitcoin/bitcoin · GitHub
< jonasschnelli> sipa: re https://github.com/bitcoin/bitcoin/pull/12196#discussion_r189396442, did you accidentally left away pubkeys for the API? We have to derive various script types anyways with xpubs, right?
< gribble> https://github.com/bitcoin/bitcoin/issues/11732 | RFC: bump GCC requirement to 4.8 · Issue #11732 · bitcoin/bitcoin · GitHub
< mryandao> the mods in #bitcoin do that.
< gribble> https://github.com/bitcoin/bitcoin/issues/13294 | Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 by practicalswift · Pull Request #13294 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13337 | OpenBSD 6.3 build: test/arith_uint256_tests.cpp complains about missing argument · Issue #13337 · bitcoin/bitcoin · GitHub
< fanquake> mryandao If you haven't see already cfields has been working on that as well https://github.com/bitcoin/bitcoin/pull/9566
< gribble> https://github.com/bitcoin/bitcoin/issues/13171 | [WIP] Change gitian-descriptors to use bionic instead by ken2812221 · Pull Request #13171 · bitcoin/bitcoin · GitHub

2018-05-30

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13353: qa: Fixup setting of PATH env var (master...Mf1806-qaPathBitcoind) https://github.com/bitcoin/bitcoin/pull/13353
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13352: qa: Avoid checking reject code for now (master...Mf1806-qaRejectCode) https://github.com/bitcoin/bitcoin/pull/13352
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13069: docs: Fix typos (master...typos-201804) https://github.com/bitcoin/bitcoin/pull/13069
< bitcoin-git> bitcoin/master d8c4998 practicalswift: Fix typos
< bitcoin-git> bitcoin/master 472fe8a MarcoFalke: Merge #13069: docs: Fix typos...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/61fcef0f89c4...472fe8a2ce9f
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13351: wallet: Prevent segfault when sending to unspendable witness (master...Mf1806-walletUnspendableWitnessIsMine) https://github.com/bitcoin/bitcoin/pull/13351
< bitcoin-git> [bitcoin] lmanners opened pull request #13350: [tests] Add logging to provide anchor points when debugging failures. (master...testlogging) https://github.com/bitcoin/bitcoin/pull/13350
< bitcoin-git> [bitcoin] laanwj opened pull request #13349: bench: Don't return a bool from main (master...2017_05_bench_warning) https://github.com/bitcoin/bitcoin/pull/13349
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13112: Throw an error for unknown args (master...gargs-know-args) https://github.com/bitcoin/bitcoin/pull/13112
< bitcoin-git> bitcoin/master 9030557 Andrew Chow: Test gArgs erroring on unknown args
< bitcoin-git> bitcoin/master 4f8704d Andrew Chow: Give an error and exit if there are unknown parameters...
< bitcoin-git> bitcoin/master 174f7c8 Andrew Chow: Use a struct for arguments and nested map for categories...
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4cc8d9930ec...61fcef0f89c4
< bitcoin-git> [bitcoin] laanwj closed pull request #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety (master...refactor_wallet_RKFKP) https://github.com/bitcoin/bitcoin/pull/13252
< bitcoin-git> bitcoin/master c4cc8d9 Wladimir J. van der Laan: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety...
< bitcoin-git> bitcoin/master 4b62bdf Ben Woosley: Wallet: Refactor ReserveKeyFromKeyPool for safety...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd96d54f39cf...c4cc8d9930ec
< bitcoin-git> [bitcoin] jl2012 opened pull request #13348: Standard template for CHECKMULTISIG with 17~20 keys (master...20multisig) https://github.com/bitcoin/bitcoin/pull/13348
< gribble> https://github.com/bitcoin/bitcoin/issues/12136 | Implement BIP 174 Partially Signed Bitcoin Transactions by achow101 · Pull Request #12136 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13194: Remove template matching and pseudo opcodes (master...201805_noscriptpattern) https://github.com/bitcoin/bitcoin/pull/13194
< bitcoin-git> bitcoin/master fd96d54 Wladimir J. van der Laan: Merge #13194: Remove template matching and pseudo opcodes...
< bitcoin-git> bitcoin/master c814e2e Pieter Wuille: Remove template matching and pseudo opcodes...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/25d2df2aa988...fd96d54f39cf
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13341: Stop translating command line options (master...2018_05_notranslate_options) https://github.com/bitcoin/bitcoin/pull/13341
< bitcoin-git> bitcoin/master 25d2df2 MarcoFalke: Merge #13341: Stop translating command line options...
< bitcoin-git> bitcoin/master 3d4fa83 Wladimir J. van der Laan: Stop translating command line options...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60f0358b4a1e...25d2df2aa988
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13347: travis: Skip cache for lint stage (master...Mf1806-travisLintNoCache) https://github.com/bitcoin/bitcoin/pull/13347
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13346: doc: update bitcoin-dot-org links in release-process.md (master...release-process-links) https://github.com/bitcoin/bitcoin/pull/13346
< bitcoin-git> bitcoin/master 60f0358 MarcoFalke: Merge #13346: doc: update bitcoin-dot-org links in release-process.md...
< bitcoin-git> bitcoin/master 8310238 fanquake: doc: update bitcoin-dot-org links in release-process.md
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8a29ca823fb...60f0358b4a1e
< fanquake> Be good to get some more macOS testers for https://github.com/bitcoin/bitcoin/pull/12783
< bitcoin-git> [bitcoin] fanquake opened pull request #13346: doc: update bitcoin-dot-org links in release-process.md (master...release-process-links) https://github.com/bitcoin/bitcoin/pull/13346
< bitcoin-git> bitcoin/0.16 afc115d Wladimir J. van der Laan: doc: Add commits and authors to release notes for rc1...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/afc115d7535986f6c2bec3c3ad4ed0fe90d31f01
<@wumpus> blocked from bitcoin and bitcoin-core orgs
< Arvidt> The release notes for 0.16.1rc1 linked in the announcement email is pretty empty / in draft state (e.g. "0.16.x Example item"). I think it would be interesting for someone considering running RC version to have an overview what's new. https://github.com/bitcoin/bitcoin/blob/0.16/doc/release-notes.md
< provoostenator> Would this version change be the reason? https://github.com/bitcoin/bitcoin/commit/a8da482a8bc87ff26194612727d4a7b86b2fb60d
< wumpus> jonasschnelli: then again, if other qt5 applications work and bitcoin core doesn't, yes it's something we forget to do
< jonasschnelli> Last time I checked, Bitcoin-Core looks pretty bad on Linux/Win HIDPI
< jonasschnelli> fanquake: cfields sigs matches with mine (https://bitcoin.jonasschnelli.ch/build/634).. will push asap
< fanquake> cfields pushed some signed sigs up https://github.com/bitcoin-core/gitian.sigs/pull/712
< GitHub159> [bitcoin-detached-sigs] theuni closed pull request #6: 0.16.1: osx signatures for 0.16.1rc (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/6
< GitHub150> [bitcoin-detached-sigs] jonasschnelli opened pull request #6: 0.16.1: osx signatures for 0.16.1rc (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/6

2018-05-29

< bitcoin-git> [bitcoin] achow101 closed pull request #13289: [Qt] Re-setup args after translator setup to translate help text (master...qt-help-translations) https://github.com/bitcoin/bitcoin/pull/13289
< bitcoin-git> [bitcoin] laanwj closed pull request #13215: Travis: Build tests on Ubuntu 18.04 with docker (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13215
< bitcoin-git> bitcoin/master f8a29ca Wladimir J. van der Laan: Merge #13215: Travis: Build tests on Ubuntu 18.04 with docker...
< bitcoin-git> bitcoin/master 59e9688 Chun Kuan Lee: Travis: Build tests on Ubuntu 18.04 with docker
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3a8e3f480612...f8a29ca823fb
< bitcoin-git> [bitcoin] krab reopened pull request #12783: macOS: Disable AppNap (master...macos-disable-appnap) https://github.com/bitcoin/bitcoin/pull/12783
< bitcoin-git> [bitcoin] krab closed pull request #12783: macOS: Disable AppNap (master...macos-disable-appnap) https://github.com/bitcoin/bitcoin/pull/12783
< gribble> https://github.com/bitcoin/bitcoin/issues/13058 | [wallet] `createwallet` RPC - create new wallet at runtime by jnewbery · Pull Request #13058 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13340: doc: remove leftover check-doc documentation (master...move-check-doc) https://github.com/bitcoin/bitcoin/pull/13340
< bitcoin-git> bitcoin/master 3a8e3f4 Wladimir J. van der Laan: Merge #13340: doc: remove leftover check-doc documentation...
< bitcoin-git> bitcoin/master 93843f6 fanquake: doc: remove leftover check-doc documentation
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e08c130c25ed...3a8e3f480612
< bitcoin-git> [bitcoin] fanquake closed pull request #13320: Ensure gitian-build.sh uses bash (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13320
< bitcoin-git> bitcoin/master e08c130 Wladimir J. van der Laan: Merge #13320: Ensure gitian-build.sh uses bash...
< bitcoin-git> bitcoin/master f44a0eb Jeff Frontz: Ensure gitian-build.sh uses bash...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ac6315f44a8...e08c130c25ed
< gribble> https://github.com/bitcoin/bitcoin/issues/13340 | doc: remove leftover check-doc documentation by fanquake · Pull Request #13340 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #13340: doc: remove leftover check-doc documentation (master...move-check-doc) https://github.com/bitcoin/bitcoin/pull/13340
< bitcoin-git> [bitcoin] laanwj closed pull request #13281: test: Move linters to test/lint, add readme (master...Mf1805-qaLint) https://github.com/bitcoin/bitcoin/pull/13281
< bitcoin-git> [bitcoin] promag opened pull request #13339: wallet: Replace %w by wallet name in -walletnotify script (master...2018-05-walletnotify) https://github.com/bitcoin/bitcoin/pull/13339
< bitcoin-git> [bitcoin] laanwj closed pull request #13134: net: Add option `-enablebip61` to configure sending of BIP61 notifications (master...2018_05_optional_bip61) https://github.com/bitcoin/bitcoin/pull/13134
< bitcoin-git> bitcoin/master 87fe292 Wladimir J. van der Laan: doc: Mention disabling BIP61 in bips.md
< bitcoin-git> bitcoin/master 70d3541 Wladimir J. van der Laan: Merge #13134: net: Add option `-enablebip61` to configure sending of BIP61 notifications...
< bitcoin-git> bitcoin/master fe16dd8 Wladimir J. van der Laan: net: Add option `-enablebip61` to configure sending of BIP61 notifications...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fd0c2336a12...70d354131379
< bitcoin-git> [bitcoin] laanwj closed pull request #13273: Qt/Bugfix: fix handling default wallet with no name (master...2018/05/loadwallet_fix) https://github.com/bitcoin/bitcoin/pull/13273
< bitcoin-git> bitcoin/master 3fd0c23 Wladimir J. van der Laan: Merge #13273: Qt/Bugfix: fix handling default wallet with no name...
< bitcoin-git> bitcoin/master 13c3a65 João Barbosa: Qt/Bugfix: fix handling default wallet with no name
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56fe3dc235a0...3fd0c2336a12
< bitcoin-git> [bitcoin] laanwj closed pull request #13142: Separate IsMine from solvability (master...201804_separate_ismine_solvable) https://github.com/bitcoin/bitcoin/pull/13142
< bitcoin-git> bitcoin/master 4e91820 Pieter Wuille: Make IsMine stop distinguishing solvable/unsolvable
< bitcoin-git> bitcoin/master b5802a9 Pieter Wuille: Simplify IsMine logic
< bitcoin-git> bitcoin/master 6d714c3 Pieter Wuille: Make coincontrol use IsSolvable to determine solvability
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/a315b79ad2b8...56fe3dc235a0
< gribble> https://github.com/bitcoin/bitcoin/issues/13160 | wallet: Unlock spent outputs by promag · Pull Request #13160 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] harrymckinnon86 closed pull request #13338: Test (master...test) https://github.com/bitcoin/bitcoin/pull/13338
< bitcoin-git> [bitcoin] harrymckinnon86 opened pull request #13338: Test (master...test) https://github.com/bitcoin/bitcoin/pull/13338
< wumpus> even if you don't care about "use of Bitcoin Core as wallet" (like Trezor), it seems that other wallets would benefit from the same
< wumpus> I've always been surprised how little the hardware wallets vendors care about this, they just carve out their little space with their own proprietary protocols and software, instead of starting some bitcoin HSM working group
< wumpus> < mryandao> sounds like the painpoints alone warrant a workshop on integration of HSMs with Bitcoin <- I agree, it's something that could use more concentrated effort
< mryandao> sounds like the painpoints alone warrant a workshop on integration of HSMs with Bitcoin
< wumpus> we're not going to do low-level USB stuff in bitcoin core
< wumpus> (simply "gpg2 bitcoin-win-0.16-build.assert.gpg" in your 0.16.1rc1 directory should do it)
< wumpus> rm bitcoin-win-0.16-build.assert.sig && gpg2 --detach-sign bitcoin-win-0.16-build.assert or something like that

2018-05-28

< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13275: Qt: use [default wallet] as name for wallet with no name (master...2018/05/loadwallet_gui_name) https://github.com/bitcoin/bitcoin/pull/13275
< bitcoin-git> bitcoin/master a315b79 Wladimir J. van der Laan: Merge #13275: Qt: use [default wallet] as name for wallet with no name...
< bitcoin-git> bitcoin/master 2885c13 Jonas Schnelli: Qt: use [default wallet] as name for wallet with no name
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/14a4b4966361...a315b79ad2b8
< gribble> https://github.com/bitcoin/bitcoin/issues/13131 | Add Windows shutdown handler by ken2812221 · Pull Request #13131 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13300: qa: Initialize lockstack to prevent null pointer deref (master...Mf1805-qaLockDebug) https://github.com/bitcoin/bitcoin/pull/13300
< bitcoin-git> bitcoin/master 14a4b49 Wladimir J. van der Laan: Merge #13300: qa: Initialize lockstack to prevent null pointer deref...
< bitcoin-git> bitcoin/master fa9da85 MarcoFalke: qa: Initialize lockstack to prevent null pointer deref
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fb7731089ed2...14a4b4966361
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< wumpus> not even bitcoin-cli?
< bitcoin-git> [bitcoin] laanwj closed pull request #13295: docs: Update OpenBSD build instructions for OpenBSD 6.3 (master...openbsd-6.3) https://github.com/bitcoin/bitcoin/pull/13295
< bitcoin-git> bitcoin/master fb77310 Wladimir J. van der Laan: Merge #13295: docs: Update OpenBSD build instructions for OpenBSD 6.3...
< bitcoin-git> bitcoin/master 1680b8b practicalswift: docs: Update OpenBSD build instructions for OpenBSD 6.3
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f5a7733ff767...fb7731089ed2
< bitcoin-git> [bitcoin] laanwj closed pull request #13306: build: split warnings out of CXXFLAGS (master...debug_flags) https://github.com/bitcoin/bitcoin/pull/13306
< bitcoin-git> bitcoin/master f5a7733 Wladimir J. van der Laan: Merge #13306: build: split warnings out of CXXFLAGS...
< bitcoin-git> bitcoin/master 9e305b5 Cory Fields: build: split warnings out of CXXFLAGS...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/610f4dd719ad...f5a7733ff767
< gribble> https://github.com/bitcoin/bitcoin/issues/13306 | build: split warnings out of CXXFLAGS by theuni · Pull Request #13306 · bitcoin/bitcoin · GitHub
< luke-jr> hm, there must be something wrong. ps claims bitcoin-qt's SIZE is 37 GB :|
< bitcoin-git> [bitcoin] laanwj closed pull request #13336: [0.16.1] doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (0.16...windows-1804) https://github.com/bitcoin/bitcoin/pull/13336
< bitcoin-git> [bitcoin] fanquake opened pull request #13336: [0.16.1] doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (0.16...windows-1804) https://github.com/bitcoin/bitcoin/pull/13336
< gribble> https://github.com/bitcoin/bitcoin/issues/13246 | doc: Bump to Ubuntu Bionic 18.04 in build-windows.md by ken2812221 · Pull Request #13246 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.16 81bc982 Wladimir J. van der Laan: build: Bump version to 0.16.1...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/07fb2a6e166f...81bc9829cdaf
< bitcoin-git> bitcoin/0.16 b42c355 Wladimir J. van der Laan: qt: Pre-rc1 transifex pull...
< fanquake> provoostenator correct, https://github.com/bitcoin/bitcoin/tree/0.16
< gribble> https://github.com/bitcoin/bitcoin/issues/11658 | During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after by luke-jr · Pull Request #11658 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
< bitcoin-git> bitcoin/0.16 dcb13a0 MarcoFalke: qt: Update translations pre-rc1
< bitcoin-git> bitcoin/0.16 0eda98d Luke Dashjr: GUI: Allow generating Bech32 addresses with a legacy-address default...
< bitcoin-git> bitcoin/0.16 ea487f9 Luke Dashjr: GUI: Rephrase Bech32 checkbox text/tooltip...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/bfd1e923335e...07fb2a6e166f
< gribble> https://github.com/bitcoin/bitcoin/issues/13319 | [0.16.1] gui: Backport bech32 checkbox by MarcoFalke · Pull Request #13319 · bitcoin/bitcoin · GitHub
< * midnightmagic> will love whoever it is, forever, who removed boost entirely as a dependency for bitcoin. :)
< bitcoin-git> [bitcoin] eklitzke opened pull request #13335: Implement pinentry wrapper to unlock bitcoin wallet (master...pinentry) https://github.com/bitcoin/bitcoin/pull/13335
< 94KAACTBR> bitcoin/0.16 bb79aaf Jesse Cohen: Fix concurrency-related bugs in ActivateBestChain...
< gribble> https://github.com/bitcoin/bitcoin/issues/13317 | [0.16.1] Remaining backports by MarcoFalke · Pull Request #13317 · bitcoin/bitcoin · GitHub
< 94KAACTBR> bitcoin/0.16 0948153 Matt Corallo: Do not unlock cs_main in ABC unless we've actually made progress....
< 94KAACTBR> bitcoin/0.16 c71e535 Suhas Daftuar: Bugfix: ensure consistency of m_failed_blocks after reconsiderblock...
< 94KAACTBR> [bitcoin] laanwj pushed 9 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/50b2c9e0dfbe...bfd1e923335e
< 7YSAAYFCN> [bitcoin] laanwj closed pull request #13317: [0.16.1] Remaining backports (0.16...Mf1805-016ForBackport) https://github.com/bitcoin/bitcoin/pull/13317
< gribble> https://github.com/bitcoin/bitcoin/issues/12381 | Remove more boost threads by theuni · Pull Request #12381 · bitcoin/bitcoin · GitHub
< mryandao> oh, i just did an update today and it pains me to need to install that 100MB+ of libboost to compile bitcoin-core

2018-05-27

< jhfrontz> Anyone know of a specific distro/release that supports the Gitian build of bitcoin core?
< jhfrontz> So I re-installed Ubuntu 14.04.5 LTS and tried to do a Gitian build of Bitcoin Core. gitian-build.sh has the same issue as on Ubuntu 18.04 — it is trying to make some sort of modifications to /etc/sudoers (via dpkg) and is requesting an interactive resolution to a conflict — but that fails (presumably because stdin is internally redirected to /dev/null?).
< bitcoin-git> [bitcoin] kallewoof closed pull request #12869: BIP-178: Extend WIF format with key type (master...importmulti-wif-extended) https://github.com/bitcoin/bitcoin/pull/12869

2018-05-26

< gribble> https://github.com/bitcoin/bitcoin/issues/13324 | 0.05 BTC LIMITED GIVEAWAY · Issue #13324 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] glaksmono opened pull request #13322: Fixing texts in the "encrypt wallet" GUI process (master...bitcoin-gui-13245) https://github.com/bitcoin/bitcoin/pull/13322
< bitcoin-git> [bitcoin] glaksmono closed pull request #13321: Fixing texts in the "encrypt wallet" GUI process (master...bitcoin-13245) https://github.com/bitcoin/bitcoin/pull/13321
< bitcoin-git> [bitcoin] glaksmono opened pull request #13321: Fixing texts in the "encrypt wallet" GUI process (master...bitcoin-13245) https://github.com/bitcoin/bitcoin/pull/13321

2018-05-25

< gribble> https://github.com/bitcoin/bitcoin/issues/178 | Link with libpthread on Linux, required by libboost_thread. by wizeman · Pull Request #178 · bitcoin/bitcoin · GitHub
< jhfrontz> I'm trying to do a Gitian build of Bitcoin Core on a stock (just installed from a liveUSB) Ubuntu 18.04 distro using the instructions at https://github.com/bitcoin-core/docs/blob/master/gitian-building.md#initial-gitian-setup . I keep running into situations where gitian-build.sh (or one of the scripts it calls) need to do some sort of interactive edits (e.g.., asking for confirmation on a package installation/customization
< bitcoin-git> [bitcoin] jhfrontz opened pull request #13320: Ensure gitian-build.sh uses bash (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13320
< gribble> https://github.com/bitcoin/bitcoin/issues/12404 | Prune more aggressively during IBD by Sjors · Pull Request #12404 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13160 | wallet: Unlock spent outputs by promag · Pull Request #13160 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13192 | [tests] Fixed intermittent failure in p2p_sendheaders.py. by lmanners · Pull Request #13192 · bitcoin/bitcoin · GitHub

2018-05-24

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13319: gui: Backport bech32 checkbox (0.16...Mf1805-016ForBackportGui) https://github.com/bitcoin/bitcoin/pull/13319
< bitcoin-git> [bitcoin] TronBlack closed pull request #13318: Remove legacy verification (master...Remove-legacy-verification) https://github.com/bitcoin/bitcoin/pull/13318
< bitcoin-git> [bitcoin] TronBlack opened pull request #13318: Remove legacy verification (master...Remove-legacy-verification) https://github.com/bitcoin/bitcoin/pull/13318
< provoostenator> When I do "bitcoin-cli -config=/the/usual/place -datadir=/some/other/place getblockheight" it creates a folder /some/other/place/wallets
< wumpus> jonasschnelli: not into bitcoin core, I mean as external thing
< gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7759 | [WIP] rest: Stream entire utxo set by laanwj · Pull Request #7759 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13043 | [qt] OptionsDialog: add prune setting by Sjors · Pull Request #13043 · bitcoin/bitcoin · GitHub
< wumpus> well the bitcoin.conf is for human editing
< gribble> https://github.com/bitcoin/bitcoin/issues/12833 | [qt] move QSettings to bitcoin.conf where possible by Sjors · Pull Request #12833 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< wumpus> I'm ok with most solutions, except writing to bitcoin.conf
< gribble> https://github.com/bitcoin/bitcoin/issues/13043 | [qt] OptionsDialog: add prune setting by Sjors · Pull Request #13043 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13298 | Net: Random delays *per network group* to obfuscate transaction time by naumenkogs · Pull Request #13298 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12863 | mempool_persist.py failing in travis · Issue #12863 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12431 | Only call NotifyBlockTip when chainActive changes by jamesob · Pull Request #12431 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub
< jtimon> https://github.com/bitcoin/bitcoin/pull/12172 is a small thing, but it is a bugfix, perhaps it makes sense to backport it?
< gribble> https://github.com/bitcoin/bitcoin/issues/13317 | [0.16.1] Remainig backports by MarcoFalke · Pull Request #13317 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< gribble> https://github.com/bitcoin/bitcoin/issues/13317 | [0.16.1] Remainig backports by MarcoFalke · Pull Request #13317 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13317: [0.16.1] Remainig backports (0.16...Mf1805-016ForBackport) https://github.com/bitcoin/bitcoin/pull/13317
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add menu entry to open wallet by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13304: qa: Fix wallet_listreceivedby race (master...Mf1805-qaWalletRace) https://github.com/bitcoin/bitcoin/pull/13304
< bitcoin-git> bitcoin/master 610f4dd MarcoFalke: Merge #13304: qa: Fix wallet_listreceivedby race...
< bitcoin-git> bitcoin/master fa865ef MarcoFalke: qa: Fix wallet_listreceivedby race
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8be43413368...610f4dd719ad
< bitcoin-git> [bitcoin] FeedTheWeb opened pull request #13315: remove ZMQ message limit (master...master) https://github.com/bitcoin/bitcoin/pull/13315
< bitcoin-git> bitcoin/master f8be434 Wladimir J. van der Laan: Merge #13284: gui: fix visual "overflow" of amount input....
< bitcoin-git> [bitcoin] laanwj closed pull request #13284: gui: fix visual "overflow" of amount input. (master...ui_amount_overflow_fix) https://github.com/bitcoin/bitcoin/pull/13284
< bitcoin-git> bitcoin/master 5f3cbde Brandon Ruggles: Increased max width of amount field to prevent number overflow bug.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/536120ec39be...f8be43413368
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13291: test: Don't include torcontrol.cpp into the test file (master...tor-reply) https://github.com/bitcoin/bitcoin/pull/13291
< bitcoin-git> bitcoin/master 536120e MarcoFalke: Merge #13291: test: Don't include torcontrol.cpp into the test file...
< bitcoin-git> bitcoin/master 97c112d Ben Woosley: Declare TorReply parsing functions in torcontrol_tests...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a9b6957383a7...536120ec39be
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13314: Fix FreeBSD build by including utilstrencodings.h (master...2018_05_freebsd_build) https://github.com/bitcoin/bitcoin/pull/13314
< bitcoin-git> bitcoin/master a9b6957 MarcoFalke: Merge #13314: Fix FreeBSD build by including utilstrencodings.h...
< bitcoin-git> bitcoin/master c865ee1 Wladimir J. van der Laan: Fix FreeBSD build by including utilstrencodings.h...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6378eef18f61...a9b6957383a7
< gribble> https://github.com/bitcoin/bitcoin/issues/13284 | gui: fix visual "overflow" of amount input. by brandonrninefive · Pull Request #13284 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12624 | Release schedule for 0.17.0 · Issue #12624 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13111 | [WIP] Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13063: Use shared pointer to retain wallet instance (master...2018-04-wallet-sharedptr) https://github.com/bitcoin/bitcoin/pull/13063
< bitcoin-git> bitcoin/master 6378eef Wladimir J. van der Laan: Merge #13063: Use shared pointer to retain wallet instance...
< bitcoin-git> bitcoin/master 80b4910 João Barbosa: wallet: Use shared pointer to retain wallet instance
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c41b6008079...6378eef18f61
< gribble> https://github.com/bitcoin/bitcoin/issues/13160 | wallet: Unlock spent outputs by promag · Pull Request #13160 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
< fanquake> kallewoof I think https://github.com/bitcoin/bitcoin/projects/8 is your best bet for now
< kallewoof> "bitcoin/bitcoin/8" doesn't seem particularly permanent.
< kallewoof> Is there a good link to the high prio list? I always have a hard time finding it and keep a tab of https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+project%3Abitcoin%2Fbitcoin%2F8 open, but not sure that URL changes at some point.
< bitcoin-git> [bitcoin] laanwj closed pull request #13246: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13246
< bitcoin-git> bitcoin/master 5c41b60 Wladimir J. van der Laan: Merge #13246: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md...
< bitcoin-git> bitcoin/master 9d4f942 Chun Kuan Lee: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7f4db9a7c354...5c41b6008079
< bitcoin-git> [bitcoin] laanwj closed pull request #13253: [0.16] Further Backports (0.16...0-16-further-backports) https://github.com/bitcoin/bitcoin/pull/13253
< gribble> https://github.com/bitcoin/bitcoin/issues/13246 | doc: Bump to Ubuntu Bionic 18.04 in build-windows.md by ken2812221 · Pull Request #13246 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub

2018-05-23

< bitcoin-git> [bitcoin] laanwj opened pull request #13314: Fix FreeBSD build by including utilstrencodigs.h (master...2018_05_freebsd_build) https://github.com/bitcoin/bitcoin/pull/13314
< gribble> https://github.com/bitcoin/bitcoin/issues/13253 | [0.16] Further Backports by fanquake · Pull Request #13253 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13151: net: Serve blocks directly from disk when possible (master...2018_05_direct_from_disk) https://github.com/bitcoin/bitcoin/pull/13151
< bitcoin-git> bitcoin/master 7f4db9a Wladimir J. van der Laan: Merge #13151: net: Serve blocks directly from disk when possible...
< bitcoin-git> bitcoin/master 0bf4318 Wladimir J. van der Laan: net: Serve blocks directly from disk when possible...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c2a41a9fc3c...7f4db9a7c354
< bitcoin-git> [bitcoin] laanwj closed pull request #13011: Cache witness hash in CTransaction (master...Mf1804-cacheWitnessHash) https://github.com/bitcoin/bitcoin/pull/13011
< bitcoin-git> bitcoin/master 3c2a41a Wladimir J. van der Laan: Merge #13011: Cache witness hash in CTransaction...
< bitcoin-git> bitcoin/master fac1223 MarcoFalke: Cache witness hash in CTransaction
< bitcoin-git> bitcoin/master faab55f MarcoFalke: Make CMutableTransaction constructor explicit...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b9551d3663fc...3c2a41a9fc3c
< bitcoin-git> [bitcoin] laanwj closed pull request #10757: RPC: Introduce getblockstats to plot things (master...b15-rpc-plotter) https://github.com/bitcoin/bitcoin/pull/10757
< bitcoin-git> bitcoin/master 4cbfb6a Jorge Timón: Tests: Test new getblockstats RPC...
< bitcoin-git> bitcoin/master 35e77a0 Jorge Timón: RPC: Introduce getblockstats
< bitcoin-git> bitcoin/master cda8e36 Jorge Timón: Refactor: RPC: Separate GetBlockChecked() from getblock()...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/6916024768ec...b9551d3663fc
< bitcoin-git> [bitcoin] jamesob reopened pull request #13200: Process logs in a separate thread (master...2018-05-asynclog) https://github.com/bitcoin/bitcoin/pull/13200
< bitcoin-git> [bitcoin] practicalswift opened pull request #13312: docs: Add a note about the source code filename naming convention (master...lowercase-filenames) https://github.com/bitcoin/bitcoin/pull/13312
< bitcoin-git> [bitcoin] jtimon opened pull request #13311: Don't edit Chainparams after initialization (master...b17-regtest-only-params) https://github.com/bitcoin/bitcoin/pull/13311
< gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into parallel validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | Add menu entry to open wallet by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< jtimon> I think it should be almost done, but I'm temped to move https://github.com/bitcoin/bitcoin/pull/10757 to a new PR just to avoid the unicorns...
< bitcoin-git> [bitcoin] promag opened pull request #13310: Report progress in ReplayBlocks while rolling forward (master...2018-05-replayblocks-progress) https://github.com/bitcoin/bitcoin/pull/13310
< gribble> https://github.com/bitcoin/bitcoin/issues/11658 | During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after by luke-jr · Pull Request #11658 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12404 | Prune more aggressively during IBD by Sjors · Pull Request #12404 · bitcoin/bitcoin · GitHub
< booyah> eshays: let of known on #bitcoin if all worked out, see you
< booyah> eshays: sorry, forgot you are on Windows. In this case just pastebin some portion of debug.log from end (check if there are no confidentail IP addresses or btc addresses). After that, imo, shut down the node, make a copy of entire data-directory of bitcoin to have snapshot of corrupted files, and start again to see if it's the same
< eshays> hey guys, my bitcoin core program didnt close correctly and upon relaunch im stuck on replaying block 0%
< bitcoin-git> [bitcoin] martinus opened pull request #13309: Faster unit tests: directloy operate with CMutableTransaction (master...SignSignature-with-CMutableTransaction) https://github.com/bitcoin/bitcoin/pull/13309
< bitcoin-git> [bitcoin] ken2812221 closed pull request #13308: Qt594 (master...qt594) https://github.com/bitcoin/bitcoin/pull/13308
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13308: Qt594 (master...qt594) https://github.com/bitcoin/bitcoin/pull/13308
< bitcoin-git> [bitcoin] achow101 opened pull request #13307: Replace coin selection fallback strategy with Single Random Draw (master...srd-fallback) https://github.com/bitcoin/bitcoin/pull/13307

2018-05-22

< bitcoin-git> [bitcoin] theuni opened pull request #13306: build: split warnings out of CXXFLAGS (master...debug_flags) https://github.com/bitcoin/bitcoin/pull/13306
< bitcoin-git> [bitcoin] jimpo closed pull request #13305: Refactor: encapsulate mapBlockIndex within validation.cpp (master...validation-globals) https://github.com/bitcoin/bitcoin/pull/13305
< bitcoin-git> [bitcoin] jimpo opened pull request #13305: Refactor: encapsulate mapBlockIndex within validation.cpp (master...validation-globals) https://github.com/bitcoin/bitcoin/pull/13305
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13304: qa: Fix wallet_listreceivedby race (master...Mf1805-qaWalletRace) https://github.com/bitcoin/bitcoin/pull/13304
< gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13282: trivial: Mark overrides as such. (master...mark-override) https://github.com/bitcoin/bitcoin/pull/13282
< bitcoin-git> bitcoin/master 6916024 MarcoFalke: Merge #13282: trivial: Mark overrides as such....
< bitcoin-git> bitcoin/master 60ebc7d Daniel Kraft: trivial: Mark overrides as such....