< jonatack>
theStack: luke-jr: i proposed to bring bitcoinacks, with pierre_rochard's permission, into https://github.com/bitcoin-core/ to see more attention
< theStack>
i think jonatack proposed to run it on bitcoin.org recently if i remember correctly; any plans about that? or is the idea that people spin it up locally? (should also be quite easy thanks to docker)
< theStack>
that's great news! i wondered recently what happened to bitcoin-acks.com
< bitcoin-git>
bitcoin/master 5d1377b Russell Yanofsky: build: multiprocess autotools changes
< vasild>
fanquake: https://travis-ci.org/github/bitcoin/bitcoin/builds/689316499 that is the result from the initial run after PR was opened. Afterwards I push-f'ed 2 times, hopefully resolving those failures (first push -f) and rebasing (second push -f)
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19028: test: Set -logthreadnames in unit tests (master...2005-testThreadNames) https://github.com/bitcoin/bitcoin/pull/19028
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #19006: rpc: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git>
bitcoin/master faf45d1 MarcoFalke: http: Avoid crash when g_thread_http was never started
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19020: net: Use C++11 member initialization in protocol (master...2005-netCxx11MemberInit) https://github.com/bitcoin/bitcoin/pull/19020
< bitcoin-git>
[bitcoin] luke-jr opened pull request #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.20...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19019
< bitcoin-git>
[bitcoin] limpbrains opened pull request #19018: docs: fixing description of the field sequence in walletcreatefundedpsbt RPC method (master...walletcreatefundedpsbt-fix-docs) https://github.com/bitcoin/bitcoin/pull/19018
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
< bitcoin-git>
[bitcoin] jnewbery opened pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
< bitcoin-git>
[bitcoin] h2o10 opened pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19006: http: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
< bitcoin-git>
[bitcoin] kcalvinalvin opened pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC… (master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
< bitcoin-git>
[bitcoin] shesek opened pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
< shesek>
I'm afraid that I'm probably not the the right person for the job, but I will happily help with testing. :) but yes, sorry, I know that making these requests without offering any help implementing them is not very useful. bitcoin core has plenty of features that could be added if someone with the expertise and time prioritized them
2020-05-17
< shesek>
does bitcoin-qt not show the fee of confirmed incoming transactions (ie where the spent prevouts are no longer in the utxo set)?
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #19001: qt: bugfix unsupported QLocale languages (master...202005-bugfix-qlocale) https://github.com/bitcoin/bitcoin/pull/19001
< jonatack>
tryphe: on github projects with a small number of collaborators i think they are fun; on more widely-watched ones like bitcoin core i tend to not use them to avoid it turning into a social media or slack feed. using an emoji inside a comment, sure. worked more ideas into the doc from all three of you, thanks!
< tryphe>
when getting into bitcoin PR review i feel like there's this -almost- unscalable mountain in front of you; semi-scalable in terms of "things that i can actually review without much historical bitcoin knowlegde" (NATPMP for example, that was easy, but almost straightforward enough that it requires no comments), but also unscalable parts in terms of other PRs where the motivation was so ingenius that trying to review it almost seems like a
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18994: tests: Add fuzzing harnesses for functions in script/ (master...fuzzers-script-slash) https://github.com/bitcoin/bitcoin/pull/18994
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #18993: qt: increase console command max lenght (master...202005-increase-console-command) https://github.com/bitcoin/bitcoin/pull/18993
< bitcoin-git>
[bitcoin] 10xcryptodev opened pull request #18992: qt: add sign and verify message support to AddressBookPage (master...202005-sign-message-ui) https://github.com/bitcoin/bitcoin/pull/18992
< bitcoin-git>
[bitcoin] naumenkogs opened pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18990: log: Properly log txs rejected from mempool (master...2005-logMempoolRej) https://github.com/bitcoin/bitcoin/pull/18990
< bitcoin-git>
[bitcoin] ariard opened pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
< bitcoin-git>
[bitcoin] ariard opened pull request #18987: RFC: Introducing Watchdog, a cross-layer anomaly detection module (master...2020-05-rfc-watchdog) https://github.com/bitcoin/bitcoin/pull/18987
< bitcoin-git>
[bitcoin] rajarshimaitra opened pull request #18986: Adds a new --notimeout flag in test_framework. (master...notimeout-flag) https://github.com/bitcoin/bitcoin/pull/18986
< bitcoin-git>
[bitcoin] kallewoof closed pull request #18981: doc: add note about considering making issues over TODO source code comments (master...202005-no-todo) https://github.com/bitcoin/bitcoin/pull/18981
< bitcoin-git>
[bitcoin] jb55 opened pull request #18985: bloom: use Span instead of std::vector for `insert` and `contains` [ZAP3] (master...2020-05-bloom-span) https://github.com/bitcoin/bitcoin/pull/18985
< jonatack>
I wonder if it would make any sense to bring bitcoinacks, with pierre_rochard's permission of course, into https://github.com/bitcoin-core/ to see more attention
< bitcoin-git>
[bitcoin] tarboss closed pull request #18961: gui: remove assert in walletcontroller & run setparent in gui-qt main thread (master...master) https://github.com/bitcoin/bitcoin/pull/18961
< gribble>
https://github.com/bitcoin/bitcoin/issues/18413 | script: prevent UB when computing abs value for num opcode serialize by pierreN · Pull Request #18413 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake merged pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git>
bitcoin/master e2f6866 fanquake: Merge #18975: test: Remove const to work around compiler error on xenial
< bitcoin-git>
bitcoin/master 050e2ee Wladimir J. van der Laan: test: Remove const to work around compiler error on xenial
< MarcoFalke>
And in reply to "removing boost should not be a goal". I think I disagree. Most of boost seems unmaintained at this point. For example the bug that crashed Bitcoin Core was reported to upstream with steps to reproduce and even a fix. I am still waiting for a reply...
< wumpus>
luke-jr talks about a security vulnerability importing data from a git repository above the bitcoin one, this can be avoided by checking in genbuild that we're really in a git repo right?
< gribble>
https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] laanwj merged pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
< bitcoin-git>
bitcoin/master 553bb3f Wladimir J. van der Laan: Merge #18962: net processing: Only send a getheaders for one block in an I...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git>
[bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974