<bitcoin-git>
[bitcoin] fanquake merged pull request #31327: doc: Correct PR Review Club frequency from weekly to monthly (master...fix-pr-club-frequency) https://github.com/bitcoin/bitcoin/pull/31327
<bitcoin-git>
bitcoin/master 637f437 Gabriele Bocchi: doc: remove PR Review Club frequency
<bitcoin-git>
bitcoin/master 15c1f47 merge-script: Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from we...
<bitcoin-git>
[bitcoin] kevkevinpal opened pull request #31328: test: locking -testdatadir when not specified and then deleting lock and dir at end of test (master...lockTestDataDir) https://github.com/bitcoin/bitcoin/pull/31328
2024-11-19
<bitcoin-git>
[bitcoin] GabrieleBocchi opened pull request #31327: doc: Correct PR Review Club frequency from weekly to monthly (master...fix-pr-club-frequency) https://github.com/bitcoin/bitcoin/pull/31327
<bitcoin-git>
[bitcoin] fanquake opened pull request #31323: guix: swap `moreutils` for just `sponge` (master...moreutils_just_sponge) https://github.com/bitcoin/bitcoin/pull/31323
<bitcoin-git>
[bitcoin] Sjors opened pull request #31318: Drop script_pub_key arg from createNewBlock (master...2024/11/no-script_pub_key) https://github.com/bitcoin/bitcoin/pull/31318
<bitcoin-git>
[bitcoin] vasild opened pull request #31316: fuzz: set the output argument of FuzzedSock::Accept() (master...fuzzedsock_accept) https://github.com/bitcoin/bitcoin/pull/31316
<bitcoin-git>
[bitcoin] TheCharlatan opened pull request #31313: refactor: Clamp worker threads in ChainstateManager constructor (master...chainstatemanagerArgs) https://github.com/bitcoin/bitcoin/pull/31313
<bitcoin-git>
[bitcoin] sipsorcery closed pull request #31311: Simplify constructor in fuzz test to help msvc compiler frontend parser. (master...fix-fuzz-msvc) https://github.com/bitcoin/bitcoin/pull/31311
<bitcoin-git>
[bitcoin] BrandonOdiwuor opened pull request #31312: test: run functional tests from ctest (master...ctest-functional-test) https://github.com/bitcoin/bitcoin/pull/31312
<bitcoin-git>
[bitcoin] sipsorcery opened pull request #31311: Simplify constructor in fuzz test to help msvc compiler frontend parser. (master...fix-fuzz-msvc) https://github.com/bitcoin/bitcoin/pull/31311
2024-11-17
<bitcoin-git>
[bitcoin] hebasto opened pull request #31308: ci, iwyu: Treat warnings as errors for specific targets (master...241117-force-iwyu) https://github.com/bitcoin/bitcoin/pull/31308
<bitcoin-git>
[bitcoin] hebasto opened pull request #31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC (master...241117-msvc) https://github.com/bitcoin/bitcoin/pull/31307
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #31302: refactor: spanify DecodeBits, use constexpr std::array instead of vector (master...refactor-spanify-DecodeBits) https://github.com/bitcoin/bitcoin/pull/31302
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #31301: refactor: covert ContainsNoNUL to ContainsNUL (master...refac-avoid-double-negative-ContainsNUL) https://github.com/bitcoin/bitcoin/pull/31301
2024-11-16
<bitcoin-git>
[bitcoin] hebasto opened pull request #31300: depends: Update minimum required CMake version (master...241116-deps-cmake) https://github.com/bitcoin/bitcoin/pull/31300
2024-11-15
<bitcoin-git>
[bitcoin] adamandrews1 opened pull request #31298: rpc: combinerawtransaction now rejects unmergeable transactions (master...combinerawtransaction-check) https://github.com/bitcoin/bitcoin/pull/31298
<bitcoin-git>
[bitcoin] furszy closed pull request #31291: test: group executed tests within the same directory (master...2024_test_global_path) https://github.com/bitcoin/bitcoin/pull/31291
<bitcoin-git>
[bitcoin] Sjors opened pull request #31297: mining: add early return to waitTipChanged() (master...2024/11/waittipchanged) https://github.com/bitcoin/bitcoin/pull/31297
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #31296: wallet: Translate [default wallet] string in progress messages (master...pr/dtran) https://github.com/bitcoin/bitcoin/pull/31296
<bitcoin-git>
[bitcoin] maflcko opened pull request #31295: refactor: Prepare compile-time check of bilingual format strings (master...2411-trans-fmt-prepare) https://github.com/bitcoin/bitcoin/pull/31295
<sipa>
i'm philosophically opposed to supporting a model that i consider harmful to bitcoin
<rodarmor>
I wrote a script to build an mdbook from the markdown docs in bitcoin/bitcoin. It's a bit of a mess, and uses Rust to generate the docs, so it's not really fit to merge in its current state, but it's pretty nice.
<bitcoin-git>
[bitcoin] casey opened pull request #31292: Add `contrib/justfile` containing useful development workflow commands. (master...justfile) https://github.com/bitcoin/bitcoin/pull/31292
<bitcoin-git>
[bitcoin] furszy opened pull request #31291: test: add global time to place exec tests within the same dir (master...2024_test_global_path) https://github.com/bitcoin/bitcoin/pull/31291
<bitcoin-git>
[gui-qml] pablomartin4btc opened pull request #433: Persist proxy settings to settings.json (main...qml-proxy-settings-persistence) https://github.com/bitcoin-core/gui-qml/pull/433
<vasild>
achow101: I guess that once legacy wallet is removed (in 29?) softwares that use Bitcoin Core's wallet but don't support descriptor wallets will have to stick to v28?
<gribble>
https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
<jonatack>
Looks like some of the hash rate graphs on https://bitcoin.sipa.be/ have y-values that go off the chart e.g. are too high to be displayed (thank you for maintaining them!)
<bitcoin-git>
[bitcoin] fanquake merged pull request #31235: addrman: cap the `max_pct` to not exceed the maximum number of addresses (master...2024-11-fuzz-fix-connman-getaddresses) https://github.com/bitcoin/bitcoin/pull/31235
<bitcoin-git>
bitcoin/master 36f5eff merge-script: Merge bitcoin/bitcoin#31235: addrman: cap the `max_pct` to not exceed the ...
<bitcoin-git>
bitcoin/master 9c5775c brunoerg: addrman: cap the `max_pct` to not exceed the maximum number of addresses
<bitcoin-git>
[bitcoin] maflcko opened pull request #31282: refactor: Make node_id a const& in RemoveBlockRequest (master...2411-const-ref) https://github.com/bitcoin/bitcoin/pull/31282
<vasild>
lightlike: laanwj: wrt #31223, what about printing the workaround in the error message? Currently when bind fails it would print: "Unable to bind to 127.0.0.1:8334 on this computer. Bitcoin Core is probably already running.", what about changing it to (if that is the onion bind): "Unable to bind to 127.0.0.1:8334 on this computer. Bitcoin Core is probably already running. Use
<bitcoin-git>
[bitcoin] fanquake merged pull request #31267: refactor: Drop deprecated space in operator""_mst (master...2411-deprecated-literal-operator) https://github.com/bitcoin/bitcoin/pull/31267
<bitcoin-git>
bitcoin/master faf2162 MarcoFalke: refactor: Drop deprecated space in operator""_mst
<bitcoin-git>
bitcoin/master 9a8e5ad merge-script: Merge bitcoin/bitcoin#31267: refactor: Drop deprecated space in operator""...
<bitcoin-git>
[bitcoin] maflcko opened pull request #31267: refactor: Drop deprecated space in operator""_mst (master...2411-deprecated-literal-operator) https://github.com/bitcoin/bitcoin/pull/31267
<bitcoin-git>
[bitcoin] secp512k2 opened pull request #31259: doc: Fix missing comma in JSON example in REST-interface.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/31259
<laanwj>
@libera_irc_timothy:bitcoin.ninja: correct, joinmarket doesn't support descriptor wallets :( if you have problems compiling bdb, i'd recommend trying bdb 5.x (easiest to install it from your distro) before passing any scary flags to bdb 4.8 build
<bitcoin-git>
[bitcoin] naiyoma closed pull request #31256: feature: RPC show decompiled P2SH redeemScript and P2WSH witnessScript (master...feature/rpc-show-redeemscript-in-P2WSH-and-P2SH) https://github.com/bitcoin/bitcoin/pull/31256
<bitcoin-git>
[bitcoin] naiyoma opened pull request #31256: feature: RPC show decompiled P2SH redeemScript and P2WSH witnessScript (master...feature/rpc-show-redeemscript-in-P2WSH-and-P2SH) https://github.com/bitcoin/bitcoin/pull/31256
<bitcoin-git>
[bitcoin] fanquake closed pull request #31255: contrib: correct default build path in man pages (master...20241108-manpages) https://github.com/bitcoin/bitcoin/pull/31255
<bitcoin-git>
[bitcoin] rkrux opened pull request #31255: contrib: correct default build path in man pages (master...20241108-manpages) https://github.com/bitcoin/bitcoin/pull/31255
<bitcoin-git>
[bitcoin] polespinasa opened pull request #31252: rpc: print P2WSH redeemScript in getrawtransaction (master...p2wsh_redeem) https://github.com/bitcoin/bitcoin/pull/31252
<bitcoin-git>
[bitcoin] furszy opened pull request #31251: test: report a more detailed failure during utf8 response decoding (master...2024_test_report_invalid_response) https://github.com/bitcoin/bitcoin/pull/31251
<bitcoin-git>
[bitcoin] achow101 opened pull request #31250: wallet: Disable creating and loading legacy wallets (master...disable-legacy-wallets) https://github.com/bitcoin/bitcoin/pull/31250
<bitcoin-git>
[bitcoin] achow101 opened pull request #31249: test: Add combinerawtransaction test to rpc_createmultisig (master...combinerawtx-test) https://github.com/bitcoin/bitcoin/pull/31249
<bitcoin-git>
[bitcoin] achow101 opened pull request #31248: test: Rework wallet_migration.py to use previous releases (master...migratewallet-prev-rels) https://github.com/bitcoin/bitcoin/pull/31248
<bitcoin-git>
[bitcoin] achow101 opened pull request #31243: descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` (master...descriptor-direct-fill) https://github.com/bitcoin/bitcoin/pull/31243
<bitcoin-git>
[bitcoin] achow101 opened pull request #31242: wallet, desc spkm: Return SigningProvider only if we have the privkey (master...wallet-signingprov-no-h) https://github.com/bitcoin/bitcoin/pull/31242
<bitcoin-git>
[bitcoin] furszy opened pull request #31241: wallet: remove BDB dependency from wallet migration benchmark (master...2024_bench_migration_remove_bdb_dependency) https://github.com/bitcoin/bitcoin/pull/31241
<josie>
stickies-v: we had discussed not running master vs PR branch on each run to save compute, but ultimately felt it was better to just accept the compute so that we have more guarantees its an apples to apples comparison (like changing bitcoin.conf options)
<josie>
stickies-v: that should be fixed soon (tm). regarding master changing, the idea is we will only sync benchcoin up with bitcoin-core master manually, once weve got agreement in the WG to choose a new base to benchmark against. long term, wed like to make it fully parameterized where you can pick a specific commit to bench your PR against (master at a certain point in time, another PR, etc)
<stickies-v>
josie: in https://github.com/bitcoin-dev-tools/benchcoin, it seems `results.json` only contains a run for PR head. Since `master` is ~going to be different for each PR, doing a run on `master` too might be helpful to isolate effects from other recent commits? Then again, doubles the compute for what will presumably be heavy workloads, so might not be worth the trade off. Just wondering what your thoughts are, i guess
<kanzure>
maybe post a question publicly and ask if anyone was using just the bitcoin-core-dev announcement list specifically, or thinks it should continue to exist, i would hate to break something important
<achow101>
and the announcements occur in a ton of other places too, including bitcoin-dev
<kanzure>
oh right, it occurs to me that bitcoin-core-dev is not supported on gnusha.org/url at the moment, does anyone have strong opinions about this. announcement emails always went out to bitcoin-dev AFAIK so they are captured there at least.
<kanzure>
lists.linuxfoundation.org is no more and is no longer hosting the mailing list static archives at this time (not just for bitcoin-dev but ~everything including some LKML stuff?)
<achow101>
#topic bitcoin-dev mailing list archive links (kanzure)
<gribble>
https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
<josie>
next will be rebasing the bitcoin core PRs on top of that. for a list of the PRs / status, im keeping the tracking issue up to date (bitcoin/bitcoin#28536)
<gribble>
https://github.com/bitcoin/bitcoin/issues/1519 | GUI: change language selection format to "language - country (locale name)" by Diapolo · Pull Request #1519 · bitcoin/bitcoin · GitHub
<josie>
ive been incorporating all of the review comments / feedback from coredev on the bitcoin-core/secp256k1#1519, hoping to finish that this week
<josie>
we have a workflow where someone can take their branch and open it as a PR against https://github.com/bitcoin-dev-tools/benchcoin and this will automatically kick off a benchmark and publish the final results as artifacts on the PR
<kanzure>
#proposedmeetingtopic bitcoin-dev mailing list archive links
<bitcoin-git>
[bitcoin] edilmedeiros opened pull request #31240: RFC: doc: Fix dead links to mailing list archives (master...fix-mailing-list-links) https://github.com/bitcoin/bitcoin/pull/31240
<bitcoin-git>
[bitcoin] vasild opened pull request #31239: test: clarify log messages when handling SOCKS5 proxy connections (master...socks5proxy_log) https://github.com/bitcoin/bitcoin/pull/31239