2019-04-11

< emilr> sorry, what I meant is that bitcoin core 0.17 has 120 hardcoded onion peers
< bitcoin-git> [bitcoin] jonatack opened pull request #15792: doc: describe onlynet option in doc/tor.md (master...add-onlynet-option-to-tor-docs) https://github.com/bitcoin/bitcoin/pull/15792
< bitcoin-git> [bitcoin] laanwj opened pull request #15791: [do not merge] net: Hardcoded seeds update for 0.18 (master...2019_04_hardcoded_seeds_update) https://github.com/bitcoin/bitcoin/pull/15791
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency (master...pr/link2) https://github.com/bitcoin/bitcoin/pull/15639
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f6120d40d583...c536dfbcb00f
< bitcoin-git> bitcoin/master fbc6bb8 Russell Yanofsky: bitcoin-wallet tool: Drop MakeChain calls
< bitcoin-git> bitcoin/master b874747 Russell Yanofsky: Remove access to node globals from wallet-linked code
< bitcoin-git> bitcoin/master 78a2fb5 Russell Yanofsky: bitcoin-wallet tool: Drop libbitcoin_server.a dependency
< emilr> most connections timeout at version handshake, takes about 10s for verack plus network latency, if bitcoin tor nodes run with the default timeout then you're out of luck
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15728: [wallet] Refactor relay transactions (master...2019_03_refactor_relay_transactions) https://github.com/bitcoin/bitcoin/pull/15728
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a135fbe5b30...f6120d40d583
< bitcoin-git> bitcoin/master 7a9046e John Newbery: [wallet] Refactor CWalletTx::RelayWalletTransaction()
< bitcoin-git> bitcoin/master f6120d4 MeshCollider: Merge #15728: [wallet] Refactor relay transactions
< jonasschnelli> Using obfuscation key for /btc/data/bitcoin/blocks/index: 0000000000000000
< wumpus> it does not relate to bip38 in any way; if anything, most people involved with bitcoin dev really dislike bip38 and it's per-key encryption
< kallewoof> Does the encryptwallet feature in bitcoin core relate to bip 38 in any way, or do they just look similar? It looks like it is basically doing the same thing but with scrypt replaced.
< emilr> I'll increase -timeout and wipe peers.dat to see if it makes much of a difference, I guess bitcoin needs to be more agressive when it has a limited number of peers
< emilr> gmaxwell: I was under the impression it would fetch all peers regardless of net but it did indeed discover some peers, I see 190 different .onions in two weeks, I think what happened is that bitcoin gave up on a lot of those peers after few failures but failure to connect is a normality in the tor land
< emilr> onlynet=onion and bitcoin user is blocked from making connections to the clearnet
< emilr> wumpus: sed -e 's|./bitcoin-cli|ANYTHING -you -want|g' banlist.cli.txt
< emilr> speaking of seeds/peers I have bitcoin running in an isolated environment: it can't connect to anything except .onions and it has some peers added with addnode, the behaviour that I'm seeing is that bitcoind does not learn about other peers from its existing ones, possibly because dns seeds fail, the expected behaviour is that bitcoin learns about other peers from it's existing ones (the ones
< bitcoin-git> [bitcoin] benthecarman opened pull request #15790: [0.18] backport #15754 (0.18...0.18) https://github.com/bitcoin/bitcoin/pull/15790
< wumpus> (it could still default to ./bitcoin-cli ofc)
< wumpus> gmaxwell: for me it would be convenient if banlist.cli.txt had ${BITCOIN_CLI} or something on every line instead of ./bitcoin-cli, and allowed it to be overridden, for example to point to a custom bitcoin-cli path or providing a -datadir/-conf argument
< dongcarl> gmaxwell: oh like connects to a bitcoin node and briefly get some other peers we can connect to from it then say bye?
< dongcarl> Oh I'm guessing the last time you tried to remove this, bitcoin only had support for SOCK4 and couldn't resolve thru the normal proxy?

2019-04-10

< jnewbery> Error! Initial build successful, but not enough time remains to run later build stages and tests. Please manually re-run this job by using the travis restart button or asking a bitcoin maintainer to restart. The next run should not time out because the build cache has been saved.
< bitcoin-git> [bitcoin] jnewbery reopened pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15788: test: Unify testing setups for fuzz, bench, and unit tests (master...1904-testUnify) https://github.com/bitcoin/bitcoin/pull/15788
< bitcoin-git> [bitcoin] jnewbery closed pull request #15778: [wallet] Move maxtxfee from node to wallet (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< dongcarl> wumpus: I see your comments here: https://github.com/bitcoin/bitcoin/pull/6053#issuecomment-128671852
< bitcoin-git> [bitcoin] laanwj merged pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638
< bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/e3a0688f8275...6a135fbe5b30
< bitcoin-git> bitcoin/master fdf8888 John Newbery: [build] Move CheckTransaction from lib_server to lib_consensus
< bitcoin-git> bitcoin/master 4a75c9d John Newbery: [build] Move policy settings to new src/policy/settings unit
< bitcoin-git> bitcoin/master 1acc61f John Newbery: [build] Move rpc utility methods to rpc/util
< bitcoin-git> [bitcoin] ariard opened pull request #15784: rpc: Remove dependency on interfaces::Chain in SignTransaction (master...2019-04-remove-chain-sign-tx-utility) https://github.com/bitcoin/bitcoin/pull/15784
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15783: Remove braces previously used for locks (master...unused-braces) https://github.com/bitcoin/bitcoin/pull/15783
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e82f6ad6f270...e3a0688f8275
< bitcoin-git> bitcoin/master c968780 r8921039: [docs] fix comment: the return value of findFork is _not_ an ancestor when...
< bitcoin-git> bitcoin/master e3a0688 MarcoFalke: Merge #15659: [docs] fix findFork comment
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15659: [docs] fix findFork comment (master...fix_findFork_comment) https://github.com/bitcoin/bitcoin/pull/15659
< bitcoin-git> [bitcoin] Bushstar opened pull request #15783: Remove braces previously used for locks (master...unused-braces) https://github.com/bitcoin/bitcoin/pull/15783
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c022e8ac401...e82f6ad6f270
< bitcoin-git> bitcoin/master f4b7a2f Ben Carman: rpc: getrpcinfo docs
< bitcoin-git> bitcoin/master e82f6ad MarcoFalke: Merge #15754: rpc: getrpcinfo docs
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15754: rpc: getrpcinfo docs (master...rpc_get_info_doc) https://github.com/bitcoin/bitcoin/pull/15754
< bitcoin-git> [bitcoin] Bushstar opened pull request #15782: Avoid redefine warning (master...warning-redefine) https://github.com/bitcoin/bitcoin/pull/15782
< gribble> https://github.com/bitcoin/bitcoin/issues/15780 | wallet: add cachable accounts for caching credit/debit values by kallewoof · Pull Request #15780 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] kallewoof opened pull request #15780: wallet: add cachable accounts for caching credit/debit values (master...cachable-accounts) https://github.com/bitcoin/bitcoin/pull/15780
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15746: rpc: RPCHelpMan: Always name dictionary keys (master...1904-rpcUtilFix) https://github.com/bitcoin/bitcoin/pull/15746
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5392aee64fa2...8c022e8ac401
< bitcoin-git> bitcoin/master fa652b2 MarcoFalke: rpc: Add some doxygen comments to utils
< bitcoin-git> bitcoin/master fa26eb5 MarcoFalke: rpc: RPCHelpMan: Always push_name when outer type is an object
< bitcoin-git> bitcoin/master 8c022e8 MarcoFalke: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/93de9abe6d68...5392aee64fa2
< bitcoin-git> bitcoin/master dddd6f0 MarcoFalke: init: Throw error when network specific config is ignored
< bitcoin-git> bitcoin/master fa4a922 MarcoFalke: qa: Add test for missing testnet section in conf file
< bitcoin-git> bitcoin/master fa9058f MarcoFalke: doc: Add release notes for 15629
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15629: init: Throw error when network specific config is ignored (master...1903-InitErrorConf) https://github.com/bitcoin/bitcoin/pull/15629

2019-04-09

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
< gwillen> (I am testing https://github.com/bitcoin/bitcoin/pull/15024, but I don't know that it's related)
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15632: Remove ResendWalletTransactions from the Validation Interface (master...no_resend_wallet_txs) https://github.com/bitcoin/bitcoin/pull/15632
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/23712f8ab951...93de9abe6d68
< bitcoin-git> bitcoin/master f463cd1 John Newbery: [wallet] Keep track of the best block time in the wallet
< bitcoin-git> bitcoin/master 52b760f John Newbery: [wallet] Schedule tx rebroadcasts in wallet
< bitcoin-git> bitcoin/master 833d98a John Newbery: [wallet] Remove unnecessary Chain::Lock parameter from ResendWalletTransac...
< bitcoin-git> [bitcoin] jnewbery opened pull request #15778: Mmove maxtxfee from node (master...remove_maxtxfeerate_from_node) https://github.com/bitcoin/bitcoin/pull/15778
< bitcoin-git> [bitcoin] jnewbery opened pull request #15777: [docs] Add doxygen comments for keypool classes (master...2019_04_keypool_comments) https://github.com/bitcoin/bitcoin/pull/15777
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15693: travis: Switch to ubuntu keyserver to avoid timeouts (master...1903-travisKeyTimeout) https://github.com/bitcoin/bitcoin/pull/15693
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f9f6c11a7422...23712f8ab951
< bitcoin-git> bitcoin/master fa36a33 MarcoFalke: travis: Switch to ubuntu keyserver to avoid timeouts
< bitcoin-git> bitcoin/master fa2056a MarcoFalke: travis: Properly cache and error on timeout
< bitcoin-git> bitcoin/master 23712f8 MarcoFalke: Merge #15693: travis: Switch to ubuntu keyserver to avoid timeouts
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3ecf3025f82...f9f6c11a7422
< bitcoin-git> bitcoin/master 90bce24 João Barbosa: qa: Prevent concurrency issues reading .cookie file
< bitcoin-git> bitcoin/master f9f6c11 MarcoFalke: Merge #15771: qa: Prevent concurrency issues reading .cookie file
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15771: qa: Prevent concurrency issues reading .cookie file (master...2019-04-retry-open-cookie) https://github.com/bitcoin/bitcoin/pull/15771
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15775: [0.18] Doc Backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15775
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/32ec90085044...164082c822b0
< bitcoin-git> bitcoin/0.18 538fef6 Pieter Wuille: Update bips.md for 0.18.0
< bitcoin-git> bitcoin/0.18 956c0aa fanquake: doc: correct bitcoinconsensus_version in shared-libraries
< bitcoin-git> bitcoin/0.18 1b0752a Pieter Wuille: Mention new PSBT RPCs in psbt.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15772: test: Properly log named args in authproxy (master...1904-qaLogNamedArgs) https://github.com/bitcoin/bitcoin/pull/15772
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54798c3a31b0...f3ecf3025f82
< bitcoin-git> bitcoin/master fa07898 MarcoFalke: test: Properly log named args in authproxy
< bitcoin-git> bitcoin/master f3ecf30 MarcoFalke: Merge #15772: test: Properly log named args in authproxy
< tryphe> luke-jr, i see, that makes sense. but i got the knack that bitcoin devs earned come income from donations somehow or some sort of community funding. not so?
< luke-jr> tryphe: Bitcoin Core is an open source project many different people contribute to; there's no centralised entity accepting/distributing donations on everyone's behalf
< tryphe> luke-jr, so where are the real bitcoin core donation addresses?
< luke-jr> tryphe: either way, it's bitcoin.org you want to report any issues to
< luke-jr> tryphe: that one is to support bitcoin.org, again not related to Bitcoin Core
< luke-jr> tryphe: eh, the link doesn't say it's to donate to Bitcoin or Bitcoin Core
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15749: Fix: importmulti only imports origin info for PKH outputs (master...201904_importallorigins) https://github.com/bitcoin/bitcoin/pull/15749
< bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/db2985651d9f...54798c3a31b0
< bitcoin-git> bitcoin/master 9a93c91 Pieter Wuille: Keep full pubkeys in FlatSigningProvider::origins
< bitcoin-git> bitcoin/master 6e59700 Pieter Wuille: Import all origin info in importmulti; even for non-importing pubkeys
< bitcoin-git> bitcoin/master b5d3987 Pieter Wuille: Take non-importing keys into account for spendability warning in descripto...
< luke-jr> tryphe: that has nothing to do with Bitcoin Core; https://github.com/bitcoin-dot-org/bitcoin.org
< bitcoin-git> [bitcoin] ajtowns opened pull request #15776: Expire inflight GETDATA requests (master...201904-inflighttxtimeout) https://github.com/bitcoin/bitcoin/pull/15776
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15747: wallet: Remove plethora of Get*Balance (master...1903-walletBal) https://github.com/bitcoin/bitcoin/pull/15747
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8088ff21e401...db2985651d9f
< bitcoin-git> bitcoin/master fa57411 MarcoFalke: wallet: Get all balances in one call
< bitcoin-git> bitcoin/master db29856 MeshCollider: Merge #15747: wallet: Remove plethora of Get*Balance
< tryphe> the donation link seems to be broken on this page: https://bitcoin.org/en/support-bitcoin
< bitcoin-git> [bitcoin] fanquake opened pull request #15775: [0.18] Doc Backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15775
< bitcoin-git> [bitcoin] laanwj merged pull request #15765: doc: correct bitcoinconsensus_version in shared-libraries.md (master...bitcoin_consensus_version) https://github.com/bitcoin/bitcoin/pull/15765
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79f73436a910...8088ff21e401
< bitcoin-git> bitcoin/master 8ae6d02 fanquake: doc: correct bitcoinconsensus_version in shared-libraries
< bitcoin-git> bitcoin/master 8088ff2 Wladimir J. van der Laan: Merge #15765: doc: correct bitcoinconsensus_version in shared-libraries.md...
< bitcoin-git> [bitcoin] laanwj merged pull request #15757: List new RPCs in psbt.md and descriptors.md (master...201904_docupdate) https://github.com/bitcoin/bitcoin/pull/15757
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a238fccce84b...79f73436a910
< bitcoin-git> bitcoin/master 28d78de Pieter Wuille: Mention new PSBT RPCs in psbt.md
< bitcoin-git> bitcoin/master 9b085f4 Pieter Wuille: Mention new descriptor RPCs in descriptors.md
< bitcoin-git> bitcoin/master 79f7343 Wladimir J. van der Laan: Merge #15757: List new RPCs in psbt.md and descriptors.md
< bitcoin-git> [bitcoin] jeffersoncarpenter closed pull request #15762: Declare iterators using auto (master...use-auto) https://github.com/bitcoin/bitcoin/pull/15762

2019-04-08

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15773: test: Add BitcoinTestFramework::sync_* methods (master...1904-qaSyncNew) https://github.com/bitcoin/bitcoin/pull/15773
< bitcoin-git> [bitcoin] kallewoof closed pull request #15753: RPC/testing: logprint RPC command (master...rpc-logprint) https://github.com/bitcoin/bitcoin/pull/15753
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15772: test: Properly log named args in authproxy (master...1904-qaLogNamedArgs) https://github.com/bitcoin/bitcoin/pull/15772
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15771: qa: Retry opening .cookie files (master...2019-04-retry-open-cookie) https://github.com/bitcoin/bitcoin/pull/15771
< instagibbs> wumpus, i sometimes get emails from random shitcoins that backport something I got merged into bitcoin core
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15763: Update bips.md for 0.18.0 (master...201904_updatebipsmd) https://github.com/bitcoin/bitcoin/pull/15763
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/297ea51caf2f...a238fccce84b
< bitcoin-git> bitcoin/master 65d2f5d Pieter Wuille: Update bips.md for 0.18.0
< bitcoin-git> bitcoin/master a238fcc MarcoFalke: Merge #15763: Update bips.md for 0.18.0
< bitcoin-git> [bitcoin] promag opened pull request #15770: rpc: Validate maxfeerate with AmountFromValue (master...2019-04-maxfeerate) https://github.com/bitcoin/bitcoin/pull/15770
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help (master...1904-docRpcRaw) https://github.com/bitcoin/bitcoin/pull/15760
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/414d8461fd67...297ea51caf2f
< bitcoin-git> bitcoin/master fa49db7 MarcoFalke: doc: Clarify sendrawtransaction::maxfeerate==0 help
< bitcoin-git> bitcoin/master 297ea51 MarcoFalke: Merge #15760: doc: Clarify sendrawtransaction::maxfeerate==0 help
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4e74f938b75...414d8461fd67
< bitcoin-git> bitcoin/master faf62d9 MarcoFalke: gui: Generate bech32 addresses by default
< bitcoin-git> bitcoin/master 414d846 MarcoFalke: Merge #15711: gui: Generate bech32 addresses by default
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15711: gui: Generate bech32 addresses by default (master...1904-guiBech32) https://github.com/bitcoin/bitcoin/pull/15711
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15446: Improve depends debuggability (master...2019-02-improve-depends-debuggability) https://github.com/bitcoin/bitcoin/pull/15446
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/327d2746fb92...b4e74f938b75
< bitcoin-git> bitcoin/master 80f0e05 Carl Dong: depends: Preprocessing doesn't care about deps
< bitcoin-git> bitcoin/master 6d44c5e Carl Dong: depends: Add commands for each package for each stage
< bitcoin-git> bitcoin/master b4e74f9 MarcoFalke: Merge #15446: Improve depends debuggability
< bitcoin-git> [bitcoin] domob1812 closed pull request #15381: Optionally return HTTP_OK for RPC errors (master...httprpc-error-code) https://github.com/bitcoin/bitcoin/pull/15381
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efbc86733a55...327d2746fb92
< bitcoin-git> bitcoin/master 8f5d943 Daniel Kraft: Add regtests for HTTP status codes.
< bitcoin-git> bitcoin/master 327d274 Jonas Schnelli: Merge #15495: Add regtests for HTTP status codes
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15495: Add regtests for HTTP status codes (master...test-http-code) https://github.com/bitcoin/bitcoin/pull/15495
< bitcoin-git> [bitcoin] crackercracked closed pull request #15769: Doc/Trivial change key name duration->duration-ms for getrpcinfo (master...fix-issue-15555-change-duration-key-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/15769
< bitcoin-git> [bitcoin] crackercracked opened pull request #15769: Doc/Trivial change key name duration->duration-ms for getrpcinfo (master...fix-issue-15555-change-duration-key-getrpcinfo) https://github.com/bitcoin/bitcoin/pull/15769

2019-04-07

< bitcoin-git> [bitcoin] IPGlider opened pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
< bitcoin-git> [bitcoin] fanquake opened pull request #15765: doc: correct bitcoinconsensus_version in shared-libraries.md (master...bitcoin_consensus_version) https://github.com/bitcoin/bitcoin/pull/15765
< bitcoin-git> [bitcoin] hebasto opened pull request #15766: scripts and tools: Upgrade gitian image before signing (master...20190407-gitian-upgrade-image) https://github.com/bitcoin/bitcoin/pull/15766

2019-04-06

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15660: [qa] Overhaul p2p_compactblocks.py (master...2019-03-refactor-p2p-compactblocks-2) https://github.com/bitcoin/bitcoin/pull/15660
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e439aeb30c04...efbc86733a55
< bitcoin-git> bitcoin/master 7813eb1 Suhas Daftuar: [qa] Overhaul p2p_compactblocks.py
< bitcoin-git> bitcoin/master efbc867 MarcoFalke: Merge #15660: [qa] Overhaul p2p_compactblocks.py
< bitcoin-git> [bitcoin] achow101 opened pull request #15764: Native descriptor wallets (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/15764
< bitcoin-git> [bitcoin] sipa merged pull request #15508: Refactor analyzepsbt for use outside RPC code (master...feature-separate-analyzepsbt) https://github.com/bitcoin/bitcoin/pull/15508
< bitcoin-git> [bitcoin] sipa pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/35991b162fd1...e439aeb30c04
< bitcoin-git> bitcoin/master afd20a2 Glenn Willen: Move PSBT decoding functions from core_io to psbt.cpp
< bitcoin-git> bitcoin/master ef22fe8 Glenn Willen: Refactor analyzepsbt for use outside RPC code
< bitcoin-git> bitcoin/master 892eff0 Glenn Willen: Add documentation of struct PSBTAnalysis et al
< bitcoin-git> [bitcoin] sipa opened pull request #15763: Update bips.md for 0.18.0 (master...201904_updatebipsmd) https://github.com/bitcoin/bitcoin/pull/15763
< instagibbs> for elements we partially reverted #13005 because debugging was so annoying and locally in my bitcoin dir i do the same
< gribble> https://github.com/bitcoin/bitcoin/issues/13005 | Make --enable-debug to pick better options by practicalswift · Pull Request #13005 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jeffersoncarpenter opened pull request #15762: Declare iterators using auto (master...use-auto) https://github.com/bitcoin/bitcoin/pull/15762
< bitcoin-git> [bitcoin] achow101 opened pull request #15761: Replace -upgradewallet startup option with upgradewallet RPC (master...upgradewallet-rpc) https://github.com/bitcoin/bitcoin/pull/15761
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub

2019-04-05

< gmaxwell> $ grep 'Successfully reconstructed' ~/.bitcoin/debug.log.old | tail -n 144 | awk '{misses += $22>0} END {print misses/NR}'
< gmaxwell> echeveria: $ grep 'Successfully reconstructed' ~/.bitcoin/debug.log | tail -n 1008 | awk '{misses += $22>0} END {print misses/NR}'
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15759: [p2p] Add 2 outbound blocks-only connections (master...2019-03-blocksonly-edges) https://github.com/bitcoin/bitcoin/pull/15759
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15758: qa: Add further tests to wallet_balance (master...1904-qaWalletBal) https://github.com/bitcoin/bitcoin/pull/15758
< bitcoin-git> [bitcoin] sipa opened pull request #15757: List new RPCs in psbt.md and descriptors.md (master...201904_docupdate) https://github.com/bitcoin/bitcoin/pull/15757
< bitcoin-git> [bitcoin] promag opened pull request #15756: gui: Add shortcuts for tab tools (master...2019-04-tools-shortcuts) https://github.com/bitcoin/bitcoin/pull/15756
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15755: rpc: remove unused var in rawtransaction.cpp (master...remove-unused-var) https://github.com/bitcoin/bitcoin/pull/15755
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c83442e17412...35991b162fd1
< bitcoin-git> bitcoin/master 4831aec Peter Bushnell: Remove unused var
< bitcoin-git> bitcoin/master 35991b1 MarcoFalke: Merge #15755: rpc: remove unused var in rawtransaction.cpp
< bitcoin-git> [bitcoin] Bushstar opened pull request #15755: qt: remove unused var (master...remove-unused-var) https://github.com/bitcoin/bitcoin/pull/15755
< bitcoin-git> [bitcoin] benthecarman opened pull request #15754: rpc: getrpcinfo docs (master...rpc_get_info_doc) https://github.com/bitcoin/bitcoin/pull/15754
< bitcoin-git> [bitcoin] kallewoof opened pull request #15753: RPC/testing: logprint RPC command (master...rpc-logprint) https://github.com/bitcoin/bitcoin/pull/15753

2019-04-04

< bitcoin-git> [bitcoin] madeken opened pull request #15752: Remove redundant shuffle in KnapsackSolver (master...master) https://github.com/bitcoin/bitcoin/pull/15752
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/daef20fb50c0...c83442e17412
< bitcoin-git> bitcoin/master fa8548c MarcoFalke: net: Remove unused unsanitized user agent string CNode::strSubVer
< bitcoin-git> bitcoin/master c83442e MarcoFalke: Merge #15654: net: Remove unused unsanitized user agent string CNode::strS...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15654: net: Remove unused unsanitized user agent string CNode::strSubVer (master...1903-netUABytes) https://github.com/bitcoin/bitcoin/pull/15654
< bitcoin-git> [bitcoin] sipa opened pull request #15751: Speed up deriveaddresses for large ranges (master...201904_fasterderiveaddresses) https://github.com/bitcoin/bitcoin/pull/15751
< bitcoin-git> [bitcoin] jnewbery opened pull request #15750: [rpc] Remove the addresses field from the getaddressinfo return object (master...2019_04_remove_address_from_getaddressinfo) https://github.com/bitcoin/bitcoin/pull/15750
< bitcoin-git> [bitcoin] sipa opened pull request #15749: Fix: importmulti only imports origin info for PKH outputs (master...201904_importallorigins) https://github.com/bitcoin/bitcoin/pull/15749
< bitcoin-git> [bitcoin] jnewbery opened pull request #15748: [rpc] remove dead mining code (master...2019_04_simplify_generate) https://github.com/bitcoin/bitcoin/pull/15748
< gribble> https://github.com/bitcoin/bitcoin/issues/15725 | Manual coin control dialog interacts badly with multiple wallets · Issue #15725 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14626 | Select orphan transaction uniformly for eviction by sipa · Pull Request #14626 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15743 | getaddressinfo missing key origin information for multisig · Issue #15743 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< bitcoin-git> [bitcoin] jamesob closed pull request #15735: Add scheduler deadlock detection (master...2019-04-serialize-scheduler) https://github.com/bitcoin/bitcoin/pull/15735
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15747: wallet: Remove plethora of Get*Balance (master...1903-walletBal) https://github.com/bitcoin/bitcoin/pull/15747
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15596: rpc: Ignore sendmany::minconf as dummy value (master...1903-rpcWalletDummySendmany_2) https://github.com/bitcoin/bitcoin/pull/15596
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ba54342c9dd3...daef20fb50c0
< bitcoin-git> bitcoin/master fae5f87 MarcoFalke: rpc: Document that minconf is an ignored dummy value
< bitcoin-git> bitcoin/master faa3a24 MarcoFalke: scripted-diff: wallet: Rename pcoin to wtx
< bitcoin-git> bitcoin/master fac1a0f MarcoFalke: wallet: Remove unused GetLegacyBalance
< araspitzu> Hi, does anybody have more info on the error "Transaction too large for fee policy"? Seems to happen at https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2986
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15746: rpc: RPCHelpMan: Always name dictionary keys (master...1904-rpcUtilFix) https://github.com/bitcoin/bitcoin/pull/15746
< bitcoin-git> [bitcoin] Empact opened pull request #15744: Extract ParseDescriptorRange (master...parse-descriptor-range) https://github.com/bitcoin/bitcoin/pull/15744
< gribble> https://github.com/bitcoin/bitcoin/issues/15743 | getaddressinfo missing key origin information for multisig · Issue #15743 · bitcoin/bitcoin · GitHub
< gwillen> btw supay, are you only using bitcoin core for rescuing this old wallet? I.e. you have no other funds in it?
< achow101> supay: bitcoin core's default wallet will generate 2000 keys automatically
< gribble> https://github.com/bitcoin/bitcoin/issues/15736 | Unable to importprivkey · Issue #15736 · bitcoin/bitcoin · GitHub
< achow101> supay: can you try `bitcoin-cli listaddressgroupings` and see if your address is in there?
< gwillen> if you are trying to import the master privkey, that is your problem -- bitcoin core does not know about bip 44, and won't try to derive the child keys automatically
< supay> gmaxwell: i've done: bitcoin-cli importprivkey the_key "" true -- and i wait about 25 mins or so for the rescan, and when i run bitcoin-cli getwalletinfo, the balances are still 0
< supay> i lost access to my bitcoin and scrubbed my system for any data i could find. found some bip32/44 paths. trying to import private keys into bitcoin core using importprivkey, but that isn't working. there aren't any errors either. any help?

2019-04-03

< bitcoin-git> [bitcoin] kallewoof closed pull request #13746: -masterdatadir for datadir bootstrapping (master...masterdatadir) https://github.com/bitcoin/bitcoin/pull/13746
< bitcoin-git> [bitcoin] achow101 opened pull request #15741: Batch write imported stuff in importmulti (master...batch-write-importmulti) https://github.com/bitcoin/bitcoin/pull/15741
< gribble> https://github.com/bitcoin/bitcoin/issues/15739 | large ranged descriptor imports are sloooooooooow. · Issue #15739 · bitcoin/bitcoin · GitHub
< gmaxwell> jl2012: there isn't a chinese version of bitcoin.org or something that only shows old links? I'm just at a loss as to what would be causing people to start new nodes using old code.
< bitcoin-git> [bitcoin] jamesob opened pull request #15735: Add scheduler deadlock detection (master...2019-04-serialize-scheduler) https://github.com/bitcoin/bitcoin/pull/15735
< instagibbs> the bitcoin-maintainer one is the more useful one IIRC
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15685: doc: rpc-mining: Clarify error messages (master...1903-docMining) https://github.com/bitcoin/bitcoin/pull/15685
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c364fde423e...ba54342c9dd3
< bitcoin-git> bitcoin/master fa292ad MarcoFalke: doc: rpc-mining: Clarify error messages
< bitcoin-git> bitcoin/master ba54342 MarcoFalke: Merge #15685: doc: rpc-mining: Clarify error messages
< bitcoin-git> [bitcoin] promag opened pull request #15730: rpc: Show scanning details in getwalletinfo (master...2019-04-getwalletinfo-scanning) https://github.com/bitcoin/bitcoin/pull/15730
< cheetah2> im getting error code -28 prunning blockstore with bitcoin-cli getinfo does it mean its crashed or is it working?
< bitcoin-git> [bitcoin] promag opened pull request #15729: rpc: Ignore minconf parameter in getbalance (master...2019-04-drop-getbalance-minconf) https://github.com/bitcoin/bitcoin/pull/15729
< bitcoin-git> [bitcoin] jnewbery opened pull request #15728: [wallet] Refactor relay transactions (master...2019_03_refactor_relay_transactions) https://github.com/bitcoin/bitcoin/pull/15728
< bitcoin-git> [bitcoin] ajtowns opened pull request #15726: bitcoin-cli -yaml support (master...201904-cli-yaml) https://github.com/bitcoin/bitcoin/pull/15726
< gribble> https://github.com/bitcoin/bitcoin/issues/15725 | Manual coin control dialog interacts badly with multiple wallets · Issue #15725 · bitcoin/bitcoin · GitHub
< gmaxwell> jl2012: ^ any thoughts for this? is it possible some high visibility chinese language bitcoin resource links to 0.16.1 ?
< wumpus> (e.g. freeze one version of bitcoin core as "stable")
< jonasschnelli> cfields: 0.18.0rc3 osx detached signatures are here: https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/24
< wumpus> fanquake: thanks for keeping an eye on changes to the release notes-if this keeps up we'll have to restrict edits to people in the bitcoin-core org (I'd prefer not to as this loses some potential documentation-only contributors), but this may well be accidental and they fixed it
< gmaxwell> $ ./bitcoin-cli getblocktemplate
< gmaxwell> I'm just ./bitcoin-cli getblocktemplate '{"rules": ["segwit"]}' | jq '.transactions | .[] | select(.hash != .txid)' |less and hitting / and pasting in the txid.
< gmaxwell> I did: $ ./bitcoin-cli prioritisetransaction 35611cbad11967731aa122136bf90bd63c5224296c45c10a26885c3bb3fff6f6 0 100000
< gmaxwell> ./bitcoin-cli getblocktemplate '{"rules": ["segwit"]}' | jq '.transactions | .[] | select(.hash != .txid)'
< fanquake> I assume this was accidental, rather than spam (as it was reverted right after). Just need to keep an eye on the wiki.. https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft/_compare/af6d617%5E...af6d617

2019-04-02

< gwillen> achow101: also, can you advise me on the intended way of using https://github.com/bitcoin/bitcoin/pull/14075
< gmaxwell> the tests are in bitcoin/test/functional/mining_prioritisetransaction.py
< gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15722: doc: Change block chain to blockchain in doc (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/15722
< bitcoin-git> [bitcoin] emilengler opened pull request #15722: doc: Change block chain to blockchain in doc (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/15722
< bitcoin-git> [bitcoin] laanwj closed pull request #15712: Update Copyright -> 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15712
< gribble> https://github.com/bitcoin/bitcoin/issues/15717 | Changes to support NAT-PMP by MishraShivendra · Pull Request #15717 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8dbb2c5e6704...2c364fde423e
< bitcoin-git> bitcoin/master ac67582 fanquake: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
< bitcoin-git> bitcoin/master 2c364fd MarcoFalke: Merge #14853: depends: latest RapidCheck
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14853: depends: latest RapidCheck (master...latest-rapidcheck) https://github.com/bitcoin/bitcoin/pull/14853
< bitcoin-git> [bitcoin] practicalswift opened pull request #15721: validation: Check absence of locks at compile-time (LOCKS_EXCLUDED) in addition to the current run-time checking (AssertLockNotHeld) (master...negative-locking-annotations) https://github.com/bitcoin/bitcoin/pull/15721
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5a2a9b5b0603...8dbb2c5e6704
< bitcoin-git> bitcoin/master f516245 John Newbery: [rpc] remove resendwallettransactions RPC
< bitcoin-git> bitcoin/master ea1a2d8 John Newbery: [wallet] Remove ResendWalletTransactionsBefore
< bitcoin-git> bitcoin/master 8dbb2c5 MarcoFalke: Merge #15680: Remove resendwallettransactions RPC method
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15680: Remove resendwallettransactions RPC method (master...2019_03_remove_resendwallettransactions) https://github.com/bitcoin/bitcoin/pull/15680
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc3
< bitcoin-git> [bitcoin] laanwj pushed 9 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/7bcf90cb01aa...32ec90085044
< bitcoin-git> bitcoin/0.18 6355214 Pieter Wuille: Simplify orphan processing in preparation for interruptibility
< bitcoin-git> bitcoin/0.18 bb60121 Pieter Wuille: [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
< bitcoin-git> bitcoin/0.18 50c56f2 Pieter Wuille: Interrupt orphan processing after every transaction
< bitcoin-git> [bitcoin] laanwj merged pull request #15691: 0.18: rc3 backports (0.18...1904-18B) https://github.com/bitcoin/bitcoin/pull/15691
< gribble> https://github.com/bitcoin/bitcoin/issues/15691 | 0.18: rc3 backports by MarcoFalke · Pull Request #15691 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] scravy closed pull request #15715: Better support for mainframes and EBCDIC users in general (master...cater-mainframes-and-ebcdic-users) https://github.com/bitcoin/bitcoin/pull/15715
< bitcoin-git> [bitcoin] laanwj closed pull request #15714: tests: Volkswagen (master...1904-testsVolkswagen) https://github.com/bitcoin/bitcoin/pull/15714

2019-04-01

< bitcoin-git> [bitcoin] fanquake closed pull request #15720: Ssk22014 (master...ssk22014-patch-1) https://github.com/bitcoin/bitcoin/pull/15720
< bitcoin-git> [bitcoin] ssk22014 opened pull request #15720: Ssk22014 (master...ssk22014-patch-1) https://github.com/bitcoin/bitcoin/pull/15720
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15719: Drop Chain::requestMempoolTransactions method (master...pr/pool) https://github.com/bitcoin/bitcoin/pull/15719
< dongcarl> Can someone explain to me the context behind `GetGroup`? My git digging lead me to a +1041 −546 commit here: https://github.com/bitcoin/bitcoin/pull/735/commits/67a42f929b1434f647c63922fd02dc2b93b28060
< bitcoin-git> [bitcoin] dongcarl opened pull request #15718: [WIP] docs: Improve netaddress comments (master...2019-04-netaddr-comments) https://github.com/bitcoin/bitcoin/pull/15718
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15652: wallet: Update transactions with current mempool after load (master...2019-03-fix-15591) https://github.com/bitcoin/bitcoin/pull/15652
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/35477e9e4e3f...5a2a9b5b0603
< bitcoin-git> bitcoin/master 0440481 João Barbosa: wallet: Move CWallet::ReacceptWalletTransactions locks to callers
< bitcoin-git> bitcoin/master 57908a7 João Barbosa: interfaces: Add Chain::requestMempoolTransactions
< bitcoin-git> bitcoin/master 2ebf650 João Barbosa: wallet: Update transactions with current mempool after load