< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
< bitcoin-git>
[bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974
< bitcoin-git>
[bitcoin] jnewbery opened pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
< gribble>
https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] tarboss opened pull request #18961: remove assert in walletcontroller & run setparent in gui-qt main thread (master...master) https://github.com/bitcoin/bitcoin/pull/18961
< jb55>
let's say I send a tx to a tor peer, they would have some custom code that correlates encrypted bitcoin-p2p traffic with transactions coming out of exit nodes somehow?
< bitcoin-git>
[bitcoin] laanwj merged pull request #18945: build: Ensure source tarball has leading directory name (0.20) (0.20...2020_11_0.20_tarball_prefix) https://github.com/bitcoin/bitcoin/pull/18945
< bitcoin-git>
[bitcoin] dongcarl opened pull request #18958: guix: Make V=1 more powerful for debugging (master...2020-05-guix-improvements) https://github.com/bitcoin/bitcoin/pull/18958
< bitcoin-git>
[bitcoin] fanquake merged pull request #18957: Add a link from ZMQ doc to ZMQ example in contrib/ (master...zmq-doc-link) https://github.com/bitcoin/bitcoin/pull/18957
< bitcoin-git>
bitcoin/master ad1b7b1 fanquake: Merge #18957: Add a link from ZMQ doc to ZMQ example in contrib/
< bitcoin-git>
bitcoin/master d97fac4 Damian Mee: Add a link from ZMQ doc to ZMQ example in contrib/
< bitcoin-git>
[bitcoin] fanquake merged pull request #18928: build: don't pass -w when building for Windows (master...dont_try_suppress_all_warnings_win) https://github.com/bitcoin/bitcoin/pull/18928
< bitcoin-git>
bitcoin/master 49d237c fanquake: Merge #18928: build: don't pass -w when building for Windows
< bitcoin-git>
bitcoin/master 89fea68 fanquake: build: don't pass -w when building for Windows
< bitcoin-git>
[bitcoin] meeDamian opened pull request #18957: Add a link from ZMQ doc to ZMQ example in contrib/ (master...zmq-doc-link) https://github.com/bitcoin/bitcoin/pull/18957
< bitcoin-git>
[bitcoin] fanquake opened pull request #18956: build: enforce minumim required Windows version (7) (master...window_enforce_runtime_version) https://github.com/bitcoin/bitcoin/pull/18956
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
< bitcoin-git>
[bitcoin] practicalswift closed pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git>
[bitcoin] andrewtoth reopened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< bitcoin-git>
[bitcoin] jnewbery closed pull request #18955: net processing: requeue transaction GETDATA requests more frequently (master...2020-05-requeue-txrequest) https://github.com/bitcoin/bitcoin/pull/18955
< bitcoin-git>
[bitcoin] fanquake merged pull request #18808: [net processing] Drop unknown types in getdata (master...2020-04-getdata) https://github.com/bitcoin/bitcoin/pull/18808
< bitcoin-git>
bitcoin/master 2f03255 Amiti Uttarwar: [test] test that an invalid GETDATA doesn't prevent processing of future m...
< bitcoin-git>
[bitcoin] jnewbery opened pull request #18955: net processing: requeue transaction GETDATA requests more frequently (master...2020-05-requeue-txrequest) https://github.com/bitcoin/bitcoin/pull/18955
2020-05-11
< bitcoin-git>
[bitcoin] andrewtoth closed pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< amiti>
I’m learning a lot and I appreciate your patience with me along the way. Its an honor to work with you all on bitcoin core <3
< amiti>
I feel deeply grateful to get to work on bitcoin core on a daily basis. I 100% do not think I would be here if it weren’t for the many of you who have believed in me & taught me so much, even when I doubt myself. I’ve found the bitcoin core community to be welcoming & supportive, and I wish to share that with others who feel intimidated but interested
< bitcoin-git>
[bitcoin] hebasto opened pull request #18948: qt: Do not call setParent() for WalletModel instances (master...200511-qt-assert) https://github.com/bitcoin/bitcoin/pull/18948
< wumpus>
thanks for weighing in; I think having contributed *something* is good before starting to review, unless you can somehow start reviewing at a deep technical level without having written any code for bitcoin core (e.g. contributor to a similar or adjacent project), but that's rare
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
< bitcoin-git>
[bitcoin] laanwj opened pull request #18945: build: Ensure source tarball has leading directory name (0.20...2020_11_0.20_tarball_prefix) https://github.com/bitcoin/bitcoin/pull/18945
< bitcoin-git>
[bitcoin] andrewtoth opened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
< bitcoin-git>
[bitcoin] andrewtoth closed pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
< bitcoin-git>
[bitcoin] theStack opened pull request #18940: miner: fix off-by-ones in BlockAssembler::TestPackage (master...20200511-miner-fix-off-by-one-in-test-package) https://github.com/bitcoin/bitcoin/pull/18940
2020-05-10
< bitcoin-git>
[bitcoin] mzumsande opened pull request #18939: doc: add c++17-enable flag to fuzzing instructions (master...202005_fuzz_doc) https://github.com/bitcoin/bitcoin/pull/18939
< bitcoin-git>
[bitcoin] brakmic closed pull request #18932: test: move sync_* implementations to framework member functions (master...move-sync-blocks-to-framework) https://github.com/bitcoin/bitcoin/pull/18932
< bitcoin-git>
[bitcoin] brakmic closed pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871
< bitcoin-git>
[bitcoin] brakmic closed pull request #17551: test: added test for RPCConvertNamedValues in rpc_tests (master...expanding-test-coverage) https://github.com/bitcoin/bitcoin/pull/17551
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18938: tests: Fill fuzzing coverage gaps for functions in consensus/validation.h, primitives/block.h and util/translation.h (master...fuzzers-misc-5) https://github.com/bitcoin/bitcoin/pull/18938
< bitcoin-git>
[bitcoin] theStack opened pull request #18937: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg (master...20200520-refactor-replace-command-by-msgtype-part-3) https://github.com/bitcoin/bitcoin/pull/18937
< luke-jr>
phantomcircuit: bitcoin-wallet doesn't do blockchain stuff
< bitcoin-git>
[bitcoin] andrewtoth opened pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
< bitcoin-git>
[bitcoin] brakmic opened pull request #18935: test: add more assert_* methods (master...new-asserts-for-functional-testing) https://github.com/bitcoin/bitcoin/pull/18935
< bitcoin-git>
[bitcoin] brakmic opened pull request #18932: test: move sync_blocks implementation to framework member function (master...move-sync-blocks-to-framework) https://github.com/bitcoin/bitcoin/pull/18932
< bitcoin-git>
[bitcoin] jonatack opened pull request #18931: net: use CMessageHeader::HEADER_SIZE, add missing include (master...netcpp-use-CMessageHeader_HEADER_SIZE) https://github.com/bitcoin/bitcoin/pull/18931
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18929: ci: Pass down MAKEJOBS to fuzz test_runner (master...2005-fuzzMakejobs) https://github.com/bitcoin/bitcoin/pull/18929
< bitcoin-git>
[bitcoin] fanquake opened pull request #18928: build: don't pass -w when building for Windows (master...dont_try_suppress_all_warnings_win) https://github.com/bitcoin/bitcoin/pull/18928
< bitcoin-git>
[bitcoin] glowang opened pull request #18926: Pass ArgsManager into functions that register args with AddArg (master...replace_global_gArgs_with_local_argsman) https://github.com/bitcoin/bitcoin/pull/18926
< bitcoin-git>
[bitcoin] naumenkogs opened pull request #18925: Add extra thread for scheduler, move TorControl and OpenAddedConnections to scheduler (master...2020_05_extra_scheduler_thread) https://github.com/bitcoin/bitcoin/pull/18925
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18923: wallet: Never schedule MaybeCompactWalletDB when -flushwallet is off (master...2005-walletNoFlush) https://github.com/bitcoin/bitcoin/pull/18923
< bitcoin-git>
[bitcoin] hebasto opened pull request #18922: gui: Do not translate InitWarning messages in debug.log (master...200509-initwarn) https://github.com/bitcoin/bitcoin/pull/18922
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18901: fuzz: use std::optional for sep_pos_opt variable (master...warning-in-fuzz-tests) https://github.com/bitcoin/bitcoin/pull/18901
< bitcoin-git>
bitcoin/master 88d8b4e MarcoFalke: Merge #18901: fuzz: use std::optional for sep_pos_opt variable
< bitcoin-git>
bitcoin/master 420fa07 Harris: fuzz: use std::optional for sep_pos variable
< bitcoin-git>
[bitcoin] fanquake opened pull request #18921: build: add stack-clash and control-flow protection options to hardening flags (master...add_cfi_to_hardening) https://github.com/bitcoin/bitcoin/pull/18921
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18920: doc: Document how to analyze Bitcoin Core using clang-tidy (master...static-analysis-clang-tidy) https://github.com/bitcoin/bitcoin/pull/18920
2020-05-08
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18866: test: Fix verack race to avoid intermittent test failures (master...2005-qaVerackRace) https://github.com/bitcoin/bitcoin/pull/18866
< bitcoin-git>
bitcoin/master 376294c MarcoFalke: Merge #18866: test: Fix verack race to avoid intermittent test failures
< bitcoin-git>
bitcoin/master fae153b MarcoFalke: test: Fix verack race to avoid intermittent test failures
< gribble>
https://github.com/bitcoin/bitcoin/issues/17681 | wallet: Keep inactive seeds after sethdseed and derive keys from them as needed by achow101 · Pull Request #17681 · bitcoin/bitcoin · GitHub
< ryanofsky>
jnewbery, it means they started bitcoin at some point with a -wallet=something command line argument, but maybe that is advanced enough
< gwillen>
luke-jr: your point is that sqlite has not changed its format in 16 years, since before bitcoin was invented?
< jnewbery>
luke-jr: is your opposition to this because it makes it more difficult to maintain bitcoin knots if the dependencies in bitcoin core change?
< bitcoin-git>
[bitcoin] brakmic opened pull request #18917: fuzz: fix vector size problem in system fuzzer (master...fix-system-fuzzer) https://github.com/bitcoin/bitcoin/pull/18917
< dfmb_>
Hi im a noob, just wondering who decides which updates to deploy on bitcoin code? Letś say I make a pull request on the bitcoin github who decides that udpate is valid or it isn't ?
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18912: ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to catch memory errors (master...fuzzers-under-valgrind) https://github.com/bitcoin/bitcoin/pull/18912
< * luke-jr>
still hasn't heard a use case for merging BIP157 at all, aside from harming Bitcoin
< sipa>
luke-jr: my belief is that bitcoin offers a choice for financial autonomy, and choice is a good thing - not everyone will choose to make maximal use of that, but everyone who wants to should be able to
< luke-jr>
at least, that as long as the situation is not good, anything that makes light clients better, is harmful to Bitcoin, and shouldn't be merged
< luke-jr>
sipa: if 99.99% don't have their own full node, Bitcoin has failed
< luke-jr>
Bitcoin's security model depends on at least most people using their own full ndoe
< jnewbery>
not everyone wants to use bitcoin in the same way as you, and that's ok
< gribble>
https://github.com/bitcoin/bitcoin/issues/18691 | test: add wait_for_cookie_credentials() to framework for rpcwait tests by jonatack · Pull Request #18691 · bitcoin/bitcoin · GitHub
< jonatack>
jonasschnelli: yes, i always look at bitcoinbuilds for first feedback, then much later, travis on my own github branch and on bitcoin/bitcoin
< gribble>
https://github.com/bitcoin/bitcoin/issues/17037 | Testschains: Many regtests with different genesis and default datadir by jtimon · Pull Request #17037 · bitcoin/bitcoin · GitHub