2018-05-02

< gribble> https://github.com/bitcoin/bitcoin/issues/12047 | Segmentation fault if configured with incompatible BDB · Issue #12047 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/6775 | Bitcoind v0.11.0 segfaults on startup trying to read wallet. · Issue #6775 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor (master...qt-constructors) https://github.com/bitcoin/bitcoin/pull/12928
< bitcoin-git> bitcoin/master 1e7813e practicalswift: Remove redundant initializations from the constructor
< bitcoin-git> bitcoin/master f131872 practicalswift: Initialize non-static class members where they are defined
< bitcoin-git> bitcoin/master 73bc1b7 practicalswift: Initialize editStatus and autoCompleter. Previously not initialized where defined or in constructor.
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef46c9904b80...ef006d92845a
< wumpus> yes, if you're in bitcoin but not in bitcoin-core or vice versa, let me know, invites are supposed to go out for both at the same time
< fanquake> The crossover between the "teams" in the two orgs is pretty high. Probably just a few more inactive/older users in /bitcoin
< BlueMatt> well except bips, which will probably always stay in bitcoin
< wumpus> it was originally the plan to move the bitcoin repository too, however since the 'bitcoin core' as currency name bullshit from BCHers, that's probably a bad idea and will only contribute towards user confusion
< wumpus> right - bitcoin is the legacy organization, bitcoin-core is where most of the repositories have been moved
< fanquake> /bitcoin was where bitcoin was migrated to from SF. /bitcoin-core houses some core specific repos such as the website, docs etc
< ryanofsky> what's the difference between https://github.com/bitcoin and https://github.com/bitcoin-core?
< bitcoin-git> [bitcoin] ryanofsky opened pull request #13154: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 (master...pr/flushed) https://github.com/bitcoin/bitcoin/pull/13154
< bitcoin-git> [bitcoin] laanwj closed pull request #13153: Add missing newlines to debug logging (master...2018_05_log_newlines) https://github.com/bitcoin/bitcoin/pull/13153
< bitcoin-git> bitcoin/master ef46c99 Wladimir J. van der Laan: Merge #13153: Add missing newlines to debug logging...
< bitcoin-git> bitcoin/master 4b75dcf MarcoFalke: devtools: Make linter check LogPrint calls
< bitcoin-git> bitcoin/master ff2ad2d Wladimir J. van der Laan: Add missing newlines to LogPrint debug logging...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/598db389c33e...ef46c9904b80
< gribble> https://github.com/bitcoin/bitcoin/issues/13151 | WIP: net: Serve blocks directly from disk when possible by laanwj · Pull Request #13151 · bitcoin/bitcoin · GitHub
< fanquake> indeed, didn't realise we were checking that https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/lint-logs.sh
< bitcoin-git> [bitcoin] laanwj opened pull request #13153: net: Add missing newlines to debug logging (master...2018_05_log_newlines) https://github.com/bitcoin/bitcoin/pull/13153
< bitcoin-git> [bitcoin] chris-belcher opened pull request #13152: [WIP] [rpc] Add getaddress RPC command (master...2018-04-rpc-getaddress) https://github.com/bitcoin/bitcoin/pull/13152
< bitcoin-git> [bitcoin] laanwj opened pull request #13151: WIP: net: Serve blocks directly from disk when possible (master...2018_05_direct_from_disk) https://github.com/bitcoin/bitcoin/pull/13151
< bitcoin-git> [bitcoin] laanwj closed pull request #13106: Simplify semantics of ChainStateFlushed callback (master...2018-04-wallet-flush-better-criteria) https://github.com/bitcoin/bitcoin/pull/13106
< bitcoin-git> bitcoin/master 598db38 Wladimir J. van der Laan: Merge #13106: Simplify semantics of ChainStateFlushed callback...
< bitcoin-git> bitcoin/master 50b6533 Matt Corallo: scripted-diff: Rename SetBestChain callback ChainStateFlushed...
< bitcoin-git> bitcoin/master 9cb6cdc Matt Corallo: Simplify semantics of ChainStateFlushed callback...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0bc980b1f65f...598db389c33e
< gribble> https://github.com/bitcoin/bitcoin/issues/13034 | Introduce WalletManager by promag · Pull Request #13034 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13146: rpcauth: Make it possible to provide a custom password (master...2018_05_rpcauth_custom_password) https://github.com/bitcoin/bitcoin/pull/13146
< bitcoin-git> bitcoin/master 0bc980b Wladimir J. van der Laan: Merge #13146: rpcauth: Make it possible to provide a custom password...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57c57df86f14...0bc980b1f65f
< bitcoin-git> bitcoin/master 2a89b0c Wladimir J. van der Laan: rpcauth: Make it possible to provide a custom password...
< bitcoin-git> [bitcoin] practicalswift opened pull request #13149: Handle unsuccessful fseek(...):s (master...fseek) https://github.com/bitcoin/bitcoin/pull/13149
< bitcoin-git> [bitcoin] practicalswift opened pull request #13148: logging: Fix potential use-after-free in LogPrintStr(...) (master...logprintstr-uaf) https://github.com/bitcoin/bitcoin/pull/13148
< gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/7965 | Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` · Issue #7965 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #13146: rpcauth: Make it possible to provide a custom password (master...2018_05_rpcauth_custom_password) https://github.com/bitcoin/bitcoin/pull/13146
< luke-jr> fun fact: I only began using the GUI when wumpus wrote Bitcoin-Qt ;)
< sipa> i thought bitcoin core was going to become a minecraft plugin?
< wumpus> there's even a project open for it https://github.com/bitcoin/bitcoin/projects/3
< bitcoin-git> [bitcoin] laanwj closed pull request #13141: [doc] qt: fixes broken link on readme (master...fix_qt_readme_typo) https://github.com/bitcoin/bitcoin/pull/13141
< bitcoin-git> bitcoin/master 57c57df Wladimir J. van der Laan: Merge #13141: [doc] qt: fixes broken link on readme...
< bitcoin-git> bitcoin/master 12ad33a marcoagner: [doc] qt: fixes broken link on readme
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/baf6b4e3f956...57c57df86f14
< gribble> https://github.com/bitcoin/bitcoin/issues/13141 | [doc] qt: fixes broken link on readme by marcoagner · Pull Request #13141 · bitcoin/bitcoin · GitHub
< fanquake> Even though I know that splitting up the massive bitcoin/bitcoin repo is going to be better in the long term. Sometimes I feel like I'm losing a handle on everything that gets split out. Especially what's in the bitcoin-core/docs repo. Haven't reviewed any of the recent gitian build guide changes.
< bitcoin-git> [bitcoin] winder opened pull request #13145: Use common getPath method to create temp directory in tests. (master...master) https://github.com/bitcoin/bitcoin/pull/13145

2018-05-01

< bitcoin-git> [bitcoin] jimpo opened pull request #13144: RPC: Improve error messages on RPC endpoints that use GetTransaction (master...gettransaction-refactor) https://github.com/bitcoin/bitcoin/pull/13144
< bitcoin-git> [bitcoin] sipa opened pull request #13142: Separate IsMine from solvability (master...201804_separate_ismine_solvable) https://github.com/bitcoin/bitcoin/pull/13142
< bitcoin-git> [bitcoin] marcoagner opened pull request #13141: [doc] qt: fixes broken link on readme (master...fix_qt_readme_typo) https://github.com/bitcoin/bitcoin/pull/13141
< bitcoin-git> [bitcoin] sidhujag closed pull request #13139: Dev 3.x (master...dev-3.x) https://github.com/bitcoin/bitcoin/pull/13139
< bitcoin-git> [bitcoin] sidhujag opened pull request #13139: Dev 3.x (master...dev-3.x) https://github.com/bitcoin/bitcoin/pull/13139
< bitcoin-git> [bitcoin] jnewbery opened pull request #13138: [tests] Remove accounts from wallet_importprunedfunds.py (master...remove_account_wallet_importprunedfunds) https://github.com/bitcoin/bitcoin/pull/13138
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13136: [tests] Fix flake8 warnings in several wallet functional tests (master...wallet_test_flake8) https://github.com/bitcoin/bitcoin/pull/13136
< bitcoin-git> bitcoin/master baf6b4e MarcoFalke: Merge #13136: [tests] Fix flake8 warnings in several wallet functional tests...
< bitcoin-git> bitcoin/master a533834 John Newbery: [tests] Fix flake8 warnings in several wallet functional tests...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1408d6cf768c...baf6b4e3f956
< bitcoin-git> [bitcoin] laanwj opened pull request #13137: contrib: Remove distribution packaging (master...2018_05_move_distro_packaging) https://github.com/bitcoin/bitcoin/pull/13137
< bitcoin-git> [bitcoin] jnewbery opened pull request #13136: [trivial] [tests] Fix flake8 warnings in several wallet functional tests (master...wallet_test_flake8) https://github.com/bitcoin/bitcoin/pull/13136
< bitcoin-git> bitcoin/master 1408d6c Wladimir J. van der Laan: Revert #12769: Add systemd service to bitcoind in debian package...
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/1408d6cf768cc3c88e9ab9efe98b0cb52ae3b537
< bitcoin-git> [bitcoin] laanwj closed pull request #12769: Add systemd service to bitcoind in debian package (master...master) https://github.com/bitcoin/bitcoin/pull/12769
< bitcoin-git> bitcoin/master 35eb9d6 Wladimir J. van der Laan: Merge #12769: Add systemd service to bitcoind in debian package...
< bitcoin-git> bitcoin/master 2a87b1b ctp-tsteenholdt: Add systemd service for bitcoind...
< bitcoin-git> bitcoin/master 9085532 ctp-tsteenholdt: Sync contrib/debian from Matt Corallo's PPA
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5f7efe3312f...35eb9d6c880e
< bitcoin-git> bitcoin/master c5f7efe Wladimir J. van der Laan: Merge #12384: [Docs] Add version footnote to tor.md...
< bitcoin-git> [bitcoin] laanwj closed pull request #12384: [Docs] Add version footnote to tor.md (master...tor.md) https://github.com/bitcoin/bitcoin/pull/12384
< bitcoin-git> bitcoin/master 39d2911 Damian Williamson: [Docs] Add version footnote to tor.md...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a024a1841d62...c5f7efe3312f
< bitcoin-git> [bitcoin] laanwj closed pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (master...2018_05_tor_md_version) https://github.com/bitcoin/bitcoin/pull/13135
< bitcoin-git> [bitcoin] laanwj opened pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (master...2018_05_tor_md_version) https://github.com/bitcoin/bitcoin/pull/13135
< gribble> https://github.com/bitcoin/bitcoin/issues/12384 | [Docs] Add version footnote to tor.md by Willtech · Pull Request #12384 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13078 | importprunedfunds + removeprunedfunds + listtransactions can cause OOM · Issue #13078 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13075 | Remove account API from wallet functional tests by jnewbery · Pull Request #13075 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj opened pull request #13134: net: Add option `-peersendreject` to configure sending of BIP61 notifications (master...2018_05_optional_bip61) https://github.com/bitcoin/bitcoin/pull/13134
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13133: Remove python2 from configure.ac (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13133
< bitcoin-git> bitcoin/master a024a18 MarcoFalke: Merge #13133: Remove python2 from configure.ac...
< bitcoin-git> bitcoin/master 457c2da Chun Kuan Lee: Remove python2 from configure.ac
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a666428b0f1...a024a1841d62
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13133: Remove python2 from configure.ac (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13133
< meshcollider> ping kallewoof are you online? Need to talk to you about bitcoin wiki but you're not in that channel
< bitcoin-git> [bitcoin] sipa closed pull request #12954: util: Refactor logging code into a global object (master...logging) https://github.com/bitcoin/bitcoin/pull/12954
< bitcoin-git> bitcoin/master 3316a9e Jim Posen: util: Encapsulate logCategories within BCLog::Logger.
< bitcoin-git> bitcoin/master 6a6d764 Jim Posen: util: Move debug file management functions into Logger.
< bitcoin-git> bitcoin/master f55f4fc Jim Posen: util: Establish global logger object....
< bitcoin-git> [bitcoin] sipa pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/3186ad4a81a4...5a666428b0f1

2018-04-30

< gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub
< provoostenator> I rebased my Gitian doc PR from February: https://github.com/bitcoin-core/docs/pull/25
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13130: [tests] Fix race in rpc_deprecated.py (master...fix_rpc_deprecated) https://github.com/bitcoin/bitcoin/pull/13130
< bitcoin-git> bitcoin/master 3186ad4 MarcoFalke: Merge #13130: [tests] Fix race in rpc_deprecated.py...
< bitcoin-git> bitcoin/master a95bf64 John Newbery: [tests] Fix race in rpc_deprecated.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/783bb6455e18...3186ad4a81a4
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13131: Add Windows shutdown handler (master...win-quit) https://github.com/bitcoin/bitcoin/pull/13131
< gribble> https://github.com/bitcoin/bitcoin/issues/13130 | [tests] Fix race in rpc_deprecated.py by jnewbery · Pull Request #13130 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12953 | Deprecate accounts by jnewbery · Pull Request #12953 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #13130: [tests] Fix race in rpc_deprecated.py (master...fix_rpc_deprecated) https://github.com/bitcoin/bitcoin/pull/13130
< bitcoin-git> [bitcoin] practicalswift closed pull request #11596: Add missing cs_main locks when accessing chainActive (master...chainActive) https://github.com/bitcoin/bitcoin/pull/11596
< bitcoin-git> [bitcoin] laanwj closed pull request #13028: Make vpwallets usage thread safe (master...2018-04-cs_wallets) https://github.com/bitcoin/bitcoin/pull/13028
< bitcoin-git> bitcoin/master 783bb64 Wladimir J. van der Laan: Merge #13028: Make vpwallets usage thread safe...
< bitcoin-git> bitcoin/master e2f58f4 João Barbosa: wallet: Make vpwallets usage thread safe
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9e9b48df72db...783bb6455e18
< bitcoin-git> [bitcoin] practicalswift opened pull request #13128: policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator (master...guarded-by-cs_feeEstimator) https://github.com/bitcoin/bitcoin/pull/13128
< bitcoin-git> [bitcoin] practicalswift closed pull request #12914: scripted-diff: Remove redundant license reference (HTTP URL) (master...copyright-headers) https://github.com/bitcoin/bitcoin/pull/12914
< bitcoin-git> [bitcoin] laanwj closed pull request #13105: [qa] Add --failfast option to functional test runner (master...2018-04-testrunner-failfast) https://github.com/bitcoin/bitcoin/pull/13105
< bitcoin-git> bitcoin/master 9e9b48d Wladimir J. van der Laan: Merge #13105: [qa] Add --failfast option to functional test runner...
< bitcoin-git> bitcoin/master 58f9a0a James O'Beirne: Use --failfast when running functional tests on Travis
< bitcoin-git> bitcoin/master bf720c1 James O'Beirne: Add --failfast option to functional test runner...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/19fadd9d6883...9e9b48df72db
< gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/6658 | Building requires >1GB memory · Issue #6658 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13106 | Simplify semantics of ChainStateFlushed callback by TheBlueMatt · Pull Request #13106 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #13127: wallet: Add Clang thread safety annotations for variables guarded by cs_db (master...guarded-by-cs_db) https://github.com/bitcoin/bitcoin/pull/13127
< bitcoin-git> [bitcoin] laanwj closed pull request #13124: [doc] nit: descendent should be spelled descendant even in the release-notes (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13124
< bitcoin-git> bitcoin/master 19fadd9 Wladimir J. van der Laan: Merge #13124: [doc] nit: descendent should be spelled descendant even in the release-notes...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/219970524d8a...19fadd9d6883
< bitcoin-git> bitcoin/master 9b78ef3 mryandao: nit: descendent should be spelled descendant even in the release-notes
< bitcoin-git> [bitcoin] practicalswift opened pull request #13126: util: Add Clang thread safety annotations for variables guarded by cs_args (master...guarded-by-cs_args) https://github.com/bitcoin/bitcoin/pull/13126
< gribble> https://github.com/bitcoin/bitcoin/issues/13124 | [doc] nit: descendent should be spelled descendant even in the release-notes by mryandao · Pull Request #13124 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending (master...m_cs_callbacks_pending) https://github.com/bitcoin/bitcoin/pull/13125
< bitcoin-git> [bitcoin] mryandao opened pull request #13124: [doc] nit: descendent should be spelled descendant even in the release-notes (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13124
< bitcoin-git> [bitcoin] laanwj closed pull request #13109: [rpc] nit: fix typo for entry description string (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13109
< bitcoin-git> bitcoin/master 2199705 Wladimir J. van der Laan: Merge #13109: [rpc] nit: fix typo for entry description string...
< bitcoin-git> bitcoin/master f7c414d mryandao: nit: fix typo for entry description string
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81743b5b24c0...219970524d8a
< bitcoin-git> [bitcoin] practicalswift opened pull request #13123: Add Clang thread safety annotations for guarded variables in the networking code (master...net-guarded-by) https://github.com/bitcoin/bitcoin/pull/13123
< bitcoin-git> [bitcoin] dbolser opened pull request #13122: --disable-asm is required to compile on FreeBSD (master...patch-4) https://github.com/bitcoin/bitcoin/pull/13122
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #13119: Remove script to clean up datadirs (master...Mf1805-deleteTidyDatadir) https://github.com/bitcoin/bitcoin/pull/13119
< bitcoin-git> bitcoin/master 81743b5 Jonas Schnelli: Merge #13119: Remove script to clean up datadirs...
< bitcoin-git> bitcoin/master fa85de9 MarcoFalke: Remove script to clean up datadirs...
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3315007e03f5...81743b5b24c0
< gribble> https://github.com/bitcoin/bitcoin/issues/13109 | [rpc] nit: fix typo for entry description string by mryandao · Pull Request #13109 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13119 | Remove script to clean up datadirs by MarcoFalke · Pull Request #13119 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #13113: tests: Make it clear that MAX_INV_SZ is not covered by functional tests (master...add-note-about-MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13113
< gribble> https://github.com/bitcoin/bitcoin/issues/13109 | [rpc] nit: fix typo for entry description string by mryandao · Pull Request #13109 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13120: policy: Treat segwit as always active (master...Mf1805-segwitGenesisPolicy) https://github.com/bitcoin/bitcoin/pull/13120

2018-04-29

< gribble> https://github.com/bitcoin/bitcoin/issues/13107 | Fix Windows locale problem by ken2812221 · Pull Request #13107 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13119: Remove script to clean up datadirs (master...Mf1805-deleteTidyDatadir) https://github.com/bitcoin/bitcoin/pull/13119
< bitcoin-git> [bitcoin] Linrono opened pull request #13118: RPCAuth Detection in Logs (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13118
< bitcoin-git> [bitcoin] practicalswift opened pull request #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} (master...guarded-by-misc) https://github.com/bitcoin/bitcoin/pull/13116
< bitcoin-git> [bitcoin] practicalswift opened pull request #13115: Add Clang thread safety annotations for variables guarded by cs_addrMan (master...guarded-by-cs_addrMan) https://github.com/bitcoin/bitcoin/pull/13115
< bitcoin-git> [bitcoin] practicalswift opened pull request #13114: Add Clang thread safety annotations for variables guarded by cs_KeyStore (master...guarded-by-cs_KeyStore) https://github.com/bitcoin/bitcoin/pull/13114
< bitcoin-git> [bitcoin] practicalswift opened pull request #13113: tests: Make it clear that MAX_INV_SZ is not covered by functional tests (master...add-note-about-MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13113
< pierre_rochard> Thanks instagibbs! I have some more ideas for v2 here: https://github.com/PierreRochard/bitcoin-acks/blob/acks/README.md If anyone has questions / comments, I’m happy to field them
< bitcoin-git> [bitcoin] achow101 opened pull request #13112: Have gArgs be aware of the arguments and error on unknown args (master...gargs-know-args) https://github.com/bitcoin/bitcoin/pull/13112

2018-04-28

< bitcoin-git> [bitcoin] promag closed pull request #13070: Split event handlers by wallet (master...2018-04-split-handlers-by-wallet) https://github.com/bitcoin/bitcoin/pull/13070
< bitcoin-git> [bitcoin] promag opened pull request #13111: [WIP] Add unloadwallet RPC (master...2018-04-unload-wallet) https://github.com/bitcoin/bitcoin/pull/13111
< mammonpan71> i send from my bitcoin core wallet two amounts at the same time one was received the other was not , its been 24 hrs
< sipa> #bitcoin or bitcoin.stackexchange.com for support
< bitcoin-git> [bitcoin] mryandao opened pull request #13109: [rpc] nit: fix typo for entry description string (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13109
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13107: Fix Windows locale problem (master...win-enc) https://github.com/bitcoin/bitcoin/pull/13107
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13077: Add compile time checking for all cs_KeyStore runtime locking assertions (master...cs_KeyStore) https://github.com/bitcoin/bitcoin/pull/13077
< bitcoin-git> bitcoin/master 3315007 MarcoFalke: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions...
< bitcoin-git> bitcoin/master 66dc662 practicalswift: Add compile time checking for all cs_KeyStore runtime locking assertions
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/17266a13067c...3315007e03f5
< gribble> https://github.com/bitcoin/bitcoin/issues/13099 | Use thread names in logs and deadlock diagnostics by jamesob · Pull Request #13099 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13077 | Add compile time checking for all cs_KeyStore runtime locking assertions by practicalswift · Pull Request #13077 · bitcoin/bitcoin · GitHub

2018-04-27

< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #13106: Simplify semantics of ChainStateFlushed callback (master...2018-04-wallet-flush-better-criteria) https://github.com/bitcoin/bitcoin/pull/13106
< bitcoin-git> [bitcoin] jamesob opened pull request #13105: [qa] Add --failfast option to functional test runner (master...2018-04-testrunner-failfast) https://github.com/bitcoin/bitcoin/pull/13105
< bitcoin-git> [bitcoin] laanwj closed pull request #13090: Remove Safe mode (achow101) (master...2018_04_remove_safemode_rebased) https://github.com/bitcoin/bitcoin/pull/13090
< bitcoin-git> bitcoin/master d8e9a2a Wladimir J. van der Laan: Remove "rpc" category from GetWarnings...
< bitcoin-git> bitcoin/master 2ae705d Andrew Chow: Remove Safe mode
< bitcoin-git> bitcoin/master 7da3b0a Wladimir J. van der Laan: rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/487dcbe80c20...17266a13067c
< gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #13102: for our kids (master...master) https://github.com/bitcoin/bitcoin/pull/13102
< bitcoin-git> [bitcoin] witty67 opened pull request #13102: for our kids (master...master) https://github.com/bitcoin/bitcoin/pull/13102
< Kanmanee> [012f6fd7@gateway/web/freenode/ip.1.47.111.215] has joined #bitcoin-core-dev

2018-04-26

< bitcoin-git> [bitcoin] promag opened pull request #13100: Add menu entry to open wallet (master...2018-04-ui-open-wallet) https://github.com/bitcoin/bitcoin/pull/13100
< bitcoin-git> [bitcoin] jamesob opened pull request #13099: Use thread names in logs and deadlock diagnostics (master...2018-04-26-use-threadnames) https://github.com/bitcoin/bitcoin/pull/13099
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13098: Skip tx-rehashing on historic blocks (master...Mf1804-readPureBlock) https://github.com/bitcoin/bitcoin/pull/13098
< jtimon> to be clear 10757 isn't blocking any work I'm doing on bitcoin core directly either
< jtimon> thanks, perhaps we can put it on https://github.com/bitcoin/bitcoin/projects/8 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/13090 | Remove Safe mode (achow101) by laanwj · Pull Request #13090 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13097 | Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub
< sipa> disabling RPCs is not how the bitcoin ecosystem will deal with an emergency anyway - a lot of infrastructure wouldn't even notice
< instagibbs> sdaftuar, https://github.com/bitcoin/bitcoin/issues/12271 please contribute if this issue helps (ok now done)
< gribble> https://github.com/bitcoin/bitcoin/issues/10563 | Remove safe mode by achow101 · Pull Request #10563 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13090 | Remove Safe mode (achow101) by laanwj · Pull Request #13090 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
< bitcoin-git> [bitcoin] fanquake closed pull request #12583: [WIP] Unit test sub-directories (master...unittest_subdir) https://github.com/bitcoin/bitcoin/pull/12583
< bitcoin-git> [bitcoin] laanwj closed pull request #13002: Do not treat bare multisig outputs as IsMine unless watched (master...201804_cleanismine) https://github.com/bitcoin/bitcoin/pull/13002
< bitcoin-git> bitcoin/master 19fc973 Pieter Wuille: Do not expose SigVersion argument to IsMine...
< bitcoin-git> bitcoin/master fb1dfbb Pieter Wuille: Remove unused IsMine overload
< bitcoin-git> bitcoin/master 952d821 Pieter Wuille: Make CScript -> CScriptID conversion explicit
< bitcoin-git> [bitcoin] laanwj pushed 10 new commits to master: https://github.com/bitcoin/bitcoin/compare/8d045a0f66df...487dcbe80c20
< bitcoin-git> [bitcoin] laanwj closed pull request #13003: qa: Add test for orphan handling (master...Mf1804-qaOrphans) https://github.com/bitcoin/bitcoin/pull/13003
< bitcoin-git> bitcoin/master 8d045a0 Wladimir J. van der Laan: Merge #13003: qa: Add test for orphan handling...
< bitcoin-git> bitcoin/master fa02c5b MarcoFalke: qa: Clarify documentation for send_txs_and_test
< bitcoin-git> bitcoin/master fadfbd3 MarcoFalke: qa: Add test for orphan handling
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/826acc9a3d02...8d045a0f66df
< bitcoin-git> [bitcoin] promag opened pull request #13097: Support wallets loaded dynamically (master...2018-04-ui-wallet-loaded) https://github.com/bitcoin/bitcoin/pull/13097
< bitcoin-git> [bitcoin] jl2012 opened pull request #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check (master...max_std_tx_weight) https://github.com/bitcoin/bitcoin/pull/13096
< bitcoin-git> [bitcoin] fanquake opened pull request #13095: build: update ax_boost_chrono/unit_test_framework (master...sync-boost-ax-chrono-unit-test) https://github.com/bitcoin/bitcoin/pull/13095
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13094
< bitcoin-git> [bitcoin] fanquake opened pull request #13093: [0.15] backport: depends qt patches (0.15...0-15-depends-qt-backport) https://github.com/bitcoin/bitcoin/pull/13093
< bitcoin-git> [bitcoin] fanquake opened pull request #13091: [0.15] doc: Add compilation note to README.md (0.15...0-15-0-readme) https://github.com/bitcoin/bitcoin/pull/13091
< Randolf> This channel is focused on Bitcoin Core code development. The question you ask seems to be a more general one.
< Randolf> bitcoin20: That's a good question for the #bitcoin channel. Please ask there.
< bitcoin-git> [bitcoin] laanwj closed pull request #13031: Fix for utiltime to compile with msvc. (master...msvc_gmtime) https://github.com/bitcoin/bitcoin/pull/13031
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eac067ad5962...826acc9a3d02
< bitcoin-git> bitcoin/master abd58a2 Aaron Clauson: Fix for utiltime to compile with msvc.
< bitcoin-git> bitcoin/master 826acc9 Wladimir J. van der Laan: Merge #13031: Fix for utiltime to compile with msvc....
< gribble> https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
< fanquake> Spent a good while compiling/installing bitcoin-qt for Windows and the .exe just refuses to run. 0 output at all.
< bitcoin-git> [bitcoin] laanwj closed pull request #10563: Remove safe mode (master...rm-safemode) https://github.com/bitcoin/bitcoin/pull/10563
< bitcoin-git> [bitcoin] laanwj opened pull request #13090: Remove Safe mode (rebased) (master...2018_04_remove_safemode_rebased) https://github.com/bitcoin/bitcoin/pull/13090
< gribble> https://github.com/bitcoin/bitcoin/issues/10563 | Remove safe mode by achow101 · Pull Request #10563 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #9443: Repairing the large-work fork warning system (master...forkwarning) https://github.com/bitcoin/bitcoin/pull/9443
< bitcoin-git> [bitcoin] fanquake closed pull request #11523: [Refactor] CValidation State (master...dos-cleanup) https://github.com/bitcoin/bitcoin/pull/11523
< bitcoin-git> [bitcoin] laanwj closed pull request #12321: p2wsh and p2sh-p2wsh address in decodescript (master...decodescript-p2wsh) https://github.com/bitcoin/bitcoin/pull/12321
< bitcoin-git> bitcoin/master eac067a Wladimir J. van der Laan: Merge #12321: p2wsh and p2sh-p2wsh address in decodescript...
< bitcoin-git> bitcoin/master 41ff967 fivepiece: list the types of scripts we should consider for a witness program
< bitcoin-git> bitcoin/master 4f933b3 fivepiece: p2wpkh, p2wsh and p2sh-nested scripts in decodescript...
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6f8b3453f8a3...eac067ad5962
< bitcoin-git> [bitcoin] laanwj closed pull request #11231: Improve netaddress implementation (master...refactor/safe-netaddress) https://github.com/bitcoin/bitcoin/pull/11231
< bitcoin-git> [bitcoin] fanquake closed pull request #12152: [WIP] misc. backwards compatibility tests (master...previous-release-segwit-wallet-test) https://github.com/bitcoin/bitcoin/pull/12152
< gribble> https://github.com/bitcoin/bitcoin/issues/11231 | Improve netaddress implementation by danra · Pull Request #11231 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12300: [Build] Adding --enable-mainnet configuration option for running mainnet (master...mainnet_chain_config) https://github.com/bitcoin/bitcoin/pull/12300
< bitcoin-git> [bitcoin] laanwj closed pull request #12158: Avoid unnecessary copy of objects. (master...avoid_copies) https://github.com/bitcoin/bitcoin/pull/12158
< bitcoin-git> [bitcoin] laanwj closed pull request #12169: Avoid temporary copies in C++11 ranged-based for loops. (master...remove_loop_implicit_casts) https://github.com/bitcoin/bitcoin/pull/12169
< bitcoin-git> [bitcoin] laanwj closed pull request #12183: Make use of emplace in nonassociative containers. (master...use_emplace) https://github.com/bitcoin/bitcoin/pull/12183
< bitcoin-git> [bitcoin] ajtowns opened pull request #13088: Log early messages with -printtoconsole (master...earlyconsolelog) https://github.com/bitcoin/bitcoin/pull/13088
< gribble> https://github.com/bitcoin/bitcoin/issues/12009 | Cant build on macOS Sierra: likely a boost c++11 error? · Issue #12009 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11809 | gui: Fix proxy setting options dialog crash by laanwj · Pull Request #11809 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #13068: tests: Remove unused constant MAX_INV_SZ (master...MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13068
< gribble> https://github.com/bitcoin/bitcoin/issues/12384 | [Docs] Add version footnote to tor.md by Willtech · Pull Request #12384 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13041 | build: Add linter checking for accidental introduction of locale dependence by practicalswift · Pull Request #13041 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/12240
< bitcoin-git> bitcoin/master 6f8b345 Wladimir J. van der Laan: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC...
< bitcoin-git> bitcoin/master 7de1de7 mryandao: Add new fee structure with all sub-fields denominated in BTC
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/646b7f6abe73...6f8b3453f8a3
< gribble> https://github.com/bitcoin/bitcoin/issues/12240 | [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12881 | Tighten up bech32::Decode(); add tests. by murrayn · Pull Request #12881 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13075 | Remove account API from wallet functional tests by jnewbery · Pull Request #13075 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12997: [doc] build-windows: Switch to Artful, since Zesty is EOL (master...Mf1804-docBuildWinArtful) https://github.com/bitcoin/bitcoin/pull/12997
< bitcoin-git> bitcoin/master 646b7f6 Wladimir J. van der Laan: Merge #12997: [doc] build-windows: Switch to Artful, since Zesty is EOL...
< bitcoin-git> bitcoin/master fad2958 MarcoFalke: [doc] build-windows: Switch to Artful, since Zesty is EOL
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a07e8caa5d50...646b7f6abe73
< wumpus> anyhow no that's not a good fit for bitcoin core...
< bitcoin-git> [bitcoin] sipa closed pull request #13033: Build txindex in parallel with validation (master...txindex-refactor-take2) https://github.com/bitcoin/bitcoin/pull/13033
< bitcoin-git> bitcoin/master 34d68bf Jim Posen: [index] Create new TxIndex class....
< bitcoin-git> bitcoin/master c88bcec Jim Posen: [db] Migration for txindex data to new, separate database.
< bitcoin-git> bitcoin/master 0cb8303 Jim Posen: [db] Create separate database for txindex....
< bitcoin-git> [bitcoin] sipa pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/24106a85b3f6...a07e8caa5d50
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13082: Tests: don't test against min relay fee information in mining_prioritisetransaction.py (master...dont-hardcode-134) https://github.com/bitcoin/bitcoin/pull/13082
< bitcoin-git> bitcoin/master 24106a8 MarcoFalke: Merge #13082: Tests: don't test against min relay fee information in mining_prioritisetransaction.py...
< bitcoin-git> bitcoin/master bd9d67b Kristaps Kaupe: Don't test against min relay fee information in mining_prioritisetransaction.py...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/25ad2f75f5d1...24106a85b3f6
< bitcoin-git> [bitcoin] ryanofsky closed pull request #12275: Improve ScanForWalletTransactions return value (master...pr/scanstat) https://github.com/bitcoin/bitcoin/pull/12275

2018-04-25

< bitcoin-git> [bitcoin] sipa opened pull request #13084: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (master...201804_keepnegone) https://github.com/bitcoin/bitcoin/pull/13084
< bitcoin-git> [bitcoin] practicalswift opened pull request #13083: Add compile time checking for all cs_main runtime locking assertions (master...cs_main) https://github.com/bitcoin/bitcoin/pull/13083
< bitcoin-git> [bitcoin] kristapsk opened pull request #13082: Don't test against min relay fee information in mining_prioritisetransaction.py (master...dont-hardcode-134) https://github.com/bitcoin/bitcoin/pull/13082
< bitcoin-git> [bitcoin] practicalswift opened pull request #13081: Add compile time checking for all cs_wallet runtime locking assertions (master...cs_wallet-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/13081
< bitcoin-git> [bitcoin] practicalswift opened pull request #13080: Add compile time checking for all ::mempool.cs runtime locking assertions (master...mempool.cs) https://github.com/bitcoin/bitcoin/pull/13080
< bitcoin-git> [bitcoin] Empact opened pull request #13079: Fix ScanForWalletTransactions to report progress correctly when a pindexStop is supplied (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079
< bitcoin-git> [bitcoin] practicalswift opened pull request #13077: Add compile time checking for all cs_KeyStore runtime locking assertions (master...cs_KeyStore) https://github.com/bitcoin/bitcoin/pull/13077
< jamesob> and if so, would want to piggyback on the bitcoin-* 16 character pthread names or just have some peripheral mapping of boost thread ids to arbitrary length names?
< bitcoin-git> [bitcoin] Empact opened pull request #13076: Fix ScanForWalletTransactions to return a bool indicating success or failure (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
< bitcoin-git> [bitcoin] jnewbery opened pull request #13075: Remove 'account' API from wallet functional tests (master...remove_functional_tests_accounts) https://github.com/bitcoin/bitcoin/pull/13075
< bitcoin-git> [bitcoin] jnewbery opened pull request #13074: [trivial] Correct help text for `importaddress` RPC (master...importaddress_help_text) https://github.com/bitcoin/bitcoin/pull/13074
< bitcoin-git> [bitcoin] laanwj closed pull request #12830: [qt] [tests] Clarify address book error messages, add tests (master...2018-03-27-send-recv-addressbook-error) https://github.com/bitcoin/bitcoin/pull/12830
< bitcoin-git> bitcoin/master 9c01be1 James O'Beirne: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage...
< bitcoin-git> bitcoin/master 8cdcaee James O'Beirne: [qt] Display more helpful message when adding a send address has failed...
< bitcoin-git> bitcoin/master c5b2770 James O'Beirne: Add purpose arg to Wallet::getAddress...
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/a785bc3667d3...25ad2f75f5d1
< wumpus> jamesob: I get a compile error when I try to compile it against current master: /.../bitcoin/src/qt/test/addressbooktests.cpp:106:5: error: use of undeclared identifier 'vpwallets'; did you mean 'wallet'?
< jamesob> jimpo: I'll do it if you take a look at https://github.com/bitcoin/bitcoin/pull/12830
< gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check (master...2018_04_rpcauth_unittest_outoftree) https://github.com/bitcoin/bitcoin/pull/13073
< bitcoin-git> bitcoin/master a785bc3 MarcoFalke: Merge #13073: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...
< bitcoin-git> bitcoin/master 3e53004 Wladimir J. van der Laan: test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check...