< bitcoin-git>
[bitcoin] fanquake closed pull request #18276: doc: rpcdoc remove redundant type from description#18258 (master...issue#18258) https://github.com/bitcoin/bitcoin/pull/18276
< bitcoin-git>
[bitcoin] yashpatel20 opened pull request #18276: doc: rpcdoc remove redundant type from description#18258 (master...issue#18258) https://github.com/bitcoin/bitcoin/pull/18276
< bitcoin-git>
[bitcoin] kallewoof opened pull request #18275: wallet: error if an explicit fee rate was given but the needed fee rate differed (master...2003-wallet-error-on-feechange) https://github.com/bitcoin/bitcoin/pull/18275
< bitcoin-git>
[bitcoin] kallewoof opened pull request #18274: wallet: set nFeeRet to 0 to avoid garbage value upon error (master...2003-reset-nfeeret) https://github.com/bitcoin/bitcoin/pull/18274
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18270: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero) (master...parsemoney-followup) https://github.com/bitcoin/bitcoin/pull/18270
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17996: tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals (master...fuzzers-float) https://github.com/bitcoin/bitcoin/pull/17996
< bitcoin-git>
bitcoin/master 8f6fb0a practicalswift: tests: Add serialization/deserialization fuzzing for integral types
< bitcoin-git>
bitcoin/master 3c82b92 practicalswift: tests: Add fuzzing harness for functions taking floating-point types as in...
< bitcoin-git>
bitcoin/master c2bd588 practicalswift: Add missing includes
< BlueMatt>
luke-jr: bitcoin core, as a project, maintains packaging scripts for fetching official release binaries and suggests users run those. if you disagree and want to start suggesting users run packages linked against os libs that have a long history of only half-working, its probably something that needs to be discussed as a project, not the two of us.
< BlueMatt>
luke-jr: if someone wants to replace the ppa with something that checks gitian signatures and downloads official binaries, as I've been saying needs to happen ~forever, then maybe its worth maintinaing again. but no one has ever shown a desire to do that, and the ppa has had many issues due to ubuntu insanity. its definitely a bad idea to use those build scripts for bitcoin nodes.
< luke-jr>
BlueMatt: there's been some interest in keeping the PPA using the bitcoin/bitcoin URI; can you add me to the org?
< moneyball>
For the purpose of this discussion, let's say it is a very high probability that Bitcoin 2020 conference may be postponed.
< moneyball>
Coinbase, Stripe, Microsoft, Twitter all strongly encouraging working from home. Lastly, there is a high probability Bitcoin 2020 will be postponed.
< gribble>
https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
< wumpus>
the 0.20.0 feature freeze is in roughly a week, see https://github.com/bitcoin/bitcoin/issues/17432, I think it makes sense to focus review on the feature PRs that have a chance to still make it in
< bitcoin-git>
[bitcoin] dangershony closed pull request #18223: Add new filter type v0 for segwit only Scripts to blockfilterindex (master...nutrino-p2wpkh-filters) https://github.com/bitcoin/bitcoin/pull/18223
< mantoshelis>
It's good idea but unfortunately we don't have enough time resources to implement this. As a result, we choose to perform tests on official Bitcoin testnet. :(
< provoostenator>
mantoshelis: testnet is pretty terrible in general. It might be worth looking into adding Signet support to BitcoinJ. Should be pretty easy: https://en.bitcoin.it/wiki/Signet
< kallewoof>
If anyone has topics they wanna talk about, we could gather those and bring them up after the next PR review, assuming people are up for doing more. I'm not actually sure how #bitcoin-core-dev maintains meeting topic proposals tho.
< bitcoin-git>
[bitcoin] luke-jr reopened pull request #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps or forked process memory spaces (master...lockedpool_dontdump) https://github.com/bitcoin/bitcoin/pull/15600
< MarcoFalke>
And if the exception is handled in the scheduler, it seems overkill to modify Bitcoin Core code for purly (unit) testing needs
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #18232: WIP test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18232
< MarcoFalke>
Well, it might if you change your time zone or system time. But I think Bitcoin Core does not support that anyway?!
< gribble>
https://github.com/bitcoin/bitcoin/issues/18232 | test: Check that wait_until returns if time point is in the past by MarcoFalke · Pull Request #18232 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18249: test: Bump timeouts to accomodate really slow disks (master...2003-testTimeout) https://github.com/bitcoin/bitcoin/pull/18249
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18247: test: Wait for both veracks in add_p2p_connection (master...2003-qaMininodeVerackRace) https://github.com/bitcoin/bitcoin/pull/18247
< bitcoin-git>
[bitcoin] promag opened pull request #18246: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246
< bitcoin-git>
[bitcoin] instagibbs opened pull request #18245: Test some transaction creation with non-empty fee estimator (master...test_est_txn) https://github.com/bitcoin/bitcoin/pull/18245
< bitcoin-git>
[bitcoin] Sjors opened pull request #18244: rpc: have lockUnspents also lock manually selected coins (master...2020/03/rpc_coin_locks) https://github.com/bitcoin/bitcoin/pull/18244
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #18242: Add BIP324 encrypted p2p transport de-/serializer (only used in tests) (master...2020/03/net_v2) https://github.com/bitcoin/bitcoin/pull/18242
< bitcoin-git>
[bitcoin] kallewoof opened pull request #18241: wallet/refactor: refer to CWallet immutably when possible (master...2002-const-fixes) https://github.com/bitcoin/bitcoin/pull/18241
< kallewoof>
sipa, aj, luke-jr: for the record, changing to immutable-CWallet-pointers in places where it made sense (many places did non-const stuff) resulted in 68 changes; see https://github.com/bitcoin/bitcoin/compare/master...kallewoof:2002-const-fixes ... is this something people would concept ack on a PR?
< bitcoin-git>
[bitcoin] meshcollider merged pull request #18224: Make AnalyzePSBT next role calculation simple, correct (master...analyze_psbt_role_simple) https://github.com/bitcoin/bitcoin/pull/18224
< bitcoin-git>
bitcoin/master 1f88624 Samuel Dobson: Merge #18224: Make AnalyzePSBT next role calculation simple, correct
< bitcoin-git>
bitcoin/master 1ef28b4 Gregory Sanders: Make AnalyzePSBT next role calculation simple, correct
< bitcoin-git>
[bitcoin] promag opened pull request #18239: gui: Refactor to drop client and wallet models setters (master...2020-03-drop-setmodel) https://github.com/bitcoin/bitcoin/pull/18239
< bitcoin-git>
[bitcoin] ajtowns opened pull request #18238: net_processing: Retry notfounds with more urgency (master...202002-bump-notfound) https://github.com/bitcoin/bitcoin/pull/18238
< kallewoof>
So, bitcoin core right now seems to lean towards constant func/method parameters to pointers in the form "type* const" (55 instances of "CWallet* const pwallet") over "const type*" (15 instances of "const CWallet*"), but from what I understand, "type* const" means the pointer itself is const (i.e. "pwallet = blarf" is illegal) but the pointed to instance is not const (i.e. pwallet->MutableThing() is legal). I tested this
< bitcoin-git>
[bitcoin] ajtowns opened pull request #18234: scheduler.cpp: Replace boost::mutex,condition_var,chrono with std equivalents (master...202002-scheduler-deboost) https://github.com/bitcoin/bitcoin/pull/18234
2020-02-29
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18232: test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18232
< bitcoin-git>
[bitcoin] instagibbs closed pull request #18214: wallet: Give slightly more understandable advice when needing -fallbackfee (master...fallback_msg) https://github.com/bitcoin/bitcoin/pull/18214
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18225: util: Fail to parse empty string in ParseMoney (master...2002-utilMoney) https://github.com/bitcoin/bitcoin/pull/18225
< bitcoin-git>
[bitcoin] Sjors closed pull request #18220: psbt: AnalyzePSBT set next to"finalizer" when all inputs need finalizing (master...2020/02/analyze_psbt) https://github.com/bitcoin/bitcoin/pull/18220
< bitcoin-git>
[bitcoin] instagibbs opened pull request #18224: Make AnalyzePSBT next role calculation simple, correct (master...analyze_psbt_role_simple) https://github.com/bitcoin/bitcoin/pull/18224
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17921: test: test OP_CSV empty stack fail in feature_csv_activation.py (master...20200113-test-check-for-empty-stack-op_csv) https://github.com/bitcoin/bitcoin/pull/17921
< bitcoin-git>
bitcoin/master 5ffaf88 Sebastian Falbesoner: test: eliminiated magic numbers in feature_csv_activation.py
< bitcoin-git>
bitcoin/master 09f706a Sebastian Falbesoner: test: check for OP_CSV empty stack fail reject reason in feature_csv_activ...
< bitcoin-git>
bitcoin/master cbd345a Sebastian Falbesoner: test: test OP_CSV empty stack fail in feature_csv_activation.py
< bitcoin-git>
[bitcoin] dangershony opened pull request #18223: Add new filer type p2wpkh to blockfilterindex (master...nutrino-p2wpkh-filters) https://github.com/bitcoin/bitcoin/pull/18223
< bitcoin-git>
[bitcoin] Sjors opened pull request #18220: psbt: AnalyzePSBT set next to FINALIZER when all inputs need finalizing (master...2020/02/analyze_psbt) https://github.com/bitcoin/bitcoin/pull/18220
< bitcoin-git>
[bitcoin] instagibbs opened pull request #18214: Give slightly more understandable advice when needing -fallbackfee (master...fallback_msg) https://github.com/bitcoin/bitcoin/pull/18214
< jonasschnelli>
luke-jr: you could register at apple (99$/year) or we could see if we want to sign it with the Bitcoin Core Code Sign Association key.
< luke-jr>
+ imposed by Apple, which the Bitcoin Knots project does not implement.
< luke-jr>
+ to open the Bitcoin Knots .dmg. This is due to new signing requirements
< Kiminuo>
I'll push it to bitcoin repo when I'm sufficiently happy about it
< gribble>
https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] fanquake closed pull request #18174: WIP test: make mockscheduler test more reliable (master...2020-02-fix-scheduler-test) https://github.com/bitcoin/bitcoin/pull/18174
< bitcoin-git>
[bitcoin] fanquake merged pull request #18211: test: Disable mockforward scheduler unit test for now (master...2002-testSchedulerWorkaround) https://github.com/bitcoin/bitcoin/pull/18211
< bitcoin-git>
[bitcoin] fanquake closed pull request #18174: WIP test: make mockscheduler test more reliable (master...2020-02-fix-scheduler-test) https://github.com/bitcoin/bitcoin/pull/18174
< bitcoin-git>
bitcoin/master 4502ed7 fanquake: Merge #18211: test: Disable mockforward scheduler unit test for now
< bitcoin-git>
bitcoin/master fab2527 MarcoFalke: test: Disable mockforward scheduler unit test for now
< bitcoin-git>
[bitcoin] laanwj merged pull request #18167: Fix a violation of C++ standard rules where unions are used for type-punning (master...master) https://github.com/bitcoin/bitcoin/pull/18167
< bitcoin-git>
bitcoin/master e5d47ed Wladimir J. van der Laan: Merge #18167: Fix a violation of C++ standard rules where unions are used ...