2019-02-19

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/904308dca3ff...3e4fd4075381
< bitcoin-git> bitcoin/master e3e1a56 Sjors Provoost: [test] functional: set cwd of nodes to tmpdir
< bitcoin-git> bitcoin/master 3e4fd40 MarcoFalke: Merge #15415: [test] functional: allow custom cwd, use tmpdir as default
< harding> promag: works for me via bitcoin-cli on mainnet using commit 4064d048d6 (master from Sunday). Rebuilding now to try on latest.
< bitcoin-git> [bitcoin] Sjors opened pull request #15441: [doc] build: warn against spaces in working directory (master...2019/02/build_discourage_space) https://github.com/bitcoin/bitcoin/pull/15441
< gmaxwell> I am just imagining a create dialog with a text entry box where you can enter a seed, and then confused users not realizing they can ignore it, googling bitcoin seed and entering in some example they found online.. :P
< bitcoin-git> [bitcoin] AkioNak opened pull request #15439: tests: remove byte.hex() to keep compatibility (master...keep_compatiblity) https://github.com/bitcoin/bitcoin/pull/15439

2019-02-18

< belcher> luke-jr it does, bitcoin core's wallet has the history
< luke-jr> maybe we should take this to #bitcoin
< belcher> its a wrapper around bitcoin core's wallet that speaks the electrum server protocol, so it has no extra indexes and is compatible with pruning etc
< bitcoin-git> [bitcoin] MeshCollider merged pull request #15433: Use a single wallet batch for UpgradeKeyMetadata (master...2019/02/wallet_key_upgrade_batch) https://github.com/bitcoin/bitcoin/pull/15433
< bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f78cd3dd5115...904308dca3ff
< bitcoin-git> bitcoin/master 0bedcba Jonas Schnelli: Use a single wallet batch for UpgradeKeyMetadata
< bitcoin-git> bitcoin/master 904308d MeshCollider: Merge #15433: Use a single wallet batch for UpgradeKeyMetadata
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15437: p2p: Remove remote debugging code (master...Mf1809-noBip61) https://github.com/bitcoin/bitcoin/pull/15437
< gmaxwell> I don't agree that any reduction of block sizes is "up for discussion" in bitcoin core development. Quite the opposite: You have already been privately censured for creating drama in the press for annoucing some absurd reduction fait accompli when you hadn't even brought the subject up with other developers.
< luke-jr> bitcoinEnthusias: the only thing up for discussion at this time is a reduction in block sizes; take this topic to #bitcoin if you want to continue it
< jarthur> bitcoinEnthusias: on the protocol side, sipa has been organizing a BIP for Schnorr signatures. It hasn't officially been proposed yet, and typically an implementation would follow a proposal. https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr.mediawiki if you want to see the current state. bitcoin-dev mailing list a fine place to discuss the proposal
< gribble> https://github.com/bitcoin/bitcoin/issues/15428 | GUI: Add Pairing tab with Tor onion address as copyable text and QR code by luke-jr · Pull Request #15428 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15348: doc: Add separate productivity notes document (master...2019-02-productivity-md) https://github.com/bitcoin/bitcoin/pull/15348
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6ba3f1fdfd88...f78cd3dd5115
< bitcoin-git> bitcoin/master 5b76c31 Carl Dong: doc: Add separate productivity notes document
< bitcoin-git> bitcoin/master f78cd3d MarcoFalke: Merge #15348: doc: Add separate productivity notes document
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15397: Remove manual byte editing in wallet_tx_clone func test (master...wallet_clone_magic) https://github.com/bitcoin/bitcoin/pull/15397
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29e82e460e19...6ba3f1fdfd88
< bitcoin-git> bitcoin/master 6aaa0ab Gregory Sanders: Remove manual byte editing in wallet_tx_clone func test
< bitcoin-git> bitcoin/master 6ba3f1f MarcoFalke: Merge #15397: Remove manual byte editing in wallet_tx_clone func test
< instagibbs> crised, #bitcoin-dev or #bitcoin for general development questions
< crised> Where can I learn the basics of bitcoin from developer point of view?
< bitcoin-git> [bitcoin] domob1812 opened pull request #15435: Add missing #include (master...fix-include) https://github.com/bitcoin/bitcoin/pull/15435
< bitcoin-git> [bitcoin] laanwj merged pull request #15250: Use RdSeed when available, and reduce RdRand load (master...201901_rdseed) https://github.com/bitcoin/bitcoin/pull/15250
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5a623eb66c8...29e82e460e19
< bitcoin-git> bitcoin/master 1435fab Pieter Wuille: Use RdSeed when available, and reduce RdRand load
< bitcoin-git> bitcoin/master 29e82e4 Wladimir J. van der Laan: Merge #15250: Use RdSeed when available, and reduce RdRand load
< bitcoin-git> [bitcoin] laanwj merged pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) https://github.com/bitcoin/bitcoin/pull/15429
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b72c787dc8f7...f5a623eb66c8
< bitcoin-git> bitcoin/master a083f75 Gregory Maxwell: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378...
< bitcoin-git> bitcoin/master f5a623e Wladimir J. van der Laan: Merge #15429: Update assumevalid, minimumchainwork, and getchaintxstats to...
< gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< gmaxwell> using bitcoin-cli over ssh is pretty dandy. I assume thats what most people in here do, it's just not super gui-enduser friendly. :)
< gribble> https://github.com/bitcoin/bitcoin/issues/11902 | NAT-PMP port forwarding support · Issue #11902 · bitcoin/bitcoin · GitHub
< gmaxwell> take a step back. I believe the history of this discussion is that luke told someone somewhere don't use wallet X (some untrusted server SPV thing) because its insecure. Then someone said something like "well obviously I'm not going to run bitcoin core on my phone so how should I solve this"?
< gmaxwell> provoostenator: it is because you don't need to know essentially anything about bitcoin.
< echeveria> what I don't want to deal with is the bitcoin project being responsible for a bunch of people running outdated, vulnerable tor software that's doing nothing but harm them. include some scripts for setting this up in contrib/ if people really want it. I certainly do not.
< provoostenator> wumpus: I tend to agree that remote control is a more generic internet problem that can be solved outside of Bitcoin.
< wumpus> remote control over bitcoin P2P? what?
< wumpus> routing your traffic over a relay would make zero sense for the bitcoin protocol as all the data is public
< gribble> https://github.com/bitcoin/bitcoin/issues/12288 | [WIP][NET] Add NATPMP support. by annanay25 · Pull Request #12288 · bitcoin/bitcoin · GitHub
< wumpus> also I've always believed the way forward would be to improve the bitcoin protocol itself; BIP150/151, Dandelion, as well as lightning onion routing
< aj> https://github.com/bitcoin/bitcoin/pull/12288 <-- there was a pr a while ago
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15433: Use a single wallet batch for UpgradeKeyMetadata (master...2019/02/wallet_key_upgrade_batch) https://github.com/bitcoin/bitcoin/pull/15433

2019-02-17

< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4064d048d61c...b72c787dc8f7
< bitcoin-git> bitcoin/master 8a1f0a3 Chun Kuan Lee: scripted-diff: Remove NDEBUG pre-define
< bitcoin-git> bitcoin/master 3ec56be Chun Kuan Lee: appveyor: Remove unused NDEBUG removal
< bitcoin-git> bitcoin/master b72c787 MarcoFalke: Merge #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project fil...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project file (master...msvc-no-ndebug) https://github.com/bitcoin/bitcoin/pull/15431
< wumpus> but tor is illegal in some countries where bitcoin is not so coupling them as the only option is a bad idea
< wumpus> I don't think we should be shipping tor binaries at all, at least not with the default download, I'm fine with a "tor bitcoin core" bundle
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15431: msvc: scripted-diff: Remove NDEBUG pre-define in project file (master...msvc-no-ndebug) https://github.com/bitcoin/bitcoin/pull/15431
< bitcoin-git> [bitcoin] practicalswift closed pull request #15215: rpc: Use the return value of GetProxy(...) in GetNetworksInfo(). Mark GetProxy(...) with [[nodiscard]]. (master...getnetworkinfo-getproxy) https://github.com/bitcoin/bitcoin/pull/15215
< gmaxwell> sipa: as requested, https://github.com/bitcoin/bitcoin/pull/15429 you might want to 0.18 tag.
< bitcoin-git> [bitcoin] gmaxwell opened pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) https://github.com/bitcoin/bitcoin/pull/15429
< gmaxwell> luke-jr: no, but if you care about authentication the bitcoin crypto/auth proposals are better for that...
< gmaxwell> like will we have to do emergency releases whenever tor has a vuln? ... will we finally get rid of the openssl induced firedrills in bitcoin only to regain them via tor? etc..
< bitcoin-git> [bitcoin] luke-jr opened pull request #15428: GUI: Add Pairing tab with Tor onion address as copyable text and QR code (master...tor_gui_pairing) https://github.com/bitcoin/bitcoin/pull/15428
< bitcoin-git> [bitcoin] laanwj merged pull request #15425: [Doc] add missing newline to listunspent help for witnessScript (master...2019-02-help-listunspent-missing-newline) https://github.com/bitcoin/bitcoin/pull/15425
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d0337992d81...4064d048d61c
< bitcoin-git> bitcoin/master d3661a3 David A. Harding: [Doc] add missing newline to witnessScript in listunspent help
< bitcoin-git> bitcoin/master 4064d04 Wladimir J. van der Laan: Merge #15425: [Doc] add missing newline to listunspent help for witnessScr...
< bitcoin-git> [bitcoin] laanwj merged pull request #15426: [Doc] importmulti: add missing description of keypool option (master...2019-02-importmulti-keypool) https://github.com/bitcoin/bitcoin/pull/15426
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9c190044df8...2d0337992d81
< bitcoin-git> bitcoin/master a607c9a David A. Harding: [Doc] importmulti: add missing description of keypool option
< bitcoin-git> bitcoin/master 2d03379 Wladimir J. van der Laan: Merge #15426: [Doc] importmulti: add missing description of keypool option...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f60d029a2a76...e9c190044df8
< bitcoin-git> bitcoin/master d067e81 Chun Kuan Lee: msvc: add rapid check property tests
< bitcoin-git> bitcoin/master e9c1900 Wladimir J. van der Laan: Merge #15398: msvc: add rapidcheck property tests
< bitcoin-git> [bitcoin] laanwj merged pull request #15398: msvc: add rapidcheck property tests (master...appveyor-rapid-check) https://github.com/bitcoin/bitcoin/pull/15398
< bitcoin-git> [bitcoin] sipa opened pull request #15427: Add support for descriptors to utxoupdatepsbt (master...201902_utxoupdatepsbtdesc) https://github.com/bitcoin/bitcoin/pull/15427

2019-02-16

< bitcoin-git> [bitcoin] harding opened pull request #15426: [Doc] importmulti: add missing description of keypool option (master...2019-02-importmulti-keypool) https://github.com/bitcoin/bitcoin/pull/15426
< bitcoin-git> [bitcoin] harding opened pull request #15425: [Doc] add missing newline to listunspent help for witnessScript (master...2019-02-help-listunspent-missing-newline) https://github.com/bitcoin/bitcoin/pull/15425
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d5b929c813ff...f60d029a2a76
< bitcoin-git> bitcoin/master 3b40bff Pieter Wuille: Descriptor checksum
< bitcoin-git> bitcoin/master b52cb63 Pieter Wuille: Add getdescriptorinfo to compute checksum
< bitcoin-git> bitcoin/master be62903 Pieter Wuille: Make descriptor checksums mandatory in deriveaddresses and importmulti
< bitcoin-git> [bitcoin] laanwj merged pull request #15368: Descriptor checksums (master...201902_descsum) https://github.com/bitcoin/bitcoin/pull/15368
< bitcoin-git> [bitcoin] Sjors opened pull request #15424: [wallet] wallet-tool: command to remove key metadata (master...2019/02/wallet_tool_remove_metadata) https://github.com/bitcoin/bitcoin/pull/15424
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/f9d50e83e290...d5b929c813ff
< bitcoin-git> bitcoin/master 7344a7b Andrew Chow: Implement utxoupdatepsbt RPC and tests
< bitcoin-git> bitcoin/master 08f749c Andrew Chow: Implement joinpsbts RPC and tests
< bitcoin-git> bitcoin/master cb40b3a Andrew Chow: Figure out what is missing during signing
< bitcoin-git> [bitcoin] laanwj merged pull request #13932: Additional utility RPCs for PSBT (master...psbt-util-rpcs) https://github.com/bitcoin/bitcoin/pull/13932
< achow101> harding: i do. I think it's because bitcoin has a lot of objects which the garbage collector cleans up every so often.
< harding> achow101: do you use worktrees with any other projects? I do, and I just checked a few and didn't find any of them broken (even ones on the same qube as my bitcoin repository). I don't know what would distinguish bitcoin from other repositories I use; the only thing I can think of is that it's the largest (size and object count) that I use with worktrees.
< harding> achow101: my git worktrees for the bitcoin repository also broke inexplicably two days ago in between my uses of them. I thought maybe something on my system broke them (I use Qubes 4 + Debian 9), e.g. some symlink was lost, but now I'm wondering if it was something else.
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15410: test: txindex: interrupt threadGroup before calling destructor (master...Mf1902-testIndexInterr) https://github.com/bitcoin/bitcoin/pull/15410
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/743c2f461c0e...f9d50e83e290
< bitcoin-git> bitcoin/master fab6b07 MarcoFalke: test: txindex: interrupt threadGroup before calling destructor
< bitcoin-git> bitcoin/master f9d50e8 MarcoFalke: Merge #15410: test: txindex: interrupt threadGroup before calling destruct...
< bitcoin-git> [bitcoin] luke-jr opened pull request #15423: torcontrol: Query Tor for correct -onion configuration (master...tor_socks_port) https://github.com/bitcoin/bitcoin/pull/15423
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr reopened pull request #11803: Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet (master...bugfix_dumpwallet_hdkeypath) https://github.com/bitcoin/bitcoin/pull/11803
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< warren> midnightmagic: https://github.com/bitcoin/bitcoin/pull/15277 it needs more work
< gribble> https://github.com/bitcoin/bitcoin/issues/11803 | Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet by luke-jr · Pull Request #11803 · bitcoin/bitcoin · GitHub

2019-02-15

< bitcoin-git> [bitcoin] luke-jr opened pull request #15421: torcontrol: Launch a private Tor instance when not already running (master...tor_subprocess) https://github.com/bitcoin/bitcoin/pull/15421
< meshcollider> provoostenator: re https://github.com/bitcoin/bitcoin/pull/11803#issuecomment-464082302 I'm not sure the same thing Luke was changing has been done?
< bitcoin-git> [bitcoin] luke-jr closed pull request #11803: Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet (master...bugfix_dumpwallet_hdkeypath) https://github.com/bitcoin/bitcoin/pull/11803
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15399: fuzz: Script validation flags (master...Mf1902-fuzzSoft) https://github.com/bitcoin/bitcoin/pull/15399
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/95801902b987...743c2f461c0e
< bitcoin-git> bitcoin/master fabcfa5 MarcoFalke: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp
< bitcoin-git> bitcoin/master fab15ff MarcoFalke: fuzz: Script validation flags
< bitcoin-git> bitcoin/master 743c2f4 MarcoFalke: Merge #15399: fuzz: Script validation flags
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13932: Additional utility RPCs for PSBT (master...psbt-util-rpcs) https://github.com/bitcoin/bitcoin/pull/13932
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #13932: Additional utility RPCs for PSBT (master...psbt-util-rpcs) https://github.com/bitcoin/bitcoin/pull/13932
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eca1273c3500...95801902b987
< bitcoin-git> bitcoin/master 7cee858 practicalswift: Add compile time verification of assumptions we're currently making implic...
< bitcoin-git> bitcoin/master 9580190 Wladimir J. van der Laan: Merge #15391: Add compile time verification of assumptions we're currently...
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15419: qa: Always refresh rotten cache to be out of ibd (master...Mf1902-mocktime) https://github.com/bitcoin/bitcoin/pull/15419
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15383: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx (master...Mf1902-rpcMining) https://github.com/bitcoin/bitcoin/pull/15383
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bf3677a6bb48...eca1273c3500
< bitcoin-git> bitcoin/master fa178a6 MarcoFalke: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx
< bitcoin-git> bitcoin/master eca1273 MarcoFalke: Merge #15383: [rpc] mining: Omit uninitialized currentblockweight, current...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d2767c2287e...bf3677a6bb48
< bitcoin-git> bitcoin/master 88a91e2 Sjors Provoost: [build] AppVeyor: clean cache when build configuration changes
< bitcoin-git> bitcoin/master bf3677a MarcoFalke: Merge #15405: [build] AppVeyor: clean cache when build configuration chang...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c576979b78b5...4d2767c2287e
< bitcoin-git> bitcoin/master 543ef7d practicalswift: tests: Add missing cs_main locks required when accessing pcoinsdbview, pco...
< bitcoin-git> bitcoin/master 4d2767c MarcoFalke: Merge #15413: tests: Add missing cs_main locks required when accessing pco...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15413: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (master...validation-cs_main-tests) https://github.com/bitcoin/bitcoin/pull/15413
< bitcoin-git> [bitcoin] fanquake opened pull request #15416: doc: update FreeBSD build guide for 12.0 (master...docs-freebsd-120) https://github.com/bitcoin/bitcoin/pull/15416
< bitcoin-git> [bitcoin] Sjors opened pull request #15415: [test] functional: set node cwd to datadir (master...2019/02/test_cwd) https://github.com/bitcoin/bitcoin/pull/15415
< bitcoin-git> [bitcoin] Sjors opened pull request #15414: [wallet] allow adding pubkeys from imported private keys to keypool (master...2019/02/keypool_import_private_keys) https://github.com/bitcoin/bitcoin/pull/15414
< bitcoin-git> [bitcoin] practicalswift opened pull request #15413: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (master...validation-cs_main-tests) https://github.com/bitcoin/bitcoin/pull/15413
< bitcoin-git> [bitcoin] yunchiri closed pull request #15396: docs: make it clearer that posix mode must be used in WSL (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15396
< gmaxwell> bitcoin specific, not that I'm aware of. There is a lot of lit on 'network coding' though, which covers many of these things.
< gribble> https://github.com/bitcoin/bitcoin/issues/81533 | HTTP Error 404: Not Found
< sipa> Mischa010: this sounds like a question for https://bitcoin.stackexchange.com
< Mischa010> hi there, does anyone here know to how many peers bitcoin sends new blocks in general?
< gmaxwell> jb55: https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki#Bech32 no, look at the table there. Visually similar characters like q/g or q/p are arranged so that their value differes only by 1 bit.
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< meshcollider> The segwit project (https://github.com/bitcoin/bitcoin/projects/5) is now empty

2019-02-14

< bitcoin-git> [bitcoin] MeshCollider merged pull request #14075: Import watch only pubkeys to the keypool if private keys are disabled (master...watch-only-keypool) https://github.com/bitcoin/bitcoin/pull/14075
< bitcoin-git> [bitcoin] MeshCollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8d0ec74801f7...c576979b78b5
< bitcoin-git> bitcoin/master 99cccb9 Andrew Chow: Add a method to add a pubkey to the keypool
< bitcoin-git> bitcoin/master 9b81fd1 Andrew Chow: Fetch keys from keypool when private keys are disabled
< bitcoin-git> bitcoin/master 513719c Andrew Chow: Add option to importmulti add an imported pubkey to the keypool
< Aequitas_> Hello, is there a valid bitcoin core binary release signing key? It looks like the key with fingerprint 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964 expired today.
< bitcoin-git> [bitcoin] MeshCollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/33480c636658...8d0ec74801f7
< bitcoin-git> bitcoin/master c45415f Andrew Chow: Refactor keymetadata writing to a separate method
< bitcoin-git> bitcoin/master e7652d3 Andrew Chow: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
< bitcoin-git> bitcoin/master bac8c67 Andrew Chow: Add a method to CWallet to write just CKeyMetadata
< bitcoin-git> [bitcoin] MeshCollider merged pull request #14021: Import key origin data through descriptors in importmulti (master...import-multi-hd) https://github.com/bitcoin/bitcoin/pull/14021
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31f7c6dd2152...33480c636658
< bitcoin-git> bitcoin/master 0890339 Sjors Provoost: build: prefer python3.4 even if newer versions are present on the system
< bitcoin-git> bitcoin/master 33480c6 MarcoFalke: Merge #15285: build: Prefer Python 3.4 even if newer versions are present ...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15285: build: Prefer Python 3.4 even if newer versions are present on the system (master...2019/01/bitcoin-util-test-python) https://github.com/bitcoin/bitcoin/pull/15285
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/642bd7bbe747...31f7c6dd2152
< bitcoin-git> bitcoin/master fa7ca8e MarcoFalke: qa: Add test/fuzz/test_runner.py
< bitcoin-git> bitcoin/master fa535af MarcoFalke: fuzz: test_runner: Better error message when built with afl
< bitcoin-git> bitcoin/master 31f7c6d MarcoFalke: Merge #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15411: travis: Combine --disable-bip70 into existing job (master...Mf1902-travisBIP70) https://github.com/bitcoin/bitcoin/pull/15411
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3facd9fdc4dd...642bd7bbe747
< bitcoin-git> bitcoin/master eeeee58 MarcoFalke: travis: Combine --disable-bip70 into existing job
< bitcoin-git> bitcoin/master 642bd7b MarcoFalke: Merge #15411: travis: Combine --disable-bip70 into existing job
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cd8ca8be31ab...3facd9fdc4dd
< bitcoin-git> bitcoin/master 314784a MeshCollider: Make listunspent and signrawtransaction RPCs support witnessScript
< bitcoin-git> bitcoin/master 928beae MeshCollider: Add test for P2SH-P2WSH in signrawtransactionwithkey and listunspent
< bitcoin-git> bitcoin/master 6ca836a MeshCollider: Add release note for listunspent P2WSH change
< bitcoin-git> [bitcoin] laanwj merged pull request #14481: Add P2SH-P2WSH support to listunspent RPC (master...201810_listunspent_wsh) https://github.com/bitcoin/bitcoin/pull/14481
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7456e6bf9d1...cd8ca8be31ab
< bitcoin-git> bitcoin/master 7257353 Pieter Wuille: Select orphan transaction uniformly for eviction
< bitcoin-git> bitcoin/master cd8ca8b MarcoFalke: Merge #14626: Select orphan transaction uniformly for eviction
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #14626: Select orphan transaction uniformly for eviction (master...201810_uniform_orphan_eviction) https://github.com/bitcoin/bitcoin/pull/14626
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3b33cbc2b60d...b7456e6bf9d1
< bitcoin-git> bitcoin/master f6122ab João Barbosa: interfaces: Add remove to Wallet
< bitcoin-git> bitcoin/master f77ba34 João Barbosa: gui: Add closeWallet to WalletController
< bitcoin-git> bitcoin/master 94086fb João Barbosa: gui: Add close wallet action
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15195: gui: Add Close Wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15393: build: Bump minimum Qt version to 5.5.1 (master...2019/02/qt-5_5) https://github.com/bitcoin/bitcoin/pull/15393
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/758c6d784da0...3b33cbc2b60d
< bitcoin-git> bitcoin/master fd46c4c Sjors Provoost: Bump minimum Qt version to 5.5.1
< bitcoin-git> bitcoin/master 3b33cbc Jonas Schnelli: Merge #15393: build: Bump minimum Qt version to 5.5.1
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15411: travis: Combine --disable-bip70 into existing job (master...Mf1902-travisBIP70) https://github.com/bitcoin/bitcoin/pull/15411
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15410: test: txindex: interrupt threadGroup before calling destructor (master...Mf1902-testIndexInterr) https://github.com/bitcoin/bitcoin/pull/15410
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15063: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (master...bip70_fallback_to_bip21) https://github.com/bitcoin/bitcoin/pull/15063
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b1df4ba0bec...758c6d784da0
< bitcoin-git> bitcoin/master 9975282 Luke Dashjr: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing
< bitcoin-git> bitcoin/master 113f000 Luke Dashjr: GUI: If BIP70 is disabled, give a proper error when trying to open a payme...
< bitcoin-git> bitcoin/master 84f5315 Luke Dashjr: Travis: Add test without BIP70 (but still full wallet + tests)
< gribble> https://github.com/bitcoin/bitcoin/issues/15393 | build: Bump minimum Qt version to 5.5.1 by Sjors · Pull Request #15393 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15250 | Use RdSeed when available, and reduce RdRand load by sipa · Pull Request #15250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
< wumpus> there's still quite a few PRs open on the 0.18 milestone https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0 though not all are features of course
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b1c7a9d6ae...9b1df4ba0bec
< bitcoin-git> bitcoin/master 4a43eb8 Sjors Provoost: [build] Makefile.am: add rule for src/bitcoin-wallet
< bitcoin-git> bitcoin/master 9b1df4b MarcoFalke: Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15408: Remove unused TransactionError constants (master...Mf1902-TransactionErrorConst) https://github.com/bitcoin/bitcoin/pull/15408
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38989ab03fb7...e3b1c7a9d6ae
< bitcoin-git> bitcoin/master 3c6ef03 Chun Kuan Lee: msvc: Fix silent merge conflict between #13926 and #14372 part II
< bitcoin-git> bitcoin/master e3b1c7a MarcoFalke: Merge #15407: msvc: Fix silent merge conflict between #13926 and #14372 pa...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2452c6cc0a23...38989ab03fb7
< bitcoin-git> bitcoin/master 8c3fdd3 marcoagner: fixes m_assumed_blockchain_size variables values:
< bitcoin-git> bitcoin/master 38989ab MarcoFalke: Merge #15183: [Qt]: fixes m_assumed_blockchain_size variable value
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183
< bitcoin-git> [bitcoin] ken2812221 opened pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
< bitcoin-git> [bitcoin] marcuswin opened pull request #15406: Update links (master...master) https://github.com/bitcoin/bitcoin/pull/15406
< provoostenator> Update: I have no idea how to make the AppVeyor errors on master go away. There's probably some extra configuration needed for bitcoin-wallet, but #15388 doesn't do the trick.
< gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
< gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider merged pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
< gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MeshCollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9c93f5d9fc93...2452c6cc0a23
< bitcoin-git> bitcoin/master 162ffef Glenn Willen: Add pf_invalid arg to std::string DecodeBase{32,64}
< bitcoin-git> bitcoin/master c734aaa Glenn Willen: Split DecodePSBT into Base64 and Raw versions
< bitcoin-git> bitcoin/master 81cd958 Glenn Willen: Factor BroadcastTransaction out of sendrawtransaction
< provoostenator> "bitcoin-wallet.exe : fatal error LNK1120: 14 unresolved externals"
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15404: [test] Remove -txindex to start nodes (master...remove_txindex) https://github.com/bitcoin/bitcoin/pull/15404
< bitcoin-git> [bitcoin] sipa opened pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
< gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub

2019-02-13

< mave> under .config/Bitcoin/Bitcoin-QT.conf
< luke-jr> sipa: assuming you mean ~/.config/Bitcoin/Bitcoin-Qt.conf , he said he already checked it
< sipa> bitcoin-qt has its own config, but i don't know the details
< mave> there is no qt-config that I am aware of aside from bitcoin.conf
< jarthur> Alright, how are you opening Bitcoin-Qt, and are you passing it that conf file at the command line?
< mave> nope, I'm running it from shell just using the command bitcoin-qt, no params
< mave> so, the debug.log says it's using as default data dir /home/roge/.bitcoin which is empty on purpose
< mave> and on the next debug.log line it says it's using as datadir /disco-dos/bitcoin-data/testnet3 which is correct
< mave> 2019-02-13 23:34:57 Default data directory /home/roge/.bitcoin
< mave> 2019-02-13 23:34:57 Using data directory /disco-dos/bitcoin-data/testnet3
< mave> 2019-02-13 23:34:57 Using config file /disco-dos/bitcoin-data/bitcoin.conf
< mave> it says it's using /home/roge/.bitcoin as default data dir
< mave> 2019-02-13 23:34:57 Bitcoin Core version v0.16.0 (release build)
< jarthur> So it says "Using data directory /disco-dos/bitcoin-data/" shortly after that?
< mave> 2019-02-13 23:34:57 Bitcoin Core version v0.16.0 (release build) 2019-02-13 23:34:57 InitParameterInteraction: parameter interaction: -whitelistforcerelay=1 -> setting -whitelistrelay=1 2019-02-13 23:34:57 Assuming ancestors of block 0000000002e9e7b00e1f6dc5123a04aad68dd0f0968d8c7aa45f6640795c37b1 have valid signatures. 2019-02-13 23:34:57 Setting nMinimumChainWork=00000000000000000000000000000000000000000000002
< mave> which is my $HOME/.bitcoin
< mave> Default data directory /home/roge/.bitcoin
< mave> I now understand that bitcoin-qt has some other set of config files under $HOME/.config/Bitcoin
< luke-jr> well, if $HOME/.bitcoin is your datadir ;)
< mave> but I don't when starting bitcoin-qt
< mave> hence my surprise to see that bitcoin-qt could find my datadir
< mave> I thought it would read from $HOME/.bitcoin/bitcoin.conf
< mave> the one that's surprising me is bitcoin-qt
< luke-jr> cat ~/.config/Bitcoin/Bitcoin-Qt.conf
< mave> for this use case it's bitcoin-qt
< mave> yes, it is finding everything correctly (which is unexpected as I deleted $HOME/.bitcoin on purpose)
< luke-jr> mave: bitcoind or bitcoin-qt?
< mave> I'm not telling it and it's finding my /disco-dos/bitcoin-data/ directory :o
< mave> I just start it up with bitcoin-qt
< mave> with an empty $HOME/.bitcoin
< mave> noob question, I've deleted $HOME/.bitcoin/, how does bitcoin-qt know where to find my other datadir correctly? (it does to my surprise)
< mryandao> or it creates a new $HOME/.bitcoin/
< jarthur> Empact: re the runtime \n embedding, should this literal now be a raw-string or escaped slash?: https://github.com/bitcoin/bitcoin/pull/15257/files#diff-dc87c4c96fc5f98c3734a2c16504eb30R88 I only ask since it replaced ones you had changed to be raw in earlier version of the PR.
< gribble> https://github.com/bitcoin/bitcoin/issues/15257 | Scripts and tools: Bump flake8 to 3.6.0 by Empact · Pull Request #15257 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c4a90040dd3...9c93f5d9fc93
< bitcoin-git> bitcoin/master a4b92e4 Hennadii Stepanov: Log full paths for wallets
< bitcoin-git> bitcoin/master 9c93f5d Wladimir J. van der Laan: Merge #15334: wallet: Log absolute paths for the wallets
< bitcoin-git> [bitcoin] laanwj merged pull request #15334: wallet: Log absolute paths for the wallets (master...20190203-wallet-env-log) https://github.com/bitcoin/bitcoin/pull/15334
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15401: rpc: Actually throw help when passed invalid number of params (master...Mf1902-rpcNumArgs) https://github.com/bitcoin/bitcoin/pull/15401
< gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15400 | p2p_invalid_messages test can fail in runner due to stderr text when socket write buffer flushed · Issue #15400 · bitcoin/bitcoin · GitHub
< x4b1d> Fair, I wish that I could break the offline functions into a seperate set of libs provided by bitcoin core but yeah more ot
< wumpus> yea #bitcoin is better for questions like this as they don't involve bitcoin core development
< sipa> #bitcoin