2019-08-07

< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
< bitcoin-git> [bitcoin] practicalswift opened pull request #16561: tests: Add test_runner.py option --parsable (master...parsable) https://github.com/bitcoin/bitcoin/pull/16561
< gribble> https://github.com/bitcoin/bitcoin/issues/16555 | [doc] mention whitelist is inbound, and applies to blocksonly by Sjors · Pull Request #16555 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15558 | Dont query all DNS seeds at once by sipa · Pull Request #15558 · bitcoin/bitcoin · GitHub

2019-08-06

< bitcoin-git> [bitcoin] luke-jr opened pull request #16560: Bugfix: QA: Run tests with UPnP disabled (master...test_without_upnp) https://github.com/bitcoin/bitcoin/pull/16560
< bitcoin-git> [bitcoin] gapeman opened pull request #16559: Unified text outputs (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16559
< bitcoin-git> [bitcoin] fanquake closed pull request #16558: Update headers to 2019 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16558
< bitcoin-git> [bitcoin] gapeman opened pull request #16558: Update headers to 2019 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16558
< bitcoin-git> [bitcoin] jnewbery opened pull request #16557: [wallet] restore coinbase check in SubmitMemoryPoolAndRelay() (master...2019-08-restore-coinbase-check) https://github.com/bitcoin/bitcoin/pull/16557
< jnewbery> The coinbase check was removed here: https://github.com/bitcoin/bitcoin/pull/15713/files#diff-b2bb174788c7409b671c46ccc86034bdL2163 (in PR 15713). I think we should just restore it
< bitcoin-git> [bitcoin] jamesob closed pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b725979a1175...e5fdda68c6d2
< bitcoin-git> bitcoin/master 2f37163 fanquake: test: only include and init openSSL where it's actually used
< bitcoin-git> bitcoin/master e5fdda6 MarcoFalke: Merge #16554: test: only include and use OpenSSL where it's actually neede...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fbe4b7665b97...b725979a1175
< bitcoin-git> bitcoin/master faff85a MarcoFalke: test: Format feature_fee_estimation with pep8
< bitcoin-git> bitcoin/master fa76285 MarcoFalke: test: Explain why -whitelist is used in feature_fee_estimation
< bitcoin-git> bitcoin/master b725979 MarcoFalke: Merge #16535: test: Explain why -whitelist is used in feature_fee_estimati...
< bitcoin-git> [bitcoin] setpill opened pull request #16556: Fix systemd service perms (master...fix-systemd-service-perms) https://github.com/bitcoin/bitcoin/pull/16556
< bitcoin-git> [bitcoin] Sjors opened pull request #16555: [doc] mention whitelist is inbound, and applies to blocksonly (master...2019/08/doc-whitelistrelay) https://github.com/bitcoin/bitcoin/pull/16555
< gribble> https://github.com/bitcoin/bitcoin/issues/15729 | rpc: Raise error in getbalance if minconf is not zero by promag · Pull Request #15729 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
< gribble> https://github.com/bitcoin/bitcoin/issues/16533 | build: disable libxcb extensions by fanquake · Pull Request #16533 · bitcoin/bitcoin · GitHub
< wumpus> fanquake: #2302 seems to be about bitcoin: URLs in general
< gribble> https://github.com/bitcoin/bitcoin/issues/2302 | Double-clicking bitcoin: URI link == duplicate Pay Tos · Issue #2302 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub
< emilengler> Does the argmanager also loads the bitcoin.conf? Or is this being done seperately
< bitcoin-git> [bitcoin] fanquake merged pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31d98584f3c5...fbe4b7665b97
< bitcoin-git> bitcoin/master b2ea20d Kristian Kramer: doc: Fix grammar and punctuation in developer notes
< bitcoin-git> bitcoin/master fbe4b76 fanquake: Merge #16530: doc: Fix grammar and punctuation in developer notes
< bitcoin-git> [bitcoin] fanquake merged pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62117f9f363e...31d98584f3c5
< bitcoin-git> bitcoin/master fa5a4cd MarcoFalke: gui: Generate bech32 addresses by default (take 2, fixup)
< bitcoin-git> bitcoin/master 31d9858 fanquake: Merge #16497: gui: Generate bech32 addresses by default (take 2, fixup)

2019-08-05

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16551: test: Test that low difficulty chain fork is rejected (master...1908-testDosLowHeader) https://github.com/bitcoin/bitcoin/pull/16551
< bitcoin-git> [bitcoin] Sjors opened pull request #16549: [WIP] UI external signer support (e.g. hardware wallet) (master...2019/08/hww-qt) https://github.com/bitcoin/bitcoin/pull/16549
< bitcoin-git> [bitcoin] emilengler closed pull request #16544: rpc: Add rpcallowstop (master...2019-08-rpc-disable-stop-parameter) https://github.com/bitcoin/bitcoin/pull/16544
< bitcoin-git> [bitcoin] mmachicao opened pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
< gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto closed pull request #16508: Disallow double negation syntax (-nofoo=0) for options (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
< bitcoin-git> [bitcoin] Alko89 opened pull request #16547: Check usages of #if defined(...) (master...if-defined-usages) https://github.com/bitcoin/bitcoin/pull/16547
< bitcoin-git> [bitcoin] ajtowns closed pull request #16229: Standardise deployment handling (master...201906-deployments) https://github.com/bitcoin/bitcoin/pull/16229
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d5ea8f4bf39a...62117f9f363e
< bitcoin-git> bitcoin/master 77770d9 MarcoFalke: test: Properly serialize BIP34 coinbase height
< bitcoin-git> bitcoin/master fa8489a MarcoFalke: test: Add test for BIP30 duplicate tx
< bitcoin-git> bitcoin/master 62117f9 MarcoFalke: Merge #16363: test: Add test for BIP30 duplicate tx
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c77f7cdbd1ce...d5ea8f4bf39a
< bitcoin-git> bitcoin/master 68f5466 Ben Woosley: test: Fix “local variable 'e' is assigned to but never used”
< bitcoin-git> bitcoin/master fa8a1d7 MarcoFalke: test: Adapt test framework for chains other than "regtest"
< bitcoin-git> bitcoin/master faf3683 MarcoFalke: test: Avoid hardcoding the chain name in combine_logs
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16197: net: Use mockable time for tx download (master...1906-netMock) https://github.com/bitcoin/bitcoin/pull/16197
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1063fc9cf9b5...c77f7cdbd1ce
< bitcoin-git> bitcoin/master fa883ab MarcoFalke: net: Use mockable time for tx download
< bitcoin-git> bitcoin/master fab3658 Suhas Daftuar: [qa] Test that getdata requests work as expected
< bitcoin-git> bitcoin/master c77f7cd MarcoFalke: Merge #16197: net: Use mockable time for tx download
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16536: doc: Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b6386e85492...1063fc9cf9b5
< bitcoin-git> bitcoin/master 05fdb97 Antoine Riard: [doc] Update and extend benchmarking.md
< bitcoin-git> bitcoin/master 1063fc9 MarcoFalke: Merge #16536: doc: Update and extend benchmarking.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e55444a2a8a2...6b6386e85492
< bitcoin-git> bitcoin/master fa566b2 MarcoFalke: test: Add missing sync_blocks to feature_pruning
< bitcoin-git> bitcoin/master 6b6386e MarcoFalke: Merge #16538: test: Add missing sync_blocks to feature_pruning
< gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub

2019-08-04

< bitcoin-git> [bitcoin] Sjors closed pull request #14912: [WIP] External signer support (e.g. hardware wallet) (master...2018/11/rpc-signer) https://github.com/bitcoin/bitcoin/pull/14912
< bitcoin-git> [bitcoin] Sjors closed pull request #15876: [rpc] signer send and fee bump convenience methods (master...2019/04/signerbumpfee) https://github.com/bitcoin/bitcoin/pull/15876
< bitcoin-git> [bitcoin] Sjors opened pull request #16546: [WIP] External signer support - Wallet Box edition (master...2019/08/hww-box2) https://github.com/bitcoin/bitcoin/pull/16546
< bitcoin-git> [bitcoin] ryanofsky opened pull request #16545: Implement missing error checking for ArgsManager flags (master...pr/argcheck) https://github.com/bitcoin/bitcoin/pull/16545
< bitcoin-git> [bitcoin] fanquake closed pull request #16138: Scripts and tools: Add sudoers.d, rc.local from docs to gitian script (master...gitian-automated-sudoers-br0) https://github.com/bitcoin/bitcoin/pull/16138
< bitcoin-git> [bitcoin] fanquake closed pull request #13612: Qt: Only call tryGetBalances in pollBalanceChanged if the result will be used. (master...bitcoin) https://github.com/bitcoin/bitcoin/pull/13612
< bitcoin-git> [bitcoin] fanquake closed pull request #14125: Add testcase to simulate bitcoin schema in leveldb (master...master) https://github.com/bitcoin/bitcoin/pull/14125
< bitcoin-git> [bitcoin] emilengler opened pull request #16544: rpc: Add rpcallowstop (master...2019-08-rpc-disable-stop-parameter) https://github.com/bitcoin/bitcoin/pull/16544
< elichai2> emilengler: yp need to add `-S` to everyt git command you run that modifies the commits. but an easier way to do this is just run `git config commit.gpgsign true` in your bitcoin dir which will force your git to sign every commit you make in that repo
< bitcoin-git> [bitcoin] fanquake merged pull request #16534: build: add Qt Creator Makefile.am.user to .gitignore (master...patch-3) https://github.com/bitcoin/bitcoin/pull/16534
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3a3d8b835712...e55444a2a8a2
< bitcoin-git> bitcoin/master 0a4e4a0 Peter Bushnell: [build] .gitignore add Qt Creator Makefile.am.user
< bitcoin-git> bitcoin/master e55444a fanquake: Merge #16534: build: add Qt Creator Makefile.am.user to .gitignore

2019-08-03

< emilengler> Hope it's ok to ask this question here, because I need it for Bitcoin Core development. How can I sign a commit which include squashed commits. Everytime I squash commits the "parent" commit is unsigned
< bitcoin-git> [bitcoin] mmachicao closed pull request #15137: Tests: Contract test for CCoinsView and CCoinsViewBacked (master...coins_contract_tests) https://github.com/bitcoin/bitcoin/pull/15137
< emilengler> Same with Bitcoin Core and FreeBSD for example
< achow101> fun fact, bitcoin 0.1 was released before Windows 7
< sipa> but in https://github.com/bitcoin/bitcoin/blob/v0.3.17/main.cpp you'll find direct calls from main.cpp into the UI :p
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< elichai2> btw if anyone is interested https://github.com/elichai/bitcoin/tree/2019-07-tap-desc (based on a merge between master and sipa/taproot)
< gribble> https://github.com/bitcoin/bitcoin/issues/16528 | [WIP] Native Descriptor Wallets (take 2) by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
< elichai2> yeah, but then I can import a desc and try to sign with it. but I guess i'm trying to do too much, for now i'll test manually and concentrate on adding more tests for the desc and then either ask someone to give my code a quick look (I am pretty new to bitcoin core's code and to c++) or look into PSBT/signing, but only after i'm 100% done with the desc

2019-08-02

< bitcoin-git> [bitcoin] achow101 opened pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
< ghost43> looks like the wallet and the node maximum absolute fees were recently separated: https://github.com/bitcoin/bitcoin/pull/15620
< bitcoin-git> [bitcoin] emilengler opened pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed tag v0.18.1: https://github.com/bitcoin/bitcoin/compare/v0.18.1
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/bfa7183c4e5a...fa27a0760792
< bitcoin-git> bitcoin/0.18 fa27a07 Wladimir J. van der Laan: doc: Bump manpages pre-final
< bitcoin-git> [bitcoin] Sjors opened pull request #16539: [wallet] lower -txmaxfee default from 0.1 to 0.01 BTC (master...2019/08/lower_txmaxfee) https://github.com/bitcoin/bitcoin/pull/16539
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/673919caf72c...bfa7183c4e5a
< bitcoin-git> bitcoin/0.18 bfa7183 Wladimir J. van der Laan: build: set CLIENT_VERSION_RC to 0 pre-final
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/784e218610d4...673919caf72c
< bitcoin-git> bitcoin/0.18 5f5b444 David A. Harding: Doc: remove old release notes about systemd and riscv changes
< bitcoin-git> bitcoin/0.18 673919c Wladimir J. van der Laan: Merge #16532: [0.18] Doc: remove old release notes about systemd and riscv...
< bitcoin-git> [bitcoin] laanwj merged pull request #16532: [0.18] Doc: remove old release notes about systemd and riscv changes (0.18...2019-07-0.18.1-release-notes) https://github.com/bitcoin/bitcoin/pull/16532
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16528 | [WIP] Native Descriptor Wallets (take 2) by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< bitcoin-git> [bitcoin] Sjors closed pull request #15414: [wallet] allow adding pubkeys from imported private keys to keypool (master...2019/02/keypool_import_private_keys) https://github.com/bitcoin/bitcoin/pull/15414
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16097: Refactor: Add Flags enum to ArgsManager class (master...20190526-fix-negated-args) https://github.com/bitcoin/bitcoin/pull/16097
< bitcoin-git> [bitcoin] MarcoFalke pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/be0e8b4bff88...3a3d8b835712
< bitcoin-git> bitcoin/master e0e18a1 Hennadii Stepanov: refactoring: Check IsArgKnown() early
< bitcoin-git> bitcoin/master e0d187d Hennadii Stepanov: Refactor InterpretNegatedOption() function
< bitcoin-git> bitcoin/master 265c1b5 Hennadii Stepanov: Add Flags enum to ArgsManager
< bitcoin-git> [bitcoin] ariard opened pull request #16536: [doc] Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15713: refactor: Replace chain relayTransactions/submitMemoryPool by higher method (master...2019-03-refactor-relay-tx-submit-pool) https://github.com/bitcoin/bitcoin/pull/15713
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d759b5d26a7e...be0e8b4bff88
< bitcoin-git> bitcoin/master 8c8aa19 Antoine Riard: Add BroadcastTransaction utility usage in Chain interface
< bitcoin-git> bitcoin/master 611291c Antoine Riard: Introduce CWalletTx::SubmitMemoryPoolAndRelay
< bitcoin-git> bitcoin/master 8753f56 Antoine Riard: Remove duplicate checks in SubmitMemoryPoolAndRelay
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9f54e9ab9038...d759b5d26a7e
< bitcoin-git> bitcoin/master 4fcb698 Sjors Provoost: [rpc] walletcreatefundedpsbt: use wallet default RBF
< bitcoin-git> bitcoin/master 9ed062b Sjors Provoost: [doc] rpc: remove "fallback to" from RBF default help
< bitcoin-git> bitcoin/master d6b3640 Sjors Provoost: [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15911: Use wallet RBF default for walletcreatefundedpsbt (master...2019/04/walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/15911
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16493: test: Fix test failures (master...1907-testRpcTimeoutBump) https://github.com/bitcoin/bitcoin/pull/16493
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e653eeff7651...9f54e9ab9038
< bitcoin-git> bitcoin/master fa8a823 MarcoFalke: test: Bump rpc_timeout in feature_dbcrash
< bitcoin-git> bitcoin/master fa1bb53 MarcoFalke: test: Add -acceptnonstdtxn to self.extra_args[3]
< bitcoin-git> bitcoin/master fa36aa4 MarcoFalke: Test: Set -acceptnonstdtxn in feature_fee_estimation
< setpill> in https://github.com/bitcoin/bitcoin/blob/master/contrib/init/bitcoind.service#L8-L9, why does the comment state "except for those explicitly specified as arguments in ExecStart="?
< bitcoin-git> [bitcoin] Bushstar opened pull request #16534: [build] .gitignore add Qt Creator Makefile.am.user (master...patch-3) https://github.com/bitcoin/bitcoin/pull/16534
< bitcoin-git> [bitcoin] fanquake reopened pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
< gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16532 | [0.18] Doc: remove old release notes about systemd and riscv changes by harding · Pull Request #16532 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake opened pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533
< fanquake> If anyone's interested, I've put up some notes about doing bitcoin* binary comparisons: https://github.com/fanquake/core-review/blob/master/binary-compare.md
< bitcoin-git> [bitcoin] harding opened pull request #16532: [0.18] Doc: remove old release notes about systemd and riscv changes (0.18...2019-07-0.18.1-release-notes) https://github.com/bitcoin/bitcoin/pull/16532
< bitcoin-git> [bitcoin] Tech1k opened pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530
< bitcoin-git> [bitcoin] achow101 opened pull request #16528: [WIP] Native Descriptor Wallets (take 2) (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/16528
< bitcoin-git> [bitcoin] fanquake closed pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
< gribble> https://github.com/bitcoin/bitcoin/issues/15768 | gui: Add CMD+W shortcut in macOS by IPGlider · Pull Request #15768 · bitcoin/bitcoin · GitHub
< emilengler> Is there a cmake file for bitcoin core?

2019-08-01

< bitcoin-git> [bitcoin] jtimon opened pull request #16527: Get rid of Params().RequireStandard() (master...b19-chainparams-no-requirestd) https://github.com/bitcoin/bitcoin/pull/16527
< bitcoin-git> [bitcoin] jtimon opened pull request #16526: Refactor: Chainparams: readability (master...b19-chainparams-no-istestchain) https://github.com/bitcoin/bitcoin/pull/16526
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16525
< bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16513: [RFC] Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513
< bitcoin-git> [bitcoin] jtimon opened pull request #16524: Truly decouple wallet from chainparams for -fallbackfee (master...b19-true-wallet-no-chainparams) https://github.com/bitcoin/bitcoin/pull/16524
< bitcoin-git> [bitcoin] metalicjames opened pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16522: travis: Run functional tests in GUI once (master...1908-testGuiFun) https://github.com/bitcoin/bitcoin/pull/16522
< sipa> arguably the ML isn't really on topic here, as it's not a bitcoin core thing
< wumpus> that leaves one topic "bitcoin-dev mailing list moderation", which I'm kind of scared of and jonasschnelli isn't here anyway
< wumpus> moneyball: it's backed up to a github repo though, so be sure to pull it regularly :) https://github.com/zw/bitcoin-gh-meta
< emzy> There is a git mirror for Bitcoin in the tor network.
< wumpus> rust-bitcoin is not consensus critical, so the amount at stake for an implementation error is somewhat less their
< BlueMatt> do people think this should be signed or unsigned in rust-bitcoin
< gribble> https://github.com/bitcoin/bitcoin/issues/16513 | [RFC] Switch CTransaction::nVersion to an unsigned integer by TheBlueMatt · Pull Request #16513 · bitcoin/bitcoin · GitHub
< BlueMatt> this came up in rust-bitcoin discussion
< gribble> https://github.com/bitcoin/bitcoin/issues/16363 | test: Add test for BIP30 duplicate tx by MarcoFalke · Pull Request #16363 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16229 | Standardise deployment handling by ajtowns · Pull Request #16229 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16060 | Bury bip9 deployments by jnewbery · Pull Request #16060 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14895 | Package relay design questions · Issue #14895 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16522: travis: Run functional tests in GUI once (master...1908-testGuiFun) https://github.com/bitcoin/bitcoin/pull/16522
< gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Remagpie opened pull request #16521: wallet/rpc: Use the default maxfeerate value as BTC/kB (master...maxfeerate-as-rate) https://github.com/bitcoin/bitcoin/pull/16521
< jonasschnelli> If someone wants to pickup my. topic (bitcoin-dev mailing list moderation), feel free
< gribble> https://github.com/bitcoin/bitcoin/issues/16493 | test: Fix test failures by MarcoFalke · Pull Request #16493 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] dongcarl opened pull request #16519: guix: Change manifest to use channels and inferiors (master...2019-06-guix-channels-and-inferiors) https://github.com/bitcoin/bitcoin/pull/16519
< emilengler> And where is the config file initial be loaded? In src/qt/bitcoin.cpp or src/qt/intro.cpp
< bitcoin-git> [bitcoin] hebasto closed pull request #16476: Use ArgsManager::ALLOW_STRING flag explicitly in simple cases (master...20190727-pr16097-new-flags) https://github.com/bitcoin/bitcoin/pull/16476
< bitcoin-git> [bitcoin] laanwj merged pull request #16277: [Tests] Suppress output in test_bitcoin for expected errors (master...issue-15944) https://github.com/bitcoin/bitcoin/pull/16277
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79816278e2fb...e653eeff7651
< bitcoin-git> bitcoin/master 7a0c224 Gert-Jaap Glasbergen: Suppress output in test_bitcoin for expected errors
< bitcoin-git> bitcoin/master e653eef Wladimir J. van der Laan: Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors
< bitcoin-git> [bitcoin] laanwj merged pull request #16470: test: Fail early on disconnect in mininode.wait_for_* (master...1907-testMininodeNoWaitOnDisconnect) https://github.com/bitcoin/bitcoin/pull/16470
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75656988ac8e...79816278e2fb
< bitcoin-git> bitcoin/master fac2e6a MarcoFalke: test: Fail early on disconnect in mininode.wait_for_*
< bitcoin-git> bitcoin/master 7981627 Wladimir J. van der Laan: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*
< bitcoin-git> [bitcoin] laanwj merged pull request #16514: gui: Remove unused RPCConsole::tabFocus (master...2019-07-remove-unused-tabfocus) https://github.com/bitcoin/bitcoin/pull/16514
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6841b013402d...75656988ac8e
< bitcoin-git> bitcoin/master b078067 João Barbosa: gui: Remove unused RPCConsole::tabFocus
< bitcoin-git> bitcoin/master 7565698 Wladimir J. van der Laan: Merge #16514: gui: Remove unused RPCConsole::tabFocus
< coinmonks> how practicalswift generates status reports every month (https://github.com/bitcoin/bitcoin/issues/16506) ..
< fanquake> wumpus: yep QT_RCC_SOURCE_DATE_OVERRIDE fixed the issues with bitcoin-qt 🤦
< coinmonks> I am online if anyone have any feedback,,or they can just leave private notes on the post itself.. thank you every one for contributing on Bitcoin.. :]
< coinmonks> Hey Guys, I am writing an article around Bitcoin codebase activity, anyone wanna look it and give me some feedback..
< bitcoin-git> [bitcoin] meshcollider merged pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
< gribble> https://github.com/bitcoin/bitcoin/issues/15986 | Add unmodified-descriptor-with-checksum to getdescriptorinfo by sipa · Pull Request #15986 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7fbf74b980e...6841b013402d
< bitcoin-git> bitcoin/master c5d3787 Andrew Chow: Allow createwallet to take empty passwords to make unencrypted wallets
< bitcoin-git> bitcoin/master 6841b01 MeshCollider: Merge #16394: Allow createwallet to take empty passwords to make unencrypt...
< wumpus> no, not using --prefix at the moment, I see a diffrence too between the same commits though, in bitcoin-qt but not bitcoind
< fanquake> I've just done master (b7fbf74b980ebb122ae34b142f2cc49b44b92de3) and a dummy commit, still seeing the same difference in bitcoin-qt.
< wumpus> i don't think i've ever used build-for-compare with bitcoin-qt, at all
< fanquake> Doing a binary comparison of a bitcoin-qt built from HEAD~1 and HEAD~2, building on Debian using depends. Currently seeing this diff: https://gist.github.com/fanquake/653bb42176d7772578db08a0f8e60f11 . Any suggestions as to what could be causing the difference? bitcoind matches.
< bitcoin-git> [bitcoin] fanquake merged pull request #16502: wallet: Drop unused OldKey (master...2019-07-drop-oldkey) https://github.com/bitcoin/bitcoin/pull/16502
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/25f0edd59fee...b7fbf74b980e
< bitcoin-git> bitcoin/master 0b1f4b3 João Barbosa: wallet: Drop unused OldKey
< bitcoin-git> bitcoin/master b7fbf74 fanquake: Merge #16502: wallet: Drop unused OldKey
< gribble> https://github.com/bitcoin/bitcoin/issues/16440 | BIP-322: Generic signed message format by kallewoof · Pull Request #16440 · bitcoin/bitcoin · GitHub
< emilengler> WHere does bitcoin-qt deals with the config?

2019-07-31

< bitcoin-git> [bitcoin] fanquake merged pull request #16448: doc: add note on precedence of options in bitcoin.conf (master...options_bitocin_conf) https://github.com/bitcoin/bitcoin/pull/16448
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5639d71a07db...25f0edd59fee
< bitcoin-git> bitcoin/master fa2f991 Torkel Rogstad: doc: add note on precedence of options in bitcoin.conf
< bitcoin-git> bitcoin/master 25f0edd fanquake: Merge #16448: doc: add note on precedence of options in bitcoin.conf
< emilengler> Maybe with git remote add promap https://github.com/promag/bitcoin.git; git fetch promag; git rebase promag/yourbranch yourbranch
< promag> emilengler: make -j8 -C src/qt bitcoin-qt
< gribble> https://github.com/bitcoin/bitcoin/issues/16515 | gui: Close console with CTRL+D ala terminal by promag · Pull Request #16515 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515
< bitcoin-git> [bitcoin] promag opened pull request #16514: gui: Remove unused RPCConsole::tabFocus (master...2019-07-remove-unused-tabfocus) https://github.com/bitcoin/bitcoin/pull/16514
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16513: Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513
< promag> emilengler: because you can't "terminate" the bitcoin-qt terminal
< emilengler> In bitcoin-qt
< bitcoin-git> [bitcoin] achow101 opened pull request #16512: Shuffle inputs and outputs after joining psbts (master...joinpsbt-rand) https://github.com/bitcoin/bitcoin/pull/16512
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7821821a23b6...5639d71a07db
< bitcoin-git> bitcoin/master fa6fba3 MarcoFalke: test: Make local symbols in run_test members
< bitcoin-git> bitcoin/master faf8318 MarcoFalke: test: Split fundrawtx test into subtests
< bitcoin-git> bitcoin/master 5639d71 MarcoFalke: Merge #16293: test: Make test cases separate functions
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
< bitcoin-git> [bitcoin] hebasto opened pull request #16508: Use ArgsManager::ALLOW_BOOL flag explicitly (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
< bitcoin-git> [bitcoin] instagibbs opened pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
< emilengler> wumpus: Well how does bitcoin-qt then detects when Ctrl+L is pressed? It only works when the console tab is open
< bitcoin-git> [bitcoin] instagibbs closed pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
< MarcoFalke> fanquake: If you leave the label for DrahtBot to remove, it will also remove all its comments and make the comment history shorter/easier to follow. https://github.com/bitcoin/bitcoin/pull/16400#event-2523391791
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f288a1c05eb...7821821a23b6
< bitcoin-git> bitcoin/master 9bc8b28 Antoine Riard: refactor : use RelayTransaction in BroadcastTransaction utility
< bitcoin-git> bitcoin/master 7821821 MarcoFalke: Merge #16452: refactor: use RelayTransaction in BroadcastTransaction utili...
< gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub
< sdaftuar> on the bitcoin main chain, this is not actually a problem (modulo the hypothetical future problem we can have after block 1.9M or whatever it is)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f89113626e42...3f288a1c05eb
< bitcoin-git> bitcoin/master 73b692b João Barbosa: doc: Add release note for the deprecated totalFee option of bumpfee
< bitcoin-git> bitcoin/master 3f288a1 MarcoFalke: Merge #16504: doc: Add release note for the deprecated totalFee option of ...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00922b872027...f89113626e42
< bitcoin-git> bitcoin/master 0646ca5 Aaron Clauson: Changes the verbosity of msbuild from quiet to normal in the appveyor scri...
< bitcoin-git> bitcoin/master f891136 MarcoFalke: Merge #16505: Changes verbosity of msbuild from quiet to normal in the app...
< bitcoin-git> [bitcoin] laanwj merged pull request #15906: [wallet] Move min_depth and max_depth to coin control (master...refactor_available_coins) https://github.com/bitcoin/bitcoin/pull/15906
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8241b5150431...00922b872027
< bitcoin-git> bitcoin/master 80ba424 Amiti Uttarwar: extract min & max depth onto coin control
< bitcoin-git> bitcoin/master 00922b8 Wladimir J. van der Laan: Merge #15906: [wallet] Move min_depth and max_depth to coin control
< bitcoin-git> [bitcoin] sipsorcery opened pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
< bitcoin-git> [bitcoin] laanwj merged pull request #16451: Remove CMerkleTx (master...2019-07-remove-CMerkleTx) https://github.com/bitcoin/bitcoin/pull/16451
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/39763b75556b...8241b5150431
< bitcoin-git> bitcoin/master b3a9d17 John Newbery: [wallet] Move CMerkleTx functions into CWalletTx
< bitcoin-git> bitcoin/master 783a76f John Newbery: [wallet] Flatten CWalletTx class hierarchy
< bitcoin-git> bitcoin/master 05b56d1 John Newbery: [wallet] Remove CMerkleTx serialization logic
< bitcoin-git> [bitcoin] promag opened pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504

2019-07-30

< bitcoin-git> [bitcoin] ariard opened pull request #16503: Remove p2pEnabled from Chain interface (master...2019-07-remove-p2p-chain) https://github.com/bitcoin/bitcoin/pull/16503
< fanquake> In newer versions of Xcode some of the headers our depends packages rely on aren’t where they used to be, and there a a script you can run that’ll put them back. See this comment: https://github.com/bitcoin/bitcoin/pull/16392#issuecomment-515268092 and the one I’m referencing.
< bitcoin-git> [bitcoin] promag closed pull request #16494: wallet: Drop support to serialize OldKey (master...2019-07-drop-oldkey-serialize) https://github.com/bitcoin/bitcoin/pull/16494
< bitcoin-git> [bitcoin] promag opened pull request #16502: wallet: Drop unused OldKey (master...2019-07-drop-oldkey) https://github.com/bitcoin/bitcoin/pull/16502
< bitcoin-git> [bitcoin] ronaldstoner closed pull request #16501: Update configure.ac to remove extra no in $use_tests (master...master) https://github.com/bitcoin/bitcoin/pull/16501
< bitcoin-git> [bitcoin] ronaldstoner opened pull request #16501: Update configure.ac to remove extra no in $use_tests (master...master) https://github.com/bitcoin/bitcoin/pull/16501
< bitcoin-git> [bitcoin] instagibbs opened pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
< emilengler> I don't get where the bitcoin-qt rpc console detecs when Ctrl-L is being pressed? With the help of the grep command I've only found the way how Ctrl-Q is being handled. Can someone tell me where I find it?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16264: policy: Add experimental -mempoolreplacement=full (off by default) (master...1906-policyFullRbf) https://github.com/bitcoin/bitcoin/pull/16264
< jonasschnelli> #proposedmeetingtopic bitcoin-dev mailing list moderation
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #16433: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN (master...1907-txmempoolNoUnknownDefault) https://github.com/bitcoin/bitcoin/pull/16433
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74f1a27f2f45...39763b75556b
< bitcoin-git> bitcoin/master 0000ff0 MarcoFalke: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN
< bitcoin-git> bitcoin/master 39763b7 Jonas Schnelli: Merge #16433: txmempool: Remove unused default value MemPoolRemovalReason:...
< jimpo> BlueMatt: Thinking about https://github.com/bitcoin/bitcoin/pull/16442#discussion_r308429740 more (the BlockRequestAllowed comment), I think just checking the stop block might be OK
< gribble> https://github.com/bitcoin/bitcoin/issues/16433 | txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN by MarcoFalke · Pull Request #16433 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #16323: Call ProcessNewBlock() asynchronously (master...2019-07-background-pnb) https://github.com/bitcoin/bitcoin/pull/16323
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497
< BlueMatt> jonasschnelli: to answer your question, in a general case, the way you write a network layer (eg the way bitcoin core does it today) is step 1) read message header, step 2) check stuff about the header, step 3) allocate buffer for the size it told you, step 4) read message. this keeps things nice and simple, you dont have much allocation complexity and you avoid most buffer overflow issues if you misallocate in your network stack.
< bitcoin-git> [bitcoin] promag opened pull request #16494: wallet: Drop support to serialize OldKey (master...2019-07-drop-oldkey-serialize) https://github.com/bitcoin/bitcoin/pull/16494
< elichai2> oh. but they will need to implement the variable size type/functions anyway for the rest of the stuff in bitcoin. so why not use the same type we use everywhere?
< elichai2> phantomcircuit: bitcoin core already uses variables sizes for everything.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16493: test: Bump rpc_timeout in feature_dbcrash (master...1907-testRpcTimeoutBump) https://github.com/bitcoin/bitcoin/pull/16493