2019-07-11

< bitcoin-git> bitcoin/master 99aea04 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin tests
< bitcoin-git> bitcoin/master bb326ad Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD benchmark
< sipa> i'm suggesting this because i'd like a bitcoin-psbt tool that you just give psbts and utxos and descriptors and keys and figures out what it can do
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< bitcoin-git> [bitcoin] instagibbs opened pull request #16373: Add bumpfee option to return PSBT instead of commiting to wallet (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
< provoostenator> Some thoughs on how to apply achow101's The Box to hardware wallets: https://github.com/bitcoin/bitcoin/pull/14912#issuecomment-510520757
< jnewbery> provoostenator: from the base bitcoin directory: ./test/functional/test_runner.py $(for f in test/functional/wallet*; do echo $f | xargs -n 1 basename; done)
< bitcoin-git> [bitcoin] fanquake opened pull request #16371: trivial: build: ignore osx_volname & add it to clean-local (master...ignore_osx_volname) https://github.com/bitcoin/bitcoin/pull/16371
< bitcoin-git> [bitcoin] fanquake opened pull request #16370: depends: cleanup package configure flags (master...not_so_great_configure_cleanup) https://github.com/bitcoin/bitcoin/pull/16370

2019-07-10

< bitcoin-git> [bitcoin] ryanofsky opened pull request #16367: Multiprocess build support (master...pr/ipc-build) https://github.com/bitcoin/bitcoin/pull/16367
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16244: Move wallet creation out of the createwallet rpc into its own function (master...mv-createwallet) https://github.com/bitcoin/bitcoin/pull/16244
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff0aad8a40a0...4fcccdac785e
< bitcoin-git> bitcoin/master 1aecdf2 Andrew Chow: Move wallet creation out of the createwallet rpc into its own function
< bitcoin-git> bitcoin/master 4fcccda MarcoFalke: Merge #16244: Move wallet creation out of the createwallet rpc into its ow...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16361: Remove redundant pre-TopUpKeypool check (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c1e45c4c416...ff0aad8a40a0
< bitcoin-git> bitcoin/master 96b6dd4 Gregory Sanders: Remove redundant pre-TopUpKeypool checks
< bitcoin-git> bitcoin/master ff0aad8 MarcoFalke: Merge #16361: Remove redundant pre-TopUpKeypool check
< instagibbs> please no politics here. timeline for 0.19 here: https://github.com/bitcoin/bitcoin/issues/15940
< sipa> for bitcoin-psbt i'm more thinking something which you give a bunch of information and uses it where useful
< sipa> bitcoin-tx is really "transformation based" thing which you give an input and then specify some transformations to apply
< elichai2> so you think it should be separate from bitcoin-tx
< elichai2> I want to add it to the PSBT standard so that other wallets can start working on support this even before it's in bitcoin core's wallet (assuming of course taproot will get activated)
< sipa> and i think we need a bitcoin-psbt tool that can sign/update a psbt with keys and descriptors
< instagibbs> might be #bitcoin chat, achow101 would know
< elichai2> If I want to add manual psbt constructions support, does it makes sense to have it in `bitcoin-tx`? regular bitcoin core rpc or even a new `bitcoin-psbt`?
< gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16322 | wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16322 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15638 | Move-only: Pull wallet code out of libbitcoin_server by ryanofsky · Pull Request #15638 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15778 | [wallet] Move maxtxfee from node to wallet by jnewbery · Pull Request #15778 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16366: init: Use InitError for all errors in bitcoind/qt (master...1907-initErrorGui) https://github.com/bitcoin/bitcoin/pull/16366
< bitcoin-git> [bitcoin] laanwj merged pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d1fc827300e2...6c1e45c4c416
< bitcoin-git> bitcoin/master 5c1b971 João Barbosa: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
< bitcoin-git> bitcoin/master 1775501 MarcoFalke: wallet: Remove unreachable code in CreateTransaction
< bitcoin-git> bitcoin/master 0d101a3 MarcoFalke: test: Add test for maxtxfee option
< bitcoin-git> [bitcoin] laanwj merged pull request #16270: depends: expat 2.2.7 (master...expat-2-2-7) https://github.com/bitcoin/bitcoin/pull/16270
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5859b7dc6ff5...d1fc827300e2
< bitcoin-git> bitcoin/master 0512f05 fanquake: depends: expat 2.2.7
< bitcoin-git> bitcoin/master d1fc827 Wladimir J. van der Laan: Merge #16270: depends: expat 2.2.7
< bitcoin-git> [bitcoin] laanwj merged pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8d1286014c61...5859b7dc6ff5
< bitcoin-git> bitcoin/master 48bcb2a qmma: Disable other targets when enable-fuzz is set
< bitcoin-git> bitcoin/master 84edfc7 qmma: Update doc and CI config
< bitcoin-git> bitcoin/master 5859b7d Wladimir J. van der Laan: Merge #16338: test: Disable other targets when enable-fuzz is set
< bitcoin-git> [bitcoin] laanwj merged pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/1fb747a8007c...410774ab89fd
< bitcoin-git> bitcoin/0.18 e2f7677 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
< bitcoin-git> bitcoin/0.18 df695db João Barbosa: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> bitcoin/0.18 410774a Wladimir J. van der Laan: Merge #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result"...
< bitcoin-git> [bitcoin] laanwj merged pull request #16237: Have the wallet give out destinations instead of keys (master...cwallet-getnewaddr) https://github.com/bitcoin/bitcoin/pull/16237
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/357488f660a5...8d1286014c61
< bitcoin-git> bitcoin/master 172213b Andrew Chow: Add GetNewDestination to CWallet to fetch new destinations
< bitcoin-git> bitcoin/master 33d13ed Andrew Chow: Replace CReserveKey with ReserveDestinatoin
< bitcoin-git> bitcoin/master 8e7f930 Andrew Chow: Add GetNewChangeDestination for getting new change Destinations
< gribble> https://github.com/bitcoin/bitcoin/issues/16362 | gui: Bilingual translation by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub

2019-07-09

< bitcoin-git> [bitcoin] darosior closed pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16240: JSONRPCRequest-aware RPCHelpMan (master...2019-06-json-aware-helper) https://github.com/bitcoin/bitcoin/pull/16240
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8046a3e0befe...357488f660a5
< bitcoin-git> bitcoin/master 0ab8ba1 Karl-Johan Alm: rpc: fix RPC help requirements for getblocktemplate
< bitcoin-git> bitcoin/master 5c5e32b Karl-Johan Alm: rpc: migrate JSONRPCRequest functionality into request.cpp
< bitcoin-git> bitcoin/master c7a9fc2 Karl-Johan Alm: Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper
< bitcoin-git> [bitcoin] LarryRuane opened pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363
< bitcoin-git> [bitcoin] hebasto opened pull request #16362: gui: Bilingual translation (master...20190709-bilingual-part-one) https://github.com/bitcoin/bitcoin/pull/16362
< bitcoin-git> [bitcoin] instagibbs opened pull request #16361: Remove redundant pre-TopUpKeypool checks (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
< bitcoin-git> [bitcoin] darosior opened pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360
< bitcoin-git> [bitcoin] darosior closed pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358
< bitcoin-git> [bitcoin] promag opened pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359
< bitcoin-git> [bitcoin] darosior opened pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358
< hebasto> MarcoFalke: I'm going to rebase my PR and implement your suggestion. Could you look into https://github.com/bitcoin/bitcoin/pull/15864#discussion_r301258664 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag · Pull Request #16348 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Remove redundant WalletController::addWallet signal by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] conscott closed pull request #14691: tests: Speedup feature_pruning test and refactor big transaction logic (master...2018_11_opreturn_splices) https://github.com/bitcoin/bitcoin/pull/14691
< bitcoin-git> [bitcoin] laanwj merged pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c799976c86e2...8046a3e0befe
< bitcoin-git> bitcoin/master f27bd96 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
< bitcoin-git> bitcoin/master 64fee48 João Barbosa: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> bitcoin/master 8046a3e Wladimir J. van der Laan: Merge #16348: qt: Assert QMetaObject::invokeMethod result
< bitcoin-git> [bitcoin] laanwj closed pull request #16357: util: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357

2019-07-08

< bitcoin-git> [bitcoin] nkostoulas opened pull request #16357: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357
< bitcoin-git> [bitcoin] cajunlady78 opened pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
< bitcoin-git> [bitcoin] cajunlady78 closed pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
< bitcoin-git> [bitcoin] instagibbs closed pull request #13057: refactor pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057
< bitcoin-git> [bitcoin] laanwj merged pull request #16128: Delete error-prone CScript constructor only used with FindAndDelete (master...cscript_construct) https://github.com/bitcoin/bitcoin/pull/16128
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345f42a9e3ae...c799976c86e2
< bitcoin-git> bitcoin/master e1a5569 Gregory Sanders: Delete error-prone CScript constructor
< bitcoin-git> bitcoin/master c799976 Wladimir J. van der Laan: Merge #16128: Delete error-prone CScript constructor only used with FindAn...
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a6ee9797e65...345f42a9e3ae
< bitcoin-git> bitcoin/master c4606b8 practicalswift: Add Travis check for single parameter constructors not marked "explicit"
< bitcoin-git> bitcoin/master 345f42a Wladimir J. van der Laan: Merge #14505: test: Add linter to make sure single parameter constructors ...
< bitcoin-git> [bitcoin] laanwj merged pull request #14505: test: Add linter to make sure single parameter constructors are marked explicit (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
< bitcoin-git> [bitcoin] laanwj merged pull request #16267: bench: Benchmark blockToJSON (master...bench-blocktojson) https://github.com/bitcoin/bitcoin/pull/16267
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4882040182ea...0a6ee9797e65
< bitcoin-git> bitcoin/master 91509ff Kirill Fomichev: bench: Benchmark blockToJSON
< bitcoin-git> bitcoin/master 0a6ee97 Wladimir J. van der Laan: Merge #16267: bench: Benchmark blockToJSON
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2679bb8919b5...4882040182ea
< bitcoin-git> bitcoin/master fa5e9f1 MarcoFalke: build: Stop translating PACKAGE_NAME
< bitcoin-git> bitcoin/master fabe87d MarcoFalke: scripted-diff: Avoid passing PACKAGE_NAME for translation
< bitcoin-git> bitcoin/master fab8520 MarcoFalke: qt: Run «make translate» in ./src/
< gribble> https://github.com/bitcoin/bitcoin/issues/15891 | test: Require standard txs in regtest by default by MarcoFalke · Pull Request #15891 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jamesob opened pull request #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp (master...2019-07-au-coinscatcher) https://github.com/bitcoin/bitcoin/pull/16355
< bitcoin-git> [bitcoin] laanwj merged pull request #16106: gui: Sort wallets in open wallet menu (master...2019-05-followup-15957) https://github.com/bitcoin/bitcoin/pull/16106
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b5fa2319d863...2679bb8919b5
< bitcoin-git> bitcoin/master 224eb95 João Barbosa: gui: Sort wallets in open wallet menu
< bitcoin-git> bitcoin/master fa90fe6 João Barbosa: refactor: Rename getWallets to getOpenWallets in WalletController
< bitcoin-git> bitcoin/master 2679bb8 Wladimir J. van der Laan: Merge #16106: gui: Sort wallets in open wallet menu
< bitcoin-git> [bitcoin] fanquake closed pull request #16351: 0.18 backport: backport github-merge.py improvements (0.18...backport_github_merge_improvements) https://github.com/bitcoin/bitcoin/pull/16351
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/983c84844c59...b5fa2319d863
< bitcoin-git> bitcoin/master 1eb13f0 Jon Atack: test: Add log messages to test/functional/tool_wallet.py
< bitcoin-git> bitcoin/master 3bf2b3a Jon Atack: test: Split tool_wallet.py test into subtests
< bitcoin-git> bitcoin/master 7195fa7 Jon Atack: test: Tool wallet test coverage for unexpected writes to wallet
< bitcoin-git> [bitcoin] laanwj merged pull request #15687: test: tool wallet test coverage for unexpected writes to wallet (master...tool-wallet-tests-for-unexpected-writes-to-wallet-file) https://github.com/bitcoin/bitcoin/pull/15687
< bitcoin-git> [bitcoin] laanwj merged pull request #16352: build: prune dbus from depends (master...depends_prune_dbus) https://github.com/bitcoin/bitcoin/pull/16352
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5a01cf25986...983c84844c59
< bitcoin-git> bitcoin/master e8fabd9 fanquake: build: prune dbus from depends
< bitcoin-git> bitcoin/master 983c848 Wladimir J. van der Laan: Merge #16352: build: prune dbus from depends
< bitcoin-git> [bitcoin] laanwj merged pull request #16332: rpc: Add logpath description for getrpcinfo (master...getrpcinfo_logpath_help) https://github.com/bitcoin/bitcoin/pull/16332
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e1a8d76aff8d...f5a01cf25986
< bitcoin-git> bitcoin/master a30bd09 Gregory Sanders: Add logpath description for getrpcinfo
< bitcoin-git> bitcoin/master f5a01cf Wladimir J. van der Laan: Merge #16332: rpc: Add logpath description for getrpcinfo
< gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Fix "opening a wallet" issue #15453 by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16285 | rpc: Improve scantxoutset response and help message by promag · Pull Request #16285 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2b465195e09a...e1a8d76aff8d
< bitcoin-git> bitcoin/master 84ad4d2 Carl Dong: doc: Include static members in Doxygen
< bitcoin-git> bitcoin/master e1a8d76 Wladimir J. van der Laan: Merge #16347: doc: Include static members in Doxygen
< bitcoin-git> [bitcoin] fanquake merged pull request #16339: doc: add reduce-memory.md (master...doc-reduce-memory-usage) https://github.com/bitcoin/bitcoin/pull/16339
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05623c021681...2b465195e09a
< bitcoin-git> bitcoin/master 64b27c4 fanquake: docs: add reduce-memory.md
< bitcoin-git> bitcoin/master 2b46519 fanquake: Merge #16339: doc: add reduce-memory.md
< bitcoin-git> [bitcoin] fanquake merged pull request #16350: qt: Remove unused guard (master...20190707-remove-unused-guard) https://github.com/bitcoin/bitcoin/pull/16350
< bitcoin-git> bitcoin/master 05623c0 fanquake: Merge #16350: qt: Remove unused guard
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f373beebbcc0...05623c021681
< bitcoin-git> bitcoin/master d003110 Hennadii Stepanov: Remove unused guard

2019-07-07

< bitcoin-git> [bitcoin] fanquake opened pull request #16352: build: prune dbus from depends (master...depends_prune_dbus) https://github.com/bitcoin/bitcoin/pull/16352
< bitcoin-git> [bitcoin] fanquake opened pull request #16351: 0.18 backport: backport github-merge.py improvements (0.18...backport_github_merge_improvements) https://github.com/bitcoin/bitcoin/pull/16351
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/629c7b029cf9...1fb747a8007c
< bitcoin-git> bitcoin/0.18 1dc357d Anthony Towns: signrawtransactionwithkey: report error when missing redeemScript/witnessS...
< bitcoin-git> bitcoin/0.18 1fb747a fanquake: Merge #16342: 0.18 backport: report error when missing redeemScript/witnes...
< bitcoin-git> [bitcoin] fanquake merged pull request #16342: 0.18 backport: report error when missing redeemScript/witnessScript (0.18...201906-signrawerror-regression-018) https://github.com/bitcoin/bitcoin/pull/16342
< bitcoin-git> [bitcoin] hebasto opened pull request #16350: qt: Remove unused guard (master...20190707-remove-unused-guard) https://github.com/bitcoin/bitcoin/pull/16350
< bitcoin-git> [bitcoin] fanquake merged pull request #16344: build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) (master...2019/07/system-ifdef) https://github.com/bitcoin/bitcoin/pull/16344
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/584168c7f9d9...f373beebbcc0
< bitcoin-git> bitcoin/master 976b034 Sjors Provoost: [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
< bitcoin-git> bitcoin/master f373bee fanquake: Merge #16344: build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
< bitcoin-git> [bitcoin] fanquake merged pull request #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCCvertParam tables (master...2019-07-utxoupdatepsbt-args) https://github.com/bitcoin/bitcoin/pull/16326
< bitcoin-git> bitcoin/master 3b11420 John Newbery: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertP...
< bitcoin-git> bitcoin/master 91cc18f John Newbery: [docs] Add release notes for PR 15427
< bitcoin-git> bitcoin/master 584168c fanquake: Merge #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand an...
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8c69fae94410...584168c7f9d9

2019-07-06

< bitcoin-git> [bitcoin] hebasto opened pull request #16349: Fix "opening a wallet" issue #15453 (master...20190706-fix15453) https://github.com/bitcoin/bitcoin/pull/16349
< bitcoin-git> [bitcoin] promag opened pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348
< bitcoin-git> [bitcoin] dongcarl opened pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | WIP: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< hebasto> promag: hi, could you look into https://travis-ci.org/bitcoin/bitcoin/jobs/554836240 ?
< achow101> anyone familiar with MSVC know what's up with this error: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/25786259?

2019-07-05

< bitcoin-git> [bitcoin] sipsorcery closed pull request #15995: systemd service script: set usable permissions on /etc/bitcoin config dir (master...systemdconfig) https://github.com/bitcoin/bitcoin/pull/15995
< sipa> there's a website which is still actively being changed: http://bitcoin.sipa.be/miniscript
< sipa> this is about the bitcoin scirpt language as it exists today, without any softforks or other changes to consensus needed (but obviously prepared for those)
< sipa> so me and some colleagues of mine have been working on a way to make more complex bitcoin scripts more accessible, in a project called miniscript
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] emilengler opened pull request #16345: RPC: Add getblockbyheight (master...getblockbyheight) https://github.com/bitcoin/bitcoin/pull/16345
< provoostenator> emilengler: it does that here: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/client.cpp#L31
< sipa> bitcoin-cli knows that the first argument to generatetoaddress is to be interpreted as json instead of as a string
< sipa> emilengler: bitcoin-cli knows which arguments to treat as strings and which as json
< bitcoin-git> [bitcoin] Sjors opened pull request #16344: [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) (master...2019/07/system-ifdef) https://github.com/bitcoin/bitcoin/pull/16344
< emilengler> bitcoin-cli says "JSON value is not an integer as expected"
< emilengler> I currently have problems with bitcoin-cli to read an integer value on a new command I've implemented
< bitcoin-git> [bitcoin] laanwj merged pull request #15457: Check std::system for -[alert|block|wallet]notify (master...2019/02/std__system) https://github.com/bitcoin/bitcoin/pull/15457
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4f378ac30cf6...8c69fae94410
< bitcoin-git> bitcoin/master c1c91bb Sjors Provoost: [build] detect std::system or ::wsystem
< bitcoin-git> bitcoin/master cc3ad56 Sjors Provoost: [build] MSVC: set HAVE_SYSTEM for desktop apps
< bitcoin-git> bitcoin/master f874e14 Sjors Provoost: [build]: check std::system for -[alert|block|wallet]notify
< gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors closed pull request #15424: [wallet] wallet-tool: command to remove key metadata (master...2019/02/wallet_tool_remove_metadata) https://github.com/bitcoin/bitcoin/pull/15424
< bitcoin-git> [bitcoin] ajtowns opened pull request #16342: Backport #16250 for 0.18 (0.18...201906-signrawerror-regression-018) https://github.com/bitcoin/bitcoin/pull/16342
< fanquake> I've had a look over the build system changes in that PR, https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-508623934, but don't have a machine that supports AVX512 to test any performance improvements on.
< bitcoin-git> [bitcoin] achow101 opened pull request #16341: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) (master...box-the-wallet) https://github.com/bitcoin/bitcoin/pull/16341
< bitcoin-git> [bitcoin] fanquake merged pull request #16308: [MSVC] Copy build output to src/ automatically after build (master...build/copy-in-msbuild) https://github.com/bitcoin/bitcoin/pull/16308
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1088b90cbae3...4f378ac30cf6
< bitcoin-git> bitcoin/master 08c721d nicolas.dorier: [MSVC] Copy build output to src/ automatically after build
< bitcoin-git> bitcoin/master 4f378ac fanquake: Merge #16308: [MSVC] Copy build output to src/ automatically after build
< bitcoin-git> bitcoin/master 1088b90 fanquake: Merge #16327: scripts and tools: Update ShellCheck linter
< bitcoin-git> [bitcoin] fanquake merged pull request #16327: scripts and tools: Update ShellCheck linter (master...20190702-shellcheck) https://github.com/bitcoin/bitcoin/pull/16327
< bitcoin-git> [bitcoin] fanquake opened pull request #16339: doc: add reduce-memory.md (master...doc-reduce-memory-usage) https://github.com/bitcoin/bitcoin/pull/16339
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dfdcb3dfe535...1088b90cbae3
< bitcoin-git> bitcoin/master 1ac454a Hennadii Stepanov: Enable ShellCheck rules

2019-07-04

< bitcoin-git> [bitcoin] qmma70 opened pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
< gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
< sipa> sorry i haven't found much time for review; i've been spending a lot of time on improving and implementing miniscript, which i hope will at some point be integratable in bitcoin core
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 5 blockers, still 7 chasing concept ACK
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
< bitcoin-git> [bitcoin] emilengler closed pull request #16317: RPC: Add feature to getblock by using the index (master...getblock-improvement) https://github.com/bitcoin/bitcoin/pull/16317
< bitcoin-git> [bitcoin] fanquake closed pull request #16336: [lib] Refactor bloom filter class data member names (master...bloom_refactor) https://github.com/bitcoin/bitcoin/pull/16336
< bitcoin-git> [bitcoin] fanquake closed pull request #16077: docs: Follow ISO/IEC 14882 terms and definitions (master...20190523-iso-parameter) https://github.com/bitcoin/bitcoin/pull/16077
< bitcoin-git> [bitcoin] fanquake merged pull request #16330: docs: Use placeholder instead of key expiration date (master...20190702-key-expiration) https://github.com/bitcoin/bitcoin/pull/16330
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1381ddbcfcb6...dfdcb3dfe535
< bitcoin-git> bitcoin/master 88fd556 Hennadii Stepanov: Use placeholder instead of key expiration date
< bitcoin-git> bitcoin/master dfdcb3d fanquake: Merge #16330: docs: Use placeholder instead of key expiration date
< bitcoin-git> [bitcoin] fanquake closed pull request #16069: test: move-only: Split large tests into smaller compile units (master...1905-testCompFast) https://github.com/bitcoin/bitcoin/pull/16069
< bitcoin-git> [bitcoin] fanquake merged pull request #16035: 0.18.1: Backports (0.18...1906-181b) https://github.com/bitcoin/bitcoin/pull/16035
< bitcoin-git> [bitcoin] fanquake pushed 37 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/9c29bc71dc40...629c7b029cf9
< bitcoin-git> bitcoin/0.18 5935f01 MarcoFalke: build with -fstack-reuse=none
< bitcoin-git> bitcoin/0.18 9c1a607 MarcoFalke: net: Rename ::fRelayTxes to ::g_relay_txes
< bitcoin-git> bitcoin/0.18 8f215c7 MarcoFalke: test: Format predicate source as multiline on error
< bitcoin-git> [bitcoin] qmma70 opened pull request #16336: [lib] Refactor bloom filter class data member names (master...bloom_refactor) https://github.com/bitcoin/bitcoin/pull/16336

2019-07-03

< bitcoin-git> [bitcoin] dongcarl opened pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16329: test: Add tests for getblockchaininfo.softforks (master...1907-qaSoftforksHeight) https://github.com/bitcoin/bitcoin/pull/16329
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91c345eb9282...1381ddbcfcb6
< bitcoin-git> bitcoin/master faf6caf MarcoFalke: test: Add tests for getblockchaininfo.softforks
< bitcoin-git> bitcoin/master 1381ddb MarcoFalke: Merge #16329: test: Add tests for getblockchaininfo.softforks
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16333: test: Set BIP34Height = 2 for regtest (master...1906-bip34H2) https://github.com/bitcoin/bitcoin/pull/16333
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16333: test: Set BIP34Height = 2 for regtest (master...1906-bip34H2) https://github.com/bitcoin/bitcoin/pull/16333
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16299: bench: Move generated data to a dedicated translation unit (master...2019-06-benchmark-data) https://github.com/bitcoin/bitcoin/pull/16299
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/11de669d8b7a...91c345eb9282
< bitcoin-git> bitcoin/master 3d60a03 João Barbosa: bench: Move generated data to a dedicated translation unit
< bitcoin-git> bitcoin/master 91c345e MarcoFalke: Merge #16299: bench: Move generated data to a dedicated translation unit
< aj> MarcoFalke: i've done a backport of #16250 for 0.18 on top of #16035 at https://github.com/ajtowns/bitcoin/tree/201906-signrawerror-regression-018 fwiw
< gribble> https://github.com/bitcoin/bitcoin/issues/16250 | signrawtransactionwithkey: report error when missing redeemScript/witnessScript by ajtowns · Pull Request #16250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16270 | depends: expat 2.2.7 by fanquake · Pull Request #16270 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16333: test: Set BIP34Height = 2 for regtest (master...1906-bip34H2) https://github.com/bitcoin/bitcoin/pull/16333
< bitcoin-git> [bitcoin] instagibbs opened pull request #16332: Add logpath description for getrpcinfo (master...getrpcinfo_logpath_help) https://github.com/bitcoin/bitcoin/pull/16332
< bitcoin-git> [bitcoin] laanwj merged pull request #16325: rpc: Clarify that block count means height excl genesis (master...1907-rpcBlockCount) https://github.com/bitcoin/bitcoin/pull/16325
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9339008a9dce...11de669d8b7a
< bitcoin-git> bitcoin/master fab0c82 MarcoFalke: rpc: Clarify that block count means height excl genesis
< bitcoin-git> bitcoin/master 11de669 Wladimir J. van der Laan: Merge #16325: rpc: Clarify that block count means height excl genesis
< bitcoin-git> [bitcoin] laanwj merged pull request #15483: rpc: Adding a 'logpath' entry to getrpcinfo (master...getrpcinfo_logpath) https://github.com/bitcoin/bitcoin/pull/15483
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/085cac6b9043...9339008a9dce
< bitcoin-git> bitcoin/master 8a6810d darosior: Add a 'logpath' field to getrpcinfo
< bitcoin-git> bitcoin/master 9339008 Wladimir J. van der Laan: Merge #15483: rpc: Adding a 'logpath' entry to getrpcinfo
< bitcoin-git> [bitcoin] laanwj merged pull request #14734: fix an undefined behavior in uint::SetHex (master...SetHex-bad-ptr) https://github.com/bitcoin/bitcoin/pull/14734
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38fbb575e252...085cac6b9043
< bitcoin-git> bitcoin/master 0f459d8 Kaz Wesley: fix an undefined behavior in uint::SetHex
< bitcoin-git> bitcoin/master 085cac6 Wladimir J. van der Laan: Merge #14734: fix an undefined behavior in uint::SetHex
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #16319: [MSVC] Simplify AppVeyor build by using user customized project file (master...msvc/appveyor-refactor) https://github.com/bitcoin/bitcoin/pull/16319
< bitcoin-git> [bitcoin] laanwj merged pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f985d6c8159...38fbb575e252
< bitcoin-git> bitcoin/master faa1e0f MarcoFalke: qt: test: Create at most one testing setup
< bitcoin-git> bitcoin/master 38fbb57 Wladimir J. van der Laan: Merge #16294: qt: test: Create at most one testing setup
< bitcoin-git> [bitcoin] practicalswift opened pull request #16331: build: Add configure option --enable-lowmem to allow for building in low-memory environments (master...low-mem) https://github.com/bitcoin/bitcoin/pull/16331
< bitcoin-git> [bitcoin] laanwj merged pull request #16158: Fix logic of memory_cleanse() on MSVC and clean up docs (master...cleanup-cleanse) https://github.com/bitcoin/bitcoin/pull/16158
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7d7b832d6707...7f985d6c8159
< bitcoin-git> bitcoin/master cac30a4 Tim Ruffing: Clean up logic in memory_cleanse() for MSVC
< bitcoin-git> bitcoin/master f53a70c Tim Ruffing: Improve documentation of memory_cleanse()
< bitcoin-git> bitcoin/master 7f985d6 Wladimir J. van der Laan: Merge #16158: Fix logic of memory_cleanse() on MSVC and clean up docs
< bitcoin-git> [bitcoin] laanwj merged pull request #16262: rpc: Allow shutdown while in generateblocks (master...2019-06-21-generateblocks) https://github.com/bitcoin/bitcoin/pull/16262
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e06067387e75...7d7b832d6707
< bitcoin-git> bitcoin/master 3b9bf0e Patrick Strateman: rpc: Allow shutdown while in generateblocks
< bitcoin-git> bitcoin/master 7d7b832 Wladimir J. van der Laan: Merge #16262: rpc: Allow shutdown while in generateblocks
< bitcoin-git> [bitcoin] laanwj closed pull request #14633: Fix height serialization inside script of coinbase input (master...fix_height_serialization_in_coinbase) https://github.com/bitcoin/bitcoin/pull/14633
< bitcoin-git> [bitcoin] fanquake closed pull request #14137: gui: Add Windows taskbar progress (master...qt-windows-progress-bar) https://github.com/bitcoin/bitcoin/pull/14137

2019-07-02

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16250: signrawtransactionwithkey: report error when missing redeemScript/witnessScript (master...201906-signrawerror-regression) https://github.com/bitcoin/bitcoin/pull/16250
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4db2f8cf0f63...e06067387e75
< bitcoin-git> bitcoin/master 0117459 Anthony Towns: signrawtransactionwithkey: report error when missing redeemScript/witnessS...
< bitcoin-git> bitcoin/master e060673 MarcoFalke: Merge #16250: signrawtransactionwithkey: report error when missing redeemS...
< bitcoin-git> [bitcoin] hebasto opened pull request #16330: docs: Update release signing key expiration date (master...20190702-key-expiration) https://github.com/bitcoin/bitcoin/pull/16330
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16329: test: Add tests for getblockchaininfo.softforks (master...1907-qaSoftforksHeight) https://github.com/bitcoin/bitcoin/pull/16329
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16328: rpc: Tidy up reporting of buried and ongoing softforks (master...1907-rpcSoftforks) https://github.com/bitcoin/bitcoin/pull/16328
< bitcoin-git> [bitcoin] hebasto opened pull request #16327: scripts and tools: Update ShellCheck linter (master...20190702-shellcheck) https://github.com/bitcoin/bitcoin/pull/16327
< bitcoin-git> [bitcoin] jnewbery opened pull request #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCCvertParam tables (master...2019-07-utxoupdatepsbt-args) https://github.com/bitcoin/bitcoin/pull/16326
< gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #16153: Qt: Add antialiasing to traffic graph widget (master...antialiasing) https://github.com/bitcoin/bitcoin/pull/16153
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c84349a14832...4db2f8cf0f63
< bitcoin-git> bitcoin/master db26e8e Josu Goñi: Add antialiasing to traffic graph widget
< bitcoin-git> bitcoin/master 4db2f8c Wladimir J. van der Laan: Merge #16153: Qt: Add antialiasing to traffic graph widget
< bitcoin-git> [bitcoin] instagibbs closed pull request #16292: wallet_resendwallettransaction.py: fix coinbase height (master...resend_test_height) https://github.com/bitcoin/bitcoin/pull/16292
< gribble> https://github.com/bitcoin/bitcoin/issues/16325 | rpc: Clarify that block count means height excl genesis by MarcoFalke · Pull Request #16325 · bitcoin/bitcoin · GitHub
< instagibbs> promag, you just linked the same PR? :P https://github.com/bitcoin/bitcoin/pull/16292#issuecomment-507754182
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16325: rpc: Clarify that block count means height excl genesis (master...1907-rpcBlockCount) https://github.com/bitcoin/bitcoin/pull/16325
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16323: Call ProcessNewBlock() asynchronously (master...2019-07-background-pnb) https://github.com/bitcoin/bitcoin/pull/16323
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16314: scripts and tools: Update copyright_header.py script (master...20190629-copyright-headers) https://github.com/bitcoin/bitcoin/pull/16314
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2f717fb5cdfc...c84349a14832
< bitcoin-git> bitcoin/master 01fafe5 Hennadii Stepanov: Include Objective-C source files
< bitcoin-git> bitcoin/master 621463d Hennadii Stepanov: Drop no-longer-relevant copyright holder name
< bitcoin-git> bitcoin/master ca11606 Hennadii Stepanov: Fix: "Bitcoin Core" -> "The Bitcoin Core"