2020-05-06

< bitcoin-git> [bitcoin] fanquake merged pull request #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix (master...20200428-net-clarify-divide-by-zero-fix) https://github.com/bitcoin/bitcoin/pull/18806
< bitcoin-git> bitcoin/master 551dc7f fanquake: Merge #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify ...
< bitcoin-git> bitcoin/master 1ad8ea2 Sebastian Falbesoner: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d96fdc2a396f...551dc7f66466
< bitcoin-git> [bitcoin] hebasto opened pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896
< bitcoin-git> [bitcoin] fanquake merged pull request #18741: guix: Make source tarball using git-archive (master...2020-04-sync-guix) https://github.com/bitcoin/bitcoin/pull/18741
< bitcoin-git> bitcoin/master 1470160 Carl Dong: guix: Expose GIT_COMMON_DIR in container as readonly
< bitcoin-git> bitcoin/master f5a6ac4 Carl Dong: guix: Make source tarball using git-archive
< bitcoin-git> bitcoin/master 395c113 Carl Dong: gitian: Limit sourced script to just assignments
< bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/60091d20f9bb...d96fdc2a396f
< bitcoin-git> [bitcoin] gzhao408 opened pull request #18895: [wip] unbroadcast followups (master...unbroadcast-followup) https://github.com/bitcoin/bitcoin/pull/18895

2020-05-05

< bitcoin-git> [bitcoin] meshcollider merged pull request #9381: Remove CWalletTx merging logic from AddToWallet (master...pr/atw-nomerge) https://github.com/bitcoin/bitcoin/pull/9381
< bitcoin-git> bitcoin/master 65b9d8f Russell Yanofsky: Avoid copying CWalletTx in LoadToWallet
< bitcoin-git> bitcoin/master bd2fbc7 Russell Yanofsky: Get rid of unneeded CWalletTx::Init parameter
< bitcoin-git> bitcoin/master 2b9cba2 Russell Yanofsky: Remove CWalletTx merging logic from AddToWallet
< bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fbd522721cb8...60091d20f9bb
< bitcoin-git> [bitcoin] promag closed pull request #17457: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725) https://github.com/bitcoin/bitcoin/pull/17457
< bitcoin-git> [bitcoin] promag opened pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894
< gribble> https://github.com/bitcoin/bitcoin/issues/18870 | build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb by achow101 · Pull Request #18870 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] robot-visions opened pull request #18890: test: disconnect_nodes should warn if nodes were already disconnected (master...disconnect-nodes) https://github.com/bitcoin/bitcoin/pull/18890
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885
< bitcoin-git> bitcoin/master fbd5227 MarcoFalke: Merge #18885: contrib: Move optimize-pngs.py script to the maintainer repo...
< bitcoin-git> bitcoin/master fa13090 MarcoFalke: contrib: Remove optimize-pngs.py script, which lives in the maintainer rep...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52ce396b2a47...fbd522721cb8
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879
< bitcoin-git> bitcoin/master 52ce396 MarcoFalke: Merge #18879: valgrind: remove outdated suppressions
< bitcoin-git> bitcoin/master d7120f7 fanquake: valgrind : remove duplicate BCLog::Logger suppression
< bitcoin-git> bitcoin/master 708e3c7 fanquake: valgrind: remove rest_blockhash_by_height suppression
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ec79b5f86b22...52ce396b2a47
< bitcoin-git> [bitcoin] promag closed pull request #18246: wip: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246
< gribble> https://github.com/bitcoin/bitcoin/issues/18863 | refactor: Drop unused CScriptVisitor return type by promag · Pull Request #18863 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] vasild opened pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887
< bitcoin-git> [bitcoin] luke-jr closed pull request #18880: [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (0.20...pr18671-0.20) https://github.com/bitcoin/bitcoin/pull/18880
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885
< bitcoin-git> [bitcoin] hebasto opened pull request #18883: qt: Fix OpenWalletActivity::open() (master...200505-fix-win) https://github.com/bitcoin/bitcoin/pull/18883
< bitcoin-git> [bitcoin] fanquake opened pull request #18882: build: fix -Wformat-security check when compiling with GCC (master...fix_gcc_wformat_security) https://github.com/bitcoin/bitcoin/pull/18882
< gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
< jonasschnelli> If an "tool" (like bitcoin-wallet) would allow the migration from bdb-storage to new-storage, we still would require the bdb support
< jonasschnelli> If an storage upgrade is required for legacy wallets (which would be a no-go IMO), it could go over bitcoin-wallet (where we still need both storage backend in the code)
< bitcoin-git> [bitcoin] hebasto opened pull request #18881: Prevent UB in DeleteLock() function (master...200505-cofu) https://github.com/bitcoin/bitcoin/pull/18881
< gribble> https://github.com/bitcoin/bitcoin/issues/5686 | [Wallet] replace BDB with internal append only (logdb) backend by jonasschnelli · Pull Request #5686 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] luke-jr opened pull request #18880: [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (0.20...pr18671-0.20) https://github.com/bitcoin/bitcoin/pull/18880
< bitcoin-git> [bitcoin] meshcollider merged pull request #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction (master...uninitialized-members) https://github.com/bitcoin/bitcoin/pull/18782
< bitcoin-git> bitcoin/master ec79b5f Samuel Dobson: Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDesc...
< bitcoin-git> bitcoin/master 2a78098 practicalswift: wallet: Make sure no WalletDescriptor members are uninitialized after cons...
< bitcoin-git> bitcoin/master ff046ae practicalswift: wallet: Make sure no DescriptorScriptPubKeyMan members are uninitialized a...
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e727c2bdcab3...ec79b5f86b22
< bitcoin-git> [bitcoin] fanquake opened pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879
< bitcoin-git> [bitcoin] ryanofsky opened pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878
< bitcoin-git> [bitcoin] fanquake closed pull request #16442: Serve BIP 157 compact filters (master...bip157-net) https://github.com/bitcoin/bitcoin/pull/16442
< bitcoin-git> [bitcoin] jnewbery opened pull request #18877: Serve cfcheckpt requests (master...2020-04-serve-getcfcheckpt) https://github.com/bitcoin/bitcoin/pull/18877
< bitcoin-git> [bitcoin] jnewbery opened pull request #18876: Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876
< gribble> https://github.com/bitcoin/bitcoin/issues/9381 | Remove CWalletTx merging logic from AddToWallet by ryanofsky · Pull Request #9381 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18875: fuzz: Stop nodes in process_message* fuzzers (master...2005-fuzzStopNodes) https://github.com/bitcoin/bitcoin/pull/18875

2020-05-04

< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18873: test: Fix intermittent sync_blocks failures (master...2005-testSyncBlocks) https://github.com/bitcoin/bitcoin/pull/18873
< bitcoin-git> [bitcoin] fanquake merged pull request #18088: build: ensure we aren't using GNU extensions (master...no_gnu_extensions) https://github.com/bitcoin/bitcoin/pull/18088
< bitcoin-git> bitcoin/master 3a0fd77 Ben Woosley: Remove use of non-standard zero variadic macros
< bitcoin-git> bitcoin/master 49f6178 Ben Woosley: Drop unused LOG_TIME_MICROS helper
< bitcoin-git> bitcoin/master 5d49999 DesWurstes: prevector: Avoid unnamed struct, which is a GNU extension
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b549cb1bd2cc...e727c2bdcab3
< bitcoin-git> [bitcoin] achow101 closed pull request #18844: wallet: build: Don't write BDB logs and bump BDB to 5.3 (master...bdb-5.3) https://github.com/bitcoin/bitcoin/pull/18844
< bitcoin-git> [bitcoin] brakmic opened pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871
< bitcoin-git> [bitcoin] achow101 opened pull request #18870: build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb (master...allow-other-bdb) https://github.com/bitcoin/bitcoin/pull/18870
< jeremyrubin> luke-jr: you may want to chime in on https://github.com/bitcoin/bitcoin/issues/12248#issuecomment-622270497 if you're looking at RPC whitelist/permissions for core
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18730: wallet: Remove -upgradewallet from dummywallet (master...2004-walletNoUpgrade) https://github.com/bitcoin/bitcoin/pull/18730
< gribble> https://github.com/bitcoin/bitcoin/issues/18869 | Build of tests fails on FreeBSD · Issue #18869 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
< bitcoin-git> [bitcoin] laanwj merged pull request #18443: lockedpool: avoid sensitive data in core files (FreeBSD) (master...madvise) https://github.com/bitcoin/bitcoin/pull/18443
< bitcoin-git> bitcoin/master b549cb1 Wladimir J. van der Laan: Merge #18443: lockedpool: avoid sensitive data in core files (FreeBSD)
< bitcoin-git> bitcoin/master f852030 Vasil Dimov: lockedpool: avoid sensitive data in core files (FreeBSD)
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23c926d859c6...b549cb1bd2cc
< bitcoin-git> [bitcoin] laanwj merged pull request #18699: wallet: Avoid translating RPC errors (master...1908-walletErrorSegfault) https://github.com/bitcoin/bitcoin/pull/18699
< bitcoin-git> bitcoin/master fae7776 MarcoFalke: wallet: Avoid translating RPC errors when creating txs
< bitcoin-git> bitcoin/master fa59cc1 MarcoFalke: wallet: Report full error message in wallettool
< bitcoin-git> bitcoin/master fae51a5 MarcoFalke: wallet: Avoid translating RPC errors when loading wallets
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/42fd5038197d...23c926d859c6
< bitcoin-git> [bitcoin] laanwj merged pull request #18786: init: Remove boost from ThreadImport (master...2004-noBoostInitThreadImport) https://github.com/bitcoin/bitcoin/pull/18786
< bitcoin-git> bitcoin/master 42fd503 Wladimir J. van der Laan: Merge #18786: init: Remove boost from ThreadImport
< bitcoin-git> bitcoin/master faec3dc MarcoFalke: init: Remove boost from ThreadImport
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a729b0e42fa...42fd5038197d
< bitcoin-git> [bitcoin] laanwj closed pull request #18851: refactor: Replace thread_local use with a mutex-protected map (master...2020_05_replace_threadlocal) https://github.com/bitcoin/bitcoin/pull/18851
< gribble> https://github.com/bitcoin/bitcoin/issues/7601 | [WIP] HTLC implementation in the wallet by ebfull · Pull Request #7601 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18851 | refactor: Replace thread_local use with a mutex-protected map by laanwj · Pull Request #18851 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #18867: tests: Add fuzzing harness for CCoinsViewCache (master...fuzzers-coins_view) https://github.com/bitcoin/bitcoin/pull/18867
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18783: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h (master...fuzzers-message) https://github.com/bitcoin/bitcoin/pull/18783
< bitcoin-git> bitcoin/master 0a729b0 MarcoFalke: Merge #18783: tests: Add fuzzing harness for MessageSign, MessageVerify an...
< bitcoin-git> bitcoin/master 38e49de practicalswift: tests: Add fuzzing harness for MessageSign, MessageVerify and other functi...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74a1152f2581...0a729b0e42fa
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18866: test: Fix verack race to avoid intermittent test failures (master...2005-qaVerackRace) https://github.com/bitcoin/bitcoin/pull/18866
< bitcoin-git> [bitcoin] promag opened pull request #18865: gui: Refactor WalletFrame to extend QStackView (master...2020-05-walletframe) https://github.com/bitcoin/bitcoin/pull/18865
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
< bitcoin-git> bitcoin/master 74a1152 MarcoFalke: Merge #18859: Remove CCoinsViewCache::GetValueIn(...)
< bitcoin-git> bitcoin/master b56607a practicalswift: Remove CCoinsViewCache::GetValueIn(...)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/afa577c323dc...74a1152f2581
< bitcoin-git> [bitcoin] Sjors opened pull request #18864: Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 (master...2020/05/backwards_compat) https://github.com/bitcoin/bitcoin/pull/18864
< bitcoin-git> [bitcoin] promag opened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #15768: gui: Add close window shortcut (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
< bitcoin-git> bitcoin/master afa577c Jonas Schnelli: Merge #15768: gui: Add close window shortcut
< bitcoin-git> bitcoin/master f5a3a5b Miguel Herranz: gui: Add close window shortcut
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e6a16b968a9...afa577c323dc
< bitcoin-git> [bitcoin] fanquake opened pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862
< bitcoin-git> [bitcoin] sipa opened pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861

2020-05-03

< fanquake> thomasb06: read https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md if you haven't already
< fanquake> thomasb06: If you want to start contributing, look at the "Good first issue" list: https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
< bitcoin-git> [bitcoin] practicalswift closed pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
< gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub
< vasild> although I guess the instruction is available on all platforms where bitcoin core is being run, otherwise somebody would have reported the crash
< vasild> sipa: wrt https://github.com/bitcoin/bitcoin/pull/18843#issuecomment-623158435 -- what would the current inline assembly do on a system that doesn't have that instruction? I guess it will cause SIGILL (illegal instruction) at runtime?
< bitcoin-git> [bitcoin] practicalswift opened pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18855: tests: feature_backwards_compatibility.py test downgrade after upgrade (master...test-backcompat-updowngrade) https://github.com/bitcoin/bitcoin/pull/18855
< bitcoin-git> bitcoin/master 2e6a16b MarcoFalke: Merge #18855: tests: feature_backwards_compatibility.py test downgrade aft...
< bitcoin-git> bitcoin/master 489ebfd Andrew Chow: tests: feature_backwards_compatibility.py test downgrade after upgrade
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cce034b02800...2e6a16b968a9
< bitcoin-git> bitcoin/master cce034b MarcoFalke: Merge #18839: test: Fix intermittent issues
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18839: test: Fix intermittent issues (master...2004-qaSegwitNoIntermittentFail) https://github.com/bitcoin/bitcoin/pull/18839
< bitcoin-git> bitcoin/master fab7ee3 MarcoFalke: test: Fix p2p_leak intermittent issue
< bitcoin-git> bitcoin/master fa8614a MarcoFalke: test: Fix intermittent p2p_segwit issue
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddc0a600b38a...cce034b02800
< bitcoin-git> [bitcoin] vasild opened pull request #18857: build: avoid repetitions when enabling warnings in configure.ac (master...avoid_repetitions_in_configure.ac) https://github.com/bitcoin/bitcoin/pull/18857
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18617: test: add factor option to adjust test timeouts (master...test-timeouts-with-factor) https://github.com/bitcoin/bitcoin/pull/18617
< bitcoin-git> bitcoin/master 2742c34 Harris: test: add factor option to adjust test timeouts
< bitcoin-git> bitcoin/master ddc0a60 MarcoFalke: Merge #18617: test: add factor option to adjust test timeouts
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68ef9523d1bc...ddc0a600b38a
< bitcoin-git> [bitcoin] achow101 opened pull request #18855: tests: feature_backwards_compatibility.py test downgrade after upgrade (master...test-backcompat-updowngrade) https://github.com/bitcoin/bitcoin/pull/18855

2020-05-02

< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< achow101> try asking in #bitcoin-builds
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18854: doc: Fix typo in Coin doxygen comment (master...2005-docCoins) https://github.com/bitcoin/bitcoin/pull/18854
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
< wumpus> thomasb06: I'm not here for casual chat sorry, this channel is for bitcoin core development, for general chat w/ other people about bitcoin join #bitcoin
< bitcoin-git> [bitcoin] fanquake closed pull request #18187: Add macOS notarization (including stapling) (master...2020/02/macos_runtime_hardening) https://github.com/bitcoin/bitcoin/pull/18187
< bitcoin-git> [bitcoin] fanquake merged pull request #18413: script: prevent UB when computing abs value for num opcode serialize (master...fix-script-absolute) https://github.com/bitcoin/bitcoin/pull/18413
< bitcoin-git> bitcoin/master 68ef952 fanquake: Merge #18413: script: prevent UB when computing abs value for num opcode s...
< bitcoin-git> bitcoin/master 2748e87 pierrenn: script: prevent UB when computing abs value for num opcode serialize
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/844d2070a2c0...68ef9523d1bc
< bitcoin-git> [bitcoin] laanwj opened pull request #18851: refactor: Replace thread_local use with a mutex-protected map (master...2020_05_replace_threadlocal) https://github.com/bitcoin/bitcoin/pull/18851
< bitcoin-git> [bitcoin] jb55 closed pull request #18848: threadnames: don't allocate memory in ThreadRename (master...2020-05-static-threadrename) https://github.com/bitcoin/bitcoin/pull/18848
< bitcoin-git> [bitcoin] jb55 reopened pull request #18848: threadnames: don't allocate memory in ThreadRename (master...2020-05-static-threadrename) https://github.com/bitcoin/bitcoin/pull/18848
< bitcoin-git> [bitcoin] jb55 closed pull request #18848: threadnames: don't allocate memory in ThreadRename (master...2020-05-static-threadrename) https://github.com/bitcoin/bitcoin/pull/18848
< bitcoin-git> [bitcoin] bvbfan opened pull request #18850: Fix ZapSelectTx to sync wallet spends (master...zapfix) https://github.com/bitcoin/bitcoin/pull/18850
< bitcoin-git> [bitcoin] jb55 opened pull request #18849: The Zero Allocations project (master...zeroalloc) https://github.com/bitcoin/bitcoin/pull/18849
< bitcoin-git> [bitcoin] jb55 opened pull request #18848: threadnames: don't allocate memory in ThreadRename (master...2020-05-static-threadrename) https://github.com/bitcoin/bitcoin/pull/18848
< bitcoin-git> [bitcoin] jb55 opened pull request #18847: compressor: use prevector in CompressScript serialization (master...2020-05-compresscript-prevector) https://github.com/bitcoin/bitcoin/pull/18847

2020-05-01

< bitcoin-git> [bitcoin] achow101 opened pull request #18844: wallet: build: Don't write BDB logs and bump BDB to 5.3 (master...bdb-5.3) https://github.com/bitcoin/bitcoin/pull/18844
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git> bitcoin/master 844d207 MarcoFalke: Merge #18828: test: Strip down previous releases boilerplate
< bitcoin-git> bitcoin/master fa359d1 MarcoFalke: test: Strip down previous releases boilerplate
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/608359b071da...844d2070a2c0
< bitcoin-git> [bitcoin] vasild opened pull request #18843: build: warn on potentially uninitialized reads (master...enable_Wconditional-uninitialized) https://github.com/bitcoin/bitcoin/pull/18843
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18842: wallet: Mark replaced tx to not be in the mempool anymore (master...2004-walletBumpFeeReplacedTxNoMempool) https://github.com/bitcoin/bitcoin/pull/18842
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18840: wallet: Fully process previous RPCs before accepting new ones (master...2004-walletFullyProcessRPCs) https://github.com/bitcoin/bitcoin/pull/18840
< bitcoin-git> [bitcoin] fanquake closed pull request #18841: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/18841
< bitcoin-git> [bitcoin] sarojgithubb opened pull request #18841: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/18841
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18840: wallet: Fully process previous wallet calls before accepting new ones (master...2004-walletFullyProcessRPCs) https://github.com/bitcoin/bitcoin/pull/18840
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18839: test: Fix intermittent p2p_segwit issue (master...2004-qaSegwitNoIntermittentFail) https://github.com/bitcoin/bitcoin/pull/18839
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16426: Reverse cs_main, cs_wallet lock order and reduce cs_main locking (master...2019-07-remove-more-locking-chain) https://github.com/bitcoin/bitcoin/pull/16426
< bitcoin-git> bitcoin/master 0a76287 Antoine Riard: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain
< bitcoin-git> bitcoin/master de13363 Antoine Riard: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain
< bitcoin-git> bitcoin/master b855592 Antoine Riard: [wallet] Move getHeight from Chain::Lock interface to simple Chain
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e5b9308920a1...608359b071da
< gribble> https://github.com/bitcoin/bitcoin/issues/18267 | BIP-325: Signet [consensus] by kallewoof · Pull Request #18267 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Nishikoh opened pull request #18838: test: Check header hash in wait_for_getheaders (master...fix-wait_for_getheaders) https://github.com/bitcoin/bitcoin/pull/18838
< bitcoin-git> [bitcoin] fanquake closed pull request #18837: Bitzeny wallet not working, why ? (master...z1.1.x) https://github.com/bitcoin/bitcoin/pull/18837
< bitcoin-git> [bitcoin] kadri117 opened pull request #18837: Bitzeny wallet not working, why ? (master...z1.1.x) https://github.com/bitcoin/bitcoin/pull/18837

2020-04-30

< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18531: rpc: Assert that RPCArg names are equal to CRPCCommand ones (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18531: rpc: Assert that RPCArg names are equal to CRPCCommand ones (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18781: Add templated GetRandDuration<> (master...2004-randDur) https://github.com/bitcoin/bitcoin/pull/18781
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18781: Add templated GetRandDuration<> (master...2004-randDur) https://github.com/bitcoin/bitcoin/pull/18781
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git> [bitcoin] achow101 opened pull request #18836: Upgradewallet tests (master...upgradewallet-tests) https://github.com/bitcoin/bitcoin/pull/18836
< bitcoin-git> [bitcoin] hebasto closed pull request #18639: Prevent consecutive ::cs_main locks (master...200414-locks) https://github.com/bitcoin/bitcoin/pull/18639
< jonatack> jnewbery: if this is an indicator, I'm not seeing any either... bitcoin-cli getpeerinfo | grep 'getblocks' | sort
< ariard> we, Rust-Bitcoin ecosystem
< BlueMatt> to, like, any real bitcoin use where you want to verify that something will be accepted, which is, largely, the point of libbitcoinconsensus as it exists today (given it cant do full verification)
< luke-jr> I mean, if you really want to, you *could* just copy Bitcoin Core's test suite…
< luke-jr> ariard: 1) regtest doesn't need any special setup; 2) I would expect every developer to have a full setup Bitcoin env anyway
< ariard> luke-jr: you're asking people developping and testing higher stuff to have a full setup bitcoin env
< wumpus> it might be more practical than linking against bitcoin core at compile time though :)
< luke-jr> ariard: Bitcoin Core does testing this way; it works fine
< wumpus> which makes me doubt this a bit in the first place, this function accepting your transaction only means that one version of bitcoin core accepted it at one point, it doesn't tell you about the current network
< luke-jr> there is no "bitcoin core policy", there is "this node's policy" :/
< sipa> if we expose a way to test policy, it is a "test things against current bitcoin core policy", not a "learn about all the things that may be wrong"
< gribble> https://github.com/bitcoin/bitcoin/issues/15891 | test: Require standard txs in regtest by default by MarcoFalke · Pull Request #15891 · bitcoin/bitcoin · GitHub
< sipa> ariard: btw, bitcoin core internally also calls script verification twice to determine cause of failure (once with and once without standardness rules enabled)
< sipa> i see no problem exposing a Bitcoin Core library that implements the same policies as Bitcoin Core; it's just a more convenient interface to do something you can already do with running a node
< wumpus> yes, c-lightning depends on bitcoin core (at run time, not at build time)
< MarcoFalke> ariard: Doesn't lightning depend on Bitcoin Core or a different full node impl anyway?
< gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo · Pull Request #16442 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16426 | Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard · Pull Request #16426 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16946 | wallet: include a checksum of encrypted private keys by achow101 · Pull Request #16946 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 -> 5 blockers, 1 bug fix, 5 chasing concept ACK
< gribble> https://github.com/bitcoin/bitcoin/issues/18699 | wallet: Avoid translating RPC errors by MarcoFalke · Pull Request #18699 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18829: ci: Merge C++17 build with one of the existing ones (master...2004-ciSpeedupCxx17) https://github.com/bitcoin/bitcoin/pull/18829
< bitcoin-git> bitcoin/master e5b9308 MarcoFalke: Merge #18829: ci: Merge C++17 build with one of the existing ones
< bitcoin-git> bitcoin/master aaaacff MarcoFalke: ci: Merge C++17 build with one of the existing ones
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef8ef31fd28a...e5b9308920a1
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18531: rpc: Assert that RPCArg names are equal to CRPCCommand ones (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18531: rpc: Assert that RPCArg names are equal to CRPCCommand ones (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18781: Add templated GetRandDuration<> (master...2004-randDur) https://github.com/bitcoin/bitcoin/pull/18781
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18781: Add templated GetRandDuration<> (master...2004-randDur) https://github.com/bitcoin/bitcoin/pull/18781
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18775: tests: Add fuzzing harnesses for various classes/functions in policy/ (CBlockPolicyEstimator, IsRBFOptIn(…), etc.) (master...fuzzers-policy) https://github.com/bitcoin/bitcoin/pull/18775
< bitcoin-git> bitcoin/master 2bcc2bd practicalswift: tests: Clarify how we avoid hitting the signed integer overflow in CFeeRat...
< bitcoin-git> bitcoin/master 13c1f6b practicalswift: tests: Add fuzzing harness for IsRBFOptIn(...)
< bitcoin-git> bitcoin/master 3439c88 practicalswift: tests: Add fuzzing harness for CBlockPolicyEstimator
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a66ba6d029b3...ef8ef31fd28a
< bitcoin-git> [bitcoin] brakmic opened pull request #18830: rpc: add user field to getrpcinfo's json (master...getrpcinfo) https://github.com/bitcoin/bitcoin/pull/18830
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18829: ci: Merge C++17 build with one of the existing ones (master...2004-ciSpeedupCxx17) https://github.com/bitcoin/bitcoin/pull/18829
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18828: test: Strip down previous releases boilerplate (master...2004-qaPreviousReleases) https://github.com/bitcoin/bitcoin/pull/18828
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18576: test: use unittest for test_framework unit testing (master...framework-unittests) https://github.com/bitcoin/bitcoin/pull/18576
< bitcoin-git> bitcoin/master a66ba6d MarcoFalke: Merge #18576: test: use unittest for test_framework unit testing
< bitcoin-git> bitcoin/master de8905a Gloria Zhao: test: use unittest and test_runner for test framework unit testing
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00c1a4d9a95e...a66ba6d029b3
< bitcoin-git> [bitcoin] brakmic opened pull request #18827: rpc: added getrpcwhitelist method (master...getrpcwhitelist) https://github.com/bitcoin/bitcoin/pull/18827
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18809: rpc: Do not advertise dumptxoutset as a way to flush the chainstate (master...2004-rpcNoFlushAdvert) https://github.com/bitcoin/bitcoin/pull/18809
< bitcoin-git> bitcoin/master 00c1a4d MarcoFalke: Merge #18809: rpc: Do not advertise dumptxoutset as a way to flush the cha...
< bitcoin-git> bitcoin/master fac0cf6 MarcoFalke: rpc: Do not advertise dumptxoutset as a way to flush the chainstate
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf5e3be5ea74...00c1a4d9a95e
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18825: test: fix message for ECC_InitSanityCheck test (master...openssl_insanity) https://github.com/bitcoin/bitcoin/pull/18825
< bitcoin-git> bitcoin/master cf5e3be MarcoFalke: Merge #18825: test: fix message for ECC_InitSanityCheck test
< bitcoin-git> bitcoin/master 06e434d fanquake: test: fix message for ECC_InitSanityCheck test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64673b1037d6...cf5e3be5ea74
< bitcoin-git> [bitcoin] fanquake merged pull request #18780: validation: add const for minimum witness commitment size (master...minimum_witness_size) https://github.com/bitcoin/bitcoin/pull/18780
< bitcoin-git> bitcoin/master 64673b1 fanquake: Merge #18780: validation: add const for minimum witness commitment size
< bitcoin-git> bitcoin/master 692f830 fanquake: test: add test for witness commitment index
< bitcoin-git> bitcoin/master 0644254 fanquake: validation: Add minimum witness commitment size constant
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/afed2e98b0e3...64673b1037d6
< bitcoin-git> [bitcoin] rvagg opened pull request #18826: Expose txinwitness for coinbase in JSON form from RPC (master...rvagg/txinwitness-for-coinbase) https://github.com/bitcoin/bitcoin/pull/18826
< bitcoin-git> [bitcoin] laanwj merged pull request #18810: doc: update rest info on block size and json (master...18703) https://github.com/bitcoin/bitcoin/pull/18810
< bitcoin-git> bitcoin/master afed2e9 Wladimir J. van der Laan: Merge #18810: doc: update rest info on block size and json
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/35ef3c15ef82...afed2e98b0e3
< bitcoin-git> bitcoin/master ff6549c Chris Abrams: fix: update rest info on block size and json
< bitcoin-git> [bitcoin] laanwj merged pull request #18591: Add C++17 build to Travis (master...202004_c++17) https://github.com/bitcoin/bitcoin/pull/18591
< bitcoin-git> bitcoin/master 7829685 Pieter Wuille: Add configure option for c++17
< bitcoin-git> bitcoin/master 0fbde48 Pieter Wuille: Support conversion between Spans of compatible types
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/63d5ed2fc458...35ef3c15ef82
< bitcoin-git> bitcoin/master 7cbfebb Pieter Wuille: Update ax_cxx_compile_stdcxx.m4
< bitcoin-git> [bitcoin] fanquake opened pull request #18825: test: fix message for ECC_InitSanityCheck test (master...openssl_insanity) https://github.com/bitcoin/bitcoin/pull/18825
< bitcoin-git> [bitcoin] laanwj merged pull request #18437: util: Detect posix_fallocate() instead of assuming (master...posix_fallocate) https://github.com/bitcoin/bitcoin/pull/18437
< bitcoin-git> bitcoin/master 63d5ed2 Wladimir J. van der Laan: Merge #18437: util: Detect posix_fallocate() instead of assuming
< bitcoin-git> bitcoin/master 182dbdf Vasil Dimov: util: Detect posix_fallocate() instead of assuming
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/36c0abd8f61b...63d5ed2fc458
< gribble> https://github.com/bitcoin/bitcoin/issues/18267 | BIP-325: Signet [consensus] by kallewoof · Pull Request #18267 · bitcoin/bitcoin · GitHub

2020-04-29

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18726: test: check misbehavior more independently in p2p_filter.py (master...p2p-filter) https://github.com/bitcoin/bitcoin/pull/18726
< bitcoin-git> bitcoin/master 36c0abd MarcoFalke: Merge #18726: test: check misbehavior more independently in p2p_filter.py
< bitcoin-git> bitcoin/master cd543d9 Danny Lee: test: check misbehavior more independently in p2p_filter.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95a9165016ec...36c0abd8f61b
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18736: test: Add fuzzing harnesses for various classes/functions in util/ (master...fuzzers-2020-04-21) https://github.com/bitcoin/bitcoin/pull/18736
< bitcoin-git> bitcoin/master 90b635e practicalswift: tests: Add fuzzing coverage for CHECK_NONFATAL(...)
< bitcoin-git> bitcoin/master a4e3d13 practicalswift: tests: Add fuzzing coverage for StringForFeeReason(...)
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/0f204dd3f21b...95a9165016ec
< bitcoin-git> bitcoin/master a19598c practicalswift: tests: Add fuzzing harness for functions in system.h (ArgsManager)
< bitcoin-git> [bitcoin] dongcarl opened pull request #18820: build: Propagate well-known vars into depends (master...2020-04-improve-depends-hosts2) https://github.com/bitcoin/bitcoin/pull/18820
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18727: test: Add CreateWalletFromFile test (master...pr/create) https://github.com/bitcoin/bitcoin/pull/18727
< bitcoin-git> bitcoin/master 0f204dd MarcoFalke: Merge #18727: test: Add CreateWalletFromFile test
< bitcoin-git> bitcoin/master 7918c1b Russell Yanofsky: test: Add CreateWalletFromFile test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/978c5a212240...0f204dd3f21b
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18819: net: Remove unused cs_feeFilter (master...2004-netNoRecursiveMutex) https://github.com/bitcoin/bitcoin/pull/18819
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18485: test: Add mempool_updatefromblock.py (master...20200331-test-mempool) https://github.com/bitcoin/bitcoin/pull/18485
< bitcoin-git> bitcoin/master 978c5a2 MarcoFalke: Merge #18485: test: Add mempool_updatefromblock.py
< bitcoin-git> bitcoin/master 8098dea Hennadii Stepanov: test: Add mempool_updatefromblock.py
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab91a0e0fc6e...978c5a212240
< bitcoin-git> [bitcoin] luke-jr opened pull request #18818: Fix release tarball generated by gitian (master...fix_gitian_src_202004) https://github.com/bitcoin/bitcoin/pull/18818
< bitcoin-git> [bitcoin] practicalswift opened pull request #18817: doc: Document differences in bitcoind and bitcoin-qt locale handling (master...bitcoin-qt-vs-bitcoind-locale) https://github.com/bitcoin/bitcoin/pull/18817
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18798: ci: Fix default retry script usage (master...200428-ci-retry) https://github.com/bitcoin/bitcoin/pull/18798
< bitcoin-git> bitcoin/master ab91a0e MarcoFalke: Merge #18798: ci: Fix default retry script usage
< bitcoin-git> bitcoin/master 45615de Hennadii Stepanov: ci: Fix default retry script usage
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e302830faed0...ab91a0e0fc6e
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18774: test: added test for upgradewallet RPC (master...upgradewallet-tests) https://github.com/bitcoin/bitcoin/pull/18774
< bitcoin-git> bitcoin/master e302830 MarcoFalke: Merge #18774: test: added test for upgradewallet RPC
< bitcoin-git> bitcoin/master 66fe7b1 Harris: test: added test for upgradewallet RPC
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af2ec6b03745...e302830faed0
< wumpus> not something any CPU capable of running a bitcoin node in the first place will have any trouble with I guess, it's only per-incoming-connection not per packet
< vasild> btw our current implementation https://github.com/bitcoin/bitcoin/blob/master/src/netaddress.cpp#L815 is checking all 16 bytes unnecessary - it could stop checking (break; from the loop) as soon as it finds a 0 byte in the netmask. E.g. with a netmask like /255.0.0.0 we don't need to check whether `(addr.ip[x] & netmask[x]) != network.ip[x]` is true or false for the last 3 bytes
< dongcarl> vasild: Well, if it's acceptable to you, you should put yourself as co-author on the commits, and push as a branch to your remote on github e.g. `vaslid/bitcoin`, and I'll get those commits into my branch/PR
< bitcoin-git> [bitcoin] practicalswift closed pull request #18124: init: Clarify C and C++ locale assumptions. Add locale sanity checks to verify assumptions at run-time. (master...LocaleSanityCheck) https://github.com/bitcoin/bitcoin/pull/18124
< bitcoin-git> [bitcoin] practicalswift closed pull request #18147: qt: Kill the locale dependency bug class by not allowing Qt to mess with LC_NUMERIC (master...kill-locale-dependency-bug-class) https://github.com/bitcoin/bitcoin/pull/18147
< bitcoin-git> [bitcoin] practicalswift closed pull request #17895: build: Enable Clang's -Wconditional-uninitialized to warn on potential uninitialized reads (master...continue-killing-of-uninitialized-reads) https://github.com/bitcoin/bitcoin/pull/17895
< vasild> yes, I agree - "for the sake of it" is useless. The main reason I started looking into it was that it would simplify addrv2 changes: https://github.com/bitcoin/bitcoin/pull/16748#discussion_r414663229
< gribble> https://github.com/bitcoin/bitcoin/issues/16748 | [WIP] Add support for addrv2 (BIP155) by dongcarl · Pull Request #16748 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815