< addressleakt>
I do a "bitcoin-cli dumpwallet wallet.txt" and I get a 300 MB file which seems to contain all addresses.
< addressleakt>
Reading the manual I got the impression that importwallet would be the command to use to import this wallet-dump. So on a different Bitcoin Core I do "bitcoin-cli importwallet wallet.txt", I then do a dumpwallet on this new node to verify that the wallet have imported all the addresses correctly.
< instagibbs>
amaclin, if it's a feature for bitcoin core, opening an issue as feature request is definitely appropriate
< molz>
amaclin, you can do it in channel #bitcoin or #bitcoin-dev
< amaclin>
may I propose Bitcoin client feature here?
< bitcoin-git>
[bitcoin] instagibbs opened pull request #14857: wallet_keypool_topup.py: Test for all keypool address types (master...keypool_topup_addresstype) https://github.com/bitcoin/bitcoin/pull/14857
< bitcoin-git>
[bitcoin] dongcarl opened pull request #14856: [rebase] net: remove more CConnman globals (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
< NicolasDorier>
gmaxwell: The people who would not check the utxo set, would also never check the bitcoin core binaries via gitian and just download them from the website.
< bitcoin-git>
[bitcoin] Empact opened pull request #14855: test: Correct ineffectual WithOrVersion from transactions_tests (master...with-or-version-test) https://github.com/bitcoin/bitcoin/pull/14855
< NicolasDorier>
Sorry, this conversation might be better on bitcoin-dev than on bitcoin-core-dev.
< NicolasDorier>
I initially just wanted to propose the idea of including such utxo set snapshot hash in a text file in Bitcoin Core releases as part of the release process. So people trusting the gitian sigs, can also trust the snapshot hash. It would be one UTXO set snapshot at every core release, which is more than enough.
< NicolasDorier>
Strictly better to use Bitcoin Core to filter the traffic for me
< bitcoin-git>
bitcoin/0.17 fcdea8a Andrew Chow: Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things...
< bitcoin-git>
bitcoin/0.17 fcefc68 Andrew Chow: Convert non-witness UTXOs to witness if witness sig created...
< bitcoin-git>
bitcoin/0.17 3362a95 MarcoFalke: Merge #14196: [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary...
< bitcoin-git>
bitcoin/master fe1ff50 Chun Kuan Lee: Hide spendable label if priveate key is disabled
< bitcoin-git>
bitcoin/master 82d6c5a Chun Kuan Lee: gui: Show watch-only eye instead of HD disabled
< bitcoin-git>
bitcoin/master ed12fd8 Wladimir J. van der Laan: Merge #13966: gui: When private key is disabled, only show watch-only balance...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13966: gui: When private key is disabled, only show watch-only balance (master...ui-disable-privkey) https://github.com/bitcoin/bitcoin/pull/13966
< gribble>
https://github.com/bitcoin/bitcoin/issues/13930 | Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader by Sjors · Pull Request #13930 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 5ab5341 Wladimir J. van der Laan: Merge #14841: consensus: Move CheckBlock() call to critical section...
< provoostenator>
luke-jr: my dedicated pizza provider accepts bitcoin via BitPay, and I generally finish my pizza before it's confirmed, depsite all the error messages and RBF fud.
< luke-jr>
provoostenator: my dedicated server provider accepts bitcoin via BitPay, and I just use PayPal nowadays instead because BitPay screwed up one too many times
< luke-jr>
sipa: well, chasing away centralising people would only be a means to a goal (keeping Bitcoin itself secure)
< luke-jr>
well, if they move to altcoins, that's not so much Bitcoin's problem..
< gmaxwell>
luke-jr: even if you don't care about compeating with paypal, other people in the bitcoin ecosystem do. And they'll make tradeoffs as required to do so, and drag the ecosystem in that direction, especially if people who don't so much care about paypal ignore the requirements.
< bitcoin-git>
[bitcoin] fanquake opened pull request #14853: depends: latest rapidcheck, enable property based tests on Travis (master...latest-rapidcheck) https://github.com/bitcoin/bitcoin/pull/14853
< gribble>
https://github.com/bitcoin/bitcoin/issues/14733 | P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. by zallarak · Pull Request #14733 · bitcoin/bitcoin · GitHub
2018-11-30
< gribble>
https://github.com/bitcoin/bitcoin/issues/11551 | Fix unsigned integer wrap-around in GetBlockProofEquivalentTime by practicalswift · Pull Request #11551 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< Chris_Stewart_5>
if anyone wants to take a stab at answering this loaded question ;) ttps://bitcoin.stackexchange.com/questions/81503/what-is-the-tradeoff-between-privacy-and-implementation-complexity-of-dandelion
< bitcoin-git>
[bitcoin] vim88 opened pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
< BlueMatt>
I have another bitcoin-dev post coming discussing package relay, but we have a few options there, if we just want to solve package relay for contracting applications like lightning, we can do so with limited consideration, I think
< BlueMatt>
but, at least IMO, its super annoying that you cant build+run bitcoin-qt on the now-several-months-old versions of various OSs, and I presume other rolling distros (eg arch) also have this issue
< gmaxwell>
I guess I can argue the consequences either way, I can imagine someone losing a wallet file with lots of bitcoin in it because it showed a low balance due to some easily abandoned transactions.
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< BlueMatt>
but 0.17.0 currently cannot be self-built and bitcoin-qt opened on latest fedora/ubuntu release
< gribble>
https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14834: validation: do not break assumption that pindexPrev may be null (master...20181129-contextualcheckblock-pindexprev-nullness) https://github.com/bitcoin/bitcoin/pull/14834
< gribble>
https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/0.17 bb90695 gustavonalle: [wallet] Ensure wallet is unlocked before signing...
< bitcoin-git>
bitcoin/0.17 85aacc4 Walter: Add autogen.sh in ARM Cross-compilation...
< bitcoin-git>
bitcoin/0.17 9406502 Kaz Wesley: add a test demonstrating an overflow in a deserialization edge case...
< bitcoin-git>
[bitcoin] ch4ot1c opened pull request #14832: docs: Add more Doxygen information to Developer Notes (master...improvement/doxygen-docs) https://github.com/bitcoin/bitcoin/pull/14832
< bitcoin-git>
[bitcoin] vim88 opened pull request #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. (master...proper_shebang) https://github.com/bitcoin/bitcoin/pull/14831
< gribble>
https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
< dongcarl>
gmaxwell: Huh... I was actually thinking that errors need error codes in Bitcoin... But perhaps that's a bad idea...
< Guest80>
Anybody here experienced with bitcoin core build?
< sipa>
for example, bitcoin core will use a very different codepath for an ecdsa signature that is too long vs one that is just invalid
< gmaxwell>
like, yes maybe bitcoin core has a branch that checks the size and terminates... but without that branch it would still reject those cases because the hash function (a size triggered OR of two functions) will never match for inputs of other sizes.
< aj>
$ time (blk=$(bitcoin-cli getblockhash 551601); echo $blk; bitcoin-cli invalidateblock $blk; bitcoin-cli gettxoutsetinfo | grep hash_serial; bitcoin-cli reconsiderblock $blk) # --> 666550387c3f5fa8e9353ce561fcee2a164022d31b97affd7c982388f19a4904as the hash, took about 1m12 all up
< NicolasDorier>
aj: At least for the reviewers. People running those "bitcoin core in a box" are already blindly trusting binaries anyway.
< NicolasDorier>
I think this is even better UX than embedding known utxo hash set anywhere into bitcoin core.
< gmaxwell>
NicolasDorier: if the "bitcoin core in a box" then the entire software could do arbritary things, the hash it gives is meaningless.
< NicolasDorier>
Yes I can understand. I am just worried that right now what we will see with those "Bitcoin Core in a box" is blind reliance on a pre-shipped UTXO Set
< NicolasDorier>
So the user could fast sync from untrusted source, and would get a warning if that differ from Bitcoin Core website/twitter or whatever publish mechanism
< NicolasDorier>
so instead I was thinking the following: What about Bitcoin Core share the txoutset hash on bitcoincore website or twitter or whatever (like every 1000 blocks). At BTCPay level, I would show the UTXOSet of their own node and check against the website
< bitcoin-git>
bitcoin/master c77f092 Russell Yanofsky: Fix descriptor_tests not checking ToString output of public descriptors
< bitcoin-git>
bitcoin/master 0fa3703 MarcoFalke: Merge #14820: test: Fix descriptor_tests not checking ToString output of public descriptors...
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #14820: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
< gmaxwell>
provoostenator: 09:57:52 < jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason
< gribble>
https://github.com/bitcoin/bitcoin/issues/10595 | Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients by luke-jr · Pull Request #10595 · bitcoin/bitcoin · GitHub
< jnewbery>
I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason don't want to include a certain class of transaction in their blocks.
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819
< jnewbery>
I think promag means 'what if the miner wants to take Bitcoin Core 0.18 but doesn't want to upgrade his pool software to support mining segwit blocks?'
< sipa>
promag: currently, if the gbt client does not provide segwit flag, bitcoin core will produce a (suboptimal) block template without segwit txn
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (master...bugfix_test_rpc_psbt) https://github.com/bitcoin/bitcoin/pull/14818
< gribble>
https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] hebasto opened pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817
< bitcoin-git>
[bitcoin] instagibbs opened pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
< bitcoin-git>
[bitcoin] jamesob opened pull request #14812: qa: fix p2p_invalid_messages on macOS (master...2018-11-test-macos-mem-fix) https://github.com/bitcoin/bitcoin/pull/14812
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14811: Mining: Enforce that segwit option must be set in GBT (master...remove_non_segwit_mining) https://github.com/bitcoin/bitcoin/pull/14811
< bitcoin-git>
[bitcoin] stevenroose opened pull request #14805: tests: Support calling add_nodes more than once (master...test-framework) https://github.com/bitcoin/bitcoin/pull/14805
< bitcoin-git>
[bitcoin] fanquake closed pull request #14072: [primitives, consensus] Make fChecked an atomic<bool> (master...fchecked-atomic) https://github.com/bitcoin/bitcoin/pull/14072
< bitcoin-git>
[bitcoin] hebasto opened pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14400: Add Benchmark to test input de-duplication worst case (master...benchmark-reject-duplicate-inputs) https://github.com/bitcoin/bitcoin/pull/14400