< bitcoin-git>
[bitcoin] stevenroose opened pull request #14805: tests: Support calling add_nodes more than once (master...test-framework) https://github.com/bitcoin/bitcoin/pull/14805
< bitcoin-git>
[bitcoin] fanquake closed pull request #14072: [primitives, consensus] Make fChecked an atomic<bool> (master...fchecked-atomic) https://github.com/bitcoin/bitcoin/pull/14072
< bitcoin-git>
[bitcoin] hebasto opened pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14400: Add Benchmark to test input de-duplication worst case (master...benchmark-reject-duplicate-inputs) https://github.com/bitcoin/bitcoin/pull/14400
< bitcoin-git>
[bitcoin] hebasto opened pull request #14798: qt: Fix Peers tab switch away in RPC console (master...20181124-fix-peers-tab-switch) https://github.com/bitcoin/bitcoin/pull/14798
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
2018-11-23
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14796: rpc: Pass argument descriptions to RPCHelpMan (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14796
< lopp>
are you suggesting that people have a life outside of bitcoin??? :-P
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits error: gpg failed to sign the data fatal: failed to write commit object Merge commit HEAD is not clean
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits
< bitcoin-git>
bitcoin/master af9a991 Cornelius Schumacher: Fix detection of copyright holders...
< bitcoin-git>
[bitcoin] marcoagner opened pull request #14795: test: allows test_runner command line to receive parameters for each test (master...fix_test_runner_parameters) https://github.com/bitcoin/bitcoin/pull/14795
< bitcoin-git>
bitcoin/master b81a186 Gregory Sanders: GetPubKey: make sigdata const
< bitcoin-git>
bitcoin/master 0595164 Wladimir J. van der Laan: Merge #14678: [wallet] remove redundant KeyOriginInfo access, already done in CreateSig...
< bitcoin-git>
[bitcoin] laanwj closed pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612
< bitcoin-git>
[bitcoin] laanwj closed pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< bitcoin-git>
bitcoin/master 8284756 John Newbery: A few minor formatting fixes and clarifications to descriptors.md
< bitcoin-git>
bitcoin/master d7fbe7d Wladimir J. van der Laan: Merge #14778: A few minor formatting fixes and clarifications to descriptors.md...
2018-11-22
< bitcoin-git>
[bitcoin] kristapsk opened pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14789: qa: Run feature_block tests on p2p and rpc interface (master...Mf1811-qaBlockRpc) https://github.com/bitcoin/bitcoin/pull/14789
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #14788: tests: Possible fix the permission error when the tests open the cookie file (master...fix-win-test-perm-deny) https://github.com/bitcoin/bitcoin/pull/14788
< bitcoin-git>
[bitcoin] merland opened pull request #14787: Replace old instructions with links to official docs (master...issue14639) https://github.com/bitcoin/bitcoin/pull/14787
< promag>
maybe we should just call `noui_connect()` in bitcoin-qt?
< bitcoin-git>
[bitcoin] promag opened pull request #14783: qt: Fix boost::signals2::no_slots_error in early calls to InitWarning (master...2018-11-fix-noslotserror) https://github.com/bitcoin/bitcoin/pull/14783
< bitcoin-git>
[bitcoin] laanwj closed pull request #14756: Improve rpcauth.py by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< bitcoin-git>
[bitcoin] laanwj closed pull request #14532: Never bind INADDR_ANY by default, and warn when doing so explicitly (master...rpcbind_explicit) https://github.com/bitcoin/bitcoin/pull/14532
< bitcoin-git>
bitcoin/master 7bad78c Ben Woosley: Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h...
< bitcoin-git>
bitcoin/master 69ca487 Ben Woosley: Implement prevector::fill once...
< bitcoin-git>
bitcoin/master e736b67 Wladimir J. van der Laan: Merge #14715: Drop defunct prevector compat handling...
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git>
[bitcoin] luke-jr closed pull request #14781: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (master...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14781
< bitcoin-git>
[bitcoin] luke-jr opened pull request #14782: [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") (0.17...bugfix_rpc_getbalance_acctstar-0.17) https://github.com/bitcoin/bitcoin/pull/14782
< gmaxwell>
"I have made progress and while the current implementation is 20% slower than it could be it is still five times faster than before and think I will settle for that. Details are in my bitcoin-armv8 repo. It is reindexing my copy of the bitcoin blockchain at over double the pace."
2018-11-21
< bitcoin-git>
[bitcoin] jnewbery opened pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< gribble>
https://github.com/bitcoin/bitcoin/issues/8751 | RPC: Add parameter to addmultisigaddress / createmultisig to sort public keys by afk11 · Pull Request #8751 · bitcoin/bitcoin · GitHub
< dgpv>
sipa: actually my initial question was should I submit a PR with change for sortedmulti() or just create an issue on bitcoin core github
< sipa>
all i'm saying is that i don't think it makes sense to commit to "bitcoin core aims to be interoperable with software X"
< gmaxwell>
dgpv: Seriously, the bitcoin project has been held back for years by misguided efforts towards interoperability with a largely indifferent industry. It's a bit irritating that you're advocating us burning more time here on this particular point of it, because it would be useful in your product.
< bitcoin-git>
[bitcoin] laanwj closed pull request #14708: Warn unrecognised sections in the config file (master...warn_unrecognized_section) https://github.com/bitcoin/bitcoin/pull/14708
< sipa>
dgpv: so far, the bitcoin core wallet also hasn't really supported HD chains created by other software as import
< bitcoin-git>
[bitcoin] kallewoof opened pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
< TGeek>
Hi all, I am having an issue in bitcoin core 0.17.0.1 with the bumpfee rpc call.. It keeps throwing an error "(-4) Transaction does not have a change output". Which is strange because the output for the tx has two outputs, one for the to address and one for change. I have been troubleshooting this issue for 2 days now and cannot seem to find anything related in searches.. Any help would be greatly appreciated.
2018-11-20
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
< bitcoin-git>
[bitcoin] vim88 closed pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
< wumpus>
look, there's this concern we haven't even ever *thought* about and suddenly it needs to be considered in bitcoin core
< LGzr>
Hola, all. I've a question about the p2sh example at https://bitcoin.org/en/developer-examples#p2sh-multisig; is there a more appropriate forum than here? (Question is: what purpose it serves that createmultisig uses public key for one, and addresses for the others)
< bitcoin-git>
[bitcoin] practicalswift opened pull request #14757: Avoid reading uninitialized variables in serialization code (triggered when running "make check") (master...avoid-read-of-uninitialized-variable) https://github.com/bitcoin/bitcoin/pull/14757
< bitcoin-git>
[bitcoin] promag opened pull request #14756: Improve by using argparse and getpass modules (master...2018-11-improve-rpcauth.py) https://github.com/bitcoin/bitcoin/pull/14756
< gmaxwell>
(I've seen other people get tricked into thinking that 'classic' is the orignal bitcoin. .. the most amusing of which was some post after BU caught fire that tried to claim that BU's problems were mostly because the original bitcoin software was such crap, and then went after a bunch of bugs in 'classic' that either never were in Bitcoin or had long since been fixed. :P )
< BlueMatt>
you'll note the snaps in this case were pretty clearly some bitcoin classic troll
< gmaxwell>
oh jesus. it's bitcoin "classic"?
< BlueMatt>
no idea, the link to the "developer site" is bitcoin classic
< gmaxwell>
occurs at the early startup stage of bitcoin-qt, it renders bitcoin-qt
< bitcoin-git>
[bitcoin] vim88 opened pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
< bitcoin-git>
[bitcoin] domob1812 opened pull request #14752: tests: Unit tests for IsPayToWitnessScriptHash and IsWitnessProgram (master...script-segwit-tests) https://github.com/bitcoin/bitcoin/pull/14752
< bitcoin-git>
[bitcoin] vim88 closed pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
< bitcoin-git>
[bitcoin] vim88 opened pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
< bitcoin-git>
[bitcoin] dongcarl opened pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
< dongcarl>
Any reason why `bitcoin/share/rpcauth/rpcauth.py` generates a 16 byte salt instead of a 32 byte salt? I believe RFC 2104 recommends the key length to be larger than or equal to the hash output length: https://tools.ietf.org/html/rfc2104#section-3
< Dizzle_>
luke-jr: if the mined block is proposed to Bitcoin Core via getblock template, it gets called, and I couldn't find an indication that a valid proposal gets submitted by Core.
< bitcoin-git>
[bitcoin] zallarak opened pull request #14733: p2p: allow p2ptimeout to be configurable, speed up slow test (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
< sipa>
Vita: #bitcoin-wizards or so, off topic here
< stevenroose>
who is maintaining the gnusha.org logs? Are they open to adding more channels? We were thinging we'd love one for #rust-bitcoin
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
< MarcoFalke>
Git should be installed on the machine, so you could do "git fetch https://github.com/promag/bitcoin branch && git merge FETCH_HEAD" before compiling?
< gribble>
https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/master 65b740f Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git>
bitcoin/master da427db Russell Yanofsky: Rename ListTransactions filter variable...
< bitcoin-git>
bitcoin/master e74649e MarcoFalke: Merge #14411: [wallet] Restore ability to list incoming transactions by label...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14478: Show error to user when corrupt wallet unlock fails (master...201810_wallet_corruption_error) https://github.com/bitcoin/bitcoin/pull/14478