[bitcoin] practicalswift closed pull request #13766: Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers. (master...initialize-members-in-initialization-list) https://github.com/bitcoin/bitcoin/pull/13766
Hello, can anyone comment on the following claim. "If there is a clock drifts more than 2 hours and and there are 2 chains similar PoW, then we can have a fork where both chains think they are longest in their own view. So, bitcoin network operates on some synchronous assumptions."
bitcoin/master fadffae MarcoFalke: Revert "Make qt wallet test compatible with qt4"...
bitcoin/master 96c409c Wladimir J. van der Laan: Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"...
Chris_Stewart_5 See the channel history, we've forked rapidcheck to bitcoin-core, could be a chance to use the new make install method etc. You should have gotten invite to /bitcoin and /bitcoin-core as well.
midnightmagic: well... currently only run OpenBSD in VM; and yes, bitcoin builds fine on OpenBSD, there's special instructions for that, which fanquake updated for 6.4 and I'l like to test out but couldn't yet
jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them.
[bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969
as you can't really make an assumption about the precision, yes if you write software for bitcoin specifically you can hardcode 10^-8, but anythign that needs to interface between different systems and APIs and databases needs to convert between them on their own terms
phantomcircuit: the old json library bitcoin used to use randomly inserted conversions to float in a minor upgrade!
phantomcircuit: depends on what you mean by float, common bitcoin values don't fit precisely in 32-bit floats, they do in 64-bit doubles.
gmaxwell: yes, it's trivial change to ValueFromAmount if you really want to, though I'd suggest looking at a better suited JSONRPC library, by now for most languages there's something for bitcoin specifically
in Bitcoin core they're just 64 bit integers.
thinking out loud- yesterday we talked with colleague how we hate that JSON RPC returns BTC values as floats. (at various points.) Do you think it would be a good idea to be able to somehow switch this with some option? either option for whole bitcoind, or just another parameter for bitcoin-cli
ken2812221: do you build bitcoin-qt with msvc?
[bitcoin] laanwj closed pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
[bitcoin] practicalswift opened pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496