2019-01-20

< bitcoin-git> bitcoin/master 5b4283c Carl Dong: Add comment describing fDisconnect behavior
< bitcoin-git> bitcoin/master 978682b Wladimir J. van der Laan: Merge #15194: Add comment describing fDisconnect behavior...
< bitcoin-git> [bitcoin] practicalswift opened pull request #15215: rpc: Use the return value of GetProxy(...) in GetNetworksInfo(). Mark GetProxy(...) with [[nodiscard]]. (master...getnetworkinfo-getproxy) https://github.com/bitcoin/bitcoin/pull/15215
< bitcoin-git> [bitcoin] instagibbs closed pull request #15179: doc: Slight clarity boost to SEQUENCE_LOCKTIME_DISABLE_FLAG (master...rel_lock_lang) https://github.com/bitcoin/bitcoin/pull/15179
< bitcoin-git> [bitcoin] practicalswift opened pull request #15214: Improve tests by checking for expected return values (master...check-return-values-in-tests) https://github.com/bitcoin/bitcoin/pull/15214
< bitcoin-git> [bitcoin] instagibbs opened pull request #15213: Remove errant past from walletcreatefundedpsbt for nLocktime replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15213
< bitcoin-git> [bitcoin] instagibbs closed pull request #15212: Remove errant paste from walletcreatefundedpsbt meant for replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15212
< bitcoin-git> [bitcoin] instagibbs opened pull request #15212: Remove errant paste from walletcreatefundedpsbt meant for replaceable (master...wcfpsbt_paste_err) https://github.com/bitcoin/bitcoin/pull/15212
< booyah> and have compiler(s) compiler bitcoin into that IR, and have identical IR from them
< dongcarl> fanquake: For the part of completing reproducible builds of bitcoin with guix, I might write up some instrucitons to do so when I sort out the current sources of non-determinism (I think qt is the culprit right now)

2019-01-19

< * hebasto> can build Bitcoin Core against any Qt version for testing now: https://gist.github.com/hebasto/4c571f6b368ab2b0d75b94aaf4bb512a
< bitcoin-git> [bitcoin] promag opened pull request #15210: gui: Fix window title update (master...2019-01-fixwindowtitle) https://github.com/bitcoin/bitcoin/pull/15210
< bitcoin-git> [bitcoin] fanquake opened pull request #15209: zmq: log outbound message high water mark when reusing socket (master...zmq-always-log-high-water-mark) https://github.com/bitcoin/bitcoin/pull/15209
< bitcoin-git> bitcoin/master fe60ee9 Wladimir J. van der Laan: Merge #15186: rpc: remove duplicate solvable field from getaddressinfo...
< bitcoin-git> [bitcoin] laanwj closed pull request #15186: rpc: remove duplicate solvable field from getaddressinfo (master...duplicate-solvable-fields) https://github.com/bitcoin/bitcoin/pull/15186
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b59fa2ce8aa...fe60ee96e915
< bitcoin-git> bitcoin/master a2a6c8f fanquake: rpc: remove duplicate solvable field from getaddressinfo
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f55808ad6939...3b59fa2ce8aa
< bitcoin-git> bitcoin/master 979bc0c Hennadii Stepanov: Improve "help-console" message...
< bitcoin-git> bitcoin/master 3b59fa2 Wladimir J. van der Laan: Merge #15178: qt: Improve "help-console" message...
< bitcoin-git> [bitcoin] laanwj closed pull request #15178: qt: Improve "help-console" message (master...20190116-improve-help-console) https://github.com/bitcoin/bitcoin/pull/15178
< gribble> https://github.com/bitcoin/bitcoin/issues/15178 | qt: Improve "help-console" message by hebasto · Pull Request #15178 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11 (master...2019/01/macos_autostart) https://github.com/bitcoin/bitcoin/pull/15208
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15175: build: Drop macports support (master...drop-macports) https://github.com/bitcoin/bitcoin/pull/15175
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/63144335becb...f55808ad6939
< bitcoin-git> bitcoin/master 4e81438 Ben Woosley: build: Drop macports support...
< bitcoin-git> bitcoin/master f55808a Jonas Schnelli: Merge #15175: build: Drop macports support...
< sipa> coco: #bitcoin-wizards or so
< sipa> this channel is about development of the bitcoin core software, not wild redesigns

2019-01-18

< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15206: p2p: immediately disconnect on invalid net message checksum (master...2019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
< gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #13100: gui: Add dynamic wallets support (master...2018-04-ui-open-wallet) https://github.com/bitcoin/bitcoin/pull/13100
< promag> jnewbery: typo in "Add an "opem wallet" command in bitcoin-qt" 13059
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15101: gui: Add WalletController (master...2019-01-walletcontroller) https://github.com/bitcoin/bitcoin/pull/15101
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd42553b1178...63144335becb
< bitcoin-git> bitcoin/master cefb399 João Barbosa: gui: Use AutoConnection for WalletModel::unload signal
< bitcoin-git> bitcoin/master 8fa271f João Barbosa: gui: Add WalletController
< bitcoin-git> bitcoin/master 0dd9bde João Barbosa: gui: Refactor to use WalletController
< bitcoin-git> [bitcoin] jamesob opened pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
< bitcoin-git> [bitcoin] dooglus opened pull request #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) (master...fix-startup-crash) https://github.com/bitcoin/bitcoin/pull/15203
< rafalcpp> hi, how Bitcoin achieves deterministic builds of Qt client too?
< bitcoin-git> [bitcoin] DesWurstes closed pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
< bitcoin-git> [bitcoin] promag opened pull request #15202: gui: Add Close All Wallets action (master...2019-01-closeallwallets) https://github.com/bitcoin/bitcoin/pull/15202
< bitcoin-git> [bitcoin] practicalswift opened pull request #15201: net: Add missing cs_vNodes lock in CConnman::Stop(). Add missing locking annotation. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
< gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] DesWurstes opened pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
< gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
< wumpus> then, please file a bug report with as much info about the issue as possible: https://github.com/bitcoin/bitcoin/issues/new
< gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
< DeanGuss> Anybody happen to know why wallet.cpp shuts bitcoind down when encryptwallet rpc command is called? https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp line 676
< dufferzafar> okay, is it bitcoin-help? i saw this channel mentioned on slack, so came here
< wumpus> it's fine as long as you don't go arguing how bitcoin's P2P protocol works...
< wumpus> I think you need to read up on how your tooling is used with other TCP protocols, it's not really different for bitcoin
< dufferzafar> so, the ports 12192 & 12476 are the ones the two bitcoin processes (btc1 & btc2) are listening on
< dufferzafar> i'm doing some network measurement experiments on bitcoin
< dufferzafar> i have bitcoin daemons running on multiple machines
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197
< luke-jr> Alixe: this is not "talk to devs", it is "talk about development", and your question is not about development. some of us are in #bitcoin too
< sipa> #bitcoin
< Alixe> So I think mining hash power can't do anything because full nodes enforce consensus rules. But some people think governments or corporates can buy a lot of nodes to affect Bitcoin with having majority of full nodes. Is it possible?
< bitcoin-git> [bitcoin] gkrizek opened pull request #15196: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196
< bitcoin-git> [bitcoin] promag opened pull request #15195: gui: Add close wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195

2019-01-17

< bitcoin-git> [bitcoin] dongcarl opened pull request #15194: Add comment describing fDisconnect behavior (master...2019-01-add-fDisconnect-comment) https://github.com/bitcoin/bitcoin/pull/15194
< dongcarl> Any further review on https://github.com/bitcoin/bitcoin/pull/14605 ?
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15193: Default -whitelistforcelay to off (master...2019-01-forcerelayoff) https://github.com/bitcoin/bitcoin/pull/15193
< bitcoin-git> [bitcoin] practicalswift closed pull request #11652: Add missing locks: validation.cpp + related (master...init-and-validation-locks) https://github.com/bitcoin/bitcoin/pull/11652
< bitcoin-git> [bitcoin] practicalswift opened pull request #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache() and benchmarks/tests. Add annotations. (master...validation-cs_main) https://github.com/bitcoin/bitcoin/pull/15192
< gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15040: qt: Add workaround for QProgressDialog bug on macOS (master...20181226-fix-macos-qprogressdialog) https://github.com/bitcoin/bitcoin/pull/15040
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12b30105fc59...cd42553b1178
< bitcoin-git> bitcoin/master 7c572c4 Hennadii Stepanov: Add workaround for QProgressDialog bug on macOS...
< bitcoin-git> bitcoin/master cd42553 Jonas Schnelli: Merge #15040: qt: Add workaround for QProgressDialog bug on macOS...
< luke-jr> wumpus: fwiw, it's not exactly pretty, but I haven't had any problem reports from https://github.com/bitcoinknots/bitcoin/commit/8261704f7fec4e3879f2b018fc27eb8834e698a6 so far
< gribble> https://github.com/bitcoin/bitcoin/issues/15188 | Update zmq to 4.3.1 by rex4539 · Pull Request #15188 · bitcoin/bitcoin · GitHub
< gwillen> just replacing it with some kind of simple fixed notice with a pointer to the COPYING file, without varying years or names other than "the Bitcoin developers" or what have you
< bitcoin-git> [bitcoin] practicalswift closed pull request #15189: validation: Add missing lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189
< bitcoin-git> [bitcoin] practicalswift opened pull request #15191: validation: Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning. (master...cs_LastBlockFile) https://github.com/bitcoin/bitcoin/pull/15191
< sipa> gwillen: IANAL but i believe those copyright statements per file (and much less the year indications) are almost certainly worthless, especially when attributing to "The Bitcoin Core developers", which is not a legal entity
< bitcoin-git> [bitcoin] LifeIsPizza closed pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190
< bitcoin-git> [bitcoin] LifeIsPizza opened pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190
< bitcoin-git> [bitcoin] practicalswift opened pull request #15189: validation: Add missing cs_nBlockSequenceId lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189
< bitcoin-git> [bitcoin] practicalswift closed pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] rex4539 opened pull request #15188: Update zmq to 4.3.1 (master...update-zmq) https://github.com/bitcoin/bitcoin/pull/15188
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/003a47f804b1...12b30105fc59
< bitcoin-git> bitcoin/master 638e53b practicalswift: Pin shellcheck version to v0.6.0
< bitcoin-git> bitcoin/master 07a53dc practicalswift: Remove repeated suppression. Fix indentation.
< bitcoin-git> bitcoin/master 0b7196e practicalswift: Fix warnings introduced in shellcheck v0.6.0
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15166: qa: Pin shellcheck version (master...opt-out-of-new-shellcheck-warnings) https://github.com/bitcoin/bitcoin/pull/15166
< bitcoin-git> [bitcoin] practicalswift opened pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee604487f54...003a47f804b1
< bitcoin-git> bitcoin/master 31097b7 benthecarman: docs: Spelling error fix on fuzzing.md
< bitcoin-git> bitcoin/master 003a47f MarcoFalke: Merge #15185: docs: Spelling error fix on fuzzing.md...
< gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fcb6694a9945...7ee604487f54
< bitcoin-git> bitcoin/master 1c0e0a5 Hennadii Stepanov: Remove redundant stopThread() signal
< bitcoin-git> bitcoin/master 24313fb Hennadii Stepanov: Remove redundant stopExecutor() signal
< bitcoin-git> bitcoin/master 7ee6044 Wladimir J. van der Laan: Merge #14250: qt: Remove redundant stopThread() and stopExecutor() signals...
< bitcoin-git> [bitcoin] laanwj closed pull request #14250: qt: Remove redundant stopThread() and stopExecutor() signals (master...stopthread-signal) https://github.com/bitcoin/bitcoin/pull/14250
< gribble> https://github.com/bitcoin/bitcoin/issues/14984 | rpc: Speedup getrawmempool when verbose=true by promag · Pull Request #14984 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14250 | qt: Remove redundant stopThread() and stopExecutor() signals by hebasto · Pull Request #14250 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact closed pull request #15133: [WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder (master...factories) https://github.com/bitcoin/bitcoin/pull/15133
< bitcoin-git> [bitcoin] fanquake opened pull request #15186: rpc: remove duplicate solvable field from getaddressinfo (master...duplicate-solvable-fields) https://github.com/bitcoin/bitcoin/pull/15186
< bitcoin-git> [bitcoin] benthecarman opened pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185

2019-01-16

< gkrizek> Found it! This commit broke the Cron CI runs. https://github.com/bitcoin/bitcoin/commit/74ce32683199b987e45eb16f0320ae392ff10edc
< gkrizek> Seems like this if statement is the only thing in the script that could exit(1) without logging a message: https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/verify-commits.py#L110-L120
< wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/480544456 the only visible warning is the one about a missspelling in fuzzing.md, however that's an old warning and also spelling errors don't cause the test to fail
< wumpus> travis is failing on master and I don't understand why: https://travis-ci.org/bitcoin/bitcoin/builds/480544455?utm_medium=notification&utm_source=email
< bitcoin-git> [bitcoin] laanwj closed pull request #15182: [Minor Performance Fix] - Reserve vectors, to save reallocation costs. (master...master) https://github.com/bitcoin/bitcoin/pull/15182
< bitcoin-git> [bitcoin] marcoagner opened pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value: (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183
< bitcoin-git> [bitcoin] shahzadlone opened pull request #15182: [Minor Performance Fix] - Reserve vectors, to save reallocation costs. (master...master) https://github.com/bitcoin/bitcoin/pull/15182
< bitcoin-git> [bitcoin] domob1812 opened pull request #15181: Use correct RPC port in help curl example (master...rpchelp-port) https://github.com/bitcoin/bitcoin/pull/15181
< bitcoin-git> [bitcoin] laanwj closed pull request #14839: [rebase] threads: fix unitialized members in sched_param (master...rebased-fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14839
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f71c2ea6620a...fcb6694a9945
< bitcoin-git> bitcoin/master 8928237 Cory Fields: threads: fix unitialized members in sched_param...
< bitcoin-git> bitcoin/master fcb6694 Wladimir J. van der Laan: Merge #14839: [rebase] threads: fix unitialized members in sched_param...
< bitcoin-git> [bitcoin] domob1812 closed pull request #15158: Use real bind address in RPC help curl example (master...rpchelp-addr) https://github.com/bitcoin/bitcoin/pull/15158
< bitcoin-git> [bitcoin] instagibbs opened pull request #15179: [trivial] Slight clarity boost to SEQUENCE_LOCKTIME_DISABLE_FLAG (master...rel_lock_lang) https://github.com/bitcoin/bitcoin/pull/15179
< bitcoin-git> [bitcoin] laanwj closed pull request #15122: [RPC] Expand help text for importmulti changes (master...pr14565_release_notes) https://github.com/bitcoin/bitcoin/pull/15122
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d44b01f028e2...f71c2ea6620a
< bitcoin-git> bitcoin/master b745e14 John Newbery: [docs] Expand help text for importmulti changes
< bitcoin-git> bitcoin/master f71c2ea Wladimir J. van der Laan: Merge #15122: [RPC] Expand help text for importmulti changes...
< dongcarl> w/re the banman PR, I'm not 100% sure about this discussion: https://github.com/bitcoin/bitcoin/pull/14605#discussion_r248050771
< bitcoin-git> [bitcoin] lontivero closed pull request #14939: rpc: Allow testmempoolaccept to test unsigned transactions (master...TestAcceptanceForUnsignedTransactions) https://github.com/bitcoin/bitcoin/pull/14939
< gribble> https://github.com/bitcoin/bitcoin/issues/14605 | Return of the Banman by dongcarl · Pull Request #14605 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14268: Introduce SafeDbt to handle Dbt with free or memory_cleanse raii-style (master...malloced-dbt) https://github.com/bitcoin/bitcoin/pull/14268
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/19c60ca4975d...d44b01f028e2
< bitcoin-git> bitcoin/master 951a44e Ben Woosley: Drop unused setRange arg to BerkeleyBatch::ReadAtCursor
< bitcoin-git> bitcoin/master 1a9f9f7 Ben Woosley: Introduce SafeDbt to handle DB_DBT_MALLOC raii-style...
< bitcoin-git> bitcoin/master 4a86a0a Ben Woosley: Make SafeDbt DB_DBT_MALLOC on default initialization...
< gribble> https://github.com/bitcoin/bitcoin/issues/14605 | Return of the Banman by dongcarl · Pull Request #14605 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64ee94356fb4...19c60ca4975d
< bitcoin-git> bitcoin/master b9dafe7 practicalswift: Fix remaining compiler warnings (MSVC). Move disabling of specific warnings from /nowarn to project file.
< bitcoin-git> bitcoin/master 19c60ca Wladimir J. van der Laan: Merge #14151: windows: Fix remaining compiler warnings (MSVC)...
< bitcoin-git> [bitcoin] laanwj closed pull request #14151: windows: Fix remaining compiler warnings (MSVC) (master...fix-remaining-compiler-warnings-msvc) https://github.com/bitcoin/bitcoin/pull/14151
< bitcoin-git> [bitcoin] laanwj closed pull request #14409: utils and libraries: Make 'blocksdir' always net specific (master...20181005-blockspath-always-netspecific) https://github.com/bitcoin/bitcoin/pull/14409
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ae3748ce1bd...64ee94356fb4
< bitcoin-git> bitcoin/master c3f1821 Hennadii Stepanov: Make blockdir always net specific...
< bitcoin-git> bitcoin/master e4a0c35 Hennadii Stepanov: Improve blocksdir functional test....
< bitcoin-git> bitcoin/master 64ee943 Wladimir J. van der Laan: Merge #14409: utils and libraries: Make 'blocksdir' always net specific...
< gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] hebasto opened pull request #15178: qt: Improve "help-console" message (master...20190116-improve-help-console) https://github.com/bitcoin/bitcoin/pull/15178
< bitcoin-git> [bitcoin] laanwj closed pull request #14958: qa: Remove race between connecting and shutdown on separate connections (master...2018-12-improve-shutdown-test) https://github.com/bitcoin/bitcoin/pull/14958
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/acec9e45c6fb...3ae3748ce1bd
< bitcoin-git> bitcoin/master 4412a59 João Barbosa: qa: Remove race between connecting and shutdown on separate connections
< bitcoin-git> bitcoin/master 3ae3748 Wladimir J. van der Laan: Merge #14958: qa: Remove race between connecting and shutdown on separate connections...
< gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15177: doc: Explain empty result of /rest/headers (master...2019-01-restheadersdoc) https://github.com/bitcoin/bitcoin/pull/15177
< bitcoin-git> [bitcoin] laanwj closed pull request #15136: qt: "Peers" tab overhaul (master...20190109-peerstab-overhaul) https://github.com/bitcoin/bitcoin/pull/15136
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bcdd31f26569...acec9e45c6fb
< bitcoin-git> bitcoin/master b0037c5 Hennadii Stepanov: Improve Peers tab layout...
< bitcoin-git> bitcoin/master 3537c83 Hennadii Stepanov: Do not deselect peer when switching away from tab...
< bitcoin-git> bitcoin/master acec9e4 Wladimir J. van der Laan: Merge #15136: qt: "Peers" tab overhaul...
< bitcoin-git> [bitcoin] laanwj closed pull request #15165: contrib: Allow use of github API authentication in github-merge (master...2019_01_ghmerge) https://github.com/bitcoin/bitcoin/pull/15165
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/16c4a5373b87...bcdd31f26569
< bitcoin-git> bitcoin/master 059a3cf Wladimir J. van der Laan: contrib: Detailed reporting for http errors in github-merge...
< bitcoin-git> bitcoin/master a4c5bbf Wladimir J. van der Laan: contrib: Add support for http[s] URLs in github-merge...
< bitcoin-git> bitcoin/master f1bd219 Wladimir J. van der Laan: contrib: Allow use of github API authentication in github-merge...
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/391a27376b30...16c4a5373b87
< bitcoin-git> bitcoin/master cbd9091 Vidar Holen: refactor/lint: Add ignored suggestions to an array...
< bitcoin-git> bitcoin/master 16c4a53 Wladimir J. van der Laan: Merge #15170: refactor/lint: Add ignored shellcheck suggestions to an array...
< bitcoin-git> [bitcoin] laanwj closed pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170
< bitcoin-git> [bitcoin] merland opened pull request #15176: Rename README_osx.md (master...rename-osx-readme) https://github.com/bitcoin/bitcoin/pull/15176
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15002 | 0.17: Backport #14941 by promag · Pull Request #15002 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact opened pull request #15175: build: Drop macports support (master...drop-macports) https://github.com/bitcoin/bitcoin/pull/15175
< gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub

2019-01-15

< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7c84209bb0a...391a27376b30
< bitcoin-git> bitcoin/master 04215eb Sjors Provoost: [doc] explain what .python-version does
< bitcoin-git> bitcoin/master 391a273 MarcoFalke: Merge #15173: [doc] explain what .python-version does...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173
< bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/82ffd4d91832...c7c84209bb0a
< bitcoin-git> bitcoin/master f411c8b João Barbosa: gui: Remove unused return type in some BitcoinGUI methods
< bitcoin-git> bitcoin/master 8a79261 João Barbosa: gui: Keep network style in BitcoinGUI
< bitcoin-git> bitcoin/master fe7048b João Barbosa: gui: Show current wallet name in window title
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #15149: gui: Show current wallet name in window title (master...2019-01-updatewindowtitle) https://github.com/bitcoin/bitcoin/pull/15149
< bitcoin-git> [bitcoin] Sjors opened pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/eb2aecfb8066...82ffd4d91832
< bitcoin-git> bitcoin/master fac4558 MarcoFalke: sync: Add RecursiveMutex type alias
< bitcoin-git> bitcoin/master fafe941 MarcoFalke: test: Add missing validation locks
< bitcoin-git> bitcoin/master fa5c346 MarcoFalke: doc: Add comment to cs_main and mempool::cs
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14963: mempool, validation: Explain cs_main locking semantics (master...Mf1812-docValLocks) https://github.com/bitcoin/bitcoin/pull/14963
< dongcarl> Anything else that needs doing for: https://github.com/bitcoin/bitcoin/pull/12255
< bitcoin-git> [bitcoin] laanwj closed pull request #14433: Add checksum in gitian build scripts for ossl (master...osslChecksum) https://github.com/bitcoin/bitcoin/pull/14433
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8ad580f5153...eb2aecfb8066
< bitcoin-git> bitcoin/master 03b8596 TheCharlatan: Add checksum in gitian build scripts for ossl...
< bitcoin-git> bitcoin/master eb2aecf Wladimir J. van der Laan: Merge #14433: Add checksum in gitian build scripts for ossl...
< bitcoin-git> [bitcoin] laanwj closed pull request #14556: qt: fix confirmed transaction labeled "open" (#13299) (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5daf70ffb80...e8ad580f5153
< bitcoin-git> bitcoin/master fb3ce75 Hennadii Stepanov: Don't label transactions "Open" while catching up...
< bitcoin-git> bitcoin/master e8ad580 Wladimir J. van der Laan: Merge #14556: qt: fix confirmed transaction labeled "open" (#13299)...
< gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14151 | windows: Fix remaining compiler warnings (MSVC) by practicalswift · Pull Request #14151 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14458 | WIP: Add JSON-RPC interface documentation by promag · Pull Request #14458 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #14965: minor: fix extra "non" in source code comment (master...minor-comment-double-negation) https://github.com/bitcoin/bitcoin/pull/14965
< bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
< bitcoin-git> [bitcoin] laanwj closed pull request #14594: qt: Fix minimized window bug on Linux (master...20181028-restore-minimized) https://github.com/bitcoin/bitcoin/pull/14594
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b6fc3053045...a5daf70ffb80
< bitcoin-git> bitcoin/master a88640e Hennadii Stepanov: Fix minimized window bug on Linux...
< bitcoin-git> bitcoin/master a5daf70 Wladimir J. van der Laan: Merge #14594: qt: Fix minimized window bug on Linux...
< bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
< bitcoin-git> [bitcoin] Mr-Leshiy reopened pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
< wumpus> whoa, bitcoin-git is *working* again
< bitcoin-git> [bitcoin] laanwj closed pull request #14941: rpc: Make unloadwallet wait for complete wallet unload (master...2018-12-sync-unloadwallet) https://github.com/bitcoin/bitcoin/pull/14941
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf0c67b62c20...1b6fc3053045
< bitcoin-git> bitcoin/master c37851d João Barbosa: rpc: Make unloadwallet wait for complete wallet unload
< bitcoin-git> bitcoin/master 645e905 João Barbosa: doc: Add release notes for unloadwallet change to synchronous call
< bitcoin-git> bitcoin/master 1b6fc30 Wladimir J. van der Laan: Merge #14941: rpc: Make unloadwallet wait for complete wallet unload...
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact opened pull request #15171: test: Wait before cleanup on exit (master...test-wait-cleanup) https://github.com/bitcoin/bitcoin/pull/15171
< bitcoin-git> [bitcoin] koalaman opened pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15169: WIP: Parallelize CheckInputs() in AcceptToMemoryPool() (master...2018-12-parallel-mempool-scriptchecks) https://github.com/bitcoin/bitcoin/pull/15169
< kanzure> /join #bitcoin-wizards

2019-01-14

< gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #15107: rest: Return 404 in /rest/headers if block hash does not exists (master...2019-rest-header-404) https://github.com/bitcoin/bitcoin/pull/15107
< gribble> https://github.com/bitcoin/bitcoin/issues/15149 | gui: Show current wallet name in window title by promag · Pull Request #15149 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/54 | do not create "Your Address" account when creating a new wallet by tcatm · Pull Request #54 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/54 | do not create "Your Address" account when creating a new wallet by tcatm · Pull Request #54 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15104 | Tests: Add unit testing for the CompressScript function by mmachicao · Pull Request #15104 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15104 | Tests: Add unit testing for the CompressScript function by mmachicao · Pull Request #15104 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15164 | qa: Ignore shellcheck warning SC2236 by promag · Pull Request #15164 · bitcoin/bitcoin · GitHub
< pbase> what should be the starting point to start understanding the bitcoin-core code?
< booyah> fyi going to "http://bitcoin.sipa.be/depths.png" --> "Warning: Unsafe Website Blocked!" (I was redirected to http://warn.recursive.dnsbycomodo.com/?host=bitcoin.sipa.be )
< phantomcircuit> gmaxwell, im talking about bitcoin.sipa.be, which isn't the thing resolving to weird stuff
< sipa> but maybe by being similar to seed.bitcoin.sipa.be ?
< phantomcircuit> bitcoin.sipa.be

2019-01-13

< gribble> https://github.com/bitcoin/bitcoin/issues/15149 | gui: Show current wallet name in window title by promag · Pull Request #15149 · bitcoin/bitcoin · GitHub

2019-01-12

< luke-jr> CODER82: your question doesn't really make sense, and in any case belongs in #bitcoin
< TokenHash> "money is a social system, therefore it's ok to integrate social management tools in Bitcoin such as 'invalidateblock' and others" is a fallacy.
< gmaxwell> if the signature is correct, you're good to go, unfortunately people maliciously submit bitcoin core as viruses to av companies and they don't give a crap about giving accurate results...
< CODER82> fa1e80c5e4ecc705549a8061e5e7e0aa6b2d26967f99681b5989d9bd938d8467 bitcoin-0.17.1-win64-setup.exe
< gribble> https://github.com/bitcoin/bitcoin/issues/15149 | gui: Show current wallet name in window title by promag · Pull Request #15149 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15150 | gui: Show wallet selector on console window if there are wallets loaded by promag · Pull Request #15150 · bitcoin/bitcoin · GitHub

2019-01-11

< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< promag> sipa: ping https://github.com/bitcoin/bitcoin/pull/15107#issuecomment-452821812 in case you missed the notification
< gribble> https://github.com/bitcoin/bitcoin/issues/10540 | [WIP] Salvage wallet should not set the aggressive flag on Db::verify() by jnewbery · Pull Request #10540 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/8745 | [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" by jonasschnelli · Pull Request #8745 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10991 | -salvagewallet seems to be causing more issues than it fixes, it should be removed · Issue #10991 · bitcoin/bitcoin · GitHub

2019-01-10

< hidden> it's not a HD wallet as you might have guessd. the link i posted (https://github.com/bitcoin/bitcoin/issues/7463#issuecomment-306336149) details the exact issue.
< hidden> https://github.com/bitcoin/bitcoin/issues/7463#issuecomment-306336149 does anybody know how i could recover keys from keypool that has been damaged in relation to this issue?
< gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
< achow101> so hwi is currently under my account. but if we are going to use it for hardware wallet support in core, then perhaps it would be better to have it under a proper github org. the obvious one that comes to mind is bitcoin-core
< wumpus> #topic moving hwi under bitcoin-core org (achow101)
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub